Fix buffer_view validation tests (#4686)
* bufferView and bufferArrayView tests had invalid checks for the
parameter type tests (copypasta)
diff --git a/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts b/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts
index aa6ee20..1bc5196 100644
--- a/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts
+++ b/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts
@@ -135,11 +135,9 @@
.desc('Validates the offset parameter type')
.params(u => u.combine('type', keysOf(kTypes)))
.fn(t => {
+ t.skipIfLanguageFeatureNotSupported('buffer_view');
const type = kTypes[t.params.type];
- let enables = `enable subgroups;\n`;
- if (type.requiresF16()) {
- enables += `enable f16;`;
- }
+ const enables = type.requiresF16() ? 'enable f16;' : '';
const wgsl = `
${enables}
@group(0) @binding(0) var<storage> v : buffer;
@@ -158,11 +156,9 @@
.desc('Validates the offset parameter type')
.params(u => u.combine('type', keysOf(kTypes)))
.fn(t => {
+ t.skipIfLanguageFeatureNotSupported('buffer_view');
const type = kTypes[t.params.type];
- let enables = `enable subgroups;\n`;
- if (type.requiresF16()) {
- enables += `enable f16;`;
- }
+ const enables = type.requiresF16() ? 'enable f16;' : '';
const wgsl = `
${enables}
@group(0) @binding(0) var<storage> v : buffer;
diff --git a/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts b/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts
index 50dbf12..f90a784 100644
--- a/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts
+++ b/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts
@@ -129,11 +129,9 @@
.desc('Validates the offset parameter type')
.params(u => u.combine('type', keysOf(kTypes)))
.fn(t => {
+ t.skipIfLanguageFeatureNotSupported('buffer_view');
const type = kTypes[t.params.type];
- let enables = `enable subgroups;\n`;
- if (type.requiresF16()) {
- enables += `enable f16;`;
- }
+ const enables = type.requiresF16() ? 'enable f16;' : '';
const wgsl = `
${enables}
@group(0) @binding(0) var<storage> v : buffer;