Automatic code cleanup. PiperOrigin-RevId: 316207121
diff --git a/annotations/src/main/java/com/google/errorprone/annotations/RestrictedApi.java b/annotations/src/main/java/com/google/errorprone/annotations/RestrictedApi.java index 80e4c35..3715706 100644 --- a/annotations/src/main/java/com/google/errorprone/annotations/RestrictedApi.java +++ b/annotations/src/main/java/com/google/errorprone/annotations/RestrictedApi.java
@@ -106,5 +106,4 @@ * ignored, so tread very carefully. */ Class<? extends Annotation>[] whitelistWithWarningAnnotations() default {}; - }
diff --git a/check_api/src/main/java/com/google/errorprone/matchers/Matchers.java b/check_api/src/main/java/com/google/errorprone/matchers/Matchers.java index 56b60cd..afc5135 100644 --- a/check_api/src/main/java/com/google/errorprone/matchers/Matchers.java +++ b/check_api/src/main/java/com/google/errorprone/matchers/Matchers.java
@@ -1306,7 +1306,6 @@ } } - /** Matches an AST node whose compilation unit's package name matches the given pattern. */ public static <T extends Tree> Matcher<T> packageMatches(Pattern pattern) { return (tree, state) -> pattern.matcher(getPackageFullName(state)).matches();
diff --git a/check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java b/check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java index b8dca14..70a765f 100644 --- a/check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java +++ b/check_api/src/main/java/com/google/errorprone/scanner/ErrorProneScanner.java
@@ -17,7 +17,6 @@ package com.google.errorprone.scanner; -import com.google.common.base.Supplier; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.errorprone.BugPattern;
diff --git a/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java b/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java index 3dc90fd..9347ac9 100644 --- a/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java +++ b/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java
@@ -1308,7 +1308,6 @@ .collect(toImmutableSet()); } - /** * Returns the values of the given symbol's {@code javax.annotation.Generated} or {@code * javax.annotation.processing.Generated} annotation, if present.
diff --git a/check_api/src/main/java/com/google/errorprone/util/Visibility.java b/check_api/src/main/java/com/google/errorprone/util/Visibility.java index bfe90c8..e0c5ebb 100644 --- a/check_api/src/main/java/com/google/errorprone/util/Visibility.java +++ b/check_api/src/main/java/com/google/errorprone/util/Visibility.java
@@ -20,7 +20,6 @@ import static com.google.errorprone.util.ASTHelpers.getSymbol; import static com.google.errorprone.util.ASTHelpers.getType; -import com.google.common.annotations.VisibleForTesting; import com.google.errorprone.VisitorState; import com.sun.source.tree.ClassTree; import com.sun.source.tree.ExpressionTree; @@ -218,7 +217,6 @@ return Visibility.PACKAGE_PRIVATE; } - public boolean isAtLeastAsRestrictiveAs(Visibility visibility) { return compareTo(visibility) <= 0; }
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/AbstractReturnValueIgnored.java b/core/src/main/java/com/google/errorprone/bugpatterns/AbstractReturnValueIgnored.java index a8469eb..078ae8f 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/AbstractReturnValueIgnored.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/AbstractReturnValueIgnored.java
@@ -259,5 +259,4 @@ ExpressionTree receiver = ASTHelpers.getReceiver(invocation); return MOCKITO_MATCHER.matches(receiver, state); } - }
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java index c55a65f..dfbb585 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java
@@ -17,7 +17,6 @@ import static com.google.errorprone.BugPattern.SeverityLevel.SUGGESTION; import static com.google.errorprone.util.ASTHelpers.getSymbol; -import static com.google.errorprone.util.ASTHelpers.hasAnnotation; import com.google.common.collect.ImmutableSet; import com.google.errorprone.BugPattern; @@ -311,7 +310,6 @@ return null; } - for (String annotation : IMPLICIT_VAR_CLASS_ANNOTATIONS) { if (ASTHelpers.hasAnnotation(getSymbol(node), annotation, state)) { return null; @@ -338,5 +336,4 @@ return super.visitUnary(node, init); } } - }
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeLocal.java b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeLocal.java index 755324e..6538479 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeLocal.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeLocal.java
@@ -108,7 +108,6 @@ return !Sets.intersection(VALID_ON_LOCAL_VARIABLES, ImmutableSet.copyOf(target.value())) .isEmpty(); } - }.scan(state.getPath(), null); new TreePathScanner<Void, Void>() {
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/InsecureCipherMode.java b/core/src/main/java/com/google/errorprone/bugpatterns/InsecureCipherMode.java index 4e869a8..9fdf907 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/InsecureCipherMode.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/InsecureCipherMode.java
@@ -50,7 +50,6 @@ staticMethod().onClass("java.security.KeyFactory").named("getInstance"), staticMethod().onClass("javax.crypto.KeyAgreement").named("getInstance")); - private Description buildErrorMessage(MethodInvocationTree tree, String explanation) { Description.Builder description = buildDescription(tree); String message = MESSAGE_BASE + explanation + "."; @@ -134,7 +133,6 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) { Description description = checkInvocation(tree, state); - return description; }
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/JUnit4TestNotRun.java b/core/src/main/java/com/google/errorprone/bugpatterns/JUnit4TestNotRun.java index 2bae2c1..3527ea7 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/JUnit4TestNotRun.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/JUnit4TestNotRun.java
@@ -75,7 +75,6 @@ private static final Matcher<Tree> NOT_STATIC = not(hasModifier(STATIC)); - @Override public Description matchClass(ClassTree tree, VisitorState state) { if (!isJUnit4TestClass.matches(tree, state)) { @@ -135,7 +134,6 @@ return Optional.of(describeFixes(methodTree, state)); } - // Method is annotated, probably not a test. List<? extends AnnotationTree> annotations = methodTree.getModifiers().getAnnotations(); if (annotations != null && !annotations.isEmpty()) {
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/OrphanedFormatString.java b/core/src/main/java/com/google/errorprone/bugpatterns/OrphanedFormatString.java index 9cb9cbc..c543446 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/OrphanedFormatString.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/OrphanedFormatString.java
@@ -73,7 +73,6 @@ .named("append") .withParameters("java.lang.CharSequence", "int", "int"))); - @Override public Description matchLiteral(LiteralTree tree, VisitorState state) { Object value = tree.getValue();
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ParametersButNotParameterized.java b/core/src/main/java/com/google/errorprone/bugpatterns/ParametersButNotParameterized.java index bcf23cb..eb4495d 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/ParametersButNotParameterized.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/ParametersButNotParameterized.java
@@ -43,7 +43,6 @@ private static final String PARAMETER = "org.junit.runners.Parameterized.Parameter"; private static final String PARAMETERS = "org.junit.runners.Parameterized.Parameters"; - @Override public Description matchClass(ClassTree tree, VisitorState state) { if (!hasJUnit4TestRunner.matches(tree, state)) {
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccess.java b/core/src/main/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccess.java index e5b039a..584db4b 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccess.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccess.java
@@ -59,7 +59,6 @@ createFieldMatcher("com.google.common.html.types.SafeStyleSheetProto")), not(packageStartsWith("com.google.common.html.types"))); - private static final String MESSAGE = "Forbidden access to a private proto field. See "; private static final String SAFEHTML_LINK = "https://github.com/google/safe-html-types/blob/master/doc/safehtml-types.md#protocol-buffer-conversion";
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java index 2401720..3682edd 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java
@@ -73,7 +73,6 @@ private static final String JUNIT_PARAMS_VALUE = "value"; private static final String JUNIT_PARAMS_ANNOTATION_TYPE = "junitparams.Parameters"; - private static final ImmutableSet<String> EXEMPTING_METHOD_ANNOTATIONS = ImmutableSet.of( "com.google.inject.Provides",
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java index 5ba9f4d..a248fa9 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java
@@ -119,7 +119,6 @@ private static final ImmutableSet<String> EXEMPT_NAMES = ImmutableSet.of("ignored"); - /** * The set of annotation full names which exempt annotated element from being reported as unused. */ @@ -622,7 +621,6 @@ } } - return enclosingMethod.getModifiers().contains(Modifier.PRIVATE); }
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/android/StaticOrDefaultInterfaceMethod.java b/core/src/main/java/com/google/errorprone/bugpatterns/android/StaticOrDefaultInterfaceMethod.java index fa7f527..875e8cd 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/android/StaticOrDefaultInterfaceMethod.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/android/StaticOrDefaultInterfaceMethod.java
@@ -39,7 +39,8 @@ @BugPattern( name = "StaticOrDefaultInterfaceMethod", summary = - "Static and default interface methods are not natively supported on older Android devices. ", + "Static and default interface methods are not natively supported on older Android devices. " + , severity = ERROR, documentSuppression = false // for slightly customized suppression documentation )
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/formatstring/FormatStringValidation.java b/core/src/main/java/com/google/errorprone/bugpatterns/formatstring/FormatStringValidation.java index 074f5ba..57393f9 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/formatstring/FormatStringValidation.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/formatstring/FormatStringValidation.java
@@ -16,7 +16,6 @@ package com.google.errorprone.bugpatterns.formatstring; -import static com.google.common.collect.Iterables.getOnlyElement; import com.google.auto.value.AutoValue; import com.google.common.base.Preconditions;
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/inject/CloseableProvides.java b/core/src/main/java/com/google/errorprone/bugpatterns/inject/CloseableProvides.java index dab6b33..aac28b8 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/inject/CloseableProvides.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/inject/CloseableProvides.java
@@ -19,7 +19,6 @@ import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.methodReturns; -import static com.google.errorprone.matchers.Matchers.not; import com.google.errorprone.BugPattern; import com.google.errorprone.VisitorState;
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/inject/ScopeOrQualifierAnnotationRetention.java b/core/src/main/java/com/google/errorprone/bugpatterns/inject/ScopeOrQualifierAnnotationRetention.java index f58e070..b469ca4 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/inject/ScopeOrQualifierAnnotationRetention.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/inject/ScopeOrQualifierAnnotationRetention.java
@@ -25,7 +25,6 @@ import static com.google.errorprone.matchers.Matchers.anyOf; import static com.google.errorprone.matchers.Matchers.hasAnnotation; import static com.google.errorprone.matchers.Matchers.kindIs; -import static com.google.errorprone.matchers.Matchers.not; import static com.sun.source.tree.Tree.Kind.ANNOTATION_TYPE; import com.google.errorprone.BugPattern;
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/WellKnownMutability.java b/core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/WellKnownMutability.java index 5cc35a7..6338b86 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/WellKnownMutability.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/WellKnownMutability.java
@@ -47,7 +47,6 @@ /** Types that are known to be mutable. */ private final ImmutableSet<String> knownUnsafeClasses; - private WellKnownMutability(List<String> knownImmutable, List<String> knownUnsafe) { knownImmutableClasses = buildImmutableClasses(knownImmutable); knownUnsafeClasses = buildUnsafeClasses(knownUnsafe);
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BigDecimalEqualsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BigDecimalEqualsTest.java index e1cfc43..b1ffd2a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/BigDecimalEqualsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/BigDecimalEqualsTest.java
@@ -48,7 +48,6 @@ .doTest(); } - @Test public void negative() { CompilationTestHelper.newInstance(BigDecimalEquals.class, getClass())
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java index c63115c..3aa276b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java
@@ -38,7 +38,6 @@ compilationHelper.addSourceFile("ByteBufferBackingArrayNegativeCases.java").doTest(); } - @Test public void i1004() { compilationHelper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java index dde75c8..29711c1 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java
@@ -643,5 +643,4 @@ .withClasspath(CRVTest.class, CheckReturnValueTest.class) .doTest(); } - }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java index cb1f67d..4b75983 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java
@@ -312,7 +312,6 @@ .doTest(); } - @Test public void allowNonFinal_nonFinalForTesting() { compilationHelper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeLocalTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeLocalTest.java index c03962b..639abb2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeLocalTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeLocalTest.java
@@ -468,5 +468,4 @@ "}") .doTest(); } - }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java index 940d1d0..566eb64 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java
@@ -39,7 +39,6 @@ compilationHelper.addSourceFile("FutureReturnValueIgnoredNegativeCases.java").doTest(); } - @Test public void testClassAnnotationButCanIgnoreReturnValue() { compilationHelper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/IgnoredPureGetterTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/IgnoredPureGetterTest.java index d6e8b35..8c951f9 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/IgnoredPureGetterTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/IgnoredPureGetterTest.java
@@ -79,7 +79,6 @@ .doTest(); } - @Test public void protoReturnValueIgnored_noFinding() { helper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java index 1e11466..1e47c67 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java
@@ -264,7 +264,6 @@ .doTest(); } - @Test public void hasOtherAnnotation_notATest() { compilationHelper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java index 779bbbd..8a52a88 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java
@@ -76,7 +76,6 @@ .doTest(); } - @Test public void testNegativeCaseJDK8OrEarlier() { assumeFalse(RuntimeVersion.isAtLeast9());
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/LiteProtoToStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/LiteProtoToStringTest.java index 842e19d..0220970 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/LiteProtoToStringTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/LiteProtoToStringTest.java
@@ -121,7 +121,6 @@ .doTest(); } - @Test public void androidLogAtInfoOrFiner_noWarning() { compilationHelper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MathAbsoluteRandomTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MathAbsoluteRandomTest.java index bba9078..b519dfa 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/MathAbsoluteRandomTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/MathAbsoluteRandomTest.java
@@ -59,7 +59,6 @@ .doTest(); } - @Test public void negativeNumber() { helper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ParametersButNotParameterizedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ParametersButNotParameterizedTest.java index 61ddc0e..32f585b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ParametersButNotParameterizedTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ParametersButNotParameterizedTest.java
@@ -82,5 +82,4 @@ "}") .doTest(); } - }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java index d822a5c..db5d45b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java
@@ -229,5 +229,4 @@ "}") .doTest(); } - }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/StreamToIterableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/StreamToIterableTest.java index 87410f7..faaa29d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/StreamToIterableTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/StreamToIterableTest.java
@@ -58,7 +58,6 @@ .doTest(); } - @Test public void methodReferenceRefactoredToExplicitCollection() { refactoring
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedMethodTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedMethodTest.java index 57b715d..ef33985 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedMethodTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedMethodTest.java
@@ -30,8 +30,6 @@ private final BugCheckerRefactoringTestHelper refactoringHelper = BugCheckerRefactoringTestHelper.newInstance(new UnusedMethod(), getClass()); - - @Test public void unusedNative() { helper @@ -44,7 +42,6 @@ .doTest(); } - @Test public void unuseds() { helper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedNestedClassTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedNestedClassTest.java index 621869b..1272426 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedNestedClassTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedNestedClassTest.java
@@ -105,7 +105,6 @@ .doTest(); } - @Test public void refactoring() { BugCheckerRefactoringTestHelper.newInstance(new UnusedNestedClass(), getClass())
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java index 4e423fe..94f1cca 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java
@@ -35,7 +35,6 @@ BugCheckerRefactoringTestHelper.newInstance( new UnusedVariable(ErrorProneFlags.empty()), getClass()); - @Test public void exemptedByReceiverParameter() { helper @@ -58,7 +57,6 @@ .doTest(); } - @Test public void unicodeBytes() { helper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/UseBindsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/UseBindsTest.java index 6ad6d31..5f8350e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/UseBindsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/UseBindsTest.java
@@ -239,5 +239,4 @@ .expectUnchanged() .doTest(); } - }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidLinkTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidLinkTest.java index 5441f8f..5fee5d2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidLinkTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidLinkTest.java
@@ -71,7 +71,6 @@ .doTest(TEXT_MATCH); } - @Test public void badMethodLink() { helper
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModeNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModeNegativeCases.java index 3193569..717b27c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModeNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModeNegativeCases.java
@@ -157,5 +157,4 @@ // We don't handle any exception as this code is not meant to be executed. } } - }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RestrictedApiMethods.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RestrictedApiMethods.java index 4d3ff0a..a1d30b2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RestrictedApiMethods.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RestrictedApiMethods.java
@@ -62,7 +62,6 @@ return 2; } - @Override public void dontCallMe() {}
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ImmutableCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ImmutableCheckerTest.java index 02e4d63..f2e2afb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ImmutableCheckerTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ImmutableCheckerTest.java
@@ -21,7 +21,6 @@ import com.google.errorprone.annotations.Immutable; import com.google.errorprone.annotations.concurrent.LazyInit; import java.util.Arrays; -import java.util.List; import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; @@ -1201,7 +1200,6 @@ .doTest(); } - // any final null reference constant is immutable, but do we actually care? // // javac makes it annoying to figure this out - since null isn't a compile-time constant,
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/time/StronglyTypeTimeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/time/StronglyTypeTimeTest.java index 1102aa6..155ff83 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/time/StronglyTypeTimeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/time/StronglyTypeTimeTest.java
@@ -63,7 +63,6 @@ .doTest(); } - @Test public void jodaInstant() { refactoringHelper
diff --git a/docgen/src/main/java/com/google/errorprone/DocGenTool.java b/docgen/src/main/java/com/google/errorprone/DocGenTool.java index 44a8d91..54deb75 100644 --- a/docgen/src/main/java/com/google/errorprone/DocGenTool.java +++ b/docgen/src/main/java/com/google/errorprone/DocGenTool.java
@@ -133,7 +133,6 @@ } } - private static ImmutableSet<String> enabledCheckNames() { return StreamSupport.stream( Iterables.concat(
diff --git a/docgen/src/main/java/com/google/errorprone/resources/bugpattern.mustache b/docgen/src/main/java/com/google/errorprone/resources/bugpattern.mustache index 8f68f5e..1d3b355 100644 --- a/docgen/src/main/java/com/google/errorprone/resources/bugpattern.mustache +++ b/docgen/src/main/java/com/google/errorprone/resources/bugpattern.mustache
@@ -35,4 +35,3 @@ ## Suppression {{{suppression}}} {{/suppression}} -
diff --git a/docgen/src/test/java/com/google/errorprone/testdata/DeadException_frontmatter_pygments.md b/docgen/src/test/java/com/google/errorprone/testdata/DeadException_frontmatter_pygments.md index 68718f1..343b755 100644 --- a/docgen/src/test/java/com/google/errorprone/testdata/DeadException_frontmatter_pygments.md +++ b/docgen/src/test/java/com/google/errorprone/testdata/DeadException_frontmatter_pygments.md
@@ -19,7 +19,6 @@ ## Suppression Suppress false positives by adding the suppression annotation `@SuppressWarnings("DeadException")` to the enclosing element. - ---------- ### Positive examples
diff --git a/docgen/src/test/java/com/google/errorprone/testdata/DeadException_nofrontmatter_gfm.md b/docgen/src/test/java/com/google/errorprone/testdata/DeadException_nofrontmatter_gfm.md index ada82cc..fbe59d5 100644 --- a/docgen/src/test/java/com/google/errorprone/testdata/DeadException_nofrontmatter_gfm.md +++ b/docgen/src/test/java/com/google/errorprone/testdata/DeadException_nofrontmatter_gfm.md
@@ -20,7 +20,6 @@ ## Suppression Suppress false positives by adding the suppression annotation `@SuppressWarnings("DeadException")` to the enclosing element. - ---------- ### Positive examples
diff --git a/docgen/src/test/java/com/google/errorprone/testdata/DontDoThis_nofrontmatter_gfm.md b/docgen/src/test/java/com/google/errorprone/testdata/DontDoThis_nofrontmatter_gfm.md index ea7d776..25c4a43 100644 --- a/docgen/src/test/java/com/google/errorprone/testdata/DontDoThis_nofrontmatter_gfm.md +++ b/docgen/src/test/java/com/google/errorprone/testdata/DontDoThis_nofrontmatter_gfm.md
@@ -18,4 +18,3 @@ ## Suppression Suppress false positives by adding the suppression annotation `@SuppressWarnings("DontDoThis")` to the enclosing element. -
diff --git a/docs/bugpattern/AndroidJdkLibsChecker.md b/docs/bugpattern/AndroidJdkLibsChecker.md index 816b210..b6811c0 100644 --- a/docs/bugpattern/AndroidJdkLibsChecker.md +++ b/docs/bugpattern/AndroidJdkLibsChecker.md
@@ -15,4 +15,3 @@ ``` @SuppressWarnings("AndroidJdkLibsChecker") // TODO({{USERNAME}}): document suppression ``` -
diff --git a/docs/bugpattern/AssignmentToMock.md b/docs/bugpattern/AssignmentToMock.md index 2e7b880..7ea4d2b 100644 --- a/docs/bugpattern/AssignmentToMock.md +++ b/docs/bugpattern/AssignmentToMock.md
@@ -3,4 +3,3 @@ Variables annotated this way should not be explicitly initialized, as this will be overwritten by automatic initialization. -
diff --git a/docs/bugpattern/BigDecimalEquals.md b/docs/bugpattern/BigDecimalEquals.md index 8d8f53a..e817876 100644 --- a/docs/bugpattern/BigDecimalEquals.md +++ b/docs/bugpattern/BigDecimalEquals.md
@@ -6,4 +6,3 @@ BigDecimal b = new BigDecimal("1.00"); a.equals(b); // false! ``` -
diff --git a/docs/bugpattern/BooleanParameter.md b/docs/bugpattern/BooleanParameter.md index 8b13789..e69de29 100644 --- a/docs/bugpattern/BooleanParameter.md +++ b/docs/bugpattern/BooleanParameter.md
@@ -1 +0,0 @@ -
diff --git a/docs/bugpattern/CatchAndPrintStackTrace.md b/docs/bugpattern/CatchAndPrintStackTrace.md index f39d22a..cf6b518 100644 --- a/docs/bugpattern/CatchAndPrintStackTrace.md +++ b/docs/bugpattern/CatchAndPrintStackTrace.md
@@ -1,7 +1,6 @@ Discarding an exception after calling `printStackTrace` should usually be avoided. - ```java try { // ...
diff --git a/docs/bugpattern/ComparisonContractViolated.md b/docs/bugpattern/ComparisonContractViolated.md index 09d2735..3ea9dfe 100644 --- a/docs/bugpattern/ComparisonContractViolated.md +++ b/docs/bugpattern/ComparisonContractViolated.md
@@ -11,4 +11,3 @@ In the long term, essentially all Comparators should be rewritten to use the Java 8 Comparator factory methods, but our automated migration tools will, of course, only work for correctly implemented Comparators. -
diff --git a/docs/bugpattern/CompileTimeConstant.md b/docs/bugpattern/CompileTimeConstant.md index d37316e..d98e84a 100644 --- a/docs/bugpattern/CompileTimeConstant.md +++ b/docs/bugpattern/CompileTimeConstant.md
@@ -7,6 +7,5 @@ disallowed because we couldn't check if the method reference is later applied to a compile-time constant. Use the methods directly instead. - For the same reason, it's also disallowed to create lambda expressions with `@CompileTimeConstant` parameters.
diff --git a/docs/bugpattern/DefaultCharset.md b/docs/bugpattern/DefaultCharset.md index 392361f..403f01c 100644 --- a/docs/bugpattern/DefaultCharset.md +++ b/docs/bugpattern/DefaultCharset.md
@@ -19,4 +19,3 @@ When in doubt, use [UTF-8]. [UTF-8]: http://www.utf8everywhere.org/ -
diff --git a/docs/bugpattern/DefaultPackage.md b/docs/bugpattern/DefaultPackage.md index 22fcff4..8dd3b3b 100644 --- a/docs/bugpattern/DefaultPackage.md +++ b/docs/bugpattern/DefaultPackage.md
@@ -1,2 +1 @@ Declaring classes in the default package is discouraged. -
diff --git a/docs/bugpattern/DoubleBraceInitialization.md b/docs/bugpattern/DoubleBraceInitialization.md index 99b86aa..993e33c 100644 --- a/docs/bugpattern/DoubleBraceInitialization.md +++ b/docs/bugpattern/DoubleBraceInitialization.md
@@ -42,5 +42,4 @@ initialize `List`s and `Set`s with `null` values, and refactoring `Map` initializers into a helper method. - [dbi]: https://stackoverflow.com/questions/1958636/what-is-double-brace-initialization-in-java
diff --git a/docs/bugpattern/ExpectedExceptionChecker.md b/docs/bugpattern/ExpectedExceptionChecker.md index 424bf62..a690d3a 100644 --- a/docs/bugpattern/ExpectedExceptionChecker.md +++ b/docs/bugpattern/ExpectedExceptionChecker.md
@@ -1,5 +1,4 @@ - Any additional statements after the statement that is expected to throw will never be executed in a passing test. This can lead to inappropriately passing tests where later incorrect assertions are skipped by the thrown exception. For
diff --git a/docs/bugpattern/FieldCanBeLocal.md b/docs/bugpattern/FieldCanBeLocal.md index 9e0482a..8e368a1 100644 --- a/docs/bugpattern/FieldCanBeLocal.md +++ b/docs/bugpattern/FieldCanBeLocal.md
@@ -35,4 +35,3 @@ This check is suppressed by `@SuppressWarnings("FieldCanBeLocal")` as well as the same suppression mechanisms as `UnusedVariable` (`@SuppressWarnings("unused")`. -
diff --git a/docs/bugpattern/FieldMissingNullable.md b/docs/bugpattern/FieldMissingNullable.md index 8abf525..4e6f18a 100644 --- a/docs/bugpattern/FieldMissingNullable.md +++ b/docs/bugpattern/FieldMissingNullable.md
@@ -1,5 +1,4 @@ - Fields that may be `null` should be annotated with `@Nullable`. For example, do this:
diff --git a/docs/bugpattern/FormatStringAnnotation.md b/docs/bugpattern/FormatStringAnnotation.md index 2950cf0..e199e22 100644 --- a/docs/bugpattern/FormatStringAnnotation.md +++ b/docs/bugpattern/FormatStringAnnotation.md
@@ -36,7 +36,6 @@ import com.google.errorprone.annotations.FormatMethod; ``` - ## Suppression Suppress false positives by adding the suppression annotation
diff --git a/docs/bugpattern/ImmutableEnumChecker.md b/docs/bugpattern/ImmutableEnumChecker.md index 65e78ad..e0efeb7 100644 --- a/docs/bugpattern/ImmutableEnumChecker.md +++ b/docs/bugpattern/ImmutableEnumChecker.md
@@ -134,4 +134,3 @@ you to a particular functional interface type -- your callers should e.g. use `STRING::hasCompatibleType` instead of `STRING.hasCompatibleType` which only works for one interface type. -
diff --git a/docs/bugpattern/InconsistentOverloads.md b/docs/bugpattern/InconsistentOverloads.md index 9c696ce..1d70965 100644 --- a/docs/bugpattern/InconsistentOverloads.md +++ b/docs/bugpattern/InconsistentOverloads.md
@@ -26,4 +26,3 @@ support they will most likely do it like `foo(bar, "quux", "norf")`. The compiler will accept this because the types match perfectly. However, this is clearly a bug caused by unintuitive API and method overloading. -
diff --git a/docs/bugpattern/InsecureCryptoUsage.md b/docs/bugpattern/InsecureCryptoUsage.md index 47522ea..9b2c91b 100644 --- a/docs/bugpattern/InsecureCryptoUsage.md +++ b/docs/bugpattern/InsecureCryptoUsage.md
@@ -22,4 +22,3 @@ * Using DSA for digital signatures. Some widely used crypto libraries accept invalid DSA signatures in specific configurations. The checker will flag all cryptographic operations that may involve DSA. -
diff --git a/docs/bugpattern/InterfaceWithOnlyStatics.md b/docs/bugpattern/InterfaceWithOnlyStatics.md index d0801b6..144929c 100644 --- a/docs/bugpattern/InterfaceWithOnlyStatics.md +++ b/docs/bugpattern/InterfaceWithOnlyStatics.md
@@ -18,4 +18,3 @@ private Constants() {} } ``` -
diff --git a/docs/bugpattern/LeakingForkedAndroidBundle.md b/docs/bugpattern/LeakingForkedAndroidBundle.md index 6d088b1..6c8a799 100644 --- a/docs/bugpattern/LeakingForkedAndroidBundle.md +++ b/docs/bugpattern/LeakingForkedAndroidBundle.md
@@ -3,7 +3,6 @@ > prone to errors if one expects the state change on the original instance to be > reflected on the method with its forked instance. - ```java Location location = new Location("gps"); Bundle bundle = new Bundle();
diff --git a/docs/bugpattern/MethodCanBeStatic.md b/docs/bugpattern/MethodCanBeStatic.md index 2bbe9c9..e7e4622 100644 --- a/docs/bugpattern/MethodCanBeStatic.md +++ b/docs/bugpattern/MethodCanBeStatic.md
@@ -19,4 +19,3 @@ case there is one additional instance the caller needs to have in order to access the method. So, adding `static` is conceptually similar to removing that unused parameter. -
diff --git a/docs/bugpattern/MoveToSafeHtmlResponse.md b/docs/bugpattern/MoveToSafeHtmlResponse.md index 8b13789..e69de29 100644 --- a/docs/bugpattern/MoveToSafeHtmlResponse.md +++ b/docs/bugpattern/MoveToSafeHtmlResponse.md
@@ -1 +0,0 @@ -
diff --git a/docs/bugpattern/NonFinalCompileTimeConstant.md b/docs/bugpattern/NonFinalCompileTimeConstant.md index d22839a..120970c 100644 --- a/docs/bugpattern/NonFinalCompileTimeConstant.md +++ b/docs/bugpattern/NonFinalCompileTimeConstant.md
@@ -10,4 +10,3 @@ x = f(x); // x is not a constant } ``` -
diff --git a/docs/bugpattern/PackageLocation.md b/docs/bugpattern/PackageLocation.md index d822fd6..a17bf67 100644 --- a/docs/bugpattern/PackageLocation.md +++ b/docs/bugpattern/PackageLocation.md
@@ -4,10 +4,8 @@ For example, classes in the package `edu.oswego.cs.dl.util.concurrent` should be located in: `.../edu/oswego/cs/dl/util/concurrent`. - ## Suppression - If necessary, the check may be suppressed by annotating the enclosing package declaration with `@com.google.errorprone.annotations.SuppressPackageLocation`, for example:
diff --git a/docs/bugpattern/ParameterName.md b/docs/bugpattern/ParameterName.md index 455c4b8..e379603 100644 --- a/docs/bugpattern/ParameterName.md +++ b/docs/bugpattern/ParameterName.md
@@ -19,4 +19,3 @@ If the comment deliberately does not match the formal parameter name, using a regular block comment without the `=` is recommended: `/* enableFoo */`. -
diff --git a/docs/bugpattern/QualifierWithTypeUse.md b/docs/bugpattern/QualifierWithTypeUse.md index e1be22c..3bb257f 100644 --- a/docs/bugpattern/QualifierWithTypeUse.md +++ b/docs/bugpattern/QualifierWithTypeUse.md
@@ -12,6 +12,5 @@ @Inject Foo(List<String> strings) ``` - [`TYPE_PARAMETER`]: https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html#TYPE_PARAMETER [`TYPE_USE`]: https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html#TYPE_USE
diff --git a/docs/bugpattern/RestrictedApiChecker.md b/docs/bugpattern/RestrictedApiChecker.md index 604543a..9e4d9cf 100644 --- a/docs/bugpattern/RestrictedApiChecker.md +++ b/docs/bugpattern/RestrictedApiChecker.md
@@ -1,3 +1,2 @@ Calls to APIs marked @RestrictedApi are prohibited without a corresponding whitelist annotation. -
diff --git a/docs/bugpattern/ReturnMissingNullable.md b/docs/bugpattern/ReturnMissingNullable.md index b7ca090..cb2ef87 100644 --- a/docs/bugpattern/ReturnMissingNullable.md +++ b/docs/bugpattern/ReturnMissingNullable.md
@@ -1,5 +1,4 @@ - Methods that may return `null` should be annotated with `@Nullable`. For example, do this:
diff --git a/docs/bugpattern/SelfComparison.md b/docs/bugpattern/SelfComparison.md index b0a38c0..44440e1 100644 --- a/docs/bugpattern/SelfComparison.md +++ b/docs/bugpattern/SelfComparison.md
@@ -1,3 +1,2 @@ The arguments to compareTo method are the same object, so it always returns 0. Either change the arguments to point to different objects or substitute 0. -
diff --git a/docs/bugpattern/StaticOrDefaultInterfaceMethod.md b/docs/bugpattern/StaticOrDefaultInterfaceMethod.md index f13f6ea..045dc98 100644 --- a/docs/bugpattern/StaticOrDefaultInterfaceMethod.md +++ b/docs/bugpattern/StaticOrDefaultInterfaceMethod.md
@@ -3,7 +3,6 @@ devices. See [Android Java 8 Documentation](https://developer.android.com/guide/platform/j8-jack.html). - ## Suppression To declare default or static methods in interfaces, add a
diff --git a/docs/bugpattern/TestExceptionChecker.md b/docs/bugpattern/TestExceptionChecker.md index 511dc1b..72e8366 100644 --- a/docs/bugpattern/TestExceptionChecker.md +++ b/docs/bugpattern/TestExceptionChecker.md
@@ -1,5 +1,4 @@ - The use of `@Test(expected = FooException.class)` is strongly discouraged, since the test passes if *any* statement throws an exception of the expected type.
diff --git a/docs/bugpattern/ThrowsUncheckedException.md b/docs/bugpattern/ThrowsUncheckedException.md index 5565fd3..d15008a 100644 --- a/docs/bugpattern/ThrowsUncheckedException.md +++ b/docs/bugpattern/ThrowsUncheckedException.md
@@ -3,4 +3,3 @@ > Use the Javadoc `@throws` tag to document each unchecked exception that a > method can throw, but do not use the throws keyword to include unchecked > exceptions in the method declaration. -
diff --git a/docs/bugpattern/UnnecessaryAnonymousClass.md b/docs/bugpattern/UnnecessaryAnonymousClass.md index 5a712e1..5842ddb 100644 --- a/docs/bugpattern/UnnecessaryAnonymousClass.md +++ b/docs/bugpattern/UnnecessaryAnonymousClass.md
@@ -51,4 +51,3 @@ Secondly, if the correctness of your program depends on reference equality, inlining the method reference may break you. Ideally, you should *not* depend on reference equality, but if you are doing so, consider not making this change. -
diff --git a/docs/bugpattern/UnnecessaryLambda.md b/docs/bugpattern/UnnecessaryLambda.md index f3ab828..437a9e0 100644 --- a/docs/bugpattern/UnnecessaryLambda.md +++ b/docs/bugpattern/UnnecessaryLambda.md
@@ -47,4 +47,3 @@ your lambda, inlining it may break you. Ideally, you should *not* depend on reference equality for a lambda, but if you are doing so, consider not making this change. -
diff --git a/docs/bugpattern/UnusedMethod.md b/docs/bugpattern/UnusedMethod.md index dbcb956..a7ff559 100644 --- a/docs/bugpattern/UnusedMethod.md +++ b/docs/bugpattern/UnusedMethod.md
@@ -2,9 +2,7 @@ _private_ methods which are unused and can be safely removed without considering the impact on other source files. - ## Suppression - All false positives can be suppressed by annotating the method with `@SuppressWarnings("unused")`.
diff --git a/docs/bugpattern/UnusedVariable.md b/docs/bugpattern/UnusedVariable.md index a338b16..0f85f54 100644 --- a/docs/bugpattern/UnusedVariable.md +++ b/docs/bugpattern/UnusedVariable.md
@@ -2,7 +2,6 @@ _private_ fields and parameters which are unused and can be safely removed without considering the impact on other source files. - ## Suppression False positives on fields and parameters can be suppressed by prefixing the @@ -14,6 +13,5 @@ } ``` - All false positives can be suppressed by annotating the variable with `@SuppressWarnings("unused")`.
diff --git a/docs/bugpattern/Var.md b/docs/bugpattern/Var.md index 639a2d2..d5f86bf 100644 --- a/docs/bugpattern/Var.md +++ b/docs/bugpattern/Var.md
@@ -1,5 +1,4 @@ - Most references are never modified, and accidentally modifying a reference is a potential source of bugs. @@ -20,4 +19,3 @@ The annotation can also be applied to fields to indicate that the field is deliberately non-final, but the use of @Var on fields is not required. -
diff --git a/docs/bugpattern/android/WakelockReleasedDangerously.md b/docs/bugpattern/android/WakelockReleasedDangerously.md index db11bf8..2b45d46 100644 --- a/docs/bugpattern/android/WakelockReleasedDangerously.md +++ b/docs/bugpattern/android/WakelockReleasedDangerously.md
@@ -32,7 +32,6 @@ OS does not check whether the `WakeLock` has been released too many times, and no `RuntimeException` is thrown. - This check will flag any call of any overload of `wakelock.release()` that is: * not in a try block that has a clause to catch `RuntimeException`
diff --git a/docs/bugpattern/argumentselectiondefects/NamedParameters.md b/docs/bugpattern/argumentselectiondefects/NamedParameters.md index 669dd58..70b9d49 100644 --- a/docs/bugpattern/argumentselectiondefects/NamedParameters.md +++ b/docs/bugpattern/argumentselectiondefects/NamedParameters.md
@@ -66,4 +66,3 @@ equals sign, and the clang-tidy [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html) check uses block-comments with equals signs. -