| /* Copyright (c) 2025-2026 The Khronos Group Inc. |
| * Copyright (c) 2025-2026 Valve Corporation |
| * Copyright (c) 2025-2026 LunarG, Inc. |
| * |
| * Licensed under the Apache License, Version 2.0 (the "License"); |
| * you may not use this file except in compliance with the License. |
| * You may obtain a copy of the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| * See the License for the specific language governing permissions and |
| * limitations under the License. |
| */ |
| |
| #include "../framework/layer_validation_tests.h" |
| #include "cooperative_matrix_helper.h" |
| #include "pipeline_helper.h" |
| #include "shader_helper.h" |
| |
| class NegativeGpuAVShaderSanitizer : public GpuAVGpuAVShaderSanitizer {}; |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroUDivScalar) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| uint index; |
| uint result; |
| }; |
| |
| void main() { |
| result = 5 / index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroSDivScalar) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| int index; |
| int result; |
| }; |
| |
| void main() { |
| result = 5 / index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroUDivVector) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| uvec4 index; |
| uvec4 result; |
| }; |
| |
| void main() { |
| result = uvec4(5) / index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroSDivVector) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| ivec2 index; |
| ivec2 result; |
| }; |
| |
| void main() { |
| result = ivec2(5) / index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroUDivVector64) { |
| AddRequiredFeature(vkt::Feature::shaderInt64); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #extension GL_EXT_shader_explicit_arithmetic_types_int64 : enable |
| layout(set=0, binding=0) buffer SSBO { |
| u64vec3 index; |
| u64vec3 result; |
| }; |
| |
| void main() { |
| result = u64vec3(5) / index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroUDiv8Bit) { |
| SetTargetApiVersion(VK_API_VERSION_1_1); |
| AddRequiredExtensions(VK_KHR_SHADER_FLOAT16_INT8_EXTENSION_NAME); |
| AddRequiredExtensions(VK_KHR_8BIT_STORAGE_EXTENSION_NAME); |
| AddRequiredFeature(vkt::Feature::storageBuffer8BitAccess); |
| AddRequiredFeature(vkt::Feature::shaderInt8); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #extension GL_EXT_shader_explicit_arithmetic_types_int8 : enable |
| layout(set=0, binding=0) buffer SSBO { |
| int8_t index; |
| int8_t result; |
| }; |
| |
| void main() { |
| result = int8_t(5) / index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroUMod) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| uint index; |
| uint result; |
| }; |
| |
| void main() { |
| result = 5 % index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroSMod) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| ivec2 index; |
| ivec2 result; |
| }; |
| |
| void main() { |
| result = ivec2(5) % index; |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, SRem) { |
| const char* cs_source = R"asm( |
| OpCapability Shader |
| OpMemoryModel Logical GLSL450 |
| OpEntryPoint GLCompute %main "main" |
| OpExecutionMode %main LocalSize 1 1 1 |
| OpDecorate %SSBO Block |
| OpMemberDecorate %SSBO 0 Offset 0 |
| OpMemberDecorate %SSBO 1 Offset 4 |
| OpDecorate %_ Binding 0 |
| OpDecorate %_ DescriptorSet 0 |
| %void = OpTypeVoid |
| %4 = OpTypeFunction %void |
| %int = OpTypeInt 32 1 |
| %SSBO = OpTypeStruct %int %int |
| %_ptr_StorageBuffer_SSBO = OpTypePointer StorageBuffer %SSBO |
| %_ = OpVariable %_ptr_StorageBuffer_SSBO StorageBuffer |
| %int_1 = OpConstant %int 1 |
| %int_0 = OpConstant %int 0 |
| %_ptr_StorageBuffer_int = OpTypePointer StorageBuffer %int |
| %main = OpFunction %void None %4 |
| %6 = OpLabel |
| %15 = OpAccessChain %_ptr_StorageBuffer_int %_ %int_0 |
| %16 = OpLoad %int %15 |
| %17 = OpIAdd %int %16 %int_0 |
| %18 = OpSRem %int %int_1 %17 |
| %19 = OpAccessChain %_ptr_StorageBuffer_int %_ %int_1 |
| OpStore %19 %18 |
| OpReturn |
| OpFunctionEnd |
| )asm"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_ASM, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroFModScalar) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| float index; |
| float result; |
| }; |
| |
| void main() { |
| result = mod(result, index); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroFModVector) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| vec2 index; |
| vec2 result; |
| }; |
| |
| void main() { |
| index.x = 1.0f; |
| result = mod(result, index); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroFMod64) { |
| AddRequiredFeature(vkt::Feature::shaderFloat64); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #extension GL_EXT_shader_explicit_arithmetic_types_float64 : enable |
| layout(set=0, binding=0) buffer SSBO { |
| float64_t index; |
| float64_t result; |
| }; |
| |
| void main() { |
| float64_t result = mod(result, index); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Divide-By-Zero"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, DivideByZeroIntDivConstant) { |
| AddRequiredFeature(vkt::Feature::shaderInt64); |
| RETURN_IF_SKIP(InitGpuAvFramework()); |
| RETURN_IF_SKIP(InitState()); |
| |
| vkt::Buffer in_buffer(*m_device, 256, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, kHostVisibleMemProps); |
| void* in_ptr = in_buffer.Memory().Map(); |
| memset(in_ptr, 0, 256); |
| |
| OneOffDescriptorSet descriptor_set(m_device, {{0, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1, VK_SHADER_STAGE_ALL, nullptr}}); |
| const vkt::PipelineLayout pipeline_layout(*m_device, {&descriptor_set.layout_}); |
| descriptor_set.WriteDescriptorBufferInfo(0, in_buffer, 0, VK_WHOLE_SIZE, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER); |
| descriptor_set.UpdateDescriptorSets(); |
| |
| std::string base = R"asm( |
| OpCapability Shader |
| OpCapability Int64 |
| OpMemoryModel Logical GLSL450 |
| OpEntryPoint GLCompute %main "main" |
| OpExecutionMode %main LocalSize 1 1 1 |
| OpDecorate %SSBO Block |
| OpMemberDecorate %SSBO 0 Offset 0 |
| OpMemberDecorate %SSBO 1 Offset 4 |
| OpMemberDecorate %SSBO 2 Offset 8 |
| OpMemberDecorate %SSBO 3 Offset 16 |
| OpMemberDecorate %SSBO 4 Offset 32 |
| OpMemberDecorate %SSBO 5 Offset 48 |
| OpMemberDecorate %SSBO 6 Offset 64 |
| OpDecorate %var Binding 0 |
| OpDecorate %var DescriptorSet 0 |
| %void = OpTypeVoid |
| %func = OpTypeFunction %void |
| %uint = OpTypeInt 32 0 |
| %uint64 = OpTypeInt 64 0 |
| %int = OpTypeInt 32 1 |
| %float = OpTypeFloat 32 |
| %v2uint = OpTypeVector %uint 2 |
| %v3int = OpTypeVector %int 3 |
| %v4uint = OpTypeVector %uint 4 |
| |
| %int_0 = OpConstant %int 0 |
| %int_1 = OpConstant %int 1 |
| %int_2 = OpConstant %int 2 |
| %int_3 = OpConstant %int 3 |
| %int_4 = OpConstant %int 4 |
| %int_5 = OpConstant %int 5 |
| %int_6 = OpConstant %int 6 |
| %uint_0 = OpConstant %uint 0 |
| %uint_1 = OpConstant %uint 1 |
| %uint_null = OpConstantNull %uint |
| %uint64_0 = OpConstant %uint64 0 |
| %float_0 = OpConstant %float 0 |
| |
| %u32v2_1_null = OpConstantComposite %v2uint %uint_1 %uint_null |
| %i32v3_000 = OpConstantComposite %v3int %int_0 %int_0 %int_0 |
| %u32v4_1101 = OpConstantComposite %v4uint %uint_1 %uint_1 %uint_0 %uint_1 |
| %u32v4_null = OpConstantNull %v4uint |
| |
| %SSBO = OpTypeStruct %uint %int %uint64 %v2uint %v3int %v4uint %float |
| %ptr_ssbo = OpTypePointer StorageBuffer %SSBO |
| %var = OpVariable %ptr_ssbo StorageBuffer |
| %ptr_ssbo_v2uint = OpTypePointer StorageBuffer %v2uint |
| %ptr_ssbo_v3int = OpTypePointer StorageBuffer %v3int |
| %ptr_ssbo_v4uint = OpTypePointer StorageBuffer %v4uint |
| %ptr_ssbo_uint64 = OpTypePointer StorageBuffer %uint64 |
| %ptr_ssbo_uint = OpTypePointer StorageBuffer %uint |
| %ptr_ssbo_int = OpTypePointer StorageBuffer %int |
| %ptr_ssbo_float = OpTypePointer StorageBuffer %float |
| %main = OpFunction %void None %func |
| %label = OpLabel |
| )asm"; |
| |
| std::string end = R"asm( |
| OpStore %4 %3 ; Prevents DCE |
| OpReturn |
| OpFunctionEnd |
| )asm"; |
| |
| auto test = [this, base, end, &pipeline_layout, &descriptor_set](std::string source) { |
| std::string full_source = base + source + end; |
| CreateComputePipelineHelper pipe(*this); |
| pipe.cp_ci_.layout = pipeline_layout; |
| pipe.cs_ = VkShaderObj(*m_device, full_source.c_str(), VK_SHADER_STAGE_COMPUTE_BIT, SPV_ENV_VULKAN_1_1, SPV_SOURCE_ASM); |
| pipe.CreateComputePipeline(); |
| |
| m_command_buffer.Begin(); |
| vk::CmdBindPipeline(m_command_buffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipe); |
| vk::CmdBindDescriptorSets(m_command_buffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipeline_layout, 0, 1, &descriptor_set.set_, 0, |
| nullptr); |
| vk::CmdDispatch(m_command_buffer, 1, 1, 1); |
| m_command_buffer.End(); |
| |
| m_errorMonitor->SetDesiredError("SPIRV-Sanitizer-Divide-By-Zero"); |
| m_default_queue->SubmitAndWait(m_command_buffer); |
| m_errorMonitor->VerifyFound(); |
| }; |
| |
| // UDiv 32-bit |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_uint %var %int_0 |
| %2 = OpLoad %uint %1 |
| %3 = OpUDiv %uint %2 %uint_0 |
| %4 = OpAccessChain %ptr_ssbo_uint %var %int_0 |
| )asm"); |
| |
| // UDiv 32-bit Null |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_uint %var %int_0 |
| %2 = OpLoad %uint %1 |
| %3 = OpUDiv %uint %2 %uint_null |
| %4 = OpAccessChain %ptr_ssbo_uint %var %int_0 |
| )asm"); |
| |
| // SDiv 32-bit |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_int %var %int_1 |
| %2 = OpLoad %int %1 |
| %3 = OpSDiv %int %2 %uint_0 |
| %4 = OpAccessChain %ptr_ssbo_int %var %int_1 |
| )asm"); |
| |
| // UDiv 64-bit Null |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_uint64 %var %int_2 |
| %2 = OpLoad %uint64 %1 |
| %3 = OpUDiv %uint64 %2 %uint64_0 |
| %4 = OpAccessChain %ptr_ssbo_uint64 %var %int_2 |
| )asm"); |
| |
| // UDiv uvec2 |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_v2uint %var %int_3 |
| %2 = OpLoad %v2uint %1 |
| %3 = OpUDiv %v2uint %2 %u32v2_1_null |
| %4 = OpAccessChain %ptr_ssbo_v2uint %var %int_3 |
| )asm"); |
| |
| // SDiv ivec3 |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_v3int %var %int_4 |
| %2 = OpLoad %v3int %1 |
| %3 = OpSDiv %v3int %2 %i32v3_000 |
| %4 = OpAccessChain %ptr_ssbo_v3int %var %int_4 |
| )asm"); |
| |
| // UDiv uvec4 |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_v4uint %var %int_5 |
| %2 = OpLoad %v4uint %1 |
| %3 = OpUDiv %v4uint %2 %u32v4_1101 |
| %4 = OpAccessChain %ptr_ssbo_v4uint %var %int_5 |
| )asm"); |
| |
| // UDiv uvec4 Null |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_v4uint %var %int_5 |
| %2 = OpLoad %v4uint %1 |
| %3 = OpUDiv %v4uint %2 %u32v4_null |
| %4 = OpAccessChain %ptr_ssbo_v4uint %var %int_5 |
| )asm"); |
| |
| // FRem |
| test(R"asm( |
| %1 = OpAccessChain %ptr_ssbo_float %var %int_6 |
| %2 = OpLoad %float %1 |
| %3 = OpFRem %float %2 %float_0 |
| %4 = OpAccessChain %ptr_ssbo_float %var %int_6 |
| )asm"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, ImageGather) { |
| SetTargetApiVersion(VK_API_VERSION_1_2); |
| RETURN_IF_SKIP(InitGpuAvFramework()); |
| RETURN_IF_SKIP(InitState()); |
| |
| const char* cs_source = R"asm( |
| OpCapability Shader |
| OpMemoryModel Logical GLSL450 |
| OpEntryPoint GLCompute %main "main" %_ %tex |
| OpExecutionMode %main LocalSize 1 1 1 |
| OpDecorate %SSBO Block |
| OpMemberDecorate %SSBO 0 Offset 0 |
| OpDecorate %_ Binding 1 |
| OpDecorate %_ DescriptorSet 0 |
| OpDecorate %tex Binding 0 |
| OpDecorate %tex DescriptorSet 0 |
| %void = OpTypeVoid |
| %4 = OpTypeFunction %void |
| %float = OpTypeFloat 32 |
| %v4float = OpTypeVector %float 4 |
| %SSBO = OpTypeStruct %v4float |
| %_ptr_StorageBuffer_SSBO = OpTypePointer StorageBuffer %SSBO |
| %_ = OpVariable %_ptr_StorageBuffer_SSBO StorageBuffer |
| %int = OpTypeInt 32 1 |
| %int_0 = OpConstant %int 0 |
| %14 = OpTypeImage %float 2D 0 0 0 1 Unknown |
| %15 = OpTypeSampledImage %14 |
| %_ptr_UniformConstant_15 = OpTypePointer UniformConstant %15 |
| %tex = OpVariable %_ptr_UniformConstant_15 UniformConstant |
| %v2float = OpTypeVector %float 2 |
| %float_0 = OpConstant %float 0 |
| %21 = OpConstantComposite %v2float %float_0 %float_0 |
| %int_4 = OpConstant %int 4 |
| %_ptr_StorageBuffer_v4float = OpTypePointer StorageBuffer %v4float |
| %main = OpFunction %void None %4 |
| %6 = OpLabel |
| %18 = OpLoad %15 %tex |
| %23 = OpImageGather %v4float %18 %21 %int_4 |
| %25 = OpAccessChain %_ptr_StorageBuffer_v4float %_ %int_0 |
| OpStore %25 %23 |
| OpReturn |
| OpFunctionEnd |
| )asm"; |
| |
| OneOffDescriptorSet descriptor_set(m_device, |
| { |
| {0, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, 1, VK_SHADER_STAGE_ALL, nullptr}, |
| {1, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1, VK_SHADER_STAGE_ALL, nullptr}, |
| }); |
| const vkt::PipelineLayout pipeline_layout(*m_device, {&descriptor_set.layout_}); |
| |
| CreateComputePipelineHelper pipe(*this); |
| pipe.cp_ci_.layout = pipeline_layout; |
| pipe.cs_ = VkShaderObj(*m_device, cs_source, VK_SHADER_STAGE_COMPUTE_BIT, SPV_ENV_VULKAN_1_2, SPV_SOURCE_ASM); |
| pipe.CreateComputePipeline(); |
| |
| vkt::Buffer buffer(*m_device, 256, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT); |
| |
| vkt::Image image(*m_device, 16, 16, VK_FORMAT_B8G8R8A8_UNORM, VK_IMAGE_USAGE_SAMPLED_BIT); |
| image.SetLayout(VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL); |
| vkt::ImageView image_view = image.CreateView(); |
| vkt::Sampler sampler(*m_device, SafeSaneSamplerCreateInfo()); |
| |
| descriptor_set.WriteDescriptorImageInfo(0, image_view, sampler); |
| descriptor_set.WriteDescriptorBufferInfo(1, buffer, 0, VK_WHOLE_SIZE, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER); |
| descriptor_set.UpdateDescriptorSets(); |
| |
| m_command_buffer.Begin(); |
| vk::CmdBindPipeline(m_command_buffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipe); |
| vk::CmdBindDescriptorSets(m_command_buffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipeline_layout, 0, 1, &descriptor_set.set_, 0, |
| nullptr); |
| vk::CmdDispatch(m_command_buffer, 1, 1, 1); |
| m_command_buffer.End(); |
| |
| m_errorMonitor->SetDesiredError("SPIRV-Sanitizer-Image-Gather"); |
| m_default_queue->SubmitAndWait(m_command_buffer); |
| m_errorMonitor->VerifyFound(); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, PowScalarZero) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| float x; |
| float y; |
| float result; |
| }; |
| |
| void main() { |
| result = pow(x, y - 1.0f); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Pow"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, PowScalarNegative) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| float x; |
| float y; |
| float result; |
| }; |
| |
| void main() { |
| float a = x - 1.0f; |
| float b = y + 1.0f; |
| result = pow(a, b); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Pow"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, PowScalarConstant) { |
| const char* cs_source = R"( |
| OpCapability Shader |
| %2 = OpExtInstImport "GLSL.std.450" |
| OpMemoryModel Logical GLSL450 |
| OpEntryPoint GLCompute %main "main" |
| OpExecutionMode %main LocalSize 1 1 1 |
| OpDecorate %SSBO Block |
| OpMemberDecorate %SSBO 0 Offset 0 |
| OpDecorate %var Binding 0 |
| OpDecorate %var DescriptorSet 0 |
| %void = OpTypeVoid |
| %4 = OpTypeFunction %void |
| %float = OpTypeFloat 32 |
| %_ptr_Function_float = OpTypePointer Function %float |
| %float_n1 = OpConstant %float -1.3 |
| %float_1 = OpConstant %float 1.3 |
| %SSBO = OpTypeStruct %float |
| %_ptr_StorageBuffer_SSBO = OpTypePointer StorageBuffer %SSBO |
| %var = OpVariable %_ptr_StorageBuffer_SSBO StorageBuffer |
| %int = OpTypeInt 32 1 |
| %int_0 = OpConstant %int 0 |
| %_ptr_StorageBuffer_float = OpTypePointer StorageBuffer %float |
| %main = OpFunction %void None %4 |
| %6 = OpLabel |
| %16 = OpExtInst %float %2 Pow %float_n1 %float_1 |
| %24 = OpAccessChain %_ptr_StorageBuffer_float %var %int_0 |
| OpStore %24 %16 |
| OpReturn |
| OpFunctionEnd |
| )"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_ASM, "SPIRV-Sanitizer-Pow"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, PowVectorZero) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| vec2 x; |
| vec2 y; |
| vec2 result; |
| }; |
| |
| void main() { |
| x.x = 3.0f; |
| y.x = 1.0f; |
| result = pow(x, y); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Pow"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, PowVectorNegative) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| vec4 x; |
| vec4 y; |
| vec4 result; |
| }; |
| |
| void main() { |
| vec4 a = x - (1.0f); |
| vec4 b = y + (1.0f); |
| result = pow(a, b); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Pow"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, Atan2Scalar) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| float x; |
| float y; |
| float result; |
| }; |
| |
| void main() { |
| result = atan(x, y); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Atan2"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, Atan2ScalarConstant) { |
| const char* cs_source = R"( |
| OpCapability Shader |
| %2 = OpExtInstImport "GLSL.std.450" |
| OpMemoryModel Logical GLSL450 |
| OpEntryPoint GLCompute %main "main" |
| OpExecutionMode %main LocalSize 1 1 1 |
| OpDecorate %SSBO Block |
| OpMemberDecorate %SSBO 0 Offset 0 |
| OpDecorate %var Binding 0 |
| OpDecorate %var DescriptorSet 0 |
| %void = OpTypeVoid |
| %4 = OpTypeFunction %void |
| %float = OpTypeFloat 32 |
| %_ptr_Function_float = OpTypePointer Function %float |
| %float_0 = OpConstant %float 0 |
| %SSBO = OpTypeStruct %float |
| %_ptr_StorageBuffer_SSBO = OpTypePointer StorageBuffer %SSBO |
| %var = OpVariable %_ptr_StorageBuffer_SSBO StorageBuffer |
| %int = OpTypeInt 32 1 |
| %int_0 = OpConstant %int 0 |
| %_ptr_StorageBuffer_float = OpTypePointer StorageBuffer %float |
| %main = OpFunction %void None %4 |
| %6 = OpLabel |
| %16 = OpExtInst %float %2 Atan2 %float_0 %float_0 |
| %24 = OpAccessChain %_ptr_StorageBuffer_float %var %int_0 |
| OpStore %24 %16 |
| OpReturn |
| OpFunctionEnd |
| )"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_ASM, "SPIRV-Sanitizer-Atan2"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, Atan2Vector) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| vec3 x; |
| vec3 y; |
| vec3 result; |
| }; |
| |
| void main() { |
| x.x = 3.0f; // now vec3(3, 0, 0) |
| y.y = 1.0f; // now vec3(0, 1, 0) |
| result = atan(x, y); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Atan2"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, FMinNaNScalar) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| float x; |
| float y; |
| float result; |
| }; |
| |
| void main() { |
| y = uintBitsToFloat(0x7FC00000u); // set NaN |
| result = min(x, y); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Fminmax"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, FMinNaNVector) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| vec2 x; |
| vec2 y; |
| vec2 result; |
| }; |
| |
| void main() { |
| x.x = uintBitsToFloat(0x7FC00000u); // set NaN |
| y.y = uintBitsToFloat(0x7FC00000u); // set NaN |
| result = min(x, y); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Fminmax"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, FMaxNaNVector) { |
| const char* cs_source = R"glsl( |
| #version 450 core |
| layout(set=0, binding=0) buffer SSBO { |
| vec4 x; |
| vec4 y; |
| vec4 result; |
| }; |
| |
| void main() { |
| x.z = uintBitsToFloat(0x7FC00000u); // set NaN |
| result = max(x, y); |
| } |
| )glsl"; |
| |
| SimpleZeroComputeTest(cs_source, SPV_SOURCE_GLSL, "SPIRV-Sanitizer-Fminmax"); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, CoopMatLoadMisalignedStride) { |
| TEST_DESCRIPTION("OpCooperativeMatrixLoadKHR with a stride that violates the alignment requirement (fp16, component_size=2)"); |
| RETURN_IF_SKIP(InitCoopMatFp16()); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #pragma use_vulkan_memory_model |
| #extension GL_KHR_memory_scope_semantics : enable |
| #extension GL_KHR_cooperative_matrix : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types : enable |
| layout(local_size_x = 64) in; |
| layout(set=0, binding=0) coherent buffer SSBO { float16_t payload[]; }; |
| layout(set=0, binding=1) buffer ParamSSBO { uint stride_val; }; |
| void main() { |
| coopmat<float16_t, gl_ScopeSubgroup, 16, 16, gl_MatrixUseA> matA; |
| coopMatLoad(matA, payload, 0, stride_val, gl_CooperativeMatrixLayoutRowMajor); |
| } |
| )glsl"; |
| CoopMatAlignmentTest(cs_source, {7}, true); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, CoopMatStoreMisalignedStride) { |
| TEST_DESCRIPTION("OpCooperativeMatrixStoreKHR with a stride that violates the alignment requirement (fp16, component_size=2)"); |
| RETURN_IF_SKIP(InitCoopMatFp16()); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #pragma use_vulkan_memory_model |
| #extension GL_KHR_memory_scope_semantics : enable |
| #extension GL_KHR_cooperative_matrix : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types : enable |
| layout(local_size_x = 64) in; |
| layout(set=0, binding=0) coherent buffer SSBO { float16_t payload[]; }; |
| layout(set=0, binding=1) buffer ParamSSBO { uint stride_val; }; |
| void main() { |
| coopmat<float16_t, gl_ScopeSubgroup, 16, 16, gl_MatrixUseA> matA; |
| coopMatLoad(matA, payload, 0, 8, gl_CooperativeMatrixLayoutRowMajor); |
| coopMatStore(matA, payload, 0, stride_val, gl_CooperativeMatrixLayoutRowMajor); |
| } |
| )glsl"; |
| CoopMatAlignmentTest(cs_source, {7}, true); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, CoopMatLoadMisalignedPointerSSBO) { |
| TEST_DESCRIPTION("OpCooperativeMatrixLoadKHR with an SSBO pointer offset that violates the alignment requirement"); |
| RETURN_IF_SKIP(InitCoopMatFp16()); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #pragma use_vulkan_memory_model |
| #extension GL_KHR_memory_scope_semantics : enable |
| #extension GL_KHR_cooperative_matrix : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types : enable |
| layout(local_size_x = 64) in; |
| layout(set=0, binding=0) coherent buffer SSBO { float16_t payload[]; }; |
| layout(set=0, binding=1) buffer ParamSSBO { uint offset_val; }; |
| void main() { |
| coopmat<float16_t, gl_ScopeSubgroup, 16, 16, gl_MatrixUseA> matA; |
| coopMatLoad(matA, payload, offset_val, 16, gl_CooperativeMatrixLayoutRowMajor); |
| } |
| )glsl"; |
| CoopMatAlignmentTest(cs_source, {1}, true); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, CoopMatLoadMisalignedStrideAndPointer) { |
| TEST_DESCRIPTION("OpCooperativeMatrixLoadKHR with both stride and pointer offset misaligned"); |
| RETURN_IF_SKIP(InitCoopMatFp16()); |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #pragma use_vulkan_memory_model |
| #extension GL_KHR_memory_scope_semantics : enable |
| #extension GL_KHR_cooperative_matrix : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types : enable |
| layout(local_size_x = 64) in; |
| layout(set=0, binding=0) coherent buffer SSBO { float16_t payload[]; }; |
| layout(set=0, binding=1) buffer ParamSSBO { uint stride_val; uint offset_val; }; |
| void main() { |
| coopmat<float16_t, gl_ScopeSubgroup, 16, 16, gl_MatrixUseA> matA; |
| coopMatLoad(matA, payload, offset_val, stride_val, gl_CooperativeMatrixLayoutRowMajor); |
| } |
| )glsl"; |
| CoopMatAlignmentTest(cs_source, {7, 1}, true); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, CoopMatLoadMisalignedPointerBDA) { |
| TEST_DESCRIPTION("OpCooperativeMatrixLoadKHR with a BDA pointer that violates the alignment requirement"); |
| SetTargetApiVersion(VK_API_VERSION_1_3); |
| AddRequiredFeature(vkt::Feature::bufferDeviceAddress); |
| AddRequiredFeature(vkt::Feature::shaderInt64); |
| RETURN_IF_SKIP(InitCoopMatFp16()); |
| |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #pragma use_vulkan_memory_model |
| #extension GL_KHR_memory_scope_semantics : enable |
| #extension GL_KHR_cooperative_matrix : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types : enable |
| #extension GL_EXT_buffer_reference : enable |
| layout(local_size_x = 64) in; |
| layout(buffer_reference, std430) buffer BufRef { float16_t data[]; }; |
| layout(set=0, binding=0) buffer AddrSSBO { uint64_t addr; }; |
| void main() { |
| BufRef buf = BufRef(addr); |
| coopmat<float16_t, gl_ScopeSubgroup, 16, 16, gl_MatrixUseA> matA; |
| coopMatLoad(matA, buf.data, 0, 16, gl_CooperativeMatrixLayoutRowMajor); |
| } |
| )glsl"; |
| |
| CreateComputePipelineHelper pipe(*this); |
| pipe.dsl_bindings_ = {{0, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1, VK_SHADER_STAGE_ALL, nullptr}}; |
| pipe.cs_ = VkShaderObj(*m_device, cs_source, VK_SHADER_STAGE_COMPUTE_BIT, SPV_ENV_VULKAN_1_2); |
| pipe.CreateComputePipeline(); |
| |
| vkt::Buffer payload_buffer(*m_device, 4096, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, vkt::device_address); |
| VkDeviceAddress misaligned_addr = payload_buffer.Address() + 1; |
| |
| vkt::Buffer addr_buffer(*m_device, sizeof(VkDeviceAddress), VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, kHostVisibleMemProps); |
| auto* addr_ptr = static_cast<VkDeviceAddress*>(addr_buffer.Memory().Map()); |
| *addr_ptr = misaligned_addr; |
| addr_buffer.Memory().Unmap(); |
| |
| pipe.descriptor_set_.WriteDescriptorBufferInfo(0, addr_buffer, 0, VK_WHOLE_SIZE, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER); |
| pipe.descriptor_set_.UpdateDescriptorSets(); |
| |
| m_command_buffer.Begin(); |
| vk::CmdBindPipeline(m_command_buffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipe); |
| vk::CmdBindDescriptorSets(m_command_buffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipe.pipeline_layout_, 0, 1, |
| &pipe.descriptor_set_.set_, 0, nullptr); |
| vk::CmdDispatch(m_command_buffer, 1, 1, 1); |
| m_command_buffer.End(); |
| |
| m_errorMonitor->SetAllowedFailureMsg("VUID-RuntimeSpirv-OpCooperativeMatrixLoadKHR-08986"); |
| m_errorMonitor->SetDesiredError("VUID-RuntimeSpirv-OpCooperativeMatrixLoadKHR-08986"); |
| m_default_queue->SubmitAndWait(m_command_buffer); |
| m_errorMonitor->VerifyFound(); |
| } |
| |
| TEST_F(NegativeGpuAVShaderSanitizer, CoopMatLoadMisalignedStrideUint8) { |
| TEST_DESCRIPTION("OpCooperativeMatrixLoadKHR with uint8 component type (K=32) and misaligned stride"); |
| SetTargetApiVersion(VK_API_VERSION_1_3); |
| AddRequiredExtensions(VK_KHR_COOPERATIVE_MATRIX_EXTENSION_NAME); |
| AddRequiredExtensions(VK_KHR_VULKAN_MEMORY_MODEL_EXTENSION_NAME); |
| AddRequiredFeature(vkt::Feature::cooperativeMatrix); |
| AddRequiredFeature(vkt::Feature::vulkanMemoryModel); |
| AddRequiredFeature(vkt::Feature::shaderInt8); |
| AddRequiredFeature(vkt::Feature::storageBuffer8BitAccess); |
| RETURN_IF_SKIP(InitGpuAvFramework()); |
| RETURN_IF_SKIP(InitState()); |
| CooperativeMatrixHelper helper(*this); |
| |
| bool found = false; |
| for (const auto& prop : helper.coop_matrix_props) { |
| if (prop.scope == VK_SCOPE_SUBGROUP_KHR && prop.AType == VK_COMPONENT_TYPE_UINT8_KHR && prop.MSize == 16 && |
| prop.KSize == 32) { |
| found = true; |
| break; |
| } |
| } |
| if (!found) { |
| GTEST_SKIP() << "uint8 16x32 A-type cooperative matrix property not found"; |
| } |
| |
| const char* cs_source = R"glsl( |
| #version 450 core |
| #pragma use_vulkan_memory_model |
| #extension GL_KHR_memory_scope_semantics : enable |
| #extension GL_KHR_cooperative_matrix : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types : enable |
| #extension GL_EXT_shader_explicit_arithmetic_types_int8 : enable |
| layout(local_size_x = 64) in; |
| layout(set=0, binding=0) coherent buffer SSBO { uint8_t payload[]; }; |
| layout(set=0, binding=1) buffer ParamSSBO { uint stride_val; }; |
| void main() { |
| coopmat<uint8_t, gl_ScopeSubgroup, 16, 32, gl_MatrixUseA> matA; |
| coopMatLoad(matA, payload, 0, stride_val, gl_CooperativeMatrixLayoutRowMajor); |
| } |
| )glsl"; |
| CoopMatAlignmentTest(cs_source, {15}, true); |
| } |