)]}' { "log": [ { "commit": "078c43c31e48cc146ee50674c3557aa0f5ffc40b", "tree": "329abca3799e494a28d8eef1d47e4866237dc33f", "parents": [ "90fb5cada8bfe33c37bd19c2e3df2cfa140018fb" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Jun 19 16:24:32 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Jun 19 16:24:32 2012" }, "message": "URLFetcher has moved from content to net, update references.\n\nNo functionality change.\n\nBUG\u003dchromium:118220\n\nReview URL: https://codereview.appspot.com/6310062\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@132 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "90fb5cada8bfe33c37bd19c2e3df2cfa140018fb", "tree": "2e7a3b282dbd1cfe0460c0647e0de5661d8d0945", "parents": [ "f36b420aa0963d07215813f3f862be1794c2ce55" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Jun 12 15:47:58 2012" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Jun 12 15:47:58 2012" }, "message": "Update the DEPS file so that the RLZ project can build standalone. It\ncurrently builds only when part of a chrome build.\n\nBUG\u003dNone\nTEST\u003dNo user visible changes\nReview URL: https://codereview.appspot.com/6306071\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@131 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "f36b420aa0963d07215813f3f862be1794c2ce55", "tree": "e9b18fbbf48175d433770533d641f1fe08aa3b56", "parents": [ "7260a08c60ca050385d16d3a1c62089b53a3be0b" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu May 31 23:45:18 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu May 31 23:45:18 2012" }, "message": "The last commit was missing the change to this file.\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@130 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "7260a08c60ca050385d16d3a1c62089b53a3be0b", "tree": "dbd922fcc63bf3bea9e1e3c6bf681b21d19556db", "parents": [ "c6536c5beb689d1ebb8997b97d76f8797ba067c7" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu May 31 23:42:03 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu May 31 23:42:03 2012" }, "message": "Use char version functions in base/stringprintf.h.\n\nA chromium change in base/ is going to remove wchar/wstring version of\nStringPrintf. So change to use char version of functions in\nwin/lib/rlz_value_store_registry.cc .\n\nhttp://codereview.chromium.org/10449042/\nPatch from Hao Zheng \u003czhenghao@chromium.org\u003e!\n\n\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@129 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "c6536c5beb689d1ebb8997b97d76f8797ba067c7", "tree": "e6de166801846a5e8b50f80790aff0b01cfe2ba3", "parents": [ "3fca43708a96462230c93f8352c62ea50350a35d" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri May 11 21:42:13 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri May 11 21:42:13 2012" }, "message": "rlz: Move UrlFetcher to net, part 1\n\nBUG\u003dchromium:118220\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/6200066\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@128 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "3fca43708a96462230c93f8352c62ea50350a35d", "tree": "5842d78cafe3da8268d3ec013ffa5be4da363750", "parents": [ "249043c6ed7e7a85d7ba46b31244b27c6b66e932" ], "author": { "name": "jam@chromium.org", "email": "jam@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Apr 27 19:24:21 2012" }, "committer": { "name": "jam@chromium.org", "email": "jam@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Apr 27 19:24:21 2012" }, "message": "Fix deps file\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@127 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "249043c6ed7e7a85d7ba46b31244b27c6b66e932", "tree": "83a8e5f8c48bf771a5346448dd6713ac6bde4e04", "parents": [ "250c68f222a879d1beef487596f465455ddc77ce" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Apr 09 17:32:54 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Apr 09 17:32:54 2012" }, "message": "Rename user_key to registry_util.\n\nNo code change.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5967046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@126 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "250c68f222a879d1beef487596f465455ddc77ce", "tree": "f1e76ce6173815cacb8feaa4bb6f09503a92f6b0", "parents": [ "384a68bba8852a9fbc841fa968547d749e37730e" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Apr 02 19:50:48 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Apr 02 19:50:48 2012" }, "message": "mac: Make ScopedRlzValueStoreLock handle nested lock failures.\n\nI thought that lib_rlz always early-exits when it fails to acquire the rlz lock,\nand so nested lock acquisition failures should never happen. That is true as\nlong as SupplementaryBranding isn\u0027t used, and that can even be used from\nuser code like so:\n\n {\n rlz_lib::SupplementaryBranding branding(reactivation_brand.c_str());\n ret \u0026\u003d rlz_lib::RecordProductEvent(product, point, event_id);\n }\n\nSince SupplementaryBranding tries to acquire the rlz lock and keeps it while\nit\u0027s on the scope, if RecordProductEvent fails to acquire the lock it\u0027ll be a\nnested lock failure. Update the code to not CHECK on this case.\n\nAdd a test that covers this scenario.\n\nBUG\u003dchromium:121255\nTEST\u003dunit test. I verified the test crashes in the CHECK without my code change.\n\nReview URL: https://codereview.appspot.com/5966066\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@125 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "384a68bba8852a9fbc841fa968547d749e37730e", "tree": "404fe6ea3f5d40c207c3b68b8c5edd4e9bb1abe5", "parents": [ "31612fefe3205c20c529993e01e00af8b4e421db" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 30 17:45:20 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 30 17:45:20 2012" }, "message": "Remove UserKey class, move registry-related functions out of string_util.\n\nNo intended functionality change, just moving code around.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5967043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@124 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "31612fefe3205c20c529993e01e00af8b4e421db", "tree": "d8b3817a7db8e3e0be22c6620bdb52ce6c392aa1", "parents": [ "f74aa8102a1ea266a7a03a30f103f901813b1444" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 28 16:31:10 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 28 16:31:10 2012" }, "message": "Try to fix a windows warning.\n\nwin\\lib\\machine_id_win.cc(67): warning C4800: \u0027BOOL\u0027 : forcing value to bool \u0027true\u0027 or \u0027false\u0027 (performance warning)\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5940054\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@123 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "f74aa8102a1ea266a7a03a30f103f901813b1444", "tree": "1accedf2a6a7b2b5e21da0df9b55ca5cf7ce8132", "parents": [ "20d29d64689780e63f0f3d760a1cae0384ef0c1b" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 23:15:39 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 23:15:39 2012" }, "message": "Set chromium_code for rlz.\n\nThis does two things:\n\n1.) It enables filename rules. Use this to simplify rlz.gyp.\n2.) It enables more warnings. Fix them.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5902045\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@122 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "20d29d64689780e63f0f3d760a1cae0384ef0c1b", "tree": "179e778d74341cb600f9f76add107266ce6dff10", "parents": [ "5c3c590011d8e41e7d5f7429bbcfba9a376e44f4" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 22:23:15 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 22:23:15 2012" }, "message": "rlz: Add a dependency on dynamic_annotations\n\nThere\u0027s a bug where libraries using singleton or lazyinstance need to explicitly\ndepend on this for the components build to work. For normal builds, it should\nbe a no-op.\n\nPatch from Ryan Sleevi \u003crsleevi@chromium.org\u003e\n\nBUG\u003dnone\nTEST\u003d\u0027win\u0027 trybots compile again\nTBR\u003drogerta\n\nReview URL: https://codereview.appspot.com/5940048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@121 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "5c3c590011d8e41e7d5f7429bbcfba9a376e44f4", "tree": "39d774c77308b4f045c23a146436c63472458352", "parents": [ "0c753a3b950b4d84168990f34904a3d80ea2a042" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 17:37:41 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 17:37:41 2012" }, "message": "Speculative fix for mini_installer size increase.\n\nAt least on Mac and Linux, the linker loads object files from static libraries\nby loading a .o file that contains symbols it\u0027s missing, then adds symbols\nneeded by that .o file to the missing symbol list, and then it repeats that\nprocess. Since uninstall.cc uses SupplementaryBranding and calls\nClearProductState, that causes rlz_lib.o to be loaded. That references\nsymbols in financial_ping.cc, which references net.\n\nIn the hope of msvc\u0027s linker working the same way, move the symbols used\nby uninstall.cc into its own file that doesn\u0027t depend on symbols in\nfinancial_ping. That way, the linker hopefully won\u0027t pull in net and content\nwhen linking mini_installer.\n\nBUG\u003dchromium:120427\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5936043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@120 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "0c753a3b950b4d84168990f34904a3d80ea2a042", "tree": "af26f4f5c36b1a982a158f53fab465a8207d4d31", "parents": [ "bbc32998d51a868468f7b0a858774d2b2c56adde" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 16:49:32 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 27 16:49:32 2012" }, "message": "Remove a static initializer from rlz.\n\nBUG\u003dchromium:120335\n\nReview URL: https://codereview.appspot.com/5918044\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@119 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "bbc32998d51a868468f7b0a858774d2b2c56adde", "tree": "09661454b40190db20b2ca763e13e5f183a0f59c", "parents": [ "c1b5098c17157531f2663da1cfb76f96af434784" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sun Mar 25 22:53:44 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sun Mar 25 22:53:44 2012" }, "message": "Use base::mac::ScopedNSAutorleasePool only on mac.\n\nBUG\u003dnone\nTEST\u003dnone\nTBR\u003drogerta\n\nReview URL: https://codereview.appspot.com/5903057\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@118 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "c1b5098c17157531f2663da1cfb76f96af434784", "tree": "437e5f60ec883fd7371314bcfc7a529a697befa0", "parents": [ "ab82473a52c414fd63808e840a5a11fb1dc47373" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sun Mar 25 21:59:59 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sun Mar 25 21:59:59 2012" }, "message": "Push RLZ_NETWORK_IMPLEMENTATION_ define to dependent targets.\n\nThis way, the #ifdef in rlz_lib.h is handled correctly when rlz_lib.h is\nincluded in files in targets that depend on rlz.\n\nBUG\u003dnone\nTEST\u003dnone\nTBR\u003drogerta\n\nReview URL: https://codereview.appspot.com/5903056\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@117 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "ab82473a52c414fd63808e840a5a11fb1dc47373", "tree": "d6e00772a95311e508cfbfb558e6835410430db4", "parents": [ "4b0f6f750c1d4abbcf1d8bae137b5dd886dbf0b7" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sun Mar 25 20:45:38 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sun Mar 25 20:45:38 2012" }, "message": "Tweaks to make the use of chrome\u0027s net stack forceable through gyp.\n\nAlso whitelist usage of \"net\" and (for now) \"content\" for check_deps\n\nBUG\u003dnone\nTEST\u003dnone\nTBR\u003drogerta\n\nReview URL: https://codereview.appspot.com/5907059\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@116 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4b0f6f750c1d4abbcf1d8bae137b5dd886dbf0b7", "tree": "c66553c9a1f1f65b354626275f8310e2a1627462", "parents": [ "19b439b262609d7f38e4801acdc00524408fdbe8" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 22:23:48 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 22:23:48 2012" }, "message": "mac: Implement the locking part of ScopedRlzValueStoreLock.\n\nBUG\u003dchromium:117738\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5874061\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@115 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "19b439b262609d7f38e4801acdc00524408fdbe8", "tree": "610c0a6c2a3d69475b570377dea6c91063d050a5", "parents": [ "3da2d45a35ae86f953c51efcd6e36501c1b8d770" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 20:50:17 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 20:50:17 2012" }, "message": "mac: Implement GetMachineId().\n\nBUG\u003dchromium:117739\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5876066\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@114 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "3da2d45a35ae86f953c51efcd6e36501c1b8d770", "tree": "057f9f99a710d13c42414f7ed0fd0f6537385f51", "parents": [ "2c70f6855863e46cd444449b0f042feec6edc1b2" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 15:40:17 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 15:40:17 2012" }, "message": "Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc\n\nBUG\u003dnone\nTEST\u003dnone\nTBR\u003drogerta\n\nReview URL: https://codereview.appspot.com/5875051\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@113 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "2c70f6855863e46cd444449b0f042feec6edc1b2", "tree": "f341e2f73c5cee56ecf38e43537cf88f0e552254", "parents": [ "b01fb2e2242c56d5b717fcfb42438ce5cedd4f70" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 14:41:22 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 14:41:22 2012" }, "message": "Don\u0027t pay a static initializer for expected_assertion_ when it\u0027s not used.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5883056\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@112 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "b01fb2e2242c56d5b717fcfb42438ce5cedd4f70", "tree": "345a82b3aa1b48def9f4e53a616b0ddd8fa84d1b", "parents": [ "9805e83dfad2c0f48ae890ccf9bf18d71e96fa57" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 01:31:05 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 23 01:31:05 2012" }, "message": "Minor cleanups.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5882054\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@111 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "9805e83dfad2c0f48ae890ccf9bf18d71e96fa57", "tree": "2c9f3a3a6cbfc3d304d8474c929fd4a106e4826f", "parents": [ "66db7225a29c7129b169e7b52f37f1cc145fc0b5" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 22:36:37 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 22:36:37 2012" }, "message": "Implement GetSystemTimeAsInt64() on mac.\n\nBUG\u003dchromium:118232\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5874054\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@110 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "66db7225a29c7129b169e7b52f37f1cc145fc0b5", "tree": "41a19f9578b35330683c9235ee8b8197aaa0bfd4", "parents": [ "dd49aa19545ff33a13149b84816c7a594feb9e71" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 22:32:37 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 22:32:37 2012" }, "message": "Move GetMachineId() to its own file.\n\nThe sha1 logic is now shared cross-platform which calls out to a\nplatform-specific function to get system data.\n\nGetMachineId() now returns a string instead of a wstring. The SID\nis still a string16 instead of a wstring, which is the same on windows.\n(I considered making it a string too, but considered it too risky since\nif a wide character creeps in somehow it\u0027d change the SHA result.)\n\nThe platform-specific implementation on mac is still empty.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5877053\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@109 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "dd49aa19545ff33a13149b84816c7a594feb9e71", "tree": "34eb1a79359b36966f8736b716be9ca054c84632", "parents": [ "05a033b03326f80adf5044a303b09db1fb4abde2" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 21:19:45 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 21:19:45 2012" }, "message": "Implement RlzValueStoreMac.\n\nIt writes to an in-memory dictionary that\u0027s read from disk when the\nstore lock is acquired and that writes to disk the that lock is released.\n\nThe lock implementation itself will be done in another CL.\n\nSince all tests do now pass, enable them on mac.\n\nBUG\u003dnone\nTEST\u003dunit tests\n\nReview URL: https://codereview.appspot.com/5885047\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@108 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "05a033b03326f80adf5044a303b09db1fb4abde2", "tree": "14970cea91a008700b5b0f811b3a5fbcff516549", "parents": [ "b15019f4067f8db4d6a29309cd46b75e08852394" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 16:51:36 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 16:51:36 2012" }, "message": "rlz: Add an implementation of PingServer() that uses chrome\u0027s net stack.\n\nOne can select an implementation via a gyp variable that defaults to wininet\non windows.\n\nPingServer() currently has blocking semantics (it\u0027s already called on a thread\nin chrome), so the chrome net implementation is that way too. However, when\nchrome\u0027s net stack is used, an URLRequestContextGetter needs to be passed\nto rlz explicitly. That\u0027s a bit fishy from an API perspective, but having a 2nd\nDNS resolver, proxy cache, etc in chrome just for RLZ felt wrong.\n\nUnfortunately, URLFetcher is currently in chrome\u0027s \u0027content\u0027 module, so this\nadds a dependency on \u0027content\u0027. akalin is moving it to \u0027net\u0027, and once that\u0027s\ndone only a dependency on \u0027net\u0027 is required. In the test code, I was careful\nto not use BrowserThread, so that the test doesn\u0027t depend on \u0027content\u0027 either.\n\nBUG\u003dchromium:117741\nTEST\u003drun rlz_unittests on mac with a local server, observe request\n\nReview URL: https://codereview.appspot.com/5864055\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@107 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "b15019f4067f8db4d6a29309cd46b75e08852394", "tree": "e932ceab977e7b01bb5865c9d721687be22d811a", "parents": [ "65cafbb14a9ac62c4c6bb9486759d89dddd2aee2" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 05:14:09 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 22 05:14:09 2012" }, "message": "Fix \"expression result unused\" warning caused by VERIFY() use.\n\nReview URL: https://codereview.appspot.com/5876048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@106 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "65cafbb14a9ac62c4c6bb9486759d89dddd2aee2", "tree": "6c00dbc60efd8877dbd251f24bd0471b87db02eb", "parents": [ "e733324d0558f75a8e50991f404447e29f4c71ec" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 21 23:16:41 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 21 23:16:41 2012" }, "message": "Move rlz_lib_test.cc and financial_ping_test.cc to common directory.\n\nNo code change.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5876046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@105 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "e733324d0558f75a8e50991f404447e29f4c71ec", "tree": "0b5e7fee56ab7eaefa5ffc953661a308e4689642", "parents": [ "409d46af5364dd4982ae97497c414f48d948ffe0" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 21 23:10:25 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 21 23:10:25 2012" }, "message": "Move rlz_test_helpers from win\\test to test.\n\nPure code move, no code change.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5880043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@104 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "409d46af5364dd4982ae97497c414f48d948ffe0", "tree": "441aa08723c3f885817e274b28c69b40d2d0abf5", "parents": [ "a1075fee2eeba018fad97edef742c573e33c8615" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 21 22:58:09 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 21 22:58:09 2012" }, "message": "Add OVERRIDE annotations to rlz_test_helpers.\n\nNo functionality change.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5874046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@103 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a1075fee2eeba018fad97edef742c573e33c8615", "tree": "f1949f1da9098f94767960cbfdb8303a8016ffd0", "parents": [ "4fd337e60d1b898a1be658684bb5d948a58289fd" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 20 20:23:39 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 20 20:23:39 2012" }, "message": "Move registry functions from lib_values into rlz_value_store_registry.\n\nAlmost all of them are now used only there.\nReview URL: https://codereview.appspot.com/5863043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@102 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4fd337e60d1b898a1be658684bb5d948a58289fd", "tree": "dc0d618340380410512573d834b1dc9b99ca5e2f", "parents": [ "7437f5e1e5ce7a21581d7bd986ff811ea29b9c14" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 20 20:23:30 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 20 20:23:30 2012" }, "message": "Make rlz_lib_test.cc and financial_ping_test.cc build on mac.\nReview URL: https://codereview.appspot.com/5862043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@101 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "7437f5e1e5ce7a21581d7bd986ff811ea29b9c14", "tree": "8613e86f4695ccad68bb02aba0650a9bf2a360e9", "parents": [ "5cc2762f1988577ff44d2730d9f9806cf76fc17d" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 20 19:22:32 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 20 19:22:32 2012" }, "message": "Let FinancialPingTest use RlzValueStore instead of doing direct registry access.\n\nReview URL: http://codereview.appspot.com/5841075/\n\n\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@100 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "5cc2762f1988577ff44d2730d9f9806cf76fc17d", "tree": "537c3def0027aec6c7e3291440724579a39519bb", "parents": [ "4892bb3454af9f308043f5d152643972c9b2b15e" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 19:40:46 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 19:40:46 2012" }, "message": "Move ClearProductState() to common code.\n\nPure code move\n\nBUG\u003dnone\nTEST\u003dnone\nTBR\u003drogerta\n\nReview URL: https://codereview.appspot.com/5845053\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@99 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4892bb3454af9f308043f5d152643972c9b2b15e", "tree": "acbed6e10c303710a2baf68ea2d793d7ec0b1ae3", "parents": [ "4425b6f0e2e6a73304d66db113ab5912d391e98b" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 19:36:15 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 19:36:15 2012" }, "message": "Move ClearProductState() to RlzValueStore.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5849047\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@98 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4425b6f0e2e6a73304d66db113ab5912d391e98b", "tree": "70effd48d27223977bc06c58217336f8eb7b81c3", "parents": [ "2f975bba9e7bb9b55753697dfe35f9d94f7f09c6" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 18:16:33 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 18:16:33 2012" }, "message": "Move ClearAllProductEvents() to shared code. Pure code move.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5846048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@97 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "2f975bba9e7bb9b55753697dfe35f9d94f7f09c6", "tree": "15ee01fb813cd4467d803e780bcd1603b99a7289", "parents": [ "1fa124211e26cb8532aafb6f60e1d7a80a6158d4" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 18:13:22 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 18:13:22 2012" }, "message": "Move ClearAllProductEvents() to use RlzValueStore.\n\nThere\u0027s a small behavior change here: Previously, ClearAllProductEvents()\nwould take the rlz lock, clear product events, release the lock, take it\nagain, and then clear stateful events. Now, the lock isn\u0027t released in between.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5846047\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@96 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "1fa124211e26cb8532aafb6f60e1d7a80a6158d4", "tree": "84657075c09a64b65d53fcdc5364b1a58336f71d", "parents": [ "92d9d01fe07359d57eb63527258e4be9f74a358c" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 16:05:27 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 16:05:27 2012" }, "message": "Move SupplementaryBranding from win/lib/rlz_lib.h to lib/rlz_lib.h\n\nMove the implementation of the class from lib/lib_values.cc to lib/rlz_lib2.cc.\n\nChange the class to not use a scoped_ptr, so that rlz_lib.h doesn\u0027t have to\nexpose the implementation detail that rlz uses chromium\u0027s base.\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5849044\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@95 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "92d9d01fe07359d57eb63527258e4be9f74a358c", "tree": "6a3b92b4737dd3f086be6987238bdc2ab0218608", "parents": [ "9e1915d17580b1f7cc2f38e199107e6a2667330c" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:45:43 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:45:43 2012" }, "message": "Move GetProductEventsAsCgi() to shared code\n\nPure code move. Depends on https://codereview.appspot.com/5835049/\n\nBUG\u003dnone\nTEST\u003dnone\n\nReview URL: https://codereview.appspot.com/5835050\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@94 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "9e1915d17580b1f7cc2f38e199107e6a2667330c", "tree": "7143154eaef49df39655bb2f7bb49971edd5ac08", "parents": [ "6b905657a19ca5835e7fa1a011fa53394cb21575" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:40:42 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:40:42 2012" }, "message": "Windows build fix.\n\nThe last 4 commits (including this one) were all http://codereview.appspot.com/5823061/.\n(git svn mishap)\n\n\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@93 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "6b905657a19ca5835e7fa1a011fa53394cb21575", "tree": "20fdde08d9842eefe7d98002548658b12750df45", "parents": [ "e9c75d8250ed69e25aa7e21c1df6a0309d90140a" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:30:53 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:30:53 2012" }, "message": ".\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@92 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "e9c75d8250ed69e25aa7e21c1df6a0309d90140a", "tree": "1344b6e5a339117cebe28b9cb9e66de744ad72ac", "parents": [ "a69a3c5fc313137fb689efd1d5668439c6b6a77a" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:30:49 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:30:49 2012" }, "message": ".\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@91 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a69a3c5fc313137fb689efd1d5668439c6b6a77a", "tree": "1e93aedbf1e39103e68a9d3284e499a49d11d203", "parents": [ "fa84f2e4b7b0c96f98b4ab79bccbb8b52dbd5c45" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:30:41 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:30:41 2012" }, "message": "wip\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@90 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "fa84f2e4b7b0c96f98b4ab79bccbb8b52dbd5c45", "tree": "5a6c6bf79e803c2517cf428e8576965c91e387f6", "parents": [ "0ebc0446ab26c7422d6eca2062fa2fec9a766052" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:24:15 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Mar 16 14:24:15 2012" }, "message": "Change the return type of GetProductEventsAsCgiHelper() from DWORD to bool.\nReview URL: https://codereview.appspot.com/5835049\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@89 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "0ebc0446ab26c7422d6eca2062fa2fec9a766052", "tree": "e9ac66031cdfd8daa02994af8cf69ee917d4e7cd", "parents": [ "956b42ba57c7cf8b5d3206179436a231e712ecb3" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 15 20:46:59 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 15 20:46:59 2012" }, "message": "Add a ReadProductEvents() method to RlzValueStore.\n\nChange GetProductEventsAsCgiHelper() to use it.\n\nAlso address review comments on earlier CLs.\nReview URL: https://codereview.appspot.com/5837049\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@88 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "956b42ba57c7cf8b5d3206179436a231e712ecb3", "tree": "30334723ed650bb3c4229a82e2175621b937cceb", "parents": [ "f1b9a90b24d9f21f73bba4c05faf77b2a0f01965" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:45:39 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:45:39 2012" }, "message": "Move SendFinancialPing() and ParseFinancialPingResponse() to the shared code.\n\nNo code change at all, just moving the functions around as is.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5784082\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@87 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "f1b9a90b24d9f21f73bba4c05faf77b2a0f01965", "tree": "90134200f62ae33bb59c22262b9e826e67416a25", "parents": [ "1a44dce82efaa95ace52620f4742e1a415d1a2af" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:37:40 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:37:40 2012" }, "message": "Move a few functions from win/lib/rlz_lib.cc ot the shared code.\n\nMove these functions:\n* ParsePingResponse()\n+ Almost completely unchanged. Changed the LibMutex at the top into\n a ScopedRlzValueStoreLock.\n\n* RecordProductEvent\n+ Almost completely unchanged. Removed the GetProductName() call with\n NULL check -- this is done again in the AddProductEvent() call, so\n it was a no-op.\n\n* ClearProductEvent(), GetEventsFromResponseString(), RecordStatefulEvent()\n+ Completely unchanged.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5822053\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@86 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "1a44dce82efaa95ace52620f4742e1a415d1a2af", "tree": "492d4cfc66e3e18e5cca42fd4e3b6d23e82651c2", "parents": [ "b6f0aa65277fd9883bc48adc37e928b351ca5908" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:16:50 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:16:50 2012" }, "message": "Tiny change to prepare moving ParsePingResponse to the shared part.\n\nNo functionality change.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5820057\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@85 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "b6f0aa65277fd9883bc48adc37e928b351ca5908", "tree": "50ef259d9f92683dae57025ab91081aaadbb5104", "parents": [ "3eea1b96994cb2656d66c6f2d31ff1f01f05bec6" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:13:14 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:13:14 2012" }, "message": "Mac build fix after my last CL.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5784081\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@84 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "3eea1b96994cb2656d66c6f2d31ff1f01f05bec6", "tree": "10ae1acb9decece88d25f70ec4e34bbf33ebb6a3", "parents": [ "7e5ab10c6001186ca6d6d9209b18562205cc0ac4" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:10:17 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 22:10:17 2012" }, "message": "Change ClearProductEvent to use RlzValueStore.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5824057\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@83 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "7e5ab10c6001186ca6d6d9209b18562205cc0ac4", "tree": "96d4b5b9c5f3e218bf7ff6d37d9e5ddd13147759", "parents": [ "825fd878541dd9251935e40f46399991b1a5f61d" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 21:59:30 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 21:59:30 2012" }, "message": "Move RecordProductEvent to use RlzValueStore.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5822052\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@82 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "825fd878541dd9251935e40f46399991b1a5f61d", "tree": "1932fcdebf6854a23c955aa5ffb2117e521b961f", "parents": [ "6f85da09b541674ae81d22fc7b0685d5cec8cac3" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 21:44:19 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 21:44:19 2012" }, "message": "Move stateful events to RlzValueStore.\n\nBecause this is somewhat entangled with product events,\ndon\u0027t move the code out of win/lib/rlz_lib.cc yet.\nReview URL: https://codereview.appspot.com/5821052\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@81 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "6f85da09b541674ae81d22fc7b0685d5cec8cac3", "tree": "acb9fcdff875a67daffb8128c519fe01a634f2c9", "parents": [ "4e7ec6734f671d7bd69b866929307f7cebdddee6" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 20:04:35 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 20:04:35 2012" }, "message": "mac: Remove stub GetPingParams(), since the real implementation is now available.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5820053\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@80 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4e7ec6734f671d7bd69b866929307f7cebdddee6", "tree": "1b56d2e35e9b8723294d0d9932910ab317f02cab", "parents": [ "f0c4d8b13c7f870e87ebad636107778f437dd630" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 18:48:18 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 18:48:18 2012" }, "message": "Address comments from https://codereview.appspot.com/5823050/\nReview URL: https://codereview.appspot.com/5825051\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@79 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "f0c4d8b13c7f870e87ebad636107778f437dd630", "tree": "053e4794fcb57e7af06ae2a677cdb694dcf77b5c", "parents": [ "7a88d3d043ff24264f3d91b3108931385a376078" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 18:21:39 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 18:21:39 2012" }, "message": "Move FormFinancialPingRequest() to the common part.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5821047\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@78 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "7a88d3d043ff24264f3d91b3108931385a376078", "tree": "6985fc6dd2bc7fc5e8b3a2450f8cbeff1dc53c05", "parents": [ "cb7462088fb15082b99274002f689e4632eef09e" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 18:02:15 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 18:02:15 2012" }, "message": "Move PingFinancialServer to common part.\n\nAlso remove 2 \"string::size() \u003c 0\" checks, since that function\nreturns an unsigned int.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5819051\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@77 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "cb7462088fb15082b99274002f689e4632eef09e", "tree": "07181ec4280f8eb4388af247844dc18c33e3a9f4", "parents": [ "2b06b726e82b35c9d459f710a1f0fa683086d8cf" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 17:50:13 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 17:50:13 2012" }, "message": "Move GetPingParams() and ParseFinancialPingResponse() to the common code.\nReview URL: https://codereview.appspot.com/5823050\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@76 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "2b06b726e82b35c9d459f710a1f0fa683086d8cf", "tree": "87752cc6e7ad0bfe6db8a63de709d6d113d8dcdf", "parents": [ "bdfb9aaa867d12337e5d5d0cd2e001eb2fbfc577" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 16:16:17 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 14 16:16:17 2012" }, "message": "Start moving functions from win/lib/rlz_lib.h to lib/rlz_lib.h\n\nStart with SetAccessPointRlz() and GetAccessPointRlz(). Add storage\nfunctions for these to RlzValueStore.\n\nNo intended behavior change.\nReview URL: https://codereview.appspot.com/5814044\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@75 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "bdfb9aaa867d12337e5d5d0cd2e001eb2fbfc577", "tree": "0f34f392d8c15cb545331522771c50bbaf862eb0", "parents": [ "a78f1b8ed7ead2eaa0e5f52faf2acb8cecba1bc6" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 13 22:27:08 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 13 22:27:08 2012" }, "message": "Change the unit of several constants from WCHARs to bytes.\n\nChange kMaxRlzLength, kMaxDccLength, kMaxCgiLength, and kMaxPingResponseLength.\n\nThey are always used with char arrays, and chrome even allocates char[kMaxCgiLength+1]\nfor its buffers -- which would be too small if these really were in WCHARs.\n\nI kept the value alone, let me know if you think kMaxCgiLength should become 4096 or\nkMaxPingResponseLength should become 0x8000.\n\nThe buffer backing kMachineIdLength is wchar_t, so don\u0027t change that for now.\n\nComment-only, so no functionality change.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5816043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@74 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a78f1b8ed7ead2eaa0e5f52faf2acb8cecba1bc6", "tree": "625e075cf6b62b96beb86d5559c896defabc7605", "parents": [ "3750a75dc592ebc9cc60718849fa1f0399dc9044" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 13 21:35:56 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 13 21:35:56 2012" }, "message": "Delete unused function IsGoodRlz().\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5812044\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@73 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "3750a75dc592ebc9cc60718849fa1f0399dc9044", "tree": "664a3abb5e8379340b0210761b8d4438d643900d", "parents": [ "ab88db9d10f43f5392ceb95b9e02c655aef25e13" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 13 18:02:34 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Mar 13 18:02:34 2012" }, "message": "Start moving FinancialPing over to the cross-platform part.\n\nSince FinancialPing is fairly intertwined with rlz_lib.cc,\nadd a few stub methods on mac to keep this patch small for now.\n\nMove all the enums in rlz_lib.h (which is still windows-only) into\na new file lib/rlz_enums.h.\n\nIntroduce lib/rlz_value_store, which will slowly grow more methods\nto abstract away all registry reads. rlz_lib.cc will talk only to\nRlzValueStore, and the windows implementation of that file will\nwrite to the registry. Give this class 4 methods as proof-of-concept\nfor now, just enough to move FinancialPing over.\n\nDon\u0027t move financial_ping_test.cc yet, as it more or less relies on\neverything working to pass (it calls several functions from rlz_lib.cc).\n\nReview URL: https://codereview.appspot.com/5754080/\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@72 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "ab88db9d10f43f5392ceb95b9e02c655aef25e13", "tree": "bc372944322e6dbe6b4eea73d5de2229119481ac", "parents": [ "116c1c425aac1137e682b287891a8b5b4baa4eae" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 01:13:50 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 01:13:50 2012" }, "message": "Remove unused user_key parameter from a few functions.\n\nEvery caller was passing HKEY_CURRENT_USER.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5789043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@71 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "116c1c425aac1137e682b287891a8b5b4baa4eae", "tree": "2389324d0d57dcad0cb80f0ca4267ddfeb85ad00", "parents": [ "609167193fcedb31d984047a0933a560122db0b0" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 01:02:30 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 01:02:30 2012" }, "message": "Various minor behavior-preserving changes to financial_ping.cc\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5787047\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@70 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "609167193fcedb31d984047a0933a560122db0b0", "tree": "fd5eabe97a6353aae5e32e654a0f04babf5ef4a6", "parents": [ "084792f9571fb85523ef4977dc699b7d5561838d" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 00:28:40 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 00:28:40 2012" }, "message": "Remove declaration of a method that isn\u0027t defined or used anywhere.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5785048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@69 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "084792f9571fb85523ef4977dc699b7d5561838d", "tree": "14f8c1be9d7b4a1067a2afefbdf4a6b2fa88ef1c", "parents": [ "edb7f601b7c67360eaba904717a8127181270769" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 00:07:30 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Mar 08 00:07:30 2012" }, "message": "Remove now-unused static UserKey::HasAccess() method.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5787046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@68 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "edb7f601b7c67360eaba904717a8127181270769", "tree": "9e51ec161ddf9166c915f1ded14f6dc51db94c6b", "parents": [ "989bdfbeafc78e8cdbc7021acddbb8a83e8318e2" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 07 23:50:42 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Mar 07 23:50:42 2012" }, "message": "Remove an effectively unused overload of GetAccessPointRlz().\n\nIt\u0027s not part of the public api either.\n\nNo intended behavior change.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5784047\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@67 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "989bdfbeafc78e8cdbc7021acddbb8a83e8318e2", "tree": "0f58ed82f866eec7cc82ce40cad1a472facac145", "parents": [ "fb1b49475d06362a87c39ecd1ca8df9bab710e87" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 21:56:48 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 21:56:48 2012" }, "message": "Windows build fix: Remove sid from the exports file too.\n\nI missed to build the dll locally :-/\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5696050\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@66 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "fb1b49475d06362a87c39ecd1ca8df9bab710e87", "tree": "d60b3c69ed1d6b8ca321a1a7b1592d1a0102aca4", "parents": [ "56f2c223765ee7cd289be7f3a6c22ef5e7a45d09" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 20:33:27 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 20:33:27 2012" }, "message": "Remove sid parameter from UserKey constructor.\n\nAll callers pass in NULL now anyway.\nReview URL: https://codereview.appspot.com/5693051\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@65 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "56f2c223765ee7cd289be7f3a6c22ef5e7a45d09", "tree": "ffafba5cc175436a4e2bf6a319d30c3190bf04a1", "parents": [ "4a9e2d7fd11e6907cee38ae1521a954e2caca860" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 19:06:42 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 19:06:42 2012" }, "message": "Remove sid from FinancialPing.\n\nMechanical change.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5700051\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@64 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4a9e2d7fd11e6907cee38ae1521a954e2caca860", "tree": "975f3eb169e8ca8af29311b677b46c774f757b97", "parents": [ "780c800614bab3eff0fe2c56cded4c30b67236ad" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 18:57:58 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 18:57:58 2012" }, "message": "Remove pointless indirection.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5694055\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@63 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "780c800614bab3eff0fe2c56cded4c30b67236ad", "tree": "954812e2b2273eb79f03af755ed4091b205dc1d6", "parents": [ "b665a485a19451aeb3a57a59d68b26d63e2e1928" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 18:52:48 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 18:52:48 2012" }, "message": "Remove the \"sid\" parameter from the interface.\n\nClients have been advised to not set this for a long time, and it\ndefaults to NULL.\nReview URL: https://codereview.appspot.com/5696046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@62 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "b665a485a19451aeb3a57a59d68b26d63e2e1928", "tree": "f8935d3a6e36910d5463bc6211a627442c18da13", "parents": [ "086767e2b5c227f5a429f9ecfc7b3dbf7e55d797" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 17:21:06 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 17:21:06 2012" }, "message": "Roll gyp to the version currently used by chromium (1233).\n\nThe old gyp version could no longer generate msvc2010 projects.\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5698048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@61 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "086767e2b5c227f5a429f9ecfc7b3dbf7e55d797", "tree": "b57388d5c245e9a8545e12854351c1af9c1da750", "parents": [ "d9386b1694c3fad1f79ccf0aaeb9fd8d71b41f89" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 16:31:33 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 23 16:31:33 2012" }, "message": "Remove an unused parameter.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5694049\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@60 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "d9386b1694c3fad1f79ccf0aaeb9fd8d71b41f89", "tree": "ae0690505f05dd6da2c3247a707623b5c2a83699", "parents": [ "bfdd8997ca0e2f06b4fdb7d19fdaf06a1411d86c" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 22:44:29 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 22:44:29 2012" }, "message": "Attempted windows build fix.\n\nTBR\u003drogerta\nReview URL: https://codereview.appspot.com/5656093\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@59 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "bfdd8997ca0e2f06b4fdb7d19fdaf06a1411d86c", "tree": "74d683ba96b454e9999ab0fabdbea35dbce2a7f1", "parents": [ "b7f8c1b32bce654778d11e31e6fb85fcd2ce5856" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 20:00:57 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 20:00:57 2012" }, "message": "Move lib_values to cross-platform part.\nReview URL: https://codereview.appspot.com/5675079\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@58 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "b7f8c1b32bce654778d11e31e6fb85fcd2ce5856", "tree": "8eac54941c9167542423de0619295e17a320b761", "parents": [ "62a0d60f7d21b0ea3e9dcd38035edc20e7ced2f6" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 16:38:47 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 16:38:47 2012" }, "message": "Move crc32 to cross-platform part.\nReview URL: https://codereview.appspot.com/5674090\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@57 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "62a0d60f7d21b0ea3e9dcd38035edc20e7ced2f6", "tree": "10f0aabe016abcc116daaea229cbdacfe94f9049", "parents": [ "7527ff0c2feb8bc1adc4078c750fc3aad2280ebc" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 16:38:28 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 16:38:28 2012" }, "message": "Remove some \"win\"s I missed when moving assert.h.\nReview URL: https://codereview.appspot.com/5673082\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@56 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "7527ff0c2feb8bc1adc4078c750fc3aad2280ebc", "tree": "9c557801dcb8cf9386b5155083373ba71864f8ae", "parents": [ "e944995b10320428c5dae849bd5cd07cace0efbb" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 16:10:52 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 16:10:52 2012" }, "message": "Move string_utils to the cross-platform part.\n\nAlso convert it from wstring to string16 and fix a few\nwarnings. No intended functionality change.\n\nBUG\u003dchromium:46579\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@55 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "e944995b10320428c5dae849bd5cd07cace0efbb", "tree": "6f45dab3e3a33133d0216a51185c55a8edcc5b95", "parents": [ "c1df91a82494ba2d9a58fd6b9c6ef9c25b1d576a" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 01:29:09 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Feb 17 01:29:09 2012" }, "message": "Move assert.h to the cross-platform part.\n\nNo intended functionality change.\nReview URL: https://codereview.appspot.com/5677071\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@54 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "c1df91a82494ba2d9a58fd6b9c6ef9c25b1d576a", "tree": "5231a8039b81bd14a84662b78053e6d1db145056", "parents": [ "9cf86e5a9f63c7416b673f012dd8b7507d500bec" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 16 16:51:21 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Feb 16 16:51:21 2012" }, "message": "Introduce toplevel lib/ and test/ directories for cross-platform code.\n\nMove crc8 there as a first step. Update the gyp file to provide the\ntargets \u0027rlz_lib\u0027 and \u0027rlz_unittests\u0027 on all platforms.\n\nNo intended functionality change.\n\nBUG\u003dchromium:46579\nReview URL: https://codereview.appspot.com/5673062/\n\n\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@53 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "9cf86e5a9f63c7416b673f012dd8b7507d500bec", "tree": "e43bbc2a8d9088576ca5fa564544f9eb8bde7029", "parents": [ "a58c4e7494cbaeda115a5e39f005ed646fd71964" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Feb 15 01:22:54 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Feb 15 01:22:54 2012" }, "message": "Unreviewed build fix.\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@52 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a58c4e7494cbaeda115a5e39f005ed646fd71964", "tree": "2a0e8515453dfcf5d32080876307eb539e9adb4c", "parents": [ "9e6b5c3990e1c24f19cff445362d0a2d5ee2bd2f" ], "author": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Feb 15 01:07:33 2012" }, "committer": { "name": "thakis@chromium.org", "email": "thakis@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Feb 15 01:07:33 2012" }, "message": "Explicitly make the rlz targets win-only (for now).\n\nBUG\u003dchromium:46579\nReview URL: https://codereview.appspot.com/5675051/\n\n\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@51 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "9e6b5c3990e1c24f19cff445362d0a2d5ee2bd2f", "tree": "e9ac14a35916bac86eb82ba546af49c5164361eb", "parents": [ "b45f360498e3816692b0ed8355b9536b08b8cf36" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Sep 26 20:10:28 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Sep 26 20:10:28 2011" }, "message": "Updating RLZ code to use new SHA1 constant since the name has changed.\nReview URL: http://codereview.appspot.com/5134046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@49 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "b45f360498e3816692b0ed8355b9536b08b8cf36", "tree": "2c282ebecf2543c95dd2cbd058cd9d3cb1e31014", "parents": [ "a2459c4005bb0af52d59a0c81fdd1a853ed91f75" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Sep 20 18:47:56 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Sep 20 18:47:56 2011" }, "message": "Remove CHECK which causes crash if there are registry problems on the machine.\nAll the code correctly handles the error, except for one place which is now\nfixed in this CL.\n\nBUG\u003dhttp://code.google.com/p/chromium/issues/detail?id\u003d96640\nReview URL: http://codereview.appspot.com/5039046\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@48 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a2459c4005bb0af52d59a0c81fdd1a853ed91f75", "tree": "450ccf83bc5c732a814d82b60276cbdc1f0fc655", "parents": [ "55012f94523f11deb556064c600dfbee552b2668" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Aug 23 16:16:41 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Aug 23 16:16:41 2011" }, "message": "Refactoring registry initialzation code for testing pursposes, and exposing\nit outside of the RLZ library, so that unit tests in dependent projects (like\nchrome) can include RLZ in their own tests.\nReview URL: http://codereview.appspot.com/4941043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@47 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "55012f94523f11deb556064c600dfbee552b2668", "tree": "691a3fc2ddfc4277a15baf4afde22993be87b253", "parents": [ "ce953a6e73861515e75a6975c4a21bc140d3bea1" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Aug 15 18:24:11 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Aug 15 18:24:11 2011" }, "message": "Include stringprintf.h for StringPrintf/Append functions.\n\nThis is necessary so later we can remove the include of stringprintf.h\nfrom string_util.h in Chromium base/ library.\n\nBUG\u003dNone\nTEST\u003dNone\n\nPatch submitted by: tfarina@chromium.org\nReview URL: http://codereview.appspot.com/4889048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@46 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "ce953a6e73861515e75a6975c4a21bc140d3bea1", "tree": "e3d1233e3f552a0a53da465939aadf010c8a615a", "parents": [ "138abd5e1ba6b0a86f5096aaad690137e300d84f" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Jul 29 20:06:57 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri Jul 29 20:06:57 2011" }, "message": "Add a test to make sure that clearing all product events clears the values\nof stateful events too. This is tested by trying to record a new stateful event\nafter all the events has been cleared; the recording should succeed.\nReview URL: http://codereview.appspot.com/4822053\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@45 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "138abd5e1ba6b0a86f5096aaad690137e300d84f", "tree": "49bc6cfb5b52ff9f47c595f529892df21673a4e7", "parents": [ "7a81d763b9078abeb33f5ca7c2f66ab25fb17b9d" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Jul 28 19:48:55 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Jul 28 19:48:55 2011" }, "message": "When clearign the product state, make sure to clear the stateful events\nregistry key along with the other keys. Not doing this leaves keys\nin the registry that contain subsequent branding code strings.\nReview URL: http://codereview.appspot.com/4806057\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@44 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "7a81d763b9078abeb33f5ca7c2f66ab25fb17b9d", "tree": "8fdfb5c5efb21ec4a2622db61959280dcdd3ddb7", "parents": [ "c15f87117c706fe3bebce05e175e046601faaeed" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Jun 29 00:46:55 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Jun 29 00:46:55 2011" }, "message": "Cleanup: use base/memory/scoped_ptr.h instead of base/scoped_ptr.h.\n\nSubmitted by: thestig@chromium.org\n\nWill sumbit TBR, review done here: http://codereview.appspot.com/4628071/\nReview URL: http://codereview.appspot.com/4627074\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@43 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "c15f87117c706fe3bebce05e175e046601faaeed", "tree": "295bfc5a13e889310f888a137770d10698d54221", "parents": [ "005fe9c5ebb9926d99a34965dc7cbc428d342123" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Jun 22 20:25:21 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Jun 22 20:25:21 2011" }, "message": "Segment RLZ persistence based on branding information.\nThe RLZ library uses the Windows registry to save persistent information.\nAll information for a given product is persisted under keys with the either\nproduct\u0027s name or its access point\u0027s name. This assumes that only\none instance of the product is installed on the machine, and that only one\nproduct brand is associated with it.\n\nIn some cases, a given product may be using supplementary brands. The RLZ\ninformation must be kept separately for each of these brands. To achieve\nthis segmentation, scope all RLZ library calls that deal with supplementary\nbrands within the lifetime of an rlz_lib::ProductBranding instance.\nReview URL: http://codereview.appspot.com/4646048\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@42 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "005fe9c5ebb9926d99a34965dc7cbc428d342123", "tree": "c51aca5bbb0ee31cfab16c2e7c3eabf6c0fbdced", "parents": [ "1d56d8ffd8f1fb53289c8ab9535c1621c8605936" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri May 06 18:43:15 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Fri May 06 18:43:15 2011" }, "message": "Adding definitions for new Product and access point enums.\n\nBUG\u003dNone\nTEST\u003dNone\nReview URL: http://codereview.appspot.com/4464045\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@39 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "1d56d8ffd8f1fb53289c8ab9535c1621c8605936", "tree": "0f64e54ef4509f6ae798c8ae256647ac03bbe2e3", "parents": [ "4d4949bac7a24dfe409996ce29d77246a09322ac" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu May 05 20:12:21 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu May 05 20:12:21 2011" }, "message": "The RLZ unit tests override the HKCU and HKLM registry hives while they run\nin order to start from a known state, make it easier to clean up afterwards,\nand not leave side effects on the machine when done. However, starting\nwith Windows 7, there were some missing registry values in the temporary HKLM\nhive causing the function SetSecurityInfo() to fail, and hence the unit tests\nto fail.\n\nTo fix, I added code to copy some portions of the HKLM hive to the temporary\ntest hive so that SetSecurityInfo() can run successfully.\n\nBUG\u003dNone\nTEST\u003dMake sure unit tests run correctly on a Windows 7 machine, in both debug\nand release\nReview URL: http://codereview.appspot.com/4479043\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@38 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4d4949bac7a24dfe409996ce29d77246a09322ac", "tree": "24f814297e7bc9b939c5a59988479cb4ba2abbe9", "parents": [ "1c68930071c624184b9374a276315bc599b78b6a" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon May 02 15:21:33 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon May 02 15:21:33 2011" }, "message": "Make sure gmock is included when doing a checkout of the RLZ project. Seems\nlike the way this dependency was being picked has changed. Will commit TBR.\nReview URL: http://codereview.appspot.com/4432087\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@37 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "1c68930071c624184b9374a276315bc599b78b6a", "tree": "75b7b5e5dd6f68678cb8f09dc55a5ed315e31eb8", "parents": [ "a93330bba0ea1bfb1fbb82d594c8b7fb23b73683" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Apr 28 03:20:36 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Apr 28 03:20:36 2011" }, "message": "Fixing DEPS file to get correct version of chrome base, needed for r33.\nReview URL: http://codereview.appspot.com/4439079\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@36 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a93330bba0ea1bfb1fbb82d594c8b7fb23b73683", "tree": "1e70d89d6e1061db6ef0bc5dd9bc9bf19686b870", "parents": [ "094d00e5fd251274297025a72cc23d3f6cad001c" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Apr 28 03:20:07 2011" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Thu Apr 28 03:20:07 2011" }, "message": "Base: Adjust dependencies to build with base.dll BUG\u003d76996 TEST\u003dnone Submitted by rvargas@google.com\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@35 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "094d00e5fd251274297025a72cc23d3f6cad001c", "tree": "c70a68703b073b77c83b5c12b504f7bac5fec41c", "parents": [ "9f28c6ae9381de154115c0badc3e1697c61beaaf" ], "author": { "name": "gwilson@chromium.org", "email": "gwilson@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Jan 24 18:27:00 2011" }, "committer": { "name": "gwilson@chromium.org", "email": "gwilson@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Jan 24 18:27:00 2011" }, "message": "Changes the svn:ignore property of the root directory to include .sln and .vcproj files.\n\n\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@34 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "9f28c6ae9381de154115c0badc3e1697c61beaaf", "tree": "c70a68703b073b77c83b5c12b504f7bac5fec41c", "parents": [ "a2e22f8e010a7d04b5836327aa7ebc6081394aa8" ], "author": { "name": "gwilson@chromium.org", "email": "gwilson@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Jan 18 19:08:59 2011" }, "committer": { "name": "gwilson@chromium.org", "email": "gwilson@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Tue Jan 18 19:08:59 2011" }, "message": "RegKey return value changes for RLZ\n\nPatch by Amit Joshi\n\nBUG\u003dnone\nTEST\u003dcovered by existing tests\n\n\nReview URL: http://codereview.appspot.com/4067041\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@33 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "a2e22f8e010a7d04b5836327aa7ebc6081394aa8", "tree": "5db627914bf9caad50ef76f29415d464bf77726c", "parents": [ "e6a94805baa71f80ae3101e2a6c1869ccfec651e" ], "author": { "name": "gwilson@chromium.org", "email": "gwilson@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sat Jan 08 01:20:59 2011" }, "committer": { "name": "gwilson@chromium.org", "email": "gwilson@chromium.org@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Sat Jan 08 01:20:59 2011" }, "message": "Include base/win/scoped_handle.h instead of base/scoped_handle_win.h.\n\nThis header is going to be removed on chromium soon.\nFix up all callers to use the new location and namespace.\n\nBUG\u003dNone\nTEST\u003dNone\n\nPatch from Thiago Farina \u003ctfarina@chromium.org\u003e\n\nReview URL: http://codereview.appspot.com/3919041\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@32 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "e6a94805baa71f80ae3101e2a6c1869ccfec651e", "tree": "b10a80ff0e458fe4d406f3da8e4b480fd5e69484", "parents": [ "4de50bea7d9e56394a544d609c41a01e68d09754" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Nov 03 15:42:50 2010" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Wed Nov 03 15:42:50 2010" }, "message": "Append base:: in the calls to SStringPrintf.\n\nThis is needed, so then in base library we can remove the\n\u0027using\u0027 declaration of SStringPrintf.\n\nBUG\u003dNone\nTEST\u003drebuild rlz, all 12 projects compiled successfull.\n\nPatch from Thiago Farina \u003ctfarina@chromium.org\u003e\n\nReview URL: http://codereview.appspot.com/2860041\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@31 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" }, { "commit": "4de50bea7d9e56394a544d609c41a01e68d09754", "tree": "16fffae2da64c93a035b7a87dfe14be28b8800cc", "parents": [ "af904fb32ced4b813429b686180feee49b0e7cb7" ], "author": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Oct 25 14:18:31 2010" }, "committer": { "name": "rogerta@google.com", "email": "rogerta@google.com@10bc0f33-e4bf-9a86-80cf-af638054f0c4", "time": "Mon Oct 25 14:18:31 2010" }, "message": "Append base:: in all the remaining calls to StringAppendF.\n\nBUG\u003dNone\nTEST\u003drebuild rlz project. All 12 projects compiled successfull.\n\nPatch from Thiago Farina \u003ctfarina@chromium.org\u003e\n\nReview URL: http://codereview.appspot.com/2706041\n\ngit-svn-id: http://rlz.googlecode.com/svn/trunk@30 10bc0f33-e4bf-9a86-80cf-af638054f0c4\n" } ], "next": "af904fb32ced4b813429b686180feee49b0e7cb7" }