ninjabackend: bring back historical "include_directories(is_system: true)" ordering

Prior to commit a6ddf2534 ("backend/ninja: Extend IncludeDirs.rel_string_list
for backend use"), when include_directories() was called with
`is_system: true` and multiple directories, the resulting `-isystem`
flags appeared on the command line in the opposite order from what was
specified: the last-listed directory was searched first by the compiler.
This was the opposite convention from non-system -I includes, where the
first-listed directory is searched first.

The asymmetry was not intentional; it was a side effect of how
CompilerArgs.__iadd__ handles flags that are not in prepend_prefixes:

- `-I` is in CLikeCompilerArgs.prepend_prefixes, so `__iadd__`
prepends it.  The ninja backend iterates directories in reversed
order and adds them one at a time; the prepend-on-each-add
counteracts the reversal, producing the original order.

- `-isystem` was not in prepend_prefixes, so __iadd__ appended it.
The same reversed one-at-a-time iteration then produced a reversed
sequence — the last-listed directory ended up first on the command line.

Commit a6ddf25634 changed generate_inc_dir to add all directories
in a single bulk commands += call instead of one at a time.  This
preserved the correct order for -I (the double reversal in
__iadd__ still works for a bulk add) but silently broke -isystem,
because appending a list at once preserves input order rather than
reversing it.

Undo the changes a6ddf25634 to preserve the previous behavior.
Adding -isystem to prepend_prefixes would also make the ordering
consistent, but projects that relied on the old reversed
behaviour would silently break.
9 files changed
tree: 2bfc6fd6ad3b466ee6f34f98c326df05f6b6267e
  1. .github/
  2. ci/
  3. cross/
  4. data/
  5. docs/
  6. graphics/
  7. man/
  8. manual tests/
  9. mesonbuild/
  10. packaging/
  11. test cases/
  12. tools/
  13. unittests/
  14. .editorconfig
  15. .flake8
  16. .gitattributes
  17. .gitignore
  18. .mailmap
  19. .mypy.ini
  20. .pylintrc
  21. azure-pipelines.yml
  22. CODEOWNERS
  23. contributing.md
  24. COPYING
  25. MANIFEST.in
  26. meson.py
  27. pyproject.toml
  28. README.md
  29. run_cross_test.py
  30. run_format_tests.py
  31. run_meson_command_tests.py
  32. run_mypy.py
  33. run_project_tests.py
  34. run_shell_checks.py
  35. run_single_test.py
  36. run_tests.py
  37. run_unittests.py
  38. setup.cfg
  39. setup.py
  40. skip_ci.py
README.md

Status

PyPI Build Status Codecov

Dependencies

  • Python (version 3.7 or newer)
  • Ninja (version 1.8.2 or newer)

Latest Meson version supporting previous Python versions:

  • Python 3.6: 0.61.5
  • Python 3.5: 0.56.2
  • Python 3.4: 0.45.1

Installing from source

Meson is available on PyPI, so it can be installed with pip3 install meson. The exact command to type to install with pip can vary between systems, be sure to use the Python 3 version of pip.

If you wish you can install it locally with the standard Python command:

python3 -m pip install meson

For builds using Ninja, Ninja can be downloaded directly from Ninja GitHub release page or via PyPI

python3 -m pip install ninja

More on Installing Meson build can be found at the getting meson page.

Creating a standalone script

Meson can be run as a Python zip app. To generate the executable run the following command:

./packaging/create_zipapp.py --outfile meson.pyz --interpreter '/usr/bin/env python3' <source checkout>

Running

Meson requires that you have a source directory and a build directory and that these two are different. In your source root must exist a file called meson.build. To generate the build system run this command:

meson setup <source directory> <build directory>

Depending on how you obtained Meson the command might also be called meson.py instead of plain meson. In the rest of this document we are going to use the latter form.

You can omit either of the two directories, and Meson will substitute the current directory and autodetect what you mean. This allows you to do things like this:

cd <source root>
meson setup builddir

To compile, cd into your build directory and type ninja. To run unit tests, type ninja test.

More on running Meson build system commands can be found at the running meson page or by typing meson --help.

Contributing

We love code contributions. See the contribution page on the website for details.

IRC

The channel to use is #mesonbuild either via Matrix (web interface) or OFTC IRC.

Further info

More information about the Meson build system can be found at the project's home page.

Meson is a registered trademark of Jussi Pakkanen.