commit 5046447cbdce3f1f3474b84ad4281b9a5c6f8fe7
author James Y Knight <jyknight@google.com> Thu Jul 31 19:07:35 2025
committer Copybara-Service <copybara-worker@google.com> Thu Jul 31 19:11:38 2025
tree 35601adfdb40c9ad520356565545521f7ea6e273
parent 43a98dc6c287ec10202a2c7259cffdec0915dafd

NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (#151545)

Handles clang::DiagnosticsEngine and clang::DiagnosticIDs.

For DiagnosticIDs, this mostly migrates from `new DiagnosticIDs` to
convenience method `DiagnosticIDs::create()`.

Part of cleanup https://github.com/llvm/llvm-project/issues/151026

NOKEYCHECK=True
GitOrigin-RevId: c7f343750744fd0c928b1da67e9dd894a2fe52cf

ClangFormat.cpp

diff --git a/ClangFormat.cpp b/ClangFormat.cpp
index afc40e9..5f6502f 100644
--- a/ClangFormat.cpp
+++ b/ClangFormat.cpp
@@ -241,8 +241,7 @@
       makeIntrusiveRefCnt<llvm::vfs::InMemoryFileSystem>();
   FileManager Files(FileSystemOptions(), InMemoryFileSystem);
   DiagnosticOptions DiagOpts;
-  DiagnosticsEngine Diagnostics(
-      IntrusiveRefCntPtr<DiagnosticIDs>(new DiagnosticIDs), DiagOpts);
+  DiagnosticsEngine Diagnostics(DiagnosticIDs::create(), DiagOpts);
   SourceManager Sources(Diagnostics, Files);
   const auto ID = createInMemoryFile("<irrelevant>", *Code, Sources, Files,
                                      InMemoryFileSystem.get());
@@ -517,9 +516,8 @@
 
     DiagnosticOptions DiagOpts;
     ClangFormatDiagConsumer IgnoreDiagnostics;
-    DiagnosticsEngine Diagnostics(
-        IntrusiveRefCntPtr<DiagnosticIDs>(new DiagnosticIDs), DiagOpts,
-        &IgnoreDiagnostics, false);
+    DiagnosticsEngine Diagnostics(DiagnosticIDs::create(), DiagOpts,
+                                  &IgnoreDiagnostics, false);
     SourceManager Sources(Diagnostics, Files);
     FileID ID = createInMemoryFile(AssumedFileName, *Code, Sources, Files,
                                    InMemoryFileSystem.get());