commit 43a98dc6c287ec10202a2c7259cffdec0915dafd
author James Y Knight <jyknight@google.com> Thu Jul 31 13:57:13 2025
committer Copybara-Service <copybara-worker@google.com> Thu Jul 31 14:02:25 2025
tree b0708360db01ad2e7c512a71ca5c8733fce0bd83
parent 911fc51fb4657b50626a915f4a7509c463e4b169

NFC: Clean up construction of IntrusiveRefCntPtr from raw pointers for llvm::vfs::FileSystem. (#151407)

This switches to `makeIntrusiveRefCnt<FileSystem>` where creating a new
object, and to passing/returning by `IntrusiveRefCntPtr<FileSystem>`
instead of `FileSystem*` or `FileSystem&`, when dealing with existing
objects.

Part of cleanup #151026.

NOKEYCHECK=True
GitOrigin-RevId: 9ddbb478ce11e43ae18aa6d04937a51621021482

ClangFormat.cpp

diff --git a/ClangFormat.cpp b/ClangFormat.cpp
index 24ad3cb..afc40e9 100644
--- a/ClangFormat.cpp
+++ b/ClangFormat.cpp
@@ -237,8 +237,8 @@
 
 static bool fillRanges(MemoryBuffer *Code,
                        std::vector<tooling::Range> &Ranges) {
-  IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> InMemoryFileSystem(
-      new llvm::vfs::InMemoryFileSystem);
+  auto InMemoryFileSystem =
+      makeIntrusiveRefCnt<llvm::vfs::InMemoryFileSystem>();
   FileManager Files(FileSystemOptions(), InMemoryFileSystem);
   DiagnosticOptions DiagOpts;
   DiagnosticsEngine Diagnostics(
@@ -511,8 +511,8 @@
   if (OutputXML) {
     outputXML(Replaces, FormatChanges, Status, Cursor, CursorPosition);
   } else {
-    IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> InMemoryFileSystem(
-        new llvm::vfs::InMemoryFileSystem);
+    auto InMemoryFileSystem =
+        makeIntrusiveRefCnt<llvm::vfs::InMemoryFileSystem>();
     FileManager Files(FileSystemOptions(), InMemoryFileSystem);
 
     DiagnosticOptions DiagOpts;