address a few analysis warnings
diff --git a/.gitignore b/.gitignore
index 3e09de1..5617d32 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@
.packages
.pub
+.dart_tool/
packages
pubspec.lock
deps/sdk
diff --git a/angular_analyzer_plugin/analysis_options.yaml b/angular_analyzer_plugin/analysis_options.yaml
index 613e528..b306593 100644
--- a/angular_analyzer_plugin/analysis_options.yaml
+++ b/angular_analyzer_plugin/analysis_options.yaml
@@ -1,8 +1,8 @@
analyzer:
- strong-mode: true
exclude:
+ # TODO(devoncarew): We should remove this blanket exclusion as it could hide
+ # other issues.
- lib/src/summary/format.dart
- - lib/src/angular_html_parser.dart
linter:
rules:
diff --git a/angular_analyzer_plugin/lib/ast.dart b/angular_analyzer_plugin/lib/ast.dart
index 5f51014..9498409 100644
--- a/angular_analyzer_plugin/lib/ast.dart
+++ b/angular_analyzer_plugin/lib/ast.dart
@@ -358,18 +358,17 @@
void accept(AngularAstVisitor visitor) => visitor.visitTextInfo(this);
}
-/// A wrapper for a given HTML document or
-/// dart-angular inline HTML template.
+/// A wrapper for a given HTML document or dart-angular inline HTML template.
class DocumentInfo extends ElementInfo {
factory DocumentInfo() = DocumentInfo._;
DocumentInfo._()
: super(
'',
- new SourceRange(0, 0),
- new SourceRange(0, 0),
- new SourceRange(0, 0),
- new SourceRange(0, 0),
+ const SourceRange(0, 0),
+ const SourceRange(0, 0),
+ const SourceRange(0, 0),
+ const SourceRange(0, 0),
[],
null,
null,
diff --git a/angular_analyzer_plugin/lib/src/completion.dart b/angular_analyzer_plugin/lib/src/completion.dart
index 9379659..875c30d 100644
--- a/angular_analyzer_plugin/lib/src/completion.dart
+++ b/angular_analyzer_plugin/lib/src/completion.dart
@@ -472,7 +472,7 @@
..parameterTypes =
element.parameters.map((param) => param.type.toString()).toList()
..requiredParameterCount =
- element.parameters.where((param) => param.isRequired).length
+ element.parameters.where((param) => param.hasRequired).length
..hasNamedParameters =
element.parameters.any((param) => param.name != null);
}
diff --git a/angular_analyzer_plugin/test/abstract_angular.dart b/angular_analyzer_plugin/test/abstract_angular.dart
index b12171c..dd49aa7 100644
--- a/angular_analyzer_plugin/test/abstract_angular.dart
+++ b/angular_analyzer_plugin/test/abstract_angular.dart
@@ -158,7 +158,7 @@
new FileContentOverlay(),
contextRoot,
sf,
- new AnalysisOptionsImpl()..strongMode = true);
+ new AnalysisOptionsImpl());
angularDriver = new AngularDriver(
resourceProvider,
new MockNotificationManager(),
diff --git a/angular_analyzer_plugin/test/angular_driver_test.dart b/angular_analyzer_plugin/test/angular_driver_test.dart
index 628dbe1..02da663 100644
--- a/angular_analyzer_plugin/test/angular_driver_test.dart
+++ b/angular_analyzer_plugin/test/angular_driver_test.dart
@@ -19,6 +19,8 @@
import 'abstract_angular.dart';
+// ignore_for_file: deprecated_member_use
+
void main() {
defineReflectiveSuite(() {
defineReflectiveTests(AngularParseHtmlTest);
diff --git a/angular_analyzer_plugin/test/element_assert.dart b/angular_analyzer_plugin/test/element_assert.dart
index f773c2c..1c42873 100644
--- a/angular_analyzer_plugin/test/element_assert.dart
+++ b/angular_analyzer_plugin/test/element_assert.dart
@@ -5,6 +5,8 @@
import 'package:angular_analyzer_plugin/src/selector.dart';
import 'package:test/test.dart';
+// ignore_for_file: deprecated_member_use
+
class AngularElementAssert extends _AbstractElementAssert {
final AngularElement element;
