Cherry-pick 7807b5ccd64a. rdar://149217986

    Loosen WKWebViewConfiguration checks in UIDelegate::UIClient::createNewPage
    https://bugs.webkit.org/show_bug.cgi?id=291346
    rdar://148942809

    Reviewed by Charlie Wolfe.

    In 276636@main I added an additional check on the WKWebViewConfiguration of the created
    WKWebView that could not be synthesized by SPI.  In 285310@main I removed the _relatedWebView
    check which had been superseded.  rdar://148942809 contains a record that somewhere in
    Safari there is a WKWebView being returned that was not created with the given configuration.
    This reverts the check to how it was last year, only checking that _relatedWebView is correct
    if site isolation is off.  That should replace a crash with a missing opener.  Since a missing
    opener is also not great, I added a RELEASE_LOG_FAULT to give us the stack of where this is
    happening so that we can fix it.  I only set openerInfoOfPageBeingOpened in Mac Safari because
    that is the only user of _relatedWebView where this issue can arise.  It's also not technically
    a restriction that you can't create another WKWebView during a WKUIDelegate's
    createWebViewWithConfiguration call because you could be creating a WKWebView to do something
    with other than return it from createWebViewWithConfiguration, but in macOS Safari we know
    it is almost certainly the case that we only create one WKWebView, which means the stack we
    get from the RELEASE_LOG_FAULT should show us where the bug is.

    * Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
    (WebKit::crashWithUIDelegateClassName):
    (WebKit::UIDelegate::UIClient::createNewPage):

    Canonical link: https://commits.webkit.org/293537@main

Canonical link: https://commits.webkit.org/289651.426@safari-7621-branch
2 files changed
tree: f6f815feab4fb94030bacf8178556e5b0c33589e
  1. .github/
  2. Configurations/
  3. JSTests/
  4. LayoutTests/
  5. ManualTests/
  6. metadata/
  7. PerformanceTests/
  8. resources/
  9. Source/
  10. Tools/
  11. WebDriverTests/
  12. WebKit.xcworkspace/
  13. WebKitLibraries/
  14. Websites/
  15. .ccls
  16. .clang-format
  17. .dir-locals.el
  18. .editorconfig
  19. .gitattributes
  20. .gitignore
  21. .submitproject
  22. .submitproject-tools
  23. CMakeLists.txt
  24. CMakePresets.json
  25. Introduction.md
  26. Makefile
  27. Makefile.shared
  28. ReadMe.md
ReadMe.md

WebKit

WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, Apple Books, and many other applications. For more information about WebKit, see the WebKit project website.

Trying the Latest

On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.

Reporting Bugs

  1. Search WebKit Bugzilla to see if there is an existing report for the bug you've encountered.
  2. Create a Bugzilla account to report bugs (and comment on them) if you haven't done so already.
  3. File a bug in accordance with our guidelines.

Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.

Getting the Code

Run the following command to clone WebKit's Git repository:

git clone https://github.com/WebKit/WebKit.git WebKit

You can enable git fsmonitor to make many git commands faster (such as git status) with git config core.fsmonitor true

Building WebKit

Building for Apple platforms

Install Xcode and its command line tools if you haven't done so already:

  1. Install Xcode Get Xcode from https://developer.apple.com/downloads. To build WebKit for OS X, Xcode 5.1.1 or later is required. To build WebKit for iOS Simulator, Xcode 7 or later is required.
  2. Install the Xcode Command Line Tools In Terminal, run the command: xcode-select --install

Run the following command to build a macOS debug build with debugging symbols and assertions:

Tools/Scripts/build-webkit --debug

For performance testing, and other purposes, use --release instead.

Embedded Builds

To build for an embedded platform like iOS, tvOS, or watchOS, pass a platform argument to build-webkit.

For example, to build a debug build with debugging symbols and assertions for embedded simulators:

Tools/Scripts/build-webkit --debug --<platform>-simulator

or embedded devices:

Tools/Scripts/build-webkit --debug --<platform>-device

where platform is ios, tvos or watchos.

Using Xcode

You can open WebKit.xcworkspace to build and debug WebKit within Xcode. Select the “Everything up to WebKit + Tools” scheme to build the entire project.

If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild for both Products and Intermediates.

Building the GTK Port

For production builds:

cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja
ninja
sudo ninja install

For development builds:

Tools/gtk/install-dependencies
Tools/Scripts/update-webkitgtk-libs
Tools/Scripts/build-webkit --gtk --debug

For more information on building WebKitGTK, see the wiki page.

Building the WPE Port

For production builds:

cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja
ninja
sudo ninja install

For development builds:

Tools/wpe/install-dependencies
Tools/Scripts/update-webkitwpe-libs
Tools/Scripts/build-webkit --wpe --debug

Building Windows Port

For building WebKit on Windows, see the WebKit on Windows page.

Running WebKit

With Safari and Other macOS Applications

Run the following command to launch Safari with your local build of WebKit:

Tools/Scripts/run-safari --debug

The run-safari script sets the DYLD_FRAMEWORK_PATH environment variable to point to your build products, and then launches /Applications/Safari.app. DYLD_FRAMEWORK_PATH tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks.

To run other applications with your local build of WebKit, run the following command:

Tools/Scripts/run-webkit-app <application-path>

iOS Simulator

Run the following command to launch iOS simulator with your local build of WebKit:

run-safari --debug --ios-simulator

In both cases, if you have built release builds instead, use --release instead of --debug.

To run other applications, for example MobileMiniBrowser, with your local build of WebKit, run the following command:

Tools/Scripts/run-webkit-app --debug --iphone-simulator <application-path>

Using Xcode

Open WebKit.xcworkspace, select intended scheme such as MobileMiniBrowser and an iOS simulator as target, click run.

Linux Ports

If you have a development build, you can use the run-minibrowser script, e.g.:

run-minibrowser --debug --wpe

Pass one of --gtk, --jsc-only, or --wpe to indicate the port to use.

Contribute

Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.