tree f16ec443dc956a9fbd17be2c9d0ecce3089d4a6a
parent b5b9ebd748027515445ac7f98ffb69ad7204be75
author Heejin Ahn <aheejin@gmail.com> 1778884458 -0700
committer GitHub <noreply@github.com> 1778884458 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqB59qCRC1aQ7uu5UhlAAAcLcQAHWwLcgy21WllTbo6hnmSWLU
 0C2oX1XPW9LajFBPVLB/3GBD0nnfd0Pj0wIgnQ0//ahJkI/dTmlepexhL/upp2ed
 qj8z9i8ot78IwbImWm7iXlfm4/o1kUz0G713c0LiyXQnYa2VF4AMD/sA2bhh8zWU
 zEvgxFatsuH+bmCh//N75brgK0ASI55Eji7+H7LFJ6LXUSZbDEUnFOSjuk0imM6o
 Wz1lvYEP/85JAnDv2ZcCQ8D/6x/iINiK9Ozuh7SeqgE2hGwtqkrbQvxM4WDeSSkk
 m+byjLo/VIqJm19toXCeu8taF7QyBXipgeUjDDj9R5xahPgNyn/l1Bqm0mqPJ8jp
 lZ7SXfm0XXRdOFDkuv8HaDPd8nEg7SC0IMVvbltO5BEV4mijboePPrsITP0jnFaM
 tK+jFQcwyaXK55d9jwO7F3AeGZ48IHqAGDr/qfn2KV6k7ajy+g3qT5/PL5dIbn0T
 x0ZQUi4OmBjqSz41/DJ2zg1cI8QSYl2G7LH8apfYOj3PNxjhvheYP8zCx8GKU1kE
 3C1Uh02s7EfBmXzeRGK0YL1/8HT0DZteGSJJOaw2lc1ORJA7Ko+3xzZmFZ4/veOX
 fu+E46iL2/saZ41o1JIrfoxe3GJIogu1QPxS71U7uXU0GKFd5QIi2ep5cQxqJp8r
 vzZr9GiUv4l3ONhh12ZG
 =PFSr
 -----END PGP SIGNATURE-----
 

[wasm-split] Fix table naming conflicts (#8708)

After #8688, we split module elements, including tables, earlier than
`indirectCallsToSecondaryFunctions`, which calls `getSlot`, which calls
`makeTable`. But when making a table, we only try to get a valid name
within the primary module:

https://github.com/WebAssembly/binaryen/blob/2f1f55aef6d9adfa6fdc2c25e46d202232dbf6e2/src/ir/module-splitting.cpp#L235-L238

If an existing table's name was `0` and it was moved to a secondary
module in `shareImportable` already, this will happily create an active
table with the name `0` again. And in `setupTablePatching`, because the
secondary module already has `0`, the active table will not be exported
/ imported there:

https://github.com/WebAssembly/binaryen/blob/2f1f55aef6d9adfa6fdc2c25e46d202232dbf6e2/src/ir/module-splitting.cpp#L1103-L1117

But this existing table is NOT the active table, and this table's type
may not even be `funcref`.

This fixes `makeTable` so that it makes a table name that does not
collide with any table names not only in the primary module but all
secondary modules.

This also disables `Split` fuzzer for now; I'm finding more bugs, so
I'll reenable it after it is more stabilized.