Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/6791
commit
f7d9bba80e8f44c3cfe6efec34aaa99890242820
[log]
author
Connor Clark <cjamcl@chromium.org>
Wed Oct 16 20:57:04 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Oct 21 22:45:02 2024
tree
470978fb4b3c73fd9bc121a02d49b3a180203fe2
parent
3fb5584ca05cee07864b5bcab5edd6e4ee299b9d [diff]
[RPP] Fix trace event search issues

1. The search feature was doing nothing if the query was <3 characters.
   This produced confusing results when deleting your query, since the
   last result highlights still lingered.
2. Ending the search sometimes threw an error from accessing a trace
   event indexed by -1. This resulted in search highlights remaining
   until the next time the panel was redrawn. TypeScript didn't catch
   this, because it was a normal array access. Fixed this by making the
   type nullable, instead of using -1 to denote "no selection".

Bug: 373914908
Change-Id: Ib292054a47b99c39dc36fdc459d8b44adb7ba044
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5939712
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
3 files changed
tree: 470978fb4b3c73fd9bc121a02d49b3a180203fe2
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitallowed
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .mailmap
  27. .npmignore
  28. .npmrc
  29. .style.yapf
  30. .stylelintignore
  31. .stylelintrc.json
  32. AUTHORS
  33. BUILD.gn
  34. codereview.settings
  35. CONTRIBUTING.md
  36. DEPS
  37. favicon.ico
  38. LICENSE
  39. OWNERS
  40. package-lock.json
  41. package.json
  42. PRESUBMIT.py
  43. README.md
  44. tsconfig.json
  45. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: