Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/6533_103
commit
c563ccab2ed28501c07ef473ab9fc7a68d08f754
[log]
author
Danil Somsikov <[email protected]>
Wed Jul 17 07:05:11 2024
committer
Danil Somsikov <[email protected]>
Wed Jul 17 11:59:50 2024
tree
70a9e38c77b7e6f63c600c42fad3d8443ebf7a31
parent
6d6fb25574db1e7a10d3b4ec0101baeaa9f01eb7 [diff]
[M127][ve] Fix memory leak in the Non-DOM state

The leak happens because we register non-DOM child loggables for some DOM nodes that never appear in the view port. Previous implementation used to hold strong references to both the child and the parent, which was released when child impression was logged. Since this is not guaranteed to happen, we might accumulate lots of such entries.

Current code stores non-DOM loggables in a weak map keyed by parent, so that they all could be released as soon as parent is released.

Bug: 352496178
Change-Id: If32ff440b95226a4c6eec5742917e1773844654c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5713929
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
(cherry picked from commit b3cda0381251db9d1de66bbad39251f183f24c94)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5712843
4 files changed
tree: 70a9e38c77b7e6f63c600c42fad3d8443ebf7a31
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch