RPP: Remove TimelineModel.PageFrame This CL replaces it with a helper and replaces the usage in TimelineTreeView that groups by frames. It also updates the test because the old engine would leave sets of events unattributed, whereas now we default to the main frame more readily (it looks like the old model meant to do this but didn't). This CL also removes the custom context menu in TimelineTreeView that only applied when `pageFrame.ownerNode` was set. However, looking at the PageFrame code relating to ownerNode, I found: ``` // TODO(dgozman): figure this out. // this.ownerNode = target && payload['nodeId'] ? new SDK.DOMModel.DeferredDOMNode(target, payload['nodeId']) : null; this.ownerNode = null; ``` And `ownerNode` was never set elsewhere in the codebase. Therefore I have removed all that logic. Fixed: 336283309 Bug: 40287735 Change-Id: I4e5ddfcd4823634464248794f2b4b21fd4654994 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5496959 Reviewed-by: Andres Olivares <andoli@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.
The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
All open DevTools tickets on crbug.com
File a new DevTools ticket: new.crbug.com
Code reviews mailing list: devtools-reviews@chromium.org
@ChromeDevTools on Twitter
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools