Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/6425
commit
f61a43042a8433b9487b37813b0bc19494a01dd7
[log]
author
Jack Franklin <jacktfranklin@chromium.org>
Tue Apr 16 17:04:04 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Apr 17 08:57:02 2024
tree
106c0667cecb38188c8b1bd456ae64386d50a95c
parent
e71698ba79bfda112a764e3af26414941eaafff9 [diff]
Ensure we dispose of targets when they crash

I found this issue via the attached bug where the performance panel
would freeze. We tracked it down to this line of code:

```
await SDK.TargetManager.TargetManager.instance().resumeAllTargets();
```

Which would never complete, and the UI would never update.

Looking in the protocol monitor, we found that there was a
`Target.targetCrashed` event being emitted. Further investigation
confirmed that if a target crashed, and then you called
`resumeAllTargets`, it would never resume, because the crashed target
would not resume.

To fix this, we listen to the crashed event in the target manager and
dispose of the target when it crashes. This fixes the bug in the
performance panel, because now DevTools can move past the crashed target
and does not attempt to resume it.

Bug: 333989070
Change-Id: I7c128c321ff396ed8bc1c9347ab08e22b003f59c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5458415
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2 files changed
tree: 106c0667cecb38188c8b1bd456ae64386d50a95c
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch