Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/6228
commit
9af248865b08c99c6ab22eee1e96a2de35c0e516
[log]
author
Elorm Coch <[email protected]>
Wed Jan 03 22:47:02 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Jan 04 17:02:03 2024
tree
65818c70fbb39cc681d7060c0a197869a50050b1
parent
ee17c7cd135b2887270e0d157ab30cd1891cc430 [diff]
[Accessibility] Ensures screen reader announces position list items and suggestions index.

We already had code in SuggestBox.ts to announce the item position in the list of suggestions from this change [here](https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2984362) However,  the announcment was getting interrupted by another screen reader call further than down the stack on ListControl Item Focus from this patch - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3780899

- This change moves the fix for the original issue higher up in the stack and ensures we include item position in the screen reader announcement.
- With this change the screen reader announcements from SuggestBox get applied correctly.

Bug: 1515418
Change-Id: Ib4b7f8830999fdbe0b527d35ffcd7d770f6c7c3a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5166711
Reviewed-by: Wolfgang Beyer <[email protected]>
Commit-Queue: Sylvester Elorm Coch <[email protected]>
2 files changed
tree: 65818c70fbb39cc681d7060c0a197869a50050b1
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch