Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/5910
commit
dd617ecaba7fdbc833ea9e622b7e9aa5ebba8107
[log]
author
Simon Zünd <szuend@chromium.org>
Mon Jul 24 11:08:39 2023
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Jul 25 07:57:49 2023
tree
58937def1ad5396de5f18ee127fdc90fdcc2d636
parent
9050f02e3fbc5a7fe475cc5a54bcc2ad4fb6dd6d [diff]
[scopes] Mark shadowed variables as 'unavailable'

This CL changes 'allVariablsInCallFrame' and 'allVariablesAtPosition'
to mark original names as 'null' when the underlying compiled name
was shadowed.

Otherwise we'd use the wrong variable after substitution.

Note that we do not yet report failures to the UI and all use-sites
currently fall back to using the original expression.

Drive-by: Type worker params as `unknown` internally. Ideally we'd
have a helper type for "structured cloneable" going forward.

R=jarin@chromium.org

Bug: 1444349
Change-Id: Id0040eacaf8076fd1ee62f9a08edfe26bc12dc49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4707975
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
5 files changed
tree: 58937def1ad5396de5f18ee127fdc90fdcc2d636
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .git-blame-ignore-revs
  18. .gitattributes
  19. .gitignore
  20. .gn
  21. .mailmap
  22. .npmignore
  23. .npmrc
  24. .style.yapf
  25. .stylelintignore
  26. .stylelintrc.json
  27. AUTHORS
  28. BUILD.gn
  29. codereview.settings
  30. DEPS
  31. LICENSE
  32. OWNERS
  33. package-lock.json
  34. package.json
  35. PRESUBMIT.py
  36. README.md
  37. tsconfig.json
  38. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch