Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/5366
commit
eba023f7da110e15eaabd622b7ab2b3abf92c222
[log]
author
Elorm Coch <elormcoch@microsoft.com>
Thu Oct 13 19:44:57 2022
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Oct 17 19:45:24 2022
tree
036878cb1347ed0f2a44268a593b770e7cbce20f
parent
242a86240f69c3b7a367e9be17d0e5d6485a828f [diff]
Resolves Bug 1364290: High Contrast down arrow in combo box not visible in high contrast themes

This bug extends to when Devtools has a dark theme and a high contrast white theme is selected. The dropdown arrow is not visible in this case.

The change applies a css selector to specify which dropdown image we use depending on white and dark contrast themes.


Before:

Dark Devtools Theme + Light High Contrast Theme
https://i.imgur.com/x1PMnXS.png

Light Devtools Theme + Dark High Contrast Theme
https://i.imgur.com/jbDwUUy.png

After
Dark Devtools Theme + Light High Contrast Theme
https://i.imgur.com/0pWWA0j.png

Light Devtools Theme + Dark High Contrast Theme
https://i.imgur.com/qKaaGpY.png


Bug: 1364290: High contrast down arrow in combo box not visible in high contrast themes
Change-Id: Ib03841b0f13f2f9913171a673fe9bf48a4251a7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3950789
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Commit-Queue: Leo Lee <leolee@microsoft.com>
1 file changed
tree: 036878cb1347ed0f2a44268a593b770e7cbce20f
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch