Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/5354
commit
4478aa88299db527943f499278d0eee59410d455
[log]
author
Simon Zünd <[email protected]>
Tue Oct 11 07:56:16 2022
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Oct 11 07:58:41 2022
tree
28b1f38d54f9e30ae8bc9adbf454f22d20520214
parent
38fa54bc33d759865fc0d0f41d7521002ea0c094 [diff]
Revert "Replace checks for non-null parentTarget with a check for a type == Frame in the NetworkLogView."

This reverts commit 8be8469f1c49ac2699270555ad76a10ed4164ee4.

Reason for revert: Causes flaky test failures (e.g. https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/8392/overview)

The failures originate from this test due to a cascade of `window.requestAnimationFrame` callbacks that can run while other tests are running. If we fall in-between test execution than the `Settings` instance is missing and we throw, causing unrelated before/after hooks to fail. 

Original change's description:
> Replace checks for non-null parentTarget with a check for a type == Frame in the NetworkLogView.
>
> Bug: 1370050
> Change-Id: I49da2fad3ea2b6bcaeff72a0d553183904bd92b3
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3936529
> Auto-Submit: Danil Somsikov <[email protected]>
> Reviewed-by: Wolfgang Beyer <[email protected]>
> Commit-Queue: Wolfgang Beyer <[email protected]>

Bug: 1370050
Change-Id: I5459f40a51d007c8a3857b1eaa953e8baa733782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3941776
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
2 files changed
tree: 28b1f38d54f9e30ae8bc9adbf454f22d20520214
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch