Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/4973
commit
b11278a379b327db3580a2a99a6defa83e1c8608
[log]
author
Rob Paveza <[email protected]>
Mon Mar 28 16:57:40 2022
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Mar 29 15:42:21 2022
tree
2c0cb1b98e593eb8dc4e2e233f8c7ab832dbe5d8
parent
93b2e30474730a97b5ae001a8aa73a4d2922b56d [diff]
Fixes mixed-sortable data grid click-to-sort.

The underlying cause is that, when there are no sortable columns, the
header row isn't selectable at all. However, when some columns are
sortable, the handling of clicking is passed through indiscriminately.

This change checks the sortability of the column before passing the
event through to the sort handler.

Bug: 1310818
Change-Id: I4326df5a0c55ecfba88be0f5586ee8e5c2c0f0b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3556086
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Robert Paveza <[email protected]>
1 file changed
tree: 2c0cb1b98e593eb8dc4e2e233f8c7ab832dbe5d8
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. ARCHITECTURE.md
  27. AUTHORS
  28. BUILD.gn
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch