Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/4546
commit
52ae36cfcfa5a20014c76216884ba97d6107da9d
[log]
author
Andres Olivares <andoli@chromium.org>
Sat Jun 12 16:37:28 2021
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Jun 17 17:40:57 2021
tree
b6ea536311ad34779076dceb60127d2c8cc08b7a
parent
5dcf70e8c48ff4751afa5bcc0e012636941375e1 [diff]
Return promise on DOM.removeNode wrapper

The function wrapping the call to this CDP method in the DevTools
frontend uses a parameter callback to call at the method's completion.
However this approach doesn't allow the caller to handle the underlying
promise, for instance, to stop the execution in case of an error.

To that effect, this CL changes the method to return the promise that
results after the completion of the method invocation.

Bug: none
Change-Id: I52a54ee47130b5796b65a167ec1a6b6211f735b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2957194
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
1 file changed
tree: b6ea536311ad34779076dceb60127d2c8cc08b7a
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. front_end/
  6. inspector_overlay/
  7. node_modules/
  8. scripts/
  9. test/
  10. third_party/
  11. v8/
  12. .clang-format
  13. .editorconfig
  14. .eslintignore
  15. .eslintrc.js
  16. .gitattributes
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .npmignore
  21. .npmrc
  22. .style.yapf
  23. .stylelintignore
  24. .stylelintrc.json
  25. ARCHITECTURE.md
  26. AUTHORS
  27. BUILD.gn
  28. DEPS
  29. LICENSE
  30. OWNERS
  31. package-lock.json
  32. package.json
  33. PRESUBMIT.py
  34. README.md
  35. tsconfig.base.json
  36. tsconfig.eslint.json
  37. tsconfig.json
  38. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch