Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/4443
commit
e7b220d512b2debe4621adcd571685f3ec4df7e5
[log]
author
Benedikt Meurer <bmeurer@chromium.org>
Wed Mar 10 13:13:53 2021
committer
Commit Bot <commit-bot@chromium.org>
Wed Mar 10 15:13:54 2021
tree
5982b25cd72efb0d45e88772c068bdb7b69d1640
parent
8d6be0d8a20357673215c2ea83a6614a26e76e13 [diff]
[wasm] Rename "Stack" scope to "Expression".

This is in preparation for the V8 side change, which exposes a dedicated
"stack" object with indexed properties within this scope. The end result
is that (a) "Copy property path" and "Add property path to Watch" will
work as expected for stack slots, and (b) everything that's visible in
the first level of the scope will be valid to enter into the Console for
developers, including "stack", whereas before the "Stack" scope was kind
of an outlier here.

The name "Expression" matches the syntactic concept of the S-expressions
in WebAssembly text format (the stack machine is the corresponding
semantic concept).

Screenshot: https://imgur.com/a/ryFiOGA.png
Bug: chromium:1159310, chromium:1071432, chromium:1159307
Change-Id: I3e02a6f237a03bec98ec826f40d142e4873b2931
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2744048
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
4 files changed
tree: 5982b25cd72efb0d45e88772c068bdb7b69d1640
  1. build_overrides/
  2. docs/
  3. front_end/
  4. inspector_overlay/
  5. node_modules/
  6. scripts/
  7. test/
  8. third_party/
  9. v8/
  10. .clang-format
  11. .editorconfig
  12. .eslintignore
  13. .eslintrc.js
  14. .gitattributes
  15. .gitignore
  16. .gn
  17. .npmignore
  18. .npmrc
  19. .style.yapf
  20. .stylelintignore
  21. .stylelintrc.json
  22. all_devtools_files.gni
  23. all_devtools_modules.gni
  24. AUTHORS
  25. BUILD.gn
  26. COMMON_OWNERS
  27. DEPS
  28. devtools_grd_files.gni
  29. devtools_image_files.gni
  30. devtools_module_entrypoints.gni
  31. ENG_REVIEW_OWNERS
  32. INFRA_OWNERS
  33. LICENSE
  34. LIGHTHOUSE_OWNERS
  35. OWNERS
  36. package-lock.json
  37. package.json
  38. PRESUBMIT.py
  39. README.md
  40. tsconfig.base.json
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch