)]}' { "log": [ { "commit": "13cb6e5d223dc49eadd082d3aef4c2a5b0e4c0a0", "tree": "10f21e4663b71b7eaee1fbe1c965175e5372e18b", "parents": [ "45843c2c1e993427751e2a07f904db069dc26ad6" ], "author": { "name": "Alex Ovsienko", "email": "ovsienko@google.com", "time": "Mon Aug 17 04:03:33 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 17 04:12:34 2026" }, "message": "Ruff: reformat tools (part 3/3: perf .. win).\n\nPreserve yapf style to the best capacity.\n\nLSC doc:\nhttps://docs.google.com/document/d/1P6AE9aeKuFkxPAYInYxLFIpDgpiCAT-S_BQkNU0lb3s/edit?tab\u003dt.0\n\nOnboarded using the following command: `~/cr/depot_tools/ruff_chromium format .`\n\nNO_IFTTT\u003dreformatting only.\nBYPASS_RECITATION_REASON\u003dreformatting only.\nBug: 40874143\n\nChange-Id: I971d8d3ad1a0dee3998a9eaa25c0617c6a6a6964\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8254624\nCommit-Queue: Junji Watanabe \u003cjwata@google.com\u003e\nOwners-Override: Alex Ovsienko \u003covsienko@google.com\u003e\nSLSA-Policy-Verified: SLSA Policy Verification Service \u003cdevtools-gerritcodereview-exitgate@google.com\u003e\nCommit-Queue: Alex Ovsienko \u003covsienko@google.com\u003e\nAuto-Submit: Alex Ovsienko \u003covsienko@google.com\u003e\nReviewed-by: Junji Watanabe \u003cjwata@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1680337}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 54e9909c3189a77bc8d353662628e4c5d6686290\n" }, { "commit": "45843c2c1e993427751e2a07f904db069dc26ad6", "tree": "366426e90ebba92aac435487c4cd983961f0dfdd", "parents": [ "faefd1b6fa9eeb033ad6fe60368ccb9bf908cbd0" ], "author": { "name": "Erik Anderson", "email": "Erik.Anderson@microsoft.com", "time": "Tue Jun 30 00:49:29 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 30 00:52:56 2026" }, "message": "Add natvis types for cc/viz (viz::DrawQuad-derived types and cc::ListContainer)\n\ncc::ListContainer has a complex storage mechanism that is difficult to\ndump manually.\n\nNote that we have separate natvis files for type definitions that work\nin both component and non-component builds.\n\nThis is for two reasons:\n\n1. Visual Studio (but not windbg/cdb) fails to visualize if both\n definitions are embedded concurrently. We\u0027d normally expect that\n Visual Studio would reject whichever one isn\u0027t valid, but in testing\n this was not the case and it required only one to be present\n2. It\u0027s less efficient to have the debugger try a type that is expected\n to be invalid only to then reject it.\n\nHow I tested:\n\n1. In the GPU process, set a bp on\n chrome!viz::DirectRenderer::DrawRenderPassAndExecuteCopyRequests\n (or, for a component build, it lives in components_viz_service).\n2. Run until the breakpoint is hit. 3. Dump render_pass-\u003equad_list a\n couple of levels deep and confirm the types show up correctly.\n4. Create a dump (.dump /ma \u003cpath\u003e) in WinDbg and load it in Visual\n Studio to confirm the natvis types work there too.\n5. Repeat for the other build type (to cover both component and\n non-component builds).\n\nNote that there was a prior attempt to land a similar visualizer in\nhttps://crrev.com/c/3863387. That change didn\u0027t handle component builds\ncorrectly and theorized it would need to be addressed with code changes.\nAs this change demonstrates, we actually just need to reference the type\nfrom a module whose PDB contains the type info.\n\nChange-Id: Ifc9fe6d5c898562c4fc79c51c364da663f6fb15b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7994959\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Michael Tang \u003ctangm@microsoft.com\u003e\nReviewed-by: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nCommit-Queue: Erik Anderson \u003cErik.Anderson@microsoft.com\u003e\nReviewed-by: Philipp Wollermann \u003cphilwo@google.com\u003e\nAuto-Submit: Erik Anderson \u003cErik.Anderson@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1654504}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ee125a3241f348cbe368d8d57194a02abf74a749\n" }, { "commit": "faefd1b6fa9eeb033ad6fe60368ccb9bf908cbd0", "tree": "1af982f05fae6cd78c986dcd26a9e43503cb4323", "parents": [ "b3ade095aeedb65b644078ae3a30d4dc13d5d3f4" ], "author": { "name": "Bharat Kumar", "email": "Bharat.Kumar@microsoft.com", "time": "Tue May 12 16:24:51 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 12 16:26:36 2026" }, "message": "chromeexts: Add DML links and task trace to !gwpasan\n\nEnhance the !gwpasan WinDbg debugger extension command with:\n\n1. DML (Debugger Markup Language) clickable links in stack traces:\n - Address links that disassemble at the location (u 0xAddr)\n - Source file links that open the file at the line (.open -a)\n - Source paths cleaned to relative form for .srcpath resolution\n\n2. Inline task trace scanning after the GWP-ASan output:\n - Scans the current thread\u0027s stack for base::TaskAnnotator markers\n - Displays the async PostTask chain showing where the crashing task\n was originally posted from\n - Uses DML links for task trace addresses and source locations\n\n3. New shared task_trace_utils module:\n - Extracts stack scanning logic into reusable utilities\n - ScanForTaskTraces/ScanMemoryRegionForTaskTraces scan thread stacks\n for magic begin/end markers placed by TaskAnnotator::RunTaskImpl()\n - TaskTraceEntry struct captures posted_from, parent PCs, IPC hash\n\n4. PrintDml/PrintDmlf methods on ChromeExtsCommand base class:\n - Enables DML output via IDebugControl4::ControlledOutput\n - Available to all debugger extension commands\n\nBug: none\nChange-Id: I3a68fbcbf4e9ff9a95e9f373fe085f4f90d627e9\nCo-authored-by: Copilot \u003c223556219+Copilot@users.noreply.github.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7763418\nReviewed-by: Robert Liao \u003crobliao@chromium.org\u003e\nCommit-Queue: David Bienvenu \u003cdavidbienvenu@chromium.org\u003e\nReviewed-by: David Bienvenu \u003cdavidbienvenu@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1629384}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5a090decb568a15056be35fbfd6127c1fc1055ac\n" }, { "commit": "b3ade095aeedb65b644078ae3a30d4dc13d5d3f4", "tree": "65ed10c41e9f5ba8e9e167770a925a524bcc0381", "parents": [ "d16e6b55b2bd699735919d8a13a55ff284086603" ], "author": { "name": "Zoraiz Naeem", "email": "zoraiznaeem@google.com", "time": "Wed May 06 00:55:59 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 06 01:14:48 2026" }, "message": "[views] Expose the paint lock state of a view to the debugging tools\n\nThis CL adds:\n- Exposes IsPaintLocked as a read-only property in the view metadata.\n- Adds a \"paint-locked\" attribute to the view\u0027s debug output if the view\n is paint locked.\n\nBug: b:507930653\nChange-Id: I04f04e5f6e3585a8ef701995498f72984fbba4a7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7809517\nCommit-Queue: Zoraiz Naeem \u003czoraiznaeem@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1625868}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f04e36984c36922e6599f0072fbc8e22ad475ac\n" }, { "commit": "d16e6b55b2bd699735919d8a13a55ff284086603", "tree": "e5a247c1dcca47367f144b59afba24b7197aecf6", "parents": [ "bfff5550ec231441c314c64878d860fdb6fdf174" ], "author": { "name": "Kevin Babbitt", "email": "kbabbitt@microsoft.com", "time": "Mon Apr 13 17:18:00 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 13 17:35:10 2026" }, "message": "Improve natvis for Blink compressed pointers\n\nWith these changes, compressed pointers can be expanded in the WinDbg\nLocals window and using the `dx` debugger command in component builds\nas well as non-component builds.\n\nBug: 40242035\nChange-Id: Idef8ded3c80d8be1e7c4e3696ee8ef92c81a78b8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7740255\nCommit-Queue: Kevin Babbitt \u003ckbabbitt@microsoft.com\u003e\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1613820}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 212af6aa8f465e1f903558d651ae9c9d46df03df\n" }, { "commit": "bfff5550ec231441c314c64878d860fdb6fdf174", "tree": "11804d43c6618d324a0cb6ff241c64404c759cd2", "parents": [ "baacfc6d5986b07abe0503216b491e234b94ba79" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Tue Mar 03 20:21:30 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 03 20:29:47 2026" }, "message": "Update Win toolchain to VS 2026 and SDK 26100.7705\n\nThis CL updates chromium to use the newest windows build files. This\nincludes a minor SDK version bump and a major VS bump. Fortunately, all\nthe required changes are pretty minor. There were no updates to the mc\nor midl files. As always, once this lands we will no longer support previous versions of the toolchain.\n\n------------------------------------------------------------------------\n\nInstructions to reproduce:\n\nThese instructions are best done on a fresh VM. Make sure to uninstall\nany existing installations of Visual Studio and any existing SDK\ninstallations before starting.\n\n```\n1. Install git for windows from their website, with the default settings\n(https://git-scm.com/downloads/win) 2. Install depot_tools following the\ninstructions on their webpage\n(https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up)\n3. Download Visual Studio Professional (Free Trial) from the official\nsite (https://visualstudio.microsoft.com/downloads/) 4. Run the VS\ninstaller with the following arguments:\n$ VisualStudioSetup.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 --includeRecommended --passive\n```\n5. Open the VS installer (from the start menu), click “Modify”, and\nuninstall any existing SDK versions (search for “windows sdk”). 6. Open\n“Add or Remove Programs” and make sure there are no SDK versions\ninstalled; remove them if so (search for “windows software development\nkit”). 7. Download SDK Version 10.0.26100.7705 from the official site\n(https://developer.microsoft.com/en-us/windows/downloads/windows-sdk/).\nNote that it may have been updated without incrementing the version\nnumber, and that if a more recent version has been released, it may no\nlonger be available. In these cases, reproducing the exact hash below\nwill be impossible. 8. Run the SDK installer with default settings,\nexcept disable “insights”. 9. Run the packaging script from depot_tools,\ne.g $ vpython3 depot_tools\\win_toolchain\\package_from_installed.py 2026\n-w 10.0.26100.0\n\nLink to packaging script version used for packaging:\nhttps://chromium-review.git.corp.google.com/c/chromium/tools/depot_tools/+/7613148/1\n\nThis resulted in the final package with hash e66617bc68.\n\nBug: 483104761\nChange-Id: Ic2132fc010cd18914e6a09b4aa8488207d8ff99d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7623535\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Devon Loehr \u003cdloehr@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1593420}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ea01904753154d3fbabe9b5eea931815e1b4a2a6\n" }, { "commit": "baacfc6d5986b07abe0503216b491e234b94ba79", "tree": "33e5d4b3543e35084155fc2b9559784e411bbd13", "parents": [ "2a9823716f1dd1491fdbc5dc0d2c2f6ab0c8e848" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Sun Jan 25 20:39:26 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sun Jan 25 20:47:16 2026" }, "message": "Use modern names for base::DictValue and base::ListValue\n\nThese classes were hoisted and renamed; switch all usage of these\nclasses to use the new names.\n\nThis is a strictly mechanical change.\n\nBug: 478100525\nChange-Id: Ib24d1f98695415ff9b8d2d6eefe69323d8473b12\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7509300\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1574260}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e99429c7513db8b3f278f15b5ae11d9f402f0d52\n" }, { "commit": "2a9823716f1dd1491fdbc5dc0d2c2f6ab0c8e848", "tree": "8b431662e776a858788b6cf85651d4a3e922b6cd", "parents": [ "24494b071e019a2baea4355d9870ffc5fc0bbafe" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Fri Jan 16 18:19:43 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 16 18:48:59 2026" }, "message": "[windows] Handle more time formats in subtract_time.py\n\nUpdate the regular expression to handle times like \" 9.53.04,25\",\nwhich is what I see in my current locale.\n\nBug: none\nChange-Id: I3b0468bd5e72a4a2477bfd1b979287a58f535af8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7456528\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1570485}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cb370f8406f7812fe7085c015ff101802e80f7f4\n" }, { "commit": "24494b071e019a2baea4355d9870ffc5fc0bbafe", "tree": "261908e914517832b5f97c7d6b63e77ec888980a", "parents": [ "2cbfc8d2e5ef4a6afd9774e9a9eaebd921a9f248" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Mon Sep 29 19:09:15 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 29 19:17:09 2025" }, "message": "Prepare to remove base::JSONReader::Read\u0027s parsing option default\n\nCallers should be explicit if they need to opt into non-compliant JSON\nparsing that allows Chromium-specific extensions, e.g. comments. This\nfixes instances included in a typical Windows developer build.\n\nBug: 446188265\nChange-Id: Ic5f29658a108380507cb3a99052e00dd594160db\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6992444\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1522403}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d7b39980f6166813758f9e9acc8bb37d2907c6e3\n" }, { "commit": "2cbfc8d2e5ef4a6afd9774e9a9eaebd921a9f248", "tree": "6d3048abb331aa48a54282ce54e2fa7310298f90", "parents": [ "89d58ebe78f02706d414154f923f759a05a887b6" ], "author": { "name": "Erik Anderson", "email": "Erik.Anderson@microsoft.com", "time": "Fri Sep 05 13:06:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 05 13:12:01 2025" }, "message": "NatVis: add base::FilePath type and add comment referencing clang \u0027debug info for constant globals\u0027 issue.\n\nChange-Id: Ic6ea3624b29c6bb315f4c320a0cee9f226165e0a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6867827\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Erik Anderson \u003cErik.Anderson@microsoft.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1511498}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f0257d72bcff07d61728bac54141c12d9a588e5\n" }, { "commit": "89d58ebe78f02706d414154f923f759a05a887b6", "tree": "5e9f93c9f3c18bb209edb964f24fb1534e0134f4", "parents": [ "4d6ecd8b0df2b2506a1ca2bf6adbc6c2491b26c5" ], "author": { "name": "Erik Anderson", "email": "Erik.Anderson@microsoft.com", "time": "Wed Aug 20 17:30:59 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 20 17:36:32 2025" }, "message": "Add NatVis types for absl::flat_hash_map, base::IdType, base::LazyInstance, and base::WeakPtr.\n\nThe absl::flat_hash_map type helps with visualizing some important\nobjects, e.g.\nchrome!content::`anonymous namespace\u0027::g_frame_tree_node_id_map.\n\nThe other types are generally helpful across many places.\n\nFor testing, launching the browser process under a debugger and setting\na breakpoint on chrome!content::FrameTreeNode::FrameTreeNode allows\ninspecting the flat_hash_map as it transitions from being not init\u0027d\n(base::LazyInstance) to initialized in SOO mode and then finally to\nnon-SOO mode.\n\nThe other types are observable by dumping a content::FrameTreeNode\na few levels deep (`dx -r3` in windbg).\n\nChange-Id: I7f1fd4c7e2371c2dbe3af98d0e0d541fa6d00930\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6857983\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Erik Anderson \u003cErik.Anderson@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1504060}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dda608506ee39104d5dae5f158e04b1732f199a7\n" }, { "commit": "4d6ecd8b0df2b2506a1ca2bf6adbc6c2491b26c5", "tree": "011b9884cde5371da159576b3f5a315a3fd35f09", "parents": [ "e05446925c044ce489fd6b123981a52d6780ef95" ], "author": { "name": "Erik Anderson", "email": "Erik.Anderson@microsoft.com", "time": "Fri Aug 15 18:35:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 15 18:41:03 2025" }, "message": "Improve NatVis definitions for std::atomic, std::basic_string, std::pair, and base::*Time* types.\n\nThis change:\n* Updates the std::__Cr::basic_string type. This takes advantage of the\n fact that the TODO-referenced clang bug was fixed. It combines the\n char/wchar variants, has clearer and direct calculations for capacity\n and size, and passes the actual length to the debugger.\n* Improves the base::time_internal::TimeBase and base::TimeDelta types:\n * Adds a TimeDelta view to be almost identical to TimeBase.\n * The display string shows the most coarse unit possible (up to days)\n without losing precision. The expanded view eliminates truncation\n and makes it clear that it\u0027s showing the value in different units.\n * Removes the base.dll reference for extracting out the constants for\n unit conversions. If debugging a build with chrome.dll, this did\n not work. Additionally, the compiler doesn\u0027t consistently put all of\n the values in the PDB (presumably due to some values always being\n inlined). Instead, we duplicate them into intrinsics that remain\n human-readable.\n* Adds a std::__Cr::atomic type.\n* Adds a std::__Cr::pair type which WinDbg requires.\n\nHow this was tested: I used both Visual Studio and WinDbg to verify\nthe visualizations. I checked short and long strings for both char\nand wchar variants. For the time-related types, I checked that it\nalways uses the most coarse-without-rounding time across all of the\nunits.\n\nChange-Id: I7a8a221e8a941a153cb90e8a918ff8d4c5920f94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6851551\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Erik Anderson \u003cErik.Anderson@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1502031}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8a7c570720c8d2c633ceca30fbcbab773b376753\n" }, { "commit": "e05446925c044ce489fd6b123981a52d6780ef95", "tree": "0c4229ea029482499121de727713b0be5885adb7", "parents": [ "46b10869843169c90aa56e9609e5b64ce1746cf4" ], "author": { "name": "Fabian Sommer", "email": "fabiansommer@chromium.org", "time": "Thu Jul 24 16:02:05 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 24 16:09:49 2025" }, "message": "Remove enable_nacl references from tools/win\n\nenable_nacl does not exist anymore.\nRemove remaining references.\n\nThis CL was uploaded by git cl split.\n\nR\u003dajgo@chromium.org\n\nBug: 40511454\nChange-Id: I889447c44a82b88a79f02ad7ae8c6079fa060505\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6783103\nAuto-Submit: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1491502}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 25f54011d686a2a920ef006958164e90d3d3f4b6\n" }, { "commit": "46b10869843169c90aa56e9609e5b64ce1746cf4", "tree": "53e3c63e42240f0b806a9537362695ee0ec854a0", "parents": [ "5024f3ffd6c1706c306a1ea2942721e735cbeb8b" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Tue Jul 22 22:12:03 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 22 22:17:56 2025" }, "message": "Fix `blink.natvis` for `blink::Length`\n\nThis fixes `blink.natvis` error for `blink::Length`:\n```\nNatvis: blink.natvis(151,6): Error: identifier \"is_float_\" is undefined\n Error while evaluating \u0027is_float_\u0027 in the context of type \u0027const blink_core.dll!blink::Length\u0027.\n```\n\n`blink::Length` was changed in crrev.com/c/4023472.\n\nChange-Id: I97281bbef86902c9a3cde7b2f0090aca6ec1a5cb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6776315\nAuto-Submit: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Kent Tamura \u003ctkent@chromium.org\u003e\nCommit-Queue: Kent Tamura \u003ctkent@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1490458}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3012aa78bd3cd6d0d6bfd6a4dc55aa5d9894e574\n" }, { "commit": "5024f3ffd6c1706c306a1ea2942721e735cbeb8b", "tree": "5caf27781af160be236efbd84fd4c9e8bde2222a", "parents": [ "c9f85419746b3924d833275039396da7206faac7" ], "author": { "name": "Kent Tamura", "email": "tkent@chromium.org", "time": "Thu Jul 17 08:23:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 17 08:28:38 2025" }, "message": "Move wtf/hash_table.h and wtf/key_value_pair.h to \"blink\" namespace\n\n* This CL removes `WTF::swap`, which is an alias of `std::swap`.\n It\u0027s not used.\n\nThis CL has no behavior changes.\n\nBug: 422768753\nChange-Id: Ia5b4f5d97c1e7c5c23d6a6f3f6e44384e8f64c3b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6763155\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nAuto-Submit: Kent Tamura \u003ctkent@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1488101}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 196602e92248114d73de96807f388cb24231fe49\n" }, { "commit": "c9f85419746b3924d833275039396da7206faac7", "tree": "5d328499db6d42e090c6a812eff22ac37132514b", "parents": [ "21b78c17c7f1a8bbf7f86bb46a8f28392b9f5795" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Thu Jul 17 04:55:37 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 17 05:01:52 2025" }, "message": "Update `blink.natvis` for the `WTF` namespace changes\n\n* `HashTable` was changed in crrev.com/c/6756689\n* `StringImpl` was changed in crrev.com/c/6702812\n* `RefPtr` is no longer used, crbug.com/40539402\n\nBug: 422768753\nChange-Id: I21a19b9143f916556ebe09ed83e75a0a24a2662e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6758354\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nAuto-Submit: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Kent Tamura \u003ctkent@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1488047}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 29fe02c67ebe221193d6ad102a8bf21a569801a9\n" }, { "commit": "21b78c17c7f1a8bbf7f86bb46a8f28392b9f5795", "tree": "65cc333798f85ee43d3421ca561d8a967b42be52", "parents": [ "077c4e71691df1e69c4d4718564cf0be1af1a235" ], "author": { "name": "Kent Tamura", "email": "tkent@chromium.org", "time": "Tue Jul 15 09:07:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 15 09:14:28 2025" }, "message": "Move wtf/vector*.* to \"blink\" namespace\n\nThis CL adds WTF:: aliases of vector.h, and blink:: aliases of other\nWTF symbols in order to minimize the CL size.\n\n* Add a forward declaration of WTF::Deque to wtf/forward.h\n vector.h needs the Deque declaration. deque.h includes forward.h to\n verify the correctness of the declaration.\n\n* swap() in vector.h\n It seems the function was not used. Since this CL, the swap()\n belongs to \"blink\" namespace, and swap() for blink::HeapVector\n matches to this swap(). This CL fixes a build error by replacing\n Swap() with swap().\n\nBug: 422768753\nChange-Id: I57138c7016c946d993f606733e082fbd0ac651a4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6733926\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nAuto-Submit: Kent Tamura \u003ctkent@chromium.org\u003e\nCommit-Queue: Kent Tamura \u003ctkent@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1486761}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ab09b0113971f395b85035cebc42b8df2438df05\n" }, { "commit": "077c4e71691df1e69c4d4718564cf0be1af1a235", "tree": "5743dcf1fd058380106cf47fecd32981d8d53777", "parents": [ "b980c8479038f1fccfee9b22574ef0bf15160135" ], "author": { "name": "Kent Tamura", "email": "tkent@chromium.org", "time": "Fri Jul 04 07:34:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 04 07:39:44 2025" }, "message": "Update debugger support files for blink::StringImpl\n\nWTF::StringImpl was changed to blink::StringImpl.\nThis CL has no production behavior changes.\n\nBug: 422768753\nChange-Id: I48c3ff5c6769959caf300f1487d3571078067576\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6703852\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nAuto-Submit: Kent Tamura \u003ctkent@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1482474}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7087254a0c6af3b94aa5aea33400cf6da9ae9ac5\n" }, { "commit": "b980c8479038f1fccfee9b22574ef0bf15160135", "tree": "234b608fc7a73e61b114b7d8306f99fd325639c9", "parents": [ "dd8674f693fe18f6d9482102f088422d993e6422" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Wed Jul 02 16:13:32 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 02 16:18:55 2025" }, "message": "Add an owner in APAC timezone for DebugVisualizers\n\nChange-Id: I124f078551c4d0d3b9d96483a9ea388ce3b00101\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6698811\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1481661}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b2a5532d05a903d36934769fb181b489ec66fc61\n" }, { "commit": "dd8674f693fe18f6d9482102f088422d993e6422", "tree": "c5b49f396f02adaf969a5df63ba691424fd0cb13", "parents": [ "f191715a88497da571a6fdd816a2276e53a65357" ], "author": { "name": "Kent Tamura", "email": "tkent@chromium.org", "time": "Wed Jul 02 16:02:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 02 16:09:12 2025" }, "message": "Update debugger support files for blink::String\n\nWTF::String was changed to blink::String.\nThis CL has no production behavior changes.\n\nBug: 422768753\nChange-Id: I8a8e174cc42f729c1f98e69c488004eef683606a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6695453\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nAuto-Submit: Kent Tamura \u003ctkent@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1481651}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a886089f057cc0edbfd7e5252fc10d87ded2b00b\n" }, { "commit": "f191715a88497da571a6fdd816a2276e53a65357", "tree": "35b23f6bb6758ac6063b3dbb61da917d8f3b2afe", "parents": [ "b15389ef76e4433196439d13339c111793ad57fc" ], "author": { "name": "Kent Tamura", "email": "tkent@chromium.org", "time": "Mon Jun 30 22:54:53 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 30 23:01:55 2025" }, "message": "Switch wtf/text/atomic_string*.* to \"blink\" namespace\n\nThis CL has no behavior changes.\n\nBinary-Size: Increase is temporary.\nBug: 422768753\nChange-Id: I708c59b6871d44c895e095b3fe9d80ceed1017bb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6682860\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Kent Tamura \u003ctkent@chromium.org\u003e\nReviewed-by: Takashi Toyoshima \u003ctoyoshim@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1480782}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a48dc60ea4e989a488aeb80f4f2091264b1276bc\n" }, { "commit": "b15389ef76e4433196439d13339c111793ad57fc", "tree": "232746d9ddf99b6a3d284861b03f76497e412bd4", "parents": [ "210ca1893b062cbc89b53ab1a736b04ac8b6cdca" ], "author": { "name": "Michael Tang", "email": "tangm@microsoft.com", "time": "Mon May 05 20:56:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 05 21:03:05 2025" }, "message": "DebugVisualizers: Add some chrome.natvis implementations and fix others\n\nThis change fixes some outdated natvis visualizers for:\n- base::Value\n- base::flat_tree/base::flat_set\n- base::TimeTicks/base::Time*\n\nAnd adds implementations for:\n- gpu::Mailbox\n- viz::SharedImageFormat\n\nChange-Id: I55f97f0a76944aabd20981609f90fe81989ed4b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509878\nCommit-Queue: Michael Tang \u003ctangm@microsoft.com\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1455929}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 153f57bbebf35236779a43350ad76eb0e4e0267d\n" }, { "commit": "210ca1893b062cbc89b53ab1a736b04ac8b6cdca", "tree": "341d115b8822757f676ab9b7f3d1121ff66ece66", "parents": [ "f764fa39486ea8d2ba2ef12e7434c90142db41b9" ], "author": { "name": "Michael Tang", "email": "tangm@microsoft.com", "time": "Mon May 05 18:44:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 05 19:06:20 2025" }, "message": "DebugVisualizers: Add support for std::variant\u003c*\u003e\n\nThis change removes support for absl::optional and absl::variant as they\nhave been replaced in Chromium with the std versions. It also migrates\nthe absl::variant implementation to support std::variant.\n\nChange-Id: Ie3676e3a98cc1277e734a48a81e1c807c706a194\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509877\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Michael Tang \u003ctangm@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1455848}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4a2e601d73989dc5672aad5302013d0563fa4537\n" }, { "commit": "f764fa39486ea8d2ba2ef12e7434c90142db41b9", "tree": "62c64745b94189829f721b7d63cfd0ee05303087", "parents": [ "acb2f3b4acad5b9725aedb4e0cef0be5abea7757" ], "author": { "name": "Michael Tang", "email": "tangm@microsoft.com", "time": "Fri May 02 16:50:25 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 02 16:57:48 2025" }, "message": "DebugVisualizers: Fix chrome.natvis typo\n\nThis CL removes an extra \u003c/Type\u003e tag in chrome.natvis and adds a\nPRESUBMIT.py script to ensure the .natvis files are valid XML.\n\nI accidentally added a type in crrev.com/c/6489025 that caused the\nnatvis files to fail to parse in the debugger. This is entirely my bad--\nI was not paying enough attention when preparing the change. I apologize\nfor any issues this caused!\n\nChange-Id: If295cb7852e835f1b0c11cc660ca013199bf0c75\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506361\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Michael Tang \u003ctangm@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1455039}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3fc13aefbfe6743bed607049060cb5ae39bcd1f0\n" }, { "commit": "acb2f3b4acad5b9725aedb4e0cef0be5abea7757", "tree": "791e5cd854b7fcc367fae40fdda71857281259d0", "parents": [ "76af6354747b3e6e7bada6ca13088d5cf8846b29" ], "author": { "name": "Michael Tang", "email": "tangm@microsoft.com", "time": "Thu Apr 24 20:37:16 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 24 20:44:59 2025" }, "message": "DebugVisualizers: Add natvis for gfx::Transform\n\ngfx::Transform is essentially a std::variant, but implemented as a union\nplus a bool. This change makes it easier to inspect a gfx::Transform\u0027s\nspecific variant, as well as see when the memory is uninitialized (it\nwill appear, for example, as { full_matrix_\u003dTrue(24) } and expand to its\nraw value).\n\nThis also adds a DisplayString for AxisTransform2d to make it easier to\nsee the full value on one line and expands Matrix44 to show all elements\nin [row,col] format.\n\nChange-Id: Icbc11fa5fa6ab5c1add16fa849f8d55d28b18d65\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489025\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Michael Tang \u003ctangm@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1451412}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f6e63dc42185b2668a8c21012e2c779f02b79b85\n" }, { "commit": "76af6354747b3e6e7bada6ca13088d5cf8846b29", "tree": "d1609c307c236f44b29403c182cf3109f832222a", "parents": [ "efc9513ba0be94b195e6fcea8b39278ee7376769" ], "author": { "name": "Michael Tang", "email": "tangm@microsoft.com", "time": "Thu Apr 24 18:09:01 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 24 18:16:25 2025" }, "message": "DebugVisualizers: Add natvis for base::span\n\n`base::span` is a wrapper around a pointer and a size. Currently we can\nonly look at the first element (at the data_ pointer) and the size. This\nchange allows us to view every element in the span.\n\nChange-Id: I59f848c8c12ab059de5f6639c7c7be2e008730dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489526\nCommit-Queue: Michael Tang \u003ctangm@microsoft.com\u003e\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Michael Tang \u003ctangm@microsoft.com\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1451310}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7ad56bdebb074a8a0fb62a1b0ec6647cc0ffb5a3\n" }, { "commit": "efc9513ba0be94b195e6fcea8b39278ee7376769", "tree": "70f585fe541df21a0c9e3540a7c97271bec836bc", "parents": [ "8c39b05330ac402690ef798b906fc0f472e59f89" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Sat Jan 25 14:43:21 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 25 14:50:23 2025" }, "message": "[etw tracing] Move tracing_service_idl into chrome\n\nBoth the service and its client are in //chrome, so there\u0027s no need for\nthe service\u0027s IDL to be in //components.\n\nBug: 41497361\nChange-Id: I5a488a6fb902d828d264b8dedb8c753ae8de4832\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179818\nReviewed-by: Mike West \u003cmkwst@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: S Ganesh \u003cganesh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1411329}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0fd443963cc236f158587e1af5e261c18a512ed8\n" }, { "commit": "8c39b05330ac402690ef798b906fc0f472e59f89", "tree": "a7188fd9a3732816c2c189bc8a10aecc1f6c1bc8", "parents": [ "78a4170b049a4d7f16865e52ff96e8fda246483a" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Fri Jan 10 18:28:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 10 18:34:30 2025" }, "message": "[windows] Fix IDL updater\n\nRecent changes to autoninja regressed update_idl.py. This brings it back\nto life. This change also adds `tracing_service_idl` to the list of\ntargets.\n\nBug: none\nChange-Id: I2d7f39377e7e521833248ea7e8c006d717946fa2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163631\nCommit-Queue: S Ganesh \u003cganesh@chromium.org\u003e\nReviewed-by: S Ganesh \u003cganesh@chromium.org\u003e\nAuto-Submit: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1404889}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c0541c493b693f6d28c89312fd52cb387a800778\n" }, { "commit": "78a4170b049a4d7f16865e52ff96e8fda246483a", "tree": "159cca69157d793b330fdc4bd285030ccdaf7471", "parents": [ "21994ffa84590fd4c0b72ee39f31a62e94259bfb" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Thu Dec 19 19:56:19 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 19 20:02:23 2024" }, "message": "Single PrintViewHierarchy implementation.\n\nWhy did we have 2 impls and 3 sets of headers? Why did it use streams?\n\nBug: none\nLow-Coverage-Reason: LARGE_SCALE_REFACTOR collapsing existing impls\nChange-Id: Ie57200239469382feee663737d956ba438f640b0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111809\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Allen Bauer \u003ckylixrd@chromium.org\u003e\nReviewed-by: Allen Bauer \u003ckylixrd@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1398768}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1b8b8bbe847d13e5a80578bc2d5942d7bb246322\n" }, { "commit": "21994ffa84590fd4c0b72ee39f31a62e94259bfb", "tree": "3192915227b792dc37776370b129bfd08112955f", "parents": [ "f80a364cc1a07be1517529f3055caa42e26b71c1" ], "author": { "name": "Joshua Pawlicki", "email": "waffles@chromium.org", "time": "Wed Dec 11 22:39:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 11 22:47:07 2024" }, "message": "Updater: Transmit install ID over IPC (Windows)\n\nThis is the Windows equivalent of\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6074099\n\nFixed: 343239826\nChange-Id: I01aa93b80504a42b143ccada3bfcd50fb78531a4\nLow-Coverage-Reason: COVERRAGE_UNDERREPORTED\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077793\nReviewed-by: S Ganesh \u003cganesh@chromium.org\u003e\nCommit-Queue: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1395118}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7763cb77a112c2097a9f5caa9f580deadc6e095f\n" }, { "commit": "f80a364cc1a07be1517529f3055caa42e26b71c1", "tree": "cd9aa4f6843d4884943ee292fc83665f614fb32e", "parents": [ "a64cfe7ee58da681522b3f7dbc2a22f86457c600" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Thu Nov 14 21:06:13 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 14 21:15:08 2024" }, "message": "[windows services] Introduce a rapid reuse test\n\nServiceTest.RapidReuse is a test that hammers a test service from four\nclient threads for 5 seconds. The test is currently disabled due to bugs\nin the service that will be fixed in a subsequent change.\n\nBug: 375097840\nChange-Id: I9e5eec926da372b9aa02e8676026168e637cae43\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980080\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: S Ganesh \u003cganesh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1383220}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 204aeadbb7b79147da2f1ff89cc4f0ae6bb98a48\n" }, { "commit": "a64cfe7ee58da681522b3f7dbc2a22f86457c600", "tree": "d89ec7f4f17f252112f61e23cbac59b2eba34229", "parents": [ "28e5fe084ef7395fd3758bf1c1aefeae64cd5d2b" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Thu Oct 24 19:42:37 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 24 19:50:48 2024" }, "message": "Update windows build output scripts\n\nUpdate our process for generating the intermediate build output\nthat we check in. The main changes are extending remc.bat to do a\nmore complete job in generating the mc files automatically, and\nremoving old mc output in base/trace_event that we don\u0027t need\nsince crrev.com/c/2171974 removed the corresponding build target.\n\nSince remidl.bat has been superseded by tools/win/update_idl.py,\nwe remove it. We update the readme to mention how the outputs can\nbe regenerated using the scripts.\n\nI also tried regenerated the mc and midl output for the 26100 SDK\nupdate, but nothing needed updating.\n\nAlso some metadata changes in the readme to satisfy presubmits.\n\nBug: 362650376\nChange-Id: I6b647672a6491d53c1dbd9b2eb9e0fee51c5fcbe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954139\nReviewed-by: S Ganesh \u003cganesh@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Devon Loehr \u003cdloehr@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1373511}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8b0f435979f292069dae1d2a8fa4accbdfb7c6b4\n" }, { "commit": "28e5fe084ef7395fd3758bf1c1aefeae64cd5d2b", "tree": "fd7377128af772ffc8e13ed7477cfd5c03271ed1", "parents": [ "687798bd5cd51bde774ac748db1995d4ecf93761" ], "author": { "name": "S. Ganesh", "email": "ganesh@chromium.org", "time": "Wed Oct 23 20:46:55 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 23 20:54:38 2024" }, "message": "Remove obsolete google_update folder and associated references\n\nEverything that was using `google_update` is now using the\n`updater_legacy_idl`.\n\nBug: 40270788\nChange-Id: Ib7adbaac647ae1dcf433c8969f193fc5e0f5f99e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953794\nCommit-Queue: S Ganesh \u003cganesh@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1372932}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3338037d83319ba66dce31643ca0206e45a409f9\n" }, { "commit": "687798bd5cd51bde774ac748db1995d4ecf93761", "tree": "e4b2d968c6d021409fe1cec1d557b8681f98b2dd", "parents": [ "763ec70dff6950c20923db8db04d9fd8e6561f5d" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Tue Oct 22 01:30:29 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 22 01:46:39 2024" }, "message": "Add Readme to tools/win\n\nBug: 40271701\nChange-Id: I94a68703b0d140d98d0e5ad3efe7a2479c6cf683\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5945584\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1371792}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0b0acaddccd9e56d93e2c1e94ea9f3843d67d11e\n" }, { "commit": "763ec70dff6950c20923db8db04d9fd8e6561f5d", "tree": "5dfb51811274a6086b36c407015d62d7958776b6", "parents": [ "56a70f8233f3e7661a03903ab29e32f17c67c4a2" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Thu Oct 03 14:47:52 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 22 01:45:55 2024" }, "message": "Remove brucedawson@ from several owners files\n\nI am leaving Google and will not be regularly contributing to Chromium\nso I am removing myself from OWNERS files. These are the easy ones where\nthere are at least two owners still remaining.\n\nChange-Id: I2071a4d4022690c19fd2e4325dd6b3e24d06638b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906249\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1363629}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2a9a0c75ffffec44eeb15d2e0096b47bf87bb1e6\n" }, { "commit": "56a70f8233f3e7661a03903ab29e32f17c67c4a2", "tree": "883561d4a97cc847bb8cb17fd116f997cec42c41", "parents": [ "24b66322fa8c852af499e398e44fd484311a6d98" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Tue Sep 24 23:50:41 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 24 23:57:26 2024" }, "message": "Delete ChromeDebug project\n\nThe ChromeDebug project was added around 2013 and has not been updated\nsince then. It is apparently not used and it is now triggering security\nwarnings so I am deleting it.\n\nI can find no references to it that need updating.\n\nBug: 361563115\nChange-Id: Ia14cf191dca84ff14b5aac214a6402763ccd5e67\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887018\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1359668}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 84d5b0378fafef4fb87c5a99fc318760d03abfdd\n" }, { "commit": "24b66322fa8c852af499e398e44fd484311a6d98", "tree": "3a04366289c1e06c38cd1fca21a1d5260834cbb0", "parents": [ "6a12334f88e65a8ad8998dd1f44475c761e75741" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Mon Sep 09 20:30:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 09 20:38:01 2024" }, "message": "[layout-unit] Update Visual Studio natvis files\n\nThis patch updates the Visual Studio natvis files to support\ntemplatized `LayoutUnit` in crrev.com/c/5678228.\n\nThe GDB support file was updated at crrev.com/c/5772062.\n\nBug: 351092748\nChange-Id: I6cd06c80f22e0f6047122d0bedc87d535a526c8e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5845050\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1352967}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 626d420f9261f62736d52d050bcb860bc21c1bc6\n" }, { "commit": "6a12334f88e65a8ad8998dd1f44475c761e75741", "tree": "422af077219cc80e50e5cffaa4ab11c2679f4bb8", "parents": [ "3d6a8653ea4d582867efe19c66aa47498dcca608" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Wed Jul 24 23:10:24 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 24 23:27:26 2024" }, "message": "Remove uses of variable-length arrays\n\nVariable-length arrays are not part of the C++ standard, and are\ndangerous to use because they allocate a potentially-unbounded\namount of data on the stack. In addition, they trigger a clang warning\n(-Wvla-extension) which is currently suppressed in Chromium builds.\n\nThis simply removes a warning by marking the length of the array as\n`constexpr`, allowing the compiler to figure out that its length is\nstatic.\n\nBug: 349656479\nChange-Id: Ifa0b588f1b986eea1f9fd707cc1fe02562963812\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5738738\nReviewed-by: Robert Liao \u003crobliao@chromium.org\u003e\nCommit-Queue: Robert Liao \u003crobliao@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1332664}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 66fca8f6309dd9f2f5219245d58afe90c50c6a6e\n" }, { "commit": "3d6a8653ea4d582867efe19c66aa47498dcca608", "tree": "c515b409c41d05d4d209b84934b1e7fd6181244d", "parents": [ "eb1bbb036d5ce165ef36c3603a0ba004e729888a" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Mon Jul 15 20:05:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 15 20:15:07 2024" }, "message": "Convert base::StringPiece to std::string_view //tools\n\nThe changes of this CL are made using the following script.\nScript: https://issues.chromium.org/issues/40506050#comment343\n\nBug: 40506050\nChange-Id: Id4d72221f933604395714f83ce46189c15beea92\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5698685\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Helmut Januschka \u003chelmut@januschka.com\u003e\nCr-Commit-Position: refs/heads/main@{#1327739}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ae003ef1db0008ee377340aeffb121b22e04ce34\n" }, { "commit": "eb1bbb036d5ce165ef36c3603a0ba004e729888a", "tree": "91214d440205b345e2659b1595d093fdf8bbc446", "parents": [ "3886d8c1774ca70cde7b819f1fc062085b1bbc3b" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Apr 15 16:59:19 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 17:07:06 2024" }, "message": "format windows headers using new config.\n\nTest new config:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5197064\n\nby applying clang-format on every problematic windows headers.\n\nThis CL is cloned from https://crrev.com/c/5366045.\n\nScript:\n-------\n\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n | grep -v \"third_party/[^b]\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/gi\"\n}\n\ngit checkout origin/main\ngit branch -D change-5197064 || true\n\ngit new-branch change-5197064\nreplace \"#include \u003c\\(initguid|mmdeviceapi\\|windows\\|winsock2\\|ws2tcpip\\|shobjidl\\|atlbase\\|ole2\\|unknwn\\|objbase\\|tchar\\).h\u003e\" \"\"\nreplace \"#include \\\"base\\\\/win\\\\/atl.h\\\"\" \"\"\nreplace \"#include \u003cuiautomation.*\u003e\" \"\"\ngit add -u\ngit commit -m \"remove problematic windows headers\"\ngit revert HEAD --no-commit\ngit add -u\ngit commit -m \"add problematic windows headers\"\ngit cl format --upstream\u003dHEAD~\ngit add -u\ngit commit -m \"format\"\n\ngit cl issue 5367127\ngit cl upload -df --bypass-hook\n```\n\nAlso removed some unnecessary comments.\n\nBug: 329138753\nChange-Id: I161c28ea2d27c569825e0c789a4c143530937f58\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367127\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1287420}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c8d6b16f02bc9013db2354b8649d2e0d97829a1a\n" }, { "commit": "3886d8c1774ca70cde7b819f1fc062085b1bbc3b", "tree": "0183f0c23f20dfee10fa175a2e6bcdbe334a1d53", "parents": [ "ad2071cf31d4092f2418d96ee6e7ade832694d20" ], "author": { "name": "Sergei Glazunov", "email": "glazunov@google.com", "time": "Thu Mar 07 20:49:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 07 20:55:51 2024" }, "message": "Make Lightweight UAF Detector reports less confusing\n\nAt the moment, we report UAF crashes detected by LUD as\n\"lightweight-heap-use-after-free\" and people are confused about what is\nlightweight about them.\n\nThis change introduces a new field to the GWP-ASan proto that\nrepresents the GWP-ASan mode and complements a similar backend change.\n\nBug: 40257491\nChange-Id: Id98ab33ac6fbc3792744d58bd835f8121b8dc5eb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5349127\nAuto-Submit: Sergei Glazunov \u003cglazunov@google.com\u003e\nReviewed-by: Matthew Denton \u003cmpdenton@chromium.org\u003e\nReviewed-by: Robert Liao \u003crobliao@chromium.org\u003e\nCommit-Queue: Robert Liao \u003crobliao@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1269805}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e3d79ff6cae899bc8ee37b493fe542be15e69f8b\n" }, { "commit": "ad2071cf31d4092f2418d96ee6e7ade832694d20", "tree": "f7af32c51d3e40261b97a59941f46930aade2a59", "parents": [ "5d8825260aad820a51db85b65296dce225e2df65" ], "author": { "name": "S. Ganesh", "email": "ganesh@chromium.org", "time": "Sat Jan 20 01:11:14 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 20 01:17:17 2024" }, "message": "updater: generate separate typelibs for user and system\n\nThis CL generates separate TLB files for user and system updater\ninterfaces. This will allow registering the interfaces via these TLBs.\n\nBug: 1496516\nChange-Id: Ie9689173b2b767ed6481d53946ce0e1b1ce62eef\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5218263\nAuto-Submit: S Ganesh \u003cganesh@chromium.org\u003e\nCommit-Queue: Xiaoling Bao \u003cxiaolingbao@chromium.org\u003e\nReviewed-by: Xiaoling Bao \u003cxiaolingbao@chromium.org\u003e\nCommit-Queue: S Ganesh \u003cganesh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249731}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 21e829272cc3486ac501e30d2ba1fdaa730beb2e\n" }, { "commit": "5d8825260aad820a51db85b65296dce225e2df65", "tree": "8acad0aae17c952007a1baf28b49007fd9f08beb", "parents": [ "2770f60855bd84484f64a08edeae5ca1505cf519" ], "author": { "name": "S. Ganesh", "email": "ganesh@chromium.org", "time": "Fri Jan 19 21:09:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 19 21:17:49 2024" }, "message": "updater: refactor the midl generation into a template\n\nThis reduces repetitiveness in the build scripts, and will make it\neasier to transition to building separate IDL and typelib files for user\nand system in the future.\n\nThe `linux-chromeos-rel` bot has been retrying since yesterday night. My\nchange is Windows only, so I\u0027m bypassing this bot with `No-Try: true`.\n\nNo-Try: true\nBug: 1496516\nChange-Id: I922ab37f116261445516a3a4321f879c0222e8bb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5214730\nReviewed-by: Xiaoling Bao \u003cxiaolingbao@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Roger Tawa \u003crogerta@chromium.org\u003e\nAuto-Submit: S Ganesh \u003cganesh@chromium.org\u003e\nCommit-Queue: S Ganesh \u003cganesh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249501}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 56b29fed092f3596b9db01452ef5285f11a6cb6f\n" }, { "commit": "2770f60855bd84484f64a08edeae5ca1505cf519", "tree": "df654f68dbc73c2fbc59e2accacbd0e0e76fbfcc", "parents": [ "4a0c54324544f99b3727b84e028e0acda83a549a" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Jan 12 08:44:59 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 12 08:51:09 2024" }, "message": "Reland \"Rename {absl \u003d\u003e std}::optional in //tools/\"\n\nThis is a reland of commit b263d258c9e4899afaa24036bde76d7e9e1d537c\n\nOriginal change\u0027s description:\n\u003e Rename {absl \u003d\u003e std}::optional in //tools/\n\u003e\n\u003e Automated patch, intended to be effectively a no-op.\n\u003e\n\u003e Context:\n\u003e https://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\u0026utm_source\u003dfooter\n\u003e\n\u003e As of https://crrev.com/1204351, absl::optional is now a type alias for\n\u003e std::optional. We should migrate toward it.\n\u003e\n\u003e Script:\n\u003e ```\n\u003e function replace {\n\u003e echo \"Replacing $1 by $2\"\n\u003e git grep -l \"$1\" \\\n\u003e | cut -f1 -d: \\\n\u003e | grep \\\n\u003e -e \"^tools\" \\\n\u003e | sort \\\n\u003e | uniq \\\n\u003e | grep \\\n\u003e -e \"\\.h\" \\\n\u003e -e \"\\.cc\" \\\n\u003e -e \"\\.mm\" \\\n\u003e -e \"\\.py\" \\\n\u003e | xargs sed -i \"s/$1/$2/g\"\n\u003e }\n\u003e replace \"absl::make_optional\" \"std::make_optional\"\n\u003e replace \"absl::optional\" \"std::optional\"\n\u003e replace \"absl::nullopt\" \"std::nullopt\"\n\u003e replace \"absl::in_place\" \"std::in_place\"\n\u003e replace \"absl::in_place_t\" \"std::in_place_t\"\n\u003e replace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\n\u003e git cl format\n\u003e ```\n\u003e\n\u003e Bug: chromium:1500249\n\u003e Change-Id: I7536d03fa09fb48f8cf7113eba8eb727d5efba7b\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185809\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Commit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Auto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1245840}\n\nBug: chromium:1500249\nChange-Id: I0abd981c73e34bec6ed83eafed20098cf82e4d12\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190270\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1246334}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 69fa1c8ea7b8b207343b91ca8db5e3e7d372b1c7\n" }, { "commit": "4a0c54324544f99b3727b84e028e0acda83a549a", "tree": "708616d8fe4f148d57c2dff7f8406a437c46d513", "parents": [ "58d900946648939357a8d363030752a8af7be287" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Jan 11 17:15:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 11 17:25:06 2024" }, "message": "Revert \"Rename {absl \u003d\u003e std}::optional in //tools/\"\n\nThis reverts commit b263d258c9e4899afaa24036bde76d7e9e1d537c.\n\nReason for revert: Speculative revert. A `NOTRY\u003dTrue` was copy\npasted mistakenly.\n\nOriginal change\u0027s description:\n\u003e Rename {absl \u003d\u003e std}::optional in //tools/\n\u003e\n\u003e Automated patch, intended to be effectively a no-op.\n\u003e\n\u003e Context:\n\u003e https://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\u0026utm_source\u003dfooter\n\u003e\n\u003e As of https://crrev.com/1204351, absl::optional is now a type alias for\n\u003e std::optional. We should migrate toward it.\n\u003e\n\u003e Script:\n\u003e ```\n\u003e function replace {\n\u003e echo \"Replacing $1 by $2\"\n\u003e git grep -l \"$1\" \\\n\u003e | cut -f1 -d: \\\n\u003e | grep \\\n\u003e -e \"^tools\" \\\n\u003e | sort \\\n\u003e | uniq \\\n\u003e | grep \\\n\u003e -e \"\\.h\" \\\n\u003e -e \"\\.cc\" \\\n\u003e -e \"\\.mm\" \\\n\u003e -e \"\\.py\" \\\n\u003e | xargs sed -i \"s/$1/$2/g\"\n\u003e }\n\u003e replace \"absl::make_optional\" \"std::make_optional\"\n\u003e replace \"absl::optional\" \"std::optional\"\n\u003e replace \"absl::nullopt\" \"std::nullopt\"\n\u003e replace \"absl::in_place\" \"std::in_place\"\n\u003e replace \"absl::in_place_t\" \"std::in_place_t\"\n\u003e replace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\n\u003e git cl format\n\u003e ```\n\u003e\n\u003e NOTRY\u003dTrue\n\u003e\n\u003e Bug: chromium:1500249\n\u003e Change-Id: I7536d03fa09fb48f8cf7113eba8eb727d5efba7b\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185809\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Commit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Auto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1245840}\n\nBug: chromium:1500249\nChange-Id: I1b9749db1ddffe073b991065d0d5b21f8579075f\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189307\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1245919}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8c3a4c4fd8ddc5c8c3384f29e48932f81a38a462\n" }, { "commit": "58d900946648939357a8d363030752a8af7be287", "tree": "df654f68dbc73c2fbc59e2accacbd0e0e76fbfcc", "parents": [ "2b442128c9be3025567a39f7e72aba805df64542" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Jan 11 15:08:39 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 11 15:18:25 2024" }, "message": "Rename {absl \u003d\u003e std}::optional in //tools/\n\nAutomated patch, intended to be effectively a no-op.\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\u0026utm_source\u003dfooter\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias for\nstd::optional. We should migrate toward it.\n\nScript:\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"^tools\" \\\n | sort \\\n | uniq \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n -e \"\\.mm\" \\\n -e \"\\.py\" \\\n | xargs sed -i \"s/$1/$2/g\"\n}\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place\" \"std::in_place\"\nreplace \"absl::in_place_t\" \"std::in_place_t\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\ngit cl format\n```\n\nNOTRY\u003dTrue\n\nBug: chromium:1500249\nChange-Id: I7536d03fa09fb48f8cf7113eba8eb727d5efba7b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185809\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1245840}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b263d258c9e4899afaa24036bde76d7e9e1d537c\n" }, { "commit": "2b442128c9be3025567a39f7e72aba805df64542", "tree": "708616d8fe4f148d57c2dff7f8406a437c46d513", "parents": [ "984f757ac366f7266b86628d6fe780ea053ee7cb" ], "author": { "name": "Michael Tang", "email": "tangm@microsoft.com", "time": "Tue Jan 09 23:32:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 09 23:40:11 2024" }, "message": "DebugVisualizers: Add natvis for base::StringAlias\n\n`base::StrongAlias` is a wrapper around an underlying type, typically an\ninteger type. This change lets the debug visualizer for\n`base::StrongAlias` defer to the underlying type\u0027s visualizer.\n\nChange-Id: If0ed96c923cef18c3cf22fc590f076e0ce00374f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181961\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Michael Tang \u003ctangm@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1244956}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a4baa6e3e3e928522948611edf928df63c87ebba\n" }, { "commit": "984f757ac366f7266b86628d6fe780ea053ee7cb", "tree": "9c45aa3c28c0d73fb51e21880d181fbf080dfb08", "parents": [ "43f71b4521f494546c6e4c5890a1bc3088ed218f" ], "author": { "name": "Sergio Gonzalez", "email": "sergiog@microsoft.com", "time": "Sat Dec 30 01:15:58 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Dec 30 01:30:22 2023" }, "message": "Add gwpasan and crashinfo commands to chromeexts debugging extension\n\nChange-Id: I35103f7edfa161c383969cd4645b84dab46d122c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5086188\nReviewed-by: Robert Liao \u003crobliao@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: James Forshaw \u003cforshaw@chromium.org\u003e\nReviewed-by: Matthew Denton \u003cmpdenton@chromium.org\u003e\nCommit-Queue: Sergio Gonzalez Martin \u003csergiog@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1241563}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: afedf26cc717ffd89836c93fe9e74eac3d904d34\n" }, { "commit": "43f71b4521f494546c6e4c5890a1bc3088ed218f", "tree": "7b12cab96e9a5e063fdf9e884efeecd70f9b75ad", "parents": [ "5ab8597fd5c444db641f51d68e31f0ad81238478" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Tue Nov 28 07:01:03 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 28 07:19:42 2023" }, "message": "Fix Visual Studio visualizer for `BasicPersistent`\n\n`BasicPersistent` uses a pointer, not `RawPointer`, stopped using `RawPointer`, and the `ptr_`\nis no longer needed. This patch changes the Visual Studio\nvisualizer to match the change.\n\nVerified as per the README.md[1]. Note that this file wasn\u0027t\nmaintained for a while, and there are other warnings. This CL fixes\nthe warnings for `BasicPersistent`, but others are not covered.\n\n[1] https://source.chromium.org/chromium/chromium/src/+/main:tools/win/DebugVisualizers/README.md\n\nChange-Id: Idc6fbca18f27d433524d25a18c6a6ad2296ef247\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5058690\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1229768}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0f91e220d3790fe49fc81b313a49ebabdc11c55a\n" }, { "commit": "5ab8597fd5c444db641f51d68e31f0ad81238478", "tree": "0d2568eb32ccd20b862c7d68c0ba499bfcf9662a", "parents": [ "09d5e4c96c907b6510ce6e1ff7347ef29d91488c" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Nov 10 09:46:54 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 10 09:59:20 2023" }, "message": "Rename {absl \u003d\u003e std}::optional in minor top-level dirs\n\nAutomated patch, intended to be effectively a no-op.\n\nThis patch gather the changes for every top-level directories with less\nthan 150 files modified:\n # directory\n--- ---------------\n150 remoting\n98 gpu\n87 chromecast\n79 mojo\n70 storage\n65 fuchsia_web\n46 sandbox\n44 android_webview\n38 google_apis\n27 pdf\n25 printing\n20 headless\n13 ipc\n11 crypto\n10 sql\n3 dbus\n2 testing\n2 skia\n2 gin\n2 apps\n1 rlz\n1 codelabs\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\u0026utm_source\u003dfooter\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias for\nstd::optional. We should migrate toward it.\n\nScript:\n```\n\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n\t\t| cut -f1 -d: \\\n\t\t| grep \\\n\t\t\t-e \"^codelabs\" \\\n\t\t\t-e \"^rlz\" \\\n\t\t\t-e \"^apps\" \\\n\t\t\t-e \"^gin\" \\\n\t\t\t-e \"^skia\" \\\n\t\t\t-e \"^testing\" \\\n\t\t\t-e \"^dbus\" \\\n\t\t\t-e \"^sql\" \\\n\t\t\t-e \"^crypto\" \\\n\t\t\t-e \"^ipc\" \\\n\t\t\t-e \"^headless\" \\\n\t\t\t-e \"^printing\" \\\n\t\t\t-e \"^pdf\" \\\n\t\t\t-e \"^google_apis\" \\\n\t\t\t-e \"^android_webview\" \\\n\t\t\t-e \"^sandbox\" \\\n\t\t\t-e \"^fuchsia_web\" \\\n\t\t\t-e \"^storage\" \\\n\t\t\t-e \"^mojo\" \\\n\t\t\t-e \"^chromecast\" \\\n\t\t\t-e \"^gpu\" \\\n\t\t\t-e \"^remoting\" \\\n\t\t| sort \\\n\t\t| uniq \\\n\t\t| grep \\\n\t\t\t-e \"\\.h\" \\\n\t\t\t-e \"\\.cc\" \\\n\t\t\t-e \"\\.mm\" \\\n\t\t\t-e \"\\.py\" \\\n\t | xargs sed -i \"s/$1/$2/g\"\n}\n\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place\" \"std::in_place\"\nreplace \"absl::in_place_t\" \"std::in_place_t\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\ngit cl format\n```\n\nCQ_INCLUDE_TRYBOTS\u003dluci.chrome.try:chromeos-betty-pi-arc-chrome\n\nBug: chromium:1500249\nChange-Id: I0eca8ff96f5712ba746ac8d8da93d03a86d8292c\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5009410\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1222826}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 59ac8227c5dd59754331b3f7f9f85e1a947f1242\n" }, { "commit": "09d5e4c96c907b6510ce6e1ff7347ef29d91488c", "tree": "80c902570ab4151f844f461fafc7e51b2e4b284a", "parents": [ "6c4c7c5727ad19065e3e23615f84efd8081ba283" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Mar 08 23:22:35 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 08 23:26:58 2023" }, "message": "Fix bugs in visualization of base::Value.\n\nThis was clearly rotted; update it to match current reality.\n\nBug: none\nChange-Id: I29e7a62dbc85b5e98dde52314b0abebbb03fb983\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320891\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1114848}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7c743a66ebcce892066c9656251e6619a277d76b\n" }, { "commit": "6c4c7c5727ad19065e3e23615f84efd8081ba283", "tree": "37fea073a22e238c6914f0e24eeb2ee325df8065", "parents": [ "239ebe3e5f416b6dfea550cc6ccc560cc1b853f5" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Tue Mar 07 18:27:02 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 07 18:32:09 2023" }, "message": "Remove last Python 2 reference from src/tools\n\nBug: 1376538\nChange-Id: I1a866dac837865a3a85e28fcf2a317c3c5f8fdad\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4315261\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1114058}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8da44fe42fd0bc089abdc7b3ba0b37a79dead14b\n" }, { "commit": "239ebe3e5f416b6dfea550cc6ccc560cc1b853f5", "tree": "3b7268696971fd02353850a70cd8d0c1c971825a", "parents": [ "cb2c67c8b665d2518b03cdf7c84929f1188821a3" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Mon Mar 06 08:53:08 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 06 08:57:50 2023" }, "message": "Update setenv.py for new VS version\n\nsetenv.py can be manually used to set up the VS build environment, but\nit isn\u0027t used by any automated processes so it is easy to miss when\nadding support for a new compiler. And, indeed, it was missed. This\nchange adds 2022 to its list of valid compilers, removes 2017 and 2019,\nand adds a reminder to build/vs_toolchain.py to consider updating this\nfile on future toolchain upgrades.\n\nThis also replaces x.x with the actual packaged version of Visual\nStudio, and replaces \"python\" with \"python3\" in setenv.bat.\n\nThis was manually tested with DEPOT_TOOLS_WIN_TOOLCHAIN set to 0 and to\n1.\n\nBug: 1273169\nChange-Id: Icea9ebe4f55a4d8a12d205862337fada6378ec97\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304699\nQuick-Run: Kris Krueger \u003ckrisk@microsoft.com\u003e\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Hans Wennborg \u003chans@chromium.org\u003e\nCommit-Queue: Hans Wennborg \u003chans@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1113283}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a8089a0d27762c967a55612a8edefbf6ace7ae91\n" }, { "commit": "cb2c67c8b665d2518b03cdf7c84929f1188821a3", "tree": "2078b8696476d152923dd8d2f4654350797b37e7", "parents": [ "82aa71d63d29c2a142db8fa0f306509c6fb33a6b" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Mon Feb 13 21:30:01 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 13 21:36:50 2023" }, "message": "Update update_idl.py\n\nThis change generalizes, optimizes, and fixes update_idl.py.\n\nupdate_idl.py is a script that was used for updating some of the\nwin_build_output/midl files. It was originally written just to update\nthe files in chrome/updater/app/server but this change generalizes it so\nthat it can be used for ten idl targets. This is important because\nthe output files change whenever we do a Windows SDK update and the\nfiles need to be regenerated for x86, x64, and arm64 for all ten\ntargets.\n\nThis change generalizes this script by adding the additional seven build\ntargets to the idl_target list.\n\nIt optimizes this script by not calling gn gen if the build settings\nhave not changed, and by making the architecture loop the outermost\nloop. This makes the script run many times faster.\n\nIt makes the script more reliable by using -j 1 so that the build output\nis predictable.\n\nThis change was tested by running this command with the current\ntoolchain, and also with a not-yet-committed change that includes the\nWindows 11 SDK. In the first case no updates were found to be needed. In\nthe second case many updates were made and these were sufficient to pass\nthe CQ with the new toolchain.\n\nBug: 1273169\nChange-Id: Idb2b4e18e59464fce455201b09d4cb3f67b1cfd3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4246046\nReviewed-by: Xiaoling Bao \u003cxiaolingbao@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1104678}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2d3b443d96b65d204bb037dcf54d503441e14ad3\n" }, { "commit": "82aa71d63d29c2a142db8fa0f306509c6fb33a6b", "tree": "5a6181cb8fa5a6a3dcefac585e929e2500eddb5e", "parents": [ "da6d7e2205385a52695ca207624ad68eedaf16a0" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Mon Feb 13 18:04:14 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 13 18:19:17 2023" }, "message": "Migrate tools/win/*.py to four-space indents\n\nMoving update_idl.py chrome/updater/tools to tools/win forced me to\nconfront the fact that tools/win is all formatted with two-space indents\nbut our goal is Python code with four-space indents. The only reasonable\nways to work on update_idl.py were to move it to two-space indents (bad)\nor move all of tools/win/*.py to four-space indents. This change does\nthe latter.\n\nAdding a line to all of the scripts to make them changed and adding a\nnew .style.yapf file followed by running:\n git cl format --python --full\nfollowed by cleaning up the comments which overran the 80-column line\nlength did the trick.\n\nLight testing was performed on some of the scripts. The diffs mostly\nshow that only indenting was changed, but sometimes the diff algorithm\ngets confused for unknown reasons.\n\nChange-Id: I3926575d4a81eb55c45f429be60c62e8fb81ccbd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240735\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1104554}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 301533f6f29ebc8890542f78b5f57c3d88217b2c\n" }, { "commit": "da6d7e2205385a52695ca207624ad68eedaf16a0", "tree": "d74a3d25682f095f454d5ef58c58e7e74a34d1c9", "parents": [ "c0c6f7c488cefa204d3f47fd7477fcb86d15c35d" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Sun Feb 12 17:24:40 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sun Feb 12 17:32:07 2023" }, "message": "Move update_idl.py to tools\\win\n\nupdate_idl.py was written for updating IDL files in chrome/updater but\nturns out to be a crucial tool for updating all IDL files. This moves\nupdate_idl.py in preparation for some updates to generalize and improve\nit.\n\nChange-Id: I62af367cf8b1d3c4c3cc8c6a0688c7fbaee46e6b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4242108\nReviewed-by: Xiaoling Bao \u003cxiaolingbao@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1104322}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fc1fe5bb837c76d3aa0ffdae05ff1ef293394b42\n" }, { "commit": "c0c6f7c488cefa204d3f47fd7477fcb86d15c35d", "tree": "3d95de9e09dceda1ab0c1dbe90362890a32519d4", "parents": [ "c5d25ec94962a207fcbceb7e2ac0256b92b1d09d" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Thu Feb 09 18:37:05 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 09 18:42:36 2023" }, "message": "Switch windbg_common.bat to python3\n\ntools\\win\\windbg64.bat and tools\\win\\windbg32.bat can be used to launch\nthe version of Windbg packaged in the Chromium toolchain used by Google\nemployees, however the batch file was invoking python instead of\npython3. This corrects that.\n\nThe change is necessary because build\\vs_toolchain.py ends up being\ninvoked and this script is no longer Python 2 compatible.\n\nChange-Id: I24f63e9bac4e4b990c78bdd602ea6991b9dd1e89\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4236516\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1103379}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 19b4c1ae0cdd77b556d3af228f572e27f559bcae\n" }, { "commit": "c5d25ec94962a207fcbceb7e2ac0256b92b1d09d", "tree": "f8658eaa1729e0fa400280accafdf279f567ff0c", "parents": [ "8937869f0d7e249b8f0c286ccad7739e27c5c301" ], "author": { "name": "Aleksey Khoroshilov", "email": "akhoroshilov@brave.com", "time": "Wed Jan 25 18:05:11 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 25 18:17:22 2023" }, "message": "Auto-generate unique output_name for component() gn targets.\n\ncomponent() target generates shared libraries if\nis_component_build\u003dtrue, which creates .dll/.so files right in the\nout/Default directory. This require component() user to come up with a\nunique output_name to not clash with already existing libraries, but in\nmany cases the conflict may not exist and a user doesn\u0027t set the unique\noutput_name. This creates libraries with very generic names such as\n\"events.dll\", \"host.dll\", \"public.dll\".\n\nThis CL forces gn to generate unique output_name using the target path\nand name when output_name is not set explicitly.\n\nExamples of automatic conversions:\nevents.dll -\u003e ui_events.dll\nhost.dll -\u003e components_viz_host.dll\npublic.dll -\u003e components_download_public_common_public.dll\n\nThe CL ensures that targets like //base:base or //v8:v8 will have the\nsame name as before (\"base.dll\" and \"v8.dll\" respectively).\n\nBug: 1407626\nChange-Id: I884f83b52106c70b696408d0f4dcac58bd0d71b1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166369\nAuto-Submit: Aleksey Khoroshilov \u003cakhoroshilov@brave.com\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Lambros Lambrou \u003clambroslambrou@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1096860}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5ad336c9e126f65ce3a0834d8e443d0a8df9ac32\n" }, { "commit": "8937869f0d7e249b8f0c286ccad7739e27c5c301", "tree": "fa9db26bcb1a608068f647c50791b63ba4ac1f7d", "parents": [ "43b78961ed360ad032c236821956fc2007e9585f" ], "author": { "name": "John Abd-El-Malek", "email": "jam@chromium.org", "time": "Tue Jan 10 18:23:33 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 10 18:31:40 2023" }, "message": "Fix Visual Studio visualizers for std::map/std::multimap/absl::variant.\n\nBug: 1406040\nChange-Id: Iad4f61a87638b370f0796de57f3e037771af7ca5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4149252\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1090912}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5038a60294e705db6b36c550f5459a52150b23ec\n" }, { "commit": "43b78961ed360ad032c236821956fc2007e9585f", "tree": "3d64fbae8ed01a2621cbad5a8ec5f66d5ef7ea45", "parents": [ "ab10bdc9724d08eb9668dbf63100e624498b7054" ], "author": { "name": "David Bienvenu", "email": "davidbienvenu@chromium.org", "time": "Thu Oct 20 18:43:09 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 20 18:48:56 2022" }, "message": "Update instructions to current version of Visual Studio\n\nChange-Id: I71b95b46a33cdad86aa158eb8a378223327e0e24\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3968346\nCommit-Queue: David Bienvenu \u003cdavidbienvenu@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1061722}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 792b3280990bd51a883c2be2c25ca8d9c9d552fd\n" }, { "commit": "ab10bdc9724d08eb9668dbf63100e624498b7054", "tree": "e80587cb5498525a212d514ac4bcc2f0522a8374", "parents": [ "89e2d9d4e499cc4b191e7633b66190b640d4daa1" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Thu Sep 15 20:11:09 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 15 20:30:13 2022" }, "message": "Update copyright headers in testing/, tools/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c95.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: I3a8a7b150e7bd64690534727150646081df50439\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900697\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1047644}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dfd88085261b662a5c0a1abea1a3b120b08e8e48\n" }, { "commit": "89e2d9d4e499cc4b191e7633b66190b640d4daa1", "tree": "6374653fc763ae9c37701163fae39b60a2828335", "parents": [ "46ce6f96e0439ac30f89deecbb153cf6b5ab0adb" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Thu Jul 14 23:01:29 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 14 23:09:08 2022" }, "message": "Let IdleWakeups monitor the System process\n\nWhen investigating OS overhead it can be useful to monitor CPU usage and\nother data in the System process. However the default prefix matching\nused by IdleWakeups cannot filter to just this process without also\nmatching SystemSettings.exe, due to the lack of a .exe suffix on the\nSystem process.\n\nTherefore this change special cases the System filter. This change also\nupdates the project to VS 2022.\n\nUsing two copies of IdleWakeups to monitor zeropage_test.exe and the\nSystem process neatly demonstrates the recently discovered issue where\na couple of processes allocating and freeing memory (200% CPU used) can\ntrigger up to 1200% CPU usage in the System process.\n\nChange-Id: Iee4c1ed1f1067e9bc503314fdd72af8f9be002fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3763710\nReviewed-by: David Bienvenu \u003cdavidbienvenu@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1024476}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fc87d5074d6647cf195ac274a1b17ce70686327c\n" }, { "commit": "46ce6f96e0439ac30f89deecbb153cf6b5ab0adb", "tree": "394662fd4afd7c9db543b1b62aebc9aab44ce36d", "parents": [ "9e1d25be96135a1cc62ff20c28031e12b95fe446" ], "author": { "name": "Yoshifumi Inoue", "email": "yosin@chromium.org", "time": "Thu May 19 04:43:04 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 19 04:51:52 2022" }, "message": "[DebugVisualizers] Update for MemberBase\u003cT\u003e changes\n\nThis patch changes `blink.natvis` to adapt new `Member\u003cT\u003e`\nimplementation[1][2], `raw_` to `raw_.ptr_` for inspecting GC objects.\n\nBefore the CL[2]:\n```\n class MemberBase {\n ...\n mutable const void* raw_;\n ...\n };\n```\n\nAfter the CL[2]:\n```\n class MemberBase {\n ...\n using RawStorage \u003d RawPointer;\n ...\n mutable RawStorage raw_;\n ...\n };\n\n class RawPointer {\n ...\n const void* ptr_;\n };\n```\n\nVerification steps:\n 1. devenv.exe /debugexe out\\Debug\\blink_unittests.exe --gtest_filter\u003dLayoutObjectTest.LayoutDecoratedNameCalledWithPositionedObject\n 2. Set breakpoint at line 77 `DCHECK(obj)` in \"third_party\\blink\\renderer\\core\\layout\\layout_object_test.cc\"\n 3. Run executable\n 4. Once hit breakpoint, see variables `div` and `obj` in \"Locals\"\n 5. You can see \"\u003cdiv\u003e test\" in \"Value\" column\n 6. Exapnd `obj` to see `node_`\n\n[1] http://crrev.com/c/2739979 cppgc: Introduce pointer compression based on thread-local base\n[2] http://crrev.com/c/3647359: cppgc: Avoid compression/decompression in Member operators/ctors\n\nBug: 1325007\nChange-Id: I9318777ef32bd1035de2020cb8e0db4f38894a6c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652099\nAuto-Submit: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nCommit-Queue: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1005112}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4ba1516af19291114fe7728c86870083d1ccf71a\n" }, { "commit": "9e1d25be96135a1cc62ff20c28031e12b95fe446", "tree": "dab74ebde95a361c1f620df72f26dbe5ef7a6e28", "parents": [ "c545ece66eaf061b222f275e965439b377c78c30" ], "author": { "name": "David Dorwin", "email": "ddorwin@chromium.org", "time": "Thu Apr 21 20:59:28 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 21 21:09:51 2022" }, "message": "Remove remaining scottmg entries in OWNERS files\n\nFollowing up on https://crrev.com/c/3526975.\n\nChange-Id: I2d00b7c838c68d561c80922f02f38bd5214282ac\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3590893\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: David Dorwin \u003cddorwin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#994895}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9eee2100a7601c697550aa5a8f996b5b831eed86\n" }, { "commit": "c545ece66eaf061b222f275e965439b377c78c30", "tree": "cea93c622e7a03a1550310dbb92baf12b3fe64e9", "parents": [ "0fe11eda7286b17546a5dca5aa250392977660a7" ], "author": { "name": "Yoshifumi Inoue", "email": "yosin@chromium.org", "time": "Wed Apr 20 17:17:57 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 20 17:27:47 2022" }, "message": "[DebugVisualizers] Update for FontPlatformData::typeface_ in blink.nativs\n\nThis patch chagnes a definition of `FontPlatformData::typeface_` to\nuse `fPtr` instead of `ptr_`.\n\nIt seems Skia changes `sk_sp\u003c\u003e` to use `fPtr` was `ptr_` again.\nThe CL[1] changes \u0027ptr_` to \u0027fPtr` on 2018.\n\nVerification steps:\n 1. devenv.exe /debugexe out\\Debug\\blink_platform_unittests.exe\n --gtest_filter\u003dFontPlatformDataTest.AhemHasNoSpaceInLigaturesOrKerning\n 2. Set breakpoint at line 50: `TypesettingFeatures features \u003d ...;`\n 3. Run executable\n 4. Once hit breakpoint, expand one variable `platform_data`.\n 5. You see `typeface_`.\n\n[1] http://crrev.com/c/1288930: Sync recent type changes in webkit.natvis\n\nBug: 1264280\nChange-Id: If2340c57c7fc180ae8eb5ad98dd7bd3fe1a356f0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3595668\nAuto-Submit: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#994190}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6d36fbfa5817daf5678c1503ddcd8d77bd8759ce\n" }, { "commit": "0fe11eda7286b17546a5dca5aa250392977660a7", "tree": "6e82be3f9a89571f4d38f5bb4006dd4f632127cb", "parents": [ "238029631181a183c9e35a2e84c052301ea3391f" ], "author": { "name": "Yoshifumi Inoue", "email": "yosin@chromium.org", "time": "Tue Apr 19 01:33:19 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 19 01:48:26 2022" }, "message": "[DebugVisualizers] Update for blink::FontFamily::family_name_\n\nThis patch changes definitions of `FontFamily` and `SharedFontFamily` to\nuse renamed member name `family_name_` from `family_` done by the CL[1].\n\nVerification steps:\n 1. devenv.exe /debugexe out\\Debug\\blink_platform_unittests.exe\n --gtest_filter\u003dFontFamilyTest.ToString\n 2. Set breakpoint at line 33: `EXPECT_EQ(\"A, B\", family.ToString());`\n 3. Run executable\n 4. Once hit breakpoint, expand one variable having type `FontFamily`.\n 5. You see `family_name_`.\n\n[1] http://crrev.com/c/3086462: Refactor internal representation of\ngeneric font-family name\n\nBug: 1264280\nChange-Id: I10fec9289e375cc516d12b2dc5d85644230832c8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3589436\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nAuto-Submit: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#993522}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b3a05bc13fe4b1caa7c15de06dc5647b3cb04f39\n" }, { "commit": "238029631181a183c9e35a2e84c052301ea3391f", "tree": "ba08fc69017ff57618da910b3ebe7e75963cce47", "parents": [ "478abfa3a2ddde6804ae38a1f78105e9e011ac41" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Tue Apr 05 19:58:32 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 05 20:08:28 2022" }, "message": "Get timeit.bat to handle midnight\n\nWhen running long tests it is quite possible for the test to continue\npast midnight, in which case a negative duration will be printed. These\nerrors can happen on quite short test runs if they start close enough to\nmidnight. These errors can be handled by checking for a negative\nduration and then correcting it by adding 60 * 60 * 24 (86,400).\n\nTimes will still be incorrect for test runs that go longer than 24\nhours, but solving that seems much less important.\n\nChange-Id: I611921ef3fdd9515596154ed8533818ec7bcd38a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3570055\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#989119}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 21251ec361ed7601fcb22fe9193cc37dcf76b760\n" }, { "commit": "478abfa3a2ddde6804ae38a1f78105e9e011ac41", "tree": "6b5f4568b6490f0c01bd8c4e8619c4d82d0aa4df", "parents": [ "5aa3b5231d289d4da79999e2ea3410181d1c2bb7" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Fri Jan 21 00:39:07 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 21 01:06:18 2022" }, "message": "Get ShowGlobals to recognize folded globals\n\nThe linker can fold identical constant global variables into one space,\njust like with code folding triggered by /OPT:ICF. This optimization\nleaves multiple symbol records all pointing at the same memory.\nPreviously ShowGlobals would report this as an optimization opportunity,\nwhen it was not. Now ShowGlobals crudely recognizes that duplicate\nsymbols reference the same address and does not show them. The new\n--show_folded_constants option can be used to show these folded globals\nsince they are often still bad code patterns.\n\nThis change also updates this project to VS 2022.\n\nBug: 1269955\nChange-Id: Ic168b8f459c0f052e9d54cfbc7735b9c816b65f4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3400340\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#961716}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2b5f2eebeea979a96eb346660b311fb67f4214a7\n" }, { "commit": "5aa3b5231d289d4da79999e2ea3410181d1c2bb7", "tree": "61c044b3bcdce3aaa80c0089630aab95730c66dc", "parents": [ "90fb5c6c5bbe8e5c4bd3622a17625fb48e01881c" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Mon Nov 15 19:14:42 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 15 19:34:17 2021" }, "message": "Fix ShowGlobals to build, and build with VS 2019\n\nShowGlobals.cc includes a file from base that has been deleted, so it\ndidn\u0027t compile at all. It also needed upgrading to VS 2019.\n\nWith these changes it builds and after registering msdia140.dll I was\nable to run the 64-bit version and analyze chrome.dll.pdb.\n\nBug: 1269955\nChange-Id: I09b640aa1fb5bd6aac7ad29f62db76a52c716c5f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3279349\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#941771}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3b95bf1362266843dbe9e218af88d1e434ef923a\n" }, { "commit": "90fb5c6c5bbe8e5c4bd3622a17625fb48e01881c", "tree": "db1acd8fb72bcfd09a99a6ed99ca75d9ff1f68e6", "parents": [ "fc02f0742ec15d2511ca21a60966dd31612b6a1f" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Nov 12 03:40:24 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 12 03:49:01 2021" }, "message": "Remove most remaining unused \"base/macros.h\"\n\nRemoves `#include \"base/macros.h\"` from remaining .cc, .h and .mm files\nthat do not contain `ignore_result(` and do not trigger pre-commit or\npre-upload errors.\n\nBug: 1010217\nNo-Try: true\nChange-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#941054}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5666ff4f5077a7e2f72902f3a95f5d553ea0d88d\n" }, { "commit": "fc02f0742ec15d2511ca21a60966dd31612b6a1f", "tree": "ec83ad511f9562d36519e6d95a2e0cb8a69f63f1", "parents": [ "849b5779daa0ba8c201f4736345297217b26d6f6" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Tue Sep 28 00:28:00 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 28 00:38:03 2021" }, "message": "Script remove more DISALLOW_COPY_AND_ASSIGNs\n\nThis applies a script previously used for large directories on all\nremaining (smaller) directories as a single chunk.\n\nThis replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes\nwhere a local script is able to detect its insertion place (~Foo() is\npublic \u003d\u003e insert before this line).\n\nThis is incomplete as not all classes have a public ~Foo() declared, so\nnot all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.\n\nIWYU cleanup is left as a separate pass that is easier when these macros\ngo away.\n\nBug: 1010217\nChange-Id: I572936462f763e1dd15dd88cdcf451ee14b34dd1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182480\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#925533}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c68c5aad6c5f2cbbda3efc5a1e6dd647bbc55108\n" }, { "commit": "849b5779daa0ba8c201f4736345297217b26d6f6", "tree": "321ae882acf1a42224021471ee1fa3575786b8d0", "parents": [ "3e73acbf8cc9497dabce4e3819e201f58cfb66b2" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Mon Sep 13 23:17:02 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 13 23:38:23 2021" }, "message": "[DebugVisualizers] Add V8 BasicPersistent to blink.natvis\n\nThis change enables |Persistent\u003cT\u003e| for the Visual Studio\ndebug visualizers.\n\nFollowing r915079 crrev.com/c/3108807 which added |Member\u003cT\u003e|\nto `blink.natvis`, this patch adds |BasicPersistent\u003cT\u003e| using\nthe same techinque as |Member\u003cT\u003e|.\n\nBug: 1056170\nChange-Id: Id8153c643ee90d96d95b13feafb220ca52c83ba3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138165\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#920978}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 662874ea22e7dff4ebfdadb18133ceced92980da\n" }, { "commit": "3e73acbf8cc9497dabce4e3819e201f58cfb66b2", "tree": "2d48ba6535847d6d28e2d84647fd2ec040875564", "parents": [ "f8c29b26bd5ba38c690d95c385c185131c1e2c74" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Sat Aug 28 14:24:59 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Aug 28 14:33:22 2021" }, "message": "[DebugVisualizers] Improve/fix NGFragmentItem\n\nThis patch:\n* Adds `SVGText`, a new addition to the class.\n* Change to use enum members instead of int constants.\n* Add intrinsic `Type()` function to avoid lengthy\n expressions appearing multiple times.\n\nChange-Id: Ic2e9e5478ff591fbc47a9811e8fa70d1c11a89cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3121639\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#916240}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3c0df65cdbc47ff4bc9b1d3f560f47a4a2405f55\n" }, { "commit": "f8c29b26bd5ba38c690d95c385c185131c1e2c74", "tree": "1bd006f47509f65abc2b353c2cd0a184b042f577", "parents": [ "0f9967d145e61685c49c198756dbe70e3b037921" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Sat Aug 28 12:26:09 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Aug 28 12:35:07 2021" }, "message": "[DebugVisualizers] Improve/fix NGPhysicalBoxFragment\n\nThis patch:\n* Changes `NGPhysicalBoxFragment` to match the recent member\n name changes in the Oilpanization CLs.\n* Add `FragmentItems`.\n* Add `BoxType()` intrinsic function.\n* Add `DisplayString` as doing this in its parent class\n (`NGPhysicalFragment`) became not possible since\n crrev.com/c/3121638.\n\nChange-Id: If8c652a6a780d079d404d3719e703809f1e6883a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3124366\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#916234}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f1d5e1510637c5f4a1edcb12b52e5007e3e5609e\n" }, { "commit": "0f9967d145e61685c49c198756dbe70e3b037921", "tree": "c7c0266515b42c327bc531b3f0e7946b974b879f", "parents": [ "6f5328ae9031d5dc217a6e6bf7b36f5d0f780fd6" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Sat Aug 28 11:36:46 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Aug 28 11:45:22 2021" }, "message": "[DebugVisualizers] Use MostDerivedType for NGPhysicalFragment\n\nIt turned out that `\u003cExpandItem\u003e` does not work for array\nitems, but `\u003cMostDerivedType\u003e` does. For that reason, This\npatch changes `NGPhysicalFragment` to use `\u003cMostDerivedType\u003e`.\n\nAlso:\n* Changed to use enum members instead of int.\n* Added `\u003cIntrinsic\u003e` to get the casted type to compare with\n the enum members to avoid lengthy expression appearing\n multiple times.\n\nChange-Id: I9cbfe0773c70ca59206fea2ef960aed57b1c05b6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3121638\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#916231}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 88caf3b95eef1404951e8ae92ad7e0453a7bce71\n" }, { "commit": "6f5328ae9031d5dc217a6e6bf7b36f5d0f780fd6", "tree": "69b801e6652ec68e50417e269a850daf3dbd0408", "parents": [ "cee931cad3de423cba1a218bc902c354665d4834" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Sat Aug 28 09:30:17 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Aug 28 09:37:26 2021" }, "message": "[DebugVisualizers] Remove NGPhysicalLineBoxFragment::Children\n\nThis member was removed in r873361 crrev.com/c/2830411. This\npatch removes it accordingly.\n\nChange-Id: Ic9f42a93d581c7533aa1cd427384c16f9a0e51dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3122704\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#916228}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 741dfd6e18494813e1ae7c83001d1b093c21623f\n" }, { "commit": "cee931cad3de423cba1a218bc902c354665d4834", "tree": "b269970012cbb3c809603a1077c9834a6b387349", "parents": [ "5567e124cffa35961bb01034601ec75f50f16fc0" ], "author": { "name": "Yoshifumi Inoue", "email": "yosin@chromium.org", "time": "Wed Aug 25 07:15:44 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 25 07:26:01 2021" }, "message": "Make blink.natvis support Oilpan version of Member\u003cT\u003e\n\nThis patch changes \"blink.natvis\" to handle Oilpan version of\n|Member\u003cT\u003e|.\n\nTo verify this change, I did:\n 1. Run devenv.exe /debug out\\Debug\\content_shell.exe --single-process\n 2. Set break point in |LayoutObject::AddChild()|\n 3. Move mouse pointer to |new_child| to see tooltip\n Tooltip contain HTML element name\n 3. Expand |this| in \"Local\" window\n Value column of |this| holds HTML element name\n 4. Expand |node_|\n Value column of |node_| holds |Node| name or text\n\nThis CL is follow-up the CL[1] supports Blink version of |Member\u003cT\u003e|.\n\nNote: Oilpan version of |Member\u003cT\u003e| is introduced by the CL[2] on August\n11, 2021.\n\nBlink version:\nnamespace blink\n class Member : MemberBase\u003cT, ...\u003e {...}\n class MemberBase { T* raw_; }\n\nOilpan version:\nnamespace gppcc\n Member \u003d BasicMember\u003cT, ...\u003e\n namespace internal\n class BasicMember : MemberBase\u003cT,...\u003e, CheckingPolicy {...}\n class MemberBase { T* raw_; }\n\n[1] http://crrev.com/c/2896119 Add `\u003cSmartPointer\u003e` to smart pointers in .natvis\n[2] http://crrev.com/c/3089152 Reland \"Enable Oilpan library\"\n\nBug: 1056170\nChange-Id: Id2367a9b63b27b40bdc079a94fc5d3fe6a53573d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3108807\nCommit-Queue: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nAuto-Submit: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#915079}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 49af88c16ac2be86363391172bbb9303f948a32e\n" }, { "commit": "5567e124cffa35961bb01034601ec75f50f16fc0", "tree": "c1b4a1b2f734ecdc1b678962fe31eb5e6499b22b", "parents": [ "f989aa069459aa6233f85ea25a1ad9b95e710735" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Mon Jun 21 02:00:08 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 21 02:06:15 2021" }, "message": "Fix typo for |absl::optional|\n\nWhen r883301 crrev.com/c/2896995 renamed |base::Optional| to\n|absl::optional|, it did not make the \"O\" small letter. This\npatch fixes this.\n\nAlso changed `\u003cItem\u003e` to `\u003cExpandedItem\u003e` as requiring users\nto expand the `Value` member has no benefits.\n\nChecked according to the test process at:\nhttps://source.chromium.org/chromium/chromium/src/+/main:tools/win/DebugVisualizers/README.md\n\nBug: 1202909\nChange-Id: If0d8ce7c8a4cce3965aa05a322d46eb0c86f0cf8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972314\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#894131}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d52d9cc0d2c09676ba592fd25c20fd83efc6b8c1\n" }, { "commit": "f989aa069459aa6233f85ea25a1ad9b95e710735", "tree": "b6fadbba947fef9b0856c081cfb87e015fd9eeff", "parents": [ "9c6eafb97f55af52a11498fd56e1cc8f434e9702" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Mon May 17 20:24:53 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 17 20:29:59 2021" }, "message": "Add `\u003cSmartPointer\u003e` to smart pointers in .natvis\n\nThis patch adds `\u003cSmartPointer\u003e` elements to smart pointers\nin .natvis files; in particular:\n* scoped_refptr\n* blink::MemberBase\n* blink::PersistentBase\n\nThis is the same change as done to `std::unique_ptr` in\n\u003ccrrev.com/c/1567928\u003e.\n\nThe Natvis `\u003cSmartPointer\u003e` element is documented only in the\nXSD, locally installed at [1] or at VSCode Natvis Schema[2].\nFrom the XSD and from testing:\n* It allows users to omit the pointer, such as\n `my_refptr-\u003emember` instead of `my_refptr._ptr-\u003emember`,\n in .natvis files and in any debugger windows such as Auto,\n Local, and Immediate.\n This is especially helpful as we movie more refptr\u0027s to\n Oilpan (`MemberBase`) in Blink.\n* It supports automatic display and expansion, though, this\n patch existing `\u003cDisplayString\u003e` and `\u003cExpand\u003e` elements to\n retain the existing behavior without using the support.\n\nTwo additional related changes are also included:\n1. Add `\u003cExpandedItem\u003e` to expand members automatically. This\n is the same way as `unique_ptr`.\n2. Removed `RefCounted`.\n Having this definition prevented viewing members of derived\n class in other than raw view. I tried several ways to fix\n this, but it looks like this is the best way.\n Users can still expand `RefCounted` to view `ref_count_`\n and other members.\n\n[1] C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Professional\\Xml\\Schemas\\1033\n[2] https://code.visualstudio.com/docs/cpp/natvis\n\nChange-Id: I6f2f08452a9e9a9eab18baf2cd95a31847b6eeba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896119\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#883593}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 252ea10dbd61102c7f46946b064a9f84fae9ea01\n" }, { "commit": "9c6eafb97f55af52a11498fd56e1cc8f434e9702", "tree": "d627589ff803f62fc8a925b60b5a18b8064d4e75", "parents": [ "41cda162a81aa72280296ee07a39c223a50e38c7" ], "author": { "name": "Anton Bikineev", "email": "bikineev@chromium.org", "time": "Sun May 16 01:16:56 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sun May 16 01:22:33 2021" }, "message": "third_party,tools: Replace base::Optional with absl::optional\n\nThis replaces:\n- base::Optional -\u003e absl::optional\n- include \"base/optional.h\"\n -\u003e\n include \"third_party/abseil-cpp/absl/types/optional.h\"\n- base::nullopt -\u003e absl::nullopt\n- base::make_optional -\u003e absl::make_optional\n\nThis also tries to fix gdb and msvc printers.\n\nBug: 1202909\nChange-Id: I2431990da1671751a5d804be162655f086bde8cd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896995\nCommit-Queue: Anton Bikineev \u003cbikineev@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nAuto-Submit: Anton Bikineev \u003cbikineev@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#883301}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4078042d186d93e60aa9e17f799f0dc550dbfda7\n" }, { "commit": "41cda162a81aa72280296ee07a39c223a50e38c7", "tree": "bbbfbc23b58212cfba55ba9fee23fba023c6ec30", "parents": [ "8b477c1f453e513d10671d99a6d87726bc1beb17" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Thu May 13 23:35:18 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 13 23:42:52 2021" }, "message": "Change IdleWakeups to show private commit instead of WS\n\nMeasuring memory is hard and when IdleWakeups was written Chromium used\nPrivate Working Set as the best measure of how much memory Chromium was\nusing. At the time this was a reasonable measure because (absent system\nmemory pressure) it would represent all of the memory that Chromium had\nallocated.\n\nHowever the introduction of memory compression changed how Windows\nhandles private working sets. Windows will now drain pages from a\nprocess\u0027 working set (if they haven\u0027t been touched recently) even when\nthere is no memory pressure. It compresses these pages. The theory is\nthat the freed up memory can be put to better use, and decompression is\nfast so there is (mostly) no downside.\n\nThis is all fine but it means that private working set is no longer a\nmeaningful measure of how much memory Chromium is consuming. Instead we\nnow use private commit, which is a measure of how much memory Chromium\nhas requested. Some bits of this memory may never have been touched and\nthus have never contributed to memory pressure, but we try to avoid this\nas much as possible. And, private commit is one of the limiting factors\non Windows, especially on machines with small page files.\n\nThis change renames the |working_set| variables to |memory|, and changes\nthe value stored and the labels printed to private commit. It also\nchanges a couple of casts so that they don\u0027t give warnings in 64-bit\nbuilds.\n\nChange-Id: I56af48f2d62ec0a8719ccb21177293148ad3e232\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2891205\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#882754}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 129e4a4293f3e8e21e8f9785f7bf639434c31fbc\n" }, { "commit": "8b477c1f453e513d10671d99a6d87726bc1beb17", "tree": "17f41454c8ee81ebb0ce7cfdec689c4328d5404d", "parents": [ "ed7f8007ff6da32e0dd317211d9dd830ea43cf9b" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Wed May 12 20:56:08 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 12 21:04:36 2021" }, "message": "Add handle counts to IdleWakeups summary\n\nChrome has had an Event handle leak for a while and it is useful to be\nable to summarize how many handles are open across all Chrome processes\nin order to better evaluate the fix.\n\nBug: 1183081\nChange-Id: I438a9880a9ec41d91e4632ae538290c9671a0d79\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2892959\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#882271}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8bbf615ef5c633563472e64ae492ea33eb6f4c72\n" }, { "commit": "ed7f8007ff6da32e0dd317211d9dd830ea43cf9b", "tree": "a6b4b4d3fd8e738cdf9d416942bf5583dc4d5c02", "parents": [ "19f5ffc9cb12fda2fee5e002cf77273077178904" ], "author": { "name": "Zequan Wu", "email": "zequanwu@google.com", "time": "Wed Apr 07 18:23:16 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 07 18:31:52 2021" }, "message": "Fix pe_summarize.py to be compatible with python3.\n\nChange-Id: I15be235a4809ddee33c01afe9f45637a2dea481a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2806727\nAuto-Submit: Zequan Wu \u003czequanwu@google.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#870109}\nGitOrigin-RevId: 29ee185c1ce162f20f04a0b019a0e348c5ce86af\n" }, { "commit": "19f5ffc9cb12fda2fee5e002cf77273077178904", "tree": "53ed212953c0badc033b2d326cf28a4009c378d9", "parents": [ "cbef3bf918979bcaad84cb71e8016745765df8ea" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Tue Apr 06 03:58:13 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 06 04:09:06 2021" }, "message": "Add windbg32.bat and windbg64.bat\n\nRunning windbg from the command line can be helpful as a way to specify\ncommand-line arguments such as -o but it is unwieldy due to the varying\nlocations for the SDK install. These batch files find the SDK and launch\neither the x86 or x64 versions of windbg. They also print some very\nbrief suggestions on command-line arguments.\n\nAs an example, instead of running this command:\n\n \"third_party\\depot_tools\\win_toolchain\\vs_files\\20d5f2553f\\Windows Kits\\10\\Debuggers\\x64\\windbg.exe\" -g -G -o out\\Default\\chrome.exe\n\na developer can run:\n\n tools\\win\\windbg64 -g -G -o out\\Default\\chrome.exe\n\nChange-Id: Ib615e97b3281b64a5cba67b85936c0b384a422bc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2794820\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: David Bienvenu \u003cdavidbienvenu@chromium.org\u003e\nReviewed-by: Elaine Chien \u003celainechien@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#869384}\nGitOrigin-RevId: af77d977c68dcfec1c560db8c5f5164d3693306d\n" }, { "commit": "cbef3bf918979bcaad84cb71e8016745765df8ea", "tree": "83c0daca27a4e00090cfdc8e601334d0a1634289", "parents": [ "823c2d71020ded4fe0179b514efb35dca50c928c" ], "author": { "name": "Robert Liao", "email": "robliao@chromium.org", "time": "Mon Mar 01 18:25:19 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 01 18:35:15 2021" }, "message": "Add Docs for chromeexts\n\nBUG\u003d1168231\n\nChange-Id: I53576e90421502a90522f71c0bcd2b027006de60\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725316\nAuto-Submit: Robert Liao \u003crobliao@chromium.org\u003e\nCommit-Queue: Wei Li \u003cweili@chromium.org\u003e\nReviewed-by: Wei Li \u003cweili@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#858609}\nGitOrigin-RevId: 0329f3957a6fbf5fc96e1c8c588312c505a76628\n" }, { "commit": "823c2d71020ded4fe0179b514efb35dca50c928c", "tree": "9a954cc85b9bba52ba6fd0c6818c89a8b9b2aa44", "parents": [ "6ef8eb35e5e37e501b29673f8f78b1252e2bd8c6" ], "author": { "name": "Robert Liao", "email": "robliao@chromium.org", "time": "Wed Feb 10 17:01:30 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 10 17:07:30 2021" }, "message": "Connect chromeexts View Command to PrintViewHierarchy()\n\nBUG\u003d1168231\n\nChange-Id: Iceed43a7231d2f6ea14ea7bf0df27462e590dc08\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679307\nCommit-Queue: Thomas Lukaszewicz \u003ctluk@chromium.org\u003e\nReviewed-by: Thomas Lukaszewicz \u003ctluk@chromium.org\u003e\nAuto-Submit: Robert Liao \u003crobliao@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#852680}\nGitOrigin-RevId: 417622e95d197b26ed668d0eecbb7292c6aa3515\n" }, { "commit": "6ef8eb35e5e37e501b29673f8f78b1252e2bd8c6", "tree": "8614d9cd45e6036a304a2b493830212fae6083dc", "parents": [ "f7c416697f35c760bf4a9c3178b4e6e631650e3a" ], "author": { "name": "Robert Liao", "email": "robliao@chromium.org", "time": "Mon Feb 01 22:44:58 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 01 22:51:32 2021" }, "message": "Add Support to Display One Level of Children on Demand\n\nThe /children flag will display all the immediate children.\n\nBUG\u003d1168231\n\nChange-Id: Iaabad3d70a78c7aebd310b5618e6e53c0e1cbf3d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2665626\nAuto-Submit: Robert Liao \u003crobliao@chromium.org\u003e\nReviewed-by: Wei Li \u003cweili@chromium.org\u003e\nCommit-Queue: Robert Liao \u003crobliao@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#849300}\nGitOrigin-RevId: dafc5b008723d19d593e36be9c61c8e1b54ede88\n" }, { "commit": "f7c416697f35c760bf4a9c3178b4e6e631650e3a", "tree": "0f1c490f1487ac531a1bd39cadff404aa77e55dd", "parents": [ "52f984558d29e0813efa3e9b72401e07b0c91fda" ], "author": { "name": "Dave Tapuska", "email": "dtapuska@chromium.org", "time": "Tue Jan 26 15:27:57 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 26 15:34:02 2021" }, "message": "Remove blink/public/platform/web_rect.h\n\nThis class is no longer used. Remove any includes and the header itself.\n\nBUG\u003d738465\n\nChange-Id: I62f667d964da705f397b23a36b96de9df6bca6c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2647905\nReviewed-by: Ken Buchanan \u003ckenrb@chromium.org\u003e\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nOwners-Override: Kentaro Hara \u003charaken@chromium.org\u003e\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#847173}\nGitOrigin-RevId: 75fbf5ebbb95001069bdc6912a1ef59467717a92\n" }, { "commit": "52f984558d29e0813efa3e9b72401e07b0c91fda", "tree": "535c11a5c45f7db164f51a84f669b597c58e969f", "parents": [ "1b47f9e46af38b7f4157027a8525282d6ab73dfc" ], "author": { "name": "Robert Liao", "email": "robliao@chromium.org", "time": "Fri Jan 22 18:04:23 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 22 18:12:55 2021" }, "message": "Set up a Basic \"view\" Command\n\nBUG\u003d1168231\n\nChange-Id: I9f46b03f3c03a50382778c8d8ae404be8714ab31\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644316\nAuto-Submit: Robert Liao \u003crobliao@chromium.org\u003e\nReviewed-by: Wei Li \u003cweili@chromium.org\u003e\nCommit-Queue: Robert Liao \u003crobliao@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#846202}\nGitOrigin-RevId: 717a503feed3cc3fd4ae9e6f84e80ea89e9779f8\n" }, { "commit": "1b47f9e46af38b7f4157027a8525282d6ab73dfc", "tree": "c9be7778bf22ae4ffbdae56ad712ea3cec98d678", "parents": [ "dabc1b42ac2e1900adf96824a27264914a6034d1" ], "author": { "name": "Robert Liao", "email": "robliao@chromium.org", "time": "Wed Jan 20 19:43:09 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 20 19:58:30 2021" }, "message": "Add base::CommandLine Support to chromeexts\n\nBUG\u003d1168231\n\nChange-Id: I7d0249efadf3da294414932f9511e18d1752994e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638550\nAuto-Submit: Robert Liao \u003crobliao@chromium.org\u003e\nReviewed-by: Wei Li \u003cweili@chromium.org\u003e\nCommit-Queue: Robert Liao \u003crobliao@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#845286}\nGitOrigin-RevId: 202d44ec5a334f0321f832002707c25c7eb2dc6e\n" }, { "commit": "dabc1b42ac2e1900adf96824a27264914a6034d1", "tree": "37cd9a1638968b1845b21c6a392b5e2f0fe43ade", "parents": [ "1a7c6f737ae72623613d074d118be6402737f9ca" ], "author": { "name": "Robert Liao", "email": "robliao@chromium.org", "time": "Wed Jan 20 17:41:48 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 20 17:52:25 2021" }, "message": "Refactor the Way Clients Obtain Interfaces from the Debug Client\n\nThe Windbg Extensions API is spread across multiple interfaces, making\na template based getter more convenient than statically defined\ninterface getters.\n\nBUG\u003d1168231\n\nChange-Id: Id9789641074b842ebcb086d386c58fffabdf104a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637270\nReviewed-by: Wei Li \u003cweili@chromium.org\u003e\nCommit-Queue: Robert Liao \u003crobliao@chromium.org\u003e\nAuto-Submit: Robert Liao \u003crobliao@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#845207}\nGitOrigin-RevId: 59a25f2bbc66fcd52fd05af59c4df75d7585e8a1\n" }, { "commit": "1a7c6f737ae72623613d074d118be6402737f9ca", "tree": "074c3f2b5bdd60c4cf12c6621e19e2e853098d5e", "parents": [ "1f7d9294d3e943959c05dd7fefb3fb8591a9dde2" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Tue Dec 01 03:36:56 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 01 03:47:41 2020" }, "message": "Revert back anonymous unions in blink.natvis\n\nThis patch reverts removed `\u003cItem\u003e`s in r816912\n\u003ccrrev.com/c/2467503\u003e back, because Visual Studio started to\nfail to parse `natvis` when it has `\u003cItem\u003e`s for anonymous\nunions.\n\nIt looks like the issue was fixed in Visual Studio 16.7.7,\nreleased on Oct 27th. Developers who have not upgraded will\nnot be able to use DebugVisualizer for |NGFragmentItem|, but\ncan still view the raw view, and will benefit from the\nDebugVisualizer once they upgraded.\n\nAlso adds a unit test as suggested by brucedawson@ in\n\u003ccrrev.com/c/2467503\u003e.\n\nChange-Id: I4d35ee40a8bbdf2c455f7c4ecf8f8f3b80d1248a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558136\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#832194}\nGitOrigin-RevId: f843c01e2d3a9733c32c80bf3fc5dd479de8fffa\n" }, { "commit": "1f7d9294d3e943959c05dd7fefb3fb8591a9dde2", "tree": "107bcee5c9b818b90a5407d21a98ee08e83aac6b", "parents": [ "70df67ccc7387844f27350c64366aafe1ccaad37" ], "author": { "name": "Jesse McKenna", "email": "jessemckenna@google.com", "time": "Thu Oct 22 17:13:53 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 22 17:19:12 2020" }, "message": "IdleWakeups: enable filtering by process ID\n\nThis change makes IdleWakeups interpret a numeric target process as\na process ID. When a process ID is provided as the target, IdleWakeups\nwill track that process and its child processes.\n\nThis is useful for measuring a particular version of Chrome, e.g., a\nlocal Chromium build, without needing to close all other running\nversions.\n\nExample usage:\nidlewakeups.exe 22612\n\nThe above makes IdleWakeups take measurements for process ID 22612,\nplus all of its child processes.\n\nChange-Id: I267bfc1dda8f5c0600f3fc677e40ca0f6bb26f22\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490253\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#819883}\nGitOrigin-RevId: 44c113052def4661a1d8daab32d67aaa9da8fd69\n" }, { "commit": "70df67ccc7387844f27350c64366aafe1ccaad37", "tree": "02c011152362801b5c4902d1d7976ab58d14c0ba", "parents": [ "efa7a4afb5521c8e7dad4c5895654a823ece65d8" ], "author": { "name": "Jesse McKenna", "email": "jessemckenna@google.com", "time": "Sat Oct 17 16:34:21 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Oct 17 16:38:14 2020" }, "message": "IdleWakeups: optionally print tab-delimited output\n\nThis change adds command-line flag `--tabbed` to IdleWakeups.\n\nThis flag makes IdleWakeups print its final summary only, in\ntab-delimited format. Intermediate measurements and other\ninformational messages are skipped. This is useful for copying or\npiping IdleWakeups\u0027 output to a spreadsheet for sharing and/or further\nanalysis, e.g., using clip:\n`idlewakeups.exe --tabbed --stop-on-exit | clip`.\n\nThe tab-delimited output contains the following columns:\n* Processes created\n* Processes destroyed\n* Context switches/sec, average\n* CPU usage (%), average\n* CPU usage (s)\n* Private working set (MiB), average\n* Power (W), average\n\nChange-Id: Ie269737950eb0d6e183a89c8bef225c7790d257e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468777\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#818254}\nGitOrigin-RevId: 8cebadc81b21fadc612fd1f82588084005abd331\n" }, { "commit": "efa7a4afb5521c8e7dad4c5895654a823ece65d8", "tree": "85626845647d2d6e26a382fd6a07cc5dc53bd867", "parents": [ "74b078801d87739f698363a16e7f7644a5dea088" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Thu Oct 15 06:47:17 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 15 06:53:11 2020" }, "message": "Add README.md to tools/win/DebugVisualizers\n\nNOTRY\u003dTrue\n\nChange-Id: Ib088a06a2f6e85ac5cb23c6c8deb0b6b9eeae7e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470038\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#817399}\nGitOrigin-RevId: 64b47babc0b205def6893d1ceb1773091bd36e61\n" }, { "commit": "74b078801d87739f698363a16e7f7644a5dea088", "tree": "4f04c586f4a903bb11b3ea2215eb83a66db8db6d", "parents": [ "7339fb051703b4b52baf6426bdcbeeaea59fa34b" ], "author": { "name": "Jesse McKenna", "email": "jessemckenna@google.com", "time": "Wed Oct 14 16:49:00 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 14 16:55:14 2020" }, "message": "IdleWakeups: optionally exit with target process\n\nThis change adds command-line option --stop-on-exit to IdleWakeups.\nThis makes IdleWakeups automatically stop measurement when the target\nprocess closes, rather than needing to be stopped via Ctrl-C.\n\nIf the target process is not running when IdleWakeups starts, it runs\nlike normal until the target process is detected and then goes away,\nat which point it stops.\n\nChange-Id: Iaa11d79e13250c8887d7aacfbfde5d0696d76b08\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464442\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#817043}\nGitOrigin-RevId: 074118b671d856a3bdf30d824b22120a40c16f0d\n" }, { "commit": "7339fb051703b4b52baf6426bdcbeeaea59fa34b", "tree": "477b0a231cf940c2d0e60e6bcbbcce72fecdd1f2", "parents": [ "3cf50385f7402e0c45b988504ba5143f06e258d8" ], "author": { "name": "Koji Ishii", "email": "kojii@chromium.org", "time": "Wed Oct 14 06:51:57 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 14 06:56:23 2020" }, "message": "Fix blink.natvis for String and NGFragmentItem\n\nThis patch fixes following issues in blink.natvis:\n1. Fix the incorrect condition for the \"bare\" view of\n |StringImpl|.\n2. Fix the order of `\u003cDisplayString\u003e` for |StringImpl|.\n The `\u003cDisplayString\u003e` element without `Condition` must come\n the last, causing a warning message when natvis diagnostic\n message is enabled.\n3. At some point VisualStudio stopped displaying anonymous\n union, and that the natvis failed to display\n |NGFragmentItem|. Removed members of the anonymous union,\n instead, added |Type| and a few other members.\n\nChecked with natvis diagnostic message turned on.\n\nChange-Id: I25cebc1695434d712d7d5a1a816ae272120d6abb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467503\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Koji Ishii \u003ckojii@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#816912}\nGitOrigin-RevId: 0fa46be8aad7ef9ed1d22ca200240dd4387711b6\n" }, { "commit": "3cf50385f7402e0c45b988504ba5143f06e258d8", "tree": "257a53caeae6e0bf4d7a0f7fdb2d07c04f87c3ed", "parents": [ "de1f382f6f9e514ccee6168e4d6d2b86bd70a19a" ], "author": { "name": "Jesse McKenna", "email": "jessemckenna@google.com", "time": "Tue Oct 06 01:09:51 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 06 01:14:18 2020" }, "message": "IdleWakeups: optionally show CPU time in seconds\n\nThis change adds command-line flag --cpu-seconds to IdleWakeups. This\noption makes IdleWakeups print absolute CPU time in seconds, rather\nthan as a percentage.\n\nBecause average and median CPU time in seconds are not meaningful\nmeasurements, this also adds a \"Sum\" row to the summary. This row\nappears only when --cpu-seconds is enabled, and displays only CPU\ntime.\n\nChange-Id: I9bd4efd8712da9ac976eeb8dc435232c63170827\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441321\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#814030}\nGitOrigin-RevId: 9bb9067bbb650f33fad27ab0d9caff39f4b49b19\n" }, { "commit": "de1f382f6f9e514ccee6168e4d6d2b86bd70a19a", "tree": "573a4f38eed94fb5af11bf120fe417c7d43f7324", "parents": [ "79320c522556ca1e82f88f0b01542d7f90563b73" ], "author": { "name": "Felix Andrew", "email": "felix.andrew@microsoft.com", "time": "Fri Oct 02 00:06:04 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 02 00:10:55 2020" }, "message": "base::Value visualizer\n\nBug: 1132914\n\nChanges to base::Value to use absl::variant made it necessary to change the .natvis to aid in debugging.\n\nChange-Id: I1f3d99afeb28bdb5a9d132d3bb578103befc6525\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436320\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Jan Wilken Dörrie \u003cjdoerrie@chromium.org\u003e\nCommit-Queue: Rafael Cintron \u003crafael.cintron@microsoft.com\u003e\nCr-Commit-Position: refs/heads/master@{#813008}\nGitOrigin-RevId: 9a738068d7e218ecf644a05cb47613c8aad418e2\n" }, { "commit": "79320c522556ca1e82f88f0b01542d7f90563b73", "tree": "ad1014fe81315033419dab5a6e0ea155838566fe", "parents": [ "f5b6a65b404818f88c4fbe8b4f92e860aabfa629" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Tue Sep 08 16:30:30 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 08 16:33:27 2020" }, "message": "Update tools\\win\\setenv.bat to support VS 2019\n\ntools\\win\\setenv.bat is a mostly unknown but sometimes useful batch file\nthat adds the VS tools to the path. It respects the value of\nDEPOT_TOOLS_WIN_TOOLCHAIN and the current toolchain hash. This change\nupdates it to add support for VS 2019, and remove support for VS 2015.\nIt also takes away support for selecting 32-bit versus 64-bit target\ntoolchains because this feature was never used and was too much work to\nsupport (since the packaged toolchain and vcvarsall.bat flags are\ndifferent).\n\nThis change also fixes a bug where the name of the batch file would be\nretained in the command-prompt title after this script exits. Using the\n\"call\" command fixes that. The retained title is ultimately a Windows\ncommand prompt bug which is not going to get fixed. Adding the call\ncommand then requires quoting the command path in the Python script.\n\nChange-Id: I2b4943dc1e391d9fb4a9e76dd8b592223dc31fb4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392013\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#804940}\nGitOrigin-RevId: e169e99714d11226e4ca5fc42d44a8bc92ff5b92\n" } ], "next": "f5b6a65b404818f88c4fbe8b4f92e860aabfa629" }