)]}' { "log": [ { "commit": "4f8413b9d5f89f22a73121e21377084249f0e0f6", "tree": "7f800fb7b25d1da0b27e9ee7917cecc6424c9f60", "parents": [ "542a5059620a679e05193021df348d43e3227a66" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Fri Mar 13 03:22:27 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 13 03:27:04 2026" }, "message": "grit: Multiprocess the output phase to speed up build\n\nGenerating output files (e.g. Android XMLs, zip files, pak fragments)\ncurrently executes sequentially in a single process. Since the GRIT AST\nis loaded into memory and primarily read-only after the gather phase, we\ncan safely fork the process and write the output files in parallel.\n\nTo prevent destroying the Copy-On-Write (COW) memory sharing through\nO(N) cache warmups in every child process, we ensure the AST is fully\nevaluated by processing the very first output file synchronously in the\nparent process. The remaining files are chunked to up to 16 workers.\n\nPerformance Comparison (hyperfine, 3 runs on\nchrome/app/generated_resources.grd): Before (main):\n Time (mean ± σ): 29.964 s ± 0.112 s\n\nAfter (multiprocessing output phase):\n Time (mean ± σ): 15.940 s ± 0.115 s\n\nThis provides a massive ~14s speedup (-46%) for large GRD file builds by\nparallelizing I/O and tree traversals without breaking test behavior.\n\nBug: 491046167\nChange-Id: Iaecf724b6141adf65721507daab1e456effbb06c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7648516\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1598852}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d4c945b2447b383692a102e90dd6935f5c8cf546\n" }, { "commit": "542a5059620a679e05193021df348d43e3227a66", "tree": "c5ca39c1ae1e93a87731099a4213d922ba404e92", "parents": [ "38fba98d527f342c76811c5417b741057a2b9bfe" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Wed Mar 11 13:18:41 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 11 13:22:48 2026" }, "message": "grit: Explicitly flush stdout and stderr before os._exit()\n\nos._exit() bypasses Python\u0027s normal cleanup, such as flushing file\nobjects. This CL adds explicit sys.stdout.flush() and sys.stderr.flush()\ncalls before calling os._exit() to prevent silent output drops. It also\nadds comments explaining why this is necessary and includes a reference\nto the Python documentation.\n\nThis is followup for https://crrev.com/c/7640979/7/tools/grit/grit.py#19\n\nBug: 491046167\nChange-Id: Icdde294a8c7a823705f90bf91c3d2c9943aed10c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7652317\nReviewed-by: Junji Watanabe \u003cjwata@google.com\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1597690}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e203fe8b3224b1c7190937f124cf7bb4f8e76fbb\n" }, { "commit": "38fba98d527f342c76811c5417b741057a2b9bfe", "tree": "cec6d22f01ec93e7ea9528f9f7d7987839179c13", "parents": [ "cf2ade5a0a1e7b7b741dec9d52bb66821b50e0eb" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Tue Mar 10 14:45:28 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 10 14:51:04 2026" }, "message": "Optimize grit build teardown using os._exit\n\nAt the end of a grit build, Python\u0027s garbage collector iterates through\nthe entire AST (often containing millions of nodes and objects, taking\nover 100MB+ in memory) to properly tear down and deallocate objects.\nThis GC phase adds 1~2 seconds of pure overhead at script exit.\n\nBy replacing `sys.exit(ret)` with `os._exit(ret or 0)`, we skip the\nPython GC entirely and let the OS immediately reclaim the process memory\npages, which takes milliseconds.\n\nSince `os._exit` bypasses Python\u0027s normal termination handlers (like\natexit and weakref cleanups) leading to potential resource leaks, this\ncommit also explicitly releases resources:\n- Calls `cleanup()` on `android_output_tmp_dir`\n- Uses `with` context manager for `depfile` to ensure it is flushed\n and closed to disk before exiting.\n\nPerformance Comparison (hyperfine, 3 runs on generated_resources.grd):\nBefore (main):\n Time (mean ± σ): 32.183 s ± 0.852 s\n\nAfter (os._exit):\n Time (mean ± σ): 30.753 s ± 0.562 s\n\nThis provides an instant ~1.43s speedup for large GRD file builds\nwithout any functional changes to the output.\n\nBug: 491046167\nChange-Id: I8b98fe9cca16956fb39c3c2fd33a9a6a109ff924\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7640979\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1597053}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 757fea07042cae2db5bb2dea4de33fd72e9bf085\n" }, { "commit": "cf2ade5a0a1e7b7b741dec9d52bb66821b50e0eb", "tree": "4034476710bfb06680697eedced1824f4828eb63", "parents": [ "132ac21c86ce2ddf76483217317e34b293125175" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Mar 09 16:03:09 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 09 16:12:04 2026" }, "message": "grit: Optimize clique dictionary lookups to O(1)\n\nThe MessageForLanguageAndGender method in clique.py is called millions\nof times during the grit build process. Previously, it iterated over all\nkeys in the dictionary to find a match, resulting in an O(N) linear scan\nfor every query.\n\nThis change replaces the iterative scan with direct O(1) dictionary\nlookups. This significantly reduces lookup overhead and dramatically\nimproves overall build performance.\n\nPerformance result:\n- Before (main): ~70.6s\n- After (this branch): ~38.4s\n(approx. 32.2s speedup)\n\nBug: 491046167\nChange-Id: I8988a9b0308c69f9b17015923890747f936ea18d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7640637\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1596374}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4ad08f1c4cc5df55d59ff08b97402f24b1eb473a\n" }, { "commit": "132ac21c86ce2ddf76483217317e34b293125175", "tree": "5d2f65126bb4c343036c71e5b2df7a48233e98da", "parents": [ "07062f289318eb57f99a678ecb1b55245558aa4f" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Mar 09 15:59:44 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 09 16:06:23 2026" }, "message": "grit: Avoid unnecessary regex execution in MessageNode.Translate\n\nThe _ELLIPSIS_PATTERN.sub regular expression executes for every message\ntranslation, but very few messages actually contain the string \u0027...\u0027. By\nguarding the regex substitution with a simple string `in` check (`\u0027...\u0027\nin msg`), we avoid millions of unnecessary regex scans during the build.\n\nPerformance result:\n- Before (main): ~70.6s\n- After (this branch): ~65.5s\n(A solid speedup of ~5.1s by removing a hot loop bottleneck).\n\nBug: 491046167\nChange-Id: If1ad44fc9a215a87ce5d31b554f5729c501b118f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7640638\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1596371}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a29d5ae6d379e9ade2d4459f85825ed59fae4611\n" }, { "commit": "07062f289318eb57f99a678ecb1b55245558aa4f", "tree": "f8dace3c0d9339279490d2c7cb145753e81b077a", "parents": [ "908ebaf6e41a1e8b380ca4fd1fe64cfb1da5d175" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Mar 09 14:08:51 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 09 14:13:56 2026" }, "message": "grit: Replace lazy_re with standard Python re module\n\nReplacing grit.lazy_re with the standard \u0027re\u0027 module improves build\nperformance, as the lazy compilation wrapper adds unnecessary overhead\nfor frequently used regex operations.\n\nPerformance result:\n- Before (main): ~70.6s\n- After (this branch): ~65.5s\n(approx. 5.1s speedup)\n\nBug: 491046167\nChange-Id: I4834d4aa1f54df7f6e5ce362bd743b58918315fb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7648512\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1596303}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4112cdde5435f89bc81b0412c17604222f2e2544\n" }, { "commit": "908ebaf6e41a1e8b380ca4fd1fe64cfb1da5d175", "tree": "299777918e7bc7aa5351c4857e18823ff93ce5f4", "parents": [ "9f4a7ad41d278a5740f4f1cd5e6eac96035245d4" ], "author": { "name": "Neri Marschik", "email": "nerima@google.com", "time": "Tue Feb 03 04:58:21 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 03 05:03:34 2026" }, "message": "Prepare for executing grit_strings actions on RBE\n\nEvery grit target with a gritdeps file has a new sub action that checks\nwhether the gritdeps file is up-to-date.\n\nThis commit does not yet enable remote execution.\n\nBug: 452240479\nChange-Id: If2e8b4d77a64184cf23760be6eb12cf5d7e51ac8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7250074\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Neri Marschik \u003cnerima@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1578553}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 18e600c92513c21aeeaa576a8ff23e8f7b25c58e\n" }, { "commit": "9f4a7ad41d278a5740f4f1cd5e6eac96035245d4", "tree": "b5162194d5b434df8ed157f86ba5fdc9fb88669f", "parents": [ "28d0135177b344252dff76ba79d27818d31b96ac" ], "author": { "name": "Neri Marschik", "email": "nerima@google.com", "time": "Tue Jan 27 05:13:39 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 27 05:19:27 2026" }, "message": "Fix grit remote actions failing on Windows hosts\n\nThis CL addresses 2 failures.\n\n1. Running `update_resource_ids` on Windows hosts causes\n`gen/tools/gritsettings/default_resource_ids` to contain `\"SRCDIR\":\n\u0027..\\\\..\\\\..\\\\..\\\\..\u0027,` which then causes the grit action on Linux\nworkers to fail.\n\n2. Building on a Windows host results in `python3.exe not found` errors\non Linux workers. Takuto guided me to\n`buildtools/reclient_cfgs/python/rewrapper_windows.cfg` which shows that\nwe always use Linux workers.\n\nBug: 452240479\nChange-Id: I01b14732fe6c3fd6966a72833d92c7be97ea8d70\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7512669\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Neri Marschik \u003cnerima@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1574978}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a1001c31d70c904d7d54e97507d9a4b9c503d178\n" }, { "commit": "28d0135177b344252dff76ba79d27818d31b96ac", "tree": "26e01bb59b187c663074ad70577a93b8c4e17f16", "parents": [ "7d038c9de2ad02b781cf870c3606d1ebc8c6aada" ], "author": { "name": "Neri Marschik", "email": "nerima@google.com", "time": "Thu Jan 22 05:16:07 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 22 05:21:10 2026" }, "message": "Execute chrome/app/generated_resources action on RBE\n\nBenchmark result: reduced wall time for target \u0027chrome\u0027 by 13-20% on\ncloudtops.\n\nMost grit and grit_strings targets don\u0027t specify their inputs which\nresults in remote build failures.\n\nTo get a list of necessary files I found grit_info.py. grit_info.py has\nfunctionality to list all needed inputs of a .grd file, but it considers\nbuild variables. For our use case this does not work since the\ndependencies declared need to work for all build configs.\n\nI added functionality that unconditionally lists all input files which\ncan be called like this: `python3 tools/grit/grit_info.py --all-inputs\nchrome/app/generated_resources.grd`\n\nWith this info we can build dependency files like action_with_pydeps.\nThe grit rule template is changed accordingly.\n\nBug: 452240479\nChange-Id: I563d940c81083475fe8c42d8c93694ed69553b4f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7210473\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Neri Marschik \u003cnerima@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1572750}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0e01172af5ac0058a1514955692a4f7c1eef822e\n" }, { "commit": "7d038c9de2ad02b781cf870c3606d1ebc8c6aada", "tree": "0fd70b7305072c3f8c3ad00e08fae75dc9aabae4", "parents": [ "f9df6c5e3689c667b9aedd4e2bcba70818e7b914" ], "author": { "name": "Neri Marschik", "email": "nerima@google.com", "time": "Thu Jan 22 03:17:23 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 22 03:35:56 2026" }, "message": "Use action_with_pydeps for grit actions to enable remote build\n\nprint_python_deps.py did not work with tools/grit/grit.py because\n1. the grit library does lazy importing\n2. grit.py conflicts with the grit/ package\n\nThis commit converts the lazy imports to normal imports and fixes\nprint_python_deps.py to not alias the grit/ package.\n\nBug: 452240479\nChange-Id: I20b1739e04a5ab7e25f342db6d7f80eb7de976f5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7250075\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Neri Marschik \u003cnerima@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1572728}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4926c951de95096e23a4c5867c4da5df1efcca7c\n" }, { "commit": "f9df6c5e3689c667b9aedd4e2bcba70818e7b914", "tree": "61b7c6354918800e31d5c88a956b8e45d87d7f9e", "parents": [ "0174b1c998b9dc062cf5f5eaf4e509bcb22edc7e" ], "author": { "name": "Neri Marschik", "email": "nerima@google.com", "time": "Mon Jan 19 04:54:04 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 19 04:59:17 2026" }, "message": "Always pass target platform to grit actions\n\nOtherwise RBE builds for the wrong platform because it defaults to the\nhost platform.\n\nBug: 452240479\nChange-Id: Ib3b2dd1b6508ba7e84fc29b51cde729df447a149\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7250073\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Neri Marschik \u003cnerima@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1570978}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f720f899799643250e5c53c96a434147582b814f\n" }, { "commit": "0174b1c998b9dc062cf5f5eaf4e509bcb22edc7e", "tree": "03ac70181d14832d1aaa515d882af1690b61b4c8", "parents": [ "841008d13f3e220126ced34e9e0b33b599a9ab6e" ], "author": { "name": "Ben Joyce", "email": "bjoyce@google.com", "time": "Wed Jan 14 23:24:12 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 14 23:49:34 2026" }, "message": "Add environment variable that sets the module_scheme\n\nSets a module scheme as an environment variable for resultdb upload.\nThese tests are run in presubmit and need to upload as a flat type,\nwhere as by default, they upload with pyunit.\n\nThese tests are called by the presubmit tests and were failing with the resultdb migration in:\nhttps://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/35142/overview\n\nThis change will be used when this catapult CL is rolled:\nhttps://chromium-review.googlesource.com/c/catapult/+/7274125\n\nBug: 467777155\nChange-Id: Icd77254b431aa5ea0793d8e3082e38da78f616fc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7277195\nReviewed-by: Kenneth Russell \u003ckbr@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1569378}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 432d031505518cd80b0ad273561260e7bd8f7b26\n" }, { "commit": "841008d13f3e220126ced34e9e0b33b599a9ab6e", "tree": "80c7a3f9eecae42afcc041c8e466ac07e9626b01", "parents": [ "0d169cfff6b3ebe9037c2adb16ac9915d5649b69" ], "author": { "name": "Neil Kronlage", "email": "neilkr@meta.com", "time": "Mon Dec 15 18:26:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 15 18:47:53 2025" }, "message": "Handle brotli command errors instead of ignoring them\n\nbrotli_util.py ignored errors from the command causing the build to succeed even if\nthe command failed. The resulting executable will crash due to missing resources.\n\nChange-Id: Ib9c2a86b8c8983bc817252e8f6d991f8c733b095\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7256553\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Robert Flack \u003cflackr@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1558829}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f310ddeb309e73db9977d46ae0f892584b03029d\n" }, { "commit": "0d169cfff6b3ebe9037c2adb16ac9915d5649b69", "tree": "e6e82896fd1a43d3872f6f85c8d59c1687b5e6af", "parents": [ "b609d35194781b22e3f044986826ea5aedddb231" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Thu Aug 07 17:49:05 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 07 17:55:03 2025" }, "message": "Grit: Do not leave any gaps when assigning IDs to .grd files\n\nWe hit the int16 limit, so need more space.\n\nThis brings the max id of cros from 65430 -\u003e 55790 (according to\ngen/tools/gritsettings/default_resource_ids)\n\nBug: 436892657\nChange-Id: I0aa1017d63bd2f2ec76278cdbd97ee4a877817e4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826230\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1498349}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e094c24068c0bba807263d048b96e10551ff5f69\n" }, { "commit": "b609d35194781b22e3f044986826ea5aedddb231", "tree": "17e2042b645c24105becb00bc13ff56581122eed", "parents": [ "7584779dce4fe81f98a955b97169d734fe52609d" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Thu Aug 07 16:51:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 07 16:58:41 2025" }, "message": "pak_util.py: Improve error message when file format is wrong\n\nChrome OS gzips their .pak without adding an extension, and this tripped\nme up.\n\nChange-Id: If5efacc131593b09a8aa9bfab118cc98dbc5377b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6827746\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1498301}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f30ddcbb714b082f838913ca9ed869089ac1e64\n" }, { "commit": "7584779dce4fe81f98a955b97169d734fe52609d", "tree": "06c5e9e1c4618140e0c266835524d6d06243428e", "parents": [ "144bfacf3c4ace14a65523ef91d6ae21c2141bb6" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Jul 08 22:25:56 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 08 22:32:16 2025" }, "message": "Cleanup: Remove \u0027chromeos_ash\u0027 Grit variable.\n\n\u0027chromeos_ash\u0027 usages have been replaced by \u0027is_chromeos\u0027 and the former\nis no longer needed. A few remaining usages are removed in this CL.\n\nBug: 373972275\nChange-Id: I7fa82b8a1b6e91e6277bbd2f9f3eb500960459e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6715838\nReviewed-by: Teresa Mao \u003ctemao@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Teresa Mao \u003ctemao@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1484034}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0f7b960cab3770ad72753fc4a27bf8226eefb4f6\n" }, { "commit": "144bfacf3c4ace14a65523ef91d6ae21c2141bb6", "tree": "4437aa9bbcc23c2ff0eff59bb4f5e818edc40543", "parents": [ "844bf396c4a84f2b786c346cc9340a9309ade38b" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu May 22 19:40:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 22 19:47:18 2025" }, "message": "grit: Remove kFooResourcesSize from generated files\n\nChange grit to remove kFooResourcesSize and associated includes. They\nare not longer needed, as all uses have been converted. Update WebUI\ndocuments to stop referring to them as well.\n\nBug: 347651465\nChange-Id: Ica6c3911c0484c49deccd54e49c89eea65c9175c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6557890\nReviewed-by: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1464310}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bc8596a0af7849cfaf6124a1f51cc6eae503f935\n" }, { "commit": "844bf396c4a84f2b786c346cc9340a9309ade38b", "tree": "d668001ee61019ec901ade0da56ede09778fa799", "parents": [ "4b6391ff696824bdb447db799be7bb59fe8cc22a" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Wed May 14 17:47:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 14 17:52:40 2025" }, "message": "[Grit] Change \u0027OTHER\u0027-gender pak files to be just the default file.\n\nIe, now we\u0027ll have \"x.pak\", \"x_FEMININE.pak\", \"x_MASCULINE.pak\", and \"x_NEUTER.pak\".\n\nBug: 416291329\nChange-Id: Ia9afbb19863993c1a7b57af16ce8bcd6f35a8564\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6546244\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1460225}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 09cc696f7ea3203447fd4ec253c65db14a4d5b9e\n" }, { "commit": "4b6391ff696824bdb447db799be7bb59fe8cc22a", "tree": "35aca65d633dd18d8b71496963f29219b6ef8666", "parents": [ "baacd7e289d1f5e38940bc1c1ad09792c9c33635" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Tue May 13 15:13:52 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 13 15:20:25 2025" }, "message": "[GRIT] Dedupe untranslated Android strings.\n\nBug: 413058329\nChange-Id: Ic51e0368e579de9a76f75ba329026f7d82cfce14\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6534561\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1459451}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3bd16cf2b85fd112dc079e6751d0c2f82e7d8acf\n" }, { "commit": "baacd7e289d1f5e38940bc1c1ad09792c9c33635", "tree": "00f9e58e5055f807636f99ac84f81cfb002ca988", "parents": [ "91d79998f0c8d955277d77bb2c3028c3ba4ff205" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Mon May 12 18:38:14 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 12 18:44:49 2025" }, "message": "[Grit] fix filename regex\n\nBefore this CL, the remoting/resources:strings_grit target fails for the\n\"es\" locale because grit replaces all instances of \"es\" (eg, it makes a\nfile called \"remoting/res_FEMININEources_FEMININE/es_FEMININE.pak\"\ninstead of \"remoting/resources/es_FEMININE.pak\").\n\nBug: 409548912\nChange-Id: I5608d487d253789689310e71a8fd25795a0b5b9b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532216\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1458979}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c5a54a53b6040eafcaf435cb339e1292e70712d2\n" }, { "commit": "91d79998f0c8d955277d77bb2c3028c3ba4ff205", "tree": "7bcbe51727987cc06406606067697ea8c540a0d8", "parents": [ "70021edc4afca8c05753a4b9decd60a3706c4315" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Fri May 09 21:58:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 09 22:05:18 2025" }, "message": "[Grit] Change Android \u0027OTHER\u0027-gender language files to be just the default file.\n\nAndroid doesn\u0027t support an \u0027OTHER\u0027 configuration (eg.\n\".../values-fr-OTHER/...\"). It only supports feminine, masculine, and\nneuter. So we have to make the \u0027OTHER\u0027 file into just eg.\n\".../values-fr/...\".\n\nSee\nhttps://developer.android.com/about/versions/14/features/grammatical-inflection#add-translations\n\nWith this patch, building Clank succeeds with `translate_genders\u003dtrue`.\n\nBUG\u003d416291329\n\nChange-Id: I958f781dffe4fecdeb35217a7237b4af69766d00\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6534277\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1458368}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 550692a775297ebe71155bab5533097750c7ba4d\n" }, { "commit": "70021edc4afca8c05753a4b9decd60a3706c4315", "tree": "c0fee652428aa7257af070bd5f3d4845a2bb77b1", "parents": [ "3963557a4815ce3f39295405ab91cd0759e23788" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Fri May 09 18:52:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 09 18:57:52 2025" }, "message": "Move temporary Android strings.xml files to system tmp dir during build.\n\nAlso contains a one-line fix for a race condition which caused rare\nbuild flake (see bug).\n\nBug: 416629238\nChange-Id: I0af0faac5d949990d11987ccb6b469edbb7e7db8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532567\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1458254}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d407714d5d7da3e28f329fb463a4ed76b61a7ae2\n" }, { "commit": "3963557a4815ce3f39295405ab91cd0759e23788", "tree": "a07285c2029c266c9b4f9fc0707bd81c2af66918", "parents": [ "24530830a3b04f7f8095f434aaa0ca4cd026c1c5" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Thu May 08 21:13:14 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 08 21:18:56 2025" }, "message": "Add a `translate_genders` GN arg and start making build work with gender translations.\n\nThis causes GRIT to be invoked with the \"--translate-genders\" flag when\nappropriate.\n\nChrome as a whole doesn\u0027t built when `translate_genders\u003dtrue` yet, but\n`autoninja -C out/Debug components/strings:components_strings_grd`\nsucceeds, which seems like a decent starting place.\n\nBUG\u003d416291329\n\nChange-Id: Ic2723545ec63d4006770cb0935c072c50c700786\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519500\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1457814}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e9516db96ccf07b66c694e6569182262333d71e7\n" }, { "commit": "24530830a3b04f7f8095f434aaa0ca4cd026c1c5", "tree": "e04fef41585f56074f7a41653598d19e389c1385", "parents": [ "1a3d057a3db2042131c797f87ddc899d2cde6d14" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Wed May 07 17:42:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 07 17:47:57 2025" }, "message": "Simplify android grit templates to make use of resources.zip\n\nNow that grit can directly output a resources.zip, we no longer need to\nenumerate the individual outputs in GN.\n\nBug: None\nChange-Id: I922b2f30d578c242fc149710b9a7e197ac066894\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6512614\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1457110}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 77c3f15294c53b2e2662fb8fd6fa303b6c54a057\n" }, { "commit": "1a3d057a3db2042131c797f87ddc899d2cde6d14", "tree": "a67586355c7d7cf491ba6b811d2b81df36061801", "parents": [ "777b07083fc33b8bbc1075715c5ab2e786f8df79" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Tue May 06 18:32:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 18:39:55 2025" }, "message": "[Grit] Rely on \u0027/values\u0027 rather than \u0027/res/\u0027 for Android strings paths.\n\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6511926\nassumed that every Android strings.xml path would contain \u0027/res/\u0027 (with\nthe additional implicit assumption that \u0027values\u0027 would follow \u0027/res/\u0027).\nTurns out that\u0027s not always true - there are many examples of having raw\n\u0027/values\u0027 directories that aren\u0027t contained within a \u0027/res/\u0027 directory.\nFor example,\n\u0027gen/chrome/android/webapk/shell_apk/values-af/android_webapk_strings.xml\u0027.\n\nChange-Id: I0bd20d8f21352982c0582294e7b953a19c1ccffe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6515783\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1456493}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 123b18e420f1541f0ba3cacfe3de4b18777458bc\n" }, { "commit": "777b07083fc33b8bbc1075715c5ab2e786f8df79", "tree": "c924343e9f9139d9ec9d09e8417c40cf5192ddf0", "parents": [ "c42344e31c6b985d4dfafe858eb6e77afbbaa7f2" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Tue May 06 14:41:30 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 14:46:20 2025" }, "message": "[Reland] \"[grit] Optionally output Android xml strings as a single zip file.\"\n\nThis enables us to simplify some GN logic and have fewer expected\noutputs. We should be able to remove the java_strings_grd_prebuilt rule\naltogether, since the only thing is does is zip Android xml files that\nwere generated by different rules. java_strings_grd can also be simpler\nby removing its zipping logic.\n\nOriginal CL\n(https://chromium-review.googlesource.com/c/chromium/src/+/6509131) was\nreverted because it was missing a line in\ntools/gritsettings/translation_expectations.pyl. Thanks to\npabouchard@google.com for the fix, originally at\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6512808.\n\nChange-Id: Ibf57a8de9b65d778102dbecd8df101c46f614bd6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6511926\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1456312}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 657cc4e70e2a65b8f725d9d277e830c24cb5ae5b\n" }, { "commit": "c42344e31c6b985d4dfafe858eb6e77afbbaa7f2", "tree": "7b98dc1db979db200ca7c92af15652c55a2b025f", "parents": [ "20c86c7a354c65382e9d76c7b09e9cadb4bdbc3c" ], "author": { "name": "Timofey Chudakov", "email": "tchudakov@google.com", "time": "Tue May 06 12:39:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 12:45:07 2025" }, "message": "Revert \"[grit] Optionally output Android xml strings as a single zip file.\"\n\nThis reverts commit 1968fce7b6f5253f08435395907f8d3babce3097.\n\nReason for revert: This CL breaks the script to upload UI screenshots.\nError message: gpaste/6168739432890368\n\nOriginal change\u0027s description:\n\u003e [grit] Optionally output Android xml strings as a single zip file.\n\u003e\n\u003e This enables us to simplify some GN logic and have fewer expected\n\u003e outputs. We should be able to remove the java_strings_grd_prebuilt rule\n\u003e altogether, since the only thing is does is zip Android xml files that\n\u003e were generated by different rules. java_strings_grd can also be simpler\n\u003e by removing its zipping logic.\n\u003e\n\u003e Change-Id: I321a6f303ef9b30737841a2d91aa3b1754808c51\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509131\n\u003e Reviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Commit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1455991}\n\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I3e54776f1c228fd3e4e6045635c76659d2d07e86\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6512875\nOwners-Override: Ioana Pandele \u003cioanap@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Timofey Chudakov \u003ctchudakov@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1456242}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3f11451e42c1ea7ea5a87edf4655978350902442\n" }, { "commit": "20c86c7a354c65382e9d76c7b09e9cadb4bdbc3c", "tree": "c924343e9f9139d9ec9d09e8417c40cf5192ddf0", "parents": [ "c3918a05fa5731a223b104e8c6e7aadaef535e51" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Mon May 05 23:04:25 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 05 23:11:31 2025" }, "message": "[grit] Optionally output Android xml strings as a single zip file.\n\nThis enables us to simplify some GN logic and have fewer expected\noutputs. We should be able to remove the java_strings_grd_prebuilt rule\naltogether, since the only thing is does is zip Android xml files that\nwere generated by different rules. java_strings_grd can also be simpler\nby removing its zipping logic.\n\nChange-Id: I321a6f303ef9b30737841a2d91aa3b1754808c51\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509131\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1455991}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1968fce7b6f5253f08435395907f8d3babce3097\n" }, { "commit": "c3918a05fa5731a223b104e8c6e7aadaef535e51", "tree": "7b98dc1db979db200ca7c92af15652c55a2b025f", "parents": [ "abacb6bd755c0b9b4e11fcb7814c93dec920fd04" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Wed Apr 30 19:26:21 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 30 19:33:21 2025" }, "message": "[Grit] Dedupe redundant gender translations.\n\nWe expect gender translations to be sparse, so we avoid including the\nstrings in each gender file which are already included in the default\ngender file to save binary size.\n\nBug: 409548912\nChange-Id: If830813f0dcbbfc59eaa5e704ecf291894f9e4ac\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6501852\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1454099}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 07aa962682fc2991009607072003b9aa69216c26\n" }, { "commit": "abacb6bd755c0b9b4e11fcb7814c93dec920fd04", "tree": "31acf3d25a4292192138dd79525262b1ed8b3870", "parents": [ "6b35008ab1551c3fae46f353d45ac965c45f7adc" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Tue Apr 29 19:58:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 29 20:04:37 2025" }, "message": "[Grit] Support genders in GetDataPackValue() functions.\n\nGender translations already work for strings.xml (with the\n--translate-genders flag), but this CL should bring support to PAK files\nas well. Note that at the moment, the generated files for each gender\nstill have redundant entries (ie, translations that aren\u0027t\ngender-specific are duplicated between all the gender files).\n\nBug: 409548912\nChange-Id: I6368a4bbd8d24d89f96561c2fc872df13a298938\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6496393\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1453470}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d07ca3efc2e641349df8fcd92e134591117af928\n" }, { "commit": "6b35008ab1551c3fae46f353d45ac965c45f7adc", "tree": "fe206a7b6357979e4cfbd44a973f1394354eb6d7", "parents": [ "beb2b71ff049bd4e5d61c83dc19df758b51982ab" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Tue Apr 29 16:32:53 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 29 16:39:23 2025" }, "message": "[Grit] Add gender support for Format() functions.\n\nBug: 409548912\nChange-Id: Ia99546d09275a0063bad0f190e9a536eb892de9c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6488811\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1453319}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ea48e438f40e48814bd9ad3c4b89ffd1978d9e54\n" }, { "commit": "beb2b71ff049bd4e5d61c83dc19df758b51982ab", "tree": "ac8e70287e3e9ba9208f0bcc696648573ba0fc98", "parents": [ "cb776eac81987650d363882832ca63f1912c1de8" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Fri Apr 25 21:36:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 25 21:41:46 2025" }, "message": "[Grit] Add support for genders in clique.py.\n\nAlso adds gender support for MessageNode\u0027s Translate() function. This\ntouches a lot of files because Translate() and clique\u0027s functions are\ncalled from all over the place, but the only real logic changes are in\nclique.py.\n\nCallers of the modified functions generally just use\ngender.DEFAULT_GENDER for now, so there should be no actual change in\nfunctionality. Eventually android_xml and data_pack types will support\ngenders properly, but other types will continue to only support\n\"genderless\" translations.\n\nBug: 409548912\nChange-Id: Ieaf2452b4609b28bc6103c3c9fc7710d93762115\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6488608\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1452066}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 454dba1e1a8603b9fe7207c33f73520bc892781f\n" }, { "commit": "cb776eac81987650d363882832ca63f1912c1de8", "tree": "07dcad60752acc0279f1b0c2191cac125b4424b6", "parents": [ "771f2cfafb2334f755682646e3f79f9901634a91" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Thu Apr 24 16:30:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 24 16:37:43 2025" }, "message": "[Grit] Add a bit of unit test coverage for gender translations.\n\nBug: 409548912\nChange-Id: Iac7fba33597b49fd5499c53a7a99481df3c17263\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489066\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1451217}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e7c1a7635655e98f4e77c2c251d8ba24569944ee\n" }, { "commit": "771f2cfafb2334f755682646e3f79f9901634a91", "tree": "94214f8b9d610f3f7a6c7ce4ba2dbb83dd215281", "parents": [ "7e3754a4052cc6590aa8d9982513aca0f90387a4" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Wed Apr 16 19:56:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 16 20:00:59 2025" }, "message": "[Grit] Conditionally generate per-gender output files.\n\nCurrently, all 4 of these output files will contain the same translations.\n\nBug: 411157063\nChange-Id: I6ca32dad5993d8bcfcc97cca42bd57486b409c34\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462044\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1447954}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5b0aaba0397915ea53bdc2d1259b4e87f634cccf\n" }, { "commit": "7e3754a4052cc6590aa8d9982513aca0f90387a4", "tree": "79fd0af3ff9ea7794ebd566a2a78f662b20dda5b", "parents": [ "d60268323df8bc4791c7424d5d44195f6ad5e852" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Fri Apr 11 14:31:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 11 14:40:39 2025" }, "message": "Add a tool to parse and dump .xtb files.\n\nMainly useful for debugging xtb parsing.\n\nThis is quite a simple tool - on the one hand, it seems a bit silly to\nadd a new tool just for this. But on the other hand, this functionality\ndoesn\u0027t really seem to fit in well with any of the other existing tools.\n\nBug: 409770185\nChange-Id: If924eecf1a74c6c6023931961517ffe2ea5e72b0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6447457\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1445854}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 39211063579d939e4d6bcdbef89d566e23c81fc7\n" }, { "commit": "d60268323df8bc4791c7424d5d44195f6ad5e852", "tree": "8a56e729f7cf2e26588b82e3cf16dae913b61f84", "parents": [ "02869c55b9634e67cde4b1319b74098a770a38af" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Fri Apr 11 14:30:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 11 14:35:19 2025" }, "message": "Grit: support gendered translations in xtb_reader.py.\n\nNote that this does not actually add full gender support\nto grit, this is just the first piece.\n\nBUG\u003d409770185\n\nChange-Id: Ic2ae068189ba389988dfffdd1c2223671ee9913c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443419\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1445852}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: be12bc09ea7db35b0fea3e080bce7e95869de541\n" }, { "commit": "02869c55b9634e67cde4b1319b74098a770a38af", "tree": "42af4ce274548f1d09e753f069caed2976a575c3", "parents": [ "2db6520e623ed70085840c5f4e2957a819f366e8" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Thu Apr 10 20:26:25 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 10 20:32:02 2025" }, "message": "Cleanup: remove crbug_1001171 logic from grit.py.\n\ncrbug_1001171.py was removed in https://chromium-review.googlesource.com/6217942.\n\nBug: 40097596\nChange-Id: Ice0e482e97b30311a42d4786cc31d84f2ddb0454\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6447709\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1445477}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 54a65cb4ce67d33b41266751d07cd9aa4b81e07e\n" }, { "commit": "2db6520e623ed70085840c5f4e2957a819f366e8", "tree": "ce1d07e45b1427975249cb9367e612d440b6992f", "parents": [ "f3a550513130f39fc260e54168fd8407482f4847" ], "author": { "name": "Glenn Hartmann", "email": "hartmanng@chromium.org", "time": "Tue Mar 18 21:09:17 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 18 21:18:22 2025" }, "message": "Fix the `grit.py unit` command.\n\nLooks like it\u0027s been broken since 2019\n(https://chromium-review.googlesource.com/c/chromium/src/+/1638297).\n\nChange-Id: I0da4014e5f0298f5f37f10d1ed0878219dcc48d6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6368280\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCommit-Queue: Glenn Hartmann \u003chartmanng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1434419}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 58b083b8b68154bc2ef691f129869ec0ef440d73\n" }, { "commit": "f3a550513130f39fc260e54168fd8407482f4847", "tree": "ff8f9e2eb12ac1ecd0cb3c2b206b771e3d1fd577", "parents": [ "baf95d0fcf500d71ee95a5be6499d5ed0e2c4e0b" ], "author": { "name": "Yuta Hijikata", "email": "ythjkt@google.com", "time": "Wed Mar 05 01:04:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 05 01:11:56 2025" }, "message": "Replace usage of is_chromeos_ash with is_chromeos in tools.\n\nThis is part of Lacros sunset. Since Lacros is gone, the two variables\nmean the same thing.\n\nNote that args for generated_script, deploy_lacros was removed in\ncrrev.com/c/5933926.\n\nBug: 373972275\nChange-Id: I840e8b9d188fc4fb8fd5d4c66a1da5449c758dbb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6320699\nCommit-Queue: Yuta Hijikata \u003cythjkt@chromium.org\u003e\nReviewed-by: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1428073}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1321d3763dbc192640d90d42c4d5ca997448b14d\n" }, { "commit": "baf95d0fcf500d71ee95a5be6499d5ed0e2c4e0b", "tree": "468acf98ed31fd2cb17633c3bfcbd82a5c15bd3f", "parents": [ "fe28ff1102e0bc9ea17b43af66b0263cc819ba0d" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Mar 04 20:24:49 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 04 20:31:27 2025" }, "message": "WebUI: Remove JS minification step built into Grit on Android builds.\n\nJS minification happens within build_webui() targets, and does not\nbelong in Grit. It was added there long time ago, before build_webui()\nexisted and before any other minification happened during the build.\n\nRemoving it avoids running the minifier (Terser) on top of already\nminified files, reducing unnecessary work during the build, as well as\ncomplexity when minification needs to be turned off for specific files.\n\nFixed: 340278433\nChange-Id: I7148bba2e542860ffafc5394e393614a6b377918\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158805\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1427910}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eadc4393a867edd65f8c279732e16cc631e30005\n" }, { "commit": "fe28ff1102e0bc9ea17b43af66b0263cc819ba0d", "tree": "b602ae136b77c2a0af3377b123b8593e8ec748f3", "parents": [ "e5a1ac22f9055f1d85ebb0de5285da775b12ca81" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Mar 04 01:46:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 04 01:56:20 2025" }, "message": "Grit: Preserve license headers in built-in minification on Android.\n\nBased on past discussions, license headers should be preserved in\ndistributed JS code, even when minification is present.\n\nThis is done as a precursor step to fully removing Grit\u0027s built-in\nminification, as an illustration that Grit\u0027s built-in minification is no\nlonger necessary since it mostly operates on already minified files\nproduced by other parts of the build leveraging minify_js() from\nui/webui/resources/tools/minify_js.py.\n\nSpecifically, this will help get more accurate results from the\nandroid-binary-size bot, when Grit\u0027s minification is removed in a\nfollow-up CL. The reported size diff is currently inflated because of\nGrit erroneously removing license headers when operating on already\nminified files.\n\nBug: 340278433\nChange-Id: I0f8d75ffa797db58292b04bdefbd86e46bae2932\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318882\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1427505}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 46ec1a0ce4b39c864384a28ca21266d203f44c03\n" }, { "commit": "e5a1ac22f9055f1d85ebb0de5285da775b12ca81", "tree": "2de837b3aeb329c267fbb8cf8c7decbd6fb889ef", "parents": [ "f703a96eac1a80f3c42eeb52d26113bd147b76eb" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Wed Feb 26 17:35:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 26 17:44:01 2025" }, "message": "Remove Lacros support from tools/grit\n\nRemove grit\u0027s chromeos_lacros definition and associated tests.\nLacros is gone, is_lacros_chrome is always false and will be removed.\n\nBug: b:354842935\nChange-Id: I5471d92d6fea14fa9ca461449714b09b511af629\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299477\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1425218}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c102955aaadf6147b4419065adade6b219b1516f\n" }, { "commit": "f703a96eac1a80f3c42eeb52d26113bd147b76eb", "tree": "47c74354cc76f75610726a16b59e40dc406ad014", "parents": [ "0c7646237f7173c963cdfd8001ec62358db1840a" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Wed Feb 05 00:23:24 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 05 00:30:31 2025" }, "message": "Grit: Remove output_all_resource_defines from list of valid attributes.\n\nAll references to this attribute have been removed in previous CLs, both\nfrom public and internal repositories.\n\nFixed: 389466679\nChange-Id: I0a3dac6c8b0a9c696ca1d4038a6020f8cbe75b0b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6188884\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1415903}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 96c98d3ae26486007669c1cd00e4da58c85659b3\n" }, { "commit": "0c7646237f7173c963cdfd8001ec62358db1840a", "tree": "2d49bcd7c04046d2a60610199eadd15464426785", "parents": [ "8cc670ddfb0109e44f6c3b72e727953272cc5ef8" ], "author": { "name": "David Bokan", "email": "bokan@chromium.org", "time": "Sat Feb 01 02:56:31 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 01 03:07:41 2025" }, "message": "Move glic_enabled out of global features.gni\n\nThis can live in chrome/common if we just move the grit define into the\nchrome/features.gni as well.\n\nBug: 378141058\nChange-Id: I4be2523d46a846f7ebb61509e4a90174e8fb1b37\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6217935\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1414510}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6ff9d9769bf22d1798b148a8f05770361da3b020\n" }, { "commit": "8cc670ddfb0109e44f6c3b72e727953272cc5ef8", "tree": "ba7a68357fda9fde8e99459c32f163c97ce2c8ae", "parents": [ "363ab375b6cfe943b5da42de29ede2a1706a5266" ], "author": { "name": "Riley Wong", "email": "rgw@google.com", "time": "Fri Jan 31 00:43:55 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 31 00:50:36 2025" }, "message": "Remove the debugging logic added to help diagnose crbug.com/1001171.\n\nBug 1001171 has been fixed.\n\nBug: 40097596\nChange-Id: I9dc1e408fbdb6945f1523d0bcac50dda5f23dc53\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6217942\nCommit-Queue: Riley Wong \u003crgw@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1413849}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 145e2ed06f9e32a7701dcf312e51068b618cebd8\n" }, { "commit": "363ab375b6cfe943b5da42de29ede2a1706a5266", "tree": "d476659f4ec09523bffc4930ed4f2da4e69f95db", "parents": [ "2621cae09f93191ea0099eaac62d449c64ef5b91" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Jan 28 00:54:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 28 01:03:38 2025" }, "message": "Grit: Improve error message when an invalid attribute is found.\n\nThe error previously did not include the name of the grd file exhibiting\nthe problem making it harder to find and fix.\n\nBefore:\ngrit.exception.UnexpectedAttribute: The attribute was not expected: output_all_resource_defines\n\nAfter:\ngrit.exception.UnexpectedAttribute: An unexpected attribute was encountered: \u0027output_all_resource_defines\u0027 in file \u0027../../chromeos/ash/resources/internal/ash_internal_scaled_resources.grd\u0027\n\nBug: 389466679\nChange-Id: I2ae02321af3d6c2547da832ea944333bfa5bd208\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203264\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1411994}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4546b07f259d413dce2a4da51b195421949dc83d\n" }, { "commit": "2621cae09f93191ea0099eaac62d449c64ef5b91", "tree": "173f3e7f0ef673b375b32344ee71cca14f261b23", "parents": [ "212da8bc037d24cc86e976387998f14406f45b8c" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Jan 21 20:13:42 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 21 20:22:31 2025" }, "message": "Remove refs to Grit\u0027s output_all_resource_defines option, part 10.\n\nIn this part updating files in android_webview/, mojo/,\nremoting/, tools/.\n\nThis option is no longer respected by Grit, as of crrev.com/c/786121\n(~7 years ago), but it is still present in a lot of grd files.\n\nFixed: 389466679\nChange-Id: Iab74957e0798d428c00b8ccdbadd8166e2d8bc6f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172115\nReviewed-by: Bo Liu \u003cboliu@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Gary Kacmarcik \u003cgarykac@chromium.org\u003e\nReviewed-by: Fred Shih \u003cffred@chromium.org\u003e\nReviewed-by: Gary Kacmarcik \u003cgarykac@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1409218}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cf9a94b58ad85432e50915e2639765fc726d5c69\n" }, { "commit": "212da8bc037d24cc86e976387998f14406f45b8c", "tree": "bd64f5bcaca8bf118d0042d658813334f4b57f28", "parents": [ "2ad6cd2665c474ec7aa18a8b0b344156f0231520" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Thu Jan 16 18:47:52 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 16 18:55:05 2025" }, "message": "Cleanup: Remove obsolete tools/grit/grit/grit-todo.xml file.\n\nThis file has never been changed, only moved around along with Grit\nitself since 2008. It is not referred by anything else and seems to hold\nsome custom XML format to track TODOs, all of which have a 2005 date\nattached to them.\n\nSeems fairly safe to delete this mysterious file. Most likely\ncorresponds to an old TODO tracking software (possibly\nhttps://abstractspoon.com/wiki/doku.php).\n\nBug: None\nChange-Id: I5d306f99a572c66a152eb05b9648ae1e1d6acaeb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180137\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1407441}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 645caf119e7216f2821fcbe0b0bbec1c64c81f2f\n" }, { "commit": "2ad6cd2665c474ec7aa18a8b0b344156f0231520", "tree": "fa6c3f8937f303fe66978e865c12520d8c6c426b", "parents": [ "193308558f8870f6ada9917e0702a29ae5ac4ca0" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Wed Jan 15 07:43:46 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 15 07:49:07 2025" }, "message": "WebUI: Add ability to load resources from disk during development.\n\nHigh level approach:\n - Add a new optional \"filepath\" field in webui::ResourcePath struct.\n - Populate it from Grit when a load_webui_from_disk\u003dtrue GN flag\n exists. The value points to a file on disk, relatively to the\n out/\u003cout_folder\u003e.\n - Update WebUIDataSourceImpl to use the \"filepath\" field to read\n requested files directly from disk instead of the pak file if the\n runtime --load-webui-from-disk switch is present.\n\nInstructions:\n 1) Add \u0027load_webui_from_disk\u003dtrue\u0027 in args.gn and build the \u0027chrome\u0027\n target.\n 2) Launch Chrome with --load-webui-from-disk\n 3) Load chrome://resources/js/assert.js in a tab. See contents\n 4) Manually edit\n out/\u003cout_folder\u003e/gen/ui/webui/resources/tsc/js/assert.js in your\n local checkout, or alternatively edit the TS file in your src/\n folder and build //ui/webui/resources/js:build_ts\n 5) Refresh the tab from #3. It should show the latest contents!\n\nBug: 384636724\nChange-Id: I6506c935116ef92027fe52f9b2abe11cdd0a9585\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089262\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Alex Rudenko \u003calexrudenko@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1406544}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ab9780611788cf722c5d043fdee165d9941b114\n" }, { "commit": "193308558f8870f6ada9917e0702a29ae5ac4ca0", "tree": "ff1584b3cd1dd4dfd36619b29fadd7bec283a6db", "parents": [ "237ce4f2b8fec4d328a15fccbc4772d359c9f4ef" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Jan 14 09:29:31 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 14 09:35:51 2025" }, "message": "Remove refs to Grit\u0027s output_all_resource_defines option, part 1.\n\nIn this part updating files that are either owned by everyone or I\nhave ownership.\n\nThis option is no longer respected by Grit, as of crrev.com/c/786121\n(~7 years ago), but it is still present in a lot of grd files.\n\nBug: 389466679\nChange-Id: I50608a355313dcb2adb372b01b1d6cbd9a7aaf12\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6170774\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1405965}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bfad4d43760450e73b1cd50ec96e7f92ecf345fe\n" }, { "commit": "237ce4f2b8fec4d328a15fccbc4772d359c9f4ef", "tree": "e512513798a68f36bbae82561f8606b6b355c970", "parents": [ "dddc8180da1677ea57b990b3de9058ade6b11c4b" ], "author": { "name": "David Bokan", "email": "bokan@chromium.org", "time": "Thu Dec 19 18:47:45 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 19 18:53:55 2024" }, "message": "Reland: Build Glic browser_tests on Linux\n\nThis revealed a number of other parts of the build that avoid compiling\non linux so this CL updates these to use the existing `enable_glic`\nbuild flag.\n\nReland Note:\nRelands https://crrev.com/c/6089193. Diff from PS1 to see changes to\noriginally landed CL.\n\nIssue is that Wayland doesn\u0027t yet have an implementation for\nGlobalShortcutListener which Glic CHECKs for. The fix for that was\nlanded in https://crrev.com/c/6100532\n\nCq-Include-Trybots: luci.chromium.try:linux-wayland-rel\nBug: 378141058\nChange-Id: Ia333c69e7def99ea622fba30f9b87c8d54c7a9af\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094446\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: David Bokan \u003cbokan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1398714}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 97177ce01a8ac81e16821307cc613bc573de2343\n" }, { "commit": "dddc8180da1677ea57b990b3de9058ade6b11c4b", "tree": "5c5b81395ee3515ae70c6497d89f96ab5a8ced80", "parents": [ "bf4cba518ff46f315f5800390ef3b7d6da9eb52b" ], "author": { "name": "David Bokan", "email": "bokan@chromium.org", "time": "Fri Dec 13 18:59:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 13 19:06:50 2024" }, "message": "Revert \"Build Glic browser_tests on Linux\"\n\nThis reverts commit 2a331365b3af170697b8d49d1f647b74fcd592fc.\n\nReason for revert: Tests are broken on Linux Wayland bot\n\nOriginal change\u0027s description:\n\u003e Build Glic browser_tests on Linux\n\u003e\n\u003e This revealed a number of other parts of the build that avoid compiling\n\u003e on linux so this CL updates these to use the existing `enable_glic`\n\u003e build flag.\n\u003e\n\u003e Bug: 378141058\n\u003e Change-Id: Idf87ad8f1fb2df3fb620482d760db17a3424a8e7\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089193\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Commit-Queue: David Bokan \u003cbokan@chromium.org\u003e\n\u003e Reviewed-by: Eshwar Stalin \u003cestalin@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1395995}\n\nBug: 378141058\nChange-Id: Ifdad258abc9529557204e3b24e2980f5e9a07824\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089889\nCommit-Queue: David Bokan \u003cbokan@chromium.org\u003e\nOwners-Override: Mike Wasserman \u003cmsw@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Eshwar Stalin \u003cestalin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1396077}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3c77efeef3ed5c154b59c0cf5fa77b8dc97aedc4\n" }, { "commit": "bf4cba518ff46f315f5800390ef3b7d6da9eb52b", "tree": "ec9fb3b64359b215ba7841653ac2cec0c5bafed6", "parents": [ "e9e27e1204643d6758a4201751793219ede42de1" ], "author": { "name": "David Bokan", "email": "bokan@chromium.org", "time": "Fri Dec 13 16:50:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 13 17:01:20 2024" }, "message": "Build Glic browser_tests on Linux\n\nThis revealed a number of other parts of the build that avoid compiling\non linux so this CL updates these to use the existing `enable_glic`\nbuild flag.\n\nBug: 378141058\nChange-Id: Idf87ad8f1fb2df3fb620482d760db17a3424a8e7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089193\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: David Bokan \u003cbokan@chromium.org\u003e\nReviewed-by: Eshwar Stalin \u003cestalin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1395995}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2a331365b3af170697b8d49d1f647b74fcd592fc\n" }, { "commit": "e9e27e1204643d6758a4201751793219ede42de1", "tree": "5c5b81395ee3515ae70c6497d89f96ab5a8ced80", "parents": [ "3a828ed08d1425e100b58d372ad55ee040ebac2d" ], "author": { "name": "Gauthier Ambard", "email": "gambard@chromium.org", "time": "Fri Nov 15 16:47:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 15 17:06:35 2024" }, "message": "[iOS] Don\u0027t use title case on iOS\n\niOS moved to sentence case for its strings.\nUpdate the tests to make sure they pass with the new strings.\n\nBug: 373823958\nChange-Id: I9b32cd279a022558d40800a5c459da5169145354\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017925\nAuto-Submit: Gauthier Ambard \u003cgambard@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1383662}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 67c0ee09af4d5625c20b91ad391662c94662322b\n" }, { "commit": "3a828ed08d1425e100b58d372ad55ee040ebac2d", "tree": "9d5efbe851e81f136bb8ed5a73a18d62aba2e861", "parents": [ "d62c0f8b8d8fb65194afb3e1acb375eb08b9b827" ], "author": { "name": "Yuzhu Shen", "email": "yzshen@chromium.org", "time": "Wed Nov 13 19:38:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 13 19:45:59 2024" }, "message": "Version page: Don\u0027t show \"Desktop Android: false\" for non-desktop android.\n\nBug: 377542841\nChange-Id: Ic35df8d2bb0535b09d8c5c00c3805593b24ff8ce\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015829\nCommit-Queue: Yuzhu Shen \u003cyzshen@chromium.org\u003e\nReviewed-by: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1382517}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5c0761ae7bc1bafe06de155a15f46749ec991f46\n" }, { "commit": "d62c0f8b8d8fb65194afb3e1acb375eb08b9b827", "tree": "d1bb79e468251ac2a1d522c6eaa14ae092147439", "parents": [ "3cc037c3c24157c9ed83fe8172ccb201239e1ca1" ], "author": { "name": "Rulong Chen（陈汝龙）", "email": "rulong.crl@alibaba-inc.com", "time": "Fri Sep 27 14:45:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 27 14:52:13 2024" }, "message": "Grit: Compress all JSON files by default\n\nChange Grit\u0027s default behavior to gzip-compress all JSON\nfiles, unless a |compress| attribute is explicitly specified,\nsuch as compress\u003d\"brotli\".\n\nout/\u003cout_folder\u003e/resources.pak sizes before/after:\n\nmacOS: 12957301 -\u003e 11383303, -12%\n(The majority of the revenue comes from devtools_resources.pak)\n\nBug: 366055332, 40790578\nChange-Id: I8dcec0e1a8780417d5d5842b43d4f8cfcc69ae85\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5856799\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nReviewed-by: David Jacobo \u003cdjacobo@chromium.org\u003e\nReviewed-by: Jeffrey Young \u003ccowmoo@google.com\u003e\nReviewed-by: Danila Kuzmin \u003cdkuzmin@google.com\u003e\nReviewed-by: Emilia Paz \u003cemiliapaz@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Curtis McMullan \u003ccurtismcmullan@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1361133}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7ecc2935c70b73f8d2dc505c771327567c5450fc\n" }, { "commit": "3cc037c3c24157c9ed83fe8172ccb201239e1ca1", "tree": "d1669f5f01b55a28c8903a8e94bc328016ae541b", "parents": [ "471a968ab017c531c99296fb8e33df6e821f0e0c" ], "author": { "name": "Mickey Burks", "email": "mickeyburks@chromium.org", "time": "Wed Aug 21 17:18:29 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 21 17:33:45 2024" }, "message": "Update WebUI grit resource script to add a fixed size\n\nThis generated array has a fixed size, but because it is `extern` it\nis defined in another compilation unit and the compiler cannot\ndetermine its size until linking. Adding the size inline allows the\ncompiler to determine that the array can be safely used to construct\na `base::span`.\n\nBug: 357559697\nChange-Id: I6b7b602ace123526c711069449a468efc0ec9e1f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5750523\nReviewed-by: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Mickey Burks \u003cmickeyburks@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1344894}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: abae289865f4eba48df0ef98f2fd7b1d9c9fd5e2\n" }, { "commit": "471a968ab017c531c99296fb8e33df6e821f0e0c", "tree": "a39177cfd5ff8320a15bd15a0cef18f8f2199564", "parents": [ "2bc29446f0e9ecc91841d116e7d55a8f872c62a3" ], "author": { "name": "George", "email": "geoada@meta.com", "time": "Tue Jul 30 17:26:19 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 30 17:33:29 2024" }, "message": "Add WebP Mimetype Override to GRIT HTML Inlining\n\nI ran into an issue with this on an older build machine\nI am stuck with that has Python 3.8.6. Since there\u0027s a\nsmiliar override for WebM I added a WebP override I used\nto get past this issue.\n\nChange-Id: Iecd0682717e23dd75e1f7b4e693c92f4f31e54c3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5747065\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1334942}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9c57d0e5ea21244fe8b356c3ecb2e6f162ac4d0\n" }, { "commit": "2bc29446f0e9ecc91841d116e7d55a8f872c62a3", "tree": "88654e1b5f93da327c722a373008958131d2963c", "parents": [ "80bd86bca2ac10d08d2e197952ec94e9b2917638" ], "author": { "name": "Khalid Peer", "email": "khalidpeer@chromium.org", "time": "Tue May 14 23:53:12 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 15 00:00:53 2024" }, "message": "[omnibox] Replace deprecated `assert` with `with` in JS imports.\n\nThe chrome://omnibox UI is currently broken due to an error caused by\nusage of the deprecated `assert` keyword in the JS imports. This CL\nfixes the issue by making use of the recommended `with` keyword as an\nalternative.\n\nIn order to play nice with the current TS toolchain used when building\nChromium, this CL also disables JS minification across all builders for\nthis particular WebUI (since the `terser` minifier hasn\u0027t been updated\nyet to support the new `with` keyword).\n\nBug: 340297713, 340278433, 339686362\nChange-Id: Ifdef7bf33724154d202d9b355e0fb5f2dfbf813b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529040\nReviewed-by: Moe Ahmadi \u003cmahmadi@chromium.org\u003e\nCommit-Queue: Khalid Peer \u003ckhalidpeer@chromium.org\u003e\nReviewed-by: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1300984}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1b8b4c7317d2b30978df3bbb5ca8cd40c1128e95\n" }, { "commit": "80bd86bca2ac10d08d2e197952ec94e9b2917638", "tree": "184678877cefab07dc0ddc4ba3b84df557fdf55d", "parents": [ "f9b36d3af7929352ac5514b8d2812d522cbab081" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue May 14 16:58:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 14 17:16:58 2024" }, "message": "Exclude c/b/r/omnibox from JS minification baked into grit() on Android.\n\nThe minifier blows up when encountering the new-ish \"import\nattributes\" feature, which in turn is blocking chrome://omnibox from\nmoving away from the deprecated and now defunct \"import assertions\"\nfeature.\n\nBug: 340278433,339686362\nChange-Id: I8cddfa44a07ac9b17653290224e02255718e697a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5536522\nReviewed-by: Khalid Peer \u003ckhalidpeer@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1300688}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d7296e3521bc2666a3405ee6f17a645dd57972e8\n" }, { "commit": "f9b36d3af7929352ac5514b8d2812d522cbab081", "tree": "e15bd005f89e39076807378559c3bb8392ad2fd1", "parents": [ "7f373915bb8fb0b48ecf989102dffc90422aa8ad" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Feb 15 18:41:35 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 15 18:56:54 2024" }, "message": "Improve an error message in GRIT\n\nWhen the resource IDs is missing an entry, the GenerateResourceUsages()\nfunction in GRIT will complain and raise a ValueError. Put more details\ninto the error message, to make it clearer what to do. Fix some outdated\ndocumentation for GenerateResourceUsages() along the way.\n\nChange-Id: I64a7963af78580d0108423922ea35169258d4465\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5297549\nReviewed-by: Andy Phan \u003candyphan@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1261203}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 800a7031efd0f16b97ef4556990b508e968a386f\n" }, { "commit": "7f373915bb8fb0b48ecf989102dffc90422aa8ad", "tree": "d13a2c3840e03e813503eb1af99483cf2b8a1b90", "parents": [ "e67d1064e1e58ab5cb37af4a545da7a984f7dd65" ], "author": { "name": "Sergei Poletaev", "email": "spylogsster@gmail.com", "time": "Wed Nov 29 15:48:32 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 29 15:55:14 2023" }, "message": "Remove chromium hardcoded paths to logos\n\nThere is branding_path_component parameter which is not added to some\nresources, added ${branding_path_component} to missed grd resources.\n\nBug: 1505279\nChange-Id: Ibd239ee8257da217002bd0060616641224235f0b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060133\nReviewed-by: Mitsuru Oshima \u003coshima@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1230662}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2be83283f3debb539ac3062e490ff40560142e87\n" }, { "commit": "e67d1064e1e58ab5cb37af4a545da7a984f7dd65", "tree": "f75274dc32a27ad21ad6731e3450565ebe76a9cb", "parents": [ "7010e4a69d0a1caca6913b64767766036b6678bd" ], "author": { "name": "Fredrik Söderquist", "email": "fs@opera.com", "time": "Tue Nov 14 14:43:38 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 14 14:55:57 2023" }, "message": "[grit] Use image-set() instead of -webkit-image-set()\n\nimage-set() has shipped since M113, and -webkit-image-set() is a subset\nof the unprefixed function. Update the image set handling to produce the\nunprefixed version. Allow the prefixed version as input still.\n\nBug: 403361\nChange-Id: I0346eba61821239af45c04fa9aa8e9fb33aadcd6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5029660\nCommit-Queue: Fredrik Söderquist \u003cfs@opera.com\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1224267}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ee9bffeaf441e5e94e816cb5929c00db46ec5169\n" }, { "commit": "7010e4a69d0a1caca6913b64767766036b6678bd", "tree": "2a5b3025a7c1cd04df0ff079217b950c5899eb02", "parents": [ "e4c894eeb4aaaca70322820ed4b59c4f98bd01a6" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Thu Oct 19 00:04:12 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 19 00:10:55 2023" }, "message": "[Reland] Grit: Add a way to inline generated JS files.\n\nReland notes: Original CL was speculatively reverted and ended up\nunrelated to http://crbug.com/1493571. As part of relanding, made some\nadditional changes that are also required to unblock the JS module\nmigration mentioned below, and were discovered after the original CL\nlanded.\n\nThis is necessary to unblock migrating the following UIs:\n - components/security_interstitials/core/browser/resources/\n - components/neterror/resources/\n\nto JS modules. Those UIs rely on Grit\u0027s obsolete flattenhtml\u003dtrue for\ninlining all involved HTML/CSS/JS files to a single HTML file. The new\nfunctionality allows using the more appropriate and canonical\nbundle_js() GN rule to generate JS bundles, and have Grit be able to\ninline the generated JS file to the final HTML file.\n\nDone by allowing a `%ROOT_GEN_DIR%` placeholder to appear in a path,\nlike `\u003cscript src\u003d\"%ROOT_GEN_DIR%/path/to/generated/folder/foo.js\"\u003e`,\nwhich is then respected when inlining such file.\n\nBug: 1347008\nChange-Id: I12cc33562f741493e7f38aa559ec0f7e61176912\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4953414\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1211852}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6991952462089f4b6240cd38a48fe863f7bcb77f\n" }, { "commit": "e4c894eeb4aaaca70322820ed4b59c4f98bd01a6", "tree": "962d505c0fcc4896be2d1d892e3ae5221ed8560f", "parents": [ "80abae1999f8c181554a1cb8adc3622c9fab7441" ], "author": { "name": "Ming-Ying Chung", "email": "mych@chromium.org", "time": "Wed Oct 18 03:47:26 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 18 04:02:24 2023" }, "message": "Revert \"Grit: Add a way to inline generated JS files.\"\n\nThis reverts commit 6c28b1a038c495b9c41bcba310e474e9f98cf286.\n\nReason for revert: May cause https://crbug.com/1493571 as this is the earliest change with that broken builder\n\nOriginal change\u0027s description:\n\u003e Grit: Add a way to inline generated JS files.\n\u003e\n\u003e This is necessary to unblock migrating the following UIs:\n\u003e - components/security_interstitials/core/browser/resources/\n\u003e - components/neterror/resources/\n\u003e\n\u003e to JS modules. Those UIs rely on Grit\u0027s obsolete flattenhtml\u003dtrue for\n\u003e inlining all involved HTML/CSS/JS files to a single HTML file. The new\n\u003e functionality allows using the more appropriate and canonical\n\u003e bundle_js() GN rule to generate JS bundles, and have Grit be able to\n\u003e inline the generated JS file to the final HTML file.\n\u003e\n\u003e Done by allowing a `%ROOT_GEN_DIR%` placeholder to appear in a path,\n\u003e like `\u003cscript src\u003d\"%ROOT_GEN_DIR%/path/to/generated/folder/foo.js\"\u003e`,\n\u003e which is then respected when inlining such file.\n\u003e\n\u003e Bug: 1347008\n\u003e Change-Id: I7a69c475ae7aee8a4adfd4df02caba3f0d11d6be\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4944592\n\u003e Commit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\n\u003e Reviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1211176}\n\nBug: 1347008,1493571\nChange-Id: I76690684dbc8fab4a92316f686291f3f690a94a3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4951950\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Ming-Ying Chung \u003cmych@chromium.org\u003e\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nCommit-Queue: Ming-Ying Chung \u003cmych@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1211293}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: baa32b2789efaa05a5b00242c359a9955110a96e\n" }, { "commit": "80abae1999f8c181554a1cb8adc3622c9fab7441", "tree": "fa6d5e499d5e4d4b1ff7ba549a05d06a43684e14", "parents": [ "0e283377686e4d6bd3ad3351b59118b71c8c9378" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Oct 17 23:14:06 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 17 23:21:18 2023" }, "message": "Grit: Add a way to inline generated JS files.\n\nThis is necessary to unblock migrating the following UIs:\n - components/security_interstitials/core/browser/resources/\n - components/neterror/resources/\n\nto JS modules. Those UIs rely on Grit\u0027s obsolete flattenhtml\u003dtrue for\ninlining all involved HTML/CSS/JS files to a single HTML file. The new\nfunctionality allows using the more appropriate and canonical\nbundle_js() GN rule to generate JS bundles, and have Grit be able to\ninline the generated JS file to the final HTML file.\n\nDone by allowing a `%ROOT_GEN_DIR%` placeholder to appear in a path,\nlike `\u003cscript src\u003d\"%ROOT_GEN_DIR%/path/to/generated/folder/foo.js\"\u003e`,\nwhich is then respected when inlining such file.\n\nBug: 1347008\nChange-Id: I7a69c475ae7aee8a4adfd4df02caba3f0d11d6be\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4944592\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1211176}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6c28b1a038c495b9c41bcba310e474e9f98cf286\n" }, { "commit": "0e283377686e4d6bd3ad3351b59118b71c8c9378", "tree": "962d505c0fcc4896be2d1d892e3ae5221ed8560f", "parents": [ "d3ed60e87b6cd82e564c1bb22df055247e4586e7" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Oct 02 21:17:18 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 02 21:29:45 2023" }, "message": "Enable wexit_time_destructors config for grit resources\n\nEnsure resources generated by grit do not accidentally add exit time\ndestructors going forward.\n\nBug: 101600\nChange-Id: I34dfb02ea76bc3c0d447a95827b87243cd70e82e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4906017\nReviewed-by: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1204267}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5979c6f81a70487af603d6eddfad92b79e1bde08\n" }, { "commit": "d3ed60e87b6cd82e564c1bb22df055247e4586e7", "tree": "bf33bb24a9e602ce3248ad0172b9e94c337e2db5", "parents": [ "272cfb4e006be5f71eb9ff6eb1f72e716823d79e" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Fri Aug 18 15:14:34 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 18 15:19:57 2023" }, "message": "Remove invalid size check from pak_util.py\n\nThere are some small files on desktop that do actually just compress\ndown to their size - 4. E.g. the error is triggering when being run on\nresources.pak.\n\nBug: None\nChange-Id: I02b36bae1f17a309a5d22e19e8383d8fcbf37412\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4768496\nCommit-Queue: Sam Maier \u003csmaier@chromium.org\u003e\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1185203}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1bc05a16fa3381c5b839927709fad06080d3d8c0\n" }, { "commit": "272cfb4e006be5f71eb9ff6eb1f72e716823d79e", "tree": "2ff53ef7020a3a1380134f2d6c4aea6c8d0b613b", "parents": [ "7a19b002972a7d68c0275ea229afd7688732b081" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Fri Jun 09 14:58:36 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 09 15:06:10 2023" }, "message": "[GRIT] Fix gzip_string.GzipString() comment.\n\nThis is a follow-up to crrev.com/c/4582853. Also update imports.\n\nBug: 1449810\nChange-Id: I717912caf9e0a9ea434adf72929caaad8cd8ea8c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584090\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1155526}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2f76730107494e549be69a5e6bdce5a480e56837\n" }, { "commit": "7a19b002972a7d68c0275ea229afd7688732b081", "tree": "7eeb7caf2095cd7191a64f14a867f3454f060128", "parents": [ "0f89c62689327be54f95edd945c0f6d5836d579b" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Fri Jun 02 14:38:42 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 02 14:45:03 2023" }, "message": "Stop using system \"gzip\" in grit\n\nThe system version can differ between machines, as is currently the case\nfor android-binary-size trybot.\n\nGiven that most entries rarely change between releases, using\n--rsyncable is of dubious value, so just always use Python\u0027s gzip\nimplementation.\n\nBug: 1449810\nChange-Id: If87c4ef10c12a91529412259d739fe65ef27860d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582853\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1152516}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0d40befb923b4be2e53523153bff9b8634b2e3f1\n" }, { "commit": "0f89c62689327be54f95edd945c0f6d5836d579b", "tree": "6242ce98100c56c6a757012a307e3abee4df3fb9", "parents": [ "8d6de4c426647039de657504541dae55f6d6a808" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Thu Jun 01 21:38:30 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 01 21:46:29 2023" }, "message": "tools: remove `USE_PYTHON3 \u003d True` from PRESUBMIT.py\n\npresubmit now uses python3 only.\n\nThis is generated by\n$ rg -l \u0027^USE_PYTHON3 \u003d True\u0027 | \\\n xargs sed -z -i \"s/\\n*USE_PYTHON3 \u003d True\\n*/\\n\\n\\n/\"\nwith some more modifications.\n\nThis also removes run_on_python2, run_on_python3, and skip_shebang_check\nargs.\n\nBug: 1207012\nChange-Id: I43ac77120dc2456bc065a41750f1f5ddfd88d9e5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576841\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1152146}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e108f10dfc017ddc158a453b2aa44a5fb7a18674\n" }, { "commit": "8d6de4c426647039de657504541dae55f6d6a808", "tree": "c4a987b6b54d3b26f627e7bf6fc53021da705d8c", "parents": [ "808bcb2661cbab21d252fd090b6e5632c0c0adde" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Tue May 23 19:18:36 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 23 19:26:15 2023" }, "message": "Reserve more space for startup-critical resource IDs.\n\nWhen regenerating the startup resource ID list I found it greatly\nexceeded 400 items, resulting in ID conflicts. Bump the reservation from\n400 to 800 to give sufficient room.\n\nThis also fixes a couple bugs in the scripts -- a typo that led to a\ncrash and a missing inclusion of a new generated .h suffix.\n\nBug: none\nChange-Id: I34624cd0ed29593b8dba764243aea1b3cbce3ed8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4555881\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Robert Flack \u003cflackr@chromium.org\u003e\nReviewed-by: Robert Flack \u003cflackr@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1148093}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: da12af818e4458d9ae552b6a2650d82568a2115f\n" }, { "commit": "808bcb2661cbab21d252fd090b6e5632c0c0adde", "tree": "eddbe665eb29a2d12ccc4a2bc0df8a94e631f3fc", "parents": [ "eb584f361529b9f518bf9916ab3f172a9df3a769" ], "author": { "name": "Alexander Hendrich", "email": "hendrich@chromium.org", "time": "Mon Apr 24 15:57:20 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 24 16:05:55 2023" }, "message": "Update \"Chrome OS\" -\u003e \"ChromeOS\" in policy descriptions\n\nThe naming was rebranded last year and not updated in all locations yet.\nThis particular string is used for the `$2` placeholders in policy\ndescriptions.\n\nBug: b:278669763\nChange-Id: I1297168aa922bf8399ed2352a1ea82d04f019162\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4440366\nReviewed-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nAuto-Submit: Alexander Hendrich \u003chendrich@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Alexander Hendrich \u003chendrich@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1134629}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 586433f56cdfe090ff8e546d2f8042004bbb5e04\n" }, { "commit": "eb584f361529b9f518bf9916ab3f172a9df3a769", "tree": "7e2b77f01ae4ac7cd9b5ca15f340899cf3b4ed43", "parents": [ "971ad072154420e72b0b2184840640374057f514" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Tue Feb 21 19:51:57 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 21 19:59:12 2023" }, "message": "WebUI: Restrict preprocess_if_expr inputs with enable_removal_comments.\n\nOnly .js and .ts files should be accepted when\nenable_removal_comments\u003dtrue. Adding an assertion to ensure the tool\nis not accidentally misused.\n\nBug: 1416356\nChange-Id: I55374f3ef442f9f1d4a255b0308e054834928c2b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4250605\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1107894}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f45184c40e0d7b6201d0939b201a8f34179b72d2\n" }, { "commit": "971ad072154420e72b0b2184840640374057f514", "tree": "59e97954d4576298319ae5a672a4715e42e9fcc5", "parents": [ "42c066b283c27c1cd2857c738ca6da44c3715de8" ], "author": { "name": "Tibor Goldschwendt", "email": "tiborg@chromium.org", "time": "Wed Feb 15 18:39:25 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 15 18:48:21 2023" }, "message": "Add tiborg@ to //tools/grit/OWNERS\n\nChange-Id: I46f34f6e74f2aad45283367cd4ad844fa5f8c9b6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4256605\nAuto-Submit: Tibor Goldschwendt \u003ctiborg@chromium.org\u003e\nCommit-Queue: Tibor Goldschwendt \u003ctiborg@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1105757}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 06ebf67da801ecaefd192b46bac0ccd05223cf38\n" }, { "commit": "42c066b283c27c1cd2857c738ca6da44c3715de8", "tree": "ae6f6cbcf4217a7dfd90761c834dcd23afb37dc7", "parents": [ "34ad7ad30e56f0626c0d351e3417ba89d24fe331" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Wed Feb 08 21:25:24 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 08 21:34:30 2023" }, "message": "Grit: Rename minify_with_uglify.py since uglify is not used anymore.\n\nRenaming to minify_js.py instead, which matches similar Python script\nfor CSS in the same folder (minimize_css.py).\n\nBug: None\nChange-Id: I60a54a3358d5eb414cf2d150a356211a3dfb639a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4232868\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1102883}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 17e6cd358eba510f10f9c201440bb085ee5a159d\n" }, { "commit": "34ad7ad30e56f0626c0d351e3417ba89d24fe331", "tree": "1104a708a5b514ceabaec93f1f3a965ddaea17e3", "parents": [ "2227340ce2c7abf16c14c72cd41d5cfe847b6dd8" ], "author": { "name": "Thiago Perrotta", "email": "tperrotta@chromium.org", "time": "Thu Jan 19 17:03:31 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 19 17:09:55 2023" }, "message": "Rename branding Chrome for Testing GN args, GRIT vars and C++ buildflags\n\nGN variables (build/config/chrome_build.gni):\n\n- Brand: use_internal_chrome_for_testing_icons -\u003e\n is_chrome_for_testing_branded\n\nC++ buildflags (chrome/browser/chrome_for_testing/BUILD.gn):\n\n- Brand: USE_INTERNAL_CHROME_FOR_TESTING_ICONS -\u003e\n GOOGLE_CHROME_FOR_TESTING_BRANDING\n\nDesign document: https://goo.gle/chrome-for-testing?disco\u003dAAAAi75kgLI\n\nSplit from: https://crrev.com/c/4027840\n\nBug: 1336611\nChange-Id: Icafed8c74ca5231dd6f5e5194fbf3f33a334d1c0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177631\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nReviewed-by: Alex Rudenko \u003calexrudenko@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1094510}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 036b34807bfa2ac700559150cce2b8a474064174\n" }, { "commit": "2227340ce2c7abf16c14c72cd41d5cfe847b6dd8", "tree": "f0f59555001a3476a74a7745db3447071a424718", "parents": [ "f90c17e13cb5d3e1de34ef50d738dcc5c1c9c801" ], "author": { "name": "Thiago Perrotta", "email": "tperrotta@chromium.org", "time": "Wed Jan 18 13:09:17 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 18 13:14:51 2023" }, "message": "Rename feature Chrome for Testing GN args, GRIT vars and C++ buildflags\n\nGN variables (build/config/chrome_build.gni):\n\n- Feature: is_chrome_for_testing_branded -\u003e\n is_chrome_for_testing\n\nC++ buildflags (chrome/browser/chrome_for_testing/BUILD.gn):\n\n- Feature: GOOGLE_CHROME_FOR_TESTING_BRANDING -\u003e\n CHROME_FOR_TESTING\n\nDesign document: https://goo.gle/chrome-for-testing?disco\u003dAAAAi75kgLI\n\nSplit from: http://crrev.com/c/4027840\n\nBug: 1336611\nChange-Id: I65f5cc53bec18cdbcd534a82ea0084f777955397\nCq-Include-Trybots: luci.chromium.try:linux-rel-cft,mac-rel-cft,win-rel-cft\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4172729\nAuto-Submit: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Alex Rudenko \u003calexrudenko@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1093822}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f3fe5fcc36a7e76ba59b040a9cd8ea60a27b6c89\n" }, { "commit": "f90c17e13cb5d3e1de34ef50d738dcc5c1c9c801", "tree": "150033d0245028b4dd9765e21f88c367dd203b43", "parents": [ "32a1ad837306ac90de3e24ca393005d7516f4eeb" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Wed Jan 18 02:45:22 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 18 02:53:18 2023" }, "message": "grit: remove dependency to six\n\nBug: 1406153\nChange-Id: I2cf74b2885b640c9639971d509038e08c2c5d157\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4173416\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1093706}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8dca1dabe7759924d853fb63cd138768fc61de47\n" }, { "commit": "32a1ad837306ac90de3e24ca393005d7516f4eeb", "tree": "513a64f84fa2cfd7c511fee52c8ad9193a58b902", "parents": [ "7806f00036a0efe3e85e216ea20fccabc7a4985a" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Tue Jan 17 15:45:53 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 17 15:51:05 2023" }, "message": "grit: apply pyupgrade\n\nWe use python3 only for build now.\n\nThis is made via\n$ git ls-files tools/grit | grep py$ | \\\n xargs pyupgrade --keep-percent-format\n\nI\u0027ll remove dependency to six in grit completely in later CL as\npyupgrade doesn\u0027t handle some cases.\n\nBug: 1406153\nChange-Id: Ic2baeaf89eeee9c23c3d6d34f3fa66a89b6847c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4167107\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1093336}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4112612ff4dc1aeb8114f3d3f3005b9ebbc866ad\n" }, { "commit": "7806f00036a0efe3e85e216ea20fccabc7a4985a", "tree": "ff1b76d97b8ab63f0f56a9d727ee14bc06fffe68", "parents": [ "d0231692ff8bcb94d4a32a5af46dae8ba35d0175" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Tue Jan 17 01:16:33 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 17 01:21:19 2023" }, "message": "grit: drop python2 compatibility\n\nWe use python3 only for build now.\n\nBug: 1406153\nChange-Id: I7a06b7976bb7ffe4d045f7f10367a18ecafc2808\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4170036\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1093176}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b3abd7e4c9467415da3a5e13d9500d2ab3abc2ec\n" }, { "commit": "d0231692ff8bcb94d4a32a5af46dae8ba35d0175", "tree": "eb3aae2e6369633f43babefb2e0237e1fb7e2b3a", "parents": [ "196aa4862969ddb8391969e3d483909c92d56dae" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Thu Dec 22 14:49:07 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 22 14:54:25 2022" }, "message": "Remove dependency from grit() -\u003e //base\n\nAFAICT, generated files from grit do not use base. I suspect they used\nto but now that newer stdlib things are allowed, it no longer does.\n\nRemoving this dep is beneficial on Android, where java targets tend to\ndepend on grit source_set() targets rather than the underlying grit.py\naction which actually produces the files they care about.\n\nThis also changes java_strings_grd_prebuilt() to depend directly on the\nunderlying grit.py action, since that\u0027s an easy spot to change.\n\nBug: 1402705\nChange-Id: Iaec6bc6978906f4c0d6ee85e0423f362fd14f404\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4116756\nReviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1086339}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e822702d43015a203f64e3469dbbc02f396ec676\n" }, { "commit": "196aa4862969ddb8391969e3d483909c92d56dae", "tree": "b2a47a0db565ed63b725afe43ccc25c137fb56b1", "parents": [ "a205be24a115fea872d4b050aa943768588daf2b" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Fri Dec 16 18:22:16 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 16 18:29:39 2022" }, "message": "Reland \"Grit: Fail if a generated .grd contains more entries than it reserved\"\n\nThis reverts commit 97f4ee407b2de03dfbf0cf81fe31c3af4a48ed6b.\n\nReason for reland: Increased signin resource count\n\nOriginal change\u0027s description:\n\u003e Revert \"Grit: Fail if a generated .grd contains more entries than it reserved\"\n\u003e\n\u003e This reverts commit 7e82ffb4cbfdfa749e2ff42ea160deef0d87e0a4.\n\u003e\n\u003e Reason for revert: Closed tree\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Grit: Fail if a generated .grd contains more entries than it reserved\n\u003e \u003e\n\u003e \u003e Builds already failed during repack steps when resource IDs collided,\n\u003e \u003e but failing earlier will make it clear which file is at fault.\n\u003e \u003e\n\u003e \u003e Bug: 979886\n\u003e \u003e Change-Id: If5fd6154753d3c5e7e2a09444c523118c103625d\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108076\n\u003e \u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e Reviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1084355}\n\u003e\n\u003e Bug: 979886\n\u003e Change-Id: I258840a1a238155c472eab838bbf341045d45d40\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113938\n\u003e Reviewed-by: Renato Silva \u003crrsilva@google.com\u003e\n\u003e Commit-Queue: Leonard Grey \u003clgrey@chromium.org\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Owners-Override: Leonard Grey \u003clgrey@chromium.org\u003e\n\u003e Reviewed-by: Christian Xu \u003cchristianxu@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1084363}\n\nBug: 979886\nChange-Id: If3e0372366a82e680656c54dbf5962efa3de2598\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114205\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Leonard Grey \u003clgrey@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1084412}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 54b069968dc93f44438695405366e9c720316cd7\n" }, { "commit": "a205be24a115fea872d4b050aa943768588daf2b", "tree": "113233dee8e146adb823baf2b733a47cf9c8bbc1", "parents": [ "0e41de21ccaa61418c483ccfd1f1fea1b39cae13" ], "author": { "name": "Leonard Grey", "email": "lgrey@chromium.org", "time": "Fri Dec 16 17:08:48 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 16 17:17:22 2022" }, "message": "Revert \"Grit: Fail if a generated .grd contains more entries than it reserved\"\n\nThis reverts commit 7e82ffb4cbfdfa749e2ff42ea160deef0d87e0a4.\n\nReason for revert: Closed tree\n\nOriginal change\u0027s description:\n\u003e Grit: Fail if a generated .grd contains more entries than it reserved\n\u003e\n\u003e Builds already failed during repack steps when resource IDs collided,\n\u003e but failing earlier will make it clear which file is at fault.\n\u003e\n\u003e Bug: 979886\n\u003e Change-Id: If5fd6154753d3c5e7e2a09444c523118c103625d\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108076\n\u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Reviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1084355}\n\nBug: 979886\nChange-Id: I258840a1a238155c472eab838bbf341045d45d40\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113938\nReviewed-by: Renato Silva \u003crrsilva@google.com\u003e\nCommit-Queue: Leonard Grey \u003clgrey@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Leonard Grey \u003clgrey@chromium.org\u003e\nReviewed-by: Christian Xu \u003cchristianxu@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1084363}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 97f4ee407b2de03dfbf0cf81fe31c3af4a48ed6b\n" }, { "commit": "0e41de21ccaa61418c483ccfd1f1fea1b39cae13", "tree": "b2a47a0db565ed63b725afe43ccc25c137fb56b1", "parents": [ "8612bf4d6257e85a6ef56fdf11b76f1ebcb68142" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Fri Dec 16 16:42:58 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 16 16:50:43 2022" }, "message": "Grit: Fail if a generated .grd contains more entries than it reserved\n\nBuilds already failed during repack steps when resource IDs collided,\nbut failing earlier will make it clear which file is at fault.\n\nBug: 979886\nChange-Id: If5fd6154753d3c5e7e2a09444c523118c103625d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108076\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1084355}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7e82ffb4cbfdfa749e2ff42ea160deef0d87e0a4\n" }, { "commit": "8612bf4d6257e85a6ef56fdf11b76f1ebcb68142", "tree": "113233dee8e146adb823baf2b733a47cf9c8bbc1", "parents": [ "d21871c709612d6e9d4f7787f860721576d1d796" ], "author": { "name": "Thiago Perrotta", "email": "tperrotta@chromium.org", "time": "Tue Nov 15 20:01:35 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 15 20:07:28 2022" }, "message": "Introduce a GN boolean to control whether to use internal icons for Chrome for Testing\n\nIf set to true, use Google-internal CfT icons, otherwise fall back to\nstock Chromium icons.\n\nThe purpose of this variable is to make it possible to perform a CfT\nbuild with a pure Chromium checkout.\n\nFollow-up of the following CLs:\n- https://chromium-review.googlesource.com/c/chromium/src/+/3887411\n- https://chromium-review.googlesource.com/c/chromium/src/+/3886826\n\nDesign document: https://goo.gle/chrome-for-testing#bookmark\u003did.ykxy948susai\n\nBug: 1336611\nChange-Id: Ib20113135675f41046fe6d26bb1957ee1e4fbf98\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4009199\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nCommit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nAuto-Submit: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1071779}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fe3d84c614ce40a118984ef39c31410cd6be1169\n" }, { "commit": "d21871c709612d6e9d4f7787f860721576d1d796", "tree": "d251ab59b89b6a1bd33659c8aff826317c7805e3", "parents": [ "bf870df94acd68b0baf2ca3dfde024f6e641e2ec" ], "author": { "name": "Yann Dago", "email": "ydago@chromium.org", "time": "Thu Oct 27 17:56:49 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 27 18:03:43 2022" }, "message": "Fix mismatched placeholders in description of ChromeRootStoreEnabled\n\nOne of the placeholders had a line return while the others did not.\nThis caused failures in the translation pipeline.\n\nBug: 1294298\nChange-Id: I412afd810c7892479000adef8a3a81c839d3ae5b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3984647\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Yann Dago \u003cydago@chromium.org\u003e\nCommit-Queue: Yann Dago \u003cydago@chromium.org\u003e\nReviewed-by: Jana Grill \u003cjanagrill@google.com\u003e\nReviewed-by: Roman Sorokin \u003crsorokin@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1064427}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 80f3df91bd3316f6e0d02e727dd0e2eafda562ab\n" }, { "commit": "bf870df94acd68b0baf2ca3dfde024f6e641e2ec", "tree": "6eb1bea9bf6a7fe85f87b51aa180f725d3639d98", "parents": [ "abb48033debca6ba2d4a0c57c29dc4550a029b20" ], "author": { "name": "Yann Dago", "email": "ydago@chromium.org", "time": "Fri Oct 21 00:16:05 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 21 00:22:19 2022" }, "message": "Use policy_templates.py to generate documentation\n\nUpdate the IDD_POLICY_SOURCE_FILE to target policy_templates.py instead\nof ${root_gen_dir}/chrome/app/policy/policy_templates.json\nin policy_templates.build.grd.\n\nThis should fix the build failure cause by the relative path in\npolicy_templates.build.grd\n\nBug: 1376893, 1294298\nChange-Id: I50a9e58604461cc5285255c15af8281657f3d015\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3968899\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Yann Dago \u003cydago@chromium.org\u003e\nReviewed-by: Owen Min \u003czmin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1061909}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5dcf9f4dc9618477c8a4ae78a668803c6aa0c499\n" }, { "commit": "abb48033debca6ba2d4a0c57c29dc4550a029b20", "tree": "0f0e474d4434abc0748988cabac6c52e5016ca44", "parents": [ "cf6437df0a447cf3963844a052e915511a25ca9f" ], "author": { "name": "Yann Dago", "email": "ydago@chromium.org", "time": "Wed Oct 19 15:03:43 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 19 15:10:59 2022" }, "message": "Use a generated policy_templates.json to generate documentation\n\nInstead of using a static policy_templates.json, we use a generated\none to generate the policy documentation when building the target\n`policy_templates`. This is done by updating IDD_POLICY_SOURCE_FILE\nto target ${root_gen_dir}/chrome/app/policy/policy_templates.json in\npolicy_templates.build.grd.\n\nThis new grd file will be used by Chrome to generate the policies\ndocumentation.\n\nThe policy_templates.grd will still point to policy_templates.json,\nbut this file will have to be generated using policy_templates.py\nin the appropriate pipeline.\n\nIt is necessary to use two different grd files since we cannot have\ngenerated files in the chromium codebase, and the translation\npipeline requires static files and does not have access to\n${root_gen_dir}.\n\nThis is a part of the road to replacing the policy_templates.json file\nby smaller files. Those smaller files will be used to generate a\npolicy_templates.json which will be used by all consumers of the\nold policy_templates.json so that they are not affected by changes to\nthe format in which policies are defined.\n\nBug: 1294298\nChange-Id: I7df04e9c2ea63d0e49e3a062a73fdfde7c5dc3c3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3932974\nReviewed-by: Owen Min \u003czmin@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Yann Dago \u003cydago@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1061028}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 53df1944d24a55d2990585d3e6730f79fcb7b825\n" }, { "commit": "cf6437df0a447cf3963844a052e915511a25ca9f", "tree": "040fca2e1399a7bd9fa75bdde0ad6c66604d8bde", "parents": [ "891e1cd3324eb97273b2f2586d6beeaaea7a6614" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Thu Sep 15 20:11:09 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 15 20:18:29 2022" }, "message": "Update copyright headers in testing/, tools/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c95.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: I3a8a7b150e7bd64690534727150646081df50439\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900697\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1047644}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dfd88085261b662a5c0a1abea1a3b120b08e8e48\n" }, { "commit": "891e1cd3324eb97273b2f2586d6beeaaea7a6614", "tree": "295a628d214a31cdad1a5d605ff5f1b3840866d7", "parents": [ "d9853328b0346c93e9c8c013ecb1e598899fa33d" ], "author": { "name": "Thiago Perrotta", "email": "tperrotta@chromium.org", "time": "Tue Sep 13 09:57:48 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 10:09:17 2022" }, "message": "Reland \"Use Chrome for Testing icon assets in binary\"\n\nThis is a reland of commit 1f2b443c0e9a252028e22807f86d5b7d488e5a26\n\nOriginal change\u0027s description:\n\u003e Use Chrome for Testing icon assets in binary\n\u003e\n\u003e For context, see https://goo.gle/chrome-for-testing\n\u003e\n\u003e Preview: https://bugs.chromium.org/p/chromium/issues/detail?id\u003d1336611#c31\n\u003e\n\u003e Bug: 1336611\n\u003e Change-Id: I4cc5d6d6aa87cb045478bab25343552e5bd73163\n\u003e Tested: `gn gen out/Default \u0026\u0026 gn args out/Default --args\u003d\"is_chrome_for_testing_branded\u003dtrue\" \u0026\u0026 autoninja -C out/Default`\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866275\n\u003e Reviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\n\u003e Reviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\n\u003e Reviewed-by: Alex Rudenko \u003calexrudenko@chromium.org\u003e\n\u003e Commit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1044027}\n\nBug: 1336611\nChange-Id: I839b1172faf418858530c896da688d3fa64363a4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3887411\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nAuto-Submit: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1046288}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f5efd5f9168766c76b1c003047bac95a274404be\n" }, { "commit": "d9853328b0346c93e9c8c013ecb1e598899fa33d", "tree": "480878bf4a4bab9e3c262f0f1f88d635b7e10df3", "parents": [ "c7630afcd461c4204db4ae35157911fc6cc46698" ], "author": { "name": "Yuxin Hu", "email": "yuxinhu@google.com", "time": "Fri Sep 09 15:46:13 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 09 15:55:52 2022" }, "message": "Revert \"Use Chrome for Testing icon assets in binary\"\n\nThis reverts commit 1f2b443c0e9a252028e22807f86d5b7d488e5a26.\n\nReason for revert: This change breaks the ANGLE build: https://crrev.com/c/3881189\n\nOriginal change\u0027s description:\n\u003e Use Chrome for Testing icon assets in binary\n\u003e\n\u003e For context, see https://goo.gle/chrome-for-testing\n\u003e\n\u003e Preview: https://bugs.chromium.org/p/chromium/issues/detail?id\u003d1336611#c31\n\u003e\n\u003e Bug: 1336611\n\u003e Change-Id: I4cc5d6d6aa87cb045478bab25343552e5bd73163\n\u003e Tested: `gn gen out/Default \u0026\u0026 gn args out/Default --args\u003d\"is_chrome_for_testing_branded\u003dtrue\" \u0026\u0026 autoninja -C out/Default`\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866275\n\u003e Reviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\n\u003e Reviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\n\u003e Reviewed-by: Alex Rudenko \u003calexrudenko@chromium.org\u003e\n\u003e Commit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1044027}\n\nBug: 1336611\nChange-Id: I261e977fd5b06dbd0975db449c1e6b96d98013b0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3885577\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nReviewed-by: Jamie Madill \u003cjmadill@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1045129}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 21a46ee093a27a7851447491c0ab2221b83455a8\n" }, { "commit": "c7630afcd461c4204db4ae35157911fc6cc46698", "tree": "40668be78d7186cf66cd74386901dbc6c347416d", "parents": [ "821d13663040ba027d96ab201449c9948f7a232c" ], "author": { "name": "Thiago Perrotta", "email": "tperrotta@chromium.org", "time": "Wed Sep 07 16:48:42 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 07 17:00:56 2022" }, "message": "Use Chrome for Testing icon assets in binary\n\nFor context, see https://goo.gle/chrome-for-testing\n\nPreview: https://bugs.chromium.org/p/chromium/issues/detail?id\u003d1336611#c31\n\nBug: 1336611\nChange-Id: I4cc5d6d6aa87cb045478bab25343552e5bd73163\nTested: `gn gen out/Default \u0026\u0026 gn args out/Default --args\u003d\"is_chrome_for_testing_branded\u003dtrue\" \u0026\u0026 autoninja -C out/Default`\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866275\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Alex Rudenko \u003calexrudenko@chromium.org\u003e\nCommit-Queue: Thiago Perrotta \u003ctperrotta@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1044027}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1f2b443c0e9a252028e22807f86d5b7d488e5a26\n" }, { "commit": "821d13663040ba027d96ab201449c9948f7a232c", "tree": "480878bf4a4bab9e3c262f0f1f88d635b7e10df3", "parents": [ "68138e1a2710a78683432a7270ccd5a9b49787a1" ], "author": { "name": "Joanmarie Diggs", "email": "jdiggs@igalia.com", "time": "Tue Aug 30 06:00:13 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 30 06:10:21 2022" }, "message": "Fix build in Python 3.11 (invalid mode: \u0027rU\u0027)\n\nIn Python 3.11, \u0027U\u0027 (\"universal newline\") is no longer accepted in\nthe file mode, having been deprecated in Python 3.3. The \"universal\nnewline\" is used by default when a file is open in text mode.\n\nThis commit removes the \u0027U\u0027 from the two (non-third-party) places\nit is used.\n\nBug: 1357549\nChange-Id: I3305707858d8ba7a9f518656a9b97dc1702bbe94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3859535\nReviewed-by: Mike Pinkerton \u003cpinkerton@chromium.org\u003e\nCommit-Queue: Joanmarie Diggs \u003cjdiggs@igalia.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1040794}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0991fc6acd3c85472000f2055af542515c3c6297\n" }, { "commit": "68138e1a2710a78683432a7270ccd5a9b49787a1", "tree": "a550ca5376cd93f0cb9fff9acc900879f665955e", "parents": [ "0cc6b1de37d691b9dfb2b377d1f7102f3b86e4ac" ], "author": { "name": "Ari Chivukula", "email": "arichiv@chromium.org", "time": "Sat Aug 06 00:14:46 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Aug 06 00:30:55 2022" }, "message": "[CodeHealth] Add native support for `is_chromeos` to Grit\n\nBug: 1316150\nChange-Id: I04b4a77593c8f786e4f3e4f49201cd365c1bb9d4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806459\nAuto-Submit: Ari Chivukula \u003carichiv@chromium.org\u003e\nReviewed-by: David Dorwin \u003cddorwin@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1032184}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cc2c658b8e2b359b73cab08b78dea1f84033017b\n" }, { "commit": "0cc6b1de37d691b9dfb2b377d1f7102f3b86e4ac", "tree": "f47574419eb2664d56774b23120a6ba6e859f640", "parents": [ "3d959465c4d015a3fd6731b70039d19a288b822e" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Fri Aug 05 23:52:56 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Aug 06 00:28:16 2022" }, "message": "Grit: Declare html_inline.py as input for preprocess_if_expr.gni.\n\nNeed to declare all imported python scripts used as inputs to ensure\nall preprocess_if_expr() targets are re-triggered whenever those inputs\nare modified. See GN docs at [1]\n\n\"... inputs should be the inputs to script that don\u0027t vary. These\nshould be all .py files that the script uses via imports.\"\n\n[1] https://gn.googlesource.com/gn/+/master/docs/reference.md#var_inputs\n\nBug: 1349923\nChange-Id: Ibe622779300973933f7531aa4f61f0f62568f628\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812286\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1032176}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 40fff5bccff604f9a6dfa65bf535380ae0427ab7\n" }, { "commit": "3d959465c4d015a3fd6731b70039d19a288b822e", "tree": "662d0f568d296e2166a0644e5608851f65e963cc", "parents": [ "ee30daff37d57b6fee1b8f3532510de18a637eca" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Thu Aug 04 20:02:14 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 04 20:14:34 2022" }, "message": "Grit: Declare additional inputs for preprocess_if_expr.gni.\n\nNeed to declare all imported python scripts used as inputs to ensure\nall preprocess_if_expr() targets are re-triggered whenever those inputs\nare modified. See GN docs at [1]\n\n\"... inputs should be the inputs to script that don\u0027t vary. These\nshould be all .py files that the script uses via imports.\"\n\nThis is a speculative (but with high confidence) fix for a few flaky\nbuild errors.\n\n[1] https://gn.googlesource.com/gn/+/master/docs/reference.md#var_inputs\n\nFixed: 1349923\nChange-Id: Ieaa30d5732015e328958d03375bd2a0c0a21de78\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810938\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1031561}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b9b9a0ec6ad98f56077f9496e529cb0c8d60afe6\n" }, { "commit": "ee30daff37d57b6fee1b8f3532510de18a637eca", "tree": "818ca5db6f75c1f59e79562b998f9e80b9041b5a", "parents": [ "e6e259b9314f0810f7c251ed3681d7b285c256a7" ], "author": { "name": "dpapad", "email": "dpapad@chromium.org", "time": "Wed Jun 29 05:31:10 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 29 05:42:29 2022" }, "message": "WebUI: Set default in_folder/out_folder values for preprocess_if_expr().\n\nProviding default values allows removing redundant code that was\nexplicitly setting them (mostly `in_folder \u003d \".\"`), and moreover makes\nit a bit easier to invoke preprocess_if_expr() before\nhtml_to_wrapper()/css_to_wrapper() in the near future.\n\nBug: 1325169\nChange-Id: Icb66cf25ab3a96fa7700ba1c4c177948a5dc0a28\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3733040\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nAuto-Submit: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1018977}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bb1e3aa8b329daf502f8dd2a8126afddd5d1860e\n" }, { "commit": "e6e259b9314f0810f7c251ed3681d7b285c256a7", "tree": "e3109d4a9a0e1f8cef8f7ee57952ab7107bf5bef", "parents": [ "1c393b10e516abda2faa85bb1459b4df6b67c021" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Wed Jun 22 17:22:01 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 22 17:39:16 2022" }, "message": "Android: Don\u0027t depend on source_set within java_strings_grd\n\nThis allows resource targets to be scheduled earlier, and avoids unnecessary\nC++ compilation for robolectric tests.\n\nE.g. content_junit_tests:\n\nBefore:\n 165.2 s weighted time (8648.7 s elapsed time sum, 52.4x parallelism)\n 9788 build steps completed, average of 59.26/s\n\nAfter:\n 160.9 s weighted time (5351.2 s elapsed time sum, 33.3x parallelism)\n 7325 build steps completed, average of 45.52/s\n\nBug: 1336476\nChange-Id: I4b3a9d9acdf159a9313f7b9c5cfe8aa343ad6d86\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715135\nReviewed-by: Peter Wen \u003cwnwen@chromium.org\u003e\nCommit-Queue: Peter Wen \u003cwnwen@chromium.org\u003e\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1016775}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 38368ed7361dab7cd250ad244e9b601212782609\n" }, { "commit": "1c393b10e516abda2faa85bb1459b4df6b67c021", "tree": "2d3b5d611f315b5a5e855e8c442489eaab3de2b4", "parents": [ "3c65b1357acd0f5e86fda2ff478eac1f257d4f17" ], "author": { "name": "Ben Mason", "email": "benmason@chromium.org", "time": "Mon Jun 13 18:47:36 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 13 19:02:18 2022" }, "message": "Revert \"Use a generated policy_templates.json\"\n\nThis reverts commit 549b48a38fcd7478041a254dcce3c9448c698b33.\n\nReason for revert: Translation pipeline issue crbug/1335992\n\nOriginal change\u0027s description:\n\u003e Use a generated policy_templates.json\n\u003e\n\u003e This is a part of the road to replacing the policy_templates.json file\n\u003e by smaller files. Those smaller files will be used to generate a\n\u003e policy_templates.json which will be used by all consumers of the\n\u003e old policy_templates.json so that they are not affected by changes to\n\u003e the format in which policies are defined.\n\u003e\n\u003e Bug: 1294298\n\u003e Change-Id: Icea890ab839800a8813a416af9d229fddc708781\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3663411\n\u003e Reviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n\u003e Reviewed-by: Owen Min \u003czmin@chromium.org\u003e\n\u003e Commit-Queue: Yann Dago \u003cydago@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1013446}\n\nBug: 1294298, 1335992\nChange-Id: I0189ef81b0dfcd7f99e845dee1f68b3968f7ebd3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702382\nOwners-Override: Ben Mason \u003cbenmason@chromium.org\u003e\nCommit-Queue: Ben Mason \u003cbenmason@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1013584}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 013f084e0d2512a3f335f31894e3ac30acbaffb7\n" } ], "next": "3c65b1357acd0f5e86fda2ff478eac1f257d4f17" }