| commit | d55d0117279121fdbe3f55058e9302d7f2bc4442 | [log] [tgz] |
|---|---|---|
| author | Takashi Sakamoto <[email protected]> | Tue Mar 05 03:13:15 2024 |
| committer | Copybara-Service <[email protected]> | Tue Mar 05 03:19:49 2024 |
| tree | 1449b2c2704d0d00403f336399684620d4eae2c6 | |
| parent | e4b499291bad049792c9147b679e105a678fb85e [diff] |
Revert "Re-enable Abseil flags support in GoogleTest." This reverts commit aa3936064e4896c948b8e82351a47b5d107fc6fe. Reason for revert: suspect causing tests failures on Linux Tests (Dbg)(1). - content_unittests failed. - browser_tests failed. - device_unittests failed. First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119054/overview Sample log: ERROR: Flag 'gmock_catch_leaked_mocks' was defined more than once but with differing types. Defined in files '../../third_party/googletest/src/googlemock/src/gmock.cc' and '../../third_party/googletest/src/googlemock/src/gmock.cc'. Original change's description: > Re-enable Abseil flags support in GoogleTest. > > While Abseil now supports a GTEST_NO_ABSL_FLAGS define, and Chrome could > simply set that define (once the corresponding GoogleTest version is > rolled in), there are other third-party test projects that need to use > parts of Abseil not normally allowed in Chrome, e.g. fuzztest's > Centipede. This serves as a proof-of-concept to validate the overall > approach. > > Bug: 326607005 > Bug: 40286621 > Change-Id: I982c8f7eaca1d20dd0d057fd2035db5cd271b99c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321837 > Reviewed-by: Nico Weber <[email protected]> > Commit-Queue: Daniel Cheng <[email protected]> > Reviewed-by: Mirko Bonadei <[email protected]> > Reviewed-by: Sorin Jianu <[email protected]> > Reviewed-by: Danil Chapovalov <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1268129} Bug: 326607005 Bug: 40286621 Change-Id: Ie5ed81138b3a751f9923dcc000793f87f6ab9efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340276 Commit-Queue: Takashi Sakamoto <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Takashi Sakamoto <[email protected]> Cr-Commit-Position: refs/heads/main@{#1268228} NOKEYCHECK=True GitOrigin-RevId: e0195dcd02deb75df4bfd994a224df47f67f3ff6