Google Git
Sign in
chromium / chromium / src / third_party / blink / renderer / devtools / 6a3cc740d747b230faca40a5f0d56a6148c70da5
commit6a3cc740d747b230faca40a5f0d56a6148c70da5[log] [tgz]
authorRob Paveza <[email protected]>Wed Oct 09 02:06:39 2019
committerCommit Bot <[email protected]>Wed Oct 09 02:06:39 2019
tree0ea05eb813b75b64ddf8d804a8b2f1516f26c672
parent7d28181e7d4f07bfb1f887702590f50f8ea8172b [diff]
DevTools: Styles focus problem after an interstitial dialog

By presenting an interstitial dialog (like Ctrl+P), keyboarding
users might get to a point where they can't put focus back into
the styles pane. This is because tabIndex is set to -1 for all
of the style blocks.  Typically, losing focus causes the styles
list to reset the first style block to tabIndex=0, but only if
the style container doesn't already have focus. Because of an
event ordering issue, the styles still have focus before the
interstitials receive focus. This change allows the styles tree
elements to reset the styles when they lose focus.

Bug: 963183
Change-Id: I227c48fd88dbe46bbebc982b0c6e10232769d860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842521
Reviewed-by: Lorne Mitchell <[email protected]>
Commit-Queue: Robert Paveza <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#704038}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 861c5ebd949d009975ded5e35ea5c4b710171d32
2 files changed
tree: 0ea05eb813b75b64ddf8d804a8b2f1516f26c672
  1. docs/
  2. front_end/
  3. scripts/
  4. services/
  5. tests/
  6. .clang-format
  7. .eslintignore
  8. .eslintrc.js
  9. .gitignore
  10. .npmignore
  11. .style.yapf
  12. BUILD.gn
  13. htaccess
  14. karma.conf.js
  15. LICENSE
  16. OWNERS
  17. package.json
  18. PRESUBMIT.py
  19. protocol.json
  20. readme.md
  21. tsconfig.json
readme.md

Chrome DevTools frontend

NPM package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

It is available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES2015 modules, so consuming this package in other tools may require some effort.

Package versioning

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Source code

The frontend is available through a git subtree mirror on chromium.googlesource.com, with a regularly updating GitHub mirror at github.com/ChromeDevTools/devtools-frontend. The codebase's true location is in third_party/blink/renderer/devtools/ in Chromium's git repo.

Getting Started

  1. Clone the repo
  2. Go to repo root and run: npm start
    • This launches Chrome Canary and starts the dev server with 1 command
  3. Go to http://localhost:9222#custom=true&experiments=true

Power user tips:

You can customize the port for the dev server: e.g. PORT=8888 npm start.

You can also launch chrome and start the server separately:

  • npm run chrome
  • npm run server

When you start Chrome separately, you can pass extra args to Chrome:

npm run chrome -- https://news.ycombinator.com

(e.g. this launches Hacker News on startup)

If you want to reset your development profile for Chrome, pass in “--reset-profile”:

npm start -- --reset-profile

OR

npm run chrome -- --reset-profile

Hacking

Useful Commands

Simpler npm commands w/ dtrun

If you want to run these npm commands anywhere in the chromium repo (e.g. in chromium/src), you'll want to setup our dtrun CLI helper.

One-time setup:

npm run setup-dtrun

Now, you can use any of the following commands by simply doing: dtrun test.

In addition, you no longer need to pass double dashes (e.g. --) before you pass in the flags. So you can do: dtrun test -d inspector/test.html.

npm run format

Formats your code using clang-format

npm run format-py

Formats your Python code using yapf

Note: Yapf is a command line tool. You will have to install this manually, either from PyPi through pip install yapf or if you want to enable multiprocessing in Python 2.7, pip install futures

npm test

Builds devtools and runs all inspector/devtools web tests.

Note: If you're using a full chromium checkout and compiled content shell in out/Release, then npm test uses that. Otherwise, with only a front-end checkout (i.e. cloning from GitHub), then npm test will fetch a previously compiled content shell from the cloud (and cache it for future test runs).

npm test basics

# run specific tests
npm test -- inspector/sources inspector/console

# debug a specific test. Any one of:
npm run debug-test inspector/cookie-resource-match.html
npm test -- --debug-devtools inspector/cookie-resource-match.html
npm test -- -d inspector/cookie-resource-match.html

# pass in additional flags to the test harness
npm test -- -f --child-processes=16

# ...for example, use a higher test timeout
npm test -- --time-out-ms=6000000 <test_path>

Tip: Learn about the test harness flags

--fetch-content-shell

# If you're using a full chromium checkout and have a compiled content shell,
# this will fetch a pre-compiled content shell. This is useful if you
# haven't compiled your content shell recently
npm test -- --fetch-content-shell

--target=SUB_DIRECTORY_NAME

# If you're using a build sub-directory that's not out/Release,
# such as out/Default, then use --target=SUB_DIRECTORY_NAME
npm test -- --target=Default

Development

Getting in touch

Tests

The tests are run through Karma.

python scripts/run_tests.py

You can also specify with which Chrome binary to run tests by setting the chrome-binary variable.

python scripts/run_tests.py --chrome-binary=/path/to/chromium/build/chromium