)]}'
{
  "log": [
    {
      "commit": "6712dc59f4a6c5626f391057cded3842700a17eb",
      "tree": "4bd6c52e0d4c05ea9cf55f7caa620d14b0f6dfd2",
      "parents": [
        "347b3c20a65d76c83757a9f9db5f09d316115907"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Fri Dec 13 21:48:20 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Fri Dec 13 21:58:09 2024"
      },
      "message": "Enable import-error check on //testing\n\nEnables the import-error pylint check on //testing. Most errors are\nfixed by updating the PYTHONPATH used by pylint to include the necessary\ndirectories, although some import errors are simply suppressed (most\ncommonly for vpython-provided modules).\n\nAlso takes this opportunity to add comments about where each block of\nnon-standard imports comes from. This was already present in a number of\nplaces, but not everywhere.\n\nBug: 353942917\nChange-Id: I506d35e5a6ae56471618e6b4af57dd2ecb64dd7b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092016\nCommit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nReviewed-by: Paul Semel \u003cpaulsemel@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1396194}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fe2702e96ce66e27b4e474f4a39eb78813de5fcc\n"
    },
    {
      "commit": "347b3c20a65d76c83757a9f9db5f09d316115907",
      "tree": "d65f8f771900872002eb55c17b8f440ef01ae25a",
      "parents": [
        "9950a459b13442a6c68016af4cc773b17c72eeca"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Thu Aug 29 02:35:54 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Thu Aug 29 02:43:46 2024"
      },
      "message": "Remove protected-access disable from //testing\n\nRemoves protected-access from the list of disabled checks in\n//testing\u0027s pylintrc file and fixes/suppresses found issues.\n\nRequires crrev.com/c/5792034 to land and roll first.\n\nBug: 353942917\nChange-Id: I199557a27c3b0ddd127c40fca60aa6dfc7b1037c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5791830\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1348412}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d776270bcf4c6df7a5f63004c46328a75a294a2b\n"
    },
    {
      "commit": "9950a459b13442a6c68016af4cc773b17c72eeca",
      "tree": "3f94f16306bf8f7eaddf090e737cc0c59bbd24d1",
      "parents": [
        "61f883a8638e662afd48dd0a540ea1fe7d720aaf"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Thu Aug 15 20:13:15 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Thu Aug 15 20:19:09 2024"
      },
      "message": "Remove additional //testing pylint disables\n\nRemoves the following disables from //testing\u0027s pylintrc file and fixes\nthe resulting warnings:\n* abstract-method\n* broad-except\n* invalid-triple-quote\n* locally-disabled (disabled by default)\n* locally-enabled (removed from Pylint)\n* ungrouped-imports\n\nAlso documents the reason why we expect to keep several disables around\nindefinitely.\n\nBug: 353942917\nChange-Id: Ifd5fce54d3187514ebc8c6a470bb1b55084b82f7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786530\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Ben Pastene \u003cbpastene@chromium.org\u003e\nAuto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1342450}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 67ff36d082a0b05877b0dd81745e32cd25175917\n"
    },
    {
      "commit": "61f883a8638e662afd48dd0a540ea1fe7d720aaf",
      "tree": "d18d0a5cf8a068a9519e36241b9f6656a471d0a2",
      "parents": [
        "c12914c28a8357e6c572b6ea35ec978463439674"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Tue Aug 13 23:14:41 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Tue Aug 13 23:21:52 2024"
      },
      "message": "Remove invalid-string-quote from //testing\n\nRemoves the invalid-string-quote disable from the //testing pylintrc\nfile and fixes all resulting errors.\n\nBug: 353942917\nChange-Id: I4e8ef60d4f7b7645fee7ee86d579032bb0c24eb1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5784807\nCommit-Queue: Ben Pastene \u003cbpastene@chromium.org\u003e\nAuto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1341341}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0d2300f3e5f6fa73e4fb6590633f4f331ffc8fc7\n"
    },
    {
      "commit": "c12914c28a8357e6c572b6ea35ec978463439674",
      "tree": "dcd781998d0ffcc81deb30a4b2f24e85ba712049",
      "parents": [
        "375252ecf36586b3eb340bf168ab92e45354486c"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Mon Aug 12 20:17:02 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Mon Aug 12 20:22:56 2024"
      },
      "message": "Remove additional //testing pylint disables\n\nRemoves the following disables from the //testing pylintrc file:\n* anomalous-backslash-in-string\n* consider-using-enumerate\n* deprecated-method\n* deprecated-module\n* function-redefined\n* global-statement\n* logging-not-lazy\n* reimported\n\nBug: 353942917\nChange-Id: I09c2508a9418e445b458f838db3cee0d2c77d7d0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777806\nCommit-Queue: Ben Pastene \u003cbpastene@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nAuto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1340582}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: db4416f19d8da169a00c1054ac02e0d52b6ff847\n"
    },
    {
      "commit": "375252ecf36586b3eb340bf168ab92e45354486c",
      "tree": "594553ab47e4cea21eeb126b56c8a48e7b92acbd",
      "parents": [
        "408887c51514251e83cab0c69bd0ea5223f60659"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Tue Aug 06 20:53:56 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Tue Aug 06 21:01:37 2024"
      },
      "message": "Reland \"Fix //testing import lint issues\"\n\nThis is a reland of commit a418670f47e2a8bb3a2ce69e990203eb69b5225f\n\nChanges from original CL:\n* Fixed run_variations_smoke_test.py being unable to import\n  from //build\n\nOriginal change\u0027s description:\n\u003e Fix //testing import lint issues\n\u003e\n\u003e Removes the import-related entries from //testing\u0027s pylintrc file and\n\u003e fixes resulting lint errors.\n\u003e\n\u003e Bug: 353942917\n\u003e Change-Id: Ie3b3dba795e0806631c37243a3b4f480a4215a6e\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5737567\n\u003e Auto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Commit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1337485}\n\nBug: 353942917\nChange-Id: Id9495cb75529fcc76037070abb4837d45f94210f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5766912\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Ben Pastene \u003cbpastene@chromium.org\u003e\nAuto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1338093}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c0021a86cb08d9c5fa63382560506a9967a056a0\n"
    },
    {
      "commit": "408887c51514251e83cab0c69bd0ea5223f60659",
      "tree": "f824527228be4682f88e29ace8596a86432c14ca",
      "parents": [
        "928154086f0da4f3eea5bb89e24364a16ec839da"
      ],
      "author": {
        "name": "Noah Rose Ledesma",
        "email": "noahrose@google.com",
        "time": "Mon Aug 05 22:57:25 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Mon Aug 05 23:17:08 2024"
      },
      "message": "Revert \"Fix //testing import lint issues\"\n\nThis reverts commit a418670f47e2a8bb3a2ce69e990203eb69b5225f.\n\nReason for revert: Causing ModuleNotFoundError: No module named \u0027skia_gold_common\u0027 errors on gardened builders\n\nOriginal change\u0027s description:\n\u003e Fix //testing import lint issues\n\u003e\n\u003e Removes the import-related entries from //testing\u0027s pylintrc file and\n\u003e fixes resulting lint errors.\n\u003e\n\u003e Bug: 353942917\n\u003e Change-Id: Ie3b3dba795e0806631c37243a3b4f480a4215a6e\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5737567\n\u003e Auto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Commit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1337485}\n\nBug: 353942917\nChange-Id: Ic27cddfc5fda700b5898c3681af18f42fd1222fa\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5763726\nCommit-Queue: Noah Rose Ledesma \u003cnoahrose@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Noah Rose Ledesma \u003cnoahrose@google.com\u003e\nReviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1337552}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3b0c4b7ccab92c0309798098f331734f023bc577\n"
    },
    {
      "commit": "928154086f0da4f3eea5bb89e24364a16ec839da",
      "tree": "594553ab47e4cea21eeb126b56c8a48e7b92acbd",
      "parents": [
        "1938e1e7b5fa41992992e9f2fceff9b8a77de6c3"
      ],
      "author": {
        "name": "Brian Sheedy",
        "email": "bsheedy@chromium.org",
        "time": "Mon Aug 05 21:09:26 2024"
      },
      "committer": {
        "name": "Copybara-Service",
        "email": "copybara-worker@google.com",
        "time": "Mon Aug 05 21:24:43 2024"
      },
      "message": "Fix //testing import lint issues\n\nRemoves the import-related entries from //testing\u0027s pylintrc file and\nfixes resulting lint errors.\n\nBug: 353942917\nChange-Id: Ie3b3dba795e0806631c37243a3b4f480a4215a6e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5737567\nAuto-Submit: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCommit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1337485}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a418670f47e2a8bb3a2ce69e990203eb69b5225f\n"
    },
    {
      "commit": "1938e1e7b5fa41992992e9f2fceff9b8a77de6c3",
      "tree": "f824527228be4682f88e29ace8596a86432c14ca",
      "parents": [
        "8624e686eecc86372c95ac9fab17d6942dd42be0"
      ],
      "author": {
        "name": "danakj",
        "email": "danakj@chromium.org",
        "time": "Fri Jun 16 13:21:48 2023"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:53:44 2023"
      },
      "message": "Choose the correct file extensions when cross-compiling for Windows\n\nWhen building a shared lib for the host tools toolchain, use .so on\nLinux, .dylib on Mac and .dll on Windows. Don\u0027t use the target\u0027s\nfile extension.\n\nWhen building a batch file to run the rust unit tests on Windows, use\nthe .exe extension even if building that batch file on a Linux\nmachine.\n\nR\u003dhans@chromium.org, lukasza@chromium.org\n\nBug: 1271215\nChange-Id: If90ea0013655a6c89e96688c9f9610b6539eb149\nCq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-dbg,android-rust-arm64-rel,mac-rust-x64-dbg,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-dbg,win-rust-x64-rel\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619088\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1158785}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9f9c029d53ed4e8a1a0cdeff70a9e21e41f840ce\n"
    },
    {
      "commit": "8624e686eecc86372c95ac9fab17d6942dd42be0",
      "tree": "53777012072af977d2a7c13d84091feca03e292e",
      "parents": [
        "507f1c7318b2333e3608a01c4ad9f99ca6a70263"
      ],
      "author": {
        "name": "Takuto Ikuta",
        "email": "tikuta@chromium.org",
        "time": "Fri Jun 02 02:23:49 2023"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:53:23 2023"
      },
      "message": "PRESUBMIT.py: remove `USE_PYTHON3 \u003d True`\n\npresubmit now uses python3 only.\n\nThis is generated by\n$ rg -l \u0027^USE_PYTHON3 \u003d True\u0027 | \\\n  xargs sed -z -i \"s/\\n*USE_PYTHON3 \u003d True\\n*/\\n\\n/\"\nwith some more modifications.\n\nThis also removes run_on_python2, run_on_python3, and skip_shebang_check\nargs.\n\nBug: 1207012\nChange-Id: I8c842d0a9ac485a27399d704a17b755f58a64db8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573952\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1152319}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 40def4845583973fe2301dc7829b4ee39c92b617\n"
    },
    {
      "commit": "507f1c7318b2333e3608a01c4ad9f99ca6a70263",
      "tree": "4f26441f2ac6622f1acdcc09bd5f9126147ff386",
      "parents": [
        "d44859b68eb794f222a8bb1aca99d593c8c91ed7"
      ],
      "author": {
        "name": "Collin Baker",
        "email": "collinbaker@chromium.org",
        "time": "Wed May 03 15:23:14 2023"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:52:56 2023"
      },
      "message": "Fix tee functionality in Rust unit test wrapper\n\nThe output was captured, but not printed to stdout. Additionally, the\ncheck_output method causes an exception when the child fails so the\noutput was completely lost on test failure.\n\nThe revised function forwards the process\u0027s stdout to both the\nparent\u0027s and a buffer.\n\nColor output is also restored.\n\nBug: 1271215\nChange-Id: I11e9873eb44688fc47acc057af391f7cca605505\nCq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-dbg,android-rust-arm64-rel,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-rel\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501262\nReviewed-by: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nAuto-Submit: Collin Baker \u003ccollinbaker@chromium.org\u003e\nCommit-Queue: Collin Baker \u003ccollinbaker@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1138921}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9de05d828b865f7b41de3bd166d06a9d5b24d82b\n"
    },
    {
      "commit": "d44859b68eb794f222a8bb1aca99d593c8c91ed7",
      "tree": "8f3b12c00d4651c418f724a4d493bc188162be8a",
      "parents": [
        "c1319a6bf0566c3a1cc90a7ff2aea4d428532171"
      ],
      "author": {
        "name": "danakj",
        "email": "danakj@chromium.org",
        "time": "Tue Apr 18 20:33:51 2023"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:52:30 2023"
      },
      "message": "Generate a .bat file for running tests in a rust_unit_test_group\n\nWhen targetting Windows, generate a .bat file instead of a bash script.\n\nBug: 1271215\nChange-Id: I682614081af8a30de10ae95f496373a665c078c8\nCq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-dbg,android-rust-arm64-rel,linux-rust-x64-dbg,linux-rust-x64-rel\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4436654\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1132123}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 89813763da19f98ffd82e1701b004a95a19a80f1\n"
    },
    {
      "commit": "c1319a6bf0566c3a1cc90a7ff2aea4d428532171",
      "tree": "5a2670f887283830417d170cfa7cdff1db3f26d0",
      "parents": [
        "752749097730fb3fa52b45a2b191f5459e236852"
      ],
      "author": {
        "name": "Andrew Grieve",
        "email": "agrieve@chromium.org",
        "time": "Thu Mar 30 19:08:38 2023"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:52:07 2023"
      },
      "message": "Copy some build_utils helpers to a non-android location\n\nSpecifically, moves:\n * atomic_output\n * add_depfile_arg()\n * parse_gn_list()\n * write_depfile()\n\nInto //build/action_helpers.py\n\nThis will remove some oddness of non-Android scripts importing a file\nfrom //build/android.\n\nI will remove the copies in build_utils.py in a follow-up.\n\nBug: 1428082\nChange-Id: If7dfe5306a7907987417e345637758c716a75ab5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382406\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1124347}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9d2a1ed6ee36f55b30031afaca939708c20410a5\n"
    },
    {
      "commit": "752749097730fb3fa52b45a2b191f5459e236852",
      "tree": "df18f95ab8a6e59298a7c27531654a29da5498ef",
      "parents": [
        "61d19b2210ad966180e8dc1cab19e7115858a5af"
      ],
      "author": {
        "name": "danakj",
        "email": "danakj@chromium.org",
        "time": "Mon Mar 13 22:05:47 2023"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:51:46 2023"
      },
      "message": "Start building with rustc on the Mac and Windows bots\n\nWe roll Rust from 6e0115778b0aedc90b59e035476c38e1b8c5c29b-2 to ac4379fea9e83465d814bb05005689f49bd2141e-1\n\nAnd get Rust starting to build on Mac and Windows trybots. It doesn\u0027t\nfully succeed but we can address more things in followup CLs.\n\nChange-Id: Ia9822c8b24a5973e1ccef942944c3465075b119f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310857\nReviewed-by: Collin Baker \u003ccollinbaker@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1116627}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 712cb486c1b2c53992fd329484c62e433df3945d\n"
    },
    {
      "commit": "61d19b2210ad966180e8dc1cab19e7115858a5af",
      "tree": "e3d7f83f6bca107393e9f995666097cb2c4c953c",
      "parents": [
        "f9b0520da3815391aead60ffbc7c1c16c3804861"
      ],
      "author": {
        "name": "Avi Drissman",
        "email": "avi@chromium.org",
        "time": "Thu Sep 15 20:11:09 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:51:22 2023"
      },
      "message": "Update copyright headers in testing/, tools/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c95.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: I3a8a7b150e7bd64690534727150646081df50439\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900697\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1047644}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dfd88085261b662a5c0a1abea1a3b120b08e8e48\n"
    },
    {
      "commit": "f9b0520da3815391aead60ffbc7c1c16c3804861",
      "tree": "411ee458eb90f5f8ca42dd83f26e73076d3d87fc",
      "parents": [
        "38ccfe8a42b897f7a6b8324c83f142a7133158cc"
      ],
      "author": {
        "name": "Joshua Hood",
        "email": "jdh@chromium.org",
        "time": "Wed May 04 16:00:42 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:50:53 2023"
      },
      "message": "Reland \"[CodeHealth] Migrate remainder of testing/ to Python3 compatible\nsyntax\"\n\nThis is a reland of commit 8defc6c6da91e4b7d7a686b7bb67658d9a5ebe55\n\nUses `sys.path.append(...)` to import the `common` module in\ntesting/scripts/run_variations_smoke_tests.py (as is done elsewhere in\nthe original CL) and resolve errors thrown for attempting a relative\nimport with no known parent package.\n\nOriginal change\u0027s description:\n\u003eand Pylint2.7, and fix resulting errors.\n\u003e\n\u003eBug: 1262363\n\u003eChange-Id: I09628427dd4caf9d873f3b489b897054430f8567\n\u003eReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557490\n\u003eReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003eCommit-Queue: Joshua Hood \u003cjdh@chromium.org\u003e\n\u003eCr-Commit-Position: refs/heads/main@{#996200}\n\nBug: 1262363\nChange-Id: I60fe062f62962d0b3dc4e93d9e29626ed181f688\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3610783\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Joshua Hood \u003cjdh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#999432}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3fade1f647d4dc195095434b4f28ed173ee61f2b\n"
    },
    {
      "commit": "38ccfe8a42b897f7a6b8324c83f142a7133158cc",
      "tree": "6ba0dc374dc094f44d369aeb677074316faa55aa",
      "parents": [
        "ee97cb9432445379275fd23fc8b574b51e19febb"
      ],
      "author": {
        "name": "Sebastien Lalancette",
        "email": "seblalancette@chromium.org",
        "time": "Tue Apr 26 20:53:45 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:50:32 2023"
      },
      "message": "Revert \"[CodeHealth] Migrate remainder of testing/ to Python3 compatible syntax\"\n\nThis reverts commit 8defc6c6da91e4b7d7a686b7bb67658d9a5ebe55.\n\nReason for revert: Makes win-chrome fail:\nhttps://ci.chromium.org/p/chrome/builders/try/win-chrome/4538\n\nOriginal change\u0027s description:\n\u003e [CodeHealth] Migrate remainder of testing/ to Python3 compatible syntax\n\u003e\n\u003e and Pylint2.7, and fix resulting errors.\n\u003e\n\u003e Bug: 1262363\n\u003e Change-Id: I09628427dd4caf9d873f3b489b897054430f8567\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557490\n\u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e Commit-Queue: Joshua Hood \u003cjdh@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#996200}\n\nBug: 1262363\nChange-Id: I74384a8cbd77e0db5adbbd5815d54e836472b756\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607233\nAuto-Submit: Sebastien Lalancette \u003cseblalancette@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Ben Pastene \u003cbpastene@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#996362}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 53ef7d3a9b421c2fb8b8831a2f20bfbcc95d1428\n"
    },
    {
      "commit": "ee97cb9432445379275fd23fc8b574b51e19febb",
      "tree": "411ee458eb90f5f8ca42dd83f26e73076d3d87fc",
      "parents": [
        "31b137247ade0ee0603c11d85f3c85a55d1c9886"
      ],
      "author": {
        "name": "Joshua Hood",
        "email": "jdh@chromium.org",
        "time": "Tue Apr 26 15:35:06 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:50:02 2023"
      },
      "message": "[CodeHealth] Migrate remainder of testing/ to Python3 compatible syntax\n\nand Pylint2.7, and fix resulting errors.\n\nBug: 1262363\nChange-Id: I09628427dd4caf9d873f3b489b897054430f8567\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557490\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: Joshua Hood \u003cjdh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#996200}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8defc6c6da91e4b7d7a686b7bb67658d9a5ebe55\n"
    },
    {
      "commit": "31b137247ade0ee0603c11d85f3c85a55d1c9886",
      "tree": "6ba0dc374dc094f44d369aeb677074316faa55aa",
      "parents": [
        "5b82c428d1cda516c2d4fc24e5db136841fb10f2"
      ],
      "author": {
        "name": "Bruce Dawson",
        "email": "brucedawson@chromium.org",
        "time": "Tue Apr 26 14:13:03 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:49:43 2023"
      },
      "message": "Disable rust tests on Windows\n\nThe rust tests fail on Windows due to importing of exe_util which\nimports pty which imports tty which imports termios (not present),\ndifferent handling of signals, and some slash/backslash mismatches just\nfor good measure. Fixing these tests is out-of-scope for this project so\nI am disabling them on Windows to get \"git cl presubmit --all\" closer to\nfinishing without errors on Windows.\n\nThis change can most easily be tested with this command:\n\n    git cl presubmit --files\u003dtesting/scripts/rust/*\n\nBug: 1309977\nChange-Id: I94c4ef177f0304f05e5c753d481b38497bb56856\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607149\nAuto-Submit: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nCommit-Queue: Robert Sesek \u003crsesek@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#996151}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5dc44535691f8f0e923e654f987c8d38c817748e\n"
    },
    {
      "commit": "5b82c428d1cda516c2d4fc24e5db136841fb10f2",
      "tree": "7adcc78500d40beb3f58d68411197d23dfd901d2",
      "parents": [
        "ad7bc0e45cf0e2706a065c4ea576a2b5a7e41639"
      ],
      "author": {
        "name": "danakj",
        "email": "danakj@chromium.org",
        "time": "Sat Mar 05 00:49:46 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:49:14 2023"
      },
      "message": "Allow multiple Cargo build targets with different configurations\n\nThis moves the build output for a cargo_crate into a subdirectory named\nafter the GN build target so that BUILD.gn can list multiple GN targets\nthat build the same files in different ways (with different features\nenabled).\n\nThe unit test file is also named such that the build target is included\nin it.\n\nR\u003dadetaylor@chromium.org\n\nBug: 1296669\nChange-Id: Ic08ef45aa99d949e9cc581c119a95f6dedde0888\nCq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3497920\nReviewed-by: Adrian Taylor \u003cadetaylor@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#977902}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5c8e1e3178e40da3ccf4171567a5d1f42e5aeb43\n"
    },
    {
      "commit": "ad7bc0e45cf0e2706a065c4ea576a2b5a7e41639",
      "tree": "d86945bfc228963931d3ad317d61fe081c61aa4d",
      "parents": [
        "6ca9997c9af4cdde7b274f67cd5ff65110ce2a3b"
      ],
      "author": {
        "name": "Collin Baker",
        "email": "collinbaker@chromium.org",
        "time": "Thu Mar 03 00:59:17 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:48:48 2023"
      },
      "message": "Run Mojo Rust tests on bot\n\nPreviously they were just compiled. Now that it\u0027s supported, run them\non the bot.\n\nAlso applies some fixes to the Rust test wrapper:\n* Handle tests in modules correctly by translating double colons to\n  slashes, e.g. (foo::bar_test -\u003e foo/bar_test)\n* Change FAILED -\u003e FAIL in json.output (to match https://chromium.googlesource.com/chromium/src/+/main/docs/testing/json_test_results_format.md#Test-result-types )\n* Handle ignored tests and report them as SKIP\n\nBug: 1274864, 1260120\nChange-Id: I37b25f440a0ccdd3f76f66c9706086059c2d6252\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3491344\nReviewed-by: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Collin Baker \u003ccollinbaker@chromium.org\u003e\nAuto-Submit: Collin Baker \u003ccollinbaker@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#976903}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 53f5a7be2c2e84ffeb7670ce3c186d58c550ba7d\n"
    },
    {
      "commit": "6ca9997c9af4cdde7b274f67cd5ff65110ce2a3b",
      "tree": "fcf6fbdc0675bbcb6d584b6fb3b0c7aad3c0d702",
      "parents": [
        "89b4857de6036d7e5e411f4a427bc67e24dd6721"
      ],
      "author": {
        "name": "danakj",
        "email": "danakj@chromium.org",
        "time": "Tue Mar 01 18:32:23 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:48:25 2023"
      },
      "message": "Support all combination of static/shared libraries with Rust\n\n1) Rename mixed_source_set/rust_source_set to *_static_library\n\nA rust crate produces the equivalent of a C++ static library: It is a\nset of object files for the sources (but not any deps) which will be\nlinked in the final linking step to produce a shared library or\nexecutable. This differs from a C++ source set, which is linked\ndirectly into some C++ static library. Rust rlibs are passed along\nto the \"link\" or \"solink\" tool, as seen by the reference to {{rlibs}}\nin //build/toolchain/gcc_toolchain.gni and described in\nhttps://crbug.com/gn/276.\n\n2) Add a test for the mixed_shared_library target type.\n\nHowever the test is currently disabled, because on the bots the .so file\nis missing from the isolate - we get a file not found for it.\n\n3) Introduce a rust_shared_library type, which is the parallel to the\nrust_static_library type, along with a test.\n\nSimilarly, the test is disabled for now but can be manually compiled\nwith the full target name.\n\n4) Export cxx-generated C++ symbols for shared_library targets always,\neven when not using component build. We ensure this happens by\nhaving rust_cxx read invoker.export_symbols. The invoker is the only one\nwho knows if symbols must be exported, because it knows if the cxx\nbindings are going to be linked into a shared_library or not. Previously\nit was trying to let the invoker set it but was not doing so correctly.\n\nWith this, we have a way to make a component, static lib, or shared\nlib that is either C++, Rust, or mixed C++-and-Rust.\n\nR\u003dadetaylor@chromium.org\n\nBug: 1297592\nChange-Id: I113a56b1a36cdec98d6dd9bddaa49cf9e5cde12f\nCq-Include-Trybots: luci.chromium.try:android-rust-arm-rel,linux-rust-x64-rel\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496008\nReviewed-by: Adrian Taylor \u003cadetaylor@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#976312}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 34e4fb85190a10f2dbce3fb881393a606673c5bc\n"
    },
    {
      "commit": "89b4857de6036d7e5e411f4a427bc67e24dd6721",
      "tree": "7908537573d3323ac9626f572a597105b4173529",
      "parents": [
        "7bd42727a742e09c946264314f2edb8a55db5cc3"
      ],
      "author": {
        "name": "Lukasz Anforowicz",
        "email": "lukasza@chromium.org",
        "time": "Thu Jan 20 15:39:04 2022"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:47:52 2023"
      },
      "message": "Fail earlier when `rust_test_exe --list ...` produces unexpected output.\n\nBefore this CL, when the output changes unexpectedly (e.g. because of\nhttps://crbug.com/1281664 or because of a change in Rust testing\nframework itself) we might not realize this and might just report that\nthe executable contains an empty list of tests.\n\nAfter this CL unexpected output will trigger an exception.\n\nBug: 1260120\nChange-Id: I97496f4c023cd2613a5a22fa14d2bc1c4089aeed\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3399483\nAuto-Submit: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nReviewed-by: Adrian Taylor \u003cadetaylor@chromium.org\u003e\nCommit-Queue: Adrian Taylor \u003cadetaylor@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#961460}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3072a367fecb4603360bcde88068fbfdb425f053\n"
    },
    {
      "commit": "7bd42727a742e09c946264314f2edb8a55db5cc3",
      "tree": "217995d9fb4437a41dac8d6dae6a8e2c51fbb8ff",
      "parents": [
        "dea1b215c51593afea70669edfbadb0afdd116be"
      ],
      "author": {
        "name": "Lukasz Anforowicz",
        "email": "lukasza@chromium.org",
        "time": "Mon Dec 20 20:59:05 2021"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:47:25 2023"
      },
      "message": "[rust] Add `rust_unit_tests_group(...)` gni template.\n\nThis CL adds a `rust_unit_tests_group(...)` gni template that can\ngenerate a Chromium-bot-friendly script that can run _all_ Rust unit\ntests inside the transitive `deps` of the group.\n\nManual testing:\n\n1. Checking that the tests can be run locally:\n    $ ninja -C out/rust build/rust/tests\n    $ out/rust/bin/run_native_rust_unittests__from__build_rust_tests\n    ... the tests execute successfully ...\n\n2. Checking that the tests can be run on the bots in a follow-up CL:\n   https://crrev.com/c/3322199/6\n\n3. Checking that the runtime_deps are reasonable:\n    $ gn clean out/rust\n    $ gn desc out/rust \\\n        build/rust/tests:native_rust_unittests__from__build_rust_tests \\\n        runtime_deps\n    bin/run_native_rust_unittests__from__build_rust_tests\n    ../../testing/scripts/rust/main_program.py\n    ../../testing/scripts/rust/test_filtering.py\n    ../../testing/scripts/rust/test_results.py\n    ../../testing/scripts/rust/exe_util.py\n    ../../testing/scripts/rust/rust_main_program.py\n    bin/run_test_mixed_component_rs_unittests\n    ./test_mixed_component_rs_unittests\n    bin/run_test_mixed_source_set_rs_unittests\n    ./test_mixed_source_set_rs_unittests\n    bin/run_test_rust_source_set_unittests\n    ./test_rust_source_set_unittests\n    bin/run_foo_tests\n    ./foo_tests\n    bin/run_test_rust_unittests\n    ./test_rust_unittests\n    bin/run_test_variable_source_set_rs_unittests\n    ./test_variable_source_set_rs_unittests\n\nBug: 1260120\nChange-Id: I19a15581ced0da85c6ec50a95016f2a547a43600\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327603\nReviewed-by: Adrian Taylor \u003cadetaylor@google.com\u003e\nCommit-Queue: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#953019}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 30500c5d5657387d3b4849d349037116c987e7ee\n"
    },
    {
      "commit": "dea1b215c51593afea70669edfbadb0afdd116be",
      "tree": "022a636c61d4a3764c4fd45d1f7a69db2969f0fa",
      "parents": [
        "766059606ba292a23988eb124247c429723b81a2"
      ],
      "author": {
        "name": "Lukasz Anforowicz",
        "email": "lukasza@chromium.org",
        "time": "Fri Dec 10 15:28:24 2021"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:46:51 2023"
      },
      "message": "[rust] generate `out/.../bin/run_foo` script from rust_unit_test(\"foo\").\n\nThis CL tweaks GN templates so that `rust_unit_test(foo)` will not only\ngenerate a `out/dir/foo` executable with unit tests from \"foo\" crate,\nbut also generate a `out/dir/bin/run_foo` Bash script that can be used\nto run the tests in a //docs/testing/test_executable_api.md-compatible\nway.\n\nExactly 1 generated run_foo script is generated per 1\nrust_unit_test(\"foo\") build target.  In the future, additional gni magic\nmay be provided for generating a script that covers multiple crates\n(e.g. multiple Rust unit test executables).  To ensure that the test\nnames are stable going forward, this CL preemptively tweaks\n//testing/scripts/rust to encode the name of a test executable in test\nnames.\n\nManual testing:\n\n1. $ ninja -C out/rust build/rust/tests/test_rust_unittests\n   $ out/rust/bin/run_test_rust_unittests\n\n2. Checking that a follow-up CL can successfully execute Rust unit tests\n   on a bot: https://crrev.com/c/3322199/3\n\nBug: 1260120\nChange-Id: I2c963c12c343ff90a7d5132ee8b7136d24a79685\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268794\nReviewed-by: Adrian Taylor \u003cadetaylor@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nCommit-Queue: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#950547}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b81e936243c7fac546e4d1cac20f286982c10823\n"
    },
    {
      "commit": "766059606ba292a23988eb124247c429723b81a2",
      "tree": "1d59c0089c2ae520e59b24323a1b0268a5c5a35c",
      "parents": [],
      "author": {
        "name": "Lukasz Anforowicz",
        "email": "lukasza@chromium.org",
        "time": "Wed Dec 08 02:35:43 2021"
      },
      "committer": {
        "name": "Josip Sokcevic",
        "email": "sokcevic@chromium.org",
        "time": "Mon Oct 30 18:46:15 2023"
      },
      "message": "[rust] Chromium-bot-friendly Python wrappers around native Rust tests.\n\nThis CL provides a script that wraps Rust unit test executables\nin an interface that Chromium bots expect - see\n//docs/testing/test_executable_api.md.\n\nBug: 1260120\nChange-Id: Ibba268b0deca5451b5859bd61862e245102be519\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233006\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: Gregory Guterman \u003cguterman@google.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#949339}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 139adaba5a47d7a4264914ee7882c1c7f2d98e65\n"
    }
  ]
}