Remove additional //testing pylint disables
Removes the following disables from //testing's pylintrc file and fixes
the resulting warnings:
* abstract-method
* broad-except
* invalid-triple-quote
* locally-disabled (disabled by default)
* locally-enabled (removed from Pylint)
* ungrouped-imports
Also documents the reason why we expect to keep several disables around
indefinitely.
Bug: 353942917
Change-Id: Ifd5fce54d3187514ebc8c6a470bb1b55084b82f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786530
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1342450}
NOKEYCHECK=True
GitOrigin-RevId: 67ff36d082a0b05877b0dd81745e32cd25175917
diff --git a/generate_script_unittests.py b/generate_script_unittests.py
index b6e2cb5..059e75a 100755
--- a/generate_script_unittests.py
+++ b/generate_script_unittests.py
@@ -47,14 +47,14 @@
finally:
os.remove(filepath)
- expected = '''
+ expected = """
#!/bin/bash
env vpython3 \
"$(dirname $0)/../../../testing/scripts/rust/rust_main_program.py" \\
"--rust-test-executable=$(dirname $0)/../bar" \\
"--rust-test-executable=$(dirname $0)/../foo" \\
"$@"
-'''.strip()
+""".strip()
self.assertEqual(expected, actual)
@@ -80,13 +80,13 @@
finally:
os.remove(filepath)
- expected = '''
+ expected = """
@echo off
vpython3 "%~dp0\\../../../testing/scripts/rust\\rust_main_program.py" ^
"--rust-test-executable=%~dp0\\..\\bar.exe" ^
"--rust-test-executable=%~dp0\\..\\foo.exe" ^
%*
-'''.strip()
+""".strip()
self.assertEqual(expected, actual)
