)]}'
{
  "commit": "ac31bc25f40f09df76304808d967475754da0988",
  "tree": "0cb91a1181da33150395c580b9729d60d6409f58",
  "parents": [
    "fa038d17091763228ec3efbc6fe7403db262505d"
  ],
  "author": {
    "name": "Will Yeager",
    "email": "wyeager@google.com",
    "time": "Tue Sep 15 22:40:26 2026"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Sep 15 23:03:14 2026"
  },
  "message": "Revert \"Wait for zxcvbn dictionaries before password weak-check\"\n\nThis reverts commit 303ca03a6a18eb85e0668bd5e3186e7723c5cdd3.\n\nReason for revert: Adding 5s to every test method in interactive_ui_tests suite on mac-rel trybot\n\nFailure Link: https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/2864682/infra the mac-rel run for this original CL saw the jump from ~25m to ~58m test shard execution time (with one 60m timeout). Since this landed, most mac-rel builder runs have been experiencing shard timeouts and there are 100s of pending builds that have accumulated.\n\nOriginal change\u0027s description:\n\u003e Wait for zxcvbn dictionaries before password weak-check\n\u003e\n\u003e PasswordWeakCheck() called zxcvbn::omnimatch() unconditionally, before\n\u003e the ZxcvbnData component finishes loading dictionaries via the async\n\u003e SetRankedDicts(). An early check could score against empty\n\u003e dictionaries and misreport weak passwords as strong.\n\u003e\n\u003e Add a readiness signal (base::WaitableEvent) to zxcvbn\u0027s RankedDicts\n\u003e and have PasswordWeakCheck() wait on it with a bounded timeout. Safe\n\u003e since BulkWeakCheck()\u0027s only callers already run on a MayBlock()\n\u003e ThreadPool sequence; added WithBaseSyncPrimitives() there to allow it.\n\u003e\n\u003e Bug: 380105409\n\u003e Change-Id: Idd47f3f97214cd538bce7740aa0467840a1c723e\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262912\n\u003e Reviewed-by: Friedrich Hauser \u003cfriedrichh@chromium.org\u003e\n\u003e Commit-Queue: Jan Keitel \u003cjkeitel@google.com\u003e\n\u003e Reviewed-by: Jan Keitel \u003cjkeitel@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1698131}\n\nBug: 380105409,562095747\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nInclude-Ci-Only-Tests: chromium.mac:mac-rel|interactive_ui_tests\nChange-Id: I6e621dfee5e1b8dbd19ec573ec77fff1dcaa03ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8415707\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nOwners-Override: Hiroshige Hayashizaki \u003chiroshige@chromium.org\u003e\nBot-Commit: rubber-stamper@appspot.gserviceaccount.com \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Hiroshige Hayashizaki \u003chiroshige@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1698439}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0b0ec1e8f7bdc1457b458cfb19f70c4893c9a990\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f463d14f13032858bd3c77a762856d3de7b3a1dd",
      "old_mode": 33188,
      "old_path": "variations/fieldtrial_testing_config.json",
      "new_id": "c25f63e3197c281189ee0f69216ec0f594c2964b",
      "new_mode": 33188,
      "new_path": "variations/fieldtrial_testing_config.json"
    }
  ]
}