)]}' { "log": [ { "commit": "4afe27fee76ed8451293415e43e9df404bc8da52", "tree": "ee554cc6a7b667d1b08d4f43c1cdf73cecc20319", "parents": [ "8d8338f3f3ce6773da022538770b6b0dba1c263c" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Nov 21 03:40:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 21 04:03:46 2025" }, "message": "Reland \"Move logging::LoggingSettings to base/logging/logging_settings.h\"\n\nThis is a reland of commit 6b79baf89a1d87407d4bafdc5d871061a81f80fc\n\nThe reland is the same CL. The difference is the problematic code in a\nseparate repo that did not do IWYU has been fixed.\n\nOriginal change\u0027s description:\n\u003e Move logging::LoggingSettings to base/logging/logging_settings.h\n\u003e\n\u003e Move struct LoggingSettings, which is only used in a relatively small\n\u003e number of files, out of base/logging.h and into its own header. Update\n\u003e direct users and then do IWYU to fix the build. This effectively moves\n\u003e base/files/file_path.h out of base/logging.h.\n\u003e\n\u003e Change-Id: I04209f1063051b7399e335d7e30cb7abb9442c94\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150\n\u003e Reviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Commit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n\u003e Owners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1546655}\n\nChange-Id: Ie877c3c85cc3e1983fb8b2b065b0d09607442ce4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7173024\nOwners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCommit-Queue: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1548242}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d7fb9d0cd0b6e1589ee974c1ca33de984df513e7\n" }, { "commit": "8d8338f3f3ce6773da022538770b6b0dba1c263c", "tree": "cd3c54af6486d22fc5f2f5ed4d3ac8efedfb8ba3", "parents": [ "fcb6206a0988deec76b592022302f7d2ad0df7ab" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Nov 19 02:46:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 19 02:51:34 2025" }, "message": "Revert \"Move logging::LoggingSettings to base/logging/logging_settings.h\"\n\nThis reverts commit 6b79baf89a1d87407d4bafdc5d871061a81f80fc.\n\nReason for revert: Broke win-chrome\n\nOriginal change\u0027s description:\n\u003e Move logging::LoggingSettings to base/logging/logging_settings.h\n\u003e\n\u003e Move struct LoggingSettings, which is only used in a relatively small\n\u003e number of files, out of base/logging.h and into its own header. Update\n\u003e direct users and then do IWYU to fix the build. This effectively moves\n\u003e base/files/file_path.h out of base/logging.h.\n\u003e\n\u003e Change-Id: I04209f1063051b7399e335d7e30cb7abb9442c94\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150\n\u003e Reviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Commit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n\u003e Owners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1546655}\n\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I7cf4167499823ba368fcfab88c930d1d98455fa0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7170750\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1546935}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6201eb11311d419ae1f44e85fff590ec69156cf5\n" }, { "commit": "fcb6206a0988deec76b592022302f7d2ad0df7ab", "tree": "ee554cc6a7b667d1b08d4f43c1cdf73cecc20319", "parents": [ "e3be333e5b1380b3f9035e8deb0e0aadfa375143" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Nov 18 18:20:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 18 18:45:32 2025" }, "message": "Move logging::LoggingSettings to base/logging/logging_settings.h\n\nMove struct LoggingSettings, which is only used in a relatively small\nnumber of files, out of base/logging.h and into its own header. Update\ndirect users and then do IWYU to fix the build. This effectively moves\nbase/files/file_path.h out of base/logging.h.\n\nChange-Id: I04209f1063051b7399e335d7e30cb7abb9442c94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150\nReviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1546655}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6b79baf89a1d87407d4bafdc5d871061a81f80fc\n" }, { "commit": "e3be333e5b1380b3f9035e8deb0e0aadfa375143", "tree": "cd3c54af6486d22fc5f2f5ed4d3ac8efedfb8ba3", "parents": [ "4ade7355f3c44c98e58e2ff3edbc5a602799df00" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Thu Jul 10 13:42:44 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 10 13:49:02 2025" }, "message": "Remove SpawnedTestServer.\n\nIt\u0027s deprecated, and tests have all been migrated off it.\n\nThis CL also enables websocket_end_to_end_test.cc on iOS, which\npreviously wasn\u0027t built there due to SpawnedTestServer not working on\nthat platform.\n\nThis leaves net/data/websocket in place, other than the Python files\nin that directory, but I plan to remove it and the\n`serve_websocket_test_data` argument to InstallDefaultWebSocketHandlers\nin a followup CL, moving files to the relevant chrome and content test\ndata directories as needed, just like non-WS BrowserTests do.\n\nFixed: 40419904\nChange-Id: Iab71a9ce79256898affc036c7c450c512fe44f48\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6713638\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Adam Rice \u003cricea@chromium.org\u003e\nCommit-Queue: mmenke \u003cmmenke@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1484928}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eab727f8ba864cc2e7aa4fddd51e532a4ce0b2d4\n" }, { "commit": "4ade7355f3c44c98e58e2ff3edbc5a602799df00", "tree": "98c3cba765854316387cd8c214f7e57b013fe669", "parents": [ "5d044b54752cff1dfb213568309c3b1075a58451" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Thu Jul 10 12:52:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 10 13:11:03 2025" }, "message": "Migrate run_testserver.cc to always use the EmbeddedTestServer.\n\nIt was using the SpawnedTestServer, which is deprecated, for WebSockets.\n\nBug: 380704159\nChange-Id: Ic37db3000a1951a30a116c27ca9df5bef28c3bab\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6710725\nCommit-Queue: mmenke \u003cmmenke@chromium.org\u003e\nReviewed-by: Adam Rice \u003cricea@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1484910}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 63b340cbcbf84cb5e64c44a2da5178eb575b80e4\n" }, { "commit": "5d044b54752cff1dfb213568309c3b1075a58451", "tree": "9bfa8334bd3615cdb038f066058a1337de2bc556", "parents": [ "be387211fbe05817ddbd6ab381be2c5b9ae8c7e1" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Thu Jun 26 16:56:15 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 26 17:14:14 2025" }, "message": "Remove proxy modes from SpawnedTestServer.\n\nNow that nothing is using them, best to remove the API to prevent\nregressions. This is not intended to remove every scrap of proxy related\nor more generally unused code from the SpawnedTestServer, since we\u0027ll\n(hopefully) be able to delete it soon anyways, but rather as a quick\nminimal-effort feature removal.\n\nFixed: 40242862\nBug: 40419904\nChange-Id: Id4ab128912a1d52c0a9e72ac39a9bb70bbf8e8e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6674254\nReviewed-by: Adam Rice \u003cricea@chromium.org\u003e\nCommit-Queue: mmenke \u003cmmenke@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1479245}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4a531243ca7b1062c78aeead9cc818714e4d46eb\n" }, { "commit": "be387211fbe05817ddbd6ab381be2c5b9ae8c7e1", "tree": "bad252d77ddfdac7a4b5682847b6a66dbf731566", "parents": [ "42754dee4e97cf6072eefaf2a0d63c3e5bc3b112" ], "author": { "name": "Ben Joyce", "email": "bjoyce@google.com", "time": "Fri Feb 14 02:34:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 14 02:43:13 2025" }, "message": "Reland \"Reland \"Reland Migrate to python 3.11 from 3.8\"\"\n\nThis is a reland of commit a5a4a98193eb652c177610afe10024cad1a17885\n\nThe revert was caused by hanging swarming tasks which had a separate\nversion of python that wasn\u0027t synced to the buildbucket version.\n(See crbug.com/395160553)\n\nThat version was fixed with https://chrome-internal-review.googlesource.com/c/infradata/config/+/8013788\n\nand a bug has been filed for the versions not being in sync.\n\nOriginal change\u0027s description:\n\u003e Reland \"Reland Migrate to python 3.11 from 3.8\"\n\u003e\n\u003e This is a reland of commit ae42a262c8c615956b14ae6de6181a7e09239ad7\n\u003e\n\u003e The CL was reverted as it caused devices to hang when running tests\n\u003e on android. (https://github.com/python/cpython/issues/106883)\n\u003e\n\u003e This has been fixed with a patch that fixed a bug in the python\n\u003e 3.11 interpreter.\n\u003e\n\u003e https://chromium-review.googlesource.com/c/infra/infra/+/6155095\n\u003e\n\u003e And then rolling out that change to depot_tools:\n\u003e https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6158273\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Reland Migrate to python 3.11 from 3.8\n\u003e \u003e\n\u003e \u003e Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/5872818\n\u003e \u003e was reverted and was not able to create an actual reland because of\n\u003e \u003e rebase merge failure with \"create reland\" button.\n\u003e \u003e\n\u003e \u003e Previous CL was reverted from failing:\n\u003e \u003e chromeos-jacuzzi-rel\n\u003e \u003e chromeos-octopus-rel\n\u003e \u003e\n\u003e \u003e This is from a incompatibility in aioquic, which is now fixed with\n\u003e \u003e an update to aioquick 1.2 (and its supporting libraries) as well as\n\u003e \u003e adding python and permission changes to chromeos.\n\u003e \u003e\n\u003e \u003e crrev.com/5904256\n\u003e \u003e crrev.com/5904734\n\u003e \u003e\n\u003e \u003e and some internal changes.\n\u003e \u003e\n\u003e \u003e The webtransport_h3_server.py file has to be changed here with the\n\u003e \u003e vpython change, and then wpt can be rolled. The change is already\n\u003e \u003e in the wpt repo, but has been manually excluded in the roll.\n\u003e \u003e\n\u003e \u003e Bug: 40942322\n\u003e \u003e Change-Id: Id12b7085fbc1ffd7694712013e6f746e65c3499f\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887447\n\u003e \u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e \u003e Reviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e \u003e Commit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\n\u003e \u003e Reviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1370866}\n\u003e\n\u003e Bug: 40942322\n\u003e Change-Id: Icce4762639fa96104f81c114e853f8069c95cf85\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168586\n\u003e Reviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\n\u003e Reviewed-by: mmenke \u003cmmenke@chromium.org\u003e\n\u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e Reviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Commit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1410521}\n\nBug: 40942322\nChange-Id: I10c428827d8c5a5618dd39f5a5f09484ee3f2d62\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198919\nReviewed-by: mmenke \u003cmmenke@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nReviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCommit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\nReviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1420258}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f22ea472fb2c64cdf6834c5da344bd5d2e1c837\n" }, { "commit": "42754dee4e97cf6072eefaf2a0d63c3e5bc3b112", "tree": "d5696fe64d54e7bc4edd0a4aae2eb58c98c921cf", "parents": [ "7b742818deeed3153894b32eb9137b5671c57d75" ], "author": { "name": "luci-bisection@appspot.gserviceaccount.com", "email": "luci-bisection@appspot.gserviceaccount.com", "time": "Fri Jan 24 14:06:20 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 24 14:25:45 2025" }, "message": "Revert \"Reland \"Reland Migrate to python 3.11 from 3.8\"\"\n\nThis reverts commit a5a4a98193eb652c177610afe10024cad1a17885.\n\nReason for revert:\nLUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5987431141605376\n\nSample build with failed test: https://ci.chromium.org/b/8724910883092854417\nAffected test(s):\n[ninja://:chrome_wpt_tests/external/wpt/webdriver/tests/bidi/session/unsubscribe/invalid.py](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:chrome_wpt_tests%2Fexternal%2Fwpt%2Fwebdriver%2Ftests%2Fbidi%2Fsession%2Funsubscribe%2Finvalid.py?q\u003dVHash%3A1b1e9c5537be9730)\n\nIf this is a false positive, please report it at http://b.corp.google.com/createIssue?component\u003d1199205\u0026description\u003dAnalysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5987431141605376\u0026format\u003dPLAIN\u0026priority\u003dP3\u0026title\u003dWrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6168586\u0026type\u003dBUG\n\nOriginal change\u0027s description:\n\u003e Reland \"Reland Migrate to python 3.11 from 3.8\"\n\u003e\n\u003e This is a reland of commit ae42a262c8c615956b14ae6de6181a7e09239ad7\n\u003e\n\u003e The CL was reverted as it caused devices to hang when running tests\n\u003e on android. (https://github.com/python/cpython/issues/106883)\n\u003e\n\u003e This has been fixed with a patch that fixed a bug in the python\n\u003e 3.11 interpreter.\n\u003e\n\u003e https://chromium-review.googlesource.com/c/infra/infra/+/6155095\n\u003e\n\u003e And then rolling out that change to depot_tools:\n\u003e https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6158273\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Reland Migrate to python 3.11 from 3.8\n\u003e \u003e\n\u003e \u003e Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/5872818\n\u003e \u003e was reverted and was not able to create an actual reland because of\n\u003e \u003e rebase merge failure with \"create reland\" button.\n\u003e \u003e\n\u003e \u003e Previous CL was reverted from failing:\n\u003e \u003e chromeos-jacuzzi-rel\n\u003e \u003e chromeos-octopus-rel\n\u003e \u003e\n\u003e \u003e This is from a incompatibility in aioquic, which is now fixed with\n\u003e \u003e an update to aioquick 1.2 (and its supporting libraries) as well as\n\u003e \u003e adding python and permission changes to chromeos.\n\u003e \u003e\n\u003e \u003e crrev.com/5904256\n\u003e \u003e crrev.com/5904734\n\u003e \u003e\n\u003e \u003e and some internal changes.\n\u003e \u003e\n\u003e \u003e The webtransport_h3_server.py file has to be changed here with the\n\u003e \u003e vpython change, and then wpt can be rolled. The change is already\n\u003e \u003e in the wpt repo, but has been manually excluded in the roll.\n\u003e \u003e\n\u003e \u003e Bug: 40942322\n\u003e \u003e Change-Id: Id12b7085fbc1ffd7694712013e6f746e65c3499f\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887447\n\u003e \u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e \u003e Reviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e \u003e Commit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\n\u003e \u003e Reviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1370866}\n\u003e\n\u003e Bug: 40942322\n\u003e Change-Id: Icce4762639fa96104f81c114e853f8069c95cf85\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168586\n\u003e Reviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\n\u003e Reviewed-by: mmenke \u003cmmenke@chromium.org\u003e\n\u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e Reviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Commit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1410521}\n\u003e\n\nBug: 40942322\nChange-Id: I0610989dbb4011d4d10b3c5b2cedaf1417e80c99\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196028\nOwners-Override: Ivana Žužić \u003cizuzic@google.com\u003e\nReviewed-by: Ivana Žužić \u003cizuzic@google.com\u003e\nCommit-Queue: Ivana Žužić \u003cizuzic@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1410881}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 468d53d6ec25d96ce10d8b014682200a5795884d\n" }, { "commit": "7b742818deeed3153894b32eb9137b5671c57d75", "tree": "bad252d77ddfdac7a4b5682847b6a66dbf731566", "parents": [ "677a7e12e91ccef622e91198d45a1ff4c1718370" ], "author": { "name": "Ben Joyce", "email": "bjoyce@google.com", "time": "Thu Jan 23 21:14:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 23 21:29:37 2025" }, "message": "Reland \"Reland Migrate to python 3.11 from 3.8\"\n\nThis is a reland of commit ae42a262c8c615956b14ae6de6181a7e09239ad7\n\nThe CL was reverted as it caused devices to hang when running tests\non android. (https://github.com/python/cpython/issues/106883)\n\nThis has been fixed with a patch that fixed a bug in the python\n3.11 interpreter.\n\nhttps://chromium-review.googlesource.com/c/infra/infra/+/6155095\n\nAnd then rolling out that change to depot_tools:\nhttps://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6158273\n\nOriginal change\u0027s description:\n\u003e Reland Migrate to python 3.11 from 3.8\n\u003e\n\u003e Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/5872818\n\u003e was reverted and was not able to create an actual reland because of\n\u003e rebase merge failure with \"create reland\" button.\n\u003e\n\u003e Previous CL was reverted from failing:\n\u003e chromeos-jacuzzi-rel\n\u003e chromeos-octopus-rel\n\u003e\n\u003e This is from a incompatibility in aioquic, which is now fixed with\n\u003e an update to aioquick 1.2 (and its supporting libraries) as well as\n\u003e adding python and permission changes to chromeos.\n\u003e\n\u003e crrev.com/5904256\n\u003e crrev.com/5904734\n\u003e\n\u003e and some internal changes.\n\u003e\n\u003e The webtransport_h3_server.py file has to be changed here with the\n\u003e vpython change, and then wpt can be rolled. The change is already\n\u003e in the wpt repo, but has been manually excluded in the roll.\n\u003e\n\u003e Bug: 40942322\n\u003e Change-Id: Id12b7085fbc1ffd7694712013e6f746e65c3499f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887447\n\u003e Reviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\n\u003e Reviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\n\u003e Commit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\n\u003e Reviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1370866}\n\nBug: 40942322\nChange-Id: Icce4762639fa96104f81c114e853f8069c95cf85\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168586\nReviewed-by: Jonathan Lee \u003cjonathanjlee@google.com\u003e\nReviewed-by: mmenke \u003cmmenke@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nReviewed-by: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCommit-Queue: Benjamin Joyce (Ben) \u003cbjoyce@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1410521}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a5a4a98193eb652c177610afe10024cad1a17885\n" }, { "commit": "677a7e12e91ccef622e91198d45a1ff4c1718370", "tree": "d5696fe64d54e7bc4edd0a4aae2eb58c98c921cf", "parents": [ "4496e76d7f5b9814a63000e1daa70b44fd8da245" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Feb 08 13:42:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 08 13:55:01 2024" }, "message": "Rename {absl \u003d\u003e std}::optional in //net/\n\n #cleanup\n\nAutomated patch. This is a no-op. Please avoid, as much as possible,\nassigning unrelated bugs to this.\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias\nfor std::optional. We should migrate toward it.\n\nScript:\n```\ncd net\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n -e \"\\.mm\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/g\"\n}\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place\" \"std::in_place\"\nreplace \"absl::in_place_t\" \"std::in_place_t\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\ncd ..\n\ngit status\necho \"Formatting\"\n\necho \"IncludeBlocks: Regroup\" \u003e\u003e \".clang-format\"\necho \"IncludeIsMainRegex: \\\"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\\\"\" \u003e\u003e \".clang-format\"\ngit cl format\ngit restore \".clang-format\"\n```\n\n# Skipping win-presubmit, due to a bug in depot_tools:\n# See https://g-issues.chromium.org/issues/324293047\nNOPRESUBMIT\u003dtrue\n\nCleanup: This is a cleanup.\nBug: chromium:1500249\nChange-Id: I87e48a7c66bb7c1a5c9f51952c303ba63b3b9c6e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277248\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Kenichi Ishibashi \u003cbashi@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1257890}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4787fce6c51383f5631643ac3d14cc512d656de6\n" }, { "commit": "4496e76d7f5b9814a63000e1daa70b44fd8da245", "tree": "ee3c50c0f3186ed903369343917342ca221939da", "parents": [ "69ef0407e96d24900081ca114cabdfc891f40d2d" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed Sep 14 20:52:29 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 14 21:08:41 2022" }, "message": "Update copyright headers in net/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c95.\n\nNo-Try: true\nBug: 1098010\nChange-Id: I26884c98578ee1ba4d7708ace5b25d1df5c0e576\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895939\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Mark Mentovai \u003cmark@chromium.org\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1047098}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6459548ee396bbe1104978b01e19fcb1bb68d0e5\n" }, { "commit": "69ef0407e96d24900081ca114cabdfc891f40d2d", "tree": "d5da9e1bda31286d6d5ff02d5e1b221e89060fd0", "parents": [ "8599944a086c503a4e31a95e226e967f5db560f7" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed Feb 23 16:34:11 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 23 16:42:28 2022" }, "message": "Remove SpawnedTestServer::TYPE_HTTP\n\nAs of https://chromium-review.googlesource.com/c/chromium/src/+/3452227,\nthe last use has been removed. SpawnedTestServer is now only used for\nWebSockets and proxies.\n\nBug: 492672\nChange-Id: Iff02e13b494a1c34e47bf51d322e72c5d8be404e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3481737\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Steven Valdez \u003csvaldez@chromium.org\u003e\nCommit-Queue: Steven Valdez \u003csvaldez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#974207}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1a95aace09e7cb1f333d11af8c5d115a5a39f686\n" }, { "commit": "8599944a086c503a4e31a95e226e967f5db560f7", "tree": "d25f454fb039e3c9662a88708a8e1585c2fb18a4", "parents": [ "be71ba5bad3989d3bd72fa3225c19e414c017f98" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Mon Nov 22 21:01:55 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 22 21:09:18 2021" }, "message": "Remove third_party/tlslite and SpawnedTestServer::TYPE_HTTPS\n\nSpawnedTestServer::TYPE_HTTPS is now unused and completely migrated\nto EmbeddedTestServer. That, in turn, means tlslite is also unused\nbecause SpawnedTestServer::TYPE_WSS uses the built-in Python ssl module.\n\n(SpawnedTestServer is now just TYPE_HTTP, only used by policy_testserver,\nand the WebSockets modes because we lack an embedded WebSockets test\nserver.)\n\nBug: 492672, 1250903\nChange-Id: If221c09671c09495bc5d7b086d0751b639515763\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3286767\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Andrey Kosyakov \u003ccaseq@chromium.org\u003e\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Sami Kyöstilä \u003cskyostil@chromium.org\u003e\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#944238}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 878348a2f43e41a1036dc716aacc2e73f2b34815\n" }, { "commit": "be71ba5bad3989d3bd72fa3225c19e414c017f98", "tree": "27d12df5f2ae192de3babbe16deef766c7fcfce4", "parents": [ "3ff96eaee6e2f7b3a287737bdf5b30cf957c7c9b" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed Nov 17 19:29:20 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 17 19:38:46 2021" }, "message": "Remove TLS13DowngradeTest\n\nThis test mattered in early days of TLS 1.3, because we disabled the\ncheck in BoringSSL and partially replicated it in Chromium. We also\nconditioned it on known roots.\n\nThat\u0027s all cleared now and we just rely on BoringSSL to enforce this. I\nthink we can thus just rely on BoringSSL\u0027s tests, as we do for most of\nthe rest of the handshake. (This one is a little tricky to test without\ntlslite because only a broken TLS server would fully complete the\nhandshake with an unexpected ServerHello.random marker.)\n\nWith this, the last tlslite-specific TLS customization is gone and we\ncan remove tlslite from testserver.py! (But policy_testserver.py still\nhas a use to clean up.)\n\nBug: 1250903\nChange-Id: I30cc6edd602bc8c1550a96ec05c053cdfd3efdaf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3286265\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#942753}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 77862729996272491479ed8983e9fdd427870b4e\n" }, { "commit": "3ff96eaee6e2f7b3a287737bdf5b30cf957c7c9b", "tree": "5ad312ee6f2ef405620763e67a17144a4e3f0322", "parents": [ "2e4fa7530ee26c51366fc5722d010cee5215918b" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed Nov 17 05:07:53 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 17 05:16:51 2021" }, "message": "Switch SSLClientSocketCertRequestInfoTest.CertKeyTypes to EmbeddedTestServer\n\nWe only use this to configure a particular list, which is the one\nBoringSSL always sends anyway. This removes another tlslite-only option,\nwhich gets us closer to removing tlslite.\n\nIt is somewhat unfortunate we cannot test other combinations, but this\nmechanism is a legacy one in the first place (see\nhttps://crbug.com/1270530), so probably not worth worrying about beyond\nremoving or modernizing it.\n\nBug: 1250903, 1270530\nChange-Id: Ifd48ff06b90bde23e5123ada6b4d17e86788e069\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283763\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#942461}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8d959c2bd4a951f3c2b7ba17e0e6269ef6dbdff8\n" }, { "commit": "2e4fa7530ee26c51366fc5722d010cee5215918b", "tree": "5dd34abe0e4b2302fc19d4744a158d40d209d1b6", "parents": [ "c0e2dc7fdad75397b750efb307ea0613c8fcd33e" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Tue Nov 16 23:26:09 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 16 23:35:32 2021" }, "message": "Switch SSLClientSocketReadTest.Read_WithFatalAlert to EmbeddedTestServer\n\nBoringSSL has an API we can call to send a fatal alert.\n\nBug: 1250903\nChange-Id: I03f8314588216dfb5941bf26f2101f2aacc5c395\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283144\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#942320}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 50c88f97667a68d84c6a18689a5dd04319aeec9c\n" }, { "commit": "c0e2dc7fdad75397b750efb307ea0613c8fcd33e", "tree": "680c74084eacd403ff8163bd9784b324f7b04fe4", "parents": [ "6eb196616d90c5fe9c73ce2dba451ede21ef883c" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Tue Nov 16 18:27:01 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 16 18:33:27 2021" }, "message": "Switch TLS intolerance tests to EmbeddedTestServer\n\nWe can simulate TLS intolerance with the ClientHello callback, so no\nneed for tlslite.\n\nBug: 1250903\nChange-Id: Icbe85b17f94d04b375d744de1959f61cdb4da703\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282446\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#942237}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d8d00b6458d3f65be7b98aaacfe81a18d9db47e2\n" }, { "commit": "6eb196616d90c5fe9c73ce2dba451ede21ef883c", "tree": "cc75cfced994adefb0a4b48c81df9bdf23553887", "parents": [ "1bb63e10de9c79826f0bb35e012277140ff1988d" ], "author": { "name": "Brian Sheedy", "email": "bsheedy@chromium.org", "time": "Thu Sep 30 20:40:46 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 30 20:52:24 2021" }, "message": "Make minidump tests Python 3-compatible\n\nMakes it possible to run //tools/perf/core/minidump_unittests.py under\nPython 3 on Linux. Other platforms may work, but have not yet been\nverified.\n\nBug: 1198237\nChange-Id: I2ba57111eb8704d446fd42f4a2d229252ec9627e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169966\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: David Schinazi \u003cdschinazi@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Brian Sheedy \u003cbsheedy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#926914}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9ffd52ad608b7302976b3557f5fb6d3c8f4fffe\n" }, { "commit": "1bb63e10de9c79826f0bb35e012277140ff1988d", "tree": "223b4951fd7ffac670cd2bf1856563db550b5b7d", "parents": [ "0c3cd36e86f0af5c5b6b8ab0d207c54367f8a64b" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Mon Sep 20 19:07:44 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 20 19:14:26 2021" }, "message": "Port SCT test to EmbeddedTestServer\n\nBug: 492672, 1250903\nChange-Id: Icac6ca051805f98c51fcacef079b105bc97cc181\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170212\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#923009}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8e657bc4d91a5004f72653039235109dba4bd211\n" }, { "commit": "0c3cd36e86f0af5c5b6b8ab0d207c54367f8a64b", "tree": "354d89986a7b0767d98218ba903bdea31c901af2", "parents": [ "f025abe4934b055b9fe4cc04f5d4edc010569e42" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Sat Sep 18 18:42:34 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Sep 18 18:50:00 2021" }, "message": "Remove unused features of SpawnedTestServer\n\nThis also removes the NoDHE test. The test was useful back while we were\nremoving DHE support. At this point, BoringSSL has not even implemented\nDHE for years. Keeping a DHE-capable test server around, purely to prove\nthat DHE doesn\u0027t work is unnecessary.\n\nBug: 1250903\nChange-Id: Iaff14c42f8ca2db0273e93e565169a0d94e1b09f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170211\nCommit-Queue: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#922809}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9f516afec13008193d77eaf88ecf6cdeda103d05\n" }, { "commit": "f025abe4934b055b9fe4cc04f5d4edc010569e42", "tree": "7106ecb1cd5abd9c88edd582535fa33d5a04cab5", "parents": [ "d8507d9f1a4e69f310823854db9ecf8b6ec59fff" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Fri Sep 17 22:59:19 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 17 23:08:34 2021" }, "message": "Port SpawnedTestServer to Python 3\n\nPorting tlslite was more straightforward than it seemed, probably\nbecause they already internally used bytearray everywhere, rather\nthan str.\n\nOne complication is getting a copy of Python 3 onto one of the\nCrOS builders. It runs out of space if we ship both Python 2\nand Python 3, so I\u0027ve switched it to only Python 3. This requires\ndisabling one test, but that test only exists to test Python 2\nworks.\nhttps://groups.google.com/a/chromium.org/g/python/c/KK60bQcwoCw/m/VctNoDYHCAAJ\n\nWe probably should remove GetPythonCommand from //net, since we\ndon\u0027t use it anymore. There\u0027s some code in //chrome/browser/media.\nBut that will take a bit more work to disentangle, so leave it\nalone for this CL.\n\nBug: 1248530\nChange-Id: I16b6d077648a436f0f2b42194b19d3104d198614\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3156548\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nReviewed-by: Amr Aboelkher \u003camraboelkher@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Pavol Marko \u003cpmarko@chromium.org\u003e\nReviewed-by: Ben Pastene \u003cbpastene@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#922697}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5af020cfe8e17f1d24ce85ee6585d79df0664c6f\n" }, { "commit": "d8507d9f1a4e69f310823854db9ecf8b6ec59fff", "tree": "360dd2a92d36b11e0406e1c7f9b20f88cb05d8e9", "parents": [ "1f5bdcf1c7ed2088a7a5e13a0430a687b5a5e6d1" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Thu Sep 16 18:09:40 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 16 18:30:25 2021" }, "message": "Convert minica and crlsetutil to Python 3\n\nI originally did this as part of SpawnedTestServer but ultimately\nremoved all dependencies on it instead. But I\u0027ve already done the work,\nso here it is. Since the test server no longer uses it, I\u0027ve also moved\nthe files to net/data/ssl/scripts.\n\nThe main detail of note is that asn1.py used to use PrintableString for\nPy2 str, which is the \"default\" string type, and UTFString for Py2\nunicode. Py3 flips this to bytes/str. Using PrintableString for bytes\nand UTF8String for str is odd because:\n\n- Surely OCTET STRING is the right default for bytes.\n\n- This changes the \"default\" string type from PrintableString to\n UTF8String. That\u0027s probably a good change overall, but I didn\u0027t want\n to change the output with a Py3 port.\n\nI\u0027ve instead made it raise an exception, so callers need to specify what\ntype they want.\n\ncrlsetutil also sees some changes. It had a bug when there were multiple\nentries. We just didn\u0027t notice because we only use it with one entry.\nNote also that, by switching to Python 3, we change order in the JSON.\nIn Python 3, unlike Python 2, the order is well-defined. So this one-time\noutput change fixes a repeatability failure in these scripts.\nhttps://stackoverflow.com/questions/1867861/how-to-keep-keys-values-in-same-order-as-declared\n\nTo keep me honest, I\u0027ve also refreshed the test data for the bits of the\nscripts that changed.\n\nChange-Id: I7e1ff6d42901c7c03903fc97eea03f7870dbd7ca\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159043\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#922214}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f6e74fe849de2f0ded88e911632fb079436bd301\n" }, { "commit": "1f5bdcf1c7ed2088a7a5e13a0430a687b5a5e6d1", "tree": "f0a2e16fe35d163124bd03db870f47b723ff2b18", "parents": [ "9aadbedd3820618feaf6c296e27d89acf9b18a12" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed Sep 15 14:46:41 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 15 14:55:49 2021" }, "message": "Remove non-default request handlers from testserver.py\n\nWe\u0027ve migrated enough tests to EmbeddedTestServer that nothing seems to\nactually use the request handlers anymore. This dramatically reduces the\namount of code that needs to be ported to Python 3, notably the bytes vs\nstr mess.\n\nBug: 492672, 1248530\nChange-Id: I26f9a6549d7702f8f61199de71a1cbf4999b45bd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3156547\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#921640}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: abdf28e532f2284e4137d3dea315a7f2bd7f9e87\n" }, { "commit": "9aadbedd3820618feaf6c296e27d89acf9b18a12", "tree": "e0ca77f6a298825f22aafc8cc94c7b55c22a321e", "parents": [ "8ed48d14a66bd6d98f0ddccab5404d9435102ee3" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed Sep 15 03:29:09 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 15 03:38:27 2021" }, "message": "Switch remaining TLS resumption tests to EmbeddedTestServer\n\nMost of the tests weren\u0027t actually using the recording features of\nssl-session-cache. The one test that did was merely testing that\nresumption happened. SSLInfo suffices for that.\n\nThis lets us delete the session cache recording machinery, which is less\ncode to port to Python 3.\n\nBug: 492672, 1248530\nChange-Id: I888a2b626f155c0544b1f5fe51a907e3917d40d4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3156550\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#921518}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 656f1c2b727432bf6029f899d13c975ff23b81be\n" }, { "commit": "8ed48d14a66bd6d98f0ddccab5404d9435102ee3", "tree": "a74ca651afe47c9427bfb856b191aacb7c099fe9", "parents": [ "0b11e48fe4c59ac08a4915b430f2922e893d212a" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Tue Sep 14 21:28:30 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 14 21:36:39 2021" }, "message": "Remove remnants of the OCSP CA from testserver.py\n\nThese tests have since been converted to EmbeddedTestServer. This lets\nus delete a bunch of code from testserver.py and thus reduce the amount\nwe need to convert to Python 3.\n\nBug: 1248530\nChange-Id: I214dc5b59edecdf00f14571acb4a4d986f679d5e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3156546\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#921414}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ff8cff7c592f35b9ae4c22715880aeb7e8294ad2\n" }, { "commit": "0b11e48fe4c59ac08a4915b430f2922e893d212a", "tree": "f81901f86bd951a697844c924953e71e8c74f904", "parents": [ "3a293bd46b32c3d5ec1c179c745c99793c9d8f25" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Mon Aug 23 15:58:54 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 23 16:08:28 2021" }, "message": "Roll src/third_party/pywebsocket3/src/ 9db3d29db..50602a14f (4 commits)\n\nhttps://chromium.googlesource.com/external/github.com/GoogleChromeLabs/pywebsocket3.git/+log/9db3d29db4f3..50602a14f1b6\n\n$ git log 9db3d29db..50602a14f --date\u003dshort --no-merges --format\u003d\u0027%ad %ae %s\u0027\n2021-08-20 ricea Support handler-encoding-ignorant embedders (#32)\n2021-08-20 ricea Support --handler-encoding option (#31)\n2021-04-22 arenevier Expose base.py as a public api. (#28)\n2021-04-01 ricea Add missing r to regular expression (#27)\n\nCreated with:\n roll-dep src/third_party/pywebsocket3/src\n build/print_python_deps.py --root net/tools/testserver --output net/tools/testserver/testserver.pydeps --allowlist third_party/tlslite/tlslite/utils net/tools/testserver/testserver.py\n\nBug: 1241489\nChange-Id: I21da67ca9e5df6546c4e02762dcc946339566555\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3109191\nReviewed-by: Yutaka Hirano \u003cyhirano@chromium.org\u003e\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nAuto-Submit: Adam Rice \u003cricea@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#914358}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b470e75f52ab2bdf4e70503dc3b589f8af989ff4\n" }, { "commit": "3a293bd46b32c3d5ec1c179c745c99793c9d8f25", "tree": "89fbf2eb04f1dc6be5b1294a5945eb955501c136", "parents": [ "58d9f6ab3009848fc94c900119176d2655a19bdd" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Fri Aug 13 20:34:43 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 13 20:47:32 2021" }, "message": "Remove FTP support from the EmbeddedTestServer.\n\nSince FTP support is gone, this is no longer needed.\n\nBug: 333943\nChange-Id: I7e0989c76ab42c36a2bbb420024a752c4f56d816\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3076540\nCommit-Queue: Matt Menke \u003cmmenke@chromium.org\u003e\nReviewed-by: Asanka Herath \u003casanka@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#911873}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 790ff96a854f0682959f957d249614d9192b0ab3\n" }, { "commit": "58d9f6ab3009848fc94c900119176d2655a19bdd", "tree": "3f2794aba57c408cba564d2bd8e4f6f30ff6550b", "parents": [ "3b00eb19ef43b75720f67083acaa567340dd1542" ], "author": { "name": "Anton Bikineev", "email": "bikineev@chromium.org", "time": "Sat May 15 20:43:52 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat May 15 20:52:28 2021" }, "message": "net: Replace base::Optional and friends with absl counterparts\n\nThis replaces:\n- base::Optional -\u003e absl::optional\n- include \"base/optional.h\"\n -\u003e\n include \"third_party/abseil-cpp/absl/types/optional.h\"\n- base::nullopt -\u003e absl::nullopt\n- base::make_optional -\u003e absl::make_optional\n\nBug: 1202909\nChange-Id: I27d6f81f415e213c1a4997a55c35935a57ba88a4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896994\nAuto-Submit: Anton Bikineev \u003cbikineev@chromium.org\u003e\nCommit-Queue: Anton Bikineev \u003cbikineev@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#883294}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 068d29106afcc2435307d2d2067a014a018d8ec7\n" }, { "commit": "3b00eb19ef43b75720f67083acaa567340dd1542", "tree": "df17f3fc9982534f374da0bf6ab069fcdebf60af", "parents": [ "aaf4967d31311f61d7026b58c43a3e3533f191f6" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Mon Apr 05 20:48:20 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 05 20:53:20 2021" }, "message": "Apply modernize-make-unique to net/\n\nThis is a large-scale change: go/chromium-modernize-make-unique\n\nBug: 1194272\nChange-Id: I6f1df6f75b769ab645fcb84666d0f2cda42c6ebc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2802770\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#869265}\nGitOrigin-RevId: 8a7540697bf500749236bf717a3930ba99f15f3e\n" }, { "commit": "aaf4967d31311f61d7026b58c43a3e3533f191f6", "tree": "27b270483d4775cda3c4c5d3eb7bcd22cd0fde17", "parents": [ "858064bf6ba0e16343621b5b022a38987fafc836" ], "author": { "name": "Nate Fischer", "email": "ntfschr@chromium.org", "time": "Wed Mar 10 17:34:40 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 10 17:50:17 2021" }, "message": "Code inclusion: update pydeps to use \"--allowlist\"\n\nNo change to logic. This swaps \"--whitelist\" for \"--allowlist\" in the\npydeps tool and updates the only site which uses this.\n\nTest: build/print_python_deps.py --root net/tools/testserver --output \\\nTest: net/tools/testserver/testserver.pydeps --allowlist \\\nTest: third_party/tlslite/tlslite/utils net/tools/testserver/testserver.py\nChange-Id: I27c7e093117cef712579952616960d9deb1eaae1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2746474\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nAuto-Submit: Nate Fischer \u003cntfschr@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#861607}\nGitOrigin-RevId: ba8f4154f9c2f0e47843aef6adc21c45659589ed\n" }, { "commit": "858064bf6ba0e16343621b5b022a38987fafc836", "tree": "101afbb917d09fe4807744a3744b9d29587595a1", "parents": [ "9ef5863fd5269836985f1248cab39ed88bca6b26" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Tue Nov 03 05:54:12 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 03 05:58:31 2020" }, "message": "Remove TCP/UDP echo modes from the SpawnedTestServer.\n\nExtensions, the only consumer of these modes, have been migrated off of\nthe SpawnedTestServer, so we can remove them.\n\nBug: 492672\nChange-Id: I105e8f4314a356a27a890f24583ca2681bc99f83\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513788\nCommit-Queue: Matt Menke \u003cmmenke@chromium.org\u003e\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#823453}\nGitOrigin-RevId: e1a1503cddd1dab06d6125b6418a6313877aa428\n" }, { "commit": "9ef5863fd5269836985f1248cab39ed88bca6b26", "tree": "79aae8cb710fe00977690caa7a4d9177ac415f07", "parents": [ "aabe678f94416cc66b12f8ee05cb5cdaab8db685" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Mon Nov 02 18:31:15 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 02 18:37:46 2020" }, "message": "Make remote_test_server use EmbeddedTestServer in HTTP mode.\n\nSpawnedTestServer is being slowly (very slowly) phased out, since it\nhas been responsible for a large number of issues leading to flake on\nthe tree, and doesn\u0027t work on mobile platforms.\n\nBug: 492672\nChange-Id: I106c01f5fb47a11655274f59da0ca622d36a0508\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510794\nReviewed-by: Steven Valdez \u003csvaldez@chromium.org\u003e\nCommit-Queue: Matt Menke \u003cmmenke@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#823221}\nGitOrigin-RevId: 8028fd8b557c7857692a92216e052fa90516221e\n" }, { "commit": "aabe678f94416cc66b12f8ee05cb5cdaab8db685", "tree": "d891431cbb3cd2e3632407f852d6f4b5ba75bb0e", "parents": [ "9630f6626863d12b1a1f81ac3e187734191861f2" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Thu Oct 22 14:44:50 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 22 14:49:33 2020" }, "message": "Add \"/chunked\" default handler to EmbeddedTestServer.\n\nLoadTimingBrowserTest.HTTP is flaking for unknown reasons. The only\nunusual thing it obviously does before it hangs is use the chunked\nhandler in the SpawnedTestServer. We want to reduce usage of that test\nserver, anyways, so this adds an equivalent handler to the\nEmbeddedTestServer.\n\nThis CL also removes the legacy chunked handled from the\nSpawnedTestServer, and migrates the small number of consumers\noff of the SpawnedTestServer.\n\nBug: 1138769\nChange-Id: Ia63be2326349f2019a1052cc04e9a708f9a2f4fa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481702\nReviewed-by: Steven Valdez \u003csvaldez@chromium.org\u003e\nReviewed-by: Andrey Kosyakov \u003ccaseq@chromium.org\u003e\nCommit-Queue: Matt Menke \u003cmmenke@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#819827}\nGitOrigin-RevId: 77a94561230b1cc89b68eff8da12d848afd38bd7\n" }, { "commit": "9630f6626863d12b1a1f81ac3e187734191861f2", "tree": "e948e1d897c39a90cbc7e1e5da6d0abb2894f5de", "parents": [ "2b74bceb4485017eeca3a2682f6fda0604c3f668" ], "author": { "name": "Victor-Gabriel Savu", "email": "vsavu@google.com", "time": "Wed May 20 07:59:50 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Wed Aug 12 17:54:02 2020" }, "message": "remove copybara initialization artifacts\n\nGitOrigin-RevId: 3c4fff9440644bfc4a9439a40f3369012c80ac1d\n" }, { "commit": "2b74bceb4485017eeca3a2682f6fda0604c3f668", "tree": "1fd83b75fd54195f8452d37b47ecbe7977d9ad99", "parents": [ "1e3338b724b0a36fc453901ca8846bd0d406d988" ], "author": { "name": "Victor-Gabriel Savu", "email": "vsavu@google.com", "time": "Wed May 20 07:59:50 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Wed Aug 12 17:52:43 2020" }, "message": "Copybara Service Migration Initialization.\n\nGitOrigin-RevId: 3c4fff9440644bfc4a9439a40f3369012c80ac1d\n" }, { "commit": "1e3338b724b0a36fc453901ca8846bd0d406d988", "tree": "e948e1d897c39a90cbc7e1e5da6d0abb2894f5de", "parents": [ "f819d2906b5fe75c81fdaf552c799e93d5e6fcd1" ], "author": { "name": "Victor-Gabriel Savu", "email": "vsavu@google.com", "time": "Wed May 20 07:59:50 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 20 07:59:50 2020" }, "message": "add python 3 compatibility to testserver_base\n\nMake testserver_base compatible with both python 2 and 3. This will\nallow policy_testserver to be compatible with both python 2 and 3.\n\nBug: chromium:1041448\nChange-Id: Id044980918baa69cdb10e26a09b9f601aab7b7cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206677\nReviewed-by: Matt Mueller \u003cmattm@chromium.org\u003e\nCommit-Queue: Victor-Gabriel Savu \u003cvsavu@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#770505}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3c4fff9440644bfc4a9439a40f3369012c80ac1d\n" }, { "commit": "f819d2906b5fe75c81fdaf552c799e93d5e6fcd1", "tree": "a4d9d8149098c296426447f75ca838dcf567b4f7", "parents": [ "83e26f964953b72cd3101ba3777dd6cb7fe29dbe" ], "author": { "name": "Lily Chen", "email": "chlily@chromium.org", "time": "Thu Apr 02 17:30:39 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 02 17:30:39 2020" }, "message": "Remove flaky obsolete test URLRequestTestHTTP.GetTest_ManyCookies\n\nBug: 1066615\nChange-Id: I661d23b59caa5d7d6e1a42b4c78575115048151f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133080\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Luke Halliwell (slow) \u003challiwell@chromium.org\u003e\nCommit-Queue: Lily Chen \u003cchlily@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#755885}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0c90b9d84ee5c48fdfb83c6c44157b442d55c08a\n" }, { "commit": "83e26f964953b72cd3101ba3777dd6cb7fe29dbe", "tree": "e9dbe118bd6e489768525ac408bddf61796962e9", "parents": [ "776b695eba0f404a72bbb5925ebfe9250e72b01b" ], "author": { "name": "Keita Suzuki", "email": "suzukikeita@google.com", "time": "Fri Mar 06 09:42:48 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 06 09:42:48 2020" }, "message": "Replace pywebsocket with pywebsocket3 in //net\n\nThis commit replaces the original pywebsocket with pywebsocket3 on //net\ntests, and removes any deprecated features. This also tweaks some of the\nwebsocket handlers that used the old API to use new ones.\n\nChange-Id: I6b77d0ed524c3ff279aa659b2ca6c4048e5da95e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054125\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Yutaka Hirano \u003cyhirano@chromium.org\u003e\nReviewed-by: Adam Rice \u003cricea@chromium.org\u003e\nCommit-Queue: Keita Suzuki \u003csuzukikeita@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#747618}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 56512597d2cba0a02d5a08529a2d585e4c2b0a0f\n" }, { "commit": "776b695eba0f404a72bbb5925ebfe9250e72b01b", "tree": "dac4e5663858589e6fb004772f963c60415d5d3d", "parents": [ "81f46b9acb3ed3d82fecd6a233935d7f30f63ff5" ], "author": { "name": "Robbie McElrath", "email": "rmcelrath@chromium.org", "time": "Tue Aug 20 22:22:53 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 20 22:22:53 2019" }, "message": "Support initializing logging with a file descriptor rather than a path.\n\nThis CL adds an optional file descriptor to LoggingSettings, which can\nbe used to initialize logging to an already open file. Previously,\nlogging to a file required passing a path and letting the logging\nsystem open() it for append. Passing a file-descriptor means that a\nprocess can be sandboxed to have no access to the log directory, but\ncan still be passed a file-descriptor to log to.\n\nThis is needed for the Network Service on ChromeOS, whose logging needs\nto be reinitialized to a new location after it\u0027s already started.\n\nBug: 977415\nChange-Id: I2d07dc13a7e9f0f57d0802e4816628c181f183cd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699477\nCommit-Queue: Robbie McElrath \u003crmcelrath@chromium.org\u003e\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Achuith Bhandarkar \u003cachuith@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Wez \u003cwez@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#688754}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8bf4984f3ad0fb5fc8981f02ce9b96078a98632f\n" }, { "commit": "81f46b9acb3ed3d82fecd6a233935d7f30f63ff5", "tree": "c183f65bec010045f743f06a1a0543625b8fcf0f", "parents": [ "8c2ae01543302aee0864e78a9b7a52eb78ff9a42" ], "author": { "name": "Chris Sharp", "email": "csharp@chromium.org", "time": "Fri Aug 02 15:45:32 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 02 15:45:32 2019" }, "message": "Reland \"Reland \"Remove references to MessagePump::Type\"\"\n\nThis reverts commit 8f5f3e89a5cdc3e67ea177eafa516f768d1f3e92.\n\nReason for revert: Revert wasn\u0027t needed\n\nOriginal change\u0027s description:\n\u003e Revert \"Reland \"Remove references to MessagePump::Type\"\"\n\u003e \n\u003e This reverts commit 1c1d61e5d92c70e423c4ea3a378523dd19a05e8f.\n\u003e \n\u003e Reason for revert: I suspect this is causing a compile failure on the Linux ChromiumOS Full Bot.\n\u003e \n\u003e Output:\n\u003e FAILED: obj/chromeos/services/assistant/tests/service_unittest.o\n\u003e /b/s/w/ir/cache/goma/client/gomacc ../../third_par...\n\u003e ../../chromeos/services/assistant/service_unittest.cc:12:10: fatal error: \u0027ash/public/interfaces/constants.mojom-forward.h\u0027 file not found\n\u003e #include \"ash/public/interfaces/constants.mojom-forward.h\"\n\u003e ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\u003e \n\u003e \n\u003e Original change\u0027s description:\n\u003e \u003e Reland \"Remove references to MessagePump::Type\"\n\u003e \u003e \n\u003e \u003e This is a reland of bfca9d675c524843b8bb6a0d014e29d4d6859056\n\u003e \u003e \n\u003e \u003e Was reverted because an optional trybot failed due to a missing include in an unrelated file.\n\u003e \u003e That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894\n\u003e \u003e \n\u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e Remove references to MessagePump::Type\n\u003e \u003e \u003e\n\u003e \u003e \u003e It is going away soon, replace with the real thing: MessagePumpType\n\u003e \u003e \u003e\n\u003e \u003e \u003e Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).\n\u003e \u003e \u003e\n\u003e \u003e \u003e This is a mechanical change that will be reviewed according to\n\u003e \u003e \u003e https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes\n\u003e \u003e \u003e\n\u003e \u003e \u003e Bug: 891670\n\u003e \u003e \u003e TBR\u003dgab@chromium.org\n\u003e \u003e \u003e\n\u003e \u003e \u003e Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7\n\u003e \u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058\n\u003e \u003e \u003e Commit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\n\u003e \u003e \u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e \u003e \u003e Cr-Commit-Position: refs/heads/master@{#682731}\n\u003e \u003e \n\u003e \u003e TBR\u003dgab@chromium.org\n\u003e \u003e \n\u003e \u003e Bug: 891670\n\u003e \u003e Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416\n\u003e \u003e Commit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\n\u003e \u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#683592}\n\u003e \n\u003e TBR\u003dgab@chromium.org,carlscab@google.com\n\u003e \n\u003e Change-Id: Ie479741cf8092d9110a9ee6c5fa81e7e084c6788\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Bug: 891670\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733432\n\u003e Reviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\n\u003e Commit-Queue: Chris Sharp \u003ccsharp@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#683602}\n\nTBR\u003dgab@chromium.org,csharp@chromium.org,carlscab@google.com\n\nChange-Id: Ieb323e7afaf248384c05b8cb0c13d6ec50856c75\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 891670\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733434\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Chris Sharp \u003ccsharp@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#683603}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7840c5809711ca58f4524a48727c35ed82299ff9\n" }, { "commit": "8c2ae01543302aee0864e78a9b7a52eb78ff9a42", "tree": "59723c4fe304a62427dce86d6a6b10993b1da65f", "parents": [ "0ec3715a3303c7bb5223013a9c438ec4aed140f6" ], "author": { "name": "Chris Sharp", "email": "csharp@chromium.org", "time": "Fri Aug 02 15:37:08 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 02 15:37:08 2019" }, "message": "Revert \"Reland \"Remove references to MessagePump::Type\"\"\n\nThis reverts commit 1c1d61e5d92c70e423c4ea3a378523dd19a05e8f.\n\nReason for revert: I suspect this is causing a compile failure on the Linux ChromiumOS Full Bot.\n\nOutput:\nFAILED: obj/chromeos/services/assistant/tests/service_unittest.o\n/b/s/w/ir/cache/goma/client/gomacc ../../third_par...\n../../chromeos/services/assistant/service_unittest.cc:12:10: fatal error: \u0027ash/public/interfaces/constants.mojom-forward.h\u0027 file not found\n#include \"ash/public/interfaces/constants.mojom-forward.h\"\n^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n\nOriginal change\u0027s description:\n\u003e Reland \"Remove references to MessagePump::Type\"\n\u003e \n\u003e This is a reland of bfca9d675c524843b8bb6a0d014e29d4d6859056\n\u003e \n\u003e Was reverted because an optional trybot failed due to a missing include in an unrelated file.\n\u003e That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894\n\u003e \n\u003e Original change\u0027s description:\n\u003e \u003e Remove references to MessagePump::Type\n\u003e \u003e\n\u003e \u003e It is going away soon, replace with the real thing: MessagePumpType\n\u003e \u003e\n\u003e \u003e Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).\n\u003e \u003e\n\u003e \u003e This is a mechanical change that will be reviewed according to\n\u003e \u003e https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes\n\u003e \u003e\n\u003e \u003e Bug: 891670\n\u003e \u003e TBR\u003dgab@chromium.org\n\u003e \u003e\n\u003e \u003e Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058\n\u003e \u003e Commit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\n\u003e \u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#682731}\n\u003e \n\u003e TBR\u003dgab@chromium.org\n\u003e \n\u003e Bug: 891670\n\u003e Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416\n\u003e Commit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\n\u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#683592}\n\nTBR\u003dgab@chromium.org,carlscab@google.com\n\nChange-Id: Ie479741cf8092d9110a9ee6c5fa81e7e084c6788\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 891670\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733432\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Chris Sharp \u003ccsharp@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#683602}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8f5f3e89a5cdc3e67ea177eafa516f768d1f3e92\n" }, { "commit": "0ec3715a3303c7bb5223013a9c438ec4aed140f6", "tree": "c183f65bec010045f743f06a1a0543625b8fcf0f", "parents": [ "63f6ddb9d660c6f4235fc2a3d74c08390bd9b036" ], "author": { "name": "Asanka Herath", "email": "asanka@chromium.org", "time": "Fri Aug 02 15:23:57 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 02 15:23:57 2019" }, "message": "[net] Fix default test data path.\n\nThe test data directory for testserver.py defaults to\n\"../../../../test/data\" which is outside the repository. Instead point\nit at \"../../data\" which is where the test data for //net is located.\n\nBug: None\nChange-Id: I6dd8c69ce9c1e12a0c031ab5a41a09fc4556e2e9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732694\nReviewed-by: Lily Chen \u003cchlily@chromium.org\u003e\nCommit-Queue: Asanka Herath \u003casanka@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#683599}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ccd86d84d7fb85fc722c16a2119afaa437e1e9cc\n" }, { "commit": "63f6ddb9d660c6f4235fc2a3d74c08390bd9b036", "tree": "db58dd5765502df39a80217a6e23981f80a58c3f", "parents": [ "64f48f41b70a96fea36023eb8f176d288ba23c39" ], "author": { "name": "Carlos Caballero", "email": "carlscab@google.com", "time": "Fri Aug 02 15:10:39 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 02 15:10:39 2019" }, "message": "Reland \"Remove references to MessagePump::Type\"\n\nThis is a reland of bfca9d675c524843b8bb6a0d014e29d4d6859056\n\nWas reverted because an optional trybot failed due to a missing include in an unrelated file.\nThat was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894\n\nOriginal change\u0027s description:\n\u003e Remove references to MessagePump::Type\n\u003e\n\u003e It is going away soon, replace with the real thing: MessagePumpType\n\u003e\n\u003e Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).\n\u003e\n\u003e This is a mechanical change that will be reviewed according to\n\u003e https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes\n\u003e\n\u003e Bug: 891670\n\u003e TBR\u003dgab@chromium.org\n\u003e\n\u003e Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058\n\u003e Commit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\n\u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#682731}\n\nTBR\u003dgab@chromium.org\n\nBug: 891670\nChange-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416\nCommit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#683592}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1c1d61e5d92c70e423c4ea3a378523dd19a05e8f\n" }, { "commit": "64f48f41b70a96fea36023eb8f176d288ba23c39", "tree": "bdd3ee3822899a6a5d0017116f69ddc232f2f710", "parents": [ "f29cc32a3c04ee5d9177d59f21e73333c6803c6d" ], "author": { "name": "Findit", "email": "findit-for-me@appspot.gserviceaccount.com", "time": "Wed Jul 31 16:42:20 2019" }, "committer": { "name": "Findit", "email": "findit-for-me@appspot.gserviceaccount.com", "time": "Wed Jul 31 16:42:20 2019" }, "message": "Revert \"Remove references to MessagePump::Type\"\n\nThis reverts commit bfca9d675c524843b8bb6a0d014e29d4d6859056.\n\nReason for revert:\n\nFindit (https://goo.gl/kROfz5) identified CL at revision 682731 as the\nculprit for failures in the build cycles as shown on:\nhttps://analysis.chromium.org/waterfall/culprit?key\u003dag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmY2E5ZDY3NWM1MjQ4NDNiOGJiNmEwZDAxNGUyOWQ0ZDY4NTkwNTYM\n\nSample Failed Build: https://ci.chromium.org/buildbot/chromium/win-archive-rel/3468\n\nSample Failed Step: compile\n\nOriginal change\u0027s description:\n\u003e Remove references to MessagePump::Type\n\u003e \n\u003e It is going away soon, replace with the real thing: MessagePumpType\n\u003e \n\u003e Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).\n\u003e \n\u003e This is a mechanical change that will be reviewed according to\n\u003e https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes\n\u003e \n\u003e Bug: 891670\n\u003e TBR\u003dgab@chromium.org\n\u003e \n\u003e Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058\n\u003e Commit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\n\u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#682731}\n\n\nChange-Id: Idf6e0f69a07267d3a322c700882d2b3f65dcf021\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 891670\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729553\nCr-Original-Commit-Position: refs/heads/master@{#682762}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b0504e9d670b43890ef31b7688fe0b247306b240\n" }, { "commit": "f29cc32a3c04ee5d9177d59f21e73333c6803c6d", "tree": "db58dd5765502df39a80217a6e23981f80a58c3f", "parents": [ "868a339c60629fbf35b47a5d762e73ee472e0eb1" ], "author": { "name": "Carlos Caballero", "email": "carlscab@google.com", "time": "Wed Jul 31 15:49:24 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 31 15:49:24 2019" }, "message": "Remove references to MessagePump::Type\n\nIt is going away soon, replace with the real thing: MessagePumpType\n\nHad to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).\n\nThis is a mechanical change that will be reviewed according to\nhttps://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes\n\nBug: 891670\nTBR\u003dgab@chromium.org\n\nChange-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058\nCommit-Queue: Carlos Caballero \u003ccarlscab@google.com\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#682731}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bfca9d675c524843b8bb6a0d014e29d4d6859056\n" }, { "commit": "868a339c60629fbf35b47a5d762e73ee472e0eb1", "tree": "bdd3ee3822899a6a5d0017116f69ddc232f2f710", "parents": [ "8270eb8472a6543dfda4a98c0723e780365f1418" ], "author": { "name": "Alex Clarke", "email": "alexclarke@chromium.org", "time": "Thu Jun 06 15:41:53 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jun 06 15:41:53 2019" }, "message": "Migrate more base::MessageLoops to base::SingleThreadTaskExecutor\n\nA large but trivial migration.\n\nTBR\u003dfdoray@chromium.org\n\nBug: 891670\nChange-Id: I1d3a7575703de8ba17238cb1c9e64d1d825c08d6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637460\nReviewed-by: Alex Clarke \u003calexclarke@chromium.org\u003e\nReviewed-by: François Doray \u003cfdoray@chromium.org\u003e\nCommit-Queue: Alex Clarke \u003calexclarke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#666718}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f7fb8a8048304051ab3f5e7b5c89b2635ea8cf77\n" }, { "commit": "8270eb8472a6543dfda4a98c0723e780365f1418", "tree": "31a058afaed0af615e33e4abb0da481602cfbf32", "parents": [ "9c2b31da68faa34eb06df212f65bee74c93a7979" ], "author": { "name": "Matt Mueller", "email": "mattm@chromium.org", "time": "Sat May 04 00:37:24 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat May 04 00:37:24 2019" }, "message": "Measure usage of Name normalization in successfully validated certificate chains.\n\nBug: 954417\nChange-Id: Ie3a2b1517db1422f5280fafd2dfc267b78bd75d4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576104\nCommit-Queue: Matt Mueller \u003cmattm@chromium.org\u003e\nReviewed-by: Steven Holte \u003cholte@chromium.org\u003e\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#656620}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 09c8fd9a816f4d83c4ee0e542973f687ba2969eb\n" }, { "commit": "9c2b31da68faa34eb06df212f65bee74c93a7979", "tree": "dcff37cc6d4fda59950b56181a7e8f67a1c559d1", "parents": [ "3459c70579436d1bf7d741dae37708e8934f4030" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Tue Mar 26 15:08:10 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 26 15:08:10 2019" }, "message": "Reland \"Allow .pydeps files to detect use of vpython\"\n\nSwitches net/tools/testserver/testserver.py to run using vpython.\n\nReverted in: 3fa3231e864cdbcd6572e8514f6050c43b28ce7f.\n\nReason for reland:\n * Fixed root cause of previous failure\n * Added more diagnostics when failures happen\n\nBug: 930752, 930538, 943654\nChange-Id: I7d09ca153162059d54c729aba4c3aed0c8cc759d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531302\nReviewed-by: John Budorick \u003cjbudorick@chromium.org\u003e\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#644330}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f230231e1a77a56d5122910fb9f02596a17e1fda" }, { "commit": "3459c70579436d1bf7d741dae37708e8934f4030", "tree": "96cacb84d450b01b4384d28e3694821ca622de12", "parents": [ "7b5aa30c2842c43da9fde4488993ac950854690c" ], "author": { "name": "Alexander Timin", "email": "altimin@chromium.org", "time": "Thu Nov 01 20:15:20 2018" }, "committer": { "name": "Alexander Timin", "email": "altimin@chromium.org", "time": "Thu Nov 01 20:15:20 2018" }, "message": "[message_loop] Remove message_loop_forward.h\n\nAs a final step, replace all includes back:\n- mv message_loop_current.h message_loop.h\n- s/message_loop_forward.h/message_loop.h/ in all includes.\n- s/message_loop_forward.h/message_loop.h/ in base/BUILD.gn\n- Remove message_loop_forward.h from third_party/DEPS.\n\nTBR\u003dgab@chromium.org\nR\u003dgab@chromium.org\nBUG\u003d891670\n\nChange-Id: I623077025701459ddb7045cbcfdad138aa90a9e4\nReviewed-on: https://chromium-review.googlesource.com/c/1313110\nReviewed-by: Alexander Timin \u003caltimin@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#604690}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4f9c35c3635144e2c2d1b87d09cbcf076d138b66" }, { "commit": "7b5aa30c2842c43da9fde4488993ac950854690c", "tree": "fa723e92862decb748bbeaf8f95d65153ef1f4d1", "parents": [ "c7b94d9ff2a59415de0de0927a8e4a7d0f8b8754" ], "author": { "name": "Alexander Timin", "email": "altimin@chromium.org", "time": "Thu Nov 01 19:43:28 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 01 19:43:28 2018" }, "message": "[message_loop] Temporary introduce message_loop_forward.h.\n\nTo facilitate splitting MessageLoop into MessageLoop and MessageLoopImpl\nintroduce message_loop_forward.h and use it everywhere.\n\n- s/message_loop.h/message_loop_forward.h/ in all includes.\n- Add message_loop_forward.h to base/BUILD.gn.\n- Add message_loop_forward.h to third_party/DEPS.\n\nTBR\u003dgab@chromium.org\nBUG\u003d891670\n\nChange-Id: Ibac3a24f5bd4291c9d57dd32c627477e4e6ef324\nReviewed-on: https://chromium-review.googlesource.com/c/1313108\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#604672}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c643d0e146c996d39f757612b52ebea645561684" }, { "commit": "c7b94d9ff2a59415de0de0927a8e4a7d0f8b8754", "tree": "96cacb84d450b01b4384d28e3694821ca622de12", "parents": [ "f839f1cdfb15d722c09f0fc1e84f4b94b7b03842" ], "author": { "name": "Scott Graham", "email": "scottmg@chromium.org", "time": "Thu Oct 25 18:50:53 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 25 18:50:53 2018" }, "message": "Fix #include in run_testserver\n\nThis happens to show up on Fuchsia, but is a general IWYU for\nbase::DirectoryExists().\n\nBug: 808287\nChange-Id: I26608991148aa2d381fe3f162a666a53722d4b57\nReviewed-on: https://chromium-review.googlesource.com/c/1298358\nReviewed-by: Asanka Herath \u003casanka@chromium.org\u003e\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#602815}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 532006cfd3c308f52d14d05fce67dd232a70e67a" }, { "commit": "f839f1cdfb15d722c09f0fc1e84f4b94b7b03842", "tree": "821b5726d5d9fbbc32f7d4009848cad2cafbfdc7", "parents": [ "4a22b72bb89fadbebd2127c51b269e87376440d8" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Tue Oct 16 06:01:29 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 16 06:01:29 2018" }, "message": "Revise TLS 1.3 downgrade feature and metrics.\n\nDue to non-compliant middleboxes, it is possible we\u0027ll need to do some\nsurgery to this mechanism. Fix the double-negative on the base::Feature\nso it is less confusing and gather more extensive metrics when\nenforcement is disabled. Also flip the default in trunk to disabled and\nconnect it to about:flags.\n\nFinally, add a bunch of machinery to test this stuff.\n\nBug: boringssl:226\nChange-Id: Ib910328c9733b47db16b4cb811e8f2cb09b69d0c\nReviewed-on: https://chromium-review.googlesource.com/c/1274605\nReviewed-by: Ilya Sherman \u003cisherman@chromium.org\u003e\nReviewed-by: Steven Valdez \u003csvaldez@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#599879}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 570460e9b6482055b236a8b60ef5521506bf991c" }, { "commit": "4a22b72bb89fadbebd2127c51b269e87376440d8", "tree": "80f5b7ed56308b958811709682c9716b4ce9c07d", "parents": [ "9476b8c8f7b69b2e6841068711cd6ea20220a0ae" ], "author": { "name": "Nick Harper", "email": "nharper@chromium.org", "time": "Fri Sep 28 20:33:26 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 28 20:33:26 2018" }, "message": "Remove support for Token Binding\n\nThis removes most Token Binding code from chromium. There are a few\nplaces that still have Token Binding references (but will go unused)\nthat can possibly be removed in the future. These are:\n- android_webview/\n- net/third_party/quic/\n- third_party/tlslite/\n\nThere are two UMA histograms in //net that also have TokenBinding in\ntheir name; these are (confusingly) used by Channel ID code as part of\nthe work on debugging Channel ID mismatches, and can be removed with the\nrest of the Channel ID code.\n\nBug: 875046\nCq-Include-Trybots: luci.chromium.try:linux_mojo\nChange-Id: Ie3d23f8e9580f2d582febfb04e777006f57baa17\nReviewed-on: https://chromium-review.googlesource.com/1248125\nReviewed-by: Kinuko Yasuda \u003ckinuko@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCommit-Queue: Nick Harper \u003cnharper@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#595197}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2243e8002e3025b3f8386c13be7437fc8b597e2a" }, { "commit": "9476b8c8f7b69b2e6841068711cd6ea20220a0ae", "tree": "211ec0404ba72cd67ee1c1c014f14d550d997f5f", "parents": [ "54443aabc1f46c343cedcc1e5b59492ca721d469" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Thu Aug 02 15:28:43 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Aug 02 15:28:43 2018" }, "message": "[WebSocket] Fix proxy.pac --winhttp-proxy-resolver\n\nMake proxy.pac resolution for WebSockets work for Windows and Mac when\nthe --winhttp-proxy-resolver flag is supplied. These platforms don\u0027t\nsupport passing WebSocket URLs to the proxy.pac file. Convert ws and wss\nURLs to http and https before passing them to proxy.pac. This matches\nthe behaviour of the vendor browsers on these platforms.\n\nAdd a WebSocket end-to-end test to verify that WebSockets can be\naccessed via a proxy specified in proxy.pac.\n\nSince preflighting proxy credentials makes the tests really complicated,\nadd an extra mode to testserver.py for a vanilla proxy that doesn\u0027t\nrequire auth.\n\nBUG\u003d862121\n\nChange-Id: I63b318b7f6d3083a6c21f5811bb27966d17cb02a\nReviewed-on: https://chromium-review.googlesource.com/1143093\nCommit-Queue: Adam Rice \u003cricea@chromium.org\u003e\nReviewed-by: Yutaka Hirano \u003cyhirano@chromium.org\u003e\nReviewed-by: Ian Clelland \u003ciclelland@chromium.org\u003e\nReviewed-by: Eric Roman \u003ceroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#580196}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5b4a3d893cfd6a42a2d1f685fa6a828d34c9c1de" }, { "commit": "54443aabc1f46c343cedcc1e5b59492ca721d469", "tree": "238a4e81994d2822dab42d3dd1fbb18a9a2418ee", "parents": [ "d167f3a6953dd8c5f59599e02a6cbd00a284bd9b" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Wed Jun 06 00:11:54 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jun 06 00:11:54 2018" }, "message": "testserver.py: Improve logging on connection failure\n\ntestserver.py didn\u0027t report useful diagnostics on connection failure in proxy\nmode. For the CONNECT method it would report an UnboundLocalError and for the\nGET method it would log nothing at all.\n\nLog connection failures (and other network errors) in proxy mode.\n\nBehaviour in other modes is unchanged.\n\nBUG\u003d849128\n\nChange-Id: Idbc8f0254438098461b6db2bb68c5268c48e1956\nReviewed-on: https://chromium-review.googlesource.com/1084422\nReviewed-by: Eric Roman \u003ceroman@chromium.org\u003e\nReviewed-by: Ian Clelland \u003ciclelland@chromium.org\u003e\nCommit-Queue: Adam Rice \u003cricea@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#564724}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d688980779bf033aa3e44df037744bce75adcb7d" }, { "commit": "d167f3a6953dd8c5f59599e02a6cbd00a284bd9b", "tree": "0aaf4a1e68a18b3377ce9828132ffd808b40c1e2", "parents": [ "55aef64072340aa1493a7cc0529ea17cf6558cdd" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Fri May 18 16:17:22 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 18 16:17:22 2018" }, "message": "GN: Add \"python_library\" template for group()s that use \".pydeps\"\n\nAlso adds two new usages of it:\n //build/android:resource_sizes_py\n //tools/binary_size:binary_size_trybot_py\n\nBug: 702625\nChange-Id: Idc8113ca5e95ec9b5f5ff0cf22c14eeab95b78f8\nReviewed-on: https://chromium-review.googlesource.com/1058836\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: John Budorick \u003cjbudorick@chromium.org\u003e\nReviewed-by: Helen Li \u003cxunjieli@chromium.org\u003e\nReviewed-by: Peter Wen \u003cwnwen@chromium.org\u003e\nCommit-Queue: agrieve \u003cagrieve@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#559916}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a7f1ee90249c022de2b5d441bb1e1a3f8c0ecdd7" }, { "commit": "55aef64072340aa1493a7cc0529ea17cf6558cdd", "tree": "60a0b79bee5212dd1a938fd7ddd850739f811b36", "parents": [ "7586334dbc998e3f94cdd1703665f5f53708291b" ], "author": { "name": "Matt Mueller", "email": "mattm@chromium.org", "time": "Wed May 02 18:53:57 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 02 18:53:57 2018" }, "message": "[PKI library] Allow intermediate\u0027s OCSP response to be up to 1 year old.\n\nBug: 410574\nChange-Id: If9d4642061ab8fb40903d7f3901b7313caf8244b\nReviewed-on: https://chromium-review.googlesource.com/1036621\nCommit-Queue: Matt Mueller \u003cmattm@chromium.org\u003e\nReviewed-by: Eric Roman \u003ceroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#555489}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5339d86ebbfd04c69c7f1ef6f08c7c4a113956cf" }, { "commit": "7586334dbc998e3f94cdd1703665f5f53708291b", "tree": "cd168bf5d12d66431ba7b5ee14ec20f08c2d04c4", "parents": [ "34b2e31f39cd90dc558590e50913ccc71dd35707" ], "author": { "name": "Matt Mueller", "email": "mattm@chromium.org", "time": "Tue May 01 22:58:47 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 01 22:58:47 2018" }, "message": "net: minica.py: Randomize intermediate CN to avoid caching issues.\n\nChange-Id: I8b2889ac52df0e59413590002416c97434ca3cfb\nReviewed-on: https://chromium-review.googlesource.com/1036797\nCommit-Queue: Matt Mueller \u003cmattm@chromium.org\u003e\nReviewed-by: Eric Roman \u003ceroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#555213}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a313035c09374b24ac0a449b611543fe7b3182c6" }, { "commit": "34b2e31f39cd90dc558590e50913ccc71dd35707", "tree": "5f5de12665c7886ebe6af25117001d38c21473fd", "parents": [ "f6a3840faa50729c249614339ae4340b5497dfef" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Fri Apr 06 16:48:30 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 06 16:48:30 2018" }, "message": "Enable simultaneous requests in testserver.py proxy\n\ntestserver.py only supports one simultaneous request in basic auth proxy\nmode. This can lead to test timeouts when an unrelated request hogs the\nconnection. Use the SelectServer.ThreadingMixIn to switch to\nthread-per-connection semantics, allowing the server to support any\nnumber of requests up to the limit of filehandles or memory.\n\nThis CL only fixes the basic auth proxy mode. The http and https modes\nhave the same flaw, but are harder to fix because all the handlers have\nto be made threadsafe. However, requests in the http and https modes are\nexpected to be short-lived and there are no known problems caused by the\ndeficiency.\n\nBUG\u003d822614\n\nChange-Id: Ieb2e91613f15e51a11af93c8da7d639da298b9a6\nReviewed-on: https://chromium-review.googlesource.com/999276\nReviewed-by: Ian Clelland \u003ciclelland@chromium.org\u003e\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nCommit-Queue: Adam Rice \u003cricea@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548814}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4258b73b0bea431994d884d0751546b647f290c6" }, { "commit": "f6a3840faa50729c249614339ae4340b5497dfef", "tree": "2e6a8daadeab49ab988c62dc78deb7ce26bbe7cc", "parents": [ "7d28d3b9f8c23127ab5a0bc8913a2d62a748ff8b" ], "author": { "name": "Eric Roman", "email": "eroman@chromium.org", "time": "Wed Feb 14 20:19:53 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Feb 14 20:19:53 2018" }, "message": "Fix description of /echoheadercache max-age.\n\nChange-Id: I2bdb45952339bd8642154c03a12b441aaf5cfc59\nReviewed-on: https://chromium-review.googlesource.com/919186\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nCommit-Queue: Eric Roman \u003ceroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#536797}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 45a569906b7d8d3aa28d6bed17c1a475266323d0" }, { "commit": "7d28d3b9f8c23127ab5a0bc8913a2d62a748ff8b", "tree": "9b11ee7530e1f1ef599246757512eca9e59d8aef", "parents": [ "3bfd15d3231d7c9c3a9d7154c0444549d3bad95c" ], "author": { "name": "John Budorick", "email": "jbudorick@chromium.org", "time": "Sat Feb 10 00:53:10 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Feb 10 00:53:10 2018" }, "message": "Switch //build/print_python_deps.py to vpython. (RELAND)\n\nBug: 800662\nChange-Id: I3907c09c3b8898c0e487348735a8bb582ff9e468\nReviewed-on: https://chromium-review.googlesource.com/881466\nReviewed-by: Helen Li \u003cxunjieli@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: agrieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: John Budorick \u003cjbudorick@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#535905}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 47ca3fe45074c35b30670cfa4e1f4117a4c676c5" }, { "commit": "3bfd15d3231d7c9c3a9d7154c0444549d3bad95c", "tree": "eaea154649c99350397fd58126d536a4f323b181", "parents": [ "fdcd4b3ff6b91e277a13790e3e88a1115dce1c16" ], "author": { "name": "Ryan Sleevi", "email": "rsleevi@chromium.org", "time": "Tue Jan 23 21:12:24 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 23 21:12:24 2018" }, "message": "Remove Common Name Fallback code\n\nUse of the common name for matching the hostname is fundamentally\ninsecure, as it allows for the bypass of security controls within\ncertificates. Remove the remaining aspects of supporting logic that\nallow common name fallback, which were enabled by Enterprise Policy,\nnow that the Enterprise Policy has been removed.\n\nBUG: 804349\n\nCq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet\nChange-Id: I6e595f106b0d989935c9edc0d4c02e9a0f0f4584\nReviewed-on: https://chromium-review.googlesource.com/878901\nCommit-Queue: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Misha Efimov \u003cmef@chromium.org\u003e\nReviewed-by: Eric Roman \u003ceroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#531345}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: def35f6b91ebf7afcf90c4bbd8c0eacaf8876b81" }, { "commit": "fdcd4b3ff6b91e277a13790e3e88a1115dce1c16", "tree": "8239f9f92e6d2d3f911203bd1e099cd81cd5c172", "parents": [ "5cac4eb4e11f0fbdb384a2211091a09a65b6ecb1" ], "author": { "name": "Nick Harper", "email": "nharper@chromium.org", "time": "Tue Jan 23 19:59:28 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 23 19:59:28 2018" }, "message": "Fix presubmit error from pyftpdlib.ftpserver import\n\nChange-Id: Ic08885239a5a5c2a1da7475c033ab80aa6f49ed4\nReviewed-on: https://chromium-review.googlesource.com/879404\nReviewed-by: Steven Valdez \u003csvaldez@chromium.org\u003e\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: Nick Harper \u003cnharper@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#531317}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 48d11bca7c8fa940fdda1498e6dca7ff7088ad19" }, { "commit": "5cac4eb4e11f0fbdb384a2211091a09a65b6ecb1", "tree": "ee86449de042dd00b5228565ba226a1297294e85", "parents": [ "396f56dc8058f52412c4844991b032016b68dda9" ], "author": { "name": "John Budorick", "email": "jbudorick@chromium.org", "time": "Tue Jan 23 18:43:21 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 23 18:43:21 2018" }, "message": "Revert \"Switch //build/print_python_deps.py to vpython.\"\n\nThis reverts commit 889f9fb8b864ce17d892e377761483f215baf7b9.\n\nReason for revert: spec revert for android trybot failures\n\nOriginal change\u0027s description:\n\u003e Switch //build/print_python_deps.py to vpython.\n\u003e \n\u003e net/tools/testserver/testserver.py (which has a pydeps file) moved to\n\u003e vpython last week in\n\u003e https://chromium-review.googlesource.com/c/chromium/src/+/874153\n\u003e \n\u003e In order to successfully generate a pydeps file for\n\u003e it, print_python_deps.py needs to move to vpython as well.\n\u003e \n\u003e Bug: 800662\n\u003e Change-Id: I09b952f2fc73e4a8bb5e7e652846051eb24ed2ba\n\u003e Reviewed-on: https://chromium-review.googlesource.com/878929\n\u003e Reviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Reviewed-by: Helen Li \u003cxunjieli@chromium.org\u003e\n\u003e Reviewed-by: agrieve \u003cagrieve@chromium.org\u003e\n\u003e Commit-Queue: John Budorick \u003cjbudorick@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#531236}\n\nTBR\u003ddcheng@chromium.org,xunjieli@chromium.org,agrieve@chromium.org,jbudorick@chromium.org\n\nChange-Id: I060de4e867982af3e5bf085d09cc67e6eb5d1bdb\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 800662\nReviewed-on: https://chromium-review.googlesource.com/881705\nReviewed-by: John Budorick \u003cjbudorick@chromium.org\u003e\nCommit-Queue: John Budorick \u003cjbudorick@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#531289}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 537d74db4b393f0a90b09bd9d7dca1ea6321a1c0" }, { "commit": "396f56dc8058f52412c4844991b032016b68dda9", "tree": "4e1601e8e1690b8e8ea8c9f27ebd479eb5140b35", "parents": [ "0e7ec95d667b4e77005a3e1efd01210d998d8f54" ], "author": { "name": "John Budorick", "email": "jbudorick@chromium.org", "time": "Tue Jan 23 14:58:26 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 23 14:58:26 2018" }, "message": "Switch //build/print_python_deps.py to vpython.\n\nnet/tools/testserver/testserver.py (which has a pydeps file) moved to\nvpython last week in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/874153\n\nIn order to successfully generate a pydeps file for\nit, print_python_deps.py needs to move to vpython as well.\n\nBug: 800662\nChange-Id: I09b952f2fc73e4a8bb5e7e652846051eb24ed2ba\nReviewed-on: https://chromium-review.googlesource.com/878929\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Helen Li \u003cxunjieli@chromium.org\u003e\nReviewed-by: agrieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: John Budorick \u003cjbudorick@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#531236}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 889f9fb8b864ce17d892e377761483f215baf7b9" }, { "commit": "0e7ec95d667b4e77005a3e1efd01210d998d8f54", "tree": "ee86449de042dd00b5228565ba226a1297294e85", "parents": [ "8ccaaed00dfb54b5e467a9b60b966df4ad8fb1ff" ], "author": { "name": "Robert Iannucci", "email": "iannucci@chromium.org", "time": "Thu Jan 18 22:44:16 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 18 22:44:16 2018" }, "message": "[net/test] Update python_utils and local_test_server to use vpython.\n\nUse vpython to provide third_party dependencies for local test\nservers. This should make the test server run equivalently well on LUCI,\ndev machines and buildbot.\n\nAlso remove some unneeded tweaks from testserver.py too.\n\nR\u003dnednguyen@chromium.org, xunjieli@chromium.org\n\nBug: 800662\nChange-Id: I02797c1ab88436cb2a0ac0e87a4dad64608b5e7a\nReviewed-on: https://chromium-review.googlesource.com/874153\nCommit-Queue: Robbie Iannucci \u003ciannucci@chromium.org\u003e\nReviewed-by: Helen Li \u003cxunjieli@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#530316}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ecafcf2b5d2c80640585949938abe79359a7177f" }, { "commit": "8ccaaed00dfb54b5e467a9b60b966df4ad8fb1ff", "tree": "47d619877c26c75fdd886f60961c2685be90ae7c", "parents": [ "4c6304cfad66f2cdfeba0a0a2fa4426ad57f5ad8" ], "author": { "name": "Pavol Marko", "email": "pmarko@chromium.org", "time": "Thu Jan 04 17:40:04 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 04 21:45:09 2018" }, "message": "Properly propagate proxy auth details on sign-in screen (v2)\n\n(Reland with WebviewProxyAuthLoginTest browsertext fix)\nThis CL fixes sign-in behind an authenticated proxy. Two actual changes\nwere necessary in this context:\n- SigninPartitionManager: copy auth data from the system request\n context into new StoragePartitions\n This makes SigninPartitionManager::StartSigninSession async, which\n made small changes necessary in GaiaScreenHandler and\n EnrollmentScreenHandler\n- SigninScreenHandler: Don\u0027t reload gaia immediately when auth details\n have been supplied. This was unnecessary (the URL Request will\n continue) and actually harmful, as now that we\u0027re using a new\n StoragePartition for each sign-in attempt, this discards auth data\n before we can copy them.\n\nTo support the browsertest, testserver.py gets an argument to redirect\nCONNECT requests to localhost when proxying (in sign-in browsertests\nwithout proxy, we use RuleBasedHostResolverProc::AddRule to achieve\nthis effect).\n\n unit_tests --gtest_filter\u003dSigninPartitionManagerTest*\n Manual test:\n Setup:\n Setup an proxy server with Basic authentication\n Configure the device to use the proxy server.\n Make sure the user adding screen is shown.\n Test 1:\n Expect proxy auth dialog. Enter correct proxy auth data.\n Expect that sign-in screen is shown and sign-in works.\n Test 2:\n Expect proxy auth dialog. Enter incorrect proxy auth data.\n Expect that proxy-auth dialog is shown again.\n Test 3:\n Expect proxy auth dialog. Press Cancel.\n Expect that a network error dialog is shown.\n Press \"try to sign in again\".\n Expect proxy auth dialog. Enter correct proxy auth data.\n Expect that sign-in screen is shown and sign-in works.\n\nBug: 793524\nTest: browser_tests --gtest_filter\u003dWebviewProxyAuthLoginTest.* \u0026\u0026\nChange-Id: I56dafa240ad3bb5902517688a5cb17e309f2982d\nReviewed-on: https://chromium-review.googlesource.com/850472\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCommit-Queue: Pavol Marko \u003cpmarko@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#527103}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 569a169adf806513bc290572393ad4f845e119f8" }, { "commit": "4c6304cfad66f2cdfeba0a0a2fa4426ad57f5ad8", "tree": "b61e476f44a2e7ed6834c0deeadb7843a4c02abb", "parents": [ "0d85536062d3573f6bcecfd44dbe33834ac453ef" ], "author": { "name": "Dominic Battré", "email": "battre@chromium.org", "time": "Thu Jan 04 08:11:22 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 04 08:12:18 2018" }, "message": "Revert \"Properly propagate proxy auth details on sign-in screen\"\n\nThis reverts commit 14a0def082f8568c1423b9c14bee21070b86fb5a.\n\nReason for revert: Introduced flakiness in tests, see bug for details.\n\nOriginal change\u0027s description:\n\u003e Properly propagate proxy auth details on sign-in screen\n\u003e \n\u003e This CL fixes sign-in behind an authenticated proxy. Two actual changes\n\u003e were necessary in this context:\n\u003e - SigninPartitionManager: copy auth data from the system request\n\u003e context into new StoragePartitions\n\u003e This makes SigninPartitionManager::StartSigninSession async, which\n\u003e made small changes necessary in GaiaScreenHandler and\n\u003e EnrollmentScreenHandler\n\u003e - SigninScreenHandler: Don\u0027t reload gaia immediately when auth details\n\u003e have been supplied. This was unnecessary (the URL Request will\n\u003e continue) and actually harmful, as now that we\u0027re using a new\n\u003e StoragePartition for each sign-in attempt, this discards auth data\n\u003e before we can copy them.\n\u003e \n\u003e To support the browsertest, testserver.py gets an argument to redirect\n\u003e CONNECT requests to localhost when proxying (in sign-in browsertests\n\u003e without proxy, we use RuleBasedHostResolverProc::AddRule to achieve\n\u003e this effect).\n\u003e \n\u003e Bug: 793524\n\u003e Test: browser_tests --gtest_filter\u003dWebviewProxyAuthLoginTest.* \u0026\u0026\n\u003e unit_tests --gtest_filter\u003dSigninPartitionManagerTest*\n\u003e Manual test:\n\u003e Setup:\n\u003e Setup an proxy server with Basic authentication\n\u003e Configure the device to use the proxy server.\n\u003e Make sure the user adding screen is shown.\n\u003e Test 1:\n\u003e Expect proxy auth dialog. Enter correct proxy auth data.\n\u003e Expect that sign-in screen is shown and sign-in works.\n\u003e Test 2:\n\u003e Expect proxy auth dialog. Enter incorrect proxy auth data.\n\u003e Expect that proxy-auth dialog is shown again.\n\u003e Test 3:\n\u003e Expect proxy auth dialog. Press Cancel.\n\u003e Expect that a network error dialog is shown.\n\u003e Press \"try to sign in again\".\n\u003e Expect proxy auth dialog. Enter correct proxy auth data.\n\u003e Expect that sign-in screen is shown and sign-in works.\n\u003e \n\u003e Change-Id: I78b5988b5ca4c6eaaf4e6f9443e299499d6f0f08\n\u003e Reviewed-on: https://chromium-review.googlesource.com/837920\n\u003e Reviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\n\u003e Reviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\n\u003e Commit-Queue: Pavol Marko \u003cpmarko@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#526779}\n\nTBR\u003dxiyuan@chromium.org,davidben@chromium.org,mmenke@chromium.org,pmarko@chromium.org\n\nChange-Id: Id979177c1b59af3903ee09b092c38b6b0c215f43\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 793524\nReviewed-on: https://chromium-review.googlesource.com/848815\nReviewed-by: Dominic Battré \u003cbattre@chromium.org\u003e\nCommit-Queue: Dominic Battré \u003cbattre@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#526939}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4bc05f9327ab9b994ab4431d33f5d8661dbb8c9a" }, { "commit": "0d85536062d3573f6bcecfd44dbe33834ac453ef", "tree": "47d619877c26c75fdd886f60961c2685be90ae7c", "parents": [ "475a3f2269a1cb1f1d7c35c365140efb1d24da22" ], "author": { "name": "Pavol Marko", "email": "pmarko@chromium.org", "time": "Thu Dec 21 17:40:10 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 03 20:07:54 2018" }, "message": "Properly propagate proxy auth details on sign-in screen\n\nThis CL fixes sign-in behind an authenticated proxy. Two actual changes\nwere necessary in this context:\n- SigninPartitionManager: copy auth data from the system request\n context into new StoragePartitions\n This makes SigninPartitionManager::StartSigninSession async, which\n made small changes necessary in GaiaScreenHandler and\n EnrollmentScreenHandler\n- SigninScreenHandler: Don\u0027t reload gaia immediately when auth details\n have been supplied. This was unnecessary (the URL Request will\n continue) and actually harmful, as now that we\u0027re using a new\n StoragePartition for each sign-in attempt, this discards auth data\n before we can copy them.\n\nTo support the browsertest, testserver.py gets an argument to redirect\nCONNECT requests to localhost when proxying (in sign-in browsertests\nwithout proxy, we use RuleBasedHostResolverProc::AddRule to achieve\nthis effect).\n\nBug: 793524\nTest: browser_tests --gtest_filter\u003dWebviewProxyAuthLoginTest.* \u0026\u0026\n unit_tests --gtest_filter\u003dSigninPartitionManagerTest*\n Manual test:\n Setup:\n Setup an proxy server with Basic authentication\n Configure the device to use the proxy server.\n Make sure the user adding screen is shown.\n Test 1:\n Expect proxy auth dialog. Enter correct proxy auth data.\n Expect that sign-in screen is shown and sign-in works.\n Test 2:\n Expect proxy auth dialog. Enter incorrect proxy auth data.\n Expect that proxy-auth dialog is shown again.\n Test 3:\n Expect proxy auth dialog. Press Cancel.\n Expect that a network error dialog is shown.\n Press \"try to sign in again\".\n Expect proxy auth dialog. Enter correct proxy auth data.\n Expect that sign-in screen is shown and sign-in works.\n\nChange-Id: I78b5988b5ca4c6eaaf4e6f9443e299499d6f0f08\nReviewed-on: https://chromium-review.googlesource.com/837920\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCommit-Queue: Pavol Marko \u003cpmarko@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#526779}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 14a0def082f8568c1423b9c14bee21070b86fb5a" }, { "commit": "475a3f2269a1cb1f1d7c35c365140efb1d24da22", "tree": "b61e476f44a2e7ed6834c0deeadb7843a4c02abb", "parents": [ "1b6226519a6136d0e4077c76ecbcbe8ec1ab5340" ], "author": { "name": "Sergey Ulanov", "email": "sergeyu@chromium.org", "time": "Fri Dec 08 00:18:39 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 08 00:18:39 2017" }, "message": "Implement OCSP server support in RemoteTestServer.\n\nPreviously OCSP was broken with RemoteTestServer because OCSP server\nport wasn\u0027t proxied.\n 1. Updated testserver.py to accept --ocsp-proxy-port-number argument\n which makes it possible to generate correct cerificate for the\n proxied connection.\n 2. Updated chrome_test_server_spawner.py to forward oscp server port.\n 3. Updated RemtoeTestServer to proxy OCSP connection.\n 4. Enabled OCSP tests on Fuchsia where they were previously failing.\n\nBug: 776575, 792300\nChange-Id: Iedb1f5b26fc29ad0c73e78f450cd49335a424c18\nReviewed-on: https://chromium-review.googlesource.com/810096\nCommit-Queue: Sergey Ulanov \u003csergeyu@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Eric Roman \u003ceroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#522634}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ee7c8db6b554120fb28385f8759695048f1d8612" }, { "commit": "1b6226519a6136d0e4077c76ecbcbe8ec1ab5340", "tree": "09aee5cec32295dbcda87d02e0a177efe419cc7a", "parents": [ "0aca4f1cd394e8b1e003ad69e3fed6d4ba6407bc" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Tue Dec 05 23:57:33 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 05 23:57:33 2017" }, "message": "CRLSets: add ability to block by subject name.\n\nChange-Id: Ib33feac507cf37c9bd4351b3fede05ea9fea8806\nBug: none\nReviewed-on: https://chromium-review.googlesource.com/797678\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nReviewed-by: Ryan Sleevi \u003crsleevi@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#521906}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ea6d678a3f100bda9fdffbbd17443a2492f95ba3" }, { "commit": "0aca4f1cd394e8b1e003ad69e3fed6d4ba6407bc", "tree": "11de973182041fc4e9f7626a13b9da5b7249db90", "parents": [ "dd8b8eace8a0071a90ac6ee550cace622cdc427d" ], "author": { "name": "Paweł Hajdan, Jr", "email": "phajdan.jr@chromium.org", "time": "Mon Nov 13 16:24:51 2017" }, "committer": { "name": "Paweł Hajdan Jr.", "email": "phajdan.jr@chromium.org", "time": "Mon Nov 13 16:24:51 2017" }, "message": "Remove references to phajdan.jr\n\nBug: 783662\nCq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet\nChange-Id: If14081b9b17a3502435d2f2c4fcccfbbe51ae813\nReviewed-on: https://chromium-review.googlesource.com/763447\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#515954}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 064792ea9aa1864fad96841c7bffd206478b6b9e" }, { "commit": "dd8b8eace8a0071a90ac6ee550cace622cdc427d", "tree": "779113de79b2221e967a056583a12d094545ea91", "parents": [ "3f98d6712928cb23a4b5d044b7551080d1bb1d3f" ], "author": { "name": "Sergey Ulanov", "email": "sergeyu@chromium.org", "time": "Fri Sep 08 22:53:25 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 08 22:53:25 2017" }, "message": "Enable WebSocketEndToEndTests with RemoteTestServer\n\n1. Added ws server type in test server spawner.\n2. Fixed a bug in testserver.py which prevented it from loading certs\n with relative paths (because it has to chdir to the working dir)\n3. Enabled some tests on Android and Fuchsia. The two tests that are\n still disabled depend on basic-auth-proxy mode in testserver, which\n doesn\u0027t work with RemoteTestServer.\n\nBug: 441711, 731302\nChange-Id: Id8346111f260ead648a98b0854669d1211fe3393\nReviewed-on: https://chromium-review.googlesource.com/656758\nCommit-Queue: Sergey Ulanov \u003csergeyu@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Matt Menke \u003cmmenke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#500722}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4c786d33ad7886c8d656ded42b68b4d0746b6881" }, { "commit": "3f98d6712928cb23a4b5d044b7551080d1bb1d3f", "tree": "ea19586a828d4ecc3b95801ff504d76dd5a6d8b5", "parents": [ "df2e386b759de61d9caf4eda7ec1b8b413128200" ], "author": { "name": "Sergey Ulanov", "email": "sergeyu@google.com", "time": "Mon Aug 14 22:12:58 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Aug 14 22:12:58 2017" }, "message": "Remove host argument from SpawnedTestServer constructor.\n\nSpawnedTestServer previously took host parameter to specify host name\nfor the test server, but it always starts the server on localhost. All\ntests were passing kLocalhost (127.0.0.1) for that parameter. Removing\nthis parameter will allow to make this tests work on Fuchsia, where test\nserver will run on a different IP address.\n\nAlso cleaned up default values initialization in BaseTestServer and\nBaseTestServer::SSLOptions.\n\nBug: 731302\nChange-Id: Ibb1206fb34dc8707db6dc0451b96323699760121\nReviewed-on: https://chromium-review.googlesource.com/608725\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Paweł Hajdan Jr. \u003cphajdan.jr@chromium.org\u003e\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: Sergey Ulanov \u003csergeyu@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#494206}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9e8d6f32424a11a6e65681862d471277df4a4e5a" }, { "commit": "df2e386b759de61d9caf4eda7ec1b8b413128200", "tree": "2e04c5925cf16d3cf9458535ffc00c375eaf6191", "parents": [ "2ba42fe1f46360683efaa2c7e0911302113e3e17" ], "author": { "name": "davidben", "email": "davidben@chromium.org", "time": "Wed Apr 12 22:23:34 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 12 22:23:34 2017" }, "message": "Add a dedicated error code for TLS 1.3 interference.\n\nFrom the previous TLS 1.3 launch attempt, we learned that many\nfirewall, proxy, etc., products are buggy and interfere with TLS 1.3\u0027s\ndeployment, holding back a security and performance improvement across\nthe web.\n\nTo make diagnosing such issues easier, this CL implements a dedicated\nerror code based on a retry probe. On SSL connection failure, if TLS 1.3\nwas enabled and the error code is one of a handful which, in the past,\nhave potentially signaled version intolerance, we retry the connection\nwith TLS 1.3 disabled. If this connection succeeds, we still reject the\nconnection (otherwise a network attacker can break the security of the\nversion negotiation, cf. POODLE) and return\nERR_SSL_VERSION_INTERFERENCE.\n\nThis error code should hopefully give an easier target for search\nmetrics and others, as we otherwise cannot reliably classify\nindividual errors.\n\nUnfortunately, such a probe is inherently flaky and is itself not\nreliable. This error could mean one of three things:\n\n1. This is a transient network error that will be resolved when the user\n reloads.\n\n2. The server is buggy and does not implement TLS version negotiation\n correctly.\n\n3. The user is behind a buggy network middlebox, firewall, or proxy which is\n interfering with TLS 1.3.\n\nBased on server side probes, the lack of TLS 1.3 error reports until it\nwas enabled on the server, and a protocol change in TLS 1.3 intended to\navoid this, we do not believe (2) is common. (The difference between (2)\nand (3) is whether the servers or middleboxes are at fault here.)\n\n(1) is unavoidable. There is no way to reliably distinguish (1) and (3).\nWe can only make (1) less and less likely by spamming the user\u0027s network\nwith probes, which is undesirable.\n\nAccordingly, though the error string is short and easily searchable, I\nhave left the network error page fairly non-descript, borrowing from the\nERR_CONNECTION_FAILED text, but with SUGGEST_PROXY_CONFIG and friends\nenabled, to hint that users should, if their default reaction of mashing\nreload (or the auto-reload feature) doesn\u0027t work, look there.\n\nScreentshot:\nhttps://drive.google.com/open?id\u003d0B2ImyA6KAoPULVp3V0xPVEJHQms\n\nBUG\u003d694593,658863\nCQ_INCLUDE_TRYBOTS\u003dmaster.tryserver.chromium.linux:closure_compilation\n\nReview-Url: https://codereview.chromium.org/2800853008\nCr-Original-Commit-Position: refs/heads/master@{#464173}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 095ebb57de0053925c4900bace0458f38bf5e051\n" }, { "commit": "2ba42fe1f46360683efaa2c7e0911302113e3e17", "tree": "3276a445511b33fffb0454dc1a5c4000824e5c78", "parents": [ "a58a92dd2af00098cc7187d3111cd1eb5807b806" ], "author": { "name": "thakis", "email": "thakis@chromium.org", "time": "Tue Mar 21 23:05:44 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 21 23:05:44 2017" }, "message": "Remove checked-in .isolate files.\n\nIf anyone still needs them, please tell me about your use case\n(and feel free to revert).\n\nRan `git ls-files -- \u0027*.isolate\u0027 | xargs git rm`\n\nBUG\u003d703799\nNOTRY\u003dtrue\nTBR\u003djochen,davidben\n\nReview-Url: https://codereview.chromium.org/2766673003\nCr-Original-Commit-Position: refs/heads/master@{#458595}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f526c497b9eae3805d18f71c1cefdf88cfaf8ab5\n" }, { "commit": "a58a92dd2af00098cc7187d3111cd1eb5807b806", "tree": "e7fdf1b407f079707f61f4b5ddfdf1d60e3985fa", "parents": [ "0fc589b9e06b14ce998305fb31328b3c2f450250" ], "author": { "name": "rsleevi", "email": "rsleevi@chromium.org", "time": "Sat Mar 04 03:07:20 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Sat Mar 04 03:07:20 2017" }, "message": "Disable commonName matching for certificates\n\nMatching the commonName has been deprecated for\nnearly 20 years, as it\u0027s a fallback path for\ncertificates that don\u0027t have a subjectAltName.\n\nDisable the matching by default, but introduce an\nenterprise policy that allows it to be enabled for\ncertificates that chain to local trust anchors.\nThis policy is similar to the SHA-1 deprecation\npolicy, and is named\nEnableCommonNameFallbackForLocalAnchors.\n\nFor systems without enterprise policies (meaning\nthey aren\u0027t using SSLConfigManagerPref), the\ndefault is to keep the insecure behaviour, which\nis most compatible with legacy, but is not secure.\n\nBUG\u003d308330\n\nReview-Url: https://codereview.chromium.org/2719273002\nCr-Original-Commit-Position: refs/heads/master@{#454752}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0f9bfb00c432d594504502728b8a1405a0ff2cf1\n" }, { "commit": "0fc589b9e06b14ce998305fb31328b3c2f450250", "tree": "f2e8de30be1900892be72fa0c9069031a8f5e8f9", "parents": [ "c7c0c8b7d23daae335dea9ba9852dbe88779cb12" ], "author": { "name": "zpeng", "email": "zpeng@chromium.org", "time": "Wed Jan 11 17:55:12 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 11 17:55:12 2017" }, "message": "Fix conditional deps in net/tools/testserver/testserver.pydeps\n\nBUG\u003d672933\n\nReview-Url: https://codereview.chromium.org/2626933003\nCr-Original-Commit-Position: refs/heads/master@{#442951}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 35daf976f75515e7679affea5c30c0e1a9dd6108\n" }, { "commit": "c7c0c8b7d23daae335dea9ba9852dbe88779cb12", "tree": "22cecf27b55baf14536b572a34c51e8ff4ab80c5", "parents": [ "10ede849d5f6c2fe423e1bbc225a225077a25c3c" ], "author": { "name": "martijn", "email": "martijn@martijnc.be", "time": "Mon Jan 09 21:07:10 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 09 21:07:10 2017" }, "message": "Update testserver deps.\n\nBUG\u003d672933\n\nReview-Url: https://codereview.chromium.org/2614623005\nCr-Original-Commit-Position: refs/heads/master@{#442342}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0e8beab6c0537dc462b96204491ef96e66628881\n" }, { "commit": "10ede849d5f6c2fe423e1bbc225a225077a25c3c", "tree": "90bad6a08e1b10a656342d21042d222e3b12d077", "parents": [ "adace8efc837c98bb118011b906f15e0034b8468" ], "author": { "name": "mattm", "email": "mattm@chromium.org", "time": "Tue Nov 29 19:57:16 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 29 20:01:43 2016" }, "message": "Add unittests of HTTPS loading that requires AIA fetching.\n\nBUG\u003d651965\nNOPRESUBMIT\u003dtrue\n\nReview-Url: https://codereview.chromium.org/2388393002\nCr-Original-Commit-Position: refs/heads/master@{#435064}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0b12a6f86f1e390267e9234dac22337600634319\n" }, { "commit": "adace8efc837c98bb118011b906f15e0034b8468", "tree": "35b2a658e46e49da5d69afaec9ac36f0238b40bd", "parents": [ "fdd01b7dea1b60aeed4830519e9134c2e408204e" ], "author": { "name": "mattm", "email": "mattm@chromium.org", "time": "Mon Oct 03 21:07:15 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 03 21:10:54 2016" }, "message": "minica.py: don\u0027t encode default critical\u003dFalse values\n\nAlso add some helper code to make updating the ocsp-test-root easier.\n\nBUG\u003dnone\n\nReview-Url: https://codereview.chromium.org/2382423002\nCr-Original-Commit-Position: refs/heads/master@{#422529}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3b4376f1d53c435d13dbcc9330c824292a793b2a\n" }, { "commit": "fdd01b7dea1b60aeed4830519e9134c2e408204e", "tree": "bc8cf8d8dde05724fe9303a3d1bf1d3b59b01406", "parents": [ "5fb33bd1a01fc8cdaca6b40c022d2d4a55a6667c" ], "author": { "name": "fdoray", "email": "fdoray@chromium.org", "time": "Thu Aug 25 15:36:37 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Aug 25 15:38:22 2016" }, "message": "Remove calls to deprecated MessageLoop methods on Windows and Linux.\n\nThis Cl removes most calls to these methods on Windows and Linux:\n- MessageLoop::PostTask\n- MessageLoop::PostDelayedTask\n- MessageLoop::ReleaseSoon\n- MessageLoop::DeleteSoon\n- MessageLoop::Run\n- MessageLoop::RunUntilIdle\n\nAlso note that calls to thread-\u003emessage_loop()-\u003etask_runner() have\nbeen replaced with thread-\u003etask_runner() (|thread| is a base::Thread).\n\nThis CL was generated by running the clang-tidy checks available here\nhttps://crbug.com/616447#c153 on Windows and Mac and by applying a few\nmanual fixes (e.g. to remove a call made from a macro in\naudio_low_latency_input_win_unittest.cc).\n\nBUG\u003d616447\nCQ_INCLUDE_TRYBOTS\u003dmaster.tryserver.chromium.linux:linux_site_isolation\n\nReview-Url: https://codereview.chromium.org/2211473003\nCr-Original-Commit-Position: refs/heads/master@{#414442}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6ef45cf47455fb44e8fa0ab5d1ba545c91429941\n" }, { "commit": "5fb33bd1a01fc8cdaca6b40c022d2d4a55a6667c", "tree": "ddc5566e50f7575362c750645f46b84c2b75c0c0", "parents": [ "9a07cc959c631722f8122d83a9f58e06cc15670c" ], "author": { "name": "bnc", "email": "bnc@chromium.org", "time": "Fri Aug 05 19:09:21 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 05 19:11:41 2016" }, "message": "Implement ALPN in tlslite.\n\n* Update SSLClientSocketFalseStartTests to use ALPN.\n* Add SSLClientSocketTest test cases for ALPN.\n* Implement ALPN in tlslite.\n* Plumb ALPN through SpawnedTestServer.\n* Configure server ALPN for URLRequest tests so that\n connection does not fail.\n\nNote that the ALPN implementation introduced by this CL does not conform to the\nRFC: if there is no overlap between client and server supported protocols, ALPN\nis ignored, whereas the specification prescribes an Alert to be sent. This by\nthe way matches BoringSSL\u0027s implementation. Also, it is simpler for tests: most\nnet_unittests against tlslite do not worry about the actual protocol negotiated,\nand this way there is no need to configure the server ALPN list.\n\nBUG\u003d547867\n\nReview-Url: https://codereview.chromium.org/2205433002\nCr-Original-Commit-Position: refs/heads/master@{#410127}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b784c2f5e0e4041f2ccb4949c3a8b4c45a30b16c\n" }, { "commit": "9a07cc959c631722f8122d83a9f58e06cc15670c", "tree": "344222d0e68414ba64ac9c54153b9ad74aee8b46", "parents": [ "4ccf51c28fdef8ce9bba5a9f5706bb5c49e4f25d" ], "author": { "name": "dadrian", "email": "dadrian@google.com", "time": "Fri Jul 22 17:44:37 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 22 17:47:04 2016" }, "message": "Add more buffer time in HTTPSOCSPVerifyTests.\n\nThis leaves at least 1 day between the value of now() and thisUpdate/nextUpdate in OCSP responses generated by minica.py. This gives more wiggle room if there\u0027s a time differential between a test bot and a RemoteTestServer, and should help reduce HTTPSOCSPVerify test flakiness.\n\nThis also removes a reference to a non-existant variable in what should be an unreachable code path in minica.py.\n\nBUG\u003d630286\n\nReview-Url: https://codereview.chromium.org/2170643004\nCr-Original-Commit-Position: refs/heads/master@{#407192}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd\n" }, { "commit": "4ccf51c28fdef8ce9bba5a9f5706bb5c49e4f25d", "tree": "56bcdf2d1064e7fe266498020f2203548e73ac1f", "parents": [ "e758cd1082c83769dd0e8ce4a828e35b23947f2e" ], "author": { "name": "dadrian", "email": "dadrian@google.com", "time": "Wed Jul 20 22:36:58 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 20 22:38:54 2016" }, "message": "Extract OCSPCertStatus::Status to standalone OCSPRevocationStatus, and add OCSPVerifyResult for tracking stapled OCSP responses cross-platform. OCSPVerifyResult is populated by CertVerifyProc, but is currently unused. In the future, it will be consumed by Expect-Staple reports.\n\nThis CL also updates mini-CA and the spawned test server to be able to send a wider range of OCSP responses. Since OCSP responses are short lived, test the new functionality in url_request_unittest.cc and dynamically generate OCSP responses.\n\nBUG\u003d598021\n\nReview-Url: https://codereview.chromium.org/2100303002\nCr-Original-Commit-Position: refs/heads/master@{#406699}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 612337a1d7cadc52d0217b9f399eb1fab445d3e2\n" }, { "commit": "e758cd1082c83769dd0e8ce4a828e35b23947f2e", "tree": "66a7e7ae012bb5b5a05dd6ea0b971997b0f43119", "parents": [ "c020192b5f895a05154d63545ed2ad544ebf42fa" ], "author": { "name": "nharper", "email": "nharper@chromium.org", "time": "Thu Jul 14 00:49:36 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 14 00:52:19 2016" }, "message": "Update token binding code to latest drafts\n\n- TBPROTO was updated from -06 to -08; no technical changes (this is the\n version number that is sent over the wire for negotiation). In -04, the\n EC Point format for public key was clarified; this CL also fixes that\n format change.\n- TBNEGO was updated from -02 to -03; no technical changes.\n- HTTPSTB was updated from -03 to -05; the header name sent by the\n server signaling that the client should reveal the Token Binding ID\n used with the referrer.\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2137193002\nCr-Original-Commit-Position: refs/heads/master@{#405372}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 86f0be236649242ee6bd977a66fe06072a765252\n" }, { "commit": "c020192b5f895a05154d63545ed2ad544ebf42fa", "tree": "2e2c87c35346370d805ff01481841cc8c463beed", "parents": [ "33b4943f50f68d00e8c3eb568b444081425c2ac3" ], "author": { "name": "agrieve", "email": "agrieve@chromium.org", "time": "Tue Apr 26 19:18:19 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 26 19:19:18 2016" }, "message": "Fix net_unittests on Android swarming by adding testserver as a data_dep\n\nTBR\u003dphajdan.jr\nBUG\u003d589318\n\nReview URL: https://codereview.chromium.org/1914073002\n\nCr-Original-Commit-Position: refs/heads/master@{#389844}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 732db3a1bf9a8ef6a0f6263e84c706fd7cdadd08\n" }, { "commit": "33b4943f50f68d00e8c3eb568b444081425c2ac3", "tree": "da869a355aca6ed81a6e80866afabd5b5e40fe92", "parents": [ "cb1adc33cc967234873dc457cdcc5c9f36e8d489" ], "author": { "name": "danakj", "email": "danakj@chromium.org", "time": "Mon Apr 18 22:28:08 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 18 22:29:12 2016" }, "message": "Change scoped_ptr to std::unique_ptr in //net.\n\nR\u003deroman@chromium.org\nTBR\u003dbrettw\nBUG\u003d554298\n\nReview URL: https://codereview.chromium.org/1893083002\n\nCr-Original-Commit-Position: refs/heads/master@{#388050}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a9850e17ec8a7e5e754d2b804ea1a93ff2352310\n" }, { "commit": "cb1adc33cc967234873dc457cdcc5c9f36e8d489", "tree": "3454d3311e4e540a872d4a56847ac6550aec2bfc", "parents": [ "08eae82b2b6ebbb9e51af9910551914043b71bd5" ], "author": { "name": "nharper", "email": "nharper@chromium.org", "time": "Wed Mar 30 23:05:48 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Mar 30 23:07:26 2016" }, "message": "Implement referred Token Bindings\n\nAs described in https://tools.ietf.org/html/draft-ietf-tokbind-https-02: when\na server sends the \u0027Include-Referer-Token-Binding-ID\u0027 header on a redirect\nresponse, the client will include the TokenBindingID from the referrer in its\nrequest to the new location in the redirect. If either connection does not\nhave Token Binding enabled, then this has no effect.\n\nBUG\u003d467312\n\nReview URL: https://codereview.chromium.org/1781003003\n\nCr-Original-Commit-Position: refs/heads/master@{#384134}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d6e658265a6a3baa7cd7befecb24b12acb181047\n" }, { "commit": "08eae82b2b6ebbb9e51af9910551914043b71bd5", "tree": "8eec6d464f7dfab8487b04680d3cc52ea827c25e", "parents": [ "da238726a1b30ef4372182380458fd551c202ecd" ], "author": { "name": "nharper", "email": "nharper@chromium.org", "time": "Mon Jan 25 23:54:14 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 25 23:55:18 2016" }, "message": "Set Token-Binding HTTP header\n\nAdds a new method to SSLClientSocket to get the Token Binding from an SSL\nconnection where Token Binding was negotiated, and uses that to add the\nSet-Token-Binding HTTP header (only when Token Binding was negotiated).\n\nBUG\u003d467312\n\nReview URL: https://codereview.chromium.org/1378613004\n\nCr-Original-Commit-Position: refs/heads/master@{#371347}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b7441ef2effe86324798710a82d8a006f5eb1395\n" }, { "commit": "da238726a1b30ef4372182380458fd551c202ecd", "tree": "010265e75dd84a40c769f39f13a776c8cc7ef352", "parents": [ "c52318b43086b482f11cd951db71003a27f9047a" ], "author": { "name": "asanka", "email": "asanka@chromium.org", "time": "Fri Dec 04 03:53:08 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 04 03:54:05 2015" }, "message": "Stop using SpawnedTestServer in DownloadContentTest.*\n\nThis CL introduces TestDownloadRequestHandler, a URLRequestJob based\ninterceptor that can be used to mock URLRequest behavior. The new\nrequest handler supports simulating network and server errors, and is a\nreplacement for the testserver.py based test setup //content is\ncurrently using to test download resumption.\n\nMoving away from SpawnedTestServer allows us to re-enable the tests on\nAndroid.\n\nR\u003drdsmith@chromium.org,svaldez@chromium.org,sky@chromium.org\nBUG\u003d215894\nBUG\u003d493347\nBUG\u003d7648\n\nReview URL: https://codereview.chromium.org/1203983004\n\nCr-Original-Commit-Position: refs/heads/master@{#363108}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c7bf9bf1624d05928bbd4ee58d2c5e377fd6cd04\n" }, { "commit": "c52318b43086b482f11cd951db71003a27f9047a", "tree": "cd116a7622c35c4c152b1384975b65e7bc08cca4", "parents": [ "0f0e4492ae290f4ba29088c095875dfda785f87b" ], "author": { "name": "asanka", "email": "asanka@chromium.org", "time": "Wed Dec 02 19:32:05 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 02 19:33:02 2015" }, "message": "Use If-Range instead of If-Match/If-Unmodified-Since for partial requests.\n\nIf-Range can shortcut partial resumption requests by having the server\nrespond with the entire entity if there\u0027s a validator mismatch. This\ncuts down resumptions by one roundtrip.\n\nThe If-Range has been in use by HttpCacheTransaction successfully and it\nis not believed that availability of support is a concern.\n\nR\u003drdsmith@chromium.org,svaldez@chromium.org,mkearney@chromium.org,davidben@chromium.org,isherman@chromium.org\nBUG\u003d7648\n\nReview URL: https://codereview.chromium.org/1444253003\n\nCr-Original-Commit-Position: refs/heads/master@{#362771}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: eaa4e86fe7d9154bde31181108180480e1d603c1\n" }, { "commit": "0f0e4492ae290f4ba29088c095875dfda785f87b", "tree": "0e24524ca351729cf20f523af4b6aec7dfcdc3f4", "parents": [ "609ad4c1e1d45de6b32d3fe186875f2346b1bce6" ], "author": { "name": "stip", "email": "stip@chromium.org", "time": "Mon Oct 12 22:31:00 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 12 22:31:55 2015" }, "message": "Attempt to isolate net_unittests.\n\nBUG\u003d525873\n\nReview URL: https://codereview.chromium.org/1386753004\n\nCr-Original-Commit-Position: refs/heads/master@{#353613}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bf7e14892d510c1a7fcf09f7dcc3a185b10d288f\n" }, { "commit": "609ad4c1e1d45de6b32d3fe186875f2346b1bce6", "tree": "3d4dfad02a7aa09c73ee92502e7a4e1761aa9a33", "parents": [ "1e8bf4b02b3c45af64350265e2d79395f19d1b90" ], "author": { "name": "bnc", "email": "bnc@chromium.org", "time": "Fri Oct 02 12:11:24 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 02 12:12:08 2015" }, "message": "Add Next Protocol Negotiation (NPN) unittests.\n\n* Replace enable_npn with npn_protocols in testserver.\n* Update existing SSLClientSocket unittests to use the new option.\n* Add SSLClientSocket unittests to test NPN behavior.\n\nBUG\u003d103127\n\nReview URL: https://codereview.chromium.org/1372843004\n\nCr-Original-Commit-Position: refs/heads/master@{#352007}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c7d5389e077b13bd153302a645070f746f72c8b8\n" }, { "commit": "1e8bf4b02b3c45af64350265e2d79395f19d1b90", "tree": "b06a9aa6546c1bd34231182438493dd49f5e9fdb", "parents": [ "06a878352e758adca54cb19e1b572c64ba9d653c" ], "author": { "name": "nharper", "email": "nharper@chromium.org", "time": "Fri Sep 18 19:23:02 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 18 19:23:34 2015" }, "message": "Add flags to python test server for channel id, extended master secret, and token binding\n\nBUG\u003d467312\n\nCommitted: https://crrev.com/22e67634e17914c5dddc6ad2649a4bf701908311\nCr-Commit-Position: refs/heads/master@{#349164}\n\nReview URL: https://codereview.chromium.org/1347503002\n\nCr-Original-Commit-Position: refs/heads/master@{#349736}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 661ba7af493eee0eb89e4b7e4c8817edb20093f9\n" }, { "commit": "06a878352e758adca54cb19e1b572c64ba9d653c", "tree": "236037c7147737b3ffdc0ef87059919aaa9d69ff", "parents": [ "442e3dfbb9e1cee69ea46ff0a9131c0c5b65a2e2" ], "author": { "name": "tommycli", "email": "tommycli@chromium.org", "time": "Thu Sep 17 17:27:22 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 17 17:28:03 2015" }, "message": "Revert of Add flags to python test server for channel id, extended master secret, and token binding (patchset #2 id:20001 of https://codereview.chromium.org/1347503002/ )\n\nReason for revert:\nThis change tripped the Linux Tests (valgrind) memory bots.\n\nSee: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20(valgrind)(1)\n\nFirst failure:\nhttp://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/43655\n\nCause:\nNewly added member variables are not initialized in second constructor.\n\nThanks and sorry for revert.\n\nOriginal issue\u0027s description:\n\u003e Add flags to python test server for channel id, extended master secret, and token binding\n\u003e\n\u003e BUG\u003d467312\n\u003e\n\u003e Committed: https://crrev.com/22e67634e17914c5dddc6ad2649a4bf701908311\n\u003e Cr-Commit-Position: refs/heads/master@{#349164}\n\nTBR\u003ddavidben@chromium.org,rsleevi@chromium.org,nharper@chromium.org\nNOPRESUBMIT\u003dtrue\nNOTREECHECKS\u003dtrue\nNOTRY\u003dtrue\nBUG\u003d467312\n\nReview URL: https://codereview.chromium.org/1351133002\n\nCr-Original-Commit-Position: refs/heads/master@{#349439}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 13f982af192e9fecd145500670198adc515d4429\n" }, { "commit": "442e3dfbb9e1cee69ea46ff0a9131c0c5b65a2e2", "tree": "b06a9aa6546c1bd34231182438493dd49f5e9fdb", "parents": [ "fd4f044f680696d78847d08bc27225b0ef40d30b" ], "author": { "name": "nharper", "email": "nharper@chromium.org", "time": "Wed Sep 16 18:25:47 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 16 18:26:43 2015" }, "message": "Add flags to python test server for channel id, extended master secret, and token binding\n\nBUG\u003d467312\n\nReview URL: https://codereview.chromium.org/1347503002\n\nCr-Original-Commit-Position: refs/heads/master@{#349164}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 22e67634e17914c5dddc6ad2649a4bf701908311\n" }, { "commit": "fd4f044f680696d78847d08bc27225b0ef40d30b", "tree": "236037c7147737b3ffdc0ef87059919aaa9d69ff", "parents": [ "9135cb99364c9593091cf555ecf827f89ce370e9" ], "author": { "name": "pneubeck", "email": "pneubeck@chromium.org", "time": "Fri Aug 07 11:55:10 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 07 11:55:50 2015" }, "message": "net/testserver.py: Add handler to reply with client auth status.\n\nBUG\u003d514575\n\nReview URL: https://codereview.chromium.org/1275853003\n\nCr-Original-Commit-Position: refs/heads/master@{#342337}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1300c883029570b4ab83ac12e340e9500e54c7e3\n" }, { "commit": "9135cb99364c9593091cf555ecf827f89ce370e9", "tree": "ce1b6f9d456022e35a111d5c6424538b1b154859", "parents": [ "fbb89ed5d45317488b35c7eefc608aec542b506e" ], "author": { "name": "twifkak", "email": "twifkak@chromium.org", "time": "Thu Jul 30 08:41:25 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 30 08:41:58 2015" }, "message": "Fix typos in testserver docstrings.\n\n5 seconds -\u003e 3 seconds, per the implementation.\n\nBUG\u003d\n\nReview URL: https://codereview.chromium.org/1259373002\n\nCr-Original-Commit-Position: refs/heads/master@{#341088}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5d5904de807c53484ef337d3f512a8de116bc91d\n" }, { "commit": "fbb89ed5d45317488b35c7eefc608aec542b506e", "tree": "bc47db49c18f5d0f76ff0016815987f90992987b", "parents": [ "1447b17f36c284021627dae110695adbdce68940" ], "author": { "name": "asanka", "email": "asanka@chromium.org", "time": "Thu Jul 09 23:46:49 2015" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 09 23:48:34 2015" }, "message": "Migrate chrome/../download_browsertests away from SpawnedTestServer\n\nThis removes the dependency on SpawnedTestServer from all but the\nreferrer policy tests. Changing the referrer policy tests to use a\nURLRequestMockHttpJob involves changing tests other than\ndownload_browsertests. So it will be done in a separate CL.\n\nR\u003drdsmith@chromium.org\nBUG\u003d493347\n\nReview URL: https://codereview.chromium.org/1194593003\n\nCr-Original-Commit-Position: refs/heads/master@{#338187}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e486ebffa0d570c4a162989e73311454f01c0add\n" } ], "next": "1447b17f36c284021627dae110695adbdce68940" }