)]}' { "log": [ { "commit": "1c3cccd020a2f22250e31ec76773c6a8eb13b4e4", "tree": "662a20d1601886de53dc6411edeb84646b3615f1", "parents": [ "1c7411780a14d1bfd21529e9e7ea3054de9cd227" ], "author": { "name": "Eldar Pulatov", "email": "epulatov.dev@gmail.com", "time": "Fri Aug 28 15:15:05 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 28 15:24:18 2026" }, "message": "[Zucchini] Modernize fuzzer seed generation\n\nThe seed scripts still use Python 2-style in some places and write\nintermediate patches to caller-provided paths. Failures can leave\nthose patches behind, and the encoding and cleanup paths lack tests.\n\nMove the scripts to Python 3, keep patches in temporary directories, and\nwrite seeds atomically. Use protobuf text-format escaping for arbitrary\nbinary input while preserving existing seed flow.\n\nTrack imports with action_with_pydeps and stop generating unused Python\nprotobuf bindings. Add unit test coverage for encoding and cleanup. Also\ninclude the ELF disassembler in the aggregate fuzzer target.\n\nFixed: 544163130\nChange-Id: I182cd71045843a1da88b9d3345cb84e6af596ae7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8225748\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Calder Kitagawa \u003cckitagawa@chromium.org\u003e\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Calder Kitagawa \u003cckitagawa@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1688024}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5962e4e9c990af9cbdfb197533992011106245cb\n" }, { "commit": "1c7411780a14d1bfd21529e9e7ea3054de9cd227", "tree": "997d0c572fc6c18d01b636419f36cc331cc52960", "parents": [ "861eb0ab3fdc0176df3b4a9efd3c502cb92fbaac" ], "author": { "name": "Eldar Pulatov", "email": "epulatov.dev@gmail.com", "time": "Wed Aug 05 06:16:15 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 05 06:20:33 2026" }, "message": "[Zucchini] Suppress INFO logs during fuzzer seed generation\n\nThe fuzzer seed actions inherit Zucchini\u0027s output streams. Zucchini logs\nprogress and resource usage at INFO severity. These messages appear in\nautoninja output even when seed generation succeeds.\n\nRun Zucchini with --v\u003d-1 when generating patches. It filters routine\nINFO logs but leaves warnings and errors visible.\n\nFixed: 542789919\nTest: Built components/zucchini/fuzzers:zucchini_raw_apply_seed.\nTest: Built components/zucchini/fuzzers:zucchini_ztf_apply_seed.\nBug: 542789919\nChange-Id: Ib1845e534d765e4dabb8e3c4c41e92d5845e98a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8198745\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Fumitoshi Ukai \u003cukai@google.com\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1673921}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 890e32b1a87a9bc4f0c929d666a58bde0052c2c0\n" }, { "commit": "861eb0ab3fdc0176df3b4a9efd3c502cb92fbaac", "tree": "d8bfa1a1cf9584ff68c4379c7cb039558d4df6bf", "parents": [ "b135caaf359251ff5f314e77f5ffcf94cdd76f1c" ], "author": { "name": "Eldar Pulatov", "email": "epulatov.dev@gmail.com", "time": "Thu Jul 23 15:16:49 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 23 15:20:39 2026" }, "message": "[Zucchini] Avoid deadlock in fuzzer seed generation\n\ngenerate_fuzzer_data.py redirects Zucchini\u0027s stdout and stderr to\nsubprocess.PIPE, then waits with subprocess.call() without reading\neither pipe. Under system pipe pressure, Zucchini can fill a pipe and\nblock in write() while Python waits for it to exit. This can block\nthe raw and ZTF apply seed actions and, consequently, the all target.\n\nUse subprocess.run() for both child processes and allow Zucchini to\ninherit the action\u0027s output streams. This avoids private unread pipes,\nmakes diagnostics available to the build, and keeps the existing\nreturn-code behavior.\n\nTest: Built components/zucchini/fuzzers:zucchini_ztf_apply_seed.\nTest: Built components/zucchini/fuzzers:zucchini_raw_apply_seed.\nChange-Id: Ica6a666fcc9f23d2b3d59333090ea732f6b162a5\nFixed: 534823414\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8092874\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1667112}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cea6ffadfc953c561f4b001d4cad030047a70042\n" }, { "commit": "b135caaf359251ff5f314e77f5ffcf94cdd76f1c", "tree": "2617f0abd35afad9e08203a893f3a4e00d87bee3", "parents": [ "d2d79f01f9db854ef41aafb93a5110db43472cc9" ], "author": { "name": "Jose Arturo Barrera", "email": "jabgonzalez@google.com", "time": "Tue Jun 30 15:57:17 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 30 15:59:17 2026" }, "message": "[MiraclePtr] Rewrite templated container fields to raw_ptr\n\nAutomates the conversion of raw pointers within templated containers\n(e.g., `std::vector`, `std::set`) to `raw_ptr` via the\n`rewrite_templated_container_fields` tool, alongside necessary\nmanual build fixes.\n\nThis advances MiraclePtr\u0027s expansion to containers and preempts an\nupcoming clang-plugin update that will strictly ban these un-rewritten\ninstances.\n\nBug: 501142609\nDoc: go/miracleptr-in-containers\nChange-Id: Idfd96ea4760418dbdf1c2f13ab07e5e39cab7ab9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7952068\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: José Arturo Barrera \u003cjabgonzalez@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1654796}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4cf2cdb0fee13205c5c6021b1a5ba4e0727f7019\n" }, { "commit": "d2d79f01f9db854ef41aafb93a5110db43472cc9", "tree": "2382bac05e1376ad9daf204b648879b3a9e8fb75", "parents": [ "2cb46fcb8bb316ae8c972a12c6d8d18870b72cb0" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Mon Jun 29 09:46:42 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 29 09:50:04 2026" }, "message": "Use span-based MemoryMappedFileAPI in zucchini integration test\n\nBug: 435317390\nChange-Id: I12c490a000426929afd8a43159e0c78ca4e33b63\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8009102\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nCommit-Queue: Jan Keitel \u003cjkeitel@google.com\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1653941}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: aaa8804569bb3aab3e1d286576bc06a655e03366\n" }, { "commit": "2cb46fcb8bb316ae8c972a12c6d8d18870b72cb0", "tree": "7957ce0e92ebc380233be9c023d1d41274ee0dd5", "parents": [ "e9357a38e520fe563b071f5671bcfa54c86ca4b8" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Fri Jun 12 16:30:44 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 12 16:33:39 2026" }, "message": "Use span-based MemoryMappedFile API in //components/zucchini\n\nTo achieve this, make BufferViewBase (which is essentially a\nbase::span and should maybe be replaced in favor of it) constructible\nfrom base::span.\n\nNo (intentional) functionality changes.\n\nBug: 435317390\nChange-Id: I5217c5272024419ac817770192e52539252d1a3e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7531543\nCommit-Queue: Jan Keitel \u003cjkeitel@google.com\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1646015}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 539666d8a6e189fed8cb3c013e72925862c7bf58\n" }, { "commit": "e9357a38e520fe563b071f5671bcfa54c86ca4b8", "tree": "056d8eb016e0e791d6dee2ae7186fbfa74c36abd", "parents": [ "cbaf8fd6f743797114f2202c686a4ec11fada869" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Thu Jun 11 08:23:23 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 11 08:26:31 2026" }, "message": "zucchini: Fix remote execution for generate_fuzzer_data.py\n\nRemove components/zucchini/fuzzers/generate_fuzzer_data.py from Siso\nremote execution denylist. Also add file_pair.proto to sources of\nzucchini_raw_apply_seed and zucchini_ztf_apply_seed actions to fix\nmissing input error on RBE.\n\nBug: 513105742\nChange-Id: I52086f44dc0a04c4f003840a836c6649399b7760\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7925346\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Junji Watanabe \u003cjwata@google.com\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Junji Watanabe \u003cjwata@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1645177}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a18235a504331d5495b25eef2db0eeea2012fc20\n" }, { "commit": "cbaf8fd6f743797114f2202c686a4ec11fada869", "tree": "1003cecc0316364a5aaa89ebf8e43e1794199750", "parents": [ "bd5bf09989b8c8947f007a760b9bcfbfc6d98e34" ], "author": { "name": "Francisco Ochoa", "email": "frankchavez@google.com", "time": "Fri May 22 20:28:10 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 22 20:29:39 2026" }, "message": "Spanification of components/zucchini/io_utils.h, etc.\n\nThis is the result of running the automatic spanification on linux\nand updating code to use and pass spans where size is known.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms\u003dlinux\nThen refined with gemini-cli and at last manually refined\n\nGemini-CLI auto-fixes for compilation\n\nBug: 505042664\nChange-Id: I7c46befc1694064fd085c70958d847e26a5a314a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7849823\nCommit-Queue: Francisco Ochoa \u003cfrankchavez@google.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1635179}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2a4ab5ae3bd0d45269a0317383b0a42c1b007c99\n" }, { "commit": "bd5bf09989b8c8947f007a760b9bcfbfc6d98e34", "tree": "6acc22f817ecdf452a3c51c1a08e67194ad3e97e", "parents": [ "3e9c102bdc301fdc84b7464e58b953ab5c6f75a1" ], "author": { "name": "Matt Stark", "email": "msta@google.com", "time": "Tue May 19 07:55:08 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 19 07:57:43 2026" }, "message": "Run `gn format` on all BUILD.gn files.\n\nNO_IFTTT\u003dFormatting change only\n\nLink: https://chromium-review.googlesource.com/id/I94ec311d69c76b9f85351c08b4d3bd216a6a6964\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7858711\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nOwners-Override: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Matt Stark \u003cmsta@google.com\u003e\nSLSA-Policy-Verified: SLSA Policy Verification Service \u003cdevtools-gerritcodereview-exitgate@google.com\u003e\nReviewed-by: Junji Watanabe \u003cjwata@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1632679}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ad14f9bebfdee678ba25da9430c2d5c3b00d6a11\n" }, { "commit": "3e9c102bdc301fdc84b7464e58b953ab5c6f75a1", "tree": "c1ce53ea987f983c5dbf80754388449ac66228b3", "parents": [ "da0101336ee6e4e76852613e9ccbb3a44bc7bddb" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Wed Apr 29 07:33:30 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 29 07:36:34 2026" }, "message": "[lzma_sdk] Migrate to the required directory structure\n\n- Move the 7zS2_source source_set from C/Util/SfxSetup/BUILD.gn into the\n main BUILD.gn for lzma_sdk.\n- Move the Asm/ and C/ directories into src/ and update references\n accordingly.\n- Add src/DOC/lzma-sdk.txt, which contains the license.\n- Convert all files in src/ to UNIX-style LF line endings.\n- Replace chromium.patch with individual .patch files in patches/.\n- Add patch application instructions to README.chromium.\n\nThis is one step along the way to enabling automated updates.\n\nBug: 502791322\nChange-Id: Ic9b52dbfd1b0bc4c7dfa39d92b328454f4601100\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7796897\nReviewed-by: S Ganesh \u003cganesh@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1622269}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 18839ecffc60be1575f339cb2a3356c854224b89\n" }, { "commit": "da0101336ee6e4e76852613e9ccbb3a44bc7bddb", "tree": "5d996076b1aae7da9bc8a9dabeb41b003f18f2ee", "parents": [ "37d2fe2da78c2c1880230260b24725b9083010b2" ], "author": { "name": "Thomas Zander", "email": "thomasalpinus@google.com", "time": "Tue Apr 28 16:48:24 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 28 16:50:09 2026" }, "message": "[zucchini] Add LICENSE file\n\nSince zucchini lives in its own component repository, it should carry\nits own copy of the LICENSE file.\n\nBug: 507069612\nChange-Id: I641c15a7828ce30c12a810dbb9e94c0e7961d4ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7793394\nCommit-Queue: Thomas Zander \u003cthomasalpinus@google.com\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1621842}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1b2e9f290a2906c817242fde19cef7781e5d493a\n" }, { "commit": "37d2fe2da78c2c1880230260b24725b9083010b2", "tree": "464eb41b684be37719d73d7288beaeba8c9c92cb", "parents": [ "7e13b9f7d7bf7b3b3a76022e21323a9ee867a3f2" ], "author": { "name": "Edgar Aguilar", "email": "eledgar@google.com", "time": "Tue Apr 28 10:13:26 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 28 10:16:27 2026" }, "message": "Update fuzzers for Android\n\nMove environment initialization so it is handled correctly from\nan APK execution. Due to how the jvm initializes variables if\nthe environment is defined outside LLVMFuzzer initialization\nit crashes.\n\nUpdating fuzzers in components/zucchini\n\nThis CL was uploaded by git cl split.\n\nBug: 500525162\nChange-Id: I0e895395745dda427f2d000e116df26fac43bff1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7798120\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nAuto-Submit: Edgar Aguilar \u003celedgar@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1621639}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fc391dde06dd51193d8478599adad3c852d37b53\n" }, { "commit": "7e13b9f7d7bf7b3b3a76022e21323a9ee867a3f2", "tree": "7a0d74a02986c535e46bf8849e07d98096a702f2", "parents": [ "91c92cb52cd2dfbe8c95e6edf1782f37e0129091" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Fri Apr 17 06:24:24 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 17 06:27:21 2026" }, "message": "Checked Span: Verify overrun before minting span\n\nSome manually constructed zucchini spans show slot overruns when Checked\nSpan is enabled. This is likely not a real issue because later\nvalidation code doesn\u0027t attempt to _read_ over the slot boundary.\n\nNevertheless --- this presents an obstacle to enabling Checked Span, in\nwhich case you are forbidden from constructing across a slot boundary.\nTo solve, do the calculations (\"do we have enough bytes to constitute\na struct of this type\") before actually minting the span.\n\nIdeally, we should be more aggressively spanifying this entire\ndirectory, but as the comment documenting `BufferViewBase::iterator`\ndescribes, this will take some investment (I gave up after about fifteen\nminutes, worried that the work would be unbounded and would end up\nblocking Checked Span).\n\nThe somewhat tortured arithmetic is necessary to avoid tripping the\nwarning (error) about unsafe pointer arithmetic.\n\nBug: 501113358\nChange-Id: Ia07356b142b0bff2d6f072fda777e45a21706ff3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7768171\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Kalvin Lee \u003ckdlee@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1616352}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3e69572d8dfb7d522f49b2c75511fadd482f1a4d\n" }, { "commit": "91c92cb52cd2dfbe8c95e6edf1782f37e0129091", "tree": "aa776b7c1f854a9a53589566d5b66b7bcd43d088", "parents": [ "a06a2337e6a6f71617576f368eb7e2e503820668" ], "author": { "name": "Will Harris", "email": "wfh@chromium.org", "time": "Thu Apr 09 17:46:23 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 09 17:50:02 2026" }, "message": "Configure Zucchini to use the system allocator\n\nZucchini uses a lot of memory, in particular when creating diffs for\nvery large files.\n\nPartition alloc, by default, blocks allocations greater than 2GiB in\nsize but the system allocator is able to handle these larger\nallocations.\n\nA \u0027copy\u0027 build step is added to make sure the binary (zucchini.exe or\nzucchini64.exe) and the symbols end up in the same directory as before\nso no scripts will need updating.\n\nBUG\u003d498512075\n\nChange-Id: I653a0723cc469f56768a55e55fe4829d37404f86\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7728046\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1612340}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9207fcd6e06063e8605ba433ad03214eb577cae\n" }, { "commit": "a06a2337e6a6f71617576f368eb7e2e503820668", "tree": "b00ce19a0821d5fb451b28bff1372b207bc75377", "parents": [ "2df92bcd68befa769b99aae7465dd9980f543881" ], "author": { "name": "Yuki Shiino", "email": "yukishiino@chromium.org", "time": "Fri Jan 30 08:27:38 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 30 08:33:11 2026" }, "message": "zucchini: Make BufferViewBase use base::span for safety\n\nThe basic features of zucchini::BufferViewBase are the same as\nones of base::span. And we shouldn\u0027t re-invent the wheel here.\n\nThis patch makes BufferViewBase has a base::span as the data\nmember so that most security checks will be done by base::span,\nbut this patch also tries keeping BufferViewBase backward-\ncompatible as much as possible so that the changes on call\nsites will be minimum (e.g. BufferViewBase::iterator is just a\npointer and not base::span::iterator i.e.\nCheckedContiguousIterator just to be backward-compatible).\n\nBug: 439964610\nChange-Id: Ia65aa0836a19ade6293f6fead9770f373f9fab5b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7495871\nReviewed-by: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCommit-Queue: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1577091}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b6d7ef83413a12ae676856acd715ddf8b43d97d4\n" }, { "commit": "2df92bcd68befa769b99aae7465dd9980f543881", "tree": "f99e84fdb726d9d7646599efeda0a13abadd6a3c", "parents": [ "95902cf59001616eb410f3ab4bcf45aa72a7d09a" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Jan 21 20:00:43 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 21 20:07:05 2026" }, "message": "[Zucchini] For ELF files, skip NOBITS sections that have offset \u003d 0.\n\nThis CL is a a refinement to senj@\u0027s CL crrev.com/c/7478314, to fix the\nproblem of ODEX (ELF) files not being recognized by Zucchini.\n\nIn ELF files, .bss would have allocated memory ranges beyond actual\nbytes on disk. Typically, its offset \u003d\u003e RVA mapping, i.e.,\n\n [sh_offset, sh_offset + sh_size) \u003d\u003e [sh_addr, sh_addr + sh_size)\n\nwould agree with (i.e., no incompatible overlap) mappsings in other\nsections.\n\nHowever, senj@ found ODEX files (generated by dex2oat) with nontrivial\nNO_BITS section (.bss and .dex) that have sh_offset \u003d 0, but with\ndifferent sh_addr values. The clash between these sections caused the\nELF files to be rejected, and Zucchini to become less efficient.\n\nTo fix this while still benefiting from non-clashing .bss, this CL adds\na special case to label NO_BITS sections with sh_offset \u003d 0 as useless.\n\nBug: 476204534\nChange-Id: I1dc43a8dadc64c3b75a6676e6138e349128ddb4c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486955\nReviewed-by: Calder Kitagawa \u003cckitagawa@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1572491}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bf2e333a6d723fb5142ec59b069638207e603765\n" }, { "commit": "95902cf59001616eb410f3ab4bcf45aa72a7d09a", "tree": "cefde86d5f63f1212a66a98f5777b399ff77c45f", "parents": [ "028985b1c77f70013b16613991626f059f29d97d" ], "author": { "name": "Jeffrey Yu", "email": "yuje@chromium.org", "time": "Tue Jan 13 20:37:03 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 13 20:42:18 2026" }, "message": "Avoid duplicate map lookups.\n\nInstead of using `.count(key)` followed by a lookup, use `.find(key)`,\nand reuse the iterator to access the value.\n\nBug: 452950815\nChange-Id: I67774bf39121b215ae7d35f42b4a5dc0ce06ec79\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7457852\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Jeffrey Yu \u003cyuje@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1568635}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ea2cfeca2714b3f1e8e92ad837e5c372ebbfaf20\n" }, { "commit": "028985b1c77f70013b16613991626f059f29d97d", "tree": "6975675b2decee3273b2e9a408bceb00ffc4af9d", "parents": [ "06486c6b6fdee6453fb5dffb24b4161fdaad7637" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Thu Jan 08 16:58:53 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 08 17:07:02 2026" }, "message": "Explicitly ignore result of peek()\n\nBug: 468205004\nChange-Id: Iaa131f1552c62c0a0519947d38ca4b7f1562fbc2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7411662\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Hans Wennborg \u003chans@chromium.org\u003e\nCommit-Queue: Hans Wennborg \u003chans@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1566345}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 64e05a10e724576426c78c4cc60914d77e7185e9\n" }, { "commit": "06486c6b6fdee6453fb5dffb24b4161fdaad7637", "tree": "a8fa039c18b302b672259bda023f82123ea3d8c5", "parents": [ "04d1de6cfabf8d868985ee88b89420250b028486" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Jan 07 20:57:39 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 07 21:05:56 2026" }, "message": "[Zucchini] Fix bad ELF reloc Reference extraction from overlapping sections.\n\nRecent fuzzing found an input that fails ReferenceSet::InitReferences()\ncheck that asserts extracted references are sorted by location. This was\ncaused by the input ELF file having two identical reloc sections.\nExisting ELF disassembler accepted the duplicates (and in general,\noverlapping reloc sections). This then caused RelocReaderElf::GetNext()\nto revisit memory addresses, resulting in non-sorted references.\n\nThis CL fixes the issue by \"resolving\" ELF reloc sections when multiples\nare found. Since duplicates / overlaps are pathological cases, so we\nsimply resolve visit reloc sections sorted by (starting offset, size),\nand reject reloc sections that are empty (for robustness) or overlap\nwith previously accepted ones. Details:\n* SectionDimensionsElf:\n * Add static ResolveOverlaps() to implement in-place greedy overlap\n removal of a given sorted list of SectionDimensionsElf.\n * operator\u003c(): For consistency, add tiebreaker so that when two\n instances have the same |offset|, sort by *decreasing* size (as\n micro-optimization, in case, e.g., (100, +20) and (100, +40) both\n exist, we\u0027d keep (100, +40) since it would appear first).\n* DisassemblerElf\u003cTRAITS\u003e::ExtractInterestingSectionHeaders(): After\n creating and sorting |reloc_section_dims_|, apply ResolveOverlaps()\n to it to remove duplicates and overlaps.\n\nTesting:\n* BufferRegion: Add default operator\u003d\u003d().\n* SectionDimensionsElf: Add default operator\u003d\u003d(); add alternative CTOR\n to directly assign values (alongside existing one, which takes an\n Elf_Shdr instance).\n* Add RelocElfTest.ResolveOverlaps.\n\nBug: 472846382\nChange-Id: Ifc4dcd0b84af3f59157a54c73972493c4974a100\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7370364\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1565877}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 40d5756130f1db8871fff92735235b1f627a0cf7\n" }, { "commit": "04d1de6cfabf8d868985ee88b89420250b028486", "tree": "3c823a998941fda7c3cb126e3715c9e98c8f8527", "parents": [ "b52224b970ea5285af41ebd701254922ddf2ac1e" ], "author": { "name": "James Decker", "email": "deckerjames@google.com", "time": "Thu Dec 04 23:03:28 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 04 23:09:36 2025" }, "message": "[Zucchini] Fix missing zucchini headers\n\nI also took the opportunity to fix the header order in a few cases.\n\nBug: 418307002\nChange-Id: I29e2f945bc195cbcd7a67618eb7ff6cc4b0db23c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6599298\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: James Decker \u003cdeckerjames@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1554321}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bed26c27c1ecede61dd60843da75e2388c3c5e15\n" }, { "commit": "b52224b970ea5285af41ebd701254922ddf2ac1e", "tree": "8ddb80b3767d32fc25df7022426aa0d96e7a4146", "parents": [ "e0e3ccc1e08bf6b7704580b04477441fd0d97eb4" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Dec 04 16:17:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 04 16:22:49 2025" }, "message": "Convert to UNSAFE_TODO in components [4/4]\n\nThis is an automated #cleanup patch using the [Script] below.\n\nWe are migrating from coarse-grained file-level suppression (#pragma\nallow_unsafe_buffers) to granular, expression-level markers\n(UNSAFE_TODO()). The pragma disables safety checks for an entire file,\nwhereas UNSAFE_TODO() isolates specific potentially unsafe operations,\nallowing the rest of the file to be enforced as safe.\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nR\u003dblundell@chromium.org\n\nScript: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp\u003dsharing\nAX-Relnotes: N/A\nCleanup: This is an automated #cleanup.\nBug: 409340989\nChange-Id: Iad51751a2a902ce9674ac83f2850bec67170d3ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224152\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1554044}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 298ad89210081e23b484fffb027fbe1c1189a054\n" }, { "commit": "e0e3ccc1e08bf6b7704580b04477441fd0d97eb4", "tree": "6fa5ffc5ae19afde3f20fb31ee89e3eb23cce283", "parents": [ "95c22484ce8077e52b962e17707ed44f3dd8f82d" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Dec 03 20:53:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 03 20:59:06 2025" }, "message": "[Zucchini] Fix PatchUtilsTest integer overflow.\n\nThe PatchUtilsTest.EncodeDecodeVar{U}Int(32,64} tests each takes a list\nof \"center\" values, and tests encode / decode for values in\n[center - 4, center + 4] and [-center - 4, -center + 4].\n\nPreviously, this approach led to integer overflow, which is undefined\nbehavior for signed integers. This CL fixes the problem in two ways:\n1. Tweak test helpers to avoid adding negative values.\n * Remove [-center - 4, -center + 4] cases, to avoid negating\n unsigned ints.\n * Change \"center + [-4, 4]\" loop to \"(center - 4) + [0, 8]\" loop.\n2. Revise input test data to avoid overflow.\n * Replace hard-coded center cases with constructed ones:\n * Add values close to 0.\n * Add powers of 2 and their negations (if signed) / values\n subtracted from UINT{32,64}_MAX.\n * Add values around 0x7FFF...F (avoiding overflow).\n\nNote: Hard-coded 4 is now constexpr RADIUS.\n\nAlso add more test helpers to dedup code:\n* Change TestEncodeDecodeVar{U}Int() to wrappers to a single templated\n TestEncodeDecodeImpl() that takes Encode / Decode functions passed as\n lambdas.\n* Add PushPowersOf2AndNegations() to replace hard-coded center values.\n\nBug: 429588215\nChange-Id: Ib21d5c5796e9ba12424af47b5e45d1a49fe80cfb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7209658\nReviewed-by: Calder Kitagawa \u003cckitagawa@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1553645}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 671119c7c91454d70707cdf55e7ab3e58d09e092\n" }, { "commit": "95c22484ce8077e52b962e17707ed44f3dd8f82d", "tree": "e79312b982944a79dd9f47bd0dc875917960b473", "parents": [ "2ff8dff79acfdd581e42efc9cde6702473d95ad7" ], "author": { "name": "Yuki Shiino", "email": "yukishiino@chromium.org", "time": "Thu Nov 27 08:26:37 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 27 08:32:46 2025" }, "message": "spanification: automatically spanify components/zucchini/disassembler_dex.cc etc.\n\nThis is the result of running the automatic spanification on linux and\nupdating code to use and pass spans where size is known.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms\u003dlinux\nThen refined with gemini-cli\n\ngemini-run/batch-run-1758857589/group_148\n\nBUG\u003d439964610\n\nChange-Id: I88e2e00865a9fcd322f848b93adffdf9e27e10b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7001904\nCommit-Queue: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nReviewed-by: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1550898}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dac90c208c702cad709360d946ca7b40a67cc179\n" }, { "commit": "2ff8dff79acfdd581e42efc9cde6702473d95ad7", "tree": "db06ce9c38b2adf60c9f1794e471d17afdbb125a", "parents": [ "049c201ebc0bafa885574079eaaf081c1a1532f3" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Nov 21 03:40:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 21 04:03:32 2025" }, "message": "Reland \"Move logging::LoggingSettings to base/logging/logging_settings.h\"\n\nThis is a reland of commit 6b79baf89a1d87407d4bafdc5d871061a81f80fc\n\nThe reland is the same CL. The difference is the problematic code in a\nseparate repo that did not do IWYU has been fixed.\n\nOriginal change\u0027s description:\n\u003e Move logging::LoggingSettings to base/logging/logging_settings.h\n\u003e\n\u003e Move struct LoggingSettings, which is only used in a relatively small\n\u003e number of files, out of base/logging.h and into its own header. Update\n\u003e direct users and then do IWYU to fix the build. This effectively moves\n\u003e base/files/file_path.h out of base/logging.h.\n\u003e\n\u003e Change-Id: I04209f1063051b7399e335d7e30cb7abb9442c94\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150\n\u003e Reviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Commit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n\u003e Owners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1546655}\n\nChange-Id: Ie877c3c85cc3e1983fb8b2b065b0d09607442ce4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7173024\nOwners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCommit-Queue: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1548242}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d7fb9d0cd0b6e1589ee974c1ca33de984df513e7\n" }, { "commit": "049c201ebc0bafa885574079eaaf081c1a1532f3", "tree": "413019308afad858c73954b83240f9bdda59c783", "parents": [ "8ad985db4cfde9d050b2456a0abcfa51f23c2bff" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Nov 19 02:46:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 19 03:06:47 2025" }, "message": "Revert \"Move logging::LoggingSettings to base/logging/logging_settings.h\"\n\nThis reverts commit 6b79baf89a1d87407d4bafdc5d871061a81f80fc.\n\nReason for revert: Broke win-chrome\n\nOriginal change\u0027s description:\n\u003e Move logging::LoggingSettings to base/logging/logging_settings.h\n\u003e\n\u003e Move struct LoggingSettings, which is only used in a relatively small\n\u003e number of files, out of base/logging.h and into its own header. Update\n\u003e direct users and then do IWYU to fix the build. This effectively moves\n\u003e base/files/file_path.h out of base/logging.h.\n\u003e\n\u003e Change-Id: I04209f1063051b7399e335d7e30cb7abb9442c94\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150\n\u003e Reviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Commit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n\u003e Owners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1546655}\n\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I7cf4167499823ba368fcfab88c930d1d98455fa0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7170750\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1546935}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6201eb11311d419ae1f44e85fff590ec69156cf5\n" }, { "commit": "8ad985db4cfde9d050b2456a0abcfa51f23c2bff", "tree": "db06ce9c38b2adf60c9f1794e471d17afdbb125a", "parents": [ "4d7b2546e1b59896b89b5ab8500436095a86fce5" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Nov 18 18:20:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 18 18:38:20 2025" }, "message": "Move logging::LoggingSettings to base/logging/logging_settings.h\n\nMove struct LoggingSettings, which is only used in a relatively small\nnumber of files, out of base/logging.h and into its own header. Update\ndirect users and then do IWYU to fix the build. This effectively moves\nbase/files/file_path.h out of base/logging.h.\n\nChange-Id: I04209f1063051b7399e335d7e30cb7abb9442c94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150\nReviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1546655}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6b79baf89a1d87407d4bafdc5d871061a81f80fc\n" }, { "commit": "4d7b2546e1b59896b89b5ab8500436095a86fce5", "tree": "413019308afad858c73954b83240f9bdda59c783", "parents": [ "226c26d174e461fe320d6c02acbe6051a9792c41" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Nov 04 20:39:48 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 04 20:46:36 2025" }, "message": "Suppress initial set of unique_ptr\u003cT[]\u003e::operator[] unsafe warnings\n\nThe clang compiler can now warn on another unsafe pattern: indexing\nan element of unique_ptr\u003cT[]\u003e. This CL stops short of actually\nenabling this warning for Chromium builds, but identifies some\nusage which would trigger the new warning and suppresses it via the\nUNSAFE_TODO() macro.\n\nThe warning itself can be enabled in a one-line follow-on, to ease\na revert if required.\n\nChange-Id: Ibe0b56d77f51114715d655f137714950034ec955\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106863\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1540262}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bee5f7ccd83b949fbd4bf96677d7039f077a5301\n" }, { "commit": "226c26d174e461fe320d6c02acbe6051a9792c41", "tree": "83f04449f6b2eed9ed90beaf0858e8b31f5c4723", "parents": [ "ec54ee29df648bae7d8fee09833fa0cec7e4e581" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Fri Aug 15 00:42:24 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 15 00:49:14 2025" }, "message": "Rewrite --force unsafe buffers pragmas in components/\n\nChange-Id: Ia214685aae0320821bb523f3f3e4a5903343373d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6828357\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1501715}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0cc725e5c06bff7e626bc6f32c90187065b10d3f\n" }, { "commit": "ec54ee29df648bae7d8fee09833fa0cec7e4e581", "tree": "4f345d4da2120554888e63baf7dcab86b6263809", "parents": [ "4ba465d947fa102c4e1c806491e93a3824f6efb0" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Mon Aug 11 21:30:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 11 21:36:06 2025" }, "message": "[Zucchini] Optimize SuffixLowerBound().\n\nRecently we\u0027ve seen Zucchini-gen become unusably slow when generating\npatches from Chrome M139 to M141 (Windows). Much slowness arise from\nSuffixLowerBound(), arising from the following factors:\n* The number of calls increased significantly, due to size increase and\n widespread differences (perhaps due to compiler or settings change?).\n* The function is slow -- though we\u0027re unsure if there are compiler or\n library regressions?\n\nThis CL optimizes SuffixLowerBound() to speed up Zucchini-gen.\nPreviously the function was implemented using std::lower_bound() and\nstd::lexicographical_compare(). This led to short code, but redundant\ncomparisons can arise. For example, when applying binary search for\n\n VERY_LONG_COMMON_PREFIX_key\n\nin the lexicographically sorted string list\n\n VERY_LONG_COMMON_PREFIX_a\n ...\n VERY_LONG_COMMON_PREFIX_zzzzzzz\n\nsince both lower and upper limit have \"VERY_LONG_COMMON_PREFIX_\" as a\nprefix, there\u0027s no need to check it at each step. The old code would\nwaste time doing this -- this is the inefficiency to optimize.\n\nGeneralizing: When performing binary search in a lexicographically\nsorted list of strings, the length of the common prefix between the\nlower limit (assumed exclusive) and the search key is monotonically\nincreasing. Same holds between the upper limit (assumed inclusive) and\nthe search key. Therefore we can track the lengths, called the Longest\nCommon Prefix (LCP), separately for lower and upper limits. The min\namong these can be skipped when applying string comparison between\nthe key and strings between. The LCPs then get updated at each step.\n\nNote: Gemini CLI was used to prototype the optimized SuffixLowerBound().\nThe code is then manually verified, optimized, and cleaned up.\n\nBug: 437405014\nChange-Id: I0fcee3f1817e7313be0b22152c88ef6718422698\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6828558\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1499825}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1f12501dbfa91c3dc0d0c050ac14c11bbd2c39c5\n" }, { "commit": "4ba465d947fa102c4e1c806491e93a3824f6efb0", "tree": "9efbfc0c84caa374630ed2a4fe1d36725d38de4e", "parents": [ "ec0f1ddcbb24d631a41be8d2d0f5454282359c2d" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Jul 31 17:41:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 31 17:48:05 2025" }, "message": "Mark some more UNSAFE_BUFFERS() in chrome for raw_ptrs\n\nCorrect some pre-existing usage before attempting to mark raw_ptr\u0027s\nunsafe operations as unsafe.\n\nBug: 435068772\nChange-Id: I6402f7a7d44f99508079db41fe1ad4f122a09662\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803330\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1494937}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 54aadc512f3e268f2b760ba5d3805be94bda5df5\n" }, { "commit": "ec0f1ddcbb24d631a41be8d2d0f5454282359c2d", "tree": "49c5629c7e55527c9b71f6ed3e1bb05ccf046b1d", "parents": [ "055f16e9b1d9b9b04540553462e1a7ab39f86c73" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Jul 28 18:58:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 28 19:04:47 2025" }, "message": "Auto-format //components/[p-z]* GN files\n\nRun \"gn format\" and automatically shorten target references, now that GN\nknows how to do this. Then manually delete duplicate entries in the\noutput. Also let GN clean up anything else it finds that is not\nformatted correctly.\n\nBug: 40760278\nChange-Id: Ie296be1613b5515bca8782ceff60e5ffa061b3ab\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6789738\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCommit-Queue: Ted Choc \u003ctedchoc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1492994}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b80b2b99e78beaa11a75072e161e7bbd346e6bd0\n" }, { "commit": "055f16e9b1d9b9b04540553462e1a7ab39f86c73", "tree": "91d5d34d024d9c5e462b7c3881cb0877d3b9c0aa", "parents": [ "3fb1d1e729a79b61023e10dcc524e4519630fa88" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jul 23 11:54:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 23 12:00:45 2025" }, "message": "Rework allow_unsafe pragmas in components/\n\nFully automated CL via tools/clang/unsafe_pragma_rewriter/ scripts,\nthen manually revert one file that failed DEPS checks.\n\nBug: 409340989\nChange-Id: I9949803989588810640b53eae14e5f02ac39a2fb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6715939\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1490730}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4413f7f927f8ddf9bfbee128b7c0161691b38913\n" }, { "commit": "3fb1d1e729a79b61023e10dcc524e4519630fa88", "tree": "e3fd0a9874854c946f74746976c2d1c528aa7500", "parents": [ "9f23da7cb17038569a7d3e26552a21b6dc9962c9" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Jul 15 09:20:38 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 15 09:27:13 2025" }, "message": "spanification: remove `#pragma allow_unsafe_buffers` where unneeded\n\nThis is a clean up of any files that now compile without the pragma.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\n//tools/clang/spanify/remove-unneeded-pragmas.py\n\nand then split with\n`git cl split --target-range 8 32 --max-depth\u003d2 --expect-owners-override --no-reviewers -d ~/description.txt`\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 414858406\nChange-Id: I6c06150ae7ed543ccaa55d64ab6c6c4d202d9bab\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6756709\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1486777}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5babd1f784547088ed4eec345dddd4a0b05b371f\n" }, { "commit": "9f23da7cb17038569a7d3e26552a21b6dc9962c9", "tree": "1a6cc8da27621ece52237d5091b08d6a887fa137", "parents": [ "cbc158f70593da44e3c158d9408c82dff360c86b" ], "author": { "name": "Joshua Pawlicki", "email": "waffles@chromium.org", "time": "Thu May 22 17:49:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 22 17:57:00 2025" }, "message": "zucchini: Fix omitted field in patch file documentation.\n\nChange-Id: I40dc915070c1aa3c7d32b5aec96ec167ecbc3a94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579916\nAuto-Submit: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1464225}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c9e7ca92ec0ffe802372c7c877294a342bbf6d96\n" }, { "commit": "cbc158f70593da44e3c158d9408c82dff360c86b", "tree": "0067e2692d367c2fe1b11f6b0ae4302e0dc2ec51", "parents": [ "cd66cf6bfbe0074b67675811183ae8594ba410a2" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Thu May 15 13:54:12 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 15 14:00:13 2025" }, "message": "[Zucchini] Add -start-scan-at\u003d# switch to Zucchini-{gen,detect,match}.\n\nChrome Update infra is changing to use self-extracting archives. A\nproblem is that Zucchini would only identify the outer binary, and skip\nthe non-compressed payload binaries. This causes these binaries to be\ntreated as unstructured raw data, and Zucchini loses its advantage re.\npointer management.\n\nThis CL has two parts:\n1. Implement a simple solution to the above problem: Add -start-scan-at\n switch to specify the offset to begin element detection. This\n allows us to skip the outermost binary by passing a small value.\n This flag is available for Zucchini-{gen,detect,match}, and is\n ignored if either -impose or -raw switch is used.\n * This does not affect patch format and Zucchini-apply.\n2. Add struct GenerateOptions to collect Zucchini-{gen,detect,match}\n switches {-start-scan-at, -impose, -raw}, then add GenerateBuffer()\n overload to use it, and deprecate GenerateBuffer{,Imposed,Raw}(),\n which uses the new interface internally.\n\nDetails:\n* ElementFinder: Add `init_pos` CTOR param as initial value to `pos_`,\n to implement (1)\u0027s main behavior.\n* zucchini_command.cc: Add ReadGenerateOptions() to read switches into\n GenerateOptions.\n* Zucchini-gen: Add plumbing for -start-scan-at:\n MainGen() [reads `options`]\n -\u003e Generate() [param `options`]\n -\u003e GenerateCommon()\n (API start)\n -\u003e GenerateBuffer() [extract `start_scan_at` from `options`]\n -\u003e HeuristicEnsembleMatcher CTOR\n -\u003e FindEmbeddedElements()\n -\u003e ElementFinder CTOR [param changed to `init_pos`]\n* Zucchini-{detect,match}: Add plumbing:\n Main{Detect,Match}() [reads `options`]\n -\u003e {Detect,Match}All()\n -\u003e ElementFinder CTOR or HeuristicEnsembleMatcher CTOR.\n\nAlso update ElementDetectionTest with cursory case to pass `init_pos`.\n\nBug: 413402398\nChange-Id: I50744e759379404ff7dcb73c2d3586ac7fca599a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6550735\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1460685}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 304d216f6271d96538a0040e05e6e3cd795d3542\n" }, { "commit": "cd66cf6bfbe0074b67675811183ae8594ba410a2", "tree": "0f44d89631b6e9ad6365f913fe16051bb0f5e99d", "parents": [ "6ab3321e616da2395609c576fe90d40f359362ae" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Tue May 06 15:05:32 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 15:12:13 2025" }, "message": "Modernize equality operators\n\nThis CL is pure clean-up and contains no functionality changes.\nDepending on the files covered in the CL (since the CL was generated\nusing git cl split), it does a subset of the following:\n- Remove unneeded operator!\u003d declarations/definitions since C++20 can\n automatically derive those from operator\u003d\u003d.\n- Default operator\u003d\u003d where this is equivalent to the current behavior.\n- Default operator\u003c\u003d\u003e where this is equivalent to the current\n behavior.\n\nThis CL was uploaded by git cl split.\n\nR\u003dgrt@chromium.org\n\nBug: 40256175\nChange-Id: If44139f4aecb31000ccaffcef6f5d924c7199504\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6512964\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1456342}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 75750e18014b94aae3067c151533e32b80f7dd72\n" }, { "commit": "6ab3321e616da2395609c576fe90d40f359362ae", "tree": "28d30865e733b8c5112ada587b0ba2036605eb9c", "parents": [ "adadf398ae4580aea88849d2a4330f5bace884ba" ], "author": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Thu May 01 21:04:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 01 21:12:10 2025" }, "message": "spanification: remove `#pragma allow_unsafe_buffers` where unneeded\n\nThis is a clean up of any files that now compile without the pragma.\nThis CL has no behavior changes.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/remove-unneeded-pragmas.py\n\nand then split with\n`git cl split --target-range 8 32 --max-depth\u003d2 --expect-owners-override --no-reviewers -d ~/description.txt`\n\nThis covers directories:\n[\u0027components/variations\u0027, \u0027components/commerce\u0027, \u0027components/domain_reliability\u0027, \u0027components/payments\u0027, \u0027components/system_cpu\u0027, \u0027components/zucchini\u0027, \u0027components/error_page\u0027, \u0027components/feedback\u0027, \u0027components/media_router\u0027, \u0027components/metrics\u0027, \u0027components/reporting\u0027, \u0027components/search_engines\u0027]\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 414858406\nChange-Id: Ib6241b62a104471668506478b357dd79adb146f1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6504356\nReviewed-by: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1454666}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f5cc789ee6e68419e2671682503c3d5ee5fe1af\n" }, { "commit": "adadf398ae4580aea88849d2a4330f5bace884ba", "tree": "11572478e65418ba854f5bee36e0384542bb6981", "parents": [ "a8738eb6197925695ddef1b406a3b9842267ea3a" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Thu Apr 17 19:32:03 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 17 19:38:25 2025" }, "message": "spanify: Renewed arrayification (X/43)\n\nThis CL is part of the wider spanification / arrayification effort [1]\nand does not (intentionally) introduce behavioral change. It applies the\n`std::array` rewrite to\n\n[\u0027components/zucchini\u0027, \u0027components/history\u0027, \u0027components/policy\u0027,\n\u0027components/viz\u0027, \u0027components/feedback\u0027,\n\u0027components/filename_generation\u0027, \u0027components/leveldb_proto\u0027,\n\u0027components/metrics\u0027, \u0027components/services\u0027, \u0027components/visitedlink\u0027]\n\nas close as possible to the output directly written by `spanify`, with\nno hand-rolled fixes (except where rebasing would require).\n\nThis change (and its siblings taken together) is thought not to cause\nany measurable perf regressions [2].\n\n[1] https://issues.chromium.org/356643982 [2]\nhttps://docs.google.com/document/d/1jughaR6JKn7T-dDjMou10awyNkhE5T-vLY_K2YMqHE4/edit?tab\u003dt.0#heading\u003dh.r2eguxl5lhu7\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 406029216\nChange-Id: I9764070fd66fbeced4d9b55512ef623b79c021a7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6436851\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Kalvin Lee \u003ckdlee@chromium.org\u003e\nReviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1448508}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 72b899591d10266d7ec9a2c3868f09f99d6e1d6f\n" }, { "commit": "a8738eb6197925695ddef1b406a3b9842267ea3a", "tree": "3141a740905e44c91d61b58f3f97df23f3d241f1", "parents": [ "b5e582ac5c26ad36de29456bfe0d71e223755f73" ], "author": { "name": "Joshua Pawlicki", "email": "waffles@chromium.org", "time": "Wed Apr 02 17:55:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 02 18:10:36 2025" }, "message": "patch_service: Add support for applying zucchini patches.\n\nThis will be used components/update_client in a future CL.\n\nBug: 399619105\nChange-Id: I6c29e062ea467feeba3036daeb54163c27649f0c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6383817\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nAuto-Submit: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nCommit-Queue: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1441614}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e4634e33b39ae2a58148938217d1e47173d47f5b\n" }, { "commit": "b5e582ac5c26ad36de29456bfe0d71e223755f73", "tree": "fd8089a202fe10f2c1b01531b338a8a64abee539", "parents": [ "ca3b6ba082e4c982a22532a9eee9be645819f169" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jan 29 02:11:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 29 02:19:07 2025" }, "message": "Suppress unsafe_libc_call warning for initial identified files.\n\nSee docs/unsafe_buffers.md for details. Enforcement is not yet\nenabled, but this set of files are not in compliance with the\nnew warnings.\n\nBug: 390223051\nChange-Id: I4e24c2141b9399f572678302c833947494098b29\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187925\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1412673}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8726d30ed0372d085f5d9048ed5a4d62e13015ca\n" }, { "commit": "ca3b6ba082e4c982a22532a9eee9be645819f169", "tree": "3c341321b21ffb35af32ff92e05a79582fb56504", "parents": [ "3b947a0297a83b00351122f3550700b58efcdbfa" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Jan 27 18:38:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 27 18:46:29 2025" }, "message": "[cleanup] Replace base::ranges with std::ranges: components/\n\nDone entirely with `git grep` and `sed` + `git cl format`, no\nhand-editing.\n\nBug: 386918226\nChange-Id: I7377af2f9c3758c68a249b421d98bd3fd5c2c1fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6201377\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1411730}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ccea09835fd67b49ef0d4aed8dda1a5f22a409c8\n" }, { "commit": "3b947a0297a83b00351122f3550700b58efcdbfa", "tree": "55181b5978791c8c995df726b5bcc393eb2fc3f6", "parents": [ "9394bac35159265c0d29ebb71b3cafb541576f36" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Jan 15 02:29:32 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 15 02:42:54 2025" }, "message": "More std::ranges porting: components/\n\nBug: 386918226\nChange-Id: Icd4538a0d9b172d2df234f88ab2b1bc1f12bea91\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164119\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: Ted Choc \u003ctedchoc@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1406479}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3f8b960085234a5b58cb6aba18f686f2e84ce788\n" }, { "commit": "9394bac35159265c0d29ebb71b3cafb541576f36", "tree": "aa491796e4184883ca750e297a0d2b5a1ffb9346", "parents": [ "ee111abca169dc50f3575e1f18e9d8e453fb1daa" ], "author": { "name": "Luc Nguyen", "email": "lucnguyen@google.com", "time": "Mon Dec 02 16:40:10 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 02 16:50:04 2024" }, "message": "Revert \"[Health] Change unique_ptr\u003c[]\u003e to HeapArray in Zucchini::BinaryDataHistogram\"\n\nThis reverts commit 6f3f22396fb6638614fad550b6b4b6b0d97076c3.\n\nReason: HeapArray adds overhead that is unacceptable.\n\nAlso adds a comment explaining this.\n\nBug: 381332105\nChange-Id: I6eca022657c4eab151e65dc4e0958f9f9f7fdfc8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062543\nAuto-Submit: Luc Nguyen \u003clucnguyen@google.com\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1390374}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 167283a7b43f952fac9ecd41456802355e44d96a\n" }, { "commit": "ee111abca169dc50f3575e1f18e9d8e453fb1daa", "tree": "8914561c221dae3d4dd3fd7e729f2dc4e68837f8", "parents": [ "377c547117e16c19b9b465c298036193aff9d08b" ], "author": { "name": "Luc Nguyen", "email": "lucnguyen@google.com", "time": "Thu Nov 28 16:30:53 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 28 16:40:16 2024" }, "message": "[Health] Change unique_ptr\u003c[]\u003e to HeapArray in Zucchini::BinaryDataHistogram\n\nUse a type that tracks its size.\n\nBug: 40285824\nChange-Id: I15b5e14b604bfe62923e3e9f30cf24f136e4eb97\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049998\nCommit-Queue: Luc Nguyen \u003clucnguyen@google.com\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1389459}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f3f22396fb6638614fad550b6b4b6b0d97076c3\n" }, { "commit": "377c547117e16c19b9b465c298036193aff9d08b", "tree": "eb673bc0a7376fa40cee6052aba5daa7a205495f", "parents": [ "cac9e826b7d70d51ef3fbc1109565b0156677bba" ], "author": { "name": "Sorin Jianu", "email": "sorin@chromium.org", "time": "Wed Oct 09 09:09:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 09 09:18:56 2024" }, "message": "components: default the user-defined empty ctor and dtor where possible\n\nI need an owner\u0027s approval please for changes under:\ncomponents/zucchini\n\nThis is a mechanical change. There are a few instances (but not all)\nof empty user-defined constructors and destructors which can be\ndefaulted in the /components code.\n\nThis CL was uploaded by git cl split.\n\nR\u003dgrt@chromium.org\n\nBug: 371316188\nChange-Id: I446078e8a6155956da84e543264a6acbc68606a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5918615\nAuto-Submit: Sorin Jianu \u003csorin@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1366042}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 999312a826bda6b1b98b7e35336cab6878e6743a\n" }, { "commit": "cac9e826b7d70d51ef3fbc1109565b0156677bba", "tree": "b8b73c6a00f08056e109a7f597bf309c0fea8626", "parents": [ "5dd275fbb25b36f37ed7bc0d1568428201b00341" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Mon Sep 30 17:58:53 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 09 09:18:30 2024" }, "message": "Rewrite map pointer values to raw_ptr\n\nThis cl rewrites CTN\u003ckey, T*\u003e into CTN\u003ckey, raw_ptr\u003cT, CtnExperimental\u003e\u003e\nwhere CTN is one of: std::map, std::unordered_map, base::flat_map\n\nThe following benchmarks were launched to ensure the cl does not\nintroduce any performance regression:\nhttps://pinpoint-dot-chromeperf.appspot.com/job/10ce4602210000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/11e2fc0c210000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/16ca4ca8210000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/168ae33c210000\n\nThe identified bottlenecks were excluded from the rewrite. These are the\ninitial values before exclusions on motionmark_ramp_composite (for\nexample): https://pinpoint-dot-chromeperf.appspot.com/job/16987bf4210000\n\nAfter Exclusions:\nhttps://pinpoint-dot-chromeperf.appspot.com/job/168ae33c210000\n\nAX-Relnotes: n/a.\nChange-Id: I35c52d7427140361410db74e25e0cb8f7bd516db\nBug: 329428315\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5867189\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1361899}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 60a72b0afdb415164c8f72cb0cada4317e4464a1\n" }, { "commit": "5dd275fbb25b36f37ed7bc0d1568428201b00341", "tree": "3878b9711047727b24ef9cb06ec85f1771692449", "parents": [ "8e63243ef01554af5a10b77d51ffbb523ffe4db3" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Wed Jul 31 08:29:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 31 08:36:22 2024" }, "message": "spanification: Add `#pragma allow_unsafe_buffers` to component/*\n\nSee `//docs/unsafe_buffers.md`\n\nThis is a preparation to fix each files.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nAX-Relnotes: n/a.\nBug: 40285824\nChange-Id: I24ff0aee7a6cbe6da11a08830135449ccf8f2ae2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5717711\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Cait Phillips \u003ccaitkp@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1335315}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b948e67a9c2fa2f8adff2206ef00cccde3f8640a\n" }, { "commit": "8e63243ef01554af5a10b77d51ffbb523ffe4db3", "tree": "4e104014e1e9089f9673b78ccb704d7ecaa4e241", "parents": [ "cfbdd888e9dad24d881957f07cf4d7898ecc6310" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Wed Jul 10 14:13:21 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 10 14:22:44 2024" }, "message": "[windows] Register an absl abort hook in the same fashion as OOM termination\n\nPreviously, the abort hook was only being registered for the copy of\nabsl linked into chrome_elf.dll. Move registration out of the crash\nhandler and into the various modules that may contain crashy code (a la\nEnableTerminationOnOutOfMemory). This ensures that it\u0027s registered in\nchrome.exe and chrome.dll so that we get nice crashes from FATAL absl\nerrors in all modules.\n\nFixed: 41494817\nChange-Id: I2435e989cedae37bd950a463a6748fc16e8cfc73\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5692058\nAuto-Submit: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1325462}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0f083544228d297cf3583cd233477d3bd866b7eb\n" }, { "commit": "cfbdd888e9dad24d881957f07cf4d7898ecc6310", "tree": "ca5766a6ce95058a72880c554740682f57dff996", "parents": [ "65c3342cf68dfe3abb2a23ba3e167d43a8fb3768" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Tue Jun 11 13:05:35 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 11 13:15:54 2024" }, "message": "Convert base::StringPiece to std::string_view left overs.\n\nThe changes of this CL are made using the following script.\nScript: https://issues.chromium.org/issues/40506050#comment343\n\nBug: 40506050\nChange-Id: I768b3590141a698385319a615f2aefb71215ec84\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601472\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Helmut Januschka \u003chelmut@januschka.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1313356}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1dce9dcaeaa1b6b2a278869566f7554c62b10dc7\n" }, { "commit": "65c3342cf68dfe3abb2a23ba3e167d43a8fb3768", "tree": "f119de80edd4df5f7a9ddc42ea7d4c92212a6b20", "parents": [ "450b025685e5391ff41a9963db25611ac4314820" ], "author": { "name": "Erik Staab", "email": "estaab@google.com", "time": "Tue Apr 30 00:45:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 30 00:53:48 2024" }, "message": "Move zucchini test data into chromium/src\n\nEven though these are binary files and 4/6 of them are approaching\n1MiB, they haven\u0027t changed since 2018 and won\u0027t negatively impact\ngit repository performance.\n\nBug: b/337329977\nChange-Id: Ifc47e03d70d291d60666626722b3b72dbabfe2a0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494121\nCommit-Queue: Erik Staab \u003cestaab@chromium.org\u003e\nReviewed-by: Calder Kitagawa \u003cckitagawa@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1294060}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 97f21d71d0f5868ac5e2930b1e20bc1f6efa99ea\n" }, { "commit": "450b025685e5391ff41a9963db25611ac4314820", "tree": "2f0b7df0b8825b372d122e2fdbe005a26d5d7d69", "parents": [ "22f8bb28c78a3428d645a6a4fbc7cfdbfa9b8f87" ], "author": { "name": "Jack Yammine", "email": "jyammine@google.com", "time": "Mon Apr 22 15:28:29 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 22 15:34:11 2024" }, "message": "[CodeHealth]Use HeapArray in components/zucchini/fuzzers/raw_gen_fuzzer.cc\n\nFixed: b:326458310\nChange-Id: I75a26f877967dfab082f27339c474cab8ae8a2f6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463510\nAuto-Submit: Jack Yammine \u003cjyammine@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1290682}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e6502907de7b9edf0c5b514c77b2282ed0ffdd64\n" }, { "commit": "22f8bb28c78a3428d645a6a4fbc7cfdbfa9b8f87", "tree": "0e83fa9092c878c777e1a0797612332eab382911", "parents": [ "8b2b7a7afc045beebb107100d6fa4610cfda77aa" ], "author": { "name": "Jack Yammine", "email": "jyammine@google.com", "time": "Mon Apr 22 15:27:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 22 15:33:54 2024" }, "message": "[CodeHealth]Use HeapArray in components/zucchini/fuzzers/imposed_ensemble_matcher_fuzzer.cc\n\nFixed: b:326458017\nChange-Id: I2e94ed27d05fe9dce5eb35a0cc3f1ab63cbeacf7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465843\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nAuto-Submit: Jack Yammine \u003cjyammine@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1290681}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 73de014d7e34a6733faae554ddef66091afb39c8\n" }, { "commit": "8b2b7a7afc045beebb107100d6fa4610cfda77aa", "tree": "04788a0c5fe7c901ad29136f6bba0958d44811f6", "parents": [ "15eed8658e0cd864f13107e5e15b65724f98c6f1" ], "author": { "name": "Jack Yammine", "email": "jyammine@google.com", "time": "Mon Apr 22 15:27:21 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 22 15:33:34 2024" }, "message": "[CodeHealth]Use HeapArray in components/zucchini/fuzzers/ztf_gen_fuzzer.cc\n\nFixed: b:326458859\nChange-Id: I71c64b08d0821009f8233e06e2ce46c134ebd602\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463509\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nAuto-Submit: Jack Yammine \u003cjyammine@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1290680}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 44e7df1f305b731b7b6b24cfbb63825f14813fa8\n" }, { "commit": "15eed8658e0cd864f13107e5e15b65724f98c6f1", "tree": "2463bfb6c97c04465e5e069b4717e71300cff848", "parents": [ "817d9e28beadeb321ec8686109bb5362baa17c89" ], "author": { "name": "Dan McArdle", "email": "dmcardle@chromium.org", "time": "Mon Apr 15 19:09:00 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 19:24:56 2024" }, "message": "base/logging: Prevent test-only crash caused by std::string(nullptr)\n\nIf logging is not set up properly, ~ScopedLoggingSettings() can make a\ncall to InitLogging() that constructs a std::string from nullptr. This\nundefined behavior would occur when BaseInitLoggingImpl() sets the value\nof `*g_log_file_name`.\n\nThis can occur in at least one scenario: when the logging destination is\nLOG_TO_FILE, but no log file is set.\n\nI think this caused a crash in sql_recovery_lpm_fuzzer on Windows (see\nlinked bug). However, a little more UB may also have been involved\nbecause the fuzzer does not call InitLogging().\n\nTo prevent this undefined behavior from occuring, this CL makes the\nfollowing changes:\n\n* It changes the type of LoggingSettings::log_file_path from a pointer\n to a string type to prevent nullptr-related accidents in the future.\n\n* It changes ScopedLoggingSettings::log_file_name_ from a\n std::unique_ptr\u003c\u003e of a string type to just a plain string type.\n\n* It upgrades some DCHECKs to CHECKs in BaseInitLoggingImpl(). Note that\n the old `DCHECK(settings.log_file_path)` would have been sufficient to\n prevent the UB in question, but we observed the crash in a fuzzer\n where DCHECKs were not enabled.\n\nBug: 331909454\nChange-Id: I27abdb3eac6fec82853a7643643b2dacd7f7571c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5416213\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Dan McArdle \u003cdmcardle@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1287534}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b4b65e3b7219a0150106e6798d7d75b401aec1d0\n" }, { "commit": "817d9e28beadeb321ec8686109bb5362baa17c89", "tree": "037c05f7be7c76bd79c2f6b1feb6b16d9a8dd481", "parents": [ "d9358652a1f7cfeb3f390176a73b2e60d4210921" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Apr 15 16:59:19 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 17:08:37 2024" }, "message": "format windows headers using new config.\n\nTest new config:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5197064\n\nby applying clang-format on every problematic windows headers.\n\nThis CL is cloned from https://crrev.com/c/5366045.\n\nScript:\n-------\n\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n | grep -v \"third_party/[^b]\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/gi\"\n}\n\ngit checkout origin/main\ngit branch -D change-5197064 || true\n\ngit new-branch change-5197064\nreplace \"#include \u003c\\(initguid|mmdeviceapi\\|windows\\|winsock2\\|ws2tcpip\\|shobjidl\\|atlbase\\|ole2\\|unknwn\\|objbase\\|tchar\\).h\u003e\" \"\"\nreplace \"#include \\\"base\\\\/win\\\\/atl.h\\\"\" \"\"\nreplace \"#include \u003cuiautomation.*\u003e\" \"\"\ngit add -u\ngit commit -m \"remove problematic windows headers\"\ngit revert HEAD --no-commit\ngit add -u\ngit commit -m \"add problematic windows headers\"\ngit cl format --upstream\u003dHEAD~\ngit add -u\ngit commit -m \"format\"\n\ngit cl issue 5367127\ngit cl upload -df --bypass-hook\n```\n\nAlso removed some unnecessary comments.\n\nBug: 329138753\nChange-Id: I161c28ea2d27c569825e0c789a4c143530937f58\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367127\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1287420}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c8d6b16f02bc9013db2354b8649d2e0d97829a1a\n" }, { "commit": "d9358652a1f7cfeb3f390176a73b2e60d4210921", "tree": "8430100d7a382f471ad7a3f59f81e45028e229cb", "parents": [ "f214c4c6acd7db198caf68d8873d2c57b055ec54" ], "author": { "name": "Andrew Rayskiy", "email": "greengrape@google.com", "time": "Wed Feb 28 20:41:58 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 28 20:46:05 2024" }, "message": "[base] Update Erase()/EraseIf() calls for std::vector\u003c\u003e in components/\n\nThey\u0027re now replaced with C++20 std::erase()/std::erase_if().\n\nScript:\n```\n* extract files referencing Erase()/EraseIf() on cs via css selectors *\n\n1. Run sed replacements:\n\u0027s/base::EraseIf/std::erase_if/g\u0027\n\u0027s/base::Erase/std::erase/g\u0027\n\u0027s/#include \"b/c/cxx20_erase.h\"/#include \u003cvector\u003e/g\u0027\n\u0027s/#include \"b/c/cxx20_erase_vector.h\"/#include \u003cvector\u003e/g\u0027\n\n2. Run git cl format to sieve \u003cvector\u003e include upwards\n3. Run sed with -z to separate \u003cvector\u003e include from quoted includes\n(above and below)\n\n\u0027s/\\n\\n#include \u003cvector\u003e\\n/\\n#include \u003cvector\u003e\\n\\n/g\u0027\n\u0027s/\"\\n#include \u003cvector\u003e/\"\\n\\n#include \u003cvector\u003e/g\u0027\n\n4. Run sed with -z to force \u003cvector\u003e includes on the remaining files:\n\n\u0027s/#include \u003c(\\w+)\u003e/#include \u003c\\1\u003e\\n#include \u003cvector\u003e/g\u0027\n\n5. Run git cl format to collapse duplicate \u003cvector\u003e includes\n\n6. Fix outliers by hand :)\n```\n\nBug: 40256229\nChange-Id: I730de747b1b49f78df6a22ce568a1b02e4c0cbba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324367\nCommit-Queue: Andrew Rayskiy \u003cgreengrape@google.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1266606}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4384ef7d38df3d8e68691fe435c20544a0d7b744\n" }, { "commit": "f214c4c6acd7db198caf68d8873d2c57b055ec54", "tree": "26015cb2eca8f3c0cc4389b976839ffc30bfe8ac", "parents": [ "a82fb2d94618501a6e206ca67a20f23515c2b4fb" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Mon Feb 26 15:49:43 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 26 15:56:31 2024" }, "message": "Rename {absl \u003d\u003e std}::optional Final n°2\n\n #cleanup\n\nAutomated patch. This is a no-op. Please avoid, as much as possible,\nassigning unrelated bugs to this.\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias\nfor std::optional. We should migrate toward it.\n\nScript:\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep -v \\\n -e \"third_party/abseil-cpp/*\" \\\n -e \"third_party/googletest/*\" \\\n -e \"third_party/leveldatabase/*\" \\\n -e \"third_party/libaddressinput/\" \\\n -e \"third_party/liburlpattern/*\" \\\n -e \"third_party/lzma_sdk/*\" \\\n -e \"third_party/maldoca/*\" \\\n -e \"third_party/mediapipe/*\" \\\n -e \"third_party/shell-encryption/*\"\\\n -e \"third_party/tflite_support/*\" \\\n -e \"third_party/webrtc_overrides/*\" \\\n -e \"third_party/zxcvbn-cpp/*\" \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n -e \"\\.mm\" \\\n -e \"\\.pidl\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/g\"\n}\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place,\" \"std::in_place,\"\nreplace \"absl::in_place_t,\" \"std::in_place_t,\"\nreplace \"absl::in_place)\" \"std::in_place)\"\nreplace \"absl::in_place_t)\" \"std::in_place_t)\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\n\ngit status\necho \"Formatting\"\n\necho \"IncludeBlocks: Regroup\" \u003e\u003e \".clang-format\"\necho \"IncludeIsMainRegex: \\\"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\\\"\" \u003e\u003e \".clang-format\"\ngit cl format\ngit restore \".clang-format\"\n```\n\nCleanup: rename\nBug: chromium:1500249\nChange-Id: I7cb6bc208109aa9b0a2d70e6cd5a7253c3cc4c0e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321725\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1265221}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 405944145a28568eb0da90d6e21caaafbe0696d4\n" }, { "commit": "a82fb2d94618501a6e206ca67a20f23515c2b4fb", "tree": "85b2fbf1cd29b323793341a2136a5e93ba51162b", "parents": [ "67fa4433a85a4e1d59d2d11b2ef28c6611460066" ], "author": { "name": "Jeff Yoon", "email": "jeffyoon@google.com", "time": "Mon Feb 12 10:11:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 12 11:33:36 2024" }, "message": "[buganizer] Migrate DIR_METADATA components/\n\nMigrate all remaining metadata files for components/\nfolders.\n\nVerify components with http://b/components/{id} or at\ngo/chrome-on-buganizer-prod-components.\n\nBug: chromium:1518875\nChange-Id: Ib2f98db0dc16f1df6c501b1d607ec586a05843dd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5284041\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1259078}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 81e6ce990a9fd2f65e89e2dbf079235991d21b5c\n" }, { "commit": "67fa4433a85a4e1d59d2d11b2ef28c6611460066", "tree": "57bb1d60cf8fef145f7d959e89254baa3d649c37", "parents": [ "377ee1e137295050484e3d210bf1c20cf2a6a16e" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Jan 26 20:26:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 26 20:34:39 2024" }, "message": "Rename {absl \u003d\u003e std}::optional in //components/\n\n#cleanup\n\nAutomated patch. This is a no-op. Please avoid, to assign unrelated\nbugs to this, as much as possible.\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias\nfor std::optional. We should migrate toward it.\n\nScript:\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"^components/\" \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n -e \"\\.mm\" \\\n | grep -v \\\n -e \"components/cast_streaming/browser/public/receiver_config.*\" \\\n -e \"components/power_metrics/*\" \\\n -e \"components/zucchini/patch_reader.*\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/g\"\n}\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place\" \"std::in_place\"\nreplace \"absl::in_place_t\" \"std::in_place_t\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\n\necho \"Formatting:\"\n\necho \"IncludeBlocks: Regroup\" \u003e\u003e \".clang-format\"\necho \"IncludeIsMainRegex: \\\"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\\\"\" \u003e\u003e \".clang-format\"\ngit cl format\ngit restore \".clang-format\"\n\ngit cl format\n```\n\nBug: chromium:1500249\nChange-Id: I34b45aba082a627d94fd9d3f9f994a60c64b40b1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5200092\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1252820}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c571efbef3ecfe66613d524ff39c58e25d18548c\n" }, { "commit": "377ee1e137295050484e3d210bf1c20cf2a6a16e", "tree": "342e7fa3261174d20f1fedf04bdae401a34599e6", "parents": [ "edc1301030db443359824fcab294628cf985f44e" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Thu Jan 25 12:49:39 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 25 12:57:23 2024" }, "message": "Reland^2 \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\n\nIt reverts the revert commit 89730423d1288fbd719f41205617ae79e1180c75\n*and* undoes the rewrites in lock_impl.h (see PS2), which caused\ncrbug.com/1520734, possibly crbug.com/1518884 and regressions in\ncrbug.com/1519816 (and merged issues).\n\nOriginal change\u0027s description:\n\u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e\n\u003e PS1: automated rewrite\n\u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e PS8-PS20: apply DanglingUntriaged\n\u003e PS21: unrewrite to undo binary size increase\n\u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e\n\u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e longer apply. But also, the rewriter changed too:\n\u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e was added)\n\u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e\n\u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e comments, e.g.:\n\u003e // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e One comment per block of fields will suffice, if the reason is the\n\u003e same throughout, and no other comments are added in between.\n\u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e because\" blurb), and improved scriptability.\n\u003e\n\u003e Bug: 1446392\n\u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\nBug: 1446392\nChange-Id: I2a2e8d97763d4ac8b7528359587689fd48e300dc\nDanglingUntriaged-notes: automated rewrite.\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232280\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1252024}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f5eeebaebe332e71aadfd5c43ec485cb23f0c7f8\n" }, { "commit": "edc1301030db443359824fcab294628cf985f44e", "tree": "065b2871785603d787512184db438f8c9ed963d2", "parents": [ "fc8aea3f1d6daf03b3c6be1d30949174832c93c4" ], "author": { "name": "Jeremie Boulic", "email": "jboulic@chromium.org", "time": "Tue Jan 23 10:42:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 23 10:49:44 2024" }, "message": "Revert \"Reland \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\"\n\nThis reverts commit 2f0511e7fd0d0ddb1632b5f418fc7b197fdd733c.\n\nReason for revert: Suspected culprit - The linux debug bot started becoming consistently red around the time this change has landed https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29\nSee crbug.com/1520734\n\nOriginal change\u0027s description:\n\u003e Reland \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\n\u003e\n\u003e This reverts commit d23c94321e2367736cafdaf0395782c97e775af7.\n\u003e\n\u003e Retrying based on gpu-fyi-try-mac-nvidia-retina-rel passing and\n\u003e http://crbug/1518884#c7 that suggests that CI has been seen passing\n\u003e even before the revert.\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e \u003e\n\u003e \u003e PS1: automated rewrite\n\u003e \u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e \u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e \u003e PS8-PS20: apply DanglingUntriaged\n\u003e \u003e PS21: unrewrite to undo binary size increase\n\u003e \u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e \u003e\n\u003e \u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e \u003e longer apply. But also, the rewriter changed too:\n\u003e \u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e \u003e was added)\n\u003e \u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e \u003e since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e \u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e \u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e \u003e\n\u003e \u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e \u003e comments, e.g.:\n\u003e \u003e // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e \u003e // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e \u003e // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e \u003e One comment per block of fields will suffice, if the reason is the\n\u003e \u003e same throughout, and no other comments are added in between.\n\u003e \u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e \u003e because\" blurb), and improved scriptability.\n\u003e \u003e\n\u003e \u003e Bug: 1446392\n\u003e \u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e \u003e DanglingUntriaged-notes: automated rewrite.\n\u003e \u003e AX-Relnotes: n/a.\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e \u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e \u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e \u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e \u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e \u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\u003e\n\u003e Bug: 1446392, 1518884\n\u003e Change-Id: I601122a00cb99ce03be6a07d98093da6a5aa3831\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202674\n\u003e Auto-Submit: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Owners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1249220}\n\nBug: 1446392, 1518884, 1520734\nChange-Id: I168d917f2b53debff8b3dee062662184faf10b41\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224145\nOwners-Override: Jeremie Boulic \u003cjboulic@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nAuto-Submit: Jeremie Boulic \u003cjboulic@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Filipa Senra \u003cfsenra@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1250727}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 89730423d1288fbd719f41205617ae79e1180c75\n" }, { "commit": "fc8aea3f1d6daf03b3c6be1d30949174832c93c4", "tree": "342e7fa3261174d20f1fedf04bdae401a34599e6", "parents": [ "e42ae13200544cb739a6ad968b05352a9f44235e" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Jan 19 15:13:08 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 19 15:17:27 2024" }, "message": "components: Guard against wrong windows.h clang-format reordering\n\nUnfortunately, the include order for \u003cwindows.h\u003e matters. This patch\nprevents clang-format to reorder them and cause compile failure.\n\nContext: I am about to rename {absl \u003d\u003e std}::optional in component:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5197813\nand those #includes have to be reordered.\n\nBug: chromium:1500249\nChange-Id: I47152a139342e6abb823b8fbbdcd26c799ecb7a5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5201050\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249348}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7e24d88ce27facb6149472bc663dd0a9f3cd7875\n" }, { "commit": "e42ae13200544cb739a6ad968b05352a9f44235e", "tree": "caeb59070d7c9bd645e417d556a96cc27d43bb28", "parents": [ "e78a5b8a294839ae6cdcd64251e245b14d2404f5" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Fri Jan 19 03:27:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 19 03:33:16 2024" }, "message": "Reland \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\n\nThis reverts commit d23c94321e2367736cafdaf0395782c97e775af7.\n\nRetrying based on gpu-fyi-try-mac-nvidia-retina-rel passing and\nhttp://crbug/1518884#c7 that suggests that CI has been seen passing\neven before the revert.\n\nOriginal change\u0027s description:\n\u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e\n\u003e PS1: automated rewrite\n\u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e PS8-PS20: apply DanglingUntriaged\n\u003e PS21: unrewrite to undo binary size increase\n\u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e\n\u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e longer apply. But also, the rewriter changed too:\n\u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e was added)\n\u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e\n\u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e comments, e.g.:\n\u003e // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e One comment per block of fields will suffice, if the reason is the\n\u003e same throughout, and no other comments are added in between.\n\u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e because\" blurb), and improved scriptability.\n\u003e\n\u003e Bug: 1446392\n\u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\nBug: 1446392, 1518884\nChange-Id: I601122a00cb99ce03be6a07d98093da6a5aa3831\nDanglingUntriaged-notes: automated rewrite.\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202674\nAuto-Submit: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249220}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2f0511e7fd0d0ddb1632b5f418fc7b197fdd733c\n" }, { "commit": "e78a5b8a294839ae6cdcd64251e245b14d2404f5", "tree": "3f7f5151609f6537da420ab9a8f81f306fbdbe2b", "parents": [ "ee27fd24f14ae539429808074b64c4d9892fd18d" ], "author": { "name": "Brian Sheedy", "email": "bsheedy@chromium.org", "time": "Wed Jan 17 01:02:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 17 01:06:05 2024" }, "message": "Revert \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\"\n\nThis reverts commit e407f3d9855a6a063eb8ea661a12b3f9d0a1e228.\n\nReason for revert: Cause of crbug.com/1518884\n\nOriginal change\u0027s description:\n\u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e\n\u003e PS1: automated rewrite\n\u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e PS8-PS20: apply DanglingUntriaged\n\u003e PS21: unrewrite to undo binary size increase\n\u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e\n\u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e longer apply. But also, the rewriter changed too:\n\u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e   was added)\n\u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e   since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e\n\u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e comments, e.g.:\n\u003e   // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e   // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e   // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e One comment per block of fields will suffice, if the reason is the\n\u003e same throughout, and no other comments are added in between.\n\u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e because\" blurb), and improved scriptability.\n\u003e\n\u003e Bug: 1446392\n\u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\nBug: 1446392, 1518884\nChange-Id: I7e5bbd0f4cbd5731ffa2cfaa24c76b17881960c3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5201861\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Tsuyoshi Horo \u003choro@chromium.org\u003e\nCommit-Queue: Tsuyoshi Horo \u003choro@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1247869}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d23c94321e2367736cafdaf0395782c97e775af7\n" }, { "commit": "ee27fd24f14ae539429808074b64c4d9892fd18d", "tree": "caeb59070d7c9bd645e417d556a96cc27d43bb28", "parents": [ "65484af347e762c94acbe1ae54d3fdf226dd7686" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Tue Jan 16 06:07:26 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 16 06:13:28 2024" }, "message": "Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\nPS1: automated rewrite\nPS2-PS5,PS7: unrewrite to fix compilation\nPS6,PS22: unrewrite non-automated exclusions\nPS8-PS20: apply DanglingUntriaged\nPS21: unrewrite to undo binary size increase\nPS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\nThe code has changed since the \"big rewrite\" so some exclusions no\nlonger apply. But also, the rewriter changed too:\n- No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n  was added)\n- union exclusion has been waived for std::optional and absl::variant,\n  since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n- Certain paths under //base are no longer need to be excluded, as\n PartitionAlloc/raw_ptr no longer depends on them\n\nThis CL also tries to popularize a better format of exclusion reasoning\ncomments, e.g.:\n  // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n  // RAW_PTR_EXCLUSION: Performance reasons ...\n  // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\nOne comment per block of fields will suffice, if the reason is the\nsame throughout, and no other comments are added in between.\nThis format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\nbecause\" blurb), and improved scriptability.\n\nBug: 1446392\nChange-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\nDanglingUntriaged-notes: automated rewrite.\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\nReviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1247373}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e407f3d9855a6a063eb8ea661a12b3f9d0a1e228\n" }, { "commit": "65484af347e762c94acbe1ae54d3fdf226dd7686", "tree": "3f7f5151609f6537da420ab9a8f81f306fbdbe2b", "parents": [ "3afbb801804d7a10f26ff35c829af5b285bfbc5c" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Jan 05 15:57:39 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 05 16:04:49 2024" }, "message": "Replace logging::LOG_FATAL with LOGGING_\n\nOld alias is deprecated. Will be removed in a separate CL to avoid\nbroader rollbacks in case I missed one or this is inadvertently used\noutside src/.\n\nBug: 849450\nChange-Id: I35d0f03cd750ef5def74f9bcdf626041847e4014\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5167919\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1243437}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8310f0f31bc693b9ba0cb1b10ff91c6d276b67e7\n" }, { "commit": "3afbb801804d7a10f26ff35c829af5b285bfbc5c", "tree": "f39b0a1152213c53a0debec07e5770a8134229d4", "parents": [ "4f6bb01838285392ab1c4efde3155cffc75483d0" ], "author": { "name": "James", "email": "deckerjames@google.com", "time": "Tue Dec 19 00:02:40 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 19 00:18:48 2023" }, "message": "Updating test params to avoid integer overflow.\n\nBug: 1512213\nChange-Id: I7205f9209d25ad1a3680939415e2cea58e548f1d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5126406\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nCommit-Queue: James Decker \u003cdeckerjames@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1238865}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f19c30784781c9dc8f7b5bce01c5af5d6ba490a6\n" }, { "commit": "4f6bb01838285392ab1c4efde3155cffc75483d0", "tree": "fdbcf85b98f0a3ca85195d3d9fd068d39adf2019", "parents": [ "181c5bb30688c295b42236d2c688b7ef3b694895" ], "author": { "name": "Andrew Rayskiy", "email": "greengrape@google.com", "time": "Thu Nov 16 12:15:25 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 16 12:20:53 2023" }, "message": "[base] Remove base::EraseIf() overloads for std::deque/std::forward_list\n\nThey\u0027re now replaced with C++20 std::erase_if().\n\nBug: 1414639\nChange-Id: I15c7e0e3cbe1e750901c495600261062d7f6dc42\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5033301\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: Andrew Rayskiy \u003cgreengrape@google.com\u003e\nOwners-Override: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nReviewed-by: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1225432}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fb46735ba84cfa0d3649a8e90e8cd8297ea8e821\n" }, { "commit": "181c5bb30688c295b42236d2c688b7ef3b694895", "tree": "7fa4cbf616aad4bcc50979476e7dadcfdbfef239", "parents": [ "e0ef74f6aec05a5f0775abd82929659e03200f8e" ], "author": { "name": "Ho Cheung", "email": "uioptt24@gmail.com", "time": "Thu Oct 19 15:22:31 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 19 15:31:32 2023" }, "message": "[base] Rename DIR_SOURCE_ROOT to DIR_SRC_TEST_DATA_ROOT in //components\n\nBug: 1264897\nChange-Id: Idb376073c1a6d058c1aca2818e5b220ca948af71\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4952178\nReviewed-by: Alex Ilin \u003calexilin@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Ho Cheung \u003cuioptt24@gmail.com\u003e\nCr-Commit-Position: refs/heads/main@{#1212167}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e5c93572b3c5bc9341e5a1a94aae3d4866796fc5\n" }, { "commit": "e0ef74f6aec05a5f0775abd82929659e03200f8e", "tree": "1e804dcc3adff2900d7816f13513b39bacb28dcb", "parents": [ "9576af3db9f643c79c13ee56bfdfd0e19c158de9" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Sep 15 15:26:13 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 15 15:41:00 2023" }, "message": "zucchini: Stop using basic_string\u003cunsigned char\u003e\n\nlibc++ is removing basic_string\u003c\u003e support for types that aren\u0027t\nchar, wchar_t, char8_t, char16_t, char32_t.\n\nWhile InducedSuffixSort does need an unsigned type, nothing here\nneeds the zero-termination of basic_string\u003cunsigned char\u003e, so just\nswitch to a vector\u003c\u003e instead.\n\nBug: 1481891\nChange-Id: If43fa7178c9ab154a6a85056fadf55378fbda33b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864394\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1197162}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5251c49a94f7f83a1fafd9c4a2f08d8562c6a4f1\n" }, { "commit": "9576af3db9f643c79c13ee56bfdfd0e19c158de9", "tree": "7e299d2a56e8e1152ac66e47a6b8809331e2bcdd", "parents": [ "b5ee843025dd51a2dc96cb198253f8f5845ec922" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Aug 07 09:21:07 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 07 09:26:53 2023" }, "message": "Ban [w]ctype.h: components/\n\nBug: 1361094\nChange-Id: I216d1c5c06b7713f3c1255f8ea15ed94b0e20222\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4748924\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1180186}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1808cd89751cb40af74dc25403de19787cf2befe\n" }, { "commit": "b5ee843025dd51a2dc96cb198253f8f5845ec922", "tree": "a6960978c6692c3bd959b49e95b8ac3d74687ad4", "parents": [ "c9f5ffbd97f6b6f774686175c021aaf7632bdb6a" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Fri Jun 02 15:43:30 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 02 15:49:24 2023" }, "message": "[Zucchini] Remove misaligned memory access from casted pointers: Part 2/2.\n\nThis CL finishes fixing aligned memory access failure brought on by:\n\n *reinterpret_cast\u003cT*\u003e(*uint8_ptr)\n\nPart 1 (crrev.com/c/4567104) has treated direct memory access via helper\nfunctions (e.g., GetValue\u003cT\u003e(), PutValue\u003cT\u003e()) by replacing the above\nwith memcpy().\n\nPart 2 (this CL) treats indirect memory access via helper functions\nGetPointer\u003cT\u003e() and GetArray\u003cT\u003e(). Guided by mvanbem@\u0027s suggestion,\ninstead of eradicating reinterpret_cast\u003cT*\u003e use (and making massive\nchanges to callers), we start by simply adding the compile-time check\n\n static_assert(alignof(T) \u003d\u003d 1)\n\nto GetValue\u003cT\u003e() and PutValue\u003cT\u003e(). The prevalent use of\n\"#pragma align(push, 1)\" for executable file format structs ensures\nalignof(T) \u003d\u003d 1 for these structs, i.e., the compiler assumes member\nmember variables access may be unaligned, and therefore won\u0027t emit\nalignment-sensitive instructions that will trigger SIGBUS at runtime.\n\nThe check fails if T were multi-byte POD types (e.g., uint32_t).\nPreviously this happens in two cases, which we resolved in this CL:\n1. BufferSourceTest.Get{Pointer,Array}Integral: T \u003d uint32_t, and the\n check fail. The solution is to wrap uint32_t into new struct\n UnalignedUint32T inside a \"#pragma align(push, 1)\" block, then use\n the struct (and access the internal |value|).\n2. dex::CodeItemParser::GetNext() calling GetArray\u003cuint16_t\u003e(): The\n intent of this call is to skip |code_item-\u003einsns_size| 2-byte units,\n and if the skip runs out of data, return error. Recently in\n crrev.com/c/4568608 we\u0027ve updated Skip() to return false on \"out of\n data\". The solution is to use Skip() instead. A (passing) usage\n of GetArray\u003cdex::TryItem\u003e() is similarly replaced.\n\nFixing the above eliminates multi-byte POD usage for GetPointer\u003cT\u003e() and\nGetArray\u003cT\u003e(), so for now we don\u0027t need to worry about them. If the need\narises, we can add some \"Unaligned\" wrapper template in the future.\n\nAlso, add BufferSourceTest.Get{Pointer,Array}IntegralMisaligned to\nexercise misaligned (re. 4-byte boundary) access succeeding by using a\nUnalignedUint32T wrapper.\n\nBug: 1446782\nChange-Id: Id19a8b52eac4f43f446a9a59934f5d32f32ad6d7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583255\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1152557}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4cdf8ae836e6e945bcfa6b6da8f3097b79f22f84\n" }, { "commit": "c9f5ffbd97f6b6f774686175c021aaf7632bdb6a", "tree": "964bd8800f6f6d7e97019e10c0b0643d98fcbbbc", "parents": [ "a968b13bc93982907b538bf6dbca71b3daf2a196" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed May 31 04:14:21 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 31 04:18:27 2023" }, "message": "[Zucchini] Refactor BufferSource::Skip().\n\nBufferSource::Skip() had two main uses:\n 1. Advance cursor by a known number of bytes.\n 2. Seek to an absolute offset of an image, e.g., via:\n source \u003d std::move(BufferSource(image).Skip(offset));\nTo support (2), Skip() returned ref to |*this| for chaining.\n\nIn retrospect, (2) was a kludge to get BufferSource::Seek(), which in\nturn was absent because BufferView is implemented as a \"shrinking range\"\n(2 fields) instead of a \"fixed range with cursor\" (3 fields).\n\nThis CL makes some simple cleanup to Skip() by doing the following:\n* Restrict Skip() to (1) by changing its return type to bool to indicate\n whether the skip would have exceeded bound.\n* Do (2) a different way: Add new BufferSource CTOR that takes an offset\n param, so the above usage becomes:\n source \u003d BufferSource(image, offset);\n* Down-cast BufferSource CTOR that takes ConstBufferView: Change to take\n const ref instead of value, for consistency.\n* Update callers.\n* Update BufferSourceTest.Skip and other tests that use Skip().\n* Add BufferSourceTest.{CtorWithOffset, SkipAcrossEnd}.\n\nBug: 1446782\nChange-Id: I53774baf3b0219a01079ae833d8289df7d13f27c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568608\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1151063}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c019fe91c5fa29d095613266833815512bdde1b6\n" }, { "commit": "a968b13bc93982907b538bf6dbca71b3daf2a196", "tree": "b43699922f7d53979123446bf8a8fbf2bb582517", "parents": [ "9170b2d639d2035337701e25722f84b78dc7e933" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Fri May 26 13:52:59 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 26 13:59:24 2023" }, "message": "[Zucchini] Remove misaligned memory access from casted pointers: Part 1/2.\n\nPreviously Zucchini copiously accessed memory via:\n\n *reinterpret_cast\u003cT*\u003e(*uint8_ptr)\n\nAlthough this worked for x86 / x64, the code isn\u0027t portable, as it can\nlead to unaligned memory access on other architectures (e.g., ARM).\nIndeed, recent Puffin test failures are caused by this.\n\nThis CL mitigates the problem by replacing direct read/write on casted\npointers with explicit memcpy() (amenable to compiler optimization for\nfixed size). Note that Zucchini still assumes that it\u0027s executing on a\nlittle-endian architecture. Details:\n\n* BufferViewBase (for {Const,Mutable}BufferView):\n * read(), write(): Use memcpy().\n * modify(): Remove.\n * Replace the 2 usages in RelocWriterElf::PutNext with write() using\n member field offset.\n * Remove test BufferViewTest.Modify.\n* BufferSink: PutValue(): Use memcpy().\n* BufferSource: {CheckNextValue(), GetValue()}: Use memcpy().\n* Add BufferSourceTest.GetValueUnaligned and\n BufferSinkTest.PutValueUnaligned.\n\nIndirect read/write from BufferSource.{GetPointer(),GetArray()} will\nrequire more restructuring, and will be handled in a follow-up.\n\nBug: 1446782\nChange-Id: Icc006478e2494fcce73b429c33a43d355d0fbc60\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567104\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1149697}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2260db99caba02fcfde27d79b174e7a7e0e99acc\n" }, { "commit": "9170b2d639d2035337701e25722f84b78dc7e933", "tree": "1e39371a62ab3cf7ba4bd01998846c3648a6e7c5", "parents": [ "1e6def85517e07284598f210f60e276890d74608" ], "author": { "name": "James", "email": "deckerjames@google.com", "time": "Wed May 17 15:21:10 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 17 15:26:25 2023" }, "message": "Reland \"Converting ENABLE_PUFFIN_PATCHES flag to a runtime flag.\"\n\nThis is a reland of commit 08f64abfea00666c4b6f7ceb22e96c71d330cf51\n\nOriginal change\u0027s description:\n\u003e Converting ENABLE_PUFFIN_PATCHES flag to a runtime flag.\n\u003e\n\u003e Bug: 1349060,1320481\n\u003e Change-Id: Ibd0921eefe1eac7f0164b7052ae5f8ebab492c89\n\u003e Binary-Size: Replacing courgette patches for component/extension delta updates with the more efficient and easier-to-verify puffin patches.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4521778\n\u003e Reviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\n\u003e Reviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\n\u003e Reviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\n\u003e Reviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n\u003e Code-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Commit-Queue: James Decker \u003cdeckerjames@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1144853}\n\nBug: 1349060,1320481\nChange-Id: I6113b59f8defac2ce6b29532917b9c60f6bc6a0a\nBinary-Size: Replacing courgette patches for component/extension delta updates with the more efficient and easier-to-verify puffin patches.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4540486\nCommit-Queue: James Decker \u003cdeckerjames@google.com\u003e\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Nate Fischer \u003cntfschr@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1145350}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a78e60c3ac1504174f0cb8af2e95ae1af05d2c53\n" }, { "commit": "1e6def85517e07284598f210f60e276890d74608", "tree": "438d99b8c2ca66ec4c4d0cc8c0359fb5401b0d17", "parents": [ "fd17649e4aec11c86a10912399e750287c6b3dab" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon May 15 07:17:34 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 15 07:24:00 2023" }, "message": "Use string_util.h functions in place of [w]ctype.h ones.\n\nThese callsites use types larger than unsigned char, and are thus not\nsafe to pass directly to e.g. absl::ascii_XXX() without a cast. The base\nfunctions will work.\n\nThis requires adding a couple more such utility functions.\n\nAX-Relnotes: n/a.\nBug: 1361094\nChange-Id: I63de36c231e5630b3cedf432d7363d8b3960e814\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529187\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1143894}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7bc1e16a5d317296c048541110c071c07aba1b1d\n" }, { "commit": "fd17649e4aec11c86a10912399e750287c6b3dab", "tree": "fcfa19ad4a931d421d85fd2e89ff668891ffc259", "parents": [ "1dd5e794ed9f3a8db72eb6e66113fe28ca161876" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Wed May 03 16:59:17 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 03 17:04:10 2023" }, "message": "[zucchini][win] Handle disk errors during patch application\n\nUse Windows structured exception handling to catch disk I/O and disk\nfull errors that fly during patch application rather than crashing the\nprocess. While this will do nothing to improve stability overall, it\nwill reduce resource consumption on end-user devices and in crash\nprocessing infrastructure. It will also reduce noise in installer\ncrashes, making it easier to spot actionable crashes.\n\nBug: 893277\nChange-Id: I5516940a782c2e87b5c357ae88c478d41a452149\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4497361\nAuto-Submit: Greg Thompson \u003cgrt@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1138953}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0f90118ee09a2c6c562bde6ea27b5192f6927b68\n" }, { "commit": "1dd5e794ed9f3a8db72eb6e66113fe28ca161876", "tree": "b06276c4e9cc219e94e19dcc9391353fef2f574d", "parents": [ "c378669c050ac8d7d7d44d3b85e8271a32cd8947" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Thu Apr 13 16:25:46 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 13 16:41:08 2023" }, "message": "[Zucchini] Fix DCHECK caused by improperly shifted emptied equivalences.\n\nIn OffsetMapper, each |equivalences| item maps from a src range to a\ndst range, with the same length. Dst ranges don\u0027t overlap, and\nPruneEquivalencesAndSortBySource() truncates items to remove src range\noverlaps. Emptied ranges are removed.\n\nSuppose |current| precedes |reduced| and covers it. To trim |reduced|,\nthe original logic was:\n\n delta \u003d current.src_offset + current.length - reduced.src_offset\n reduced.length -\u003d min(reduced.length, delta)\n reduced.src_offset +\u003d delta\n reduced.dst_offset +\u003d delta\n\nA subtle problem is that if both |delta| and |reduced.dst_offset| are\nlarge, and the |reduced| gets emptied, then |reduced.dst_offset| can\noverflow (value won\u0027t be unused, but this is still bad). So in\ncrrev.com/c/4393161 we changed this to:\n\n delta \u003d current.src_offset + current.length - reduced.src_offset\n capped_delta \u003d min(reduced.length, delta)\n reduced.length -\u003d capped_delta\n reduced.src_offset +\u003d capped_delta\n reduced.dst_offset +\u003d capped_delta\n\nHowever, this is causing DCHECK to fail, because if a range gets emptied\nthen |equivalences| may no longer be sorted by |src_offset|!\n\nThis CL fixes the issue by effectively changing the above to:\n\n reduced.src_offset +\u003d delta\n\nThis way, when ranges are non-empty, there\u0027s no change in behavior; and\nwhen ranges are empty, we\u0027d avoid the |dst_offset| overflow while also\nkeep |equivalences| sorted by |src_offset| throughout processing.\n\nBug: 1432457, 1429086\nChange-Id: Id61fc0c3466787117ff9d7c5efee66fef8873136\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418488\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1129897}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4ec735904c32d771e71ebb2954d02bef3d8f0993\n" }, { "commit": "c378669c050ac8d7d7d44d3b85e8271a32cd8947", "tree": "473b3510ac0e1ee25da5005c60f2287040652106", "parents": [ "104184464f98cee1854a7f1845b0dd33c5a8623a" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Apr 05 18:47:32 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 05 18:53:44 2023" }, "message": "[Zucchini] Increase Version from 1.0 to 2.0.\n\ncrrev.com/c/4393161 fixed a sort non-determinism that can cause patch\nfailure across same-source Zucchini binaries built with different\ncompiler versions (esp. std::sort() changes). To prevent hidden\nsurprises, this CL increases major version from 1 to 2.\n\nBug: 1429086, 1231882\nChange-Id: Ia1ed92cd3cc6b82409eb033eb4d424a8b1698fb3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4403919\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1126720}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f3c83081a6e59d2993b0f60e26a30a7543222f1\n" }, { "commit": "104184464f98cee1854a7f1845b0dd33c5a8623a", "tree": "e7bb16d63d90b411d27cea6ec60ab9a962fe72e8", "parents": [ "4dc4e753a49a8fc66d317ec541313f7fef5738c6" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Tue Apr 04 15:25:32 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 04 15:32:58 2023" }, "message": "[Zucchini] Fix sort non-determinism in OffsetMapper.\n\nThanks to yngve@vivaldi.com\u0027s investigation, a non-deterministic\nbehavior in OffsetMapper was found: In\n\n OffsetMapper::PruneEquivalencesAndSortBySource(),\n\nthe param |equivalences| was sorted only by |src_offset|, which may not\nbe unique (unlike |dst_offset|). Owing to recent std::sort() changes, a\npatch generated by old Zucchini may fail to apply by new Zucchini!\n\nA simple fix is to use std::stable_sort(), but this can lead to more\nmemory usage. Therefore we continue to use sort(), and fix the\ncomparison function to include all of Equivalence. So after sort,\n|equivalences| elements are ordered by:\n * Ascending |src_offset|: Required by the pruning algorithm.\n * Descending |length|: Optimization to decrease pruning churn; this\n should not affect the result.\n * Ascending |dst_offset|: To impose total ordering (and fix the bug).\n\nAlso:\n* PruneEquivalencesAndSortBySource(): Improve robustness:\n * Explicitly skip emptied |current|.\n * When clipping |reduced|, use |capped_delta| instead of |delta|.\n* In EquivalenceMapTest.PruneEquivalencesAndSortBySource, add test case\n that permutes 4 equivalences with the same |src_offset| and |length|.\n* Note that EquivalenceMap::SortByDestination()\u0027s sort() can be left\n as-is, since |dst_offset| values are distinct.\n\nBug: 1429086\nChange-Id: I64c5888cdd9bb0752270caea94eedeb4d797494e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4393161\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1125991}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 517aec690f8ef3c33378f6f54855528170636bc8\n" }, { "commit": "4dc4e753a49a8fc66d317ec541313f7fef5738c6", "tree": "bae9dc1f6522af8991c862143c3145833eb02f61", "parents": [ "70ba62e6665f40c1ff11750bdc7fe0d77caf74ed" ], "author": { "name": "Keishi Hattori", "email": "keishi@chromium.org", "time": "Fri Mar 24 12:23:35 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 24 12:35:43 2023" }, "message": "Add RAW_PTR_EXCLUSION to files in components/\n\nAdd RAW_PTR_EXCLUSION to files in components/ where the rewriter could not automatically rewrite.\n\nChange was generated by processing the output of the rewriter.\n\nBug: 1273182\nChange-Id: I4d75a27f1f634f9ed7636abb113ca9e6a8b0fb49\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4170101\nCommit-Queue: Keishi Hattori \u003ckeishi@chromium.org\u003e\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1121633}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9b33657435b03fa7e7701161c76772aefe1d385b\n" }, { "commit": "70ba62e6665f40c1ff11750bdc7fe0d77caf74ed", "tree": "9a140e1f2b0b5e0dc73b485c58a0fcdfffc5cc76", "parents": [ "0d2de6a19f8952d8bdad09c11b29f8747355dc8d" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Mar 06 13:54:26 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 06 14:00:39 2023" }, "message": "Use base::ranges::transform(): components/\n\nBug: 1368812\nChange-Id: I4ae7812b08ee0dddcb019efd2cbeac186d6e5d0e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4308300\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1113353}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3eddaf157a73ac053d1db3da665b2a07443ee49b\n" }, { "commit": "0d2de6a19f8952d8bdad09c11b29f8747355dc8d", "tree": "1ca3bdf3391df15a4adc223fead826a3b5fb54bc", "parents": [ "567d679baba35bc67eed17ab3daa4dd860cc80f4" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Feb 15 19:08:11 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 15 19:14:06 2023" }, "message": "Introduce the raw_ptr attribute AllowPtrArithmetic.\n\nThis will help flag places that are better suited for conversions\nto span\u003c\u003e or other containers and prevent the growth of new usages.\n\nThis CL flags the places that require pointer arithmetic, but stops\nshort of banning it entirely. A future CL will refuse to compile\npointer arithmetic against raw_ptrs that lack this attribute.\n\nChange-Id: Iff4a671280930df6eeacb04ff52dfa863da2b1dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4229951\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1105779}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 09c200aef72e385f9549cdf21f14c1c15d90558b\n" }, { "commit": "567d679baba35bc67eed17ab3daa4dd860cc80f4", "tree": "fbbf85909e3ed47a07bc2c7294eaf9aed84ada16", "parents": [ "86fa54b1b351999eff1a35cbb1cfb233a8b18a6f" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed Jan 11 09:16:09 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 11 09:20:44 2023" }, "message": "Update header includes for /base/functional in /components\n\nbind.h, callback.h, callback_forward.h, and callback_helpers.h\nmoved into /base/functional/. Update the include paths to\ndirectly include them in their new location.\n\nBug: 1364441\nChange-Id: I3179c6b5879e1e2d5a5f4990484b9a85f8548809\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4152595\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1091229}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 12be03159fe22cd4ef291e9561762531c2589539\n" }, { "commit": "86fa54b1b351999eff1a35cbb1cfb233a8b18a6f", "tree": "e7f666e69ed4ab1c7cae51b17c0107a2d2ea01c1", "parents": [ "9e999a72213315d0ed5ccb4613e0ac120afe8a1a" ], "author": { "name": "Will Harris", "email": "wfh@chromium.org", "time": "Wed Nov 16 00:54:21 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 16 01:00:35 2022" }, "message": "Create zucchini64.exe for Windows builds.\n\n32-bit zucchini.exe can run out of memory when constructing a patch.\n\nThis CL ensures that there is always a 64-bit zucchini64.exe in the\nout directory for both 32-bit and 64-bit builds. For compatibility, a\nzucchini.exe also exists, but might be 32-bit or 64-bit depending\non the build configuration.\n\nOn 64-bit, the zucchini.exe target is copied to zucchini64.exe.\n\nOn 32-bit, a custom target label is created that creates\na 64-bit zucchini.exe using a 64-bit toolchain, then this is\ncopied to zucchini64.exe in the main outdir.\n\nA future CL will update the builders to always use zucchini64.exe\nwhen constructing diff patches.\n\nBUG\u003d1378898\n\nChange-Id: I66a034307c67b819736001c6a3432401978cc26b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027674\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1071955}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 62dfa046f4e16be70a6da96de8324b65cfa243c7\n" }, { "commit": "9e999a72213315d0ed5ccb4613e0ac120afe8a1a", "tree": "8225d76a5bffaf019f2313337995638eecc9d9a8", "parents": [ "c94c22518be97656825856c9d3a4fb8a2f89db1d" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Wed Nov 09 01:27:44 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 09 01:33:59 2022" }, "message": "Rewrite T\u0026 into raw_ref\u003cT\u003e under components/\n\nThe changes were generated by running\ntools/clang/rewrite_raw_ref_fields/rewrite-multiple-platforms.sh with\ntool-arg\u003d--enable_raw_ref_rewrite\n\n`raw_ref` is a smart pointer for a pointer which can not be null, and\nwhich provides Use-after-Free protection in the same ways as raw_ptr.\nThis class acts like a combination of std::reference_wrapper and\nraw_ptr.\n\nSee raw_ptr and //base/memory/raw_ptr.md for more details on the\nUse-after-Free protection.\n\nBug: 1357022\nChange-Id: I189d2c17d56ec341f61bdadff2a98abceaa178a7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3998933\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1068923}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a709b48b2a6cdd03115e9c3ba4805687ba26e7bb\n" }, { "commit": "c94c22518be97656825856c9d3a4fb8a2f89db1d", "tree": "dce42bfbe01496c46d94c193af26e6833dbdb7a4", "parents": [ "8192c74bee1c8cbe12866dba3fcb1d83d5300051" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Nov 02 20:24:33 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 02 20:29:32 2022" }, "message": "[Zucchini] Fix BufferSourceTest.GetSleb128 test for improper negation.\n\nThe test BufferSourceTest.GetSleb128 previously used\n\n -static_cast\u003cint32_t\u003e(0x80000000).\n\nThe negation is redundant and invalid since signed 0x80000000 is\nalready negative, and negation can trigger lint / sanitizer warnings.\nThis CL fixes the issue by removing \"-\".\n\nChange-Id: I91a04f26152da2a104750f7edf42aebc9e3cad57\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3997020\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1066652}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 40faae2c37631a6a14d3885606574ac66ccc462d\n" }, { "commit": "8192c74bee1c8cbe12866dba3fcb1d83d5300051", "tree": "25219dfa082548b4e954bc704c6aa0b993df7915", "parents": [ "0002cbec153f7f55e131c29e84a0f1a2194795cb" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Mon Oct 31 17:30:13 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 31 17:35:03 2022" }, "message": "[Zucchini] Add Zucchini-suffix-array tool.\n\nThis CL adds the -suffix-array tool that computes the suffix arrays of\nan input file. We want to use this to test speed and peak memory of\nsuffix array calculation, so no additional output is created.\n\nAlso refactor zucchini_commands.cc. Details:\n* zucchini_commands.cc:\n * Add WrappedMappedFileReader to wrap zucchini::MappedFileReader, to\n take and open input base::FilePath, and handle error message output.\n * Replace repetitive file open code to use WrappedMappedFileReader\n (5 instances).\n * Add MainSuffixArray() to implement new command.\n* main_utils.cc: Update |kCommands| to add new command entry.\n\nBug: 1378898\nChange-Id: I9664f920f0391d3907ef6cdeddcb2b4450352262\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3988770\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1065539}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0fe9ae92ae5e4cec70f152c8588743c5550cd000\n" }, { "commit": "0002cbec153f7f55e131c29e84a0f1a2194795cb", "tree": "c3c4db699a07ac5a3124e6e690df6a67cfd66cb3", "parents": [ "646f0ae508ac0ac57250533d12cfe3723938e8df" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Sat Oct 29 01:45:01 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Oct 29 01:50:44 2022" }, "message": "Replace std::copy() with base::ranges::copy(): components/\n\nBug: 1368812\nChange-Id: I182c9354ced282777bd472df37e96351a48edddf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3988417\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1065132}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f54ba6adfa8f619fd7f6993649bdc68e1b3a167\n" }, { "commit": "646f0ae508ac0ac57250533d12cfe3723938e8df", "tree": "faf2016472dffc907a2f4ee1e18132abe5e437f8", "parents": [ "c91d293190b287fe416321516bcb52ee5ebcfa3d" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Oct 26 17:07:02 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 26 17:13:47 2022" }, "message": "Replace std::equal() with base::ranges::equal(): components/\n\nBug: 1368812\nChange-Id: Idcb6ef03847cf0489ea2358989b69d3c3876b243\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3980296\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1063867}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 39271e153dd29a1f7949cbaaadb1798d83773b1a\n" }, { "commit": "c91d293190b287fe416321516bcb52ee5ebcfa3d", "tree": "babc5925737b82128cc4b9bf1f13842f210585a1", "parents": [ "eb48152ca6ad33ff4c9d582eecca148e52e1ce44" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 21 19:05:50 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 21 19:10:33 2022" }, "message": "Convert std::mismatch() to base::ranges::mismatch.\n\nNot only is this more ergonomic, it\u0027s safer in the cases where callers\nwere previously using the three-iterator versions of mismatch(): it\u0027s\nguaranteed not to read off the end of the second container.\n\nBug: 1368812\nChange-Id: I6ad1aff6771596abbb7379949bb955cdde33ec20\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3966273\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: James Forshaw \u003cforshaw@chromium.org\u003e\nReviewed-by: Dan McArdle \u003cdmcardle@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1062285}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0078ad4a816b91fc555ef74ae885b53a1837573c\n" }, { "commit": "eb48152ca6ad33ff4c9d582eecca148e52e1ce44", "tree": "e4bfb2864fc925efa424c302377c828402621c05", "parents": [ "33d191f2715ae394132f9941b9979c6be17946ad" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Thu Oct 20 20:14:36 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 20 20:19:58 2022" }, "message": "Change std::adjacent_find() to use base:: functions.\n\nSimplifies code slightly.\n\nBug: 1368812\nChange-Id: I50c455f8cf7b092b3334b882462ba464d3a7b142\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961574\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nReviewed-by: Justin Novosad \u003cjunov@chromium.org\u003e\nReviewed-by: Charlie Reis \u003ccreis@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1061768}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9b9644f912a7d29921c27037a4c3fc6a36e8cbb7\n" }, { "commit": "33d191f2715ae394132f9941b9979c6be17946ad", "tree": "3bcc2e677e7ffd49163014e895445445686ab78f", "parents": [ "211c287d3d9981b2cf85bc6e3fda9b47a53583c2" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Oct 19 08:45:35 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 19 08:51:56 2022" }, "message": "Convert std::count*() to base:: functions: components/\n\nBug: 1368812\nChange-Id: Ie645e1b48ea821901dea31801d2e1e3ae97f0966\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3964713\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1060906}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c6c2d0af86b12eafced06f71e7a1c063e4eb8c80\n" }, { "commit": "211c287d3d9981b2cf85bc6e3fda9b47a53583c2", "tree": "15d946fc1eac04c145e6e22da686b30ae773460e", "parents": [ "5bb6e37f91127d3c691fec17f13d82a94cdbadd3" ], "author": { "name": "Peter Williamson", "email": "petewil@chromium.org", "time": "Fri Oct 14 23:30:09 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 14 23:36:19 2022" }, "message": "Revert \"Change std::adjacent_find() to use base:: functions.\"\n\nThis reverts commit b68638c6b28931a4b1e5d77323871c06b3d8ce94.\n\nReason for revert: Fails to compile on some builders: Details\nin the bug here: https://bugs.chromium.org/p/chromium/issues/detail?id\u003d1374976\n\n[67685/87673] CXX obj/chrome/browser/win/conflicts/unit_tests/installed_applications_unittest.obj\nFAILED: obj/chrome/browser/win/conflicts/unit_tests/installed_applications_unittest.obj\nC:\\b\\s\\w\\ir\\cache\\goma\\client\\gomacc.exe ..\\..\\third_party\\llvm-build\\Release+Asserts\\bin\\clang-cl.e...(too long)\n../../chrome/browser/win/conflicts/installed_applications_unittest.cc(401,31): error: no matching function for call to \u0027equal\u0027\napplications, std::equal\u003c\u003e(), [](const auto\u0026 app) {\n^~~~~~~~~~~~\n../..\\third_party/googletest/src/googletest/include/gtest/gtest.h(1840,69): note: expanded from macro \u0027EXPECT_EQ\u0027\nEXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)\n\nOriginal change\u0027s description:\n\u003e Change std::adjacent_find() to use base:: functions.\n\u003e\n\u003e Simplifies code slightly.\n\u003e\n\u003e Bug: 1368812\n\u003e Change-Id: If642caa93e99f178cdf8832846649a076976471c\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3953856\n\u003e Reviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\n\u003e Reviewed-by: Charlie Reis \u003ccreis@chromium.org\u003e\n\u003e Reviewed-by: Justin Novosad \u003cjunov@chromium.org\u003e\n\u003e Reviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\n\u003e Auto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\n\u003e Commit-Queue: Justin Novosad \u003cjunov@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1059394}\n\nBug: 1368812\nChange-Id: Ie4223f306e4c8dd749a09271a881d214294f5f93\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956667\nCommit-Queue: Peter Williamson \u003cpetewil@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nOwners-Override: Peter Williamson \u003cpetewil@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1059528}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a3f8aab18eadec7ea1335f02499b9b7606d189fa\n" }, { "commit": "5bb6e37f91127d3c691fec17f13d82a94cdbadd3", "tree": "e1a6948e82b1a65c4eadbeb262d0f72c5ecf1b62", "parents": [ "699050959e32f919a0fbaaa3a30c38b0f7faac63" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 14 18:53:29 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 14 19:01:54 2022" }, "message": "Change std::adjacent_find() to use base:: functions.\n\nSimplifies code slightly.\n\nBug: 1368812\nChange-Id: If642caa93e99f178cdf8832846649a076976471c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3953856\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nReviewed-by: Charlie Reis \u003ccreis@chromium.org\u003e\nReviewed-by: Justin Novosad \u003cjunov@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Justin Novosad \u003cjunov@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1059394}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b68638c6b28931a4b1e5d77323871c06b3d8ce94\n" }, { "commit": "699050959e32f919a0fbaaa3a30c38b0f7faac63", "tree": "15d946fc1eac04c145e6e22da686b30ae773460e", "parents": [ "ea29e4bc6cdfea64c34982c5dee302d7acb21398" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Thu Sep 22 01:13:05 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 22 01:31:13 2022" }, "message": "Change std::find_if*() to use base:: functions: components/\n\nGoal: Slightly simpler and/or more semantically-accurate code.\n\nBug: none\nChange-Id: I93ee0c087d4d073b7fa39757f6e5a0f92348cea5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911876\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Ted Choc \u003ctedchoc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1049992}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 738d5cbcf26c666fbb7bb6cf6302da777c21a515\n" }, { "commit": "ea29e4bc6cdfea64c34982c5dee302d7acb21398", "tree": "61d1618795f63d6bc909569abf9f730890b01833", "parents": [ "a2c5e69b18b47625904513234f88658bcce8cab1" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Sep 13 19:22:36 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 19:38:34 2022" }, "message": "Update copyright headers in components/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c34.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: If6a3370b0b2849d889ce797596fe1ccbad2f3fe6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891619\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1046502}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ba1bad80dc22235693a0dd41fe55c0fd2dbdabd\n" }, { "commit": "a2c5e69b18b47625904513234f88658bcce8cab1", "tree": "b3c0d26fb38ba38800bb5a0135fe751e5dca96bd", "parents": [ "c12fd3a130d9387f1de51255d7aaf99a5c4412ae" ], "author": { "name": "Javier Flores Assad", "email": "floresa@microsoft.com", "time": "Wed Aug 24 16:42:00 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 24 16:49:41 2022" }, "message": "Zucchini: Add the default EXE manifest\n\nThis change adds an executable manifest to zucchini.exe so if any of the\ncode it calls uses Windows version checking functions they work as\nintended.\n\nWithout a manifest the Windows functions returns version 8.2 for most\nversion checking APIs and helpers. Refer to the remarks section:\nhttps://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-verifyversioninfoa\n\nThe lack of a manifest caused zucchini patch generation to hit OOM due\nto a recent change in PartitionAlloc which uses Windows version check\nfunctions.\n\nIt is better for EXEs to have a compatibility manifest to avoid these\nsort of problems and surprises.\n\nChange-Id: I2029f86663dfa4419777494463f55a90b3700acb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852419\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Javier Flores Assad \u003cfloresa@microsoft.com\u003e\nCr-Commit-Position: refs/heads/main@{#1038813}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5736ae82072fcd980e165eb2494da1ba5f1020f9\n" }, { "commit": "c12fd3a130d9387f1de51255d7aaf99a5c4412ae", "tree": "28236c1bf9c158141809384c07abbd5331cf06a6", "parents": [ "0fcc66c5a2640ff1debc11875326d72d613a3016" ], "author": { "name": "Michael Chang", "email": "donchan@microsoft.com", "time": "Fri Jul 01 19:15:57 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 01 19:36:48 2022" }, "message": "Clean-up //third_party/lzma_sdk folder\n\nAs part of updating the lzma_sdk, clean up the folders and put them into different subfolders. This puts the files in a more similar\norganization to the original lzma sdk. Fix up other files to have\ncorrect includes.\n\nBug: 1334732\nChange-Id: If345eee3ae1b81f1de804b289880ea5755def49f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727278\nCommit-Queue: Dong Sung Chang \u003cdonchan@microsoft.com\u003e\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: David Roger \u003cdroger@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1020195}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3fa36902563c565b6c1e7811b7e431a533529a82\n" }, { "commit": "0fcc66c5a2640ff1debc11875326d72d613a3016", "tree": "22b979305d3df052f8c80984fe34b5c49e43d94d", "parents": [ "9145ecc7618257164a93a73bb46fc309d0e8cb14" ], "author": { "name": "Etienne Pierre-doray", "email": "etiennep@chromium.org", "time": "Sat Mar 26 01:10:19 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Mar 26 01:19:23 2022" }, "message": "[zucchini] Fold reference mixing in Disassembler.\n\nThis CL makes the mixer interface similar to ReferenceWriter/Reader,\nfolding reference mixing in Disassembler, as part of ReferenceGroup.\n\nChange-Id: I5920a47e5d926e0f3cc7c0a1bfe1aa4dc660c88d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3082269\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#985596}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c21432357aad1b1f2c27ea1701171fe518e06f73\n" } ], "next": "9145ecc7618257164a93a73bb46fc309d0e8cb14" }