)]}' { "log": [ { "commit": "620910f0490f251b0989930552f044e4eba98065", "tree": "85c72f453750a5471f9522ce6800d3f290a9411b", "parents": [ "0c3c9ee5da9fddef68406086392f43a94ed589b7" ], "author": { "name": "Elly", "email": "ellyjones@chromium.org", "time": "Tue May 26 18:42:02 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 26 18:44:13 2026" }, "message": "reporting: use one-shot crypto/aead APIs\n\nThe new APIs are functionally equivalent but simpler to call.\n\nAI-Model: antigravity\nBug: 475891208\nChange-Id: I523ddf0567359aa6c018fefdc8f6638815a30d36\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7875261\nReviewed-by: Nancy Xiao \u003cnancylanxiao@google.com\u003e\nAuto-Submit: Elly \u003cellyjones@chromium.org\u003e\nCommit-Queue: Elly \u003cellyjones@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1636344}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: aec1b1f65ef089671f313e2efcbbe2e31342d1a4\n" }, { "commit": "0c3c9ee5da9fddef68406086392f43a94ed589b7", "tree": "882e2646a84fecced142412e0ec935252e839916", "parents": [ "ec36456c8afdf2a129c7788bdcb69b3cfd45d75f" ], "author": { "name": "Jeffrey Yu", "email": "yuje@chromium.org", "time": "Mon Apr 20 18:19:26 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 20 18:22:55 2026" }, "message": "Change string to string_view to avoid an unnecessary copy.\n\n`.substr()` on a string_view returns another string_view instead of\ncreating a new string.\n\nBug: 501076278\nChange-Id: Iadaa8daf02426362f4b3730d043f9504143cb106\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7771167\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nCommit-Queue: Jeffrey Yu \u003cyuje@chromium.org\u003e\nAuto-Submit: Jeffrey Yu \u003cyuje@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1617631}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3b0895470229e10558a05baf2e3dcaf640cfb9ba\n" }, { "commit": "ec36456c8afdf2a129c7788bdcb69b3cfd45d75f", "tree": "b0e2dd91e4afe4d36b7dda9ea215a5b99a1eafd5", "parents": [ "bb8ee70f78400ca5467f69efe65a66ccb0590b84" ], "author": { "name": "Qiutan Wu", "email": "qiutanw@google.com", "time": "Thu Apr 09 21:03:59 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 09 21:07:34 2026" }, "message": "Add BrowserLaunchEvent proto and reporting destination.\n\nThis change introduces a new proto message, BrowserLaunchEvent, to capture information about browser launches, including the timestamp and command-line switches. A new reporting destination, BROWSER_LAUNCH, is added to the reporting pipeline to handle these events.\n\nBug: b:492329449\nChange-Id: Ibb1445ece5da17c06cf702e1d3c5d59055713ffa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7736364\nCommit-Queue: Qiutan Wu \u003cqiutanw@google.com\u003e\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1612499}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c6c9731d1b21adcf45328776e783489b6dfd22b2\n" }, { "commit": "bb8ee70f78400ca5467f69efe65a66ccb0590b84", "tree": "316e6d443844610a8253fe97a6a5ec5cfe83eaf9", "parents": [ "bf286610b0e1eb8c80c1f8f544741e8a1e2497a6" ], "author": { "name": "Yisi Yu", "email": "yuyisi@chromium.org", "time": "Thu Feb 12 01:53:51 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 12 01:58:51 2026" }, "message": "Replace some pointer-based HexEncode calls with span-based HexEncode in //components\n\nBug: 40284755\nChange-Id: I1343373ea434139aa22ca695169e34d1c2330cdf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7565698\nCommit-Queue: YISI YU \u003cyuyisi@chromium.org\u003e\nReviewed-by: Mustafa Emre Acer \u003cmeacer@chromium.org\u003e\nReviewed-by: Chris Fredrickson \u003ccfredric@chromium.org\u003e\nAuto-Submit: YISI YU \u003cyuyisi@chromium.org\u003e\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1583658}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 13cca0e34f38c9d9851c77de2f5e3158ed065391\n" }, { "commit": "bf286610b0e1eb8c80c1f8f544741e8a1e2497a6", "tree": "4d1777b6e5fbb1ac832df0c2756951152f040901", "parents": [ "6183f539988768a41710f399ed97dc8edd255f05" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Sun Jan 25 21:04:18 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sun Jan 25 21:10:14 2026" }, "message": "Use modern names for base::DictValue and base::ListValue\n\nThese classes were hoisted and renamed; switch all usage of these\nclasses to use the new names.\n\nThis is a strictly mechanical change, except for the\nforward-declarations in:\n- components/payments/core/payment_item.h\n- components/payments/core/payment_shipping_option.h\n- components/permissions/contexts/bluetooth_chooser_context.h\n\nBug: 478100525\nChange-Id: Ia625a95906e56d1070af420eb2c0c1c9f19d7e31\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7514604\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1574269}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d8289648ec52bbac47a8039ba7858f6d348f593d\n" }, { "commit": "6183f539988768a41710f399ed97dc8edd255f05", "tree": "e1df614048cf1c4ce9a85fb038e2513a254ebc07", "parents": [ "21f18224f37b2aec8f64ecb4d2c1f587b3a8fc2b" ], "author": { "name": "Elly", "email": "ellyjones@chromium.org", "time": "Wed Jan 21 22:13:53 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 21 22:20:19 2026" }, "message": "base: add RandIntInclusive alias for RandInt\n\nThis name makes it clearer that the function includes both endpoints.\n\nThis change also bulk-rewrites all references from base::RandInt to\nbase::RandIntInclusive.\n\nBug: 40283703\nChange-Id: Ieb64e5c2cee0d0dd3a6cf8e1c38ad6d1b3c5cddb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7494488\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Elly FJ \u003cellyjones@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1572569}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9d81d0b1e025b3b6800b560eac3e05b8dc2ed48e\n" }, { "commit": "21f18224f37b2aec8f64ecb4d2c1f587b3a8fc2b", "tree": "4b106a854e54f6f6d973541cb5af96b11e3a60e0", "parents": [ "1a658b5e70723ac5e393e3c302063c54070cbe01" ], "author": { "name": "Jan Zarzycki", "email": "janzarzycki@google.com", "time": "Fri Jan 16 07:51:02 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 16 07:56:01 2026" }, "message": "Rename SaaS domain report to SaaS usage report\n\nRenames message to SaasUsageReportEvent to align with the \"SaaS usage\nreport\" feature name.\n\nUpdates the SaasDomainMetrics message to include start and end\ntimestamps for the reporting period.\n\nRemoves content_transfer_count from the metrics as it will not be\ntracked by this feature.\n\nBug: 466008386\nChange-Id: I7e5b45972d1c5adf2d01914116e0a115fb62885f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7485132\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nCommit-Queue: Jan Zarzycki \u003cjanzarzycki@google.com\u003e\nReviewed-by: Igor Ruvinov \u003cigorruvinov@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1570214}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9e2d26da80e385085ebe566957d4572834b2726\n" }, { "commit": "1a658b5e70723ac5e393e3c302063c54070cbe01", "tree": "74187cc5b470cd2106f3cf76fe7dd4a90d805f32", "parents": [ "d28be7a87522897cf49afca1a6e1662fb4b8428e" ], "author": { "name": "Elly", "email": "ellyjones@chromium.org", "time": "Wed Jan 14 00:04:28 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 14 00:10:54 2026" }, "message": "reporting: base::RandInt(0, n - 1) -\u003e base::RandGenerator(n)\n\nbase::RandGenerator() is specifically for producing values in [0 - n).\n\nBug: 40283703\nChange-Id: I45779f8dabc371c3534326ace86714019f3b84d8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7459158\nCommit-Queue: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nAuto-Submit: Elly FJ \u003cellyjones@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1568789}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 15c004d1bc9b90b0d7a8f2e1032bef987651ee3b\n" }, { "commit": "d28be7a87522897cf49afca1a6e1662fb4b8428e", "tree": "5adedc2ea0810a52c86c511cc73ac7fc557cdb4c", "parents": [ "56a34e2df1be59d557dd48de963b55ec9b9399e1" ], "author": { "name": "Dejie Zhang", "email": "djzhang@google.com", "time": "Tue Jan 13 22:39:15 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 13 22:44:05 2026" }, "message": "Change reporting client side ownership.\n\nBUG: b:450289501\nChange-Id: I86d469e7eccd998d1dc917c33be380149523f15b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7454280\nReviewed-by: Nancy Xiao \u003cnancylanxiao@google.com\u003e\nCommit-Queue: Dejie Zhang \u003cdjzhang@google.com\u003e\nReviewed-by: Shanthanu Bhardwaj \u003cxanth@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1568734}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 01d05d17dc098481a3aa2ab5d6e7550631b81be5\n" }, { "commit": "56a34e2df1be59d557dd48de963b55ec9b9399e1", "tree": "4edaf77bb33f2d64461c3cf7e92b399584584d81", "parents": [ "c270bc4734df73a2161a89c77f442ae33489f1f5" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Wed Jan 07 17:35:56 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 07 17:41:54 2026" }, "message": "Migrate various base::Contains() to contains() in components\n\nBug: 470391351\nChange-Id: I918d786073d57b19a75ef5c2642c458a3611f1ed\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7404136\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1565735}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 16b7171f8e2cd5bb41279a7975dc9cf1f8c98b5d\n" }, { "commit": "c270bc4734df73a2161a89c77f442ae33489f1f5", "tree": "3240d75175a7e0abb75e32a59a321dfe43c71349", "parents": [ "5e1f7de57cd51642e8d01fe2aaa574857a73f076" ], "author": { "name": "Minseop Choi", "email": "minsubb13@gmail.com", "time": "Wed Dec 24 05:35:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 24 05:40:31 2025" }, "message": "components/storage: migrate to new crypto/hash APIs\n\nMigrate storage_queue from crypto/sha2 API to new crypto/hash API.\n\nBug: 372283556\nChange-Id: If73ec3eac1144dd7f4022f37199f0241e75bdcb3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7247227\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nReviewed-by: Elly FJ \u003cellyjones@chromium.org\u003e\nCommit-Queue: Minseop Choi \u003cminsubb13@gmail.com\u003e\nCr-Commit-Position: refs/heads/main@{#1562421}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ed186c69b6a4de8d04a41da41eaac7a5738dbb96\n" }, { "commit": "5e1f7de57cd51642e8d01fe2aaa574857a73f076", "tree": "5c1215c38df1c27e2faed2034817aa5464a31bae", "parents": [ "c80cc3c6f8d4fd0247d5cc00ac6bb0e97e3f11f1" ], "author": { "name": "Jan Zarzycki", "email": "janzarzycki@google.com", "time": "Fri Dec 12 07:43:39 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 12 07:51:45 2025" }, "message": "Add proto for SaaS domain usage reporting.\n\nIntroduces SaaSDomainReportEvent to capture aggregated metrics about SaaS domain usage, including profile details and per-domain metrics like visit counts, content transfers, and encryption protocols. Adds SAAS_DOMAIN to Destination enum in record_constants.proto to support this new report type.\n\nBug: 466008386\nChange-Id: I09bb93b220f683b670f9427455c4139354203507\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7252549\nCommit-Queue: Jan Zarzycki \u003cjanzarzycki@google.com\u003e\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nReviewed-by: Igor Ruvinov \u003cigorruvinov@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1557885}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 28b433409da09f78cc35711a208e2e354d56c81a\n" }, { "commit": "c80cc3c6f8d4fd0247d5cc00ac6bb0e97e3f11f1", "tree": "0c266c469ad28dd90bda4690336c888e24a6e504", "parents": [ "b23aeee82026e4c5b71afab51f7176de33cf825f" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Tue Dec 09 02:28:46 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 09 02:35:13 2025" }, "message": "Fix more IWYU issues\n\nThese issues came up while trying to replace base/types/expected.h with\n\u003cexpected\u003e. We might not adopt std::expected\u003c\u003e in the end, but this\nis still worth landing.\n\nHeaders added with `git grep` + `tools/add_header.py`\n- base/strings/strcat.h\n- base/strings/to_string.h\n- base/strings/string_view_util.h\n\nHeaders added manually in a few instances.\n- build/build_config.h\n- base/check.h\n- base/notreached.h\n- base/time/time.h\n- base/functional/callback_helpers.h\n\nChange-Id: I490cd1630d813dd6f07e57fe31f7677076597884\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228863\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1555861}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e8b169d1e8ed51cc6e49a169f10c4876e5a9e30f\n" }, { "commit": "b23aeee82026e4c5b71afab51f7176de33cf825f", "tree": "0f9a970ed62108d3fe7b0fd7f41b97376a145fa6", "parents": [ "72f67e42b3cc5d4cb2bb4b7a61ce8ad80defb915" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Dec 09 02:17:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 09 02:23:32 2025" }, "message": "Remove superfluous \u003cmap\u003e includes from //components headers\n\nRemove unnecessary includes. Then do IWYU to fix the build. Removal\nautomated with:\n\ngit ls-files components | grep \u0027\\.h$\u0027 | xargs grep -l \u0027\u003cmap\u003e$\u0027 | \\\n xargs grep -L std::map | xargs grep -L std::multimap | \\\n xargs tools/add_header.py --remove --header \u0027\u003cmap\u003e\u0027\n\nBug: 40318405\nChange-Id: I57a66308625c319056c023282c91ee24fcd06794\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7234717\nReviewed-by: Tommy Nyquist \u003cnyquist@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1555857}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3a4f9141339792d856a791f88d44693e7cb4b6c9\n" }, { "commit": "72f67e42b3cc5d4cb2bb4b7a61ce8ad80defb915", "tree": "6c824364cada7d58e84cc2284f468df80bb4ba8d", "parents": [ "d58cdf45394e25ca66cec73a0ad3ca1825f79ba6" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Fri Dec 05 10:49:40 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 05 10:59:00 2025" }, "message": "Migrate ResourceManagedBuffer to base::HeapArray\n\nThis change updates ResourceManagedBuffer to use\nbase::HeapArray\u003cuint8_t\u003e instead of std::unique_ptr\u003cchar[]\u003e for\nmanaging the buffer. It then uses the resulting span-based API to\nreplace pointer-based file API calls by span-based ones.\n\nNo functionality changes.\n\nBug: 435317390\nChange-Id: I72a33db0a6a08394ad4a04ad09cf861e52004c42\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7208436\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Jan Keitel \u003cjkeitel@google.com\u003e\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1554564}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2f0d85aaad72add1add5f18e69078ead83a7cba4\n" }, { "commit": "d58cdf45394e25ca66cec73a0ad3ca1825f79ba6", "tree": "c0a12b3e87a32611010e8cec7eaa021c0984996d", "parents": [ "abcd85172019c7c2d431e7ded5901daacea9b399" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Thu Dec 04 18:10:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 04 18:16:29 2025" }, "message": "Migrate file I/O to use base::span in reporting util file\n\nNo functionality changes.\n\nBug: 435317390\nChange-Id: Ib578d5a2d983ca61b93886b25fcd9b68ea3041f1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7213192\nReviewed-by: Shanthanu Bhardwaj \u003cxanth@google.com\u003e\nCommit-Queue: Shanthanu Bhardwaj \u003cxanth@google.com\u003e\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1554091}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d2d81d281b7e456da391c0e9e6a6945e31e9c5d0\n" }, { "commit": "abcd85172019c7c2d431e7ded5901daacea9b399", "tree": "1a408bf0e1a7900a3cee095d4fb9fe4f328fa129", "parents": [ "bec87bcc04176fd9e618d6cdb654f1da4c95ba6d" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Nov 28 19:28:39 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 28 19:47:48 2025" }, "message": "Avoid using //base internal headers outside of //base\n\nAvoid including headers that are meant to be internal. Either remove\nthem, or replace them with the appropriate header.\n\nChange-Id: Iaa724c5850c000cdf1d2245e96cfc6cf9a02afa7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7205157\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1551628}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b6242fa046a488acfd64233bde6784cf52626e59\n" }, { "commit": "bec87bcc04176fd9e618d6cdb654f1da4c95ba6d", "tree": "6921f71cfea1deb11961b6863b49c7a9e0ca76a0", "parents": [ "352da4abb72d2b555312f6d630067296ab6cc965" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Nov 26 01:32:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 26 02:01:29 2025" }, "message": "Remove includes of callback_forward.h from .cc files\n\nGenerally, .cc files should not be forward declaring base::OnceCallback\nand related classes. If they are using Callbacks, they should include\ncallback.h instead. So treat the base/functional/callback_forward.h\nincludes as superfluous and remove them.\n\nBug: 40318405\nChange-Id: I487c907e520d03be3db5b03a8757c7f2559c8278\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201005\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nReviewed-by: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1550173}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 16723c112a9691d3819d7117e2faf2aeecf1891a\n" }, { "commit": "352da4abb72d2b555312f6d630067296ab6cc965", "tree": "c7e4f2456322fff7516b38a29e88d721567400fd", "parents": [ "e169c5390260f1a02815c2c27062fc59be1feab2" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Nov 25 22:13:57 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 25 22:22:34 2025" }, "message": "Remove superfluous base/feature_list.h includes from various headers\n\nRemove base/feature_list.h includes from headers that do not reference\nbase::FeatureList, BASE_DECLARE_FEATURE, etc. Then do IWYU to fix the\nbuild.\n\nBug: 40318405\nChange-Id: Ic3246984e47519b41ee33b54805dcabe42782b87\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7190133\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1550068}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c550253dfa0571d25c979719865e0e3a93d7d0dc\n" }, { "commit": "e169c5390260f1a02815c2c27062fc59be1feab2", "tree": "9adb546aea62ecbf90ac317f35a3568cb6d9af41", "parents": [ "9c67ea99745719c4ae7b7368de05fa0aca6a1ca1" ], "author": { "name": "Daniel Angulo", "email": "angdaniel@google.com", "time": "Tue Nov 18 20:42:39 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 18 21:03:29 2025" }, "message": "fix of auto spanification for storage_unittest\n\nspanification: automatically spanify components/reporting/storage/storage_unittest.cc etc.\n\nThis is the result of running the automatic spanification on linux and\nupdating code to use and pass spans where size is known.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms\u003dlinux\nThen refined with gemini-cli\n\ngemini-run/batch-run-1761116551/group_110\n\nBUG\u003d439964610\n\nChange-Id: I9b4698e78e9b12e97d0289af54cfcf523b108b8f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7128061\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCommit-Queue: Daniel Angulo \u003cangdaniel@google.com\u003e\nReviewed-by: Stephen Nusko \u003cnuskos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1546743}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 77520af31e4849be2bf526748749656e738ea912\n" }, { "commit": "9c67ea99745719c4ae7b7368de05fa0aca6a1ca1", "tree": "87d1be2aaea3a169406ce74879b89882a7f34982", "parents": [ "fd31192f2e480ca50ebc46cbc7cfd13bf3a89601" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Nov 06 18:08:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 06 18:15:29 2025" }, "message": "Remove superfluous file_util.h includes in //components\n\nSince base/files/file_util.h mostly contains a list of functions that\nare labeled with BASE_EXPORT, one can make a list of these functions.\nOne can also easily make a list of files that include file_util.h. Then\nfor each file in the list, grep for the functions from the first list.\nIf there are no matches, then remove file_util.h with:\n\ntools/add_header.py --header \u0027\"base/files/file_util.h\"\u0027 --remove\n\nThen do IWYU to fix the build.\n\nBug: 40318405\nChange-Id: Iec44b717e10d8c5b88836d2b58de3234f46f5f79\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7119880\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1541295}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f1840b68d127bb01f2103ce5d2b9a541df7f0a7e\n" }, { "commit": "fd31192f2e480ca50ebc46cbc7cfd13bf3a89601", "tree": "9bb2269e1efa184b94299d0488f68a9e1c061e85", "parents": [ "12959f34570bf53a4744816b492f212a0ae1f389" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Nov 03 19:03:15 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 03 19:09:07 2025" }, "message": "Remove superfluous ref_counted.h includes from headers\n\nMostly automated with the following command:\n\ngit ls-files | grep \u0027\\.h$\u0027 | xargs grep -l base/memory/ref_counted.h | \\\n xargs grep -L RefCounted | \\\n xargs tools/add_header.py --header \u0027\"base/memory/ref_counted.h\"\u0027 \\\n --remove\n\nBug: 40318405\nChange-Id: I11b7dfe759c4d343339cab46548c1181a73082a8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097682\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1539491}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 40ee99b56e8cf002ad5c02bc7b640fd19a0478b0\n" }, { "commit": "12959f34570bf53a4744816b492f212a0ae1f389", "tree": "bc6ce4e3fa33c41e86c1f327ff7e2691d8189846", "parents": [ "a659169dd621494b3aaa221200a428b2c83a3b6f" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Oct 30 22:04:40 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 30 22:11:03 2025" }, "message": "Remove most base/files/file_util.h includes from headers\n\nMost headers do not need to include file_util.h. Instead, either include\nfile_path.h, or forward declare base::FilePath. Then do IWYU to fix the\nbuild. Also forward declare base::FileEnumerator in one case.\n\nChange-Id: I99193a8c5ee309fdba56b6f70cc753dc08983840\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7099339\nOwners-Override: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1538232}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: adb7e791ecf552ea3d97bf76aeca15c178241ca2\n" }, { "commit": "a659169dd621494b3aaa221200a428b2c83a3b6f", "tree": "73246c56de112e43fd5052a55160c489f3fa42ae", "parents": [ "80597d6a9c9c6b971043cb5bb2973b32a6267ea3" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Oct 24 17:30:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 24 17:36:04 2025" }, "message": "Do IWYU for base/sequence_checker.h in headers\n\nMostly automated with this command:\n\ngit ls-files | grep \u0027\\.h$\u0027 | xargs grep -l \u0027SEQUENCE_CHECKER(\u0027 | \\\n xargs grep -L base/sequence_checker.h | \\\n xargs tools/add_header.py --header \u0027\"base/sequence_checker.h\"\u0027\n\nAlso fix a \"Includes STL header(s) but does not reference std::\"\npresubmit warning along the way.\n\nBug: 40216326\nChange-Id: If93650c544115828e7ffa7fd031970a375041c38\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7081917\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1535141}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f331b8e8c898d1b1208a82207710d3c060ea489f\n" }, { "commit": "80597d6a9c9c6b971043cb5bb2973b32a6267ea3", "tree": "37ddc8cf23dabbddf3371fa8bccde612fe7e1bbf", "parents": [ "4de5b9e404c3aa538cb6f0140ae3b78938e5e11d" ], "author": { "name": "Nancy Xiao", "email": "nancylanxiao@google.com", "time": "Fri Oct 24 14:29:24 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 24 14:35:54 2025" }, "message": "Add new owners for the ERP library\n\nAs part of the ERP ownership handover process, add POCs from CEP to the\nOWNERS file.\n\nBug: b:452313177\nChange-Id: I29b685d628ca60c321a29498f7fc09f913182b69\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7079982\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Nancy Xiao \u003cnancylanxiao@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1534995}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 380c216bc3a5244ac6aa6bca8226486abf5e75b4\n" }, { "commit": "4de5b9e404c3aa538cb6f0140ae3b78938e5e11d", "tree": "42d6b89ab2ad480d8534bc3d053f0df53f2c1d9d", "parents": [ "0ae9d69eb0bbe833e24190d7ca3fd31c1ff4c339" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Oct 16 09:34:27 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 16 09:40:05 2025" }, "message": "Remove unnecessary //build/config/features.gni imports\n\nThis .gni file only defines a few GN variables. Files that don\u0027t use\nthose variables don\u0027t need to import this .gni file.\n\nChange-Id: I06e1e20e348cf7d29238c80430a3139b72b3fc9a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7047261\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nOwners-Override: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1530708}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d885eb6bd1991e0b2901dcae97ea53c6cd8f78f8\n" }, { "commit": "0ae9d69eb0bbe833e24190d7ca3fd31c1ff4c339", "tree": "4dce70e45abd1efe560631b102eb0445378e4aa5", "parents": [ "b17f35d247799d8bac5c436b1966c7b63ea5feb8" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Oct 10 06:23:18 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 10 06:28:57 2025" }, "message": "Remove superfluous includes for base/containers/fixed_flat_{map,set}.h\n\nHeaders that don\u0027t reference fixed_flat_map or MakeFixedFlatMap() don\u0027t\nneed this include. Remove the include and do IWYU to fix the build. In\nsome cases, replace fixed_flat_map.h with flat_map.h.\n\nThen do the same cleanup for fixed_flat_set.\n\nBug: 40318405\nChange-Id: I2de0c7a4842550bb502144cf428548447fde8116\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030819\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1527943}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: aa07dd78d1e03d4a8577e26c984ca6d7f62ca2dd\n" }, { "commit": "b17f35d247799d8bac5c436b1966c7b63ea5feb8", "tree": "14b5cd224533f72c6e0f6bf75f8251d388732acf", "parents": [ "8dc114461292c805e74c401bcd3acada32e2a641" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Mon Sep 29 19:27:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 29 19:33:34 2025" }, "message": "Prepare to remove base::JSONReader::Read\u0027s parsing option default\n\nCallers should be explicit if they need to opt into non-compliant JSON\nparsing that allows Chromium-specific extensions, e.g. comments. This\nfixes instances in //components included in a typical Linux developer build.\n\nBug: 446188265\nChange-Id: I0ca01fbbd4a889a480e8661d17496f775b5df0d2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6990985\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1522415}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 14c5cefc52dcba486476d22a1f7f7d2a179a9198\n" }, { "commit": "8dc114461292c805e74c401bcd3acada32e2a641", "tree": "0d8325685d3bc5bd76a65b7ea6a95b914e837f19", "parents": [ "47117ab7afdca65836def11e62063a3d1ffadf32" ], "author": { "name": "Xiaohan Wang", "email": "xhwang@chromium.org", "time": "Tue Sep 16 05:15:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 16 05:21:41 2025" }, "message": "components: Migrate BASE_FEATURE macros to 2-argument version\n\nThis CL migrates three-argument BASE_FEATURE macros in //components to\nthe new two-argument version where the C++ identifier and the string\nfeature name match.\n\nThis automated refactoring helps ensure that the C++ identifier and the\nstring feature name always match, reducing potential errors.\n\nThe following features could not be migrated automatically and may\nrequire manual intervention:\n\n * kDownloadServiceFeature vs \"DownloadService\"\n * Identifier has Feature suffix.\n\n * kDisplayInitiatorOrigin vs \"DownloadsDisplayInitiatorOrigin\"\n * Name has Downloads prefix.\n\n * kInvalidateTokenFeature vs \"GCMTokenInvalidAfterDays\"\n * Identifier has Feature suffix.\n\n * kReportingStorageDegradationFeature vs \"ReportingStorageDegradation\"\n * Identifier has Feature suffix.\n\n * kEncryptedReportingFeature vs \"EncryptedReporting\"\n * Identifier has Feature suffix.\n\n * kEnableCompose vs \"Compose\"\n * Identifier has Enable prefix.\n\n * kEnableComposeSavedStateNudge vs \"ComposeNudge\"\n * Identifier has Enable prefix and different name.\n\n * kEnableComposeProactiveNudge vs \"ComposeProactiveNudge\"\n * Identifier has Enable prefix.\n\n * kEnableComposeLanguageBypassForContextMenu vs \"ComposeLanguageBypassForContextMenu\"\n * Identifier has Enable prefix.\n\n * kEnableComposeWebUIAnimations vs \"ComposeWebUIAnimations\"\n * Identifier has Enable prefix.\n\n * kEnableNudgeForUnspecifiedHint vs \"ComposeEnableNudgeForUnspecifiedHint\"\n * Identifier has different name.\n\n * kPasswordsGrouperHeapIntegrityKillSwitch vs \"PasswordsGrouperHeapIntegrityKillSwitchv2\"\n * Name has v2 suffix.\n\n * kClearUndecryptablePasswordsOnSync vs \"ClearUndecryptablePasswordsInSync\"\n * on vs in.\n\n * kFillOnAccountSelect vs \"fill-on-account-select\"\n * Case and kebab-case mismatch.\n\n * kIOSProactivePasswordGenerationBottomSheet vs \"kIOSProactivePasswordGenerationBottomSheet\"\n * Name has k prefix.\n\n * kPasswordGenerationChunking vs \"PasswordGenerationChunkPassword\"\n * Chunking vs ChunkPassword.\n\n * kDelaySuggestionsOnAutofocusWaitingForPasskeys vs \"DelaysSuggestionsOnAutofocusWaitingForPasskeys\"\n * Delay vs Delays.\n\n * kAdSamplerTriggerFeature vs \"SafeBrowsingAdSamplerTrigger\"\n * Identifier has Feature suffix and name has SafeBrowsing prefix.\n\n * kDelayedWarnings vs \"SafeBrowsingDelayedWarnings\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetryConfiguration vs \"SafeBrowsingExtensionTelemetryConfiguration\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetryDeclarativeNetRequestActionSignal vs \"SafeBrowsingExtensionTelemetryDeclarativeNetRequestActionSignal\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetryFileDataForCommandLineExtensions vs \"SafeBrowsingExtensionTelemetryFileDataForCommandLineExtensions\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetrySearchHijackingSignal vs \"SafeBrowsingExtensionTelemetrySearchHijackingSignal\"\n * Name has SafeBrowsing prefix.\n\n * kExternalAppRedirectTelemetry vs \"SafeBrowsingExternalAppRedirectTelemetry\"\n * Name has SafeBrowsing prefix.\n\n * kGooglePlayProtectInApkTelemetry vs \"SafeBrowsingGooglePlayProtectInApkTelemetry\"\n * Name has SafeBrowsing prefix.\n\n * kGooglePlayProtectReducesWarnings vs \"SafeBrowsingGooglePlayProtectReducesWarnings\"\n * Name has SafeBrowsing prefix.\n\n * kHashPrefixRealTimeLookups vs \"SafeBrowsingHashPrefixRealTimeLookups\"\n * Name has SafeBrowsing prefix.\n\n * kHashPrefixRealTimeLookupsSamplePing vs \"SafeBrowsingHashPrefixRealTimeLookupsSamplePing\"\n * Name has SafeBrowsing prefix.\n\n * kLocalListsUseSBv5 vs \"SafeBrowsingLocalListsUseSBv5\"\n * Name has SafeBrowsing prefix.\n\n * kSuspiciousSiteTriggerQuotaFeature vs \"SafeBrowsingSuspiciousSiteTriggerQuota\"\n * Identifier has Feature suffix and name has SafeBrowsing prefix.\n\n * kThreatDomDetailsTagAndAttributeFeature vs \"ThreatDomDetailsTagAttributes\"\n * Identifier has Feature suffix and name has different name.\n\n * kConfirmSuggestionRemovals vs \"ConfirmNtpSuggestionRemovals\"\n * Name has Ntp prefix.\n\n * kRealboxCr23Theming vs \"NtpRealboxCr23Theming\"\n * Name has Ntp prefix.\n\n * kRealboxMatchSearchboxTheme vs \"NtpRealboxMatchSearchboxTheme\"\n * Name has Ntp prefix.\n\n * kRealboxUseGoogleGIcon vs \"NtpRealboxUseGoogleGIcon\"\n * Name has Ntp prefix.\n\n * kNtpTabGroupsModule vs \"kNtpTabGroupsModule\"\n * Name has k prefix.\n\n * kNtpTabGroupsModuleZeroState vs \"kNtpTabGroupsModuleZeroState\"\n * Name has k prefix.\n\n * kAndroidMediaPickerAdoption vs \"MediaPickerAdoption\"\n * Identifier has Android prefix.\n\n * kLocalWebApprovalsWidgetSupportsUrlPayload vs \"PacpWidgetSupportsUrlPayload\"\n * Identifier has different name.\n\n * kOmniboxAction vs \"JourneysOmniboxAction\"\n * Name has Journeys prefix.\n\n * kOmniboxHistoryClusterProvider vs \"JourneysOmniboxHistoryClusterProvider\"\n * Name has Journeys prefix.\n\n * kNonUserVisibleDebug vs \"JourneysNonUserVisibleDebug\"\n * Name has Journeys prefix.\n\n * kUserVisibleDebug vs \"JourneysUserVisibleDebug\"\n * Name has Journeys prefix.\n\n * kSearchesFindUngroupedVisits vs \"GroupedHistorySearchesFindUngroupedVisits\"\n * Name has GroupedHistory prefix.\n\n * kOnDeviceClustering vs \"HistoryClustersOnDeviceClustering\"\n * Name has HistoryClusters prefix.\n\n * kOnDeviceClusteringBlocklists vs \"JourneysOnDeviceClusteringBlocklist\"\n * Name has Journeys prefix and Blocklists vs Blocklist.\n\n * kOnDeviceClusteringKeywordFiltering vs \"JourneysKeywordFiltering\"\n * Name has Journeys prefix.\n\n * kOnDeviceClusteringVisitRanking vs \"JourneysOnDeviceClusteringVisitRanking\"\n * Name has Journeys prefix.\n\n * kSyntheticCapabilities vs \"FeedSyntheticCapabilities\"\n * Name has Feed prefix.\n\n * kGroupingFrameworkForNonZPS vs \"OmniboxGroupingFrameworkForNonZPS\"\n * Name has Omnibox prefix.\n\n * kMaxZeroSuggestMatches vs \"OmniboxMaxZeroSuggestMatches\"\n * Name has Omnibox prefix.\n\n * kUIExperimentMaxAutocompleteMatches vs \"OmniboxUIExperimentMaxAutocompleteMatches\"\n * Name has Omnibox prefix.\n\n * kDynamicMaxAutocomplete vs \"OmniboxDynamicMaxAutocomplete\"\n * Name has Omnibox prefix.\n\n * kFocusTriggersWebAndSRPZeroSuggest vs \"OmniboxFocusTriggersWebAndSRPZeroSuggest\"\n * Name has Omnibox prefix.\n\n * kHideSuggestionGroupHeaders vs \"OmniboxHideSuggestionGroupHeaders\"\n * Name has Omnibox prefix.\n\n * kOnDeviceHeadProviderIncognito vs \"OmniboxOnDeviceHeadProviderIncognito\"\n * Name has Omnibox prefix.\n\n * kOnDeviceHeadProviderNonIncognito vs \"OmniboxOnDeviceHeadProviderNonIncognito\"\n * Name has Omnibox prefix.\n\n * kOnDeviceTailModel vs \"OmniboxOnDeviceTailModel\"\n * Name has Omnibox prefix.\n\n * kOnDeviceTailEnableEnglishModel vs \"OmniboxOnDeviceTailEnableEnglishModel\"\n * Name has Omnibox prefix.\n\n * kDocumentProvider vs \"OmniboxDocumentProvider\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderPrimaryAccountRequirement vs \"OmniboxDocumentProviderPrimaryAccountRequirement\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderEnterpriseEligibility vs \"OmniboxDocumentProviderEnterpriseEligibility\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderEnterpriseEligibilityWhenUnknown vs \"OmniboxDocumentProviderEnterpriseEligibilityWhenUnknown\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderNoSyncRequirement vs \"OmniboxDocumentProviderNoSyncRequirement\"\n * Name has Omnibox prefix.\n\n * kShowPopupOnMouseReleased vs \"OmniboxShowPopupOnMouseReleased\"\n * Name has Omnibox prefix.\n\n * kMostVisitedTilesHorizontalRenderGroup vs \"OmniboxMostVisitedTilesHorizontalRenderGroup\"\n * Name has Omnibox prefix.\n\n * kRichAutocompletion vs \"OmniboxRichAutocompletion\"\n * Name has Omnibox prefix.\n\n * kDefaultTypedNavigationsToHttps vs \"OmniboxDefaultTypedNavigationsToHttps\"\n * Name has Omnibox prefix.\n\n * kNumNtpZpsRecentSearches vs \"OmniboxNumNtpZpsRecentSearches\"\n * Name has Omnibox prefix.\n\n * kNumNtpZpsTrendingSearches vs \"OmniboxNumNtpZpsTrendingSearches\"\n * Name has Omnibox prefix.\n\n * kNumWebZpsRecentSearches vs \"OmniboxNumWebZpsRecentSearches\"\n * Name has Omnibox prefix.\n\n * kNumWebZpsRelatedSearches vs \"OmniboxNumWebZpsRelatedSearches\"\n * Name has Omnibox prefix.\n\n * kNumWebZpsMostVisitedUrls vs \"OmniboxNumWebZpsMostVisitedUrls\"\n * Name has Omnibox prefix.\n\n * kNumSrpZpsRecentSearches vs \"OmniboxNumSrpZpsRecentSearches\"\n * Name has Omnibox prefix.\n\n * kNumSrpZpsRelatedSearches vs \"OmniboxNumSrpZpsRelatedSearches\"\n * Name has Omnibox prefix.\n\n * kMultilineEditField vs \"OmniboxMultilineEditField\"\n * Name has Omnibox prefix.\n\n * kHideAimEntrypointOnUserInput vs \"OmniboxHideAimEntrypointOnUserInput\"\n * Name has Omnibox prefix.\n\n * kDiagnostics vs \"OmniboxDiagnostics\"\n * Name has Omnibox prefix.\n\n * kUkmSamplingRateFeature vs \"UkmSamplingRate\"\n * Identifier has Feature suffix.\n\n * kAsyncCheck vs \"AsyncNavigationIntercept\"\n * Identifier has different name.\n\n * kPushNotifications vs \"OptimizationGuidePushNotifications\"\n * Name has OptimizationGuide prefix.\n\n * kPageTextExtraction vs \"OptimizationGuidePageContentExtraction\"\n * Name has OptimizationGuide prefix.\n\n * kOptimizationGuideFetchingForSRP vs \"OptimizationHintsFetchingSRP\"\n * Guide vs Hints.\n\n * kOptimizationGuidePersonalizedFetching vs \"OptimizationPersonalizedHintsFetching\"\n * Guide vs PersonalizedHints.\n\n * kPasswordChangeSubmission vs \"PasswordChangeSubmissionSettingsVisibility\"\n * Name has SettingsVisibility suffix.\n\n * kHintsBatchUpdateForActiveTabsAndTopHosts vs \"OptimizationGuideHintsBatchUpdateForActiveTabsAndTopHosts\"\n * Name has OptimizationGuide prefix.\n\n * kHintsMaxConcurrentBatchUpdateFetchesOverride vs \"OptimizationGuideHintsMaxConcurrentBatchUpdateFetchesOverride\"\n * Name has OptimizationGuide prefix.\n\n * kHintsMaxConcurrentNavigationFetchesOverride vs \"OptimizationGuideHintsMaxConcurrentNavigationFetchesOverride\"\n * Name has OptimizationGuide prefix.\n\n * kDisableStrikeSystem vs \"DisableAutofillStrikeSystem\"\n * Name has Autofill prefix.\n\n * kPriceInsightsHighPriceIos vs \"PriceInsightsHighPrice\"\n * Identifier has Ios suffix.\n\n * kLensSearchNotFoundOnPageToast vs \"kLensSearchNotFoundOnPageToast\"\n * Name has k prefix.\n\n * kEnforceNonceChecking vs \"CastNonceEnforced\"\n * Enforce vs Cast and Checking vs Enforced.\n\n * kEnforceSHA256Checking vs \"CastSHA256Enforced\"\n * Enforce vs Cast and Checking vs Enforced.\n\n * kSafeBrowsingSubresourceFilter vs \"SubresourceFilter\"\n * Identifier has SafeBrowsing prefix.\n\n * kIPHDummyGroup vs \"IPH_DummyGroup\"\n * Case difference.\n\n * kiOSFullscreenPromosGroup vs \"IPH_iOSFullscreenPromosGroup\"\n * Case difference.\n\n * kiOSDefaultBrowserPromosGroup vs \"IPH_iOSDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kiOSTailoredDefaultBrowserPromosGroup vs \"IPH_iOSTailoredDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kiOSTailoredNonModalDefaultBrowserPromosGroup vs \"IPH_iOSTailoredNonModalDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kiOSNonModalSigninPromosGroup vs \"IPH_iOSNonModalSigninPromosGroup\"\n * Case difference.\n\n * kiOSHomepageNewBadgesGroup vs \"IPH_iOSHomepageNewBadgesGroup\"\n * Case difference.\n\n * kClankDefaultBrowserPromosGroup vs \"IPH_ClankDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kIPHDemoMode vs \"IPH_DemoMode\"\n * Case difference.\n\n * kIPHDummyFeature vs \"IPH_Dummy\"\n * Identifier has Feature suffix.\n\n * kEsbDownloadRowPromoFeature vs \"EsbDownloadRowPromo\"\n * Identifier has Feature suffix.\n\n * kIPHBatterySaverModeFeature vs \"IPH_BatterySaverMode\"\n * Identifier has Feature suffix.\n\n * kIPHCompanionSidePanelFeature vs \"IPH_CompanionSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHCompanionSidePanelRegionSearchFeature vs \"IPH_CompanionSidePanelRegionSearch\"\n * Identifier has Feature suffix.\n\n * kIPHComposeMSBBSettingsFeature vs \"IPH_ComposeMSBBSettingsFeature\"\n * Identifier has Feature suffix.\n\n * kIPHComposeNewBadgeFeature vs \"IPH_ComposeNewBadgeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopSharedHighlightingFeature vs \"IPH_DesktopSharedHighlighting\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopCustomizeChromeFeature vs \"IPH_DesktopCustomizeChrome\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopCustomizeChromeRefreshFeature vs \"IPH_DesktopCustomizeChromeRefresh\"\n * Identifier has Feature suffix.\n\n * kIPHDiscardRingFeature vs \"IPH_DiscardRing\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadEsbPromoFeature vs \"IPH_DownloadEsbPromo\"\n * Identifier has Feature suffix.\n\n * kIPHExplicitBrowserSigninPreferenceRememberedFeature vs \"IPH_ExplicitBrowserSigninPreferenceRemembered\"\n * Identifier has Feature suffix.\n\n * kIPHHistorySearchFeature vs \"IPH_HistorySearch\"\n * Identifier has Feature suffix.\n\n * kIPHExtensionsMenuFeature vs \"IPH_ExtensionsMenu\"\n * Identifier has Feature suffix.\n\n * kIPHExtensionsRequestAccessButtonFeature vs \"IPH_ExtensionsRequestAccessButton\"\n * Identifier has Feature suffix.\n\n * kIPHExtensionsZeroStatePromoFeature vs \"IPH_ExtensionsZeroStatePromo\"\n * Identifier has Feature suffix.\n\n * kIPHFocusHelpBubbleScreenReaderPromoFeature vs \"IPH_FocusHelpBubbleScreenReaderPromo\"\n * Identifier has Feature suffix.\n\n * kIPHGlicPromoFeature vs \"IPH_GlicPromo\"\n * Identifier has Feature suffix.\n\n * kIPHGMCCastStartStopFeature vs \"IPH_GMCCastStartStop\"\n * Identifier has Feature suffix.\n\n * kIPHGMCLocalMediaCastingFeature vs \"IPH_GMCLocalMediaCasting\"\n * Identifier has Feature suffix.\n\n * kIPHMemorySaverModeFeature vs \"IPH_HighEfficiencyMode\"\n * MemorySaver vs HighEfficiency.\n\n * kIPHLiveCaptionFeature vs \"IPH_LiveCaption\"\n * Identifier has Feature suffix.\n\n * kIPHMerchantTrustFeature vs \"IPH_MerchantTrust\"\n * Identifier has Feature suffix.\n\n * kIPHLensOverlayFeature vs \"IPH_LensOverlay\"\n * Identifier has Feature suffix.\n\n * kIPHLensOverlayTranslateButtonFeature vs \"IPH_LensOverlayTranslateButton\"\n * Identifier has Feature suffix.\n\n * kIPHTabAudioMutingFeature vs \"IPH_TabAudioMuting\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsSavePrimingPromoFeature vs \"IPH_PasswordsSavePrimingPromo\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsSaveRecoveryPromoFeature vs \"IPH_PasswordsSaveRecoveryPromo\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsManagementBubbleAfterSaveFeature vs \"IPH_PasswordsManagementBubbleAfterSave\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsManagementBubbleDuringSigninFeature vs \"IPH_PasswordsManagementBubbleDuringSignin\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsWebAppProfileSwitchFeature vs \"IPH_PasswordsWebAppProfileSwitch\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordManagerShortcutFeature vs \"IPH_PasswordManagerShortcut\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordSharingFeature vs \"IPH_PasswordSharingFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPdfSearchifyFeature vs \"IPH_PdfSearchifyFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPerformanceInterventionDialogFeature vs \"IPH_PerformanceInterventionDialogFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPlusAddressFirstSaveFeature vs \"IPH_PlusAddressFirstSaveFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPowerBookmarksSidePanelFeature vs \"IPH_PowerBookmarksSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHPriceInsightsPageActionIconLabelFeature vs \"IPH_PriceInsightsPageActionIconLabelFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPriceTrackingEmailConsentFeature vs \"IPH_PriceTrackingEmailConsentFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPriceTrackingPageActionIconLabelFeature vs \"IPH_PriceTrackingPageActionIconLabelFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListDiscoveryFeature vs \"IPH_ReadingListDiscovery\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListEntryPointFeature vs \"IPH_ReadingListEntryPoint\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListInSidePanelFeature vs \"IPH_ReadingListInSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHReadingModeSidePanelFeature vs \"IPH_ReadingModeSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHShoppingCollectionFeature vs \"IPH_ShoppingCollectionFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSideBySidePinnableFeature vs \"IPH_SideBySidePinnableFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSidePanelGenericPinnableFeature vs \"IPH_SidePanelGenericPinnableFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSidePanelLensOverlayPinnableFeature vs \"IPH_SidePanelLensOverlayPinnableFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSidePanelLensOverlayPinnableFollowupFeature vs \"IPH_SidePanelLensOverlayPinnableFollowupFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSideSearchAutoTriggeringFeature vs \"IPH_SideSearchAutoTriggering\"\n * Identifier has Feature suffix.\n\n * kIPHSideSearchPageActionLabelFeature vs \"IPH_SideSearchPageActionLabel\"\n * Identifier has Feature suffix.\n\n * kIPHSignoutWebInterceptFeature vs \"IPH_SignoutWebIntercept\"\n * Identifier has Feature suffix.\n\n * kIPHPwaQuietNotificationFeature vs \"IPH_PwaQuietNotification\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSaveV2IntroFeature vs \"IPH_TabGroupsSaveV2Intro\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSaveV2CloseGroupFeature vs \"IPH_TabGroupsSaveV2CloseGroup\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSharedTabChangedFeature vs \"IPH_TabGroupsSharedTabChanged\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSharedTabFeedbackFeature vs \"IPH_TabGroupsSharedTabFeedback\"\n * Identifier has Feature suffix.\n\n * kIPHTabOrganizationSuccessFeature vs \"IPH_TabOrganizationSuccess\"\n * Identifier has Feature suffix.\n\n * kIPHTabSearchFeature vs \"IPH_TabSearch\"\n * Identifier has Feature suffix.\n\n * kIPHTabSearchToolbarButtonFeature vs \"IPH_TabSearchToolbarButton\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopSnoozeFeature vs \"IPH_DesktopSnoozeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopPwaInstallFeature vs \"IPH_DesktopPwaInstall\"\n * Identifier has Feature suffix.\n\n * kIPHProfileSwitchFeature vs \"IPH_ProfileSwitch\"\n * Identifier has Feature suffix.\n\n * kIPHWebUiHelpBubbleTestFeature vs \"IPH_WebUiHelpBubbleTest\"\n * Identifier has Feature suffix.\n\n * kIPHPriceTrackingInSidePanelFeature vs \"IPH_PriceTrackingInSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHBackNavigationMenuFeature vs \"IPH_BackNavigationMenu\"\n * Identifier has Feature suffix.\n\n * kIPHAccountSettingsHistorySync vs \"IPH_AccountSettingsHistorySync\"\n * Identifier has Feature suffix.\n\n * kIPHAndroidTabDeclutter vs \"IPH_AndroidTabDeclutter\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationNewTabFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_NewTab\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationOpenInBrowserFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_OpenInBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationShareFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_Share\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationVoiceSearchFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_VoiceSearch\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationTranslateFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_Translate\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationAddToBookmarksFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_AddToBookmarks\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationReadAloudFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_ReadAloud\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationPageSummaryWebFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_PageSummary_Web\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationPageSummaryPdfFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_PageSummary_Pdf\"\n * Identifier has Feature suffix.\n\n * kIPHPageSummaryWebMenuFeature vs \"IPH_PageSummaryWebMenu\"\n * Identifier has Feature suffix.\n\n * kIPHPageSummaryPdfMenuFeature vs \"IPH_PageSummaryPdfMenu\"\n * Identifier has Feature suffix.\n\n * kIPHAppSpecificHistory vs \"IPH_AppSpecificHistory\"\n * Identifier has Feature suffix.\n\n * kIPHAutoDarkOptOutFeature vs \"IPH_AutoDarkOptOut\"\n * Identifier has Feature suffix.\n\n * kIPHAutoDarkUserEducationMessageFeature vs \"IPH_AutoDarkUserEducationMessage\"\n * Identifier has Feature suffix.\n\n * kIPHAutoDarkUserEducationMessageOptInFeature vs \"IPH_AutoDarkUserEducationMessageOptIn\"\n * Identifier has Feature suffix.\n\n * kIPHCCTHistory vs \"IPH_CCTHistory\"\n * Identifier has Feature suffix.\n\n * kIPHCCTMinimized vs \"IPH_CCTMinimized\"\n * Identifier has Feature suffix.\n\n * kIPHContextualPageActionsQuietVariantFeature vs \"IPH_ContextualPageActions_QuietVariant\"\n * Identifier has Feature suffix.\n\n * kIPHContextualPageActionsActionChipFeature vs \"IPH_ContextualPageActions_ActionChip\"\n * Identifier has Feature suffix.\n\n * kIPHDataSaverDetailFeature vs \"IPH_DataSaverDetail\"\n * Identifier has Feature suffix.\n\n * kIPHDataSaverMilestonePromoFeature vs \"IPH_DataSaverMilestonePromo\"\n * Identifier has Feature suffix.\n\n * kIPHDataSaverPreviewFeature vs \"IPH_DataSaverPreview\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultBrowserPromoMagicStackFeature vs \"IPH_DefaultBrowserPromoMagicStack\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultBrowserPromoMessagesFeature vs \"IPH_DefaultBrowserPromoMessages\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultBrowserPromoSettingCardFeature vs \"IPH_DefaultBrowserPromoSettingCard\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadHomeFeature vs \"IPH_DownloadHome\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadIndicatorFeature vs \"IPH_DownloadIndicator\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadPageFeature vs \"IPH_DownloadPage\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadPageScreenshotFeature vs \"IPH_DownloadPageScreenshot\"\n * Identifier has Feature suffix.\n\n * kIPHChromeHomeExpandFeature vs \"IPH_ChromeHomeExpand\"\n * Identifier has Feature suffix.\n\n * kIPHChromeHomePullToRefreshFeature vs \"IPH_ChromeHomePullToRefresh\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadSettingsFeature vs \"IPH_DownloadSettings\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadInfoBarDownloadContinuingFeature vs \"IPH_DownloadInfoBarDownloadContinuing\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadInfoBarDownloadsAreFasterFeature vs \"IPH_DownloadInfoBarDownloadsAreFaster\"\n * Identifier has Feature suffix.\n\n * kIPHReadAloudAppMenuFeature vs \"IPH_ReadAloudAppMenuFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadAloudExpandedPlayerFeature vs \"IPH_ReadAloudExpandedPlayerFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadAloudPlaybackModeFeature vs \"IPH_ReadAloudPlaybackModeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterContextMenuFeature vs \"IPH_ReadLaterContextMenu\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterAppMenuBookmarkThisPageFeature vs \"IPH_ReadLaterAppMenuBookmarkThisPage\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterAppMenuBookmarksFeature vs \"IPH_ReadLaterAppMenuBookmarks\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterBottomSheetFeature vs \"IPH_ReadLaterBottomSheet\"\n * Identifier has Feature suffix.\n\n * kIPHRequestDesktopSiteDefaultOnFeature vs \"IPH_RequestDesktopSiteDefaultOn\"\n * Identifier has Feature suffix.\n\n * kIPHRequestDesktopSiteExceptionsGenericFeature vs \"IPH_RequestDesktopSiteExceptionsGeneric\"\n * Identifier has Feature suffix.\n\n * kIPHRequestDesktopSiteWindowSettingFeature vs \"IPH_RequestDesktopSiteWindowSetting\"\n * Identifier has Feature suffix.\n\n * kIPHRtlGestureNavigationFeature vs \"IPH_RtlGestureNavigation\"\n * Identifier has Feature suffix.\n\n * kIPHShoppingListSaveFlowFeature vs \"IPH_ShoppingListSaveFlow\"\n * Identifier has Feature suffix.\n\n * kIPHEphemeralTabFeature vs \"IPH_EphemeralTab\"\n * Identifier has Feature suffix.\n\n * kIPHFeedCardMenuFeature vs \"IPH_FeedCardMenu\"\n * Identifier has Feature suffix.\n\n * kIPHGenericAlwaysTriggerHelpUiFeature vs \"IPH_GenericAlwaysTriggerHelpUiFeature\"\n * Identifier has Feature suffix.\n\n * kIPHIdentityDiscFeature vs \"IPH_IdentityDisc\"\n * Identifier has Feature suffix.\n\n * kIPHInstanceSwitcherFeature vs \"IPH_InstanceSwitcher\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryAddressFillingFeature vs \"IPH_KeyboardAccessoryAddressFilling\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryBarSwipingFeature vs \"IPH_KeyboardAccessoryBarSwiping\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryPasswordFillingFeature vs \"IPH_KeyboardAccessoryPasswordFilling\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryPaymentFillingFeature vs \"IPH_KeyboardAccessoryPaymentFilling\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryPaymentOfferFeature vs \"IPH_KeyboardAccessoryPaymentOffer\"\n * Identifier has Feature suffix.\n\n * kIPHLowUserEngagementDetectorFeature vs \"IPH_LowUserEngagementDetector\"\n * Identifier has Feature suffix.\n\n * kIPHMicToolbarFeature vs \"IPH_MicToolbar\"\n * Identifier has Feature suffix.\n\n * kIPHMenuAddToGroup vs \"IPH_MenuAddToGroup\"\n * Identifier has Feature suffix.\n\n * kIPHMostVisitedTilesCustomizationPinFeature vs \"IPH_MostVisitedTilesCustomizationPin\"\n * Identifier has Feature suffix.\n\n * kIPHPageInfoFeature vs \"IPH_PageInfo\"\n * Identifier has Feature suffix.\n\n * kIPHPageInfoStoreInfoFeature vs \"IPH_PageInfoStoreInfo\"\n * Identifier has Feature suffix.\n\n * kIPHPageZoomFeature vs \"IPH_PageZoom\"\n * Identifier has Feature suffix.\n\n * kIPHPdfPageDownloadFeature vs \"IPH_PdfPageDownload\"\n * Identifier has Feature suffix.\n\n * kIPHPreviewsOmniboxUIFeature vs \"IPH_PreviewsOmniboxUI\"\n * Identifier has Feature suffix.\n\n * kIPHReaderModeDistillInAppFeature vs \"IPH_ReaderModeDistillInApp\"\n * Identifier has Feature suffix.\n\n * kIPHShoppingListMenuItemFeature vs \"IPH_ShoppingListMenuItem\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupCreationDialogSyncTextFeature vs \"IPH_TabGroupCreationDialogSyncText\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsDragAndDropFeature vs \"IPH_TabGroupsDragAndDrop\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareNoticeFeature vs \"IPH_TabGroupShareNotice\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareNotificationBubbleOnStripFeature vs \"IPH_TabGroupSharedNotificationBubbleOnStrip\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareUpdateFeature vs \"IPH_TabGroupShareUpdate\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareVersionUpdateFeature vs \"IPH_TabGroupShareVersionUpdate\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsRemoteGroupFeature vs \"IPH_TabGroupsRemoteGroup\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSurfaceFeature vs \"IPH_TabGroupsSurface\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSurfaceOnHideFeature vs \"IPH_TabGroupsSurfaceOnHide\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupSyncOnStripFeature vs \"IPH_TabGroupSyncOnStrip\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherAddToGroup vs \"IPH_TabSwitcherAddToGroup\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherButtonFeature vs \"IPH_TabSwitcherButton\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherButtonSwitchIncognitoFeature vs \"IPH_TabSwitcherButtonSwitchIncognito\"\n * Identifier has Feature suffix.\n\n * kIPHTouchToSearchCalloutFeature vs \"IPH_TouchToSearchCallout\"\n * Identifier has Feature suffix.\n\n * kIPHTranslateMenuButtonFeature vs \"IPH_TranslateMenuButton\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPChromeIntroFeature vs \"IPH_VideoTutorial_NTP_ChromeIntro\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPDownloadFeature vs \"IPH_VideoTutorial_NTP_Download\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPSearchFeature vs \"IPH_VideoTutorial_NTP_Search\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPVoiceSearchFeature vs \"IPH_VideoTutorial_NTP_VoiceSearch\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPSummaryFeature vs \"IPH_VideoTutorial_NTP_Summary\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialTryNowFeature vs \"IPH_VideoTutorial_TryNow\"\n * Identifier has Feature suffix.\n\n * kIPHExploreSitesTileFeature vs \"IPH_ExploreSitesTile\"\n * Identifier has Feature suffix.\n\n * kIPHFeedHeaderMenuFeature vs \"IPH_FeedHeaderMenu\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedAwarenessFeature vs \"IPH_WebFeedAwareness\"\n * Identifier has Feature suffix.\n\n * kIPHFeedSwipeRefresh vs \"IPH_FeedSwipeRefresh\"\n * Identifier has Feature suffix.\n\n * kIPHChromeReengagementNotification1Feature vs \"IPH_ChromeReengagementNotification1\"\n * Identifier has Feature suffix.\n\n * kIPHChromeReengagementNotification2Feature vs \"IPH_ChromeReengagementNotification2\"\n * Identifier has Feature suffix.\n\n * kIPHChromeReengagementNotification3Feature vs \"IPH_ChromeReengagementNotification3\"\n * Identifier has Feature suffix.\n\n * kIPHShareScreenshotFeature vs \"IPH_ShareScreenshot\"\n * Identifier has Feature suffix.\n\n * kIPHSharingHubLinkToggleFeature vs \"IPH_SharingHubLinkToggle\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedFollowFeature vs \"IPH_WebFeedFollow\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedPostFollowDialogFeature vs \"IPH_WebFeedPostFollowDialog\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedPostFollowDialogFeatureWithUIUpdate vs \"IPH_WebFeedPostFollowDialogWithUIUpdate\"\n * Identifier has Feature suffix.\n\n * kIPHSharedHighlightingBuilder vs \"IPH_SharedHighlightingBuilder\"\n * Identifier has Feature suffix.\n\n * kIPHSharedHighlightingReceiverFeature vs \"IPH_SharedHighlightingReceiver\"\n * Identifier has Feature suffix.\n\n * kIPHSharingHubWebnotesStylizeFeature vs \"IPH_SharingHubWebnotesStylize\"\n * Identifier has Feature suffix.\n\n * kIPHRestoreTabsOnFREFeature vs \"IPH_RestoreTabsOnFRE\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherXR vs \"IPH_TabSwitcherXR\"\n * Identifier has Feature suffix.\n\n * kIPHTabTearingXR vs \"IPH_TabTearingXR\"\n * Identifier has Feature suffix.\n\n * kIPHBottomToolbarTipFeature vs \"IPH_BottomToolbarTip\"\n * Identifier has Feature suffix.\n\n * kIPHLongPressToolbarTipFeature vs \"IPH_LongPressToolbarTip\"\n * Identifier has Feature suffix.\n\n * kIPHBadgedReaderModeFeature vs \"IPH_BadgedReaderMode\"\n * Identifier has Feature suffix.\n\n * kIPHBadgedReadingListFeature vs \"IPH_BadgedReadingList\"\n * Identifier has Feature suffix.\n\n * kIPHWhatsNewFeature vs \"IPH_WhatsNew\"\n * Identifier has Feature suffix.\n\n * kIPHWhatsNewUpdatedFeature vs \"IPH_WhatsNewUpdated\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListMessagesFeature vs \"IPH_ReadingListMessages\"\n * Identifier has Feature suffix.\n\n * kIPHBadgedTranslateManualTriggerFeature vs \"IPH_BadgedTranslateManualTrigger\"\n * Identifier has Feature suffix.\n\n * kIPHDiscoverFeedHeaderFeature vs \"IPH_DiscoverFeedHeaderMenu\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultSiteViewFeature vs \"IPH_DefaultSiteView\"\n * Identifier has Feature suffix.\n\n * kIPHFollowWhileBrowsingFeature vs \"IPH_FollowWhileBrowsing\"\n * Identifier has Feature suffix.\n\n * kIPHPriceNotificationsWhileBrowsingFeature vs \"IPH_PriceNotificationsWhileBrowsing\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserBadgeEligibilityFeature vs \"IPH_iOSDefaultBrowserBadgeEligibility\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserOverflowMenuBadgeFeature vs \"IPH_iOSDefaultBrowserOverflowMenuBadge\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDownloadAutoDeletionFeature vs \"IPH_iOSDownloadAutoDeletion\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensKeyboardFeature vs \"IPH_iOSLensKeyboard\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoAppStoreFeature vs \"IPH_iOSPromoAppStore\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoWhatsNewFeature vs \"IPH_iOSPromoWhatsNew\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoSigninFullscreenFeature vs \"IPH_iOSPromoSigninFullscreen\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoPostRestoreFeature vs \"IPH_iOSPromoPostRestore\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoCredentialProviderExtensionFeature vs \"IPH_iOSPromoCredentialProviderExtension\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoDefaultBrowserReminderFeature vs \"IPH_iOSPromoDefaultBrowserReminder\"\n * Identifier has Feature suffix.\n\n * kIPHiOSHistoryOnOverflowMenuFeature vs \"IPH_iOSHistoryOnOverflowMenuFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoPostRestoreDefaultBrowserFeature vs \"IPH_iOSPromoPostRestoreDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalUrlPasteDefaultBrowserFeature vs \"IPH_iOSPromoNonModalUrlPasteDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalAppSwitcherDefaultBrowserFeature vs \"IPH_iOSPromoNonModalAppSwitcherDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalShareDefaultBrowserFeature vs \"IPH_iOSPromoNonModalShareDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalSigninPasswordFeature vs \"IPH_iOSPromoNonModalSigninPassword\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalSigninBookmarkFeature vs \"IPH_iOSPromoNonModalSigninBookmark\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoPasswordManagerWidgetFeature vs \"IPH_iOSPromoPasswordManagerWidget\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPullToRefreshFeature vs \"IPH_iOSPullToRefreshFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSReplaceSyncPromosWithSignInPromos vs \"IPH_iOSReplaceSyncPromosWithSignInPromos\"\n * Identifier has Feature suffix.\n\n * kIPHiOSTabGridSwipeRightForIncognito vs \"IPH_iOSTabGridSwipeRightForIncognito\"\n * Case difference.\n\n * kIPHiOSDockingPromoFeature vs \"IPH_iOSDockingPromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDockingPromoRemindMeLaterFeature vs \"IPH_iOSDockingPromoRemindMeLater\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoAllTabsFeature vs \"IPH_iOSPromoAllTabs\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoMadeForIOSFeature vs \"IPH_iOSPromoMadeForIOS\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoStaySafeFeature vs \"IPH_iOSPromoStaySafe\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSwipeBackForwardFeature vs \"IPH_iOSSwipeBackForward\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSwipeToolbarToChangeTabFeature vs \"IPH_iOSSwipeToolbarToChangeTab\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPostDefaultAbandonmentPromoFeature vs \"IPH_iOSPostDefaultAbandonmentPromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoGenericDefaultBrowserFeature vs \"IPH_iOSPromoGenericDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSOverflowMenuCustomizationFeature vs \"IPH_iOSOverflowMenuCustomization\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPageInfoRevampFeature vs \"IPH_iOSPageInfoRevamp\"\n * Identifier has Feature suffix.\n\n * kIPHiOSInlineEnhancedSafeBrowsingPromoFeature vs \"IPH_iOSInlineEnhancedSafeBrowsingPromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSavedTabGroupClosed vs \"IPH_iOSSavedTabGroupClosed\"\n * Case difference.\n\n * kIPHiOSContextualPanelSampleModelFeature vs \"IPH_iOSContextualPanelSampleModel\"\n * Identifier has Feature suffix.\n\n * kIPHiOSContextualPanelPriceInsightsFeature vs \"IPH_iOSContextualPanelPriceInsights\"\n * Identifier has Feature suffix.\n\n * kIPHHomeCustomizationMenuFeature vs \"IPH_HomeCustomizationMenu\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensOverlayEntrypointTipFeature vs \"IPH_iOSLensOverlayEntrypointTip\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensOverlayEscapeHatchTipFeature vs \"IPH_iOSLensOverlayEscapeHatchTip\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSharedTabGroupForeground vs \"IPH_iOSSharedTabGroupForeground\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserBannerPromoFeature vs \"IPH_iOSDefaultBrowserBannerPromoFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserOffCyclePromoFeature vs \"IPH_iOSDefaultBrowserOffCyclePromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSReminderNotificationsOverflowMenuBubbleFeature vs \"IPH_iOSReminderNotificationsOverflowMenuBubbleFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSReminderNotificationsOverflowMenuNewBadgeFeature vs \"IPH_iOSReminderNotificationsOverflowMenuNewBadgeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSafariImportFeature vs \"IPH_iOSSafariImportFeature\"\n * Case difference.\n\n * kIPHiOSSettingsInOverflowMenuBubbleFeature vs \"IPH_iOSSettingsInOverflowMenuBubbleFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSwitchAccountsWithNTPAccountParticleDiscFeature vs \"IPH_iOSSwitchAccountsWithNTPAccountParticleDiscFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSFeedSwipeStaticFeature vs \"IPH_iOSFeedSwipeStaticFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSFeedSwipeAnimatedFeature vs \"IPH_iOSFeedSwipeAnimatedFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSWelcomeBackFeature vs \"IPH_iOSWelcomeBack\"\n * Identifier has Feature suffix.\n\n * kIPHIOSPageActionMenu vs \"IPH_iOSPageActionMenu\"\n * Case difference.\n\n * kIPHiOSReaderModeOptionsFeature vs \"IPH_iOSReaderModeOptions\"\n * Identifier has Feature suffix.\n\n * kIPHiOSHomepageLensNewBadge vs \"IPH_iOSHomepageLensNewBadge\"\n * Identifier has Feature suffix.\n\n * kIPHiOSHomepageCustomizationNewBadge vs \"IPH_iOSHomepageCustomizationNewBadge\"\n * Identifier has Feature suffix.\n\n * kIPHiOSOneTimeDefaultBrowserNotificationFeature vs \"IPH_iOSOneTimeDefaultBrowserNotification\"\n * Identifier has Feature suffix.\n\n * kIPHiOSAIHubNewBadge vs \"IPH_iOSAIHubNewBadge\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillBnplAffirmOrZipSuggestionFeature vs \"IPH_AutofillBnplAffirmOrZipSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillBnplAffirmZipOrKlarnaSuggestionFeature vs \"IPH_AutofillBnplAffirmZipOrKlarnaSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillCardInfoRetrievalSuggestionFeature vs \"IPH_AutofillCardInfoRetrievalSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillCreditCardBenefitFeature vs \"IPH_AutofillCreditCardBenefit\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillDisabledVirtualCardSuggestionFeature vs \"IPH_AutofillDisabledVirtualCardSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillExternalAccountProfileSuggestionFeature vs \"IPH_AutofillExternalAccountProfileSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillHomeWorkProfileSuggestionFeature vs \"IPH_AutofillHomeWorkProfileSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillAccountNameEmailSuggestionFeature vs \"IPH_AutofillAccountNameEmailSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillAiOptInFeature vs \"IPH_AutofillAiOptIn\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillVirtualCardCVCSuggestionFeature vs \"IPH_AutofillVirtualCardCVCSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillVirtualCardSuggestionFeature vs \"IPH_AutofillVirtualCardSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHCookieControlsFeature vs \"IPH_CookieControls\"\n * Identifier has Feature suffix.\n\n * kIPHPlusAddressCreateSuggestionFeature vs \"IPH_PlusAddressCreateSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillEnableLoyaltyCardsFeature vs \"IPH_AutofillEnableLoyaltyCards\"\n * Identifier has Feature suffix.\n\n * kIPHGrowthFramework vs \"IPH_GrowthFramework\"\n * Identifier has Feature suffix.\n\n * kIPHGoogleOneOfferNotificationFeature vs \"IPH_GoogleOneOfferNotification\"\n * Identifier has Feature suffix.\n\n * kIPHLauncherSearchHelpUiFeature vs \"IPH_LauncherSearchHelpUi\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedOneFeature vs \"IPH_ScalableIphTimerBasedOne\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedTwoFeature vs \"IPH_ScalableIphTimerBasedTwo\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedThreeFeature vs \"IPH_ScalableIphTimerBasedThree\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedFourFeature vs \"IPH_ScalableIphTimerBasedFour\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedFiveFeature vs \"IPH_ScalableIphTimerBasedFive\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedSixFeature vs \"IPH_ScalableIphTimerBasedSix\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedSevenFeature vs \"IPH_ScalableIphTimerBasedSeven\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedEightFeature vs \"IPH_ScalableIphTimerBasedEight\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedNineFeature vs \"IPH_ScalableIphTimerBasedNine\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedTenFeature vs \"IPH_ScalableIphTimerBasedTen\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedOneFeature vs \"IPH_ScalableIphUnlockedBasedOne\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedTwoFeature vs \"IPH_ScalableIphUnlockedBasedTwo\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedThreeFeature vs \"IPH_ScalableIphUnlockedBasedThree\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedFourFeature vs \"IPH_ScalableIphUnlockedBasedFour\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedFiveFeature vs \"IPH_ScalableIphUnlockedBasedFive\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedSixFeature vs \"IPH_ScalableIphUnlockedBasedSix\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedSevenFeature vs \"IPH_ScalableIphUnlockedBasedSeven\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedEightFeature vs \"IPH_ScalableIphUnlockedBasedEight\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedNineFeature vs \"IPH_ScalableIphUnlockedBasedNine\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedTenFeature vs \"IPH_ScalableIphUnlockedBasedTen\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedNudgeFeature vs \"IPH_ScalableIphHelpAppBasedNudge\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedOneFeature vs \"IPH_ScalableIphHelpAppBasedOne\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedTwoFeature vs \"IPH_ScalableIphHelpAppBasedTwo\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedThreeFeature vs \"IPH_ScalableIphHelpAppBasedThree\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedFourFeature vs \"IPH_ScalableIphHelpAppBasedFour\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedFiveFeature vs \"IPH_ScalableIphHelpAppBasedFive\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedSixFeature vs \"IPH_ScalableIphHelpAppBasedSix\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedSevenFeature vs \"IPH_ScalableIphHelpAppBasedSeven\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedEightFeature vs \"IPH_ScalableIphHelpAppBasedEight\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedNineFeature vs \"IPH_ScalableIphHelpAppBasedNine\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedTenFeature vs \"IPH_ScalableIphHelpAppBasedTen\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphGamingFeature vs \"IPH_ScalableIphGaming\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopPWAsLinkCapturingLaunch vs \"IPH_DesktopPWAsLinkCapturingLaunch\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopPWAsLinkCapturingLaunchAppInTab vs \"IPH_DesktopPWAsLinkCapturingLaunchAppInTab\"\n * Identifier has Feature suffix.\n\n * kIPHSupervisedUserProfileSigninFeature vs \"IPH_SupervisedUserProfileSignin\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPasswordPromoDesktopFeature vs \"IPH_iOSPasswordPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSAddressPromoDesktopFeature vs \"IPH_iOSAddressPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPaymentPromoDesktopFeature vs \"IPH_iOSPaymentPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensPromoDesktopFeature vs \"IPH_iOSLensPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSEnhancedBrowsingDesktopFeature vs \"IPH_iOSEnhancedBrowsingDesktop\"\n * Case difference.\n\n * kCctAutoTranslate vs \"CCTAutoTranslate\"\n * Case difference.\n\n * kEnableZstd vs \"EnableZstdV2\"\n * Name has V2 suffix.\n\n * kLogMe vs \"CronetLogMe\"\n * Name has Cronet prefix.\n\n * kWindowsMemoryPressurePeriod vs \"WinMemoryPressurePeriod\"\n * Windows vs Win.\n\n * kOfflinePagesInDownloadHomeOpenInCctFeature vs \"OfflinePagesInDownloadHomeOpenInCct\"\n * Identifier has Feature suffix.\n\n * kStructuredMetrics vs \"EnableStructuredMetrics\"\n * Name has Enable prefix.\n\n * kExpiredHistogramLogicFeature vs \"ExpiredHistogramLogic\"\n * Identifier has Feature suffix.\n\n * kPersistentHistogramsFeature vs \"PersistentHistograms\"\n * Identifier has Feature suffix.\n\n * kUseUserDefaultsForExitedCleanlyBeacon vs \"UseUserDefaultsForExitedCleanlyBeaconEnabler\"\n * Name has Enabler suffix.\n\n * kPseudoMetricsEffectFeature vs \"UMAPseudoMetricsEffect\"\n * Name has UMA prefix.\n\n * kCARenderer vs \"CoreAnimationRenderer\"\n * CA vs CoreAnimation.\n\n * kHDRUnderlays vs \"CoreAnimationHDRUnderlays\"\n * Name has CoreAnimation prefix.\n\n * kWebAuthnAndroidPasskeyCacheMigration vs \"WebAuthenticationAndroidPasskeyCacheMigration\"\n * WebAuthn vs WebAuthentication.\n\n * kCrosSystemLevelPermissionBlockedWarnings vs \"CrosBlockWarnings\"\n * SystemLevelPermissionBlocked vs Block.\n\n * kFlushAfterAppending vs \"SessionStorageFlushAfterAppendingCommands\"\n * Name has SessionStorage prefix and Commands suffix.\n\n * kUseFinchPermanentCountryForFetchCountryId vs \"UseFinchPermanentCountyForFetchCountryId\"\n * Country vs County.\n\n * kSiteIsolationForPasswordSites vs \"site-isolation-for-password-sites\"\n * Case and kebab-case mismatch.\n\n * kSiteIsolationMemoryThresholdsAndroid vs \"SiteIsolationMemoryThresholds\"\n * Identifier has Android suffix.\n\n * kDataSharingFeature vs \"DataSharing\"\n * Identifier has Feature suffix.\n\n * kSegmentationPlatformFeature vs \"SegmentationPlatform\"\n * Identifier has Feature suffix.\n\n * kResumeHeavyUserSegmentFeature vs \"ResumeHeavyUserSegment\"\n * Identifier has Feature suffix.\n\n * kUIDebugToolsEnableSyntheticEvents vs \"ui-debug-tools-enable-synthetic-events\"\n * Case and kebab-case mismatch.\n\n * kPopularSitesBakedInContentFeature vs \"NTPPopularSitesBakedInContent\"\n * Name has NTP prefix.\n\n * kNtpMostLikelyFaviconsFromServerFeature vs \"NTPMostLikelyFaviconsFromServer\"\n * Identifier has Feature suffix.\n\n * kNtpEnterpriseShortcuts vs \"NTPEnterpriseShortcuts\"\n * Identifier has Feature suffix.\n\nEnabled-by-default-reason: refactor\nNO_IFTTT\u003drefactor; no functionality change\n\nBug: 436274260\nChange-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6945639\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nAuto-Submit: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1515845}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 67735866800aa838628039f951a3095d0602f03c\n" }, { "commit": "47117ab7afdca65836def11e62063a3d1ffadf32", "tree": "167ca70606d7c15460c685674206d29fb107d07b", "parents": [ "877d0beed701e6d58be98b7037b06052d1254dd4" ], "author": { "name": "Shanthanu Bhardwaj", "email": "xanth@google.com", "time": "Tue Sep 09 21:19:20 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 09 21:26:42 2025" }, "message": "Add full proto runtime targets for UploadEventsRequest and transitive\ndeps\n\nWe log these values in the chrome://safe-browsing page and need full\ntargets to represent the proto targets in a human-readable way.\n\nChange-Id: I6d6c9cbb37dff55264c115896052871122f74508\nBug: 394403142\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6922749\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Shanthanu Bhardwaj \u003cxanth@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1513318}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: df8c43337b1503ec09b7a4ae852e5e2eece560d9\n" }, { "commit": "877d0beed701e6d58be98b7037b06052d1254dd4", "tree": "94df81000a87a5426eb1c9d9a6e64badb2da1da5", "parents": [ "44cac78dff817c5bab3a190fa0c3a55a1a005318" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed Aug 27 21:54:11 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 27 21:59:54 2025" }, "message": "Remove base::AlwaysFalse\u003c\u003e\n\nSince its introduction in 2011, `static_assert(false)` could not be used\nin templates because it caused the code to be ill-formed. However,\nsometimes you want to prohibit instantiation of a template with a\ndefault parameter value, and force users to create specializations. The\nusual workaround was to define an \"always false\" template. Chromium\nfollowed that pattern with `base/types/always_false.h`.\n\nBecause this issue was one that widely affected the C++ community, in\n2023 the C++ committee accepted P2593R1 to fix this problem. Later in\n2023, a note about this fix was added to `always_false.h`.\n\nHowever, the author of this note in `always_false.h` was mistaken. The\nauthor believed that P2593R1 was accepted as part of C++23 (and thus\n`base::AlwaysFalse\u003c\u003e` would need to be kept until Chromium adopted\nC++23), but in fact the C++ committee had accepted and incorporated\nP2593R1 as errata all the way back to C++11.\n\nBecause this errata has been widely implemented (Clang 17, GCC 13, and\nMSVC 19.40), it is safe to remove the Chromium workaround.\n\nSee https://en.cppreference.com/w/cpp/language/static_assert.html and\nits \"defect reports\" section.\n\nBug: none\nChange-Id: Ic0c9378483c9ad5cceb08bbb20a348a818ec5bd1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6891176\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1507382}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 421425fe3324d5aa499a1314c8094547285dcdeb\n" }, { "commit": "44cac78dff817c5bab3a190fa0c3a55a1a005318", "tree": "c414209ec6a185875ee17b00c311cbb0a9622e97", "parents": [ "e87d4bdc46d479628f1e3147a637b404f4e4d639" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Tue Aug 26 19:06:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 26 19:12:36 2025" }, "message": "[owners] Remove lbaraz@chromium.org from components/reporting/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\n\nPlease approve this change and vote the highest CR. This will keep the\nOWNERS file tidy. We ask that you do not ignore this change and either\napprove it if the OWNER is no longer active or deny it if the OWNER is\ncontinuing to review CLs (including under a different affiliation).\nThis CL can always be reverted if the understanding changes.\n\nIf this change is in error, vote the lowest CR value (i.e. reject the\nCL) and the bot will abandon it.\n\nSee the owner\u0027s recent review activity for context:\nhttps://chromium-review.googlesource.com/q/lbaraz@chromium.org\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: I2acbc93a071639eaa42bbfd6d5fac732e0f493a7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6885830\nReviewed-by: Ahmed Nasr \u003canasr@google.com\u003e\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nCommit-Queue: Ahmed Nasr \u003canasr@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1506688}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fbb43b10f67ebf42f0c16ad653d49f34a2ca9511\n" }, { "commit": "e87d4bdc46d479628f1e3147a637b404f4e4d639", "tree": "2f2b4effa1a23eb9b1bd5096d5be88c248236277", "parents": [ "d07bc0eb1d669ce4a8f6114315dec08ca648218c" ], "author": { "name": "Jonathan Lee", "email": "jonathanjlee@google.com", "time": "Mon Aug 25 20:26:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 25 20:31:51 2025" }, "message": "[gtest] Clean up single-arg `Invoke()`s in `//components/reporting/`\n\nNot needed and deprecated [0]. This CL should be a no-op.\n\n[0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046\n\nBug: 439838457\nChange-Id: Id1a0411c5f3d2622dd723d331f8a7799dd2f43b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6879121\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Jonathan Lee \u003cjonathanjlee@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1506091}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d6361842fbdda5266c8dc9dde00224b3b0d62ae8\n" }, { "commit": "d07bc0eb1d669ce4a8f6114315dec08ca648218c", "tree": "11e3e921ec8767d8c8e54cb79d015f776ccb4a89", "parents": [ "3c0a42856f67934fb9e07d6a132776cf049ddac7" ], "author": { "name": "David Sanders", "email": "dsanders11@ucsbalum.com", "time": "Mon Aug 18 22:27:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 18 22:33:24 2025" }, "message": "Forward declare DelayPolicy in //base/task/sequenced_task_runner.h\n\nShould save ~103 MiB of compiler input size.\n\nAdds missing includes and forward decls as needed to fix the build.\n\nBug: 429365675\nChange-Id: I9a8430205f4c42c7837bf99dfa203171672a7ee2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6853759\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1503001}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 68a3a2b4cab192e16427d5ecc3c010792b1b78bc\n" }, { "commit": "3c0a42856f67934fb9e07d6a132776cf049ddac7", "tree": "c805c56e386ceb2886e7130597ca0e2baa3617fa", "parents": [ "6bfd9ac18a5b0e062c361f0548beca46308af019" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Fri Aug 15 00:42:24 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 15 00:48:16 2025" }, "message": "Rewrite --force unsafe buffers pragmas in components/\n\nChange-Id: Ia214685aae0320821bb523f3f3e4a5903343373d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6828357\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1501715}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0cc725e5c06bff7e626bc6f32c90187065b10d3f\n" }, { "commit": "6bfd9ac18a5b0e062c361f0548beca46308af019", "tree": "06c859475f791a02873601858e3b1f963f060322", "parents": [ "af2bf3e920e1f8ba6198ac806a53588d534b7a17" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@chromium.org", "time": "Tue Aug 12 20:26:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 12 20:35:17 2025" }, "message": "Add djzhang@google.com and jdudder@google.com to ERP client code OWNERS.\n\nChange-Id: I6cb6e748b7095dfe7b78406c1b5b761b6cea25c9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6841878\nCommit-Queue: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nAuto-Submit: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1500382}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b86c99ba64b778e3fada39d0790d32ffdf3ccebf\n" }, { "commit": "af2bf3e920e1f8ba6198ac806a53588d534b7a17", "tree": "5a4f1683e757b38538cf24554121161ce04c55e8", "parents": [ "3d08f8851584c26937b4e21adc0dc44f8331c37b" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@google.com", "time": "Wed Aug 06 20:53:03 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 06 20:58:19 2025" }, "message": "Increase initial delay for uploads\n\nAfter non-periodic queue initiates upload, check back and retry after\n3 sec instead of 1 sec. Chrome uploader is doing an exponential backoff\nand was supposed to soften the impact of 1 sec retry (to possibly update\nthe cache but not send anything to the server); however, according to\nthe bug, it is insufficient or not functioning properly (heuristics of\nduplicate events detection might be not aggressive enough).\n\nThe change should not have a adverse impact - it affects only events\nthat are not delivered soon enough.\n\nBug: b:435234655\nChange-Id: Ic31a61d00bda8c2f56898822ff5872628838b0ec\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825283\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nAuto-Submit: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1497825}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a66925b3b9ac7c7666f924566fa8adf60dece755\n" }, { "commit": "3d08f8851584c26937b4e21adc0dc44f8331c37b", "tree": "7aa45586abc45d3be88263b2c40b12901626c3c5", "parents": [ "93f6dfcb731b27cb5a3aa00b8c6b608b21de6223" ], "author": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Wed Aug 06 05:52:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 06 05:59:15 2025" }, "message": "spanification: automatically spanify various pointers\n\nThis is the result of running the automatic spanification on linux and\nupdating code to use and pass spans where size is known. This CL has no\nbehavior changes.\n\nAll changes should be correct and no behaviour changes in patchset 1,\nhowever the plan is to follow up and remove the redundant size\nparameters. To this effect in patchset 2 we\u0027ve added CHECKS and renames\nto note the fact the size is believed to be redundant. This was done\nthrough AI and should be carefully checked, but the CHECKS are not fatal\nand thus if unsure should be fine to land and remove after reports of\nthe crashes.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms\u003dlinux\n\nand then split with `git cl split --target-range 8 32 --max-depth\u003d2\n--no-reviewers -d ~/description.txt`\n\nThis covers directories: components\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/u/1/d/1poEhNARfFas2osqPoXGzVZtBgnOQGQtQNUFTA-MlADs/edit?tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 431824299\nChange-Id: I1282679317c0b5879455db087b672d9c4083084e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6731989\nReviewed-by: Muyao Xu \u003cmuyaoxu@google.com\u003e\nReviewed-by: Emily Stark \u003cestark@chromium.org\u003e\nReviewed-by: Nidhi Jaju \u003cnidhijaju@chromium.org\u003e\nCommit-Queue: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Jonathan Ross \u003cjonross@chromium.org\u003e\nReviewed-by: Mikel Astiz \u003cmastiz@chromium.org\u003e\nReviewed-by: Darryl James \u003cdljames@chromium.org\u003e\nReviewed-by: Antonio Rivera \u003cantoniori@google.com\u003e\nReviewed-by: Martin Kreichgauer \u003cmartinkr@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Bao-Duy Tran \u003ctranbaoduy@chromium.org\u003e\nAuto-Submit: Stephen Nusko \u003cnuskos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1497369}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2cd85c2b87fdbdba704b34b66a0cf1eeb1ebbffc\n" }, { "commit": "93f6dfcb731b27cb5a3aa00b8c6b608b21de6223", "tree": "53e391109d7a9870a6d5dc7523202fc898268171", "parents": [ "6e5542378c5df0a5298aadd89e633478e11fe2b4" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Jul 28 18:58:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 28 19:04:34 2025" }, "message": "Auto-format //components/[p-z]* GN files\n\nRun \"gn format\" and automatically shorten target references, now that GN\nknows how to do this. Then manually delete duplicate entries in the\noutput. Also let GN clean up anything else it finds that is not\nformatted correctly.\n\nBug: 40760278\nChange-Id: Ie296be1613b5515bca8782ceff60e5ffa061b3ab\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6789738\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCommit-Queue: Ted Choc \u003ctedchoc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1492994}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b80b2b99e78beaa11a75072e161e7bbd346e6bd0\n" }, { "commit": "6e5542378c5df0a5298aadd89e633478e11fe2b4", "tree": "6254065ee83dcdf4431c6d7aab0005e5f4b3889c", "parents": [ "19fcd8ce61b0a43abd1673a51ee6d118930c0371" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jul 23 11:54:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 23 12:08:02 2025" }, "message": "Rework allow_unsafe pragmas in components/\n\nFully automated CL via tools/clang/unsafe_pragma_rewriter/ scripts,\nthen manually revert one file that failed DEPS checks.\n\nBug: 409340989\nChange-Id: I9949803989588810640b53eae14e5f02ac39a2fb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6715939\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1490730}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4413f7f927f8ddf9bfbee128b7c0161691b38913\n" }, { "commit": "19fcd8ce61b0a43abd1673a51ee6d118930c0371", "tree": "0e2181b1695e58f205a2fef8e61cf022e50594d9", "parents": [ "f966de99cc1b0e6603269d2c3104ebaf402c5d1d" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Wed Jul 23 08:03:31 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 23 08:12:06 2025" }, "message": "Add missing includes\n\nThis is to fix\nhttps://ci.chromium.org/ui/p/chromium/builders/try/linux-libfuzzer-asan-rel/2314057/overview\nand\nhttps://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_tsan_rel_ng/2414034/overview\n\nBug: 40263312\nChange-Id: I6f5be6398e3d9b03b4607a343d97221bf1675710\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780026\nOwners-Override: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Junji Watanabe \u003cjwata@google.com\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1490654}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: edc03b588da57ce59246a1cc5f2e0165a359dbc5\n" }, { "commit": "f966de99cc1b0e6603269d2c3104ebaf402c5d1d", "tree": "5e4c10b06c0015b3688d41f09bbc271806d14715", "parents": [ "e7470c0be39734fe181a5e838585c3b1d9fa6ed9" ], "author": { "name": "Elly", "email": "ellyjones@chromium.org", "time": "Thu Jul 17 17:03:59 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 17 17:11:12 2025" }, "message": "components/reporting: spanify crypto primitives\n\nThese are wrappers around boringssl at the moment so they accept raw\npointers and pass them through to bssl. Soon, they will be migrated to\ncall the //crypto wrappers which themselves accept spans. To prepare for\nthat, this CL changes the crypto primitives in reporting to take spans\nthemselves.\n\nBug: 372283556\nChange-Id: I34e9b592c0c0220778d267af3d4501ad10cf490f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6758190\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Elly FJ \u003cellyjones@chromium.org\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1488365}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2a9233053ebf86ad3b9ed104985cd8f5f522ecb8\n" }, { "commit": "e7470c0be39734fe181a5e838585c3b1d9fa6ed9", "tree": "f3cf28be4ebaedf77b13ef0853aa67a394d423bb", "parents": [ "48a27d696e1e19be4692353a7f1b9d75c982b4ad" ], "author": { "name": "shvm", "email": "shvm@google.com", "time": "Thu Jun 26 19:41:48 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 26 19:48:21 2025" }, "message": "Kiosk: Add new user type and profile load for arcvm kiosk\n\nBug: 388602323\nChange-Id: I7249db12f65cb00d5bfb986a9e3ada2e39cd337b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6471170\nAuto-Submit: Shivam Sharma \u003cshvm@google.com\u003e\nCommit-Queue: Shivam Sharma \u003cshvm@google.com\u003e\nReviewed-by: Anqing Zhao \u003canqing@chromium.org\u003e\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1479380}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 040170e8dcdd3dd93133e5d5dd13cce45ec93d26\n" }, { "commit": "48a27d696e1e19be4692353a7f1b9d75c982b4ad", "tree": "a2567cb5db526f08df0753408c9602ae2a56fca5", "parents": [ "6e931a0c7d971f5865cb65020580824fb79d3003" ], "author": { "name": "Dejie Zhang", "email": "djzhang@google.com", "time": "Mon Jun 09 23:16:00 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 09 23:22:03 2025" }, "message": "Add new destination DATA_LOST_ACTIVITY for creating a server side event to update data lost activity.\n\nChange-Id: I0bf772888f8de757fd4c2b81d0a622a52e37801d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6630726\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Dejie Zhang \u003cdjzhang@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1471493}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4134beab4be5136db57d0731d2e608c4043cf189\n" }, { "commit": "6e931a0c7d971f5865cb65020580824fb79d3003", "tree": "7245328c8d410024a2b0ed1af88f604354664dd0", "parents": [ "a5a570e8686dca2ebbfb808c62cb72f610d0fec5" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Sat Jun 07 21:04:51 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jun 07 21:10:05 2025" }, "message": "Fix IWYU issues to prepare to move cstring_view helpers out of span.h\n\nAdd includes for check_op.h and ostream as necessary. Also fixes IWYU\nfor check.h where noticed by the author.\n\nBug: 423048781\nChange-Id: I4e348bd898e57d221bf6f3bb902380e9936c338e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6628143\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1470972}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 610a205ccdfd8cba61a49d55eeed1635fa9b7790\n" }, { "commit": "a5a570e8686dca2ebbfb808c62cb72f610d0fec5", "tree": "34c5502032b7d17d8934c797105a86dd81117a75", "parents": [ "632542b0708829ce56b3c66e3d3855a691aa4af6" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Sat Jun 07 07:15:45 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jun 07 07:21:13 2025" }, "message": "Do some IWYU for base/logging.h\n\nSome files depend on base/feature_list.h to provide logging.h. A future\nCL will try to remove that, so do IWYU to prepare for that.\n\nBug: 40216326\nChange-Id: Icf10792f5b76b689481525d961d45e6f9386b5a9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6624721\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1470900}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8a5af199283ad2c25a4a0743d90d43ddc41399b4\n" }, { "commit": "632542b0708829ce56b3c66e3d3855a691aa4af6", "tree": "5b5f07962e227d72cb3c697a671680b52b8eab9e", "parents": [ "0f417f0f6cb7e3bd1119d101579ae96650b77ced" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Sat Jun 07 06:38:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jun 07 06:46:04 2025" }, "message": "Include base/strings/string_view_util.h for base::as_string_view()\n\nThis technically introduces IWYU violations but should make it easier to\nland the followup CL that performs the actual move.\n\nBug: 423048781\nChange-Id: I708da25493210ab4f5298d3d4c8caa8e2995d11b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6625024\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1470898}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 17390fd8ebc83f5074230e09b5c55d0e4c30c362\n" }, { "commit": "0f417f0f6cb7e3bd1119d101579ae96650b77ced", "tree": "30555bee427cebd92082184edfc7c2d92bda3901", "parents": [ "36c384fed3afeb2d70957bd9082381793017c884" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Wed Jun 04 06:37:48 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 04 06:42:30 2025" }, "message": "metrics: add edid version and serial number to DisplayStatus\n\nInitially, the commit 0211765461b3132d491cfc0adb502ff0bcc0e912, which\nintroduced ExternalDisplayEventsObserver, used InfoData instead of\nTelemetryData and was reverted as it was incorrect type of data that was\nused.\n\nIt was split into smaller pieces - 1) https://crrev.com/c/6563693 2)\nhttps://crrev.com/c/6563694 3) https://crrev.com/c/6543589\n\nNow, ExternalDisplayEventsObserver uses DisplayStatus, which is part of\nthe TelemetryData, but we need edid version and serial number to be sent\nvia the Telemetry API for clients to distinguish displays when they\ntriage problems.\n\nThis CL duplicates these two data members to resolve this issue.\n\nPS: usage of these new data fields will be adde in the next CL.\nBug: 327532834\nChange-Id: I95dddc8d2904b9654ee10b0635287ca4e4f02ec7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6614679\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nCr-Commit-Position: refs/heads/main@{#1469143}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a3865a3482523bef1630fddd20b08f09c6ee445b\n" }, { "commit": "36c384fed3afeb2d70957bd9082381793017c884", "tree": "e92739ad6a0695ab9cbc32ac6bed1d9935fe3e83", "parents": [ "2a506ff354e5fb80c358d2a960fa0af7004ebfc2" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Tue Jun 03 09:07:32 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 03 09:14:33 2025" }, "message": "Reland \"metrics: introduce ExternalDisplayEventsObserver\"\n\nThis is a reland of commit 0211765461b3132d491cfc0adb502ff0bcc0e912\n\n1) Switch to use DisplaysTelemetry instead of DisplayInfo\n2) Add chromeos::features::kExternalDisplayEventTelemetry\n3) Allow ExternalDisplayEventsObserver only if the feature\n enabled.\n4) Update tests\n\nOriginal change\u0027s description:\n\u003e metrics: introduce ExternalDisplayEventsObserver\n\u003e\n\u003e Introduces external display events observer and new metrics events that\n\u003e passes connected/disconnected external display via Telemetry API.\n\u003e\n\u003e Bug: 327532834\n\u003e Change-Id: Ie92106031ffb4cad1526e9a999fa45c1cfcea082\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489171\n\u003e Auto-Submit: Maksim Sisov \u003cmsisov@igalia.com\u003e\n\u003e Reviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Commit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1453327}\n\nBug: 327532834\nChange-Id: I3fdc0ee164846a18ae748b885836f86dfeb3d2d4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6543589\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nCr-Commit-Position: refs/heads/main@{#1468596}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8378841a9e6328d3bc7a3ea151b4db889f7c8d86\n" }, { "commit": "2a506ff354e5fb80c358d2a960fa0af7004ebfc2", "tree": "518abf48f48b942cf23b29e4cdf1a7cf2047a874", "parents": [ "2d371e4a8f68a1e929e75660af92ea015428494b" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Wed May 21 13:05:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 21 13:11:01 2025" }, "message": "metrics: add new external display connected/disconnected events\n\nIntroduce new metrics events that will be used when an external display\nis connected/disconnected. The events are part of the Telemetry API.\n\nThis is a partial reland of commit\n0211765461b3132d491cfc0adb502ff0bcc0e912 aiming at separating C++ and\nproto changes.\n\nBug: 327532834\nChange-Id: I8c6345af9873a854caed5c2774eed7139004e5f8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6563693\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nCr-Commit-Position: refs/heads/main@{#1463356}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 520e2c8722590ac285493bd0edc6e6ba104a98cb\n" }, { "commit": "2d371e4a8f68a1e929e75660af92ea015428494b", "tree": "edaa348d8dc63ef6d2d9fb33c157364d0d4072d5", "parents": [ "65f596acf685646a70e57da7a9d09632e1267097" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue May 20 23:52:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 20 23:58:29 2025" }, "message": "Remove superfluous includes for \u003cqueue\u003e in headers\n\nHeaders that do not use std::queue or std::priority_queue do not need to\ninclude \u003cqueue\u003e.\n\n- Headers that use std::deque can include \u003cdeque\u003e instead.\n- Do IWYU to fix the build.\n\nBug: 40318405\nChange-Id: I52bcf59e0c73fe069aa8490237202fc29568700d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6570349\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1463099}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: acf3d6d985ee8afc93afc12d98538716a21cfa8c\n" }, { "commit": "65f596acf685646a70e57da7a9d09632e1267097", "tree": "87b9bcaaf8145c011bcc2f56d9f95b7881d8eb6a", "parents": [ "952fc502ddafe2598daa3ae164d8359c4e98cab3" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Mon May 19 16:19:51 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 19 16:24:58 2025" }, "message": "Remove checks for null return from make_unique() in components/reporting\n\nstd::make_unique cannot return nullptr. Fix code in components/reporting\nthat checked for that.\n\nNo functional change.\n\nThis CL was uploaded by git cl split.\n\nR\u003dlbaraz@chromium.org\n\nChange-Id: Ie17fc8671337ae64c48cfc9144e33a8452db5037\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6562681\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nAuto-Submit: Adam Rice \u003cricea@chromium.org\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1462197}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ca1c68483fa9ffc4830a9e154f22625c9bed98bb\n" }, { "commit": "952fc502ddafe2598daa3ae164d8359c4e98cab3", "tree": "f3b17f0f54f9c3cef921e06572646e613014b0e2", "parents": [ "d23f3293bef4a823be1a478cc0dacf6fd93bbc15" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Fri May 16 01:53:52 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 16 01:59:13 2025" }, "message": "[owners] Remove jrhilke@google.com from components/reporting/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\n\nPlease approve this change and vote the highest CR. This will keep the OWNERs\nfile tidy. We ask that you do not ignore this change and approve it\nunless you know a reason the OWNER should remain. It can always be\nreverted if needed.\n\nIf this change is in error, vote the lowest CR value (i.e. reject the CL)\nand the bot will abandon it.\n\nSee the owner\u0027s recent review activity for context:\nhttps://chromium-review.googlesource.com/q/jrhilke@google.com\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: I49b3c0dff0d39fc0a4342fd6a6b0a78ccabb579c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6554551\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nCommit-Queue: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1461121}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6b6b8ee538d466ee6a304cf04849a74e854133c9\n" }, { "commit": "d23f3293bef4a823be1a478cc0dacf6fd93bbc15", "tree": "26ef5200db216d9e0aab5887272d7151bcac7ed6", "parents": [ "e15c7b6cf991e56aee7c656945539cbf51a59d26" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@chromium.org", "time": "Wed May 14 20:15:27 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 14 20:21:30 2025" }, "message": "Add missing `reserve` to proto enum\n\nWhen automatic revert crrev.com/c/6540665 was created,\nit removed proto enum but did not mark the removed values\nas reserved.\n\nDoing it now.\n\nBug: 327532834\nChange-Id: I672a0b9b1ec21a196eadf4719637b209071dcf26\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6546411\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nAuto-Submit: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1460326}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d21877d8c302a5de0f7118c45a0fb7a3d8eea6b3\n" }, { "commit": "e15c7b6cf991e56aee7c656945539cbf51a59d26", "tree": "8a70a6c04dc65b3f540597536cfae093455a3c1c", "parents": [ "2034de2ef1172dc1b15740fc46ce24eddfd7c2a4" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@chromium.org", "time": "Tue May 13 17:24:31 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 13 17:29:53 2025" }, "message": "Revert \"metrics: introduce ExternalDisplayEventsObserver\"\n\nThis reverts commit 0211765461b3132d491cfc0adb502ff0bcc0e912.\n\nReason for revert: the feature is implemented incorrectly:\n 1. it is not guarded by finch flag for rollout.\n 2. the data generated is attached as \"info\" instead of \"telemetry\" proto which the server recognizes, in this case it should be part of \"PeripheralsTelemetry\"\n Here are the guidelines: https://g3doc.corp.google.com/chrome/cros/reporting/g3doc/users/events/add_new_insights_metric.md#add-new-event-metric\n\nBug: 327532834\nOriginal change\u0027s description:\n\u003e metrics: introduce ExternalDisplayEventsObserver\n\u003e\n\u003e Introduces external display events observer and new metrics events that\n\u003e passes connected/disconnected external display via Telemetry API.\n\u003e\n\u003e Bug: 327532834\n\u003e Change-Id: Ie92106031ffb4cad1526e9a999fa45c1cfcea082\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489171\n\u003e Auto-Submit: Maksim Sisov \u003cmsisov@igalia.com\u003e\n\u003e Reviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Commit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1453327}\n\nBug: 327532834\nChange-Id: I7107199f47e01723d1041c3b011c0474c999ead3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6540665\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1459551}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e455bc038e9b802265fd5b7026fc0208a0fce921\n" }, { "commit": "2034de2ef1172dc1b15740fc46ce24eddfd7c2a4", "tree": "f7ee17d8c165a8acf3b94ece2c06c01204c35719", "parents": [ "381fd7a8a436d37ec7b14d3c7b3f3cb4eb9071e7" ], "author": { "name": "Forest Elliott", "email": "felliott@google.com", "time": "Fri May 09 21:39:44 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 09 21:46:37 2025" }, "message": "Add DESKTOP_STATUS_REPORT_PREPROCESS as destination\n\nChange-Id: Id7dec5382c6e4d08e1b6e121313df7283c4e3d2a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6528109\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCommit-Queue: Forest Elliott \u003cfelliott@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1458357}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3a35136c89a4862930a036df8e7cd9e8c2fea68e\n" }, { "commit": "381fd7a8a436d37ec7b14d3c7b3f3cb4eb9071e7", "tree": "c056bc81fe06cdb8d2416ecf9a79b98482ce3514", "parents": [ "4172b2c33bd3a0050fca0c24fbb34893dbb50802" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Fri May 09 12:17:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 09 12:22:20 2025" }, "message": "Reland #2 \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\nThis reverts commit ff6e76aec780005f6b81df93c63e8fc6360b6c1c.\n\nReason for reland: Fixed link error on fuzzer bot\n* Also made a couple other fuzzer-related GN simplifications.\n\nOriginal change\u0027s description:\n\u003e Revert \"Reland \"Make proto_library() actions depend directly on their dep\u0027s actions\"\"\n\u003e\n\u003e This reverts commit c3c72ad87345c26e28f78b6d97f571402548cd47.\n\u003e\n\u003e Reason for revert: suspect compile failure on Libfuzzer Upload Chrome OS Asan\n\u003e\n\u003e First build failure:\n\u003e https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/122004/overview\n\u003e\n\u003e Failure summary:\n\u003e ---\n\u003e [75972/75984] LINK ./policy_fuzzer\n\u003e python3 ../../build/toolchain/gcc_link_wrapper.py --output\u003d./policy_fuzzer -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Werror...(too long)\n\u003e ld.lld: error: duplicate symbol: enterprise_management::DevicePolicyRefreshRateProto::DevicePolicyRefreshRateProto(google::protobuf::Arena*)\n\u003e \u003e\u003e\u003e defined at chrome_device_policy.pb.cc:5287 (gen/components/policy/proto/chrome_device_policy.pb.cc:5287)\n\u003e \u003e\u003e\u003e obj/components/policy/proto/proto_internal/chrome_device_policy.pb.o:(enterprise_management::DevicePolicyRefreshRateProto::DevicePolicyRefreshRateProto(google::protobuf::Arena*))\n\u003e \u003e\u003e\u003e defined at chrome_device_policy.pb.cc:7534 (gen/components/policy/proto/fuzzer/chrome_device_policy.pb.cc:7534)\n\u003e \u003e\u003e\u003e chrome_device_policy_full_runtime_proto__proto/chrome_device_policy.pb.o:(.text+0x0) in archive obj/components/policy/proto/fuzzer/libchrome_device_policy_full_runtime_proto__proto.a\n\u003e ---\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Reland \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\u003e \u003e\n\u003e \u003e This reverts commit 3c31897013d5a332da2b05cf5f1ed1469433233b.\n\u003e \u003e\n\u003e \u003e Reason for reland: Update dep labels\n\u003e \u003e\n\u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e Revert \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\u003e \u003e \u003e\n\u003e \u003e \u003e This reverts commit 01bb32f8cee2c8a36a55e8b9b82600170ee8303b.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Reason for revert: broke https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan :\n\u003e \u003e \u003e\n\u003e \u003e \u003e ERROR Unresolved dependencies.\n\u003e \u003e \u003e //chrome/browser/resources/chromeos/contact_center_insights:reporting_protos(//build/toolchain/linux:clang_x64)\n\u003e \u003e \u003e needs //components/reporting/proto:proto_library_health_proto_gen(//build/toolchain/linux:clang_x64)\n\u003e \u003e \u003e\n\u003e \u003e \u003e and the latter is changed by this CL.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e \u003e Make proto_library() actions depend directly on their dep\u0027s actions\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e Instead of on their source_set() targets, which blocks the actions on\n\u003e \u003e \u003e \u003e compile steps that it doesn\u0027t need.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e This necessitates removing visibility from the generation action, and\n\u003e \u003e \u003e \u003e thus removing the need for \"generator_visibility\", which IMO provided\n\u003e \u003e \u003e \u003e negative value.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e Change-Id: I75abd295ee5a2943fcdd9c4a15d569c43056b872\n\u003e \u003e \u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505727\n\u003e \u003e \u003e \u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e \u003e \u003e Owners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e \u003e \u003e Reviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e \u003e \u003e \u003e Cr-Commit-Position: refs/heads/main@{#1456968}\n\u003e \u003e \u003e\n\u003e \u003e \u003e No-Presubmit: true\n\u003e \u003e \u003e No-Tree-Checks: true\n\u003e \u003e \u003e No-Try: true\n\u003e \u003e \u003e Change-Id: Idd8cd73bf8d9485414d1adbade6bf9082010fb1c\n\u003e \u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519496\n\u003e \u003e \u003e Owners-Override: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e \u003e \u003e Auto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e \u003e \u003e Commit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e \u003e \u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e \u003e \u003e Cr-Commit-Position: refs/heads/main@{#1457005}\n\u003e \u003e\n\u003e \u003e Change-Id: I4f109ce03d7941df914b2dc01e99729b77950092\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6518391\n\u003e \u003e Auto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e Owners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e Reviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1457159}\n\u003e\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Change-Id: I21b0b25281904a4db0ce35b5763a49c74aa37917\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6521886\n\u003e Auto-Submit: Takashi Sakamoto \u003ctasak@google.com\u003e\n\u003e Commit-Queue: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Owners-Override: Takashi Sakamoto \u003ctasak@google.com\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1457346}\n\nChange-Id: I48cff63e3dd7e8405af2ea9cdff175e27c69b1ee\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6528249\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1458070}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 57f4ffeb6480af3190995f55362639c168a0d92e\n" }, { "commit": "4172b2c33bd3a0050fca0c24fbb34893dbb50802", "tree": "0aec6bfbb6ab896deef59a946430a792cfb96137", "parents": [ "e4474314e82ff3b7dc2f706e3c199042fe6f7d88" ], "author": { "name": "Takashi Sakamoto", "email": "tasak@google.com", "time": "Thu May 08 00:42:11 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 08 00:48:10 2025" }, "message": "Revert \"Reland \"Make proto_library() actions depend directly on their dep\u0027s actions\"\"\n\nThis reverts commit c3c72ad87345c26e28f78b6d97f571402548cd47.\n\nReason for revert: suspect compile failure on Libfuzzer Upload Chrome OS Asan\n\nFirst build failure:\nhttps://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/122004/overview\n\nFailure summary:\n---\n[75972/75984] LINK ./policy_fuzzer\npython3 ../../build/toolchain/gcc_link_wrapper.py --output\u003d./policy_fuzzer -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Werror...(too long)\nld.lld: error: duplicate symbol: enterprise_management::DevicePolicyRefreshRateProto::DevicePolicyRefreshRateProto(google::protobuf::Arena*)\n\u003e\u003e\u003e defined at chrome_device_policy.pb.cc:5287 (gen/components/policy/proto/chrome_device_policy.pb.cc:5287)\n\u003e\u003e\u003e obj/components/policy/proto/proto_internal/chrome_device_policy.pb.o:(enterprise_management::DevicePolicyRefreshRateProto::DevicePolicyRefreshRateProto(google::protobuf::Arena*))\n\u003e\u003e\u003e defined at chrome_device_policy.pb.cc:7534 (gen/components/policy/proto/fuzzer/chrome_device_policy.pb.cc:7534)\n\u003e\u003e\u003e chrome_device_policy_full_runtime_proto__proto/chrome_device_policy.pb.o:(.text+0x0) in archive obj/components/policy/proto/fuzzer/libchrome_device_policy_full_runtime_proto__proto.a\n---\n\nOriginal change\u0027s description:\n\u003e Reland \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\u003e\n\u003e This reverts commit 3c31897013d5a332da2b05cf5f1ed1469433233b.\n\u003e\n\u003e Reason for reland: Update dep labels\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Revert \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\u003e \u003e\n\u003e \u003e This reverts commit 01bb32f8cee2c8a36a55e8b9b82600170ee8303b.\n\u003e \u003e\n\u003e \u003e Reason for revert: broke https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan :\n\u003e \u003e\n\u003e \u003e ERROR Unresolved dependencies.\n\u003e \u003e //chrome/browser/resources/chromeos/contact_center_insights:reporting_protos(//build/toolchain/linux:clang_x64)\n\u003e \u003e needs //components/reporting/proto:proto_library_health_proto_gen(//build/toolchain/linux:clang_x64)\n\u003e \u003e\n\u003e \u003e and the latter is changed by this CL.\n\u003e \u003e\n\u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e Make proto_library() actions depend directly on their dep\u0027s actions\n\u003e \u003e \u003e\n\u003e \u003e \u003e Instead of on their source_set() targets, which blocks the actions on\n\u003e \u003e \u003e compile steps that it doesn\u0027t need.\n\u003e \u003e \u003e\n\u003e \u003e \u003e This necessitates removing visibility from the generation action, and\n\u003e \u003e \u003e thus removing the need for \"generator_visibility\", which IMO provided\n\u003e \u003e \u003e negative value.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Change-Id: I75abd295ee5a2943fcdd9c4a15d569c43056b872\n\u003e \u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505727\n\u003e \u003e \u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e \u003e Owners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e \u003e Reviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e \u003e \u003e Cr-Commit-Position: refs/heads/main@{#1456968}\n\u003e \u003e\n\u003e \u003e No-Presubmit: true\n\u003e \u003e No-Tree-Checks: true\n\u003e \u003e No-Try: true\n\u003e \u003e Change-Id: Idd8cd73bf8d9485414d1adbade6bf9082010fb1c\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519496\n\u003e \u003e Owners-Override: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e \u003e Auto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e \u003e Commit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e \u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1457005}\n\u003e\n\u003e Change-Id: I4f109ce03d7941df914b2dc01e99729b77950092\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6518391\n\u003e Auto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Owners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Reviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1457159}\n\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I21b0b25281904a4db0ce35b5763a49c74aa37917\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6521886\nAuto-Submit: Takashi Sakamoto \u003ctasak@google.com\u003e\nCommit-Queue: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Takashi Sakamoto \u003ctasak@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1457346}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ff6e76aec780005f6b81df93c63e8fc6360b6c1c\n" }, { "commit": "e4474314e82ff3b7dc2f706e3c199042fe6f7d88", "tree": "c056bc81fe06cdb8d2416ecf9a79b98482ce3514", "parents": [ "6ae03a038bab6f5f59ccb890bf3c27c29a1e6996" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Wed May 07 18:41:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 07 18:46:50 2025" }, "message": "Reland \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\nThis reverts commit 3c31897013d5a332da2b05cf5f1ed1469433233b.\n\nReason for reland: Update dep labels\n\nOriginal change\u0027s description:\n\u003e Revert \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\u003e\n\u003e This reverts commit 01bb32f8cee2c8a36a55e8b9b82600170ee8303b.\n\u003e\n\u003e Reason for revert: broke https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan :\n\u003e\n\u003e ERROR Unresolved dependencies.\n\u003e //chrome/browser/resources/chromeos/contact_center_insights:reporting_protos(//build/toolchain/linux:clang_x64)\n\u003e needs //components/reporting/proto:proto_library_health_proto_gen(//build/toolchain/linux:clang_x64)\n\u003e\n\u003e and the latter is changed by this CL.\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Make proto_library() actions depend directly on their dep\u0027s actions\n\u003e \u003e\n\u003e \u003e Instead of on their source_set() targets, which blocks the actions on\n\u003e \u003e compile steps that it doesn\u0027t need.\n\u003e \u003e\n\u003e \u003e This necessitates removing visibility from the generation action, and\n\u003e \u003e thus removing the need for \"generator_visibility\", which IMO provided\n\u003e \u003e negative value.\n\u003e \u003e\n\u003e \u003e Change-Id: I75abd295ee5a2943fcdd9c4a15d569c43056b872\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505727\n\u003e \u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e Owners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e \u003e Reviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1456968}\n\u003e\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Change-Id: Idd8cd73bf8d9485414d1adbade6bf9082010fb1c\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519496\n\u003e Owners-Override: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e Auto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e Commit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1457005}\n\nChange-Id: I4f109ce03d7941df914b2dc01e99729b77950092\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6518391\nAuto-Submit: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Sam Maier \u003csmaier@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1457159}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c3c72ad87345c26e28f78b6d97f571402548cd47\n" }, { "commit": "6ae03a038bab6f5f59ccb890bf3c27c29a1e6996", "tree": "0aec6bfbb6ab896deef59a946430a792cfb96137", "parents": [ "fb2ef904ea99de5e91c2f94ca61d6ee0f68b860d" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed May 07 15:16:52 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 07 15:22:10 2025" }, "message": "Revert \"Make proto_library() actions depend directly on their dep\u0027s actions\"\n\nThis reverts commit 01bb32f8cee2c8a36a55e8b9b82600170ee8303b.\n\nReason for revert: broke https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan :\n\nERROR Unresolved dependencies.\n//chrome/browser/resources/chromeos/contact_center_insights:reporting_protos(//build/toolchain/linux:clang_x64)\n needs //components/reporting/proto:proto_library_health_proto_gen(//build/toolchain/linux:clang_x64)\n\nand the latter is changed by this CL.\n\nOriginal change\u0027s description:\n\u003e Make proto_library() actions depend directly on their dep\u0027s actions\n\u003e\n\u003e Instead of on their source_set() targets, which blocks the actions on\n\u003e compile steps that it doesn\u0027t need.\n\u003e\n\u003e This necessitates removing visibility from the generation action, and\n\u003e thus removing the need for \"generator_visibility\", which IMO provided\n\u003e negative value.\n\u003e\n\u003e Change-Id: I75abd295ee5a2943fcdd9c4a15d569c43056b872\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505727\n\u003e Commit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Owners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\n\u003e Reviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1456968}\n\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: Idd8cd73bf8d9485414d1adbade6bf9082010fb1c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519496\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1457005}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3c31897013d5a332da2b05cf5f1ed1469433233b\n" }, { "commit": "fb2ef904ea99de5e91c2f94ca61d6ee0f68b860d", "tree": "c056bc81fe06cdb8d2416ecf9a79b98482ce3514", "parents": [ "659b381d1a0406cea1b418271f3efc52b70e76e9" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Wed May 07 13:57:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 07 14:03:39 2025" }, "message": "Make proto_library() actions depend directly on their dep\u0027s actions\n\nInstead of on their source_set() targets, which blocks the actions on\ncompile steps that it doesn\u0027t need.\n\nThis necessitates removing visibility from the generation action, and\nthus removing the need for \"generator_visibility\", which IMO provided\nnegative value.\n\nChange-Id: I75abd295ee5a2943fcdd9c4a15d569c43056b872\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505727\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1456968}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 01bb32f8cee2c8a36a55e8b9b82600170ee8303b\n" }, { "commit": "659b381d1a0406cea1b418271f3efc52b70e76e9", "tree": "0aec6bfbb6ab896deef59a946430a792cfb96137", "parents": [ "6473a760c21fb1ac24999b08097c89af54a630a7" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Tue May 06 18:21:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 18:28:22 2025" }, "message": "Modernize equality operators\n\nThis CL is pure clean-up and contains no functionality changes.\nDepending on the files covered in the CL (since the CL was generated\nusing git cl split), it does a subset of the following:\n- Remove unneeded operator!\u003d declarations/definitions since C++20 can\n automatically derive those from operator\u003d\u003d.\n- Default operator\u003d\u003d where this is equivalent to the current behavior.\n- Default operator\u003c\u003d\u003e where this is equivalent to the current\n behavior.\n\nThis CL was uploaded by git cl split.\n\nR\u003danasr@google.com\n\nBug: 40256175\nChange-Id: I0b08a36d2968b44eaacfb81eaaaca5e41b5ea7ea\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513045\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1456474}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 630a4e4c40f04f72738710d1d12a5710b3d2d1c0\n" }, { "commit": "6473a760c21fb1ac24999b08097c89af54a630a7", "tree": "464bfa59602fbad5e81c738b905eab51bb4ef269", "parents": [ "223c77680488b4e857e4806bc324914f32d1af28" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Fri May 02 03:25:33 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 18:27:51 2025" }, "message": "components: Change deps type in a proto_library\n\nThis is extracted from https://crrev.com/c/6442961/29\n\nAnd this is a preparation CL to change public_deps in proto_library\ntemplate to deps to remove unnecessary dependency propagation.\n\nBug: 402356473\nChange-Id: If07e3cc97f5cab1f729c61b46399a3bc7a927607\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6502033\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1454812}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 23d2f8837262ff33744cd5ba51a86ebdd9f0d4c2\n" }, { "commit": "223c77680488b4e857e4806bc324914f32d1af28", "tree": "3856d686e72a3a26a5c5d1d7220d90a3bc68793c", "parents": [ "4698d333d13127d6c76bbf3e98a64cbfbaf812ba" ], "author": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Thu May 01 21:04:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 01 21:10:50 2025" }, "message": "spanification: remove `#pragma allow_unsafe_buffers` where unneeded\n\nThis is a clean up of any files that now compile without the pragma.\nThis CL has no behavior changes.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/remove-unneeded-pragmas.py\n\nand then split with\n`git cl split --target-range 8 32 --max-depth\u003d2 --expect-owners-override --no-reviewers -d ~/description.txt`\n\nThis covers directories:\n[\u0027components/variations\u0027, \u0027components/commerce\u0027, \u0027components/domain_reliability\u0027, \u0027components/payments\u0027, \u0027components/system_cpu\u0027, \u0027components/zucchini\u0027, \u0027components/error_page\u0027, \u0027components/feedback\u0027, \u0027components/media_router\u0027, \u0027components/metrics\u0027, \u0027components/reporting\u0027, \u0027components/search_engines\u0027]\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 414858406\nChange-Id: Ib6241b62a104471668506478b357dd79adb146f1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6504356\nReviewed-by: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1454666}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f5cc789ee6e68419e2671682503c3d5ee5fe1af\n" }, { "commit": "4698d333d13127d6c76bbf3e98a64cbfbaf812ba", "tree": "ebbab4b1e9cb4c557e07511e622a7f67d367cd21", "parents": [ "5e55f51df8ec05de9f27b2a9218df2417c53c9d4" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Tue Apr 29 16:42:27 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 29 16:49:56 2025" }, "message": "metrics: introduce ExternalDisplayEventsObserver\n\nIntroduces external display events observer and new metrics events that\npasses connected/disconnected external display via Telemetry API.\n\nBug: 327532834\nChange-Id: Ie92106031ffb4cad1526e9a999fa45c1cfcea082\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489171\nAuto-Submit: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1453327}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0211765461b3132d491cfc0adb502ff0bcc0e912\n" }, { "commit": "5e55f51df8ec05de9f27b2a9218df2417c53c9d4", "tree": "c042e0002f6752c1aac9e3f61c53a033bdf8f3dd", "parents": [ "c1bc607a08f567aec21772b749edf14219d7092c" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Fri Apr 18 16:35:56 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 18 16:42:04 2025" }, "message": "Reland \"telemetry: extend networking info with IPv6 and other fields\"\n\nThis is a reland of commit 21cd9690e135ead341fb000d405f26e39618f3a1\n\nNew fields such as max download link speed revealed that the\nNetworkState had |max_downlink_speed_kbps| not initialized. As a result,\nwhen GetUInt32Value was called it internally compared a value it read\nfrom `value` with `max_downlink_speed_kbps` passed as a pointer. Given\nthat `max_downlink_speed_kbps` had never been initialized, it raised a\nred flag in msan builds.\n\n`max_uplink_speed_kbps` wasn\u0027t initialized either, so I proactively did\ninitial initialization of that.\n\nOriginal change\u0027s description:\n\u003e telemetry: extend networking info with IPv6 and other fields\n\u003e\n\u003e There is a request to extend the networking info in such a way that it\n\u003e the Telemetry API can provide the following information in addition to\n\u003e already provided one - 1) IPv6 addresses + gateway 2) Whether the\n\u003e connection is metered 3) max download link speed\n\u003e\n\u003e Design doc -\n\u003e https://docs.google.com/document/d/1JEKN9_WEV0PEVabQHE7GsXaKQk5UjGyhcVDJDS_4b4E\n\u003e\n\u003e Bug: 327532834\n\u003e Change-Id: I5837c2b87b909c5e399b769c40f1ccffdfd2e46c\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450338\n\u003e Reviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Commit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1448194}\n\nBug: 327532834, 411343738\nCq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng\nChange-Id: I0bd0d2e9a4e310866774355f8e1c5379a553e431\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6469897\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1448902}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5fdea1ab9e023b4469a634739496c16f278d264c\n" }, { "commit": "c1bc607a08f567aec21772b749edf14219d7092c", "tree": "1271a22cd44b507ade71c478dd654012633db754", "parents": [ "fc8f074804dc61cf56ec87c0c9b91601a82c3dc0" ], "author": { "name": "Maria Kazinova", "email": "kazinova@google.com", "time": "Thu Apr 17 12:23:05 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 17 12:28:12 2025" }, "message": "Revert \"telemetry: extend networking info with IPv6 and other fields\"\n\nThis reverts commit 21cd9690e135ead341fb000d405f26e39618f3a1.\n\nReason for revert: NetworkTelemetrySamplerTest are broken\ncrbug.com/411343738\n\nBug: 327532834\nOriginal change\u0027s description:\n\u003e telemetry: extend networking info with IPv6 and other fields\n\u003e\n\u003e There is a request to extend the networking info in such a way that it\n\u003e the Telemetry API can provide the following information in addition to\n\u003e already provided one - 1) IPv6 addresses + gateway 2) Whether the\n\u003e connection is metered 3) max download link speed\n\u003e\n\u003e Design doc -\n\u003e https://docs.google.com/document/d/1JEKN9_WEV0PEVabQHE7GsXaKQk5UjGyhcVDJDS_4b4E\n\u003e\n\u003e Bug: 327532834\n\u003e Change-Id: I5837c2b87b909c5e399b769c40f1ccffdfd2e46c\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450338\n\u003e Reviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Commit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1448194}\n\nBug: 327532834\nChange-Id: I0ababc1a60c4b2403e47dbf82c8416d65a046c53\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6468397\nOwners-Override: Maria Kazinova \u003ckazinova@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Maria Kazinova \u003ckazinova@google.com\u003e\nAuto-Submit: Maria Kazinova \u003ckazinova@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1448248}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5dada1facf2f70e02f119b3446c9fd5bfb72e78c\n" }, { "commit": "fc8f074804dc61cf56ec87c0c9b91601a82c3dc0", "tree": "c042e0002f6752c1aac9e3f61c53a033bdf8f3dd", "parents": [ "caee893d81af0a5aae10cee3b3c8cf184304e572" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Thu Apr 17 08:21:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 17 08:27:46 2025" }, "message": "telemetry: extend networking info with IPv6 and other fields\n\nThere is a request to extend the networking info in such a way that it\nthe Telemetry API can provide the following information in addition to\nalready provided one - 1) IPv6 addresses + gateway 2) Whether the\nconnection is metered 3) max download link speed\n\nDesign doc -\nhttps://docs.google.com/document/d/1JEKN9_WEV0PEVabQHE7GsXaKQk5UjGyhcVDJDS_4b4E\n\nBug: 327532834\nChange-Id: I5837c2b87b909c5e399b769c40f1ccffdfd2e46c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450338\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nCr-Commit-Position: refs/heads/main@{#1448194}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 21cd9690e135ead341fb000d405f26e39618f3a1\n" }, { "commit": "caee893d81af0a5aae10cee3b3c8cf184304e572", "tree": "1271a22cd44b507ade71c478dd654012633db754", "parents": [ "ee0411d1663bc910578399e9d815a919b9719f44" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Thu Apr 17 07:57:33 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 17 08:06:05 2025" }, "message": "telemetry: extend DisplayDevice with edid version and serial number\n\nThis CL extends DisplayDevice telemetry info data with two new metrics\nthat are already reported by the cros_healthd - serial number and edid\nversion.\n\nDesign doc -\nhttps://docs.google.com/document/d/1JEKN9_WEV0PEVabQHE7GsXaKQk5UjGyhcVDJDS_4b4E\n\nBug: 327532834\nChange-Id: I6d5f6ec5f43f17f9b4aaf9ad8e4fc7b2f47c4202\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6459604\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1448185}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 089926a2cf70172451cffbf5f797f8c6895a5a44\n" }, { "commit": "ee0411d1663bc910578399e9d815a919b9719f44", "tree": "64f1213750650870ca6ca07743a4c257168a40ef", "parents": [ "b7181ce6e3f454ed248a5751fd3317d9ef9cc44e" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Tue Apr 15 18:41:45 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 15 18:47:14 2025" }, "message": "spanify: Renewed arrayification (X/43)\n\nThis CL is part of the wider spanification / arrayification effort [1]\nand does not (intentionally) introduce behavioral change. It applies the\n`std::array` rewrite to\n\n[\u0027components/page_load_metrics\u0027, \u0027components/domain_reliability\u0027, \u0027components/payments\u0027, \u0027components/system_cpu\u0027, \u0027components/bookmarks\u0027, \u0027components/cast_streaming\u0027, \u0027components/gcm_driver\u0027, \u0027components/gwp_asan\u0027, \u0027components/query_parser\u0027, \u0027components/reporting\u0027, \u0027components/webrtc\u0027]\n\nas close as possible to the output directly written by `spanify`, with\nno hand-rolled fixes (except where rebasing would require).\n\nThis change (and its siblings taken together) is thought not to cause\nany measurable perf regressions [2].\n\n[1] https://issues.chromium.org/356643982\n[2] https://docs.google.com/document/d/1jughaR6JKn7T-dDjMou10awyNkhE5T-vLY_K2YMqHE4/edit?tab\u003dt.0#heading\u003dh.r2eguxl5lhu7\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 406029216\nChange-Id: I6b2de5d5e3c2d5e7f7265f3f96999e85458c22cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6433398\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Stephen Nusko \u003cnuskos@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Kalvin Lee \u003ckdlee@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1447263}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 82085a8b840562aaf22f691894edf17908a6360f\n" }, { "commit": "b7181ce6e3f454ed248a5751fd3317d9ef9cc44e", "tree": "f1e5ae2b17a8b6db668cd05968044d23b10fa753", "parents": [ "9de72eaf03db582d0163ad139a389c5597fbe231" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Thu Apr 10 18:44:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 10 18:49:47 2025" }, "message": "metrics: pass MAX value + 1 to UmaHistogramEnumeration\n\nMetricEventType defined proto doesn\u0027t specify separate max value, but\nrather it\u0027s generated from proto. UmaHistogramEnumeration expects that\nMAX value is less than last value of enum. As a result, if the very last\nenum value from the MetricEventType type is passed, DCHECK can be hit as\nMetricEventType_MAX \u003d\u003d last value of MetricEventType.\n\nBug: None\nChange-Id: Idf6254da52c9c0ae8ab56aa9ca044c91c67f87ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6439646\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1445391}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 637928e9abf00d556021807830072a0659edc639\n" }, { "commit": "9de72eaf03db582d0163ad139a389c5597fbe231", "tree": "c97ee6f2e3c91a3ccd543a6a314d65796f7ec00b", "parents": [ "70e6e65913c9d85fb2ff8794b6eeaa3339a74084" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Thu Apr 03 07:05:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 03 07:27:14 2025" }, "message": "Reland \"reporting_protos: Use generator_visibility for some proto_library targets\"\n\nThis reverts commit b771914506ff54d9200e5531179fbfe3cb838b35.\n\nReason for revert:\nFixed targets in deps for libfuzzer build.\n\nOriginal change\u0027s description:\n\u003e Revert \"reporting_protos: Use generator_visibility for some proto_library targets\"\n\u003e\n\u003e This reverts commit 8db27252ea6d599c07585e4be8fc647b10f68da1.\n\u003e\n\u003e Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/121024/overview\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e reporting_protos: Use generator_visibility for some proto_library targets\n\u003e \u003e\n\u003e \u003e This is necessary to change public_deps to deps in proto_library\n\u003e \u003e template so that we can remove unnecessary inputs dependency from ninja\n\u003e \u003e build files.\n\u003e \u003e\n\u003e \u003e Original CL is: https://crrev.com/c/6414089\n\u003e \u003e\n\u003e \u003e Bug: 402356473\n\u003e \u003e Change-Id: I92b76d71d2d4423aa6144f5639cc2616d330118e\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6424782\n\u003e \u003e Auto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e \u003e Commit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\n\u003e \u003e Reviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1441435}\n\u003e\n\u003e Bug: 402356473\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Change-Id: I483abf98a531480b465fafe88398416680d41b6f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6425382\n\u003e Commit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\n\u003e Reviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\n\u003e Auto-Submit: Morten Stenshorne \u003cmstensho@chromium.org\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1441439}\n\nBug: 402356473\nCq-Include-Trybots: luci.chromium.try:chromeos-libfuzzer-asan-rel\nChange-Id: Ic97ffccd3c4787c40d153ac468cb65f2fec3c118\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6428965\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1441994}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: efa4177a6013cabd26cf6102a216776e1d7175ad\n" }, { "commit": "70e6e65913c9d85fb2ff8794b6eeaa3339a74084", "tree": "9569e9668a94ae0e4165a3a9d39a48df54fe24a6", "parents": [ "c8e68f80c9cfe6331080c08b2685a2af0232291b" ], "author": { "name": "Morten Stenshorne", "email": "mstensho@chromium.org", "time": "Wed Apr 02 11:25:40 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 02 11:30:54 2025" }, "message": "Revert \"reporting_protos: Use generator_visibility for some proto_library targets\"\n\nThis reverts commit 8db27252ea6d599c07585e4be8fc647b10f68da1.\n\nReason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/121024/overview\n\nOriginal change\u0027s description:\n\u003e reporting_protos: Use generator_visibility for some proto_library targets\n\u003e\n\u003e This is necessary to change public_deps to deps in proto_library\n\u003e template so that we can remove unnecessary inputs dependency from ninja\n\u003e build files.\n\u003e\n\u003e Original CL is: https://crrev.com/c/6414089\n\u003e\n\u003e Bug: 402356473\n\u003e Change-Id: I92b76d71d2d4423aa6144f5639cc2616d330118e\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6424782\n\u003e Auto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e Commit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\n\u003e Reviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1441435}\n\nBug: 402356473\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I483abf98a531480b465fafe88398416680d41b6f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6425382\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nAuto-Submit: Morten Stenshorne \u003cmstensho@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1441439}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b771914506ff54d9200e5531179fbfe3cb838b35\n" }, { "commit": "c8e68f80c9cfe6331080c08b2685a2af0232291b", "tree": "c97ee6f2e3c91a3ccd543a6a314d65796f7ec00b", "parents": [ "12e51eaf5a32bb0329390184f848eeee1bf38394" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Wed Apr 02 11:08:12 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 02 11:14:10 2025" }, "message": "reporting_protos: Use generator_visibility for some proto_library targets\n\nThis is necessary to change public_deps to deps in proto_library\ntemplate so that we can remove unnecessary inputs dependency from ninja\nbuild files.\n\nOriginal CL is: https://crrev.com/c/6414089\n\nBug: 402356473\nChange-Id: I92b76d71d2d4423aa6144f5639cc2616d330118e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6424782\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1441435}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8db27252ea6d599c07585e4be8fc647b10f68da1\n" }, { "commit": "12e51eaf5a32bb0329390184f848eeee1bf38394", "tree": "9569e9668a94ae0e4165a3a9d39a48df54fe24a6", "parents": [ "10672bdd905f3710d0b23e8e10d66c0c9b3b1abd" ], "author": { "name": "Dejie Zhang", "email": "djzhang@google.com", "time": "Fri Mar 28 21:11:51 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 28 21:34:20 2025" }, "message": "Change enum name to DESKTOP_STATUS_REPORT and DESKTOP_USAGE_LOGS.\n\nChange-Id: I424e4229dd862bbaeda6fba89730600b18a58558\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6404369\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Dejie Zhang \u003cdjzhang@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1439699}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1bdaa43d7d591c8349adbe4a8f402fdb018b0533\n" }, { "commit": "10672bdd905f3710d0b23e8e10d66c0c9b3b1abd", "tree": "963f2b423b325918722bc8869e85194d68538057", "parents": [ "64828b5b103d7617ddf88db88f5fe9db407a80c6" ], "author": { "name": "Dejie Zhang", "email": "djzhang@google.com", "time": "Thu Mar 27 19:08:11 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 28 21:33:50 2025" }, "message": "Add AL_STATUS_REPORT and AL_USAGE_LOGS destinations\n\nChange-Id: I7f5c415c0843d5d5bc2d1c8f111e0c7149d320c8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6402874\nCommit-Queue: Dejie Zhang \u003cdjzhang@google.com\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1438911}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e0e5c31906dc2ec8de4cf9aebab9f713b1834db0\n" }, { "commit": "64828b5b103d7617ddf88db88f5fe9db407a80c6", "tree": "0ed0bb3d8046504765ee1d06485f6cfc3fe4d1b4", "parents": [ "4e374639a1fb5ee39cfb8518c5cf7dee8a38fb29" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Feb 05 21:18:29 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 05 21:56:15 2025" }, "message": "Update base::FilePath::StringPieceType usage outside of //base\n\nReplace StringPieceType with StringViewType, since base::StringPiece has\nbeen replaced by std::string_view.\n\nChange-Id: I22826fb9df1a71d4ec1fadecaef969db52971d3b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6235785\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1416425}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a8d5beb257203758bb904316344d220f19a20266\n" }, { "commit": "4e374639a1fb5ee39cfb8518c5cf7dee8a38fb29", "tree": "e7e9c79da628e17428e01c73a6f166e4dec35f93", "parents": [ "842f8cb2079c01bcbc2f6ce884223b6238f0ad78" ], "author": { "name": "Shanthanu Bhardwaj", "email": "xanth@google.com", "time": "Tue Feb 04 14:34:00 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 04 15:09:24 2025" }, "message": "[Client-Side] Copy ChromeReportingEntity from google3\n\n- This CL adds the UploadEventsRequest \u0026 UploadEventsResponse proto messages to Chromium (along with standard google3-only protos that have been recreated here in gooogle3_protos.proto)\n- This is based on Google3 cl/721760597 which extracts the relevant protos into a single file and sets metadata se we can configure a copybara job to sync this file from the Google3 version.\n- When that is done, this file will have a header added that warns against modifying it in Chromium, since it will be automatically kept in sync by Copybara.\n\nBug: 378139107\nChange-Id: I6af7023fa549791812e8c64a0dfd5ca70edcbac2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221379\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nReviewed-by: Dominique Fauteux-Chapleau \u003cdomfc@chromium.org\u003e\nReviewed-by: Nancy Xiao \u003cnancylanxiao@google.com\u003e\nCommit-Queue: Shanthanu Bhardwaj \u003cxanth@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1415534}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ee0a35a73c0607b9f62cda036231f3eb28ae30da\n" }, { "commit": "842f8cb2079c01bcbc2f6ce884223b6238f0ad78", "tree": "a5b6107faa045ae86ba6f0b5d3f01681526f733a", "parents": [ "6eda5de4fd9624961996191232073798cc787f0e" ], "author": { "name": "Sergii Bykov", "email": "sbykov@google.com", "time": "Thu Jan 30 20:01:00 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 30 20:06:41 2025" }, "message": "kiosk: Add IWA type to FatalCrashTelemetry\n\nAdds a new enum value to FatalCrashTelemetry::SessionType. This will\nallow to monitor crashes for Isolated Web App Kiosk.\n\nBug: 358536558\nChange-Id: Icfd7ffe0cbb1f410dbae889fea892034215dd629\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216867\nCommit-Queue: Sergii Bykov \u003csbykov@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1413661}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 75232914f0abb8055071e881e2414157ff9fecd1\n" }, { "commit": "6eda5de4fd9624961996191232073798cc787f0e", "tree": "bfa3f8dad77a1f3b38eca18d047f5656744f66ba", "parents": [ "7ba06b0c67bbd03948604655c20053be548534ff" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jan 29 02:11:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 29 02:25:42 2025" }, "message": "Suppress unsafe_libc_call warning for initial identified files.\n\nSee docs/unsafe_buffers.md for details. Enforcement is not yet\nenabled, but this set of files are not in compliance with the\nnew warnings.\n\nBug: 390223051\nChange-Id: I4e24c2141b9399f572678302c833947494098b29\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187925\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1412673}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8726d30ed0372d085f5d9048ed5a4d62e13015ca\n" }, { "commit": "7ba06b0c67bbd03948604655c20053be548534ff", "tree": "6cc44012ef9bc0342a11ecb57656ace0f9ccb97f", "parents": [ "e8fe41938378abeefe7b2f3d854aa0c5175f2cf1" ], "author": { "name": "Zequan Wu", "email": "zequanwu@google.com", "time": "Tue Jan 28 04:34:41 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 28 05:11:15 2025" }, "message": "Fix -Wignored-qualifiers warnings\n\nIn recent change (https://github.com/llvm/llvm-project/commit/cac67d39362b23466708e464c00ce84abe16bece), clang was improved that it can detect no-effect const qualifiers on inheritance.\n\nBug: 392650300\nChange-Id: Iee0fce051c907a40ad7f6939e35792c596d2d9e4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6204067\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Zequan Wu \u003czequanwu@google.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1412087}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6dae6b11fdcee1eceda1dd43583fe00885d73816\n" }, { "commit": "e8fe41938378abeefe7b2f3d854aa0c5175f2cf1", "tree": "d880bbdcd89b748d82bb173380a1945624509dc7", "parents": [ "f759dbb324085d278ef39fd0e80d32a43a96d12d" ], "author": { "name": "Evan Stade", "email": "estade@google.com", "time": "Fri Jan 17 14:00:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 17 14:16:38 2025" }, "message": "Remove references to protobuf::down_cast in tests.\n\nThis utility no longer exists in protobuf, and also the usages of this\nutility don\u0027t seem to have been very related to protobuf to begin with.\nstatic_cast should suffice.\n\nBug: 328417294\nChange-Id: Ibc68441d888e6fee2b7ae699f65211d4586d17fc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181006\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Gavin Williams \u003cgavinwill@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1407862}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ea69366d36c5261b7ec06f6cec1455295371d2f7\n" }, { "commit": "f759dbb324085d278ef39fd0e80d32a43a96d12d", "tree": "089dd75d5496467b2d54974f82250148febaaa95", "parents": [ "b96a48ffe25cc23feff7e1bb457e341249ba8640" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@google.com", "time": "Wed Jan 15 02:00:17 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 15 02:07:15 2025" }, "message": "Refactor metric manager for testing\n\nBesides streamlining and unifying the tests, allow multiple mock queues\nfor the same categories of events and remove disabling the feature flag\nthat prevented more than 1 queue before this fix.\n\nNote, that as a result the metric queues in the tests can now be\nassessed only after MetricReportManager is created, so it is not possible to predicate on them in ON_CALL/EXPECT_CALL that create observers and collectors. But none of the tests apparently\ndepends on this.\n\nMultiple Dangling raw pointers have been eliminated.\n\nBug: 375383880\nChange-Id: Ia32d62b13254bf33cb0d723c68e30515df5da7a6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171317\nAuto-Submit: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1406467}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 01f9efaa4608f45e2e2d453b0ad1e07727948d76\n" }, { "commit": "b96a48ffe25cc23feff7e1bb457e341249ba8640", "tree": "abe3c71d0a40f42ca10824098f5ad1a379568275", "parents": [ "37e5aca412044072f2a32c00a4009102e10772ab" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Jan 09 10:49:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 09 10:55:56 2025" }, "message": "C++11 std::array rewrite for memory safety [18/19]\n\nSplit from:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nGenerated patch\n---------------\n- Tool: ./tool/clang/spanify/rewrite-multiple-platform.sh\n- Platform: Linux.\n- Filter: This includes 2400/4222 patches. I included the std::array\n ones and excluded build errors.\n\nGoogle announcement:\n--------------------\nhttps://groups.google.com/a/google.com/g/chrome-memory-safety/c/RMiO4gaVLQA/m/Yz-3NCObAgAJ\n\nBenchmarks:\n----------\nSee design doc and\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nDescription\n-----------\nThe consensus during the memory safety summit was to begin rewriting\nrelevant C-style arrays to C++11 std::array. It can be done immediately,\noffers better developer ergonomics, and fix large chunks of the\n-Wunsafe-buffer-usage errors in Chrome.\n\nTo clarify, this effort is complementary to the longer plan work with\nenabling -fsanitize\u003darray-bounds, and we plan to leverage both,\nespecially for protecting 3p code.\n\n[Attached] is a document detailing the rationale, benefits, and\nconsiderations for potential compile-time and performance impacts.\n\n[Attached]:https://docs.google.com/document/d/1z5aBDg26lHmNDjXRCysElWKx7E4PAJXqykI_k7ondJI/edit?tab\u003dt.0#heading\u003dh.cqgo7wvp0kzt\n\nNO_IFTTT\u003dNo need to update base/debug/stack_trace.h\n\nBug: 378069401\nChange-Id: I985601e93e79a72d984de78d23670ae214a7d630\nR: dcheng@chromium.org\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043827\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1404094}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6718b706ff100957d755554cec783840a8f1f05b\n" }, { "commit": "37e5aca412044072f2a32c00a4009102e10772ab", "tree": "44aa5ddee2d4fd6579fe7315d215a17e411bc6b5", "parents": [ "9ce63e4355665beb72547a8abde9b35d4441fc91" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Tue Dec 24 09:15:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 24 09:24:51 2024" }, "message": "components: Remove chromeos_buildflags build dependencies\n\nAfter [1], the only build target (under components/) that needs chromeos_buildflags is //components/crash/core/app. Remove the\ndependency from all others.\n\n[1]https://chromium-review.googlesource.com/c/chromium/src/+/6108703/\n\nBug: b:354842935\nChange-Id: I537ea10ab943374fe9793767a5461b71ecbcf52b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109205\nReviewed-by: Jun Ishiguro \u003cjunis@google.com\u003e\nOwners-Override: Georg Neis \u003cneis@chromium.org\u003e\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1400012}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c91f08f907d2d2ad324bdb2ae55f4c1aafa1997b\n" }, { "commit": "9ce63e4355665beb72547a8abde9b35d4441fc91", "tree": "799223454503ee1484119c686cc6b3edb2cf19a3", "parents": [ "ac333c7799e93e2091e6e8a93379d403ff5d8fe3" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Tue Dec 24 09:14:13 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 24 09:19:23 2024" }, "message": "components: Remove obsolete includes of chromeos_buildflags.h\n\nHaving removed IS_CHROMEOS_ASH and IS_CHROMEOS_LACROS uses, almost\nall includes of chromeos_buildflags.h have become obsolete.\n\nBug: b:354842935\nChange-Id: I1c3e33f12ea63f9444b841c465de5b37c4ae4b80\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108703\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Jun Ishiguro \u003cjunis@google.com\u003e\nOwners-Override: Georg Neis \u003cneis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1400011}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0f98ad7c50806baa2133f6c6e49eb03bc1534829\n" }, { "commit": "ac333c7799e93e2091e6e8a93379d403ff5d8fe3", "tree": "722186d579ace846015d328c49c3a15bd780fb6c", "parents": [ "507dadc52280e1482e1ce6fc1eb54eb74fbf83d5" ], "author": { "name": "Alexandra Reimers", "email": "areimers@chromium.org", "time": "Thu Dec 19 17:12:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 19 17:19:10 2024" }, "message": "Code Health: Clean up stale base::Feature \"CompressReportingPipeline\"\n\nThis feature is enabled by default for a long time. Let\u0027s clean up the flag and the unnecessary logic.\n\nBug: 356236871\nChange-Id: Id4ced2f2d76782f44c68f7c6a4431d8f4f4dc7b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111206\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Alexandra Reimers \u003careimers@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1398630}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4da89274bff9c4fc21f288e6b4e643964d521a7f\n" }, { "commit": "507dadc52280e1482e1ce6fc1eb54eb74fbf83d5", "tree": "44c6ea2bcb59f4d6429f9f5793a49c4f52a79cdb", "parents": [ "fc929462460ef702e74071880d372b8509ab41bb" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@google.com", "time": "Fri Dec 13 21:00:52 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 19 17:18:41 2024" }, "message": "Remove incorrect CHECK\n\nThis CHECK can fire in rare cases, since `BucketsShift` is called\nasynchronously, and so some trimming might have happened in between.\n\nThere is no risk in removing it, since ensuing code has its own guards\nagainst buckets set being empty.\n\nBug: b:383627059\nChange-Id: Idc51f4e550b5639cce9c722cd880f554b7713b6e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094374\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nAuto-Submit: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nReviewed-by: Josh Hilke \u003cjrhilke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1396160}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cb393cef92d371b2d9218307915c3ea9c5295d08\n" }, { "commit": "fc929462460ef702e74071880d372b8509ab41bb", "tree": "ccf56aec1ebe47ce6fa0c06f77b94952c453a934", "parents": [ "a7e7b8e72a5c1261796fc9bf67c0a6ffca00de52" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Dec 10 07:50:36 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 10 08:09:32 2024" }, "message": "C++11 std::array rewrite for memory safety [2/19]\n\nSplit from:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nGenerated patch\n---------------\n- Tool: ./tool/clang/spanify/rewrite-multiple-platform.sh\n- Platform: Linux.\n- Filter: This includes 2400/4222 patches. I included the std::array\n ones and excluded build errors.\n\nGoogle announcement:\n--------------------\nhttps://groups.google.com/a/google.com/g/chrome-memory-safety/c/RMiO4gaVLQA/m/Yz-3NCObAgAJ\n\nBenchmarks:\n----------\nSee design doc and\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nDescription\n-----------\nThe consensus during the memory safety summit was to begin rewriting\nrelevant C-style arrays to C++11 std::array. It can be done immediately,\noffers better developer ergonomics, and fix large chunks of the\n-Wunsafe-buffer-usage errors in Chrome.\n\nTo clarify, this effort is complementary to the longer plan work with\nenabling -fsanitize\u003darray-bounds, and we plan to leverage both,\nespecially for protecting 3p code.\n\n[Attached] is a document detailing the rationale, benefits, and\nconsiderations for potential compile-time and performance impacts.\n\n[Attached]:https://docs.google.com/document/d/1z5aBDg26lHmNDjXRCysElWKx7E4PAJXqykI_k7ondJI/edit?tab\u003dt.0#heading\u003dh.cqgo7wvp0kzt\n\nNO_IFTTT\u003dNo need to update base/debug/stack_trace.h\n\nBug: 378069401\nChange-Id: I3cc39267971c103c90cbf802762dc60ea544286e\nR: dcheng@chromium.org\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043958\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1394122}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cb0a1a5ce37f85dc0f1fa38e034e0f45def080e6\n" }, { "commit": "a7e7b8e72a5c1261796fc9bf67c0a6ffca00de52", "tree": "7ad2a30c0e40fbf88104b22b839d750f6b84150c", "parents": [ "4d0e87f620c10ed1a74628f2f1aca2105783a4b5" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Dec 02 17:12:59 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 02 18:05:02 2024" }, "message": "Remove usage of base::make_span(): components/, part 2\n\nReplace with span() CTAD use, or more targeted helpers.\n\nBug: 341907909\nChange-Id: If17945eb0811b5d171c1fd443b567b0990a9587f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6061144\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: Cait Phillips \u003ccaitkp@google.com\u003e\nReviewed-by: Cait Phillips \u003ccaitkp@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1390403}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d82594fc3a3dd3fbc55afcf927c05c52f797f757\n" }, { "commit": "4d0e87f620c10ed1a74628f2f1aca2105783a4b5", "tree": "28dcdbab0d5acdb8722dcc4435c1a6e3448a87f5", "parents": [ "bc9d2a7613f289d92460bf251b85100e5c9a4db4" ], "author": { "name": "Leonid Baraz", "email": "lbaraz@chromium.org", "time": "Mon Nov 18 23:04:42 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 18 23:36:33 2024" }, "message": "Introduce dBus jobs limit\n\nModify DisconnectableClient (used by EnqueueEvent) to allow no more than\n10 jobs in parallel (by default). Any job beyond that would wait and run\nonce the total count drops below 10.\n\nBug: b:377934648\nChange-Id: Ie977d46d4162bb26d2ada1bbf7ccd26003be3157\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032071\nReviewed-by: Josh Hilke \u003cjrhilke@google.com\u003e\nCommit-Queue: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1384623}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 27df47c7ab095f2d51b673bb99f1983f5eb52a8f\n" }, { "commit": "bc9d2a7613f289d92460bf251b85100e5c9a4db4", "tree": "9376c0169002e4a69d650c34c6339bab0c7bcb8d", "parents": [ "6357076a9c32a7f0c5b5e81992b24a7cee997c76" ], "author": { "name": "Josh Hilke", "email": "jrhilke@google.com", "time": "Mon Nov 18 23:03:42 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 18 23:36:12 2024" }, "message": "Use int64 instead of uint32 SessionUnaffiliatedUser.\n\nThis proto is synced to the server which runs Java and Java does not\nhave unsigned integers.\n\nChange-Id: I1c5c5c7edfc752230fdefa130f394027cc7ddf28\nBug: b:356237033\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033569\nReviewed-by: Alberto Juarez \u003calbertojuarez@google.com\u003e\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1384622}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 952f95337169614844815a2dcac7e46ba65b645a\n" }, { "commit": "6357076a9c32a7f0c5b5e81992b24a7cee997c76", "tree": "d3cea35b19e388f3f82fa3a4eebb053affbcdcd4", "parents": [ "e9de50840a2300be5d4bc5a9cd687d8b90cceccf" ], "author": { "name": "Shanthanu Bhardwaj", "email": "xanth@google.com", "time": "Mon Nov 18 21:51:44 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 18 21:57:44 2024" }, "message": "Replace ${COPYBARA_DATAPOL_ST_*} with copybara:datapol_begin and copybara:datapol_end.\n\n- This way to annotate proto fields for datapol is more capable of handling deprecation and other field options.\n- The deprecation of `SessionUnaffiliatedUser.user_id` in crrev.com/c/6024349 broke the datapol annotation\n\nChange-Id: I894cb95d1451960f3c8f8c70dbc2b4a8f9d1a702\nBug: 378488231\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6027451\nReviewed-by: Josh Hilke \u003cjrhilke@google.com\u003e\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nAuto-Submit: Shanthanu Bhardwaj \u003cxanth@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1384579}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a8d0c67b20418a4adf8b4b4a4096497b1dcfad02\n" }, { "commit": "e9de50840a2300be5d4bc5a9cd687d8b90cceccf", "tree": "c381be83d02324a2f09d8cce45364fd1b444c91e", "parents": [ "dd15b605d5b95395530c6648a8041f599281cbed" ], "author": { "name": "Josh Hilke", "email": "jrhilke@google.com", "time": "Fri Nov 15 18:47:09 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 18 21:57:24 2024" }, "message": "Use number instead of string for unaffiliated user ID.\n\nThe original implementation filled the proto string using a\ncryptographic hash which generated a non-readable byte string. We can\u0027t\ndisplay this in the admin UI. Additionally a number is shorter and\neasier to read. We are using a uint32 which should be more than enough\nnumbers to cover the number of unique unaffiliated users that will use a\ngiven device during its lifetime.\n\nChange-Id: I30b0a99d4a6da4d823c96e50c79e8ca6997e40b6\nBug: b:356237033\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024349\nReviewed-by: Alberto Juarez \u003calbertojuarez@google.com\u003e\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1383724}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f18c82f208fdfca2b494b48e6592b664fe866f7e\n" }, { "commit": "dd15b605d5b95395530c6648a8041f599281cbed", "tree": "8dba8e9a26d2ca3db9247e06807f1982325e76d5", "parents": [ "9924b8e2b3acae0bbcc036367b4b0c932699506a" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Wed Nov 13 22:26:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 14 22:09:50 2024" }, "message": "Migrate remaining NOTREACHED()s in components/\n\nNOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.\nThe former is [[noreturn]] so this CL also performs dead-code removal\nafter the NOTREACHED().\n\nThis CL does not attempt to do additional rewrites of any surrounding\ncode, like:\n\nif (!foo) {\n NOTREACHED();\n}\n\nto CHECK(foo);\n\nThose transforms take a non-trivial amount of time (and there are\nthousands of instances). Cleanup can be left as an exercise for the\nreader.\n\nBug: 40580068\nChange-Id: I72205fb77747957c6bf33dbea93656fd20085a42\nLow-Coverage-Reason: OTHER Should-be-unreachable code\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6010008\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nOwners-Override: Rick Byers \u003crbyers@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1382618}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 77d2135a331b8cf68960469a20e58117c82d395b\n" }, { "commit": "9924b8e2b3acae0bbcc036367b4b0c932699506a", "tree": "089ef6b80db47dc591bba9dcd05d88d6b3ed88f5", "parents": [ "3f94040f1476f2bf8769e141ae646f8a190413ae" ], "author": { "name": "Josh Hilke", "email": "jrhilke@google.com", "time": "Wed Nov 13 21:52:44 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 13 21:58:46 2024" }, "message": "Remove extraneous newlines.\n\nChange-Id: I0791b1e23394b7c851a45f263feb5116a680a391\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6018824\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nReviewed-by: Vignesh Shenvi \u003cvshenvi@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1382600}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ff74053c4b0781c325769620786779e6936ac319\n" }, { "commit": "3f94040f1476f2bf8769e141ae646f8a190413ae", "tree": "9a50acb7a5de045a57d9049f4807b9af19591288", "parents": [ "5fbf06694ef01c052a063397d6d416547f502126" ], "author": { "name": "Josh Hilke", "email": "jrhilke@google.com", "time": "Fri Nov 08 11:41:53 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 08 11:47:58 2024" }, "message": "Reland \"Create user session activity reporter.\"\n\nThis is a reland of commit 8b891caca5cd34b4e39981de8098654fbe5f39a1\n\nFixed build error by updating deps in\nchrome/browser/ash/policy/core/BUILD.gn\n\nOriginal change\u0027s description:\n\u003e Create user session activity reporter.\n\u003e\n\u003e This class and its delegate observes and reports active/idle states within a user session using the encrypted reporting pipeline and an idle event notifier. This change is guarded by the EnableUserSessionActivityReporting feature which is disabled by default.\n\u003e\n\u003e Browser test will be added in a following change.\n\u003e\n\u003e BYPASS_LARGE_CHANGE_WARNING\u003dThe majority of added code is guarded by a feature flag which is disabled by default.\n\u003e\n\u003e Change-Id: Ib68b883c9107f94bb2692d4d2cb8520ed6876f66\n\u003e Bug: b:372757109\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924246\n\u003e Reviewed-by: Sergey Poromov \u003cporomov@chromium.org\u003e\n\u003e Reviewed-by: Xinglong (Alan) Luan \u003calanlxl@chromium.org\u003e\n\u003e Commit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\n\u003e Reviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1378766}\n\nBug: b:372757109\nChange-Id: I7013db3683fefdcdb1063a979b6378a7e7764640\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002488\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Sergey Poromov \u003cporomov@chromium.org\u003e\nReviewed-by: Xinglong (Alan) Luan \u003calanlxl@chromium.org\u003e\nReviewed-by: Sergey Poromov \u003cporomov@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1380281}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ec980b0fdc9310c0daaaf3bc06df07465417abd\n" }, { "commit": "5fbf06694ef01c052a063397d6d416547f502126", "tree": "a547b1d7b5d9f198b4de13182737611c05dcc7d7", "parents": [ "43fa0a2ef2ee1c0bcd44825a611ff2a06775c8e6" ], "author": { "name": "Timothy Loh", "email": "timloh@chromium.org", "time": "Thu Nov 07 11:35:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 07 11:41:04 2024" }, "message": "Revert \"Create user session activity reporter.\"\n\nThis reverts commit 8b891caca5cd34b4e39981de8098654fbe5f39a1.\n\nReason for revert: Compile fails when built as chromeos-chrome, blocking uprev\n\nhttps://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6002511\n\nOriginal change\u0027s description:\n\u003e Create user session activity reporter.\n\u003e\n\u003e This class and its delegate observes and reports active/idle states within a user session using the encrypted reporting pipeline and an idle event notifier. This change is guarded by the EnableUserSessionActivityReporting feature which is disabled by default.\n\u003e\n\u003e Browser test will be added in a following change.\n\u003e\n\u003e BYPASS_LARGE_CHANGE_WARNING\u003dThe majority of added code is guarded by a feature flag which is disabled by default.\n\u003e\n\u003e Change-Id: Ib68b883c9107f94bb2692d4d2cb8520ed6876f66\n\u003e Bug: b:372757109\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924246\n\u003e Reviewed-by: Sergey Poromov \u003cporomov@chromium.org\u003e\n\u003e Reviewed-by: Xinglong (Alan) Luan \u003calanlxl@chromium.org\u003e\n\u003e Commit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\n\u003e Reviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1378766}\n\nBug: b:372757109\nChange-Id: Iff0e6e0f894b6923cea13f0aea78db3112230f2a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998796\nCommit-Queue: Timothy Loh \u003ctimloh@chromium.org\u003e\nOwners-Override: Timothy Loh \u003ctimloh@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1379598}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0225c3b282489bae66c0c895e5e4545281a30014\n" }, { "commit": "43fa0a2ef2ee1c0bcd44825a611ff2a06775c8e6", "tree": "9a50acb7a5de045a57d9049f4807b9af19591288", "parents": [ "8188a3db8f079ac8c463b9a791433b26efa9a759" ], "author": { "name": "Josh Hilke", "email": "jrhilke@google.com", "time": "Wed Nov 06 05:17:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 06 06:01:04 2024" }, "message": "Create user session activity reporter.\n\nThis class and its delegate observes and reports active/idle states within a user session using the encrypted reporting pipeline and an idle event notifier. This change is guarded by the EnableUserSessionActivityReporting feature which is disabled by default.\n\nBrowser test will be added in a following change.\n\nBYPASS_LARGE_CHANGE_WARNING\u003dThe majority of added code is guarded by a feature flag which is disabled by default.\n\nChange-Id: Ib68b883c9107f94bb2692d4d2cb8520ed6876f66\nBug: b:372757109\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924246\nReviewed-by: Sergey Poromov \u003cporomov@chromium.org\u003e\nReviewed-by: Xinglong (Alan) Luan \u003calanlxl@chromium.org\u003e\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1378766}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8b891caca5cd34b4e39981de8098654fbe5f39a1\n" }, { "commit": "8188a3db8f079ac8c463b9a791433b26efa9a759", "tree": "a547b1d7b5d9f198b4de13182737611c05dcc7d7", "parents": [ "5b647e1fe53bfb1f3c25efdaa1dc86e9340ebb27" ], "author": { "name": "Josh Hilke", "email": "jrhilke@google.com", "time": "Tue Nov 05 00:58:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 06 06:00:35 2024" }, "message": "Add datapol annotations to protos.\n\nThese annotations are required by google3.\n\nChange-Id: I8389c86b8fe3ce5c26c6526cff927f4bdb3fdf4f\nBug: b/369912274\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991570\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nCommit-Queue: Josh Hilke \u003cjrhilke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1378037}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9fca173377b3d6ef6eb64eec6e3800749fa0aad0\n" } ], "next": "5b647e1fe53bfb1f3c25efdaa1dc86e9340ebb27" }