Convert to UNSAFE_TODO in components [1/4]
This is an automated #cleanup patch using the [Script] below.
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
[email protected]
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: I1ea9d4a1c176aa262b4beeb58fc63280b00e0baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228422
Auto-Submit: Arthur Sonzogni <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1554008}
NOKEYCHECK=True
GitOrigin-RevId: a1ee611b3f7e0b9517c064113a3dc282a996e3c4
diff --git a/call_stacks/stack_sampling_recorder_unittest.cc b/call_stacks/stack_sampling_recorder_unittest.cc
index 17c040c..e9bbb54 100644
--- a/call_stacks/stack_sampling_recorder_unittest.cc
+++ b/call_stacks/stack_sampling_recorder_unittest.cc
@@ -2,11 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
-#pragma allow_unsafe_buffers
-#endif
-
#include "components/metrics/call_stacks/stack_sampling_recorder.h"
#include <sys/file.h>
@@ -15,6 +10,7 @@
#include <utility>
#include "base/check.h"
+#include "base/compiler_specific.h"
#include "base/containers/span.h"
#include "base/files/file.h"
#include "base/files/file_util.h"
@@ -258,7 +254,7 @@
base::File::FLAG_WRITE);
CHECK(file.IsValid());
constexpr char kPattern[] = "Not a valid proto";
- CHECK_EQ(file.Write(0, kPattern, sizeof(kPattern)),
+ CHECK_EQ(UNSAFE_TODO(file.Write(0, kPattern, sizeof(kPattern))),
static_cast<int>(sizeof(kPattern)));
// 2. Lock the file
@@ -279,8 +275,8 @@
// 5. CHECK that the file still contains the original pattern.
char buffer[sizeof(kPattern) + 1];
- CHECK_EQ(file.Read(0, buffer, sizeof(buffer)),
- static_cast<int>(sizeof(kPattern)));
+ UNSAFE_TODO(CHECK_EQ(file.Read(0, buffer, sizeof(buffer)),
+ static_cast<int>(sizeof(kPattern))));
CHECK_EQ(std::string(buffer), std::string(kPattern));
}
