Remove TODO to remove StoreLog()
UnsentLogStore::StoreLog() is a thin wrapper over
UnsentLogstore::StoreLogInfo() but I do think it is useful in reducing
boilerplate code. In particular, it has direct access to the signing
key, and removes the need to redundantly pass the uncompressed size.
I.e., if we removed StoreLog(), we'd need to replace callers from:
log_store->StoreLog(log_data, log_metadata, reason);
To:
log_store->StoreLogInfo(
std::make_unique<LogInfo>(
log_data,
log_store->signing_key(),
log_metadata
),
log_data.size(),
reason
);
Which is a bit verbose.
Note: MetricLogStore is just a delegator over multiple (2-3)
`UnsentLogStore`s
Bug: 40119012
Change-Id: I502043365b9898c7e1396ab2189595f9ffd66559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228071
Auto-Submit: Luc Nguyen <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1554688}
NOKEYCHECK=True
GitOrigin-RevId: 0d9e5947ca4067cae5b2a7a68d1907bd8bd10317
2 files changed
