)]}' { "log": [ { "commit": "3977deb31296f86a6f79011aa7989349ea031383", "tree": "1239210821980b894da3557ac67431c5571575f1", "parents": [ "f72a6f34cb0ad624b7dea97966a2bb9eb147c1c7" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Fri Feb 20 10:07:34 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 20 10:13:37 2026" }, "message": "Spanify `RedactionTool` (2/2)\n\nConvert `kBuiltInFirstPartyExtensionIds` to an array of\n`std::string_view` and tweak functions as necessary.\n\nChange the business logic to not expect a `nullptr` sentinel.\n\nFixed: 439455382\nChange-Id: Ia79513fee6503c41b91726f2391f2d18c0a5267d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7544239\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Kalvin Lee \u003ckdlee@chromium.org\u003e\nCommit-Queue: Kalvin Lee \u003ckdlee@chromium.org\u003e\nReviewed-by: Devlin Cronin \u003crdevlin.cronin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1587695}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: edc4b56703ff9cb7bf14c95d72aa3b8efb98c305\n" }, { "commit": "f72a6f34cb0ad624b7dea97966a2bb9eb147c1c7", "tree": "658a5ad489e9e3d3e5b70ffe3029e8d383f3dc7c", "parents": [ "a9b77012272d7c32c649f2717221d50e62ec1bb1" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Thu Feb 12 06:30:17 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 12 06:35:20 2026" }, "message": "Spanify `RedactionTool` (1/2)\n\nStep 1 is being split into a swarm of CLs. This one creates spanified\nconstructors. This will be followed by a split of\nhttps://crrev.com/c/7554150. Once those land, we will try to erase this\nshort-lived constructors schism. This way, if I miss something again,\nwe don\u0027t get a big revert of the whole migration.\n\nBug: 439455382\nChange-Id: I4128d917a686276ac853ff22f0185b3260881719\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7556932\nCommit-Queue: Kalvin Lee \u003ckdlee@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1583756}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6ff32df293624ba185f3b2c9a6d933e46131b6ee\n" }, { "commit": "a9b77012272d7c32c649f2717221d50e62ec1bb1", "tree": "78852203599d9bcc5db39f848d7958843dff4f72", "parents": [ "ef1e45fa5232e1aad42044d41b0d49bd20015e87" ], "author": { "name": "luci-bisection@appspot.gserviceaccount.com", "email": "luci-bisection@appspot.gserviceaccount.com", "time": "Sat Feb 07 06:49:26 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 07 06:56:49 2026" }, "message": "Revert \"Spanify `RedactionTool` (1/2)\"\n\nThis reverts commit b71bf2a194a1d2fd6a25ffb8a0c9546ba2557116.\n\nReason for revert:\nLUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8690546660686992961\n\nSample failed build: https://ci.chromium.org/b/8690546660686992961\n\nIf this is a false positive, please report it at http://b.corp.google.com/createIssue?component\u003d1199205\u0026description\u003dAnalysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7544238\u0026format\u003dPLAIN\u0026priority\u003dP3\u0026title\u003dWrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8690546660686992961\u0026type\u003dBUG\n\nOriginal change\u0027s description:\n\u003e Spanify `RedactionTool` (1/2)\n\u003e\n\u003e Broadly,\n\u003e\n\u003e 1. Convert `kBuiltInFirstPartyExtensionIds` to a `std::array` and\n\u003e inline it directly in the associated header. This exposes its size\n\u003e everywhere and makes it compatible with `base::span`.\n\u003e\n\u003e 2. Move away from trafficking `const char* const*`. Use `base::span`\n\u003e where possible, and default it to the empty span where `nullptr`\n\u003e would be passed.\n\u003e\n\u003e Bug: 439455382\n\u003e Change-Id: If3dbbdc088ece9e760ce359c8c63caab2accb8b9\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7544238\n\u003e Reviewed-by: Vasilii Sukhanov \u003cvasilii@chromium.org\u003e\n\u003e Reviewed-by: Emilia Paz \u003cemiliapaz@chromium.org\u003e\n\u003e Reviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\n\u003e Commit-Queue: Kalvin Lee \u003ckdlee@chromium.org\u003e\n\u003e Reviewed-by: Michelle Chen \u003cmichellegc@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1581291}\n\u003e\n\nBug: 439455382\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I2905577cdea819d2a7e9f60ee6f62da478c8bf6e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7553710\nCommit-Queue: luci-bisection@appspot.gserviceaccount.com \u003cluci-bisection@appspot.gserviceaccount.com\u003e\nOwners-Override: luci-bisection@appspot.gserviceaccount.com \u003cluci-bisection@appspot.gserviceaccount.com\u003e\nBot-Commit: luci-bisection@appspot.gserviceaccount.com \u003cluci-bisection@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1581294}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6e9ced761eaf7993719c7fd6e74218d54e4d3cdb\n" }, { "commit": "ef1e45fa5232e1aad42044d41b0d49bd20015e87", "tree": "6c1b61027b02ce25c75c5aaca5458711fa1a281d", "parents": [ "17c654f5118f301af91684f4243267ad4ee7251e" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Sat Feb 07 06:07:24 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 07 06:12:56 2026" }, "message": "Spanify `RedactionTool` (1/2)\n\nBroadly,\n\n1. Convert `kBuiltInFirstPartyExtensionIds` to a `std::array` and\n inline it directly in the associated header. This exposes its size\n everywhere and makes it compatible with `base::span`.\n\n2. Move away from trafficking `const char* const*`. Use `base::span`\n where possible, and default it to the empty span where `nullptr`\n would be passed.\n\nBug: 439455382\nChange-Id: If3dbbdc088ece9e760ce359c8c63caab2accb8b9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7544238\nReviewed-by: Vasilii Sukhanov \u003cvasilii@chromium.org\u003e\nReviewed-by: Emilia Paz \u003cemiliapaz@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Kalvin Lee \u003ckdlee@chromium.org\u003e\nReviewed-by: Michelle Chen \u003cmichellegc@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1581291}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b71bf2a194a1d2fd6a25ffb8a0c9546ba2557116\n" }, { "commit": "17c654f5118f301af91684f4243267ad4ee7251e", "tree": "78852203599d9bcc5db39f848d7958843dff4f72", "parents": [ "58ecd56d80046c9b4e3faf42ea13ee27fcd09f1f" ], "author": { "name": "Sergio Solano", "email": "sergiosolano@google.com", "time": "Fri Dec 19 18:06:45 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 19 18:13:24 2025" }, "message": "spanification: spanified and manually checked url_canon_ip.cc\n\nThis change modernized the code and improves type safety by using\nstd::string_views and base::span. UNSAFE macros are removed.\n\nThis is the result of running the automatic spanification on linux and\nupdating code to use and pass spans where size is known.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms\u003dlinux\nThen refined with gemini-cli\n\ngemini-run/batch-run-1761798078/group_99\n\nBUG\u003d439964610\n\nChange-Id: Idfe7e667ffa1d69abf1c034ceb087a7d879bbff2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204761\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Sergio Solano \u003csergiosolano@google.com\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Stephen Nusko \u003cnuskos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1561226}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f09a6ea0003d91d4276dd57e109afe1dda68f1eb\n" }, { "commit": "58ecd56d80046c9b4e3faf42ea13ee27fcd09f1f", "tree": "c1d2837f78cc81c8da8c410b038e530dfd9d0648", "parents": [ "88f45ef39955f06c9c47f256942fe4b405261ca8" ], "author": { "name": "Nan Lin", "email": "linnan@chromium.org", "time": "Wed Dec 17 18:37:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 17 18:55:06 2025" }, "message": "[Code Health] Clean up stale base::Feature EnableIbanRedaction\n\nFixed: 356236321\nChange-Id: I78332d626e84f32af965246c1997c77dbefb2e3c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7266799\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1560044}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2cddfe033c2e25f86823ed6543bcc2390bc142da\n" }, { "commit": "88f45ef39955f06c9c47f256942fe4b405261ca8", "tree": "1d4a0aaafebe9402580e6f2de275ebb7fea32bff", "parents": [ "d6ee12f96e54e64fb581c3c42c722a1dbbc89b47" ], "author": { "name": "Nan Lin", "email": "linnan@chromium.org", "time": "Wed Dec 17 12:21:53 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 17 12:41:15 2025" }, "message": "[Code Health] Remove base::Feature::EnableCreditCardRedaction\n\nFixed: 356236577\nChange-Id: I2fcbd56b5faa64868e6101f14bf20ad93793255c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262283\nCommit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1559876}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ec00edfb9c80a52b81a82e1ca3330b9f27c3b497\n" }, { "commit": "d6ee12f96e54e64fb581c3c42c722a1dbbc89b47", "tree": "deb27fa9a55c10552a751433405606bce6e99a3d", "parents": [ "aa37380f70a01e166773a34d873fed36f286516a" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Dec 04 15:39:39 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 04 15:44:53 2025" }, "message": "Convert to UNSAFE_TODO in components [1/4]\n\nThis is an automated #cleanup patch using the [Script] below.\n\nWe are migrating from coarse-grained file-level suppression (#pragma\nallow_unsafe_buffers) to granular, expression-level markers\n(UNSAFE_TODO()). The pragma disables safety checks for an entire file,\nwhereas UNSAFE_TODO() isolates specific potentially unsafe operations,\nallowing the rest of the file to be enforced as safe.\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nR\u003dblundell@chromium.org\n\nScript: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp\u003dsharing\nAX-Relnotes: N/A\nCleanup: This is an automated #cleanup.\nBug: 409340989\nChange-Id: I1ea9d4a1c176aa262b4beeb58fc63280b00e0baf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228422\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1554008}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a1ee611b3f7e0b9517c064113a3dc282a996e3c4\n" }, { "commit": "aa37380f70a01e166773a34d873fed36f286516a", "tree": "740172cc5eef204edcea77426ba3194afdb29a3e", "parents": [ "bc95c95b58a8e02bda05fa25e8b3e62838b8a060" ], "author": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Mon Dec 01 19:12:21 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 01 19:32:55 2025" }, "message": "spanification: Clean up unneeded parameters in components\n\nThis was the result of asking gemini to remove all of the redundant\nvariables and update call sites. I have also gone ahead and updated all\nthe for loops that the linter complained were not modern c++ (to range\nfor loops).\n\nThe aim of this patch should be no behaviour changes, however well I\u0027ve\nmanually reviewed it, since this patch was generated by AI please review\ncarefully.\n\nThese checks have been in the code for 2 stable releases, and M143 is\nabout to go to Stable, which means this has been fully fatal in\nCanary/Dev. All of these should be completely redundant.\n\nThis patch was split with `git cl split --target-range 8 32\n--max-depth\u003d2 --no-reviewers -d ~/description.txt`\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/u/1/d/1poEhNARfFas2osqPoXGzVZtBgnOQGQtQNUFTA-MlADs/edit?tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 431824301\nChange-Id: I98d8a92bde8812a7272b452977f47e92925a1bb5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201723\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Ryan Hamilton \u003crch@chromium.org\u003e\nCommit-Queue: Orin Jaworski \u003corinj@chromium.org\u003e\nReviewed-by: Orin Jaworski \u003corinj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1552287}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: aa88a22a5ecb133ca7a51298e13b801fa05c074a\n" }, { "commit": "bc95c95b58a8e02bda05fa25e8b3e62838b8a060", "tree": "05b2a901ad8e038d79ca368ad42bcb49b5720447", "parents": [ "7023e065214f0980ca173b65721938208a1dc69d" ], "author": { "name": "Xiaohan Wang", "email": "xhwang@chromium.org", "time": "Tue Sep 16 05:15:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 16 05:22:15 2025" }, "message": "components: Migrate BASE_FEATURE macros to 2-argument version\n\nThis CL migrates three-argument BASE_FEATURE macros in //components to\nthe new two-argument version where the C++ identifier and the string\nfeature name match.\n\nThis automated refactoring helps ensure that the C++ identifier and the\nstring feature name always match, reducing potential errors.\n\nThe following features could not be migrated automatically and may\nrequire manual intervention:\n\n * kDownloadServiceFeature vs \"DownloadService\"\n * Identifier has Feature suffix.\n\n * kDisplayInitiatorOrigin vs \"DownloadsDisplayInitiatorOrigin\"\n * Name has Downloads prefix.\n\n * kInvalidateTokenFeature vs \"GCMTokenInvalidAfterDays\"\n * Identifier has Feature suffix.\n\n * kReportingStorageDegradationFeature vs \"ReportingStorageDegradation\"\n * Identifier has Feature suffix.\n\n * kEncryptedReportingFeature vs \"EncryptedReporting\"\n * Identifier has Feature suffix.\n\n * kEnableCompose vs \"Compose\"\n * Identifier has Enable prefix.\n\n * kEnableComposeSavedStateNudge vs \"ComposeNudge\"\n * Identifier has Enable prefix and different name.\n\n * kEnableComposeProactiveNudge vs \"ComposeProactiveNudge\"\n * Identifier has Enable prefix.\n\n * kEnableComposeLanguageBypassForContextMenu vs \"ComposeLanguageBypassForContextMenu\"\n * Identifier has Enable prefix.\n\n * kEnableComposeWebUIAnimations vs \"ComposeWebUIAnimations\"\n * Identifier has Enable prefix.\n\n * kEnableNudgeForUnspecifiedHint vs \"ComposeEnableNudgeForUnspecifiedHint\"\n * Identifier has different name.\n\n * kPasswordsGrouperHeapIntegrityKillSwitch vs \"PasswordsGrouperHeapIntegrityKillSwitchv2\"\n * Name has v2 suffix.\n\n * kClearUndecryptablePasswordsOnSync vs \"ClearUndecryptablePasswordsInSync\"\n * on vs in.\n\n * kFillOnAccountSelect vs \"fill-on-account-select\"\n * Case and kebab-case mismatch.\n\n * kIOSProactivePasswordGenerationBottomSheet vs \"kIOSProactivePasswordGenerationBottomSheet\"\n * Name has k prefix.\n\n * kPasswordGenerationChunking vs \"PasswordGenerationChunkPassword\"\n * Chunking vs ChunkPassword.\n\n * kDelaySuggestionsOnAutofocusWaitingForPasskeys vs \"DelaysSuggestionsOnAutofocusWaitingForPasskeys\"\n * Delay vs Delays.\n\n * kAdSamplerTriggerFeature vs \"SafeBrowsingAdSamplerTrigger\"\n * Identifier has Feature suffix and name has SafeBrowsing prefix.\n\n * kDelayedWarnings vs \"SafeBrowsingDelayedWarnings\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetryConfiguration vs \"SafeBrowsingExtensionTelemetryConfiguration\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetryDeclarativeNetRequestActionSignal vs \"SafeBrowsingExtensionTelemetryDeclarativeNetRequestActionSignal\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetryFileDataForCommandLineExtensions vs \"SafeBrowsingExtensionTelemetryFileDataForCommandLineExtensions\"\n * Name has SafeBrowsing prefix.\n\n * kExtensionTelemetrySearchHijackingSignal vs \"SafeBrowsingExtensionTelemetrySearchHijackingSignal\"\n * Name has SafeBrowsing prefix.\n\n * kExternalAppRedirectTelemetry vs \"SafeBrowsingExternalAppRedirectTelemetry\"\n * Name has SafeBrowsing prefix.\n\n * kGooglePlayProtectInApkTelemetry vs \"SafeBrowsingGooglePlayProtectInApkTelemetry\"\n * Name has SafeBrowsing prefix.\n\n * kGooglePlayProtectReducesWarnings vs \"SafeBrowsingGooglePlayProtectReducesWarnings\"\n * Name has SafeBrowsing prefix.\n\n * kHashPrefixRealTimeLookups vs \"SafeBrowsingHashPrefixRealTimeLookups\"\n * Name has SafeBrowsing prefix.\n\n * kHashPrefixRealTimeLookupsSamplePing vs \"SafeBrowsingHashPrefixRealTimeLookupsSamplePing\"\n * Name has SafeBrowsing prefix.\n\n * kLocalListsUseSBv5 vs \"SafeBrowsingLocalListsUseSBv5\"\n * Name has SafeBrowsing prefix.\n\n * kSuspiciousSiteTriggerQuotaFeature vs \"SafeBrowsingSuspiciousSiteTriggerQuota\"\n * Identifier has Feature suffix and name has SafeBrowsing prefix.\n\n * kThreatDomDetailsTagAndAttributeFeature vs \"ThreatDomDetailsTagAttributes\"\n * Identifier has Feature suffix and name has different name.\n\n * kConfirmSuggestionRemovals vs \"ConfirmNtpSuggestionRemovals\"\n * Name has Ntp prefix.\n\n * kRealboxCr23Theming vs \"NtpRealboxCr23Theming\"\n * Name has Ntp prefix.\n\n * kRealboxMatchSearchboxTheme vs \"NtpRealboxMatchSearchboxTheme\"\n * Name has Ntp prefix.\n\n * kRealboxUseGoogleGIcon vs \"NtpRealboxUseGoogleGIcon\"\n * Name has Ntp prefix.\n\n * kNtpTabGroupsModule vs \"kNtpTabGroupsModule\"\n * Name has k prefix.\n\n * kNtpTabGroupsModuleZeroState vs \"kNtpTabGroupsModuleZeroState\"\n * Name has k prefix.\n\n * kAndroidMediaPickerAdoption vs \"MediaPickerAdoption\"\n * Identifier has Android prefix.\n\n * kLocalWebApprovalsWidgetSupportsUrlPayload vs \"PacpWidgetSupportsUrlPayload\"\n * Identifier has different name.\n\n * kOmniboxAction vs \"JourneysOmniboxAction\"\n * Name has Journeys prefix.\n\n * kOmniboxHistoryClusterProvider vs \"JourneysOmniboxHistoryClusterProvider\"\n * Name has Journeys prefix.\n\n * kNonUserVisibleDebug vs \"JourneysNonUserVisibleDebug\"\n * Name has Journeys prefix.\n\n * kUserVisibleDebug vs \"JourneysUserVisibleDebug\"\n * Name has Journeys prefix.\n\n * kSearchesFindUngroupedVisits vs \"GroupedHistorySearchesFindUngroupedVisits\"\n * Name has GroupedHistory prefix.\n\n * kOnDeviceClustering vs \"HistoryClustersOnDeviceClustering\"\n * Name has HistoryClusters prefix.\n\n * kOnDeviceClusteringBlocklists vs \"JourneysOnDeviceClusteringBlocklist\"\n * Name has Journeys prefix and Blocklists vs Blocklist.\n\n * kOnDeviceClusteringKeywordFiltering vs \"JourneysKeywordFiltering\"\n * Name has Journeys prefix.\n\n * kOnDeviceClusteringVisitRanking vs \"JourneysOnDeviceClusteringVisitRanking\"\n * Name has Journeys prefix.\n\n * kSyntheticCapabilities vs \"FeedSyntheticCapabilities\"\n * Name has Feed prefix.\n\n * kGroupingFrameworkForNonZPS vs \"OmniboxGroupingFrameworkForNonZPS\"\n * Name has Omnibox prefix.\n\n * kMaxZeroSuggestMatches vs \"OmniboxMaxZeroSuggestMatches\"\n * Name has Omnibox prefix.\n\n * kUIExperimentMaxAutocompleteMatches vs \"OmniboxUIExperimentMaxAutocompleteMatches\"\n * Name has Omnibox prefix.\n\n * kDynamicMaxAutocomplete vs \"OmniboxDynamicMaxAutocomplete\"\n * Name has Omnibox prefix.\n\n * kFocusTriggersWebAndSRPZeroSuggest vs \"OmniboxFocusTriggersWebAndSRPZeroSuggest\"\n * Name has Omnibox prefix.\n\n * kHideSuggestionGroupHeaders vs \"OmniboxHideSuggestionGroupHeaders\"\n * Name has Omnibox prefix.\n\n * kOnDeviceHeadProviderIncognito vs \"OmniboxOnDeviceHeadProviderIncognito\"\n * Name has Omnibox prefix.\n\n * kOnDeviceHeadProviderNonIncognito vs \"OmniboxOnDeviceHeadProviderNonIncognito\"\n * Name has Omnibox prefix.\n\n * kOnDeviceTailModel vs \"OmniboxOnDeviceTailModel\"\n * Name has Omnibox prefix.\n\n * kOnDeviceTailEnableEnglishModel vs \"OmniboxOnDeviceTailEnableEnglishModel\"\n * Name has Omnibox prefix.\n\n * kDocumentProvider vs \"OmniboxDocumentProvider\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderPrimaryAccountRequirement vs \"OmniboxDocumentProviderPrimaryAccountRequirement\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderEnterpriseEligibility vs \"OmniboxDocumentProviderEnterpriseEligibility\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderEnterpriseEligibilityWhenUnknown vs \"OmniboxDocumentProviderEnterpriseEligibilityWhenUnknown\"\n * Name has Omnibox prefix.\n\n * kDocumentProviderNoSyncRequirement vs \"OmniboxDocumentProviderNoSyncRequirement\"\n * Name has Omnibox prefix.\n\n * kShowPopupOnMouseReleased vs \"OmniboxShowPopupOnMouseReleased\"\n * Name has Omnibox prefix.\n\n * kMostVisitedTilesHorizontalRenderGroup vs \"OmniboxMostVisitedTilesHorizontalRenderGroup\"\n * Name has Omnibox prefix.\n\n * kRichAutocompletion vs \"OmniboxRichAutocompletion\"\n * Name has Omnibox prefix.\n\n * kDefaultTypedNavigationsToHttps vs \"OmniboxDefaultTypedNavigationsToHttps\"\n * Name has Omnibox prefix.\n\n * kNumNtpZpsRecentSearches vs \"OmniboxNumNtpZpsRecentSearches\"\n * Name has Omnibox prefix.\n\n * kNumNtpZpsTrendingSearches vs \"OmniboxNumNtpZpsTrendingSearches\"\n * Name has Omnibox prefix.\n\n * kNumWebZpsRecentSearches vs \"OmniboxNumWebZpsRecentSearches\"\n * Name has Omnibox prefix.\n\n * kNumWebZpsRelatedSearches vs \"OmniboxNumWebZpsRelatedSearches\"\n * Name has Omnibox prefix.\n\n * kNumWebZpsMostVisitedUrls vs \"OmniboxNumWebZpsMostVisitedUrls\"\n * Name has Omnibox prefix.\n\n * kNumSrpZpsRecentSearches vs \"OmniboxNumSrpZpsRecentSearches\"\n * Name has Omnibox prefix.\n\n * kNumSrpZpsRelatedSearches vs \"OmniboxNumSrpZpsRelatedSearches\"\n * Name has Omnibox prefix.\n\n * kMultilineEditField vs \"OmniboxMultilineEditField\"\n * Name has Omnibox prefix.\n\n * kHideAimEntrypointOnUserInput vs \"OmniboxHideAimEntrypointOnUserInput\"\n * Name has Omnibox prefix.\n\n * kDiagnostics vs \"OmniboxDiagnostics\"\n * Name has Omnibox prefix.\n\n * kUkmSamplingRateFeature vs \"UkmSamplingRate\"\n * Identifier has Feature suffix.\n\n * kAsyncCheck vs \"AsyncNavigationIntercept\"\n * Identifier has different name.\n\n * kPushNotifications vs \"OptimizationGuidePushNotifications\"\n * Name has OptimizationGuide prefix.\n\n * kPageTextExtraction vs \"OptimizationGuidePageContentExtraction\"\n * Name has OptimizationGuide prefix.\n\n * kOptimizationGuideFetchingForSRP vs \"OptimizationHintsFetchingSRP\"\n * Guide vs Hints.\n\n * kOptimizationGuidePersonalizedFetching vs \"OptimizationPersonalizedHintsFetching\"\n * Guide vs PersonalizedHints.\n\n * kPasswordChangeSubmission vs \"PasswordChangeSubmissionSettingsVisibility\"\n * Name has SettingsVisibility suffix.\n\n * kHintsBatchUpdateForActiveTabsAndTopHosts vs \"OptimizationGuideHintsBatchUpdateForActiveTabsAndTopHosts\"\n * Name has OptimizationGuide prefix.\n\n * kHintsMaxConcurrentBatchUpdateFetchesOverride vs \"OptimizationGuideHintsMaxConcurrentBatchUpdateFetchesOverride\"\n * Name has OptimizationGuide prefix.\n\n * kHintsMaxConcurrentNavigationFetchesOverride vs \"OptimizationGuideHintsMaxConcurrentNavigationFetchesOverride\"\n * Name has OptimizationGuide prefix.\n\n * kDisableStrikeSystem vs \"DisableAutofillStrikeSystem\"\n * Name has Autofill prefix.\n\n * kPriceInsightsHighPriceIos vs \"PriceInsightsHighPrice\"\n * Identifier has Ios suffix.\n\n * kLensSearchNotFoundOnPageToast vs \"kLensSearchNotFoundOnPageToast\"\n * Name has k prefix.\n\n * kEnforceNonceChecking vs \"CastNonceEnforced\"\n * Enforce vs Cast and Checking vs Enforced.\n\n * kEnforceSHA256Checking vs \"CastSHA256Enforced\"\n * Enforce vs Cast and Checking vs Enforced.\n\n * kSafeBrowsingSubresourceFilter vs \"SubresourceFilter\"\n * Identifier has SafeBrowsing prefix.\n\n * kIPHDummyGroup vs \"IPH_DummyGroup\"\n * Case difference.\n\n * kiOSFullscreenPromosGroup vs \"IPH_iOSFullscreenPromosGroup\"\n * Case difference.\n\n * kiOSDefaultBrowserPromosGroup vs \"IPH_iOSDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kiOSTailoredDefaultBrowserPromosGroup vs \"IPH_iOSTailoredDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kiOSTailoredNonModalDefaultBrowserPromosGroup vs \"IPH_iOSTailoredNonModalDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kiOSNonModalSigninPromosGroup vs \"IPH_iOSNonModalSigninPromosGroup\"\n * Case difference.\n\n * kiOSHomepageNewBadgesGroup vs \"IPH_iOSHomepageNewBadgesGroup\"\n * Case difference.\n\n * kClankDefaultBrowserPromosGroup vs \"IPH_ClankDefaultBrowserPromosGroup\"\n * Case difference.\n\n * kIPHDemoMode vs \"IPH_DemoMode\"\n * Case difference.\n\n * kIPHDummyFeature vs \"IPH_Dummy\"\n * Identifier has Feature suffix.\n\n * kEsbDownloadRowPromoFeature vs \"EsbDownloadRowPromo\"\n * Identifier has Feature suffix.\n\n * kIPHBatterySaverModeFeature vs \"IPH_BatterySaverMode\"\n * Identifier has Feature suffix.\n\n * kIPHCompanionSidePanelFeature vs \"IPH_CompanionSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHCompanionSidePanelRegionSearchFeature vs \"IPH_CompanionSidePanelRegionSearch\"\n * Identifier has Feature suffix.\n\n * kIPHComposeMSBBSettingsFeature vs \"IPH_ComposeMSBBSettingsFeature\"\n * Identifier has Feature suffix.\n\n * kIPHComposeNewBadgeFeature vs \"IPH_ComposeNewBadgeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopSharedHighlightingFeature vs \"IPH_DesktopSharedHighlighting\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopCustomizeChromeFeature vs \"IPH_DesktopCustomizeChrome\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopCustomizeChromeRefreshFeature vs \"IPH_DesktopCustomizeChromeRefresh\"\n * Identifier has Feature suffix.\n\n * kIPHDiscardRingFeature vs \"IPH_DiscardRing\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadEsbPromoFeature vs \"IPH_DownloadEsbPromo\"\n * Identifier has Feature suffix.\n\n * kIPHExplicitBrowserSigninPreferenceRememberedFeature vs \"IPH_ExplicitBrowserSigninPreferenceRemembered\"\n * Identifier has Feature suffix.\n\n * kIPHHistorySearchFeature vs \"IPH_HistorySearch\"\n * Identifier has Feature suffix.\n\n * kIPHExtensionsMenuFeature vs \"IPH_ExtensionsMenu\"\n * Identifier has Feature suffix.\n\n * kIPHExtensionsRequestAccessButtonFeature vs \"IPH_ExtensionsRequestAccessButton\"\n * Identifier has Feature suffix.\n\n * kIPHExtensionsZeroStatePromoFeature vs \"IPH_ExtensionsZeroStatePromo\"\n * Identifier has Feature suffix.\n\n * kIPHFocusHelpBubbleScreenReaderPromoFeature vs \"IPH_FocusHelpBubbleScreenReaderPromo\"\n * Identifier has Feature suffix.\n\n * kIPHGlicPromoFeature vs \"IPH_GlicPromo\"\n * Identifier has Feature suffix.\n\n * kIPHGMCCastStartStopFeature vs \"IPH_GMCCastStartStop\"\n * Identifier has Feature suffix.\n\n * kIPHGMCLocalMediaCastingFeature vs \"IPH_GMCLocalMediaCasting\"\n * Identifier has Feature suffix.\n\n * kIPHMemorySaverModeFeature vs \"IPH_HighEfficiencyMode\"\n * MemorySaver vs HighEfficiency.\n\n * kIPHLiveCaptionFeature vs \"IPH_LiveCaption\"\n * Identifier has Feature suffix.\n\n * kIPHMerchantTrustFeature vs \"IPH_MerchantTrust\"\n * Identifier has Feature suffix.\n\n * kIPHLensOverlayFeature vs \"IPH_LensOverlay\"\n * Identifier has Feature suffix.\n\n * kIPHLensOverlayTranslateButtonFeature vs \"IPH_LensOverlayTranslateButton\"\n * Identifier has Feature suffix.\n\n * kIPHTabAudioMutingFeature vs \"IPH_TabAudioMuting\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsSavePrimingPromoFeature vs \"IPH_PasswordsSavePrimingPromo\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsSaveRecoveryPromoFeature vs \"IPH_PasswordsSaveRecoveryPromo\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsManagementBubbleAfterSaveFeature vs \"IPH_PasswordsManagementBubbleAfterSave\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsManagementBubbleDuringSigninFeature vs \"IPH_PasswordsManagementBubbleDuringSignin\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordsWebAppProfileSwitchFeature vs \"IPH_PasswordsWebAppProfileSwitch\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordManagerShortcutFeature vs \"IPH_PasswordManagerShortcut\"\n * Identifier has Feature suffix.\n\n * kIPHPasswordSharingFeature vs \"IPH_PasswordSharingFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPdfSearchifyFeature vs \"IPH_PdfSearchifyFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPerformanceInterventionDialogFeature vs \"IPH_PerformanceInterventionDialogFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPlusAddressFirstSaveFeature vs \"IPH_PlusAddressFirstSaveFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPowerBookmarksSidePanelFeature vs \"IPH_PowerBookmarksSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHPriceInsightsPageActionIconLabelFeature vs \"IPH_PriceInsightsPageActionIconLabelFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPriceTrackingEmailConsentFeature vs \"IPH_PriceTrackingEmailConsentFeature\"\n * Identifier has Feature suffix.\n\n * kIPHPriceTrackingPageActionIconLabelFeature vs \"IPH_PriceTrackingPageActionIconLabelFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListDiscoveryFeature vs \"IPH_ReadingListDiscovery\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListEntryPointFeature vs \"IPH_ReadingListEntryPoint\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListInSidePanelFeature vs \"IPH_ReadingListInSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHReadingModeSidePanelFeature vs \"IPH_ReadingModeSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHShoppingCollectionFeature vs \"IPH_ShoppingCollectionFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSideBySidePinnableFeature vs \"IPH_SideBySidePinnableFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSidePanelGenericPinnableFeature vs \"IPH_SidePanelGenericPinnableFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSidePanelLensOverlayPinnableFeature vs \"IPH_SidePanelLensOverlayPinnableFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSidePanelLensOverlayPinnableFollowupFeature vs \"IPH_SidePanelLensOverlayPinnableFollowupFeature\"\n * Identifier has Feature suffix.\n\n * kIPHSideSearchAutoTriggeringFeature vs \"IPH_SideSearchAutoTriggering\"\n * Identifier has Feature suffix.\n\n * kIPHSideSearchPageActionLabelFeature vs \"IPH_SideSearchPageActionLabel\"\n * Identifier has Feature suffix.\n\n * kIPHSignoutWebInterceptFeature vs \"IPH_SignoutWebIntercept\"\n * Identifier has Feature suffix.\n\n * kIPHPwaQuietNotificationFeature vs \"IPH_PwaQuietNotification\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSaveV2IntroFeature vs \"IPH_TabGroupsSaveV2Intro\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSaveV2CloseGroupFeature vs \"IPH_TabGroupsSaveV2CloseGroup\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSharedTabChangedFeature vs \"IPH_TabGroupsSharedTabChanged\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSharedTabFeedbackFeature vs \"IPH_TabGroupsSharedTabFeedback\"\n * Identifier has Feature suffix.\n\n * kIPHTabOrganizationSuccessFeature vs \"IPH_TabOrganizationSuccess\"\n * Identifier has Feature suffix.\n\n * kIPHTabSearchFeature vs \"IPH_TabSearch\"\n * Identifier has Feature suffix.\n\n * kIPHTabSearchToolbarButtonFeature vs \"IPH_TabSearchToolbarButton\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopSnoozeFeature vs \"IPH_DesktopSnoozeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopPwaInstallFeature vs \"IPH_DesktopPwaInstall\"\n * Identifier has Feature suffix.\n\n * kIPHProfileSwitchFeature vs \"IPH_ProfileSwitch\"\n * Identifier has Feature suffix.\n\n * kIPHWebUiHelpBubbleTestFeature vs \"IPH_WebUiHelpBubbleTest\"\n * Identifier has Feature suffix.\n\n * kIPHPriceTrackingInSidePanelFeature vs \"IPH_PriceTrackingInSidePanel\"\n * Identifier has Feature suffix.\n\n * kIPHBackNavigationMenuFeature vs \"IPH_BackNavigationMenu\"\n * Identifier has Feature suffix.\n\n * kIPHAccountSettingsHistorySync vs \"IPH_AccountSettingsHistorySync\"\n * Identifier has Feature suffix.\n\n * kIPHAndroidTabDeclutter vs \"IPH_AndroidTabDeclutter\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationNewTabFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_NewTab\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationOpenInBrowserFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_OpenInBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationShareFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_Share\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationVoiceSearchFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_VoiceSearch\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationTranslateFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_Translate\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationAddToBookmarksFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_AddToBookmarks\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationReadAloudFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_ReadAloud\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationPageSummaryWebFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_PageSummary_Web\"\n * Identifier has Feature suffix.\n\n * kIPHAdaptiveButtonInTopToolbarCustomizationPageSummaryPdfFeature vs \"IPH_AdaptiveButtonInTopToolbarCustomization_PageSummary_Pdf\"\n * Identifier has Feature suffix.\n\n * kIPHPageSummaryWebMenuFeature vs \"IPH_PageSummaryWebMenu\"\n * Identifier has Feature suffix.\n\n * kIPHPageSummaryPdfMenuFeature vs \"IPH_PageSummaryPdfMenu\"\n * Identifier has Feature suffix.\n\n * kIPHAppSpecificHistory vs \"IPH_AppSpecificHistory\"\n * Identifier has Feature suffix.\n\n * kIPHAutoDarkOptOutFeature vs \"IPH_AutoDarkOptOut\"\n * Identifier has Feature suffix.\n\n * kIPHAutoDarkUserEducationMessageFeature vs \"IPH_AutoDarkUserEducationMessage\"\n * Identifier has Feature suffix.\n\n * kIPHAutoDarkUserEducationMessageOptInFeature vs \"IPH_AutoDarkUserEducationMessageOptIn\"\n * Identifier has Feature suffix.\n\n * kIPHCCTHistory vs \"IPH_CCTHistory\"\n * Identifier has Feature suffix.\n\n * kIPHCCTMinimized vs \"IPH_CCTMinimized\"\n * Identifier has Feature suffix.\n\n * kIPHContextualPageActionsQuietVariantFeature vs \"IPH_ContextualPageActions_QuietVariant\"\n * Identifier has Feature suffix.\n\n * kIPHContextualPageActionsActionChipFeature vs \"IPH_ContextualPageActions_ActionChip\"\n * Identifier has Feature suffix.\n\n * kIPHDataSaverDetailFeature vs \"IPH_DataSaverDetail\"\n * Identifier has Feature suffix.\n\n * kIPHDataSaverMilestonePromoFeature vs \"IPH_DataSaverMilestonePromo\"\n * Identifier has Feature suffix.\n\n * kIPHDataSaverPreviewFeature vs \"IPH_DataSaverPreview\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultBrowserPromoMagicStackFeature vs \"IPH_DefaultBrowserPromoMagicStack\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultBrowserPromoMessagesFeature vs \"IPH_DefaultBrowserPromoMessages\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultBrowserPromoSettingCardFeature vs \"IPH_DefaultBrowserPromoSettingCard\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadHomeFeature vs \"IPH_DownloadHome\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadIndicatorFeature vs \"IPH_DownloadIndicator\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadPageFeature vs \"IPH_DownloadPage\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadPageScreenshotFeature vs \"IPH_DownloadPageScreenshot\"\n * Identifier has Feature suffix.\n\n * kIPHChromeHomeExpandFeature vs \"IPH_ChromeHomeExpand\"\n * Identifier has Feature suffix.\n\n * kIPHChromeHomePullToRefreshFeature vs \"IPH_ChromeHomePullToRefresh\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadSettingsFeature vs \"IPH_DownloadSettings\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadInfoBarDownloadContinuingFeature vs \"IPH_DownloadInfoBarDownloadContinuing\"\n * Identifier has Feature suffix.\n\n * kIPHDownloadInfoBarDownloadsAreFasterFeature vs \"IPH_DownloadInfoBarDownloadsAreFaster\"\n * Identifier has Feature suffix.\n\n * kIPHReadAloudAppMenuFeature vs \"IPH_ReadAloudAppMenuFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadAloudExpandedPlayerFeature vs \"IPH_ReadAloudExpandedPlayerFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadAloudPlaybackModeFeature vs \"IPH_ReadAloudPlaybackModeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterContextMenuFeature vs \"IPH_ReadLaterContextMenu\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterAppMenuBookmarkThisPageFeature vs \"IPH_ReadLaterAppMenuBookmarkThisPage\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterAppMenuBookmarksFeature vs \"IPH_ReadLaterAppMenuBookmarks\"\n * Identifier has Feature suffix.\n\n * kIPHReadLaterBottomSheetFeature vs \"IPH_ReadLaterBottomSheet\"\n * Identifier has Feature suffix.\n\n * kIPHRequestDesktopSiteDefaultOnFeature vs \"IPH_RequestDesktopSiteDefaultOn\"\n * Identifier has Feature suffix.\n\n * kIPHRequestDesktopSiteExceptionsGenericFeature vs \"IPH_RequestDesktopSiteExceptionsGeneric\"\n * Identifier has Feature suffix.\n\n * kIPHRequestDesktopSiteWindowSettingFeature vs \"IPH_RequestDesktopSiteWindowSetting\"\n * Identifier has Feature suffix.\n\n * kIPHRtlGestureNavigationFeature vs \"IPH_RtlGestureNavigation\"\n * Identifier has Feature suffix.\n\n * kIPHShoppingListSaveFlowFeature vs \"IPH_ShoppingListSaveFlow\"\n * Identifier has Feature suffix.\n\n * kIPHEphemeralTabFeature vs \"IPH_EphemeralTab\"\n * Identifier has Feature suffix.\n\n * kIPHFeedCardMenuFeature vs \"IPH_FeedCardMenu\"\n * Identifier has Feature suffix.\n\n * kIPHGenericAlwaysTriggerHelpUiFeature vs \"IPH_GenericAlwaysTriggerHelpUiFeature\"\n * Identifier has Feature suffix.\n\n * kIPHIdentityDiscFeature vs \"IPH_IdentityDisc\"\n * Identifier has Feature suffix.\n\n * kIPHInstanceSwitcherFeature vs \"IPH_InstanceSwitcher\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryAddressFillingFeature vs \"IPH_KeyboardAccessoryAddressFilling\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryBarSwipingFeature vs \"IPH_KeyboardAccessoryBarSwiping\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryPasswordFillingFeature vs \"IPH_KeyboardAccessoryPasswordFilling\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryPaymentFillingFeature vs \"IPH_KeyboardAccessoryPaymentFilling\"\n * Identifier has Feature suffix.\n\n * kIPHKeyboardAccessoryPaymentOfferFeature vs \"IPH_KeyboardAccessoryPaymentOffer\"\n * Identifier has Feature suffix.\n\n * kIPHLowUserEngagementDetectorFeature vs \"IPH_LowUserEngagementDetector\"\n * Identifier has Feature suffix.\n\n * kIPHMicToolbarFeature vs \"IPH_MicToolbar\"\n * Identifier has Feature suffix.\n\n * kIPHMenuAddToGroup vs \"IPH_MenuAddToGroup\"\n * Identifier has Feature suffix.\n\n * kIPHMostVisitedTilesCustomizationPinFeature vs \"IPH_MostVisitedTilesCustomizationPin\"\n * Identifier has Feature suffix.\n\n * kIPHPageInfoFeature vs \"IPH_PageInfo\"\n * Identifier has Feature suffix.\n\n * kIPHPageInfoStoreInfoFeature vs \"IPH_PageInfoStoreInfo\"\n * Identifier has Feature suffix.\n\n * kIPHPageZoomFeature vs \"IPH_PageZoom\"\n * Identifier has Feature suffix.\n\n * kIPHPdfPageDownloadFeature vs \"IPH_PdfPageDownload\"\n * Identifier has Feature suffix.\n\n * kIPHPreviewsOmniboxUIFeature vs \"IPH_PreviewsOmniboxUI\"\n * Identifier has Feature suffix.\n\n * kIPHReaderModeDistillInAppFeature vs \"IPH_ReaderModeDistillInApp\"\n * Identifier has Feature suffix.\n\n * kIPHShoppingListMenuItemFeature vs \"IPH_ShoppingListMenuItem\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupCreationDialogSyncTextFeature vs \"IPH_TabGroupCreationDialogSyncText\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsDragAndDropFeature vs \"IPH_TabGroupsDragAndDrop\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareNoticeFeature vs \"IPH_TabGroupShareNotice\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareNotificationBubbleOnStripFeature vs \"IPH_TabGroupSharedNotificationBubbleOnStrip\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareUpdateFeature vs \"IPH_TabGroupShareUpdate\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupShareVersionUpdateFeature vs \"IPH_TabGroupShareVersionUpdate\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsRemoteGroupFeature vs \"IPH_TabGroupsRemoteGroup\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSurfaceFeature vs \"IPH_TabGroupsSurface\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupsSurfaceOnHideFeature vs \"IPH_TabGroupsSurfaceOnHide\"\n * Identifier has Feature suffix.\n\n * kIPHTabGroupSyncOnStripFeature vs \"IPH_TabGroupSyncOnStrip\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherAddToGroup vs \"IPH_TabSwitcherAddToGroup\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherButtonFeature vs \"IPH_TabSwitcherButton\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherButtonSwitchIncognitoFeature vs \"IPH_TabSwitcherButtonSwitchIncognito\"\n * Identifier has Feature suffix.\n\n * kIPHTouchToSearchCalloutFeature vs \"IPH_TouchToSearchCallout\"\n * Identifier has Feature suffix.\n\n * kIPHTranslateMenuButtonFeature vs \"IPH_TranslateMenuButton\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPChromeIntroFeature vs \"IPH_VideoTutorial_NTP_ChromeIntro\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPDownloadFeature vs \"IPH_VideoTutorial_NTP_Download\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPSearchFeature vs \"IPH_VideoTutorial_NTP_Search\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPVoiceSearchFeature vs \"IPH_VideoTutorial_NTP_VoiceSearch\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialNTPSummaryFeature vs \"IPH_VideoTutorial_NTP_Summary\"\n * Identifier has Feature suffix.\n\n * kIPHVideoTutorialTryNowFeature vs \"IPH_VideoTutorial_TryNow\"\n * Identifier has Feature suffix.\n\n * kIPHExploreSitesTileFeature vs \"IPH_ExploreSitesTile\"\n * Identifier has Feature suffix.\n\n * kIPHFeedHeaderMenuFeature vs \"IPH_FeedHeaderMenu\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedAwarenessFeature vs \"IPH_WebFeedAwareness\"\n * Identifier has Feature suffix.\n\n * kIPHFeedSwipeRefresh vs \"IPH_FeedSwipeRefresh\"\n * Identifier has Feature suffix.\n\n * kIPHChromeReengagementNotification1Feature vs \"IPH_ChromeReengagementNotification1\"\n * Identifier has Feature suffix.\n\n * kIPHChromeReengagementNotification2Feature vs \"IPH_ChromeReengagementNotification2\"\n * Identifier has Feature suffix.\n\n * kIPHChromeReengagementNotification3Feature vs \"IPH_ChromeReengagementNotification3\"\n * Identifier has Feature suffix.\n\n * kIPHShareScreenshotFeature vs \"IPH_ShareScreenshot\"\n * Identifier has Feature suffix.\n\n * kIPHSharingHubLinkToggleFeature vs \"IPH_SharingHubLinkToggle\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedFollowFeature vs \"IPH_WebFeedFollow\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedPostFollowDialogFeature vs \"IPH_WebFeedPostFollowDialog\"\n * Identifier has Feature suffix.\n\n * kIPHWebFeedPostFollowDialogFeatureWithUIUpdate vs \"IPH_WebFeedPostFollowDialogWithUIUpdate\"\n * Identifier has Feature suffix.\n\n * kIPHSharedHighlightingBuilder vs \"IPH_SharedHighlightingBuilder\"\n * Identifier has Feature suffix.\n\n * kIPHSharedHighlightingReceiverFeature vs \"IPH_SharedHighlightingReceiver\"\n * Identifier has Feature suffix.\n\n * kIPHSharingHubWebnotesStylizeFeature vs \"IPH_SharingHubWebnotesStylize\"\n * Identifier has Feature suffix.\n\n * kIPHRestoreTabsOnFREFeature vs \"IPH_RestoreTabsOnFRE\"\n * Identifier has Feature suffix.\n\n * kIPHTabSwitcherXR vs \"IPH_TabSwitcherXR\"\n * Identifier has Feature suffix.\n\n * kIPHTabTearingXR vs \"IPH_TabTearingXR\"\n * Identifier has Feature suffix.\n\n * kIPHBottomToolbarTipFeature vs \"IPH_BottomToolbarTip\"\n * Identifier has Feature suffix.\n\n * kIPHLongPressToolbarTipFeature vs \"IPH_LongPressToolbarTip\"\n * Identifier has Feature suffix.\n\n * kIPHBadgedReaderModeFeature vs \"IPH_BadgedReaderMode\"\n * Identifier has Feature suffix.\n\n * kIPHBadgedReadingListFeature vs \"IPH_BadgedReadingList\"\n * Identifier has Feature suffix.\n\n * kIPHWhatsNewFeature vs \"IPH_WhatsNew\"\n * Identifier has Feature suffix.\n\n * kIPHWhatsNewUpdatedFeature vs \"IPH_WhatsNewUpdated\"\n * Identifier has Feature suffix.\n\n * kIPHReadingListMessagesFeature vs \"IPH_ReadingListMessages\"\n * Identifier has Feature suffix.\n\n * kIPHBadgedTranslateManualTriggerFeature vs \"IPH_BadgedTranslateManualTrigger\"\n * Identifier has Feature suffix.\n\n * kIPHDiscoverFeedHeaderFeature vs \"IPH_DiscoverFeedHeaderMenu\"\n * Identifier has Feature suffix.\n\n * kIPHDefaultSiteViewFeature vs \"IPH_DefaultSiteView\"\n * Identifier has Feature suffix.\n\n * kIPHFollowWhileBrowsingFeature vs \"IPH_FollowWhileBrowsing\"\n * Identifier has Feature suffix.\n\n * kIPHPriceNotificationsWhileBrowsingFeature vs \"IPH_PriceNotificationsWhileBrowsing\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserBadgeEligibilityFeature vs \"IPH_iOSDefaultBrowserBadgeEligibility\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserOverflowMenuBadgeFeature vs \"IPH_iOSDefaultBrowserOverflowMenuBadge\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDownloadAutoDeletionFeature vs \"IPH_iOSDownloadAutoDeletion\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensKeyboardFeature vs \"IPH_iOSLensKeyboard\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoAppStoreFeature vs \"IPH_iOSPromoAppStore\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoWhatsNewFeature vs \"IPH_iOSPromoWhatsNew\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoSigninFullscreenFeature vs \"IPH_iOSPromoSigninFullscreen\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoPostRestoreFeature vs \"IPH_iOSPromoPostRestore\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoCredentialProviderExtensionFeature vs \"IPH_iOSPromoCredentialProviderExtension\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoDefaultBrowserReminderFeature vs \"IPH_iOSPromoDefaultBrowserReminder\"\n * Identifier has Feature suffix.\n\n * kIPHiOSHistoryOnOverflowMenuFeature vs \"IPH_iOSHistoryOnOverflowMenuFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoPostRestoreDefaultBrowserFeature vs \"IPH_iOSPromoPostRestoreDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalUrlPasteDefaultBrowserFeature vs \"IPH_iOSPromoNonModalUrlPasteDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalAppSwitcherDefaultBrowserFeature vs \"IPH_iOSPromoNonModalAppSwitcherDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalShareDefaultBrowserFeature vs \"IPH_iOSPromoNonModalShareDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalSigninPasswordFeature vs \"IPH_iOSPromoNonModalSigninPassword\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoNonModalSigninBookmarkFeature vs \"IPH_iOSPromoNonModalSigninBookmark\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoPasswordManagerWidgetFeature vs \"IPH_iOSPromoPasswordManagerWidget\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPullToRefreshFeature vs \"IPH_iOSPullToRefreshFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSReplaceSyncPromosWithSignInPromos vs \"IPH_iOSReplaceSyncPromosWithSignInPromos\"\n * Identifier has Feature suffix.\n\n * kIPHiOSTabGridSwipeRightForIncognito vs \"IPH_iOSTabGridSwipeRightForIncognito\"\n * Case difference.\n\n * kIPHiOSDockingPromoFeature vs \"IPH_iOSDockingPromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDockingPromoRemindMeLaterFeature vs \"IPH_iOSDockingPromoRemindMeLater\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoAllTabsFeature vs \"IPH_iOSPromoAllTabs\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoMadeForIOSFeature vs \"IPH_iOSPromoMadeForIOS\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoStaySafeFeature vs \"IPH_iOSPromoStaySafe\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSwipeBackForwardFeature vs \"IPH_iOSSwipeBackForward\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSwipeToolbarToChangeTabFeature vs \"IPH_iOSSwipeToolbarToChangeTab\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPostDefaultAbandonmentPromoFeature vs \"IPH_iOSPostDefaultAbandonmentPromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPromoGenericDefaultBrowserFeature vs \"IPH_iOSPromoGenericDefaultBrowser\"\n * Identifier has Feature suffix.\n\n * kIPHiOSOverflowMenuCustomizationFeature vs \"IPH_iOSOverflowMenuCustomization\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPageInfoRevampFeature vs \"IPH_iOSPageInfoRevamp\"\n * Identifier has Feature suffix.\n\n * kIPHiOSInlineEnhancedSafeBrowsingPromoFeature vs \"IPH_iOSInlineEnhancedSafeBrowsingPromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSavedTabGroupClosed vs \"IPH_iOSSavedTabGroupClosed\"\n * Case difference.\n\n * kIPHiOSContextualPanelSampleModelFeature vs \"IPH_iOSContextualPanelSampleModel\"\n * Identifier has Feature suffix.\n\n * kIPHiOSContextualPanelPriceInsightsFeature vs \"IPH_iOSContextualPanelPriceInsights\"\n * Identifier has Feature suffix.\n\n * kIPHHomeCustomizationMenuFeature vs \"IPH_HomeCustomizationMenu\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensOverlayEntrypointTipFeature vs \"IPH_iOSLensOverlayEntrypointTip\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensOverlayEscapeHatchTipFeature vs \"IPH_iOSLensOverlayEscapeHatchTip\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSharedTabGroupForeground vs \"IPH_iOSSharedTabGroupForeground\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserBannerPromoFeature vs \"IPH_iOSDefaultBrowserBannerPromoFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSDefaultBrowserOffCyclePromoFeature vs \"IPH_iOSDefaultBrowserOffCyclePromo\"\n * Identifier has Feature suffix.\n\n * kIPHiOSReminderNotificationsOverflowMenuBubbleFeature vs \"IPH_iOSReminderNotificationsOverflowMenuBubbleFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSReminderNotificationsOverflowMenuNewBadgeFeature vs \"IPH_iOSReminderNotificationsOverflowMenuNewBadgeFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSafariImportFeature vs \"IPH_iOSSafariImportFeature\"\n * Case difference.\n\n * kIPHiOSSettingsInOverflowMenuBubbleFeature vs \"IPH_iOSSettingsInOverflowMenuBubbleFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSSwitchAccountsWithNTPAccountParticleDiscFeature vs \"IPH_iOSSwitchAccountsWithNTPAccountParticleDiscFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSFeedSwipeStaticFeature vs \"IPH_iOSFeedSwipeStaticFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSFeedSwipeAnimatedFeature vs \"IPH_iOSFeedSwipeAnimatedFeature\"\n * Identifier has Feature suffix.\n\n * kIPHiOSWelcomeBackFeature vs \"IPH_iOSWelcomeBack\"\n * Identifier has Feature suffix.\n\n * kIPHIOSPageActionMenu vs \"IPH_iOSPageActionMenu\"\n * Case difference.\n\n * kIPHiOSReaderModeOptionsFeature vs \"IPH_iOSReaderModeOptions\"\n * Identifier has Feature suffix.\n\n * kIPHiOSHomepageLensNewBadge vs \"IPH_iOSHomepageLensNewBadge\"\n * Identifier has Feature suffix.\n\n * kIPHiOSHomepageCustomizationNewBadge vs \"IPH_iOSHomepageCustomizationNewBadge\"\n * Identifier has Feature suffix.\n\n * kIPHiOSOneTimeDefaultBrowserNotificationFeature vs \"IPH_iOSOneTimeDefaultBrowserNotification\"\n * Identifier has Feature suffix.\n\n * kIPHiOSAIHubNewBadge vs \"IPH_iOSAIHubNewBadge\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillBnplAffirmOrZipSuggestionFeature vs \"IPH_AutofillBnplAffirmOrZipSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillBnplAffirmZipOrKlarnaSuggestionFeature vs \"IPH_AutofillBnplAffirmZipOrKlarnaSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillCardInfoRetrievalSuggestionFeature vs \"IPH_AutofillCardInfoRetrievalSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillCreditCardBenefitFeature vs \"IPH_AutofillCreditCardBenefit\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillDisabledVirtualCardSuggestionFeature vs \"IPH_AutofillDisabledVirtualCardSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillExternalAccountProfileSuggestionFeature vs \"IPH_AutofillExternalAccountProfileSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillHomeWorkProfileSuggestionFeature vs \"IPH_AutofillHomeWorkProfileSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillAccountNameEmailSuggestionFeature vs \"IPH_AutofillAccountNameEmailSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillAiOptInFeature vs \"IPH_AutofillAiOptIn\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillVirtualCardCVCSuggestionFeature vs \"IPH_AutofillVirtualCardCVCSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillVirtualCardSuggestionFeature vs \"IPH_AutofillVirtualCardSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHCookieControlsFeature vs \"IPH_CookieControls\"\n * Identifier has Feature suffix.\n\n * kIPHPlusAddressCreateSuggestionFeature vs \"IPH_PlusAddressCreateSuggestion\"\n * Identifier has Feature suffix.\n\n * kIPHAutofillEnableLoyaltyCardsFeature vs \"IPH_AutofillEnableLoyaltyCards\"\n * Identifier has Feature suffix.\n\n * kIPHGrowthFramework vs \"IPH_GrowthFramework\"\n * Identifier has Feature suffix.\n\n * kIPHGoogleOneOfferNotificationFeature vs \"IPH_GoogleOneOfferNotification\"\n * Identifier has Feature suffix.\n\n * kIPHLauncherSearchHelpUiFeature vs \"IPH_LauncherSearchHelpUi\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedOneFeature vs \"IPH_ScalableIphTimerBasedOne\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedTwoFeature vs \"IPH_ScalableIphTimerBasedTwo\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedThreeFeature vs \"IPH_ScalableIphTimerBasedThree\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedFourFeature vs \"IPH_ScalableIphTimerBasedFour\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedFiveFeature vs \"IPH_ScalableIphTimerBasedFive\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedSixFeature vs \"IPH_ScalableIphTimerBasedSix\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedSevenFeature vs \"IPH_ScalableIphTimerBasedSeven\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedEightFeature vs \"IPH_ScalableIphTimerBasedEight\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedNineFeature vs \"IPH_ScalableIphTimerBasedNine\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphTimerBasedTenFeature vs \"IPH_ScalableIphTimerBasedTen\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedOneFeature vs \"IPH_ScalableIphUnlockedBasedOne\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedTwoFeature vs \"IPH_ScalableIphUnlockedBasedTwo\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedThreeFeature vs \"IPH_ScalableIphUnlockedBasedThree\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedFourFeature vs \"IPH_ScalableIphUnlockedBasedFour\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedFiveFeature vs \"IPH_ScalableIphUnlockedBasedFive\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedSixFeature vs \"IPH_ScalableIphUnlockedBasedSix\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedSevenFeature vs \"IPH_ScalableIphUnlockedBasedSeven\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedEightFeature vs \"IPH_ScalableIphUnlockedBasedEight\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedNineFeature vs \"IPH_ScalableIphUnlockedBasedNine\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphUnlockedBasedTenFeature vs \"IPH_ScalableIphUnlockedBasedTen\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedNudgeFeature vs \"IPH_ScalableIphHelpAppBasedNudge\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedOneFeature vs \"IPH_ScalableIphHelpAppBasedOne\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedTwoFeature vs \"IPH_ScalableIphHelpAppBasedTwo\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedThreeFeature vs \"IPH_ScalableIphHelpAppBasedThree\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedFourFeature vs \"IPH_ScalableIphHelpAppBasedFour\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedFiveFeature vs \"IPH_ScalableIphHelpAppBasedFive\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedSixFeature vs \"IPH_ScalableIphHelpAppBasedSix\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedSevenFeature vs \"IPH_ScalableIphHelpAppBasedSeven\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedEightFeature vs \"IPH_ScalableIphHelpAppBasedEight\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedNineFeature vs \"IPH_ScalableIphHelpAppBasedNine\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphHelpAppBasedTenFeature vs \"IPH_ScalableIphHelpAppBasedTen\"\n * Identifier has Feature suffix.\n\n * kIPHScalableIphGamingFeature vs \"IPH_ScalableIphGaming\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopPWAsLinkCapturingLaunch vs \"IPH_DesktopPWAsLinkCapturingLaunch\"\n * Identifier has Feature suffix.\n\n * kIPHDesktopPWAsLinkCapturingLaunchAppInTab vs \"IPH_DesktopPWAsLinkCapturingLaunchAppInTab\"\n * Identifier has Feature suffix.\n\n * kIPHSupervisedUserProfileSigninFeature vs \"IPH_SupervisedUserProfileSignin\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPasswordPromoDesktopFeature vs \"IPH_iOSPasswordPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSAddressPromoDesktopFeature vs \"IPH_iOSAddressPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSPaymentPromoDesktopFeature vs \"IPH_iOSPaymentPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSLensPromoDesktopFeature vs \"IPH_iOSLensPromoDesktop\"\n * Identifier has Feature suffix.\n\n * kIPHiOSEnhancedBrowsingDesktopFeature vs \"IPH_iOSEnhancedBrowsingDesktop\"\n * Case difference.\n\n * kCctAutoTranslate vs \"CCTAutoTranslate\"\n * Case difference.\n\n * kEnableZstd vs \"EnableZstdV2\"\n * Name has V2 suffix.\n\n * kLogMe vs \"CronetLogMe\"\n * Name has Cronet prefix.\n\n * kWindowsMemoryPressurePeriod vs \"WinMemoryPressurePeriod\"\n * Windows vs Win.\n\n * kOfflinePagesInDownloadHomeOpenInCctFeature vs \"OfflinePagesInDownloadHomeOpenInCct\"\n * Identifier has Feature suffix.\n\n * kStructuredMetrics vs \"EnableStructuredMetrics\"\n * Name has Enable prefix.\n\n * kExpiredHistogramLogicFeature vs \"ExpiredHistogramLogic\"\n * Identifier has Feature suffix.\n\n * kPersistentHistogramsFeature vs \"PersistentHistograms\"\n * Identifier has Feature suffix.\n\n * kUseUserDefaultsForExitedCleanlyBeacon vs \"UseUserDefaultsForExitedCleanlyBeaconEnabler\"\n * Name has Enabler suffix.\n\n * kPseudoMetricsEffectFeature vs \"UMAPseudoMetricsEffect\"\n * Name has UMA prefix.\n\n * kCARenderer vs \"CoreAnimationRenderer\"\n * CA vs CoreAnimation.\n\n * kHDRUnderlays vs \"CoreAnimationHDRUnderlays\"\n * Name has CoreAnimation prefix.\n\n * kWebAuthnAndroidPasskeyCacheMigration vs \"WebAuthenticationAndroidPasskeyCacheMigration\"\n * WebAuthn vs WebAuthentication.\n\n * kCrosSystemLevelPermissionBlockedWarnings vs \"CrosBlockWarnings\"\n * SystemLevelPermissionBlocked vs Block.\n\n * kFlushAfterAppending vs \"SessionStorageFlushAfterAppendingCommands\"\n * Name has SessionStorage prefix and Commands suffix.\n\n * kUseFinchPermanentCountryForFetchCountryId vs \"UseFinchPermanentCountyForFetchCountryId\"\n * Country vs County.\n\n * kSiteIsolationForPasswordSites vs \"site-isolation-for-password-sites\"\n * Case and kebab-case mismatch.\n\n * kSiteIsolationMemoryThresholdsAndroid vs \"SiteIsolationMemoryThresholds\"\n * Identifier has Android suffix.\n\n * kDataSharingFeature vs \"DataSharing\"\n * Identifier has Feature suffix.\n\n * kSegmentationPlatformFeature vs \"SegmentationPlatform\"\n * Identifier has Feature suffix.\n\n * kResumeHeavyUserSegmentFeature vs \"ResumeHeavyUserSegment\"\n * Identifier has Feature suffix.\n\n * kUIDebugToolsEnableSyntheticEvents vs \"ui-debug-tools-enable-synthetic-events\"\n * Case and kebab-case mismatch.\n\n * kPopularSitesBakedInContentFeature vs \"NTPPopularSitesBakedInContent\"\n * Name has NTP prefix.\n\n * kNtpMostLikelyFaviconsFromServerFeature vs \"NTPMostLikelyFaviconsFromServer\"\n * Identifier has Feature suffix.\n\n * kNtpEnterpriseShortcuts vs \"NTPEnterpriseShortcuts\"\n * Identifier has Feature suffix.\n\nEnabled-by-default-reason: refactor\nNO_IFTTT\u003drefactor; no functionality change\n\nBug: 436274260\nChange-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6945639\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nAuto-Submit: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1515845}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 67735866800aa838628039f951a3095d0602f03c\n" }, { "commit": "7023e065214f0980ca173b65721938208a1dc69d", "tree": "98b7a2538dfd68b7b442f1de560c266255070285", "parents": [ "c038ef6f93d9b3ca8386b36ace899d409ed02fa9" ], "author": { "name": "Ho Cheung", "email": "hocheung@chromium.org", "time": "Fri Aug 29 11:19:55 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 29 11:25:09 2025" }, "message": "Replace ternary with logical expressions in //components\n\nConvert, e.g.\n x ? y : false -\u003e x \u0026\u0026 y\n x ? false : y -\u003e !x \u0026\u0026 y\n x ? y : true - \u003e !x || y\n x ? true : y -\u003e x || y\n\nBug: 416294715\nChange-Id: I5b5cd2a2fffdc74ff4711352f0b80b28b168ff83\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6898575\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Ho Cheung \u003chocheung@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1508281}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6cdb114695626c964e5ee1cc4d8a9508639beb01\n" }, { "commit": "c038ef6f93d9b3ca8386b36ace899d409ed02fa9", "tree": "543ceed741a8eb0e9a0b9218774bf67f3971f0ac", "parents": [ "5a71d7bc165c9f79a2bbb08fec7972493f67847b" ], "author": { "name": "Michael Sun", "email": "michaelfsun@google.com", "time": "Wed Aug 27 17:49:30 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 27 17:55:44 2025" }, "message": "redaction_tool: narrow down the regex search for Bluetooth HID device\n\nFurther specific BUS index to more accurately search the Bluetooth HID device.\n\nBUG\u003db:323953072\nTEST\u003dcomponents_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: I7dcf185d7e6dcc3d2610c7e13aead1d8a4ee3ceb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6881910\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Michael Sun \u003cmichaelfsun@google.com\u003e\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nCommit-Queue: Michael Sun \u003cmichaelfsun@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1507208}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5b257bb96c62ca2d8f82bcdd5b06334871e489ef\n" }, { "commit": "5a71d7bc165c9f79a2bbb08fec7972493f67847b", "tree": "7f944b54f41512080653aab9c8a1fcd4dffe05c6", "parents": [ "d0db9f26d63c999ebfd35f748bc0dd67d3a2f40d" ], "author": { "name": "Michael Sun", "email": "michaelfsun@google.com", "time": "Mon Aug 25 21:52:23 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 25 21:58:21 2025" }, "message": "redaction_tool: Redact Bluetooth HID device names\n\nRedact Bluetooth HID device names in the kernel/dmesg logs.\n\nBUG\u003db:323953072\nTEST\u003dcomponents_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: I71e1e897a6f38ad9db08607f81ef9a1c84500929\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6880795\nCommit-Queue: Michael Sun \u003cmichaelfsun@google.com\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1506159}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 71cdb995a64b27f82614aaa223317111ae6373ee\n" }, { "commit": "d0db9f26d63c999ebfd35f748bc0dd67d3a2f40d", "tree": "e06ae7f36d05d9f24f7f800af9ef69d586d51c87", "parents": [ "ffdd9c6f54639d1ae671bf487272028b0b1846a7" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Mon Aug 18 15:37:49 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 18 15:43:23 2025" }, "message": "Fix unsafe buffer usage in components/feedback/redaction_tool/ip_address.cc\n\nThis CL fixes unsafe buffer usage in `ip_address.cc` by using\n`base::span` to avoid pointer arithmetic on IPAddress bytes.\n\nBug: 435317390\nBug: 435683431\nFixed: 435683431\nChange-Id: I9484d0a116f04665d0ff20e3b0d840e67b11977e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6846308\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1502715}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d04b0f61b4f5d7c7ee13ad0ee5676795706b0fc5\n" }, { "commit": "ffdd9c6f54639d1ae671bf487272028b0b1846a7", "tree": "0f9a142f643ad3e498a28b21fc1cac79c0287e36", "parents": [ "54e83aa2a7a00c3c65c6107a438fbb1f9a692bff" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Fri Aug 15 00:42:24 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 15 00:48:05 2025" }, "message": "Rewrite --force unsafe buffers pragmas in components/\n\nChange-Id: Ia214685aae0320821bb523f3f3e4a5903343373d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6828357\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1501715}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0cc725e5c06bff7e626bc6f32c90187065b10d3f\n" }, { "commit": "54e83aa2a7a00c3c65c6107a438fbb1f9a692bff", "tree": "6adf1185df7ec15c926091798d54a86d327db55d", "parents": [ "47b5c72add0a85dc183f2d1bc7860a03aa8b7b4a" ], "author": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Wed Aug 06 05:52:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 06 06:08:47 2025" }, "message": "spanification: automatically spanify various pointers\n\nThis is the result of running the automatic spanification on linux and\nupdating code to use and pass spans where size is known. This CL has no\nbehavior changes.\n\nAll changes should be correct and no behaviour changes in patchset 1,\nhowever the plan is to follow up and remove the redundant size\nparameters. To this effect in patchset 2 we\u0027ve added CHECKS and renames\nto note the fact the size is believed to be redundant. This was done\nthrough AI and should be carefully checked, but the CHECKS are not fatal\nand thus if unsure should be fine to land and remove after reports of\nthe crashes.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms\u003dlinux\n\nand then split with `git cl split --target-range 8 32 --max-depth\u003d2\n--no-reviewers -d ~/description.txt`\n\nThis covers directories: components\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/u/1/d/1poEhNARfFas2osqPoXGzVZtBgnOQGQtQNUFTA-MlADs/edit?tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 431824299\nChange-Id: I1282679317c0b5879455db087b672d9c4083084e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6731989\nReviewed-by: Muyao Xu \u003cmuyaoxu@google.com\u003e\nReviewed-by: Emily Stark \u003cestark@chromium.org\u003e\nReviewed-by: Nidhi Jaju \u003cnidhijaju@chromium.org\u003e\nCommit-Queue: Stephen Nusko \u003cnuskos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Jonathan Ross \u003cjonross@chromium.org\u003e\nReviewed-by: Mikel Astiz \u003cmastiz@chromium.org\u003e\nReviewed-by: Darryl James \u003cdljames@chromium.org\u003e\nReviewed-by: Antonio Rivera \u003cantoniori@google.com\u003e\nReviewed-by: Martin Kreichgauer \u003cmartinkr@google.com\u003e\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Bao-Duy Tran \u003ctranbaoduy@chromium.org\u003e\nAuto-Submit: Stephen Nusko \u003cnuskos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1497369}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2cd85c2b87fdbdba704b34b66a0cf1eeb1ebbffc\n" }, { "commit": "47b5c72add0a85dc183f2d1bc7860a03aa8b7b4a", "tree": "b293d7197a950fcb915f281af193832a06df0637", "parents": [ "947340ba4c5cecc8a14a2d6587a84c9c7567bd70" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jul 23 11:54:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 23 12:28:50 2025" }, "message": "Rework allow_unsafe pragmas in components/\n\nFully automated CL via tools/clang/unsafe_pragma_rewriter/ scripts,\nthen manually revert one file that failed DEPS checks.\n\nBug: 409340989\nChange-Id: I9949803989588810640b53eae14e5f02ac39a2fb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6715939\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1490730}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4413f7f927f8ddf9bfbee128b7c0161691b38913\n" }, { "commit": "947340ba4c5cecc8a14a2d6587a84c9c7567bd70", "tree": "af41e660980dbedf1717854657fee5f6cd0605ee", "parents": [ "d75a398f5458545e915a3ce242291af751d8765e" ], "author": { "name": "Claudio DeSouza", "email": "cdesouza@chromium.org", "time": "Wed Jul 16 12:14:15 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 16 12:20:23 2025" }, "message": "[exit-time-destructors] Exclude target with warnings\n\nThis CL is part of number of CLs disabling `-Wexit-time-destructors`in\nplaces where this warning is going off. This will allow having this\nwarning enabled-by-default across the codebase, whilst documenting the\nplaces where corrections for this warning are necessary.\n\nThis change exclude targets under:\n - [\u0027components\u0027, \u0027components/feedback\u0027, \u0027components/filename_generation\u0027, \u0027components/mirroring\u0027, \u0027components/omnibox\u0027, \u0027components/privacy_sandbox\u0027, \u0027components/safe_browsing\u0027, \u0027components/url_formatter\u0027, \u0027components/user_data_importer\u0027]\n\nThis CL was uploaded by an experimental version of git cl split\n\nR\u003dblundell@chromium.org\n\nBug: 40031409, 430332953\nChange-Id: I950cc82dbd28ece5d7a4109e2bf0a11f40e43fd3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6759325\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nAuto-Submit: Claudio DeSouza \u003ccdesouza@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1487546}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b20b09844c3215439aaaa6e7e5d0ac364c9bd47c\n" }, { "commit": "d75a398f5458545e915a3ce242291af751d8765e", "tree": "c41bfd27142c9de3668709c194e9fbc630c684cc", "parents": [ "327b000c90e725fa35b1443cfb8efb7037de0c81" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Tue May 06 17:01:11 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 17:13:34 2025" }, "message": "Modernize equality operators\n\nThis CL is pure clean-up and contains no functionality changes.\nDepending on the files covered in the CL (since the CL was generated\nusing git cl split), it does a subset of the following:\n- Remove unneeded operator!\u003d declarations/definitions since C++20 can\n automatically derive those from operator\u003d\u003d.\n- Default operator\u003d\u003d where this is equivalent to the current behavior.\n- Default operator\u003c\u003d\u003e where this is equivalent to the current\n behavior.\n\nThis CL was uploaded by git cl split.\n\nR\u003dxiangdongkong@google.com\n\nBug: 40256175\nChange-Id: I38b97f88dc9b092a4fbbe5a3e9e0a54836b6eb8b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513058\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1456425}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3cb388f732344f62593d308457c6b0994571358c\n" }, { "commit": "327b000c90e725fa35b1443cfb8efb7037de0c81", "tree": "1180c0a24525398219f65d3087cbdd0f4fd6c703", "parents": [ "4050314849f73ae5df47f6693cee3213ab83d5fd" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Thu Apr 17 19:32:03 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 17 19:38:44 2025" }, "message": "spanify: Renewed arrayification (X/43)\n\nThis CL is part of the wider spanification / arrayification effort [1]\nand does not (intentionally) introduce behavioral change. It applies the\n`std::array` rewrite to\n\n[\u0027components/zucchini\u0027, \u0027components/history\u0027, \u0027components/policy\u0027,\n\u0027components/viz\u0027, \u0027components/feedback\u0027,\n\u0027components/filename_generation\u0027, \u0027components/leveldb_proto\u0027,\n\u0027components/metrics\u0027, \u0027components/services\u0027, \u0027components/visitedlink\u0027]\n\nas close as possible to the output directly written by `spanify`, with\nno hand-rolled fixes (except where rebasing would require).\n\nThis change (and its siblings taken together) is thought not to cause\nany measurable perf regressions [2].\n\n[1] https://issues.chromium.org/356643982 [2]\nhttps://docs.google.com/document/d/1jughaR6JKn7T-dDjMou10awyNkhE5T-vLY_K2YMqHE4/edit?tab\u003dt.0#heading\u003dh.r2eguxl5lhu7\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 406029216\nChange-Id: I9764070fd66fbeced4d9b55512ef623b79c021a7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6436851\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Kalvin Lee \u003ckdlee@chromium.org\u003e\nReviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1448508}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 72b899591d10266d7ec9a2c3868f09f99d6e1d6f\n" }, { "commit": "4050314849f73ae5df47f6693cee3213ab83d5fd", "tree": "abc27f652094a496b82f42eb49839d25095b8eed", "parents": [ "cf80340e1c312a728eb399ae2949c06dffb581b8" ], "author": { "name": "Chris Davis", "email": "chrdavis@microsoft.com", "time": "Tue Mar 04 22:45:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 04 22:51:20 2025" }, "message": "Cleanup at exit destructors in chromium\n\nRemoves at exit destructors in the codebase by wrapping NoDestructor\nas appropriate. Also adds configs to various BUILD.gn files to ensure\nno future globals get added.\n\nAX-Relnotes: n/a.\nSkip-Clang-Tidy-Checks: modernize-use-equals-default\nBug: 40031409\nChange-Id: Ic801f9cedcef79d8618add51904193e95fe4dba4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6306943\nReviewed-by: Sam McNally \u003csammc@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nReviewed-by: Robert Liao \u003crobliao@chromium.org\u003e\nReviewed-by: Nicolas Ouellet-Payeur \u003cnicolaso@chromium.org\u003e\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nReviewed-by: Matthew Denton \u003cmpdenton@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Frank Liberato \u003cliberato@chromium.org\u003e\nCommit-Queue: Chris Davis \u003cchrdavis@microsoft.com\u003e\nReviewed-by: Dale Curtis \u003cdalecurtis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1428006}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1c9ac999cae62c7503565112b93a782a03e58afc\n" }, { "commit": "cf80340e1c312a728eb399ae2949c06dffb581b8", "tree": "2eaa0f10b46e6ee36397efd0ad2bcdeb5351406f", "parents": [ "3691629f24a4153be456a9ed3776ca3dcaa85069" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jan 29 02:11:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 29 02:19:33 2025" }, "message": "Suppress unsafe_libc_call warning for initial identified files.\n\nSee docs/unsafe_buffers.md for details. Enforcement is not yet\nenabled, but this set of files are not in compliance with the\nnew warnings.\n\nBug: 390223051\nChange-Id: I4e24c2141b9399f572678302c833947494098b29\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187925\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1412673}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8726d30ed0372d085f5d9048ed5a4d62e13015ca\n" }, { "commit": "3691629f24a4153be456a9ed3776ca3dcaa85069", "tree": "57d057371712219df968b4380cbb43baa5bc0a70", "parents": [ "f8c73117b1aee43ed1df825cb733f4cee3e5bb50" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Jan 27 18:38:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 27 18:48:18 2025" }, "message": "[cleanup] Replace base::ranges with std::ranges: components/\n\nDone entirely with `git grep` and `sed` + `git cl format`, no\nhand-editing.\n\nBug: 386918226\nChange-Id: I7377af2f9c3758c68a249b421d98bd3fd5c2c1fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6201377\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1411730}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ccea09835fd67b49ef0d4aed8dda1a5f22a409c8\n" }, { "commit": "f8c73117b1aee43ed1df825cb733f4cee3e5bb50", "tree": "70aa772fbc325919648c2c16c5f7f76366a00148", "parents": [ "b3f1ac14f8165274fecf24845e05fdf48740f7e9" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Dec 10 09:58:59 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 10 10:07:19 2024" }, "message": "C++11 std::array rewrite for memory safety [4/19]\n\nSplit from:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nGenerated patch\n---------------\n- Tool: ./tool/clang/spanify/rewrite-multiple-platform.sh\n- Platform: Linux.\n- Filter: This includes 2400/4222 patches. I included the std::array\n ones and excluded build errors.\n\nGoogle announcement:\n--------------------\nhttps://groups.google.com/a/google.com/g/chrome-memory-safety/c/RMiO4gaVLQA/m/Yz-3NCObAgAJ\n\nBenchmarks:\n----------\nSee design doc and\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nDescription\n-----------\nThe consensus during the memory safety summit was to begin rewriting\nrelevant C-style arrays to C++11 std::array. It can be done immediately,\noffers better developer ergonomics, and fix large chunks of the\n-Wunsafe-buffer-usage errors in Chrome.\n\nTo clarify, this effort is complementary to the longer plan work with\nenabling -fsanitize\u003darray-bounds, and we plan to leverage both,\nespecially for protecting 3p code.\n\n[Attached] is a document detailing the rationale, benefits, and\nconsiderations for potential compile-time and performance impacts.\n\n[Attached]:https://docs.google.com/document/d/1z5aBDg26lHmNDjXRCysElWKx7E4PAJXqykI_k7ondJI/edit?tab\u003dt.0#heading\u003dh.cqgo7wvp0kzt\n\nNO_IFTTT\u003dNo need to update base/debug/stack_trace.h\n\nBug: 378069401\nChange-Id: I838a8c44e82ed27dc75e771acec31d84992860af\nR: dcheng@chromium.org\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038951\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Alexei Svitkine \u003casvitkine@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1394163}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b7c1fd51e13bbaee378c9a0e188050ec9893c01b\n" }, { "commit": "b3f1ac14f8165274fecf24845e05fdf48740f7e9", "tree": "31b5f5a4b92791333fc1eb6b02dbf9233d206672", "parents": [ "58a1c3c248419ec8fde00f4ecff3d280add0959d" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Mon Dec 09 08:22:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 09 08:31:55 2024" }, "message": "Use is_chromeos in //components/{feed|feedback|filename_generation ..\n\n... guest_view|input|language}\n\nLacros is deprecated, usage of is_chromeos_ash is discouraged.\n\nBug: Bug: 375523816, 373972275\nChange-Id: I8e7b62d264d5111f2a83fcac678431ff39ff669b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6074380\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Georg Neis \u003cneis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1393537}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 183e6181197c270489eeb123c9debe6566bb9b3b\n" }, { "commit": "58a1c3c248419ec8fde00f4ecff3d280add0959d", "tree": "687c576b05e8baf769c5086ecd4163ef12e89725", "parents": [ "398ca5b9cb17acde623e5e66951384a435f64834" ], "author": { "name": "Steven Bennetts", "email": "stevenjb@chromium.org", "time": "Tue Nov 19 19:14:22 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 19 19:22:55 2024" }, "message": "RedactionTool: reuse the ipv4 RE\n\nBUG\u003d376612463\nTEST\u003dcomponents_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: I6dfb1f28ea244f0a28cdf4504726ffe6f6ad003a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033689\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Etienne Bergeron \u003cetienneb@chromium.org\u003e\nCommit-Queue: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1385122}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b35ed12c818520da5cfaf8279bba283b22c2e40c\n" }, { "commit": "398ca5b9cb17acde623e5e66951384a435f64834", "tree": "ece03dc207fc1b9c5bfd9c03eaa86f408f30d2f7", "parents": [ "4f0875c13b869a4e6a95cc7c0f6aa4fd7048b419" ], "author": { "name": "Arkadiusz Tomczak", "email": "artomczak@google.com", "time": "Fri Oct 11 14:54:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 11 15:01:15 2024" }, "message": "Deprecate UMA Histogram Medium Times macro.\n\nThere are two separate UMA logging implementations named variants of \"UMA Histogram Medium Times\" that are bucketed differently. The intent is to have macros and functions with matching names to be identical. Therefore we are deprecating existing macro and will reintroduce it in the following cl with a definition matching the function.\n\nNO_IFTTT\u003d\"Only changed the comment, not the function definition, in base/metrics/histogram_functions.h \"\n\nBug: 353712922\nChange-Id: I8bfd900e3f49fe865c80b6a2f100feee61174c5e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898922\nCommit-Queue: Arkadiusz Tomczak \u003cartomczak@google.com\u003e\nReviewed-by: Denis Kuznetsov \u003cantrim@chromium.org\u003e\nReviewed-by: Yi Gu \u003cyigu@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nReviewed-by: Kenneth Russell \u003ckbr@chromium.org\u003e\nReviewed-by: Luc Nguyen \u003clucnguyen@google.com\u003e\nReviewed-by: Emilia Paz \u003cemiliapaz@chromium.org\u003e\nReviewed-by: Adam Rice \u003cricea@chromium.org\u003e\nReviewed-by: David Roger \u003cdroger@chromium.org\u003e\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nReviewed-by: Kinuko Yasuda \u003ckinuko@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Sophie Chang \u003csophiechang@chromium.org\u003e\nReviewed-by: Éric Noyau \u003cnoyau@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1367528}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1363905e2e2f3fb3dcde62648ef8e6a2fe01ed0e\n" }, { "commit": "4f0875c13b869a4e6a95cc7c0f6aa4fd7048b419", "tree": "5a0cd0786480d84ab65b38fcec5d261a45c9f38e", "parents": [ "af3e2080f0cccb7ffe98fdc038a1073b97bbeb52" ], "author": { "name": "Steven Bennetts", "email": "stevenjb@chromium.org", "time": "Mon Oct 07 20:00:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 07 20:07:51 2024" }, "message": "RedactionTool: Use context for IPv4 addresses.\n\nCurrently any 4 octets separated by \u0027.\u0027 are identified as\nIP addresses, including version numbers in the form\n1.2.3.4.5 or 1-2.3.4.5.\n\nThis adds context to IPv4 redaction to avoid these false\npositives and adds tests for the above cases.\n\nBUG\u003db:366025451\nTEST\u003dcomponents_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: Iaeb437f9741c42e42b8572ed7bf17dcbda3e84f7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892961\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1365103}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 45d007f29e6bbe5b0131a16fbbb149afe88c8c70\n" }, { "commit": "af3e2080f0cccb7ffe98fdc038a1073b97bbeb52", "tree": "50839deb3afbf586e2f5a6fd2bb7c7d20d59a0c0", "parents": [ "8bb9cf715d6344491b70366dad723893450c6abb" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Oct 02 21:54:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 07 20:07:25 2024" }, "message": "Remove stray const when passing std::string_view arguments.\n\nThese may be remnants from a time before string_view when a const\nchar* would have made sense. Now the const doesn\u0027t matter.\n\nFully automated change.\n\nChange-Id: I2dfc7ce30a54701639535a4f137dc18e71575fe2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906184\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1363323}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b55f2f1f5e65a3f2da4ded9337553c7b37169e39\n" }, { "commit": "8bb9cf715d6344491b70366dad723893450c6abb", "tree": "301a678d74bdd4d16c432163ce1c9b1574c75578", "parents": [ "bf208b3563bd0af32df0f41fa3fda439ff11cc2f" ], "author": { "name": "Steven Bennetts", "email": "stevenjb@chromium.org", "time": "Thu Sep 26 17:56:42 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 26 18:17:08 2024" }, "message": "RedactionTook: Format file and move macros\n\nThis is some prep work for a linked follow-up change.\nThere are no logical changes in this CL.\n\nBUG\u003db:366025451\nTEST\u003dcomponents_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: Ie21438c43fa2cad48d1f0b94622ab3c0a3affee0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892422\nAuto-Submit: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1360651}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f6237d64721d2942df7fc461d4c2217ca25f003d\n" }, { "commit": "bf208b3563bd0af32df0f41fa3fda439ff11cc2f", "tree": "969504f42584482c712e7d0e2c506e55ca3ade8f", "parents": [ "bee1095f66f6e376fe6e1d4f55d8068c97a4bb59" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Wed Jul 31 08:29:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 31 08:34:22 2024" }, "message": "spanification: Add `#pragma allow_unsafe_buffers` to component/*\n\nSee `//docs/unsafe_buffers.md`\n\nThis is a preparation to fix each files.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nAX-Relnotes: n/a.\nBug: 40285824\nChange-Id: I24ff0aee7a6cbe6da11a08830135449ccf8f2ae2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5717711\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Cait Phillips \u003ccaitkp@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1335315}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b948e67a9c2fa2f8adff2206ef00cccde3f8640a\n" }, { "commit": "bee1095f66f6e376fe6e1d4f55d8068c97a4bb59", "tree": "0f12466dc4230f6ae2d5a55ee575023de21175d7", "parents": [ "2c45be11975145e5fb97f33c2d4e3c12dc9c457c" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Thu Jul 11 17:18:55 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 11 17:27:29 2024" }, "message": "Remove unneeded StringPiece header usage\n\nBug: 40506050\nChange-Id: I15636e78efea9243ad7c13c9e91e82d683f70a35\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688848\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Helmut Januschka \u003chelmut@januschka.com\u003e\nCommit-Queue: Helmut Januschka \u003chelmut@januschka.com\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1326238}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5452f216fc8465fcb0a20970e617edcbf897d1ed\n" }, { "commit": "2c45be11975145e5fb97f33c2d4e3c12dc9c457c", "tree": "98266d9ebf024af6fe82677e4c76323416b99346", "parents": [ "b7e4c7300ca1b03b1fd36d875168f6717ea159b4" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Mon Jun 17 20:05:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 17 20:12:40 2024" }, "message": "[CC Number Validation Target] Common validator in redaction tool (8/8)\n\nThis patch removes the outdated version of credit card number validation\nfrom the redaction tool and updates it to use the common credit card\nnumber validator from the new autofill target that has minimal\ndependencies, so it can be copied into ChromeOS.\n\nDesign doc: https://bit.ly/cc-number-validation-target-dd\n\nBug: b:281812289\nChange-Id: I48fe34eaabc5fc716753c9f39f513ee7a1affaeb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5626593\nReviewed-by: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nReviewed-by: Jimmy Gong \u003cjimmyxgong@chromium.org\u003e\nCommit-Queue: Rouslan Solomakhin \u003crouslan@chromium.org\u003e\nReviewed-by: Rouslan Solomakhin \u003crouslan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1316043}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 92f0fdb3f3516c145da5c2c3abe7762b9575f821\n" }, { "commit": "b7e4c7300ca1b03b1fd36d875168f6717ea159b4", "tree": "c425e041e42befb1a511d3e5517f4a35d11f2263", "parents": [ "4d0bef644311ff233df2687d3be90ecc2188fa1f" ], "author": { "name": "Vipul Vinod Koul", "email": "koulvipul@google.com", "time": "Thu May 16 20:56:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 16 21:03:55 2024" }, "message": "[Verve] Update the validation checks for Verve cards\n\nThe length checks for Verve cards are sourced from open web-\nhttps://en.wikipedia.org/wiki/Payment_card_number\n\nThis change is also duplicated in the feedback redaction\nvalidation codebase based on the comments. Also the BIN ranges for Verve\nand Discover collide at \"65\" but since the Verve BIN ranges are more\ndetailed, it will be searched first. This approach was used previously\nto remove collisions for Discover and Elo in credit_card.cc.\n(https://chromium-review.googlesource.com/c/chromium/src/+/4225129)\n\nFixed: 336652048\nChange-Id: I6a80e292f61f0348865f479ba32d187d4e74aacb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530982\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Olivia Saul \u003cjsaul@google.com\u003e\nReviewed-by: Rouslan Solomakhin \u003crouslan@chromium.org\u003e\nCommit-Queue: Vipul Koul \u003ckoulvipul@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1302212}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 766ed1f33c30391d45bee2a72f3789ce4e888a8a\n" }, { "commit": "4d0bef644311ff233df2687d3be90ecc2188fa1f", "tree": "ed2bfda687d7844d2ee667ec9360c54361db3f12", "parents": [ "89e0ffb9a25633b33a55bf89c4563c8128feeaa9" ], "author": { "name": "Rohit Kapoor", "email": "rohkap@google.com", "time": "Wed May 15 18:53:55 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 15 19:01:41 2024" }, "message": "Redaction Tool: Redaction Tool Caller Metric: Breakdown the Feedback Tool and Crash Tool metrics into components for easier analysis.\n\nBug: 338447818\nChange-Id: I8a91345618967e62e0f1dfcc67376515d5063ca4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5535317\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Jimmy Gong \u003cjimmyxgong@chromium.org\u003e\nCommit-Queue: Rohit Kapoor \u003crohkap@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1301473}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c88e857c6d4a5c36eaff483d0d70ac439b0a691c\n" }, { "commit": "89e0ffb9a25633b33a55bf89c4563c8128feeaa9", "tree": "4d87dbafa098b88785336fc147cc473fe0e09f39", "parents": [ "a0eaf6213000a3fc129d9ad16e02041057b4186d" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Fri May 10 18:51:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 10 19:00:51 2024" }, "message": "Convert base::StringPiece to std::string_view in //components 5/5\n\nThe changes of this CL are made using the following script.\nScript: https://issues.chromium.org/issues/40506050#comment343\n\nBug: 40506050\nChange-Id: I8df4dd9fdd0f44ab37b779ebdfe203e28a2e4bf2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501956\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Helmut Januschka \u003chelmut@januschka.com\u003e\nCr-Commit-Position: refs/heads/main@{#1299407}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fa9871dea2815a63b9742308baa5074985b17eea\n" }, { "commit": "a0eaf6213000a3fc129d9ad16e02041057b4186d", "tree": "0fc92a530598f8db2d109b8c545a98e8f99fcbc8", "parents": [ "1fec13e91321c3795ebfc28d5fca14073662fbbf" ], "author": { "name": "Rohit Kapoor", "email": "rohkap@google.com", "time": "Thu May 09 17:02:01 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 09 17:10:26 2024" }, "message": "Redaction Tool: RedactionToolCaller metric: Adding an entry for Crash Tool and deprecating the entry for browser system logs since they map to Feedback tool\n\nBug: 338447818\nChange-Id: Ieb7823d3b300ee23ad08e6fd2dcfa227a54e70b3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513122\nReviewed-by: Chris Mullins \u003ccrmullins@chromium.org\u003e\nCommit-Queue: Rohit Kapoor \u003crohkap@google.com\u003e\nAuto-Submit: Rohit Kapoor \u003crohkap@google.com\u003e\nReviewed-by: Jimmy Gong \u003cjimmyxgong@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1298686}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9fb8694111a56a17a9877b589a4bbe9e171b6087\n" }, { "commit": "1fec13e91321c3795ebfc28d5fca14073662fbbf", "tree": "77e7b213f21a4892eb8509047eebfabf721702b4", "parents": [ "c08bb40410e1fa358ea85de4215be6a7966d0175" ], "author": { "name": "Rohit Kapoor", "email": "rohkap@google.com", "time": "Wed Apr 10 22:18:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 10 22:24:45 2024" }, "message": "Minor update to the order of checks to absorb previous comment\n\nTest: tools/autotest.py -C out/Default --run_all /usr/local/google/home/rohkap/chromium/src/components/feedback/redaction_tool/redaction_tool_unittest.cc\n\nBug: 318878100\nChange-Id: I4d20abf8ad107f90d3bd21fe17f6fa299c9679f0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439777\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Rohit Kapoor \u003crohkap@google.com\u003e\nReviewed-by: Chris Mullins \u003ccrmullins@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1285451}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 66c37b5448c3b8aa565d6a35785d8e02945c5de8\n" }, { "commit": "c08bb40410e1fa358ea85de4215be6a7966d0175", "tree": "4557e3f3230e1583ff44e4df81e3fec9e0b2f074", "parents": [ "9aea97d8eea25ee0ac7ac559916442897270f14a" ], "author": { "name": "Brian Granaghan", "email": "granaghan@google.com", "time": "Thu Jan 25 21:42:45 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 25 21:50:14 2024" }, "message": "redaction_tool: Redact GSC dev ids, serial, and memory dumps.\n\nBUG\u003db:286427956\nTEST\u003dcomponents_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: I3992582de7ec590806397a7d9cf65863a727983c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5201562\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Ahmed Fakhry \u003cafakhry@chromium.org\u003e\nCommit-Queue: Brian Granaghan \u003cgranaghan@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1252340}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4395cf4e2ae46f6ce4fdc858ec00642af626a8c0\n" }, { "commit": "9aea97d8eea25ee0ac7ac559916442897270f14a", "tree": "4bac99f17d93b6bdbcb7977206f698e5e87c0f73", "parents": [ "49ccf84dcde4b91e51c6cef9ea4e996bdf403be1" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Thu Jan 25 12:49:39 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 25 12:56:39 2024" }, "message": "Reland^2 \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\n\nIt reverts the revert commit 89730423d1288fbd719f41205617ae79e1180c75\n*and* undoes the rewrites in lock_impl.h (see PS2), which caused\ncrbug.com/1520734, possibly crbug.com/1518884 and regressions in\ncrbug.com/1519816 (and merged issues).\n\nOriginal change\u0027s description:\n\u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e\n\u003e PS1: automated rewrite\n\u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e PS8-PS20: apply DanglingUntriaged\n\u003e PS21: unrewrite to undo binary size increase\n\u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e\n\u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e longer apply. But also, the rewriter changed too:\n\u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e was added)\n\u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e\n\u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e comments, e.g.:\n\u003e // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e One comment per block of fields will suffice, if the reason is the\n\u003e same throughout, and no other comments are added in between.\n\u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e because\" blurb), and improved scriptability.\n\u003e\n\u003e Bug: 1446392\n\u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\nBug: 1446392\nChange-Id: I2a2e8d97763d4ac8b7528359587689fd48e300dc\nDanglingUntriaged-notes: automated rewrite.\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232280\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1252024}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f5eeebaebe332e71aadfd5c43ec485cb23f0c7f8\n" }, { "commit": "49ccf84dcde4b91e51c6cef9ea4e996bdf403be1", "tree": "13c711cec95213a06dc02f5b0200c7d1e48dec5b", "parents": [ "893505b24d818aa9da6cb1e82bba60863c0b72fc" ], "author": { "name": "Jeremie Boulic", "email": "jboulic@chromium.org", "time": "Tue Jan 23 10:42:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 23 10:48:25 2024" }, "message": "Revert \"Reland \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\"\n\nThis reverts commit 2f0511e7fd0d0ddb1632b5f418fc7b197fdd733c.\n\nReason for revert: Suspected culprit - The linux debug bot started becoming consistently red around the time this change has landed https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29\nSee crbug.com/1520734\n\nOriginal change\u0027s description:\n\u003e Reland \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\n\u003e\n\u003e This reverts commit d23c94321e2367736cafdaf0395782c97e775af7.\n\u003e\n\u003e Retrying based on gpu-fyi-try-mac-nvidia-retina-rel passing and\n\u003e http://crbug/1518884#c7 that suggests that CI has been seen passing\n\u003e even before the revert.\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e \u003e\n\u003e \u003e PS1: automated rewrite\n\u003e \u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e \u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e \u003e PS8-PS20: apply DanglingUntriaged\n\u003e \u003e PS21: unrewrite to undo binary size increase\n\u003e \u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e \u003e\n\u003e \u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e \u003e longer apply. But also, the rewriter changed too:\n\u003e \u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e \u003e was added)\n\u003e \u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e \u003e since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e \u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e \u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e \u003e\n\u003e \u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e \u003e comments, e.g.:\n\u003e \u003e // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e \u003e // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e \u003e // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e \u003e One comment per block of fields will suffice, if the reason is the\n\u003e \u003e same throughout, and no other comments are added in between.\n\u003e \u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e \u003e because\" blurb), and improved scriptability.\n\u003e \u003e\n\u003e \u003e Bug: 1446392\n\u003e \u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e \u003e DanglingUntriaged-notes: automated rewrite.\n\u003e \u003e AX-Relnotes: n/a.\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e \u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e \u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e \u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e \u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e \u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\u003e\n\u003e Bug: 1446392, 1518884\n\u003e Change-Id: I601122a00cb99ce03be6a07d98093da6a5aa3831\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202674\n\u003e Auto-Submit: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Owners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1249220}\n\nBug: 1446392, 1518884, 1520734\nChange-Id: I168d917f2b53debff8b3dee062662184faf10b41\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224145\nOwners-Override: Jeremie Boulic \u003cjboulic@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nAuto-Submit: Jeremie Boulic \u003cjboulic@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Filipa Senra \u003cfsenra@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1250727}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 89730423d1288fbd719f41205617ae79e1180c75\n" }, { "commit": "893505b24d818aa9da6cb1e82bba60863c0b72fc", "tree": "4bac99f17d93b6bdbcb7977206f698e5e87c0f73", "parents": [ "6b1efd78c412e053ca0501eae3c37cd16de80415" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Fri Jan 19 03:27:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 19 03:39:05 2024" }, "message": "Reland \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \u0027refresh\u0027\"\n\nThis reverts commit d23c94321e2367736cafdaf0395782c97e775af7.\n\nRetrying based on gpu-fyi-try-mac-nvidia-retina-rel passing and\nhttp://crbug/1518884#c7 that suggests that CI has been seen passing\neven before the revert.\n\nOriginal change\u0027s description:\n\u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e\n\u003e PS1: automated rewrite\n\u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e PS8-PS20: apply DanglingUntriaged\n\u003e PS21: unrewrite to undo binary size increase\n\u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e\n\u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e longer apply. But also, the rewriter changed too:\n\u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e was added)\n\u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e\n\u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e comments, e.g.:\n\u003e // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e One comment per block of fields will suffice, if the reason is the\n\u003e same throughout, and no other comments are added in between.\n\u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e because\" blurb), and improved scriptability.\n\u003e\n\u003e Bug: 1446392\n\u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\nBug: 1446392, 1518884\nChange-Id: I601122a00cb99ce03be6a07d98093da6a5aa3831\nDanglingUntriaged-notes: automated rewrite.\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202674\nAuto-Submit: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249220}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2f0511e7fd0d0ddb1632b5f418fc7b197fdd733c\n" }, { "commit": "6b1efd78c412e053ca0501eae3c37cd16de80415", "tree": "13c711cec95213a06dc02f5b0200c7d1e48dec5b", "parents": [ "09af232364bd3b6ccca4a824d361319ed696c247" ], "author": { "name": "Brian Sheedy", "email": "bsheedy@chromium.org", "time": "Wed Jan 17 01:02:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 17 01:07:25 2024" }, "message": "Revert \"Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\"\n\nThis reverts commit e407f3d9855a6a063eb8ea661a12b3f9d0a1e228.\n\nReason for revert: Cause of crbug.com/1518884\n\nOriginal change\u0027s description:\n\u003e Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\u003e\n\u003e PS1: automated rewrite\n\u003e PS2-PS5,PS7: unrewrite to fix compilation\n\u003e PS6,PS22: unrewrite non-automated exclusions\n\u003e PS8-PS20: apply DanglingUntriaged\n\u003e PS21: unrewrite to undo binary size increase\n\u003e PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\u003e\n\u003e The code has changed since the \"big rewrite\" so some exclusions no\n\u003e longer apply. But also, the rewriter changed too:\n\u003e - No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n\u003e   was added)\n\u003e - union exclusion has been waived for std::optional and absl::variant,\n\u003e   since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n\u003e - Certain paths under //base are no longer need to be excluded, as\n\u003e PartitionAlloc/raw_ptr no longer depends on them\n\u003e\n\u003e This CL also tries to popularize a better format of exclusion reasoning\n\u003e comments, e.g.:\n\u003e   // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n\u003e   // RAW_PTR_EXCLUSION: Performance reasons ...\n\u003e   // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\n\u003e One comment per block of fields will suffice, if the reason is the\n\u003e same throughout, and no other comments are added in between.\n\u003e This format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\n\u003e because\" blurb), and improved scriptability.\n\u003e\n\u003e Bug: 1446392\n\u003e Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\n\u003e DanglingUntriaged-notes: automated rewrite.\n\u003e AX-Relnotes: n/a.\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\n\u003e Reviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Commit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\n\u003e Code-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1247373}\n\nBug: 1446392, 1518884\nChange-Id: I7e5bbd0f4cbd5731ffa2cfaa24c76b17881960c3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5201861\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Tsuyoshi Horo \u003choro@chromium.org\u003e\nCommit-Queue: Tsuyoshi Horo \u003choro@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1247869}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d23c94321e2367736cafdaf0395782c97e775af7\n" }, { "commit": "09af232364bd3b6ccca4a824d361319ed696c247", "tree": "4bac99f17d93b6bdbcb7977206f698e5e87c0f73", "parents": [ "ad6ce0b0722c3b605697c019a53c9a2171c909ba" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Tue Jan 16 06:07:26 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 16 06:12:33 2024" }, "message": "Automated T* -\u003e raw_ptr\u003cT\u003e rewrite \"refresh\"\n\nPS1: automated rewrite\nPS2-PS5,PS7: unrewrite to fix compilation\nPS6,PS22: unrewrite non-automated exclusions\nPS8-PS20: apply DanglingUntriaged\nPS21: unrewrite to undo binary size increase\nPS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes \u0026 comments\n\nThe code has changed since the \"big rewrite\" so some exclusions no\nlonger apply. But also, the rewriter changed too:\n- No longer applies constexpr-related exclusions (raw_ptr\u003c\u003e support\n  was added)\n- union exclusion has been waived for std::optional and absl::variant,\n  since they invoke raw_ptr\u003c\u003e\u0027s ctor/dtor correctly\n- Certain paths under //base are no longer need to be excluded, as\n PartitionAlloc/raw_ptr no longer depends on them\n\nThis CL also tries to popularize a better format of exclusion reasoning\ncomments, e.g.:\n  // RAW_PTR_EXCLUSION: #addr-of, #global-scope\n  // RAW_PTR_EXCLUSION: Performance reasons ...\n  // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason\nOne comment per block of fields will suffice, if the reason is the\nsame throughout, and no other comments are added in between.\nThis format has advantages, like brevity (no more \"not a raw_ptr\u003c\u003e\nbecause\" blurb), and improved scriptability.\n\nBug: 1446392\nChange-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce\nDanglingUntriaged-notes: automated rewrite.\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661\nReviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1247373}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e407f3d9855a6a063eb8ea661a12b3f9d0a1e228\n" }, { "commit": "ad6ce0b0722c3b605697c019a53c9a2171c909ba", "tree": "13c711cec95213a06dc02f5b0200c7d1e48dec5b", "parents": [ "4e80eb8e9a87a9db4a267da3852c8eec49990e19" ], "author": { "name": "Rohit Kapoor", "email": "rohkap@google.com", "time": "Tue Jan 09 23:55:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 10 00:29:50 2024" }, "message": "redaction tool : add metrics about the caller of the tool\n\nBug: 316631972\nChange-Id: I365df3356a560b1d1e1326fe5ae746e3976eef19\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5126712\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nAuto-Submit: Rohit Kapoor \u003crohkap@google.com\u003e\nCommit-Queue: Rohit Kapoor \u003crohkap@google.com\u003e\nReviewed-by: Chris Mullins \u003ccrmullins@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1244975}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 31bc3fbde7185471eaa1f88ee0808c2d59391d6c\n" }, { "commit": "4e80eb8e9a87a9db4a267da3852c8eec49990e19", "tree": "9a5a7cb551f07ff336c97591cc36b2d6de03c346", "parents": [ "cbfb0f613b6eb257dc38a519ed22b1539966414f" ], "author": { "name": "Matthias Kaehlcke", "email": "mka@chromium.org", "time": "Tue Dec 19 16:21:29 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 19 16:30:33 2023" }, "message": "redaction_tool: Redact partial user id hashes from cryptohome device names\n\nThe name of Cryptohome storage devices include a partial hash\nof the user id, e.g.:\n\n dmcrypt-0d9a4e74-data\n E7341N6FNEYIR2CX-cryptohome--0d9a4e74--data\n\nRedact these partial hashes.\n\nBug: b:309001479\nTest: components_unittests --gtest_filter\u003dRedactionToolTest.*\n\nChange-Id: I67ca648f4eaa467657fd17da8ab49bc0b06affeb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5124299\nReviewed-by: Brian Geffon \u003cbgeffon@chromium.org\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCommit-Queue: Matthias Kaehlcke \u003cmka@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1239174}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3b6a95131621253de89f07b3900b40f76b3302ef\n" }, { "commit": "cbfb0f613b6eb257dc38a519ed22b1539966414f", "tree": "0a3254246f227008667ffae2ddeb79ef06f4d1d6", "parents": [ "8f6e1f305c7b7102c7e01f589393fadd6e4dd4f6" ], "author": { "name": "shaochenguang", "email": "chenguangshao1@gmail.com", "time": "Wed Nov 29 23:57:17 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 30 00:06:59 2023" }, "message": "Fix header guards in components/.\n\nGenerated mechanically as follows:\n\ngit ls-files \u0027*.h\u0027 | grep -E \u0027^components/\u0027 | \\\n xargs parallel cpplint.py --filter\u003d-,+build/header_guard -- 2\u003e\u00261 | \\\n grep build/header_guard | tools/apply_cpplint_header_guard.py\n\nBug: 1200694\nChange-Id: I7d365e54e01292ebddadb3486494d4b8b729e38f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5051991\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ted Choc \u003ctedchoc@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1231006}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 61f8f1d8975b12f218bfb059d867178de02af5f9\n" }, { "commit": "8f6e1f305c7b7102c7e01f589393fadd6e4dd4f6", "tree": "080c2ad86f3c7ec81d8262ac6efc9313179464df", "parents": [ "10f3d2b4985e66747af5b5bd8fe244f2a7d3ca42" ], "author": { "name": "Benson Leung", "email": "bleung@google.com", "time": "Tue Sep 26 01:15:25 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 26 01:22:17 2023" }, "message": "redaction_tool: Add support for lsusb\u0027s and usbguard\u0027s output as serial nums.\n\nlsusb --verbose outputs a line in the following format (in C printf format):\n\" iSerial %5u %s\\n\"\n\nusbguard also prints a serial number, with the word \"serial\" plus a space,\nand then the serial number in double quotes.\n\nUpdate unittests to add expected redact cases for lsusb and usbguard output.\n\nBUG\u003db:288439908\nTEST\u003dAll unittests pass, especially RedactionToolTest.RedactCustomPatterns.\n\nChange-Id: I9aaa7638d8059b3dc9eef300f24ad36dd75b0f15\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879370\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Benson Leung \u003cbleung@google.com\u003e\nCommit-Queue: Benson Leung \u003cbleung@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1201283}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 112cd5613ed0ddba8086bbb2568e884c977f8e1c\n" }, { "commit": "10f3d2b4985e66747af5b5bd8fe244f2a7d3ca42", "tree": "adb6c0dc1f9b4b929382db5f94fba62a73d75d3e", "parents": [ "2b5c69b3676993a4dcc0cc708aad40694d3c8904" ], "author": { "name": "seobrien", "email": "seobrien@google.com", "time": "Fri Sep 15 22:28:52 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 15 22:34:42 2023" }, "message": "redaction_tool: Do not match line breaks in PSM ID\n\nThe matching rule for PSM identifiers will sometimes match part of\nbase64-encoded data. We currently will match any whitespace character,\nincluding line breaks. This CL removes line break matching.\n\nBug: b:282166518\nChange-Id: I926ff69df98a230bb0dd2cdf9e71751ada7006f5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864692\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nReviewed-by: Jimmy Gong \u003cjimmyxgong@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1197407}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 63959d39f039028cc51e9e11308c39dc05a29535\n" }, { "commit": "2b5c69b3676993a4dcc0cc708aad40694d3c8904", "tree": "1890bd1c34409e1cbb623bdb1b8e7cc30a0e719d", "parents": [ "5753ee84465a5eb5a474ec97e209eb4c711930b9" ], "author": { "name": "Sarthak Kukreti", "email": "sarthakkukreti@google.com", "time": "Tue Sep 12 23:33:24 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 12 23:41:24 2023" }, "message": "redaction_tool: Add LVM UUIDs\n\nvgcfgbackup can contain non-standard LVM UUIDs\n\nBug: b:232006113\nChange-Id: I3a0508e9996387c8398fff7b7de041df76dede28\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803919\nReviewed-by: Miriam Zimmerman \u003cmutexlox@chromium.org\u003e\nCommit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nAuto-Submit: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1195708}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a3c29a9533620caa39f742ec4e8b45148194c187\n" }, { "commit": "5753ee84465a5eb5a474ec97e209eb4c711930b9", "tree": "915695673f1e01f93186fe5e7b71cdb3103f1629", "parents": [ "9af86212ab8c517bf524b1887161bd6898d63e1c" ], "author": { "name": "xiangdong kong", "email": "xiangdongkong@google.com", "time": "Mon Sep 11 21:04:35 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 11 21:12:36 2023" }, "message": "redaction_tool: modified the regex capturing URLs\n\nIt anonymizes memory dump data incorrectly.\n\nBefore the change, the following string will be anonymized to\n\"active_(URL: 1) inactive_(URL: 2)\":\n\n- active_file:7652 inactive_file:193577.\n\nThis is the problem: the \"//\" is inside of the non capturing group.\nMove the \"//\" out to outside of the NCG to fix the issue.\n\n- It will match \"file://..\" (: followed by //).\n- It won\u0027t match \"file:...\" (\"non // after :).\n\nBug: 298029555\nTest: out/Default/components_unittests --gtest_filter\u003dRedactionToolTest.*\nChange-Id: I9a9bd5ecdb408e3e0d92f83c24f3005b6aac21f9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4846719\nReviewed-by: Brian Geffon \u003cbgeffon@chromium.org\u003e\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1195045}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2610e525378a3811d2c417ec6e1e39c2629d807c\n" }, { "commit": "9af86212ab8c517bf524b1887161bd6898d63e1c", "tree": "cda565ee6c580a29afb0defe6eaca5883e7372ab", "parents": [ "f577339cbc0a9529667f861a29479eb04b5e5617" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Thu Aug 31 20:20:34 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 31 20:27:54 2023" }, "message": "Replace re2::StringPiece with std::string_view\n\nThey\u0027re the same type nowadays. I\u0027ve replaced all uses except\n//third_party/maldoca as that seems to be a standalone library.\n\nBug: 1447090\nChange-Id: Ib6974182145f3538021b868a2f06d80b07d9ed72\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4826026\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Kelvin Jiang \u003ckelvinjiang@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Dominic Battre \u003cbattre@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1190948}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8357e4cbfdf74e12426417b65df775760ee4a03b\n" }, { "commit": "f577339cbc0a9529667f861a29479eb04b5e5617", "tree": "15c5aa32d064a871339e640780343906e5f3201b", "parents": [ "1eebee022e5afe102685d6560f6d88a22f0b928e" ], "author": { "name": "Nacho Coloma", "email": "icoloma@google.com", "time": "Mon Aug 07 13:24:55 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 07 13:30:44 2023" }, "message": "support-tool: Add SigninDataCollector\n\nThis Data Collector writes the signin internals information into\na temporary signin.json file, detecting and optionally redacting Gaia IDs and other PII.\n\nBug: b/236118965\nChange-Id: I90146e5a68ae10750b17d6a1997dc85d5b4a1081\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437909\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Irem Uguz \u003ciremuguz@google.com\u003e\nCommit-Queue: Nacho Coloma \u003cicoloma@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1180248}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1ed16d82a6be47c9791159fffec4772f63d556c6\n" }, { "commit": "1eebee022e5afe102685d6560f6d88a22f0b928e", "tree": "3735aeb609e4a932688dc8b0f3342434e23a58fa", "parents": [ "9422ac15672523ecb550e93308a08c3c8bb71654" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Tue Aug 01 20:32:26 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 01 20:40:45 2023" }, "message": "Use InlinedVector in /components/feedback\n\nReplace usages of base::StackVector with absl::InlinedVector. This is\nnot a pure rename, as the semantics are slightly different:\n\n1. Methods like push_back() which were accessed with the -\u003e operator in\n StackVector are instead accessed with . with InlinedVector.\n\nSee also discussion thread in cxx@chromium.org:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/jTfqVfU-Ka0/m/caaal90NCgAJ\n\nThis CL was uploaded by git cl split.\n\nR\u003dzentaro@chromium.org\n\nBug: 1465736\nChange-Id: Ibc06064a7e6edd83d9e6694c770624f9d07718db\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4707685\nReviewed-by: Jimmy Gong \u003cjimmyxgong@chromium.org\u003e\nAuto-Submit: Adam Rice \u003cricea@chromium.org\u003e\nCommit-Queue: Jimmy Gong \u003cjimmyxgong@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1178045}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bcad104cce7cd30925e277a4c6c8c70047cadb4f\n" }, { "commit": "9422ac15672523ecb550e93308a08c3c8bb71654", "tree": "b7ae92319ad13886b65f93116f767f1a1944206b", "parents": [ "178060be0f3295c2be33db6ab82513b08b6b6160" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Mon Jul 10 17:08:27 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 10 17:13:34 2023" }, "message": "redaction_tool: Add UMA metric measuring time to redact input\n\nWith the growing list of redactions we want to make sure that we aren\u0027t\nrunning them too long in the background negatively impacting the users\nexperience after a report.\n\nBug: b:281836883\nChange-Id: I57b0ddc9c16ebb7e0d51eb34d6c6c72cef4be2f9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4659509\nCommit-Queue: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nAuto-Submit: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1168164}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 90474d2c06f2855b648a78518124a00027464354\n" }, { "commit": "178060be0f3295c2be33db6ab82513b08b6b6160", "tree": "40dbe2361019915e2962d03cc72c6a74e7a22395", "parents": [ "3a27743c2a97fceebbb013898ba3db5626bfc0c3" ], "author": { "name": "xiangdong kong", "email": "xiangdongkong@google.com", "time": "Thu Jul 06 18:31:18 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 06 18:38:20 2023" }, "message": "redaction_tool: Fix a SSID pattern truncating Net logs issue\n\nThe original regex causing the truncation was: (\\\\* SSID\u003d)(.+)($).\n\nThe reason was the regex matching has enabled multiple-lines option.\nAll the lines after the SSID line will then be treated as part of the\nSSID.\n\nChange it to \"(\\\\* SSID\u003d)([^\\n]+)(.*)\" so that SSID part will stop\ntaking characters once encountering a newline.\n\nBug: b:231631847\nTest: components_unittests --gtest_filter\u003dRedactionToolTest.*\nChange-Id: Id118ceb8ef4ddc1c9cac4ebc0ec6c811f373d487\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4661398\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1166679}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fffb9b47a1847ba8fa7e3f06232f1fb3597274fa\n" }, { "commit": "3a27743c2a97fceebbb013898ba3db5626bfc0c3", "tree": "e483da1328f30c0fcb1fd61abc95432ca71dd3da", "parents": [ "5c8ef9333208f568437aaee3a3857d1a93f017bf" ], "author": { "name": "xiangdong kong", "email": "xiangdongkong@google.com", "time": "Thu Jul 06 18:15:22 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 06 18:20:15 2023" }, "message": "redaction_tool: Add a test using input from a data file\n\nThis will make it easier to test more scenario and to troubleshoot\nredaction issues.\n\nFor example, it was reported that Net logs are getting truncated by\nSSID redaction logic. The unit test did not catch it. It took lots of\nefforts to understand why (http://b/228639407). Now we just need to add\nsample log to the test files, run the unit test, and reproduce the\nissue.\n\nBug: b:231631847\nTest: components_unittests --gtest_filter\u003dRedactionToolTest.*\nChange-Id: I0561d0fce0a12292a1ff7e90d07a3c23821e1560\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4660005\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1166668}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 951470bf43e2a62a762224ccb87715a88e3d0930\n" }, { "commit": "5c8ef9333208f568437aaee3a3857d1a93f017bf", "tree": "98dee577996a8e5cb189046a5e8078bd954cf369", "parents": [ "74e5b4af35ab8ec79d71ac0e7d831f0c321279fb" ], "author": { "name": "xiangdong kong", "email": "xiangdongkong@google.com", "time": "Fri Jun 30 20:25:02 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 30 20:31:57 2023" }, "message": "redaction_tool: Redact crash IDs\n\nwith this pattern: \"Crash report receipt ID \u003chex number\u003e\".\n\nChromeOS\u0027s crash sender logs the crash report IDs using this format in\n/var/log/messages.\n\nBug: b:287496842\nTest: components_unittests --gtest_filter\u003dRedactionToolTest.*\nChange-Id: I7560380d68b61af8e9db49bf0438b522ccd20ce7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4661475\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1164881}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 501f3281900150d33b5e87a74f7400c165b5f8c4\n" }, { "commit": "74e5b4af35ab8ec79d71ac0e7d831f0c321279fb", "tree": "a964e38e259286af99908391603aee28309624a5", "parents": [ "87237a881d56cc6fbd9361fa413d0670b8ca110e" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Tue Jun 27 10:38:09 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 27 10:51:35 2023" }, "message": "redaction_tool: Verify that metrics are collected for all PII\n\nUntil chromium:4520920 metrics were not only collected when PII was\nredacted but all the time.\nThis should prevent us from regressing and guide new PII additions.\n\nBug: b:285247746\nChange-Id: Ib438a705020f0e6b2b563a1f20c0c110e066ed6b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582490\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1162865}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0da0c644b10e1cd2cb9e1b98e018e35446ade851\n" }, { "commit": "87237a881d56cc6fbd9361fa413d0670b8ca110e", "tree": "f1ea9611d9ade0592be10af0589cc5906c737247", "parents": [ "a6023541a4c6175873820cf3710c18da41ef215f" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Tue Jun 27 09:38:27 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 27 09:55:39 2023" }, "message": "redaction_tool: Use platform specific metric recorder\n\nCrOS requires a different setup for metric collection. This change adds\nthe metric recorder implementation for the chromium usage of the\nredaction_tool.\n\nBug: b:284464395\nChange-Id: Ib4ef3c6ee5b4c9ac3a1106896ee25fed2bfafadd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574313\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCommit-Queue: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1162849}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 44901fae905c60bdc26956416cbed99cb8d70ff9\n" }, { "commit": "a6023541a4c6175873820cf3710c18da41ef215f", "tree": "cd9466cdf11c91e7dd492153dca2962960f7f9a5", "parents": [ "b8e4c4af11a5365d503965e5c12aa3638b6258cb" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Thu Jun 15 05:42:02 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 15 05:49:00 2023" }, "message": "Rely on much simpler re2::StringPiece \u003c-\u003e base::StringPiece conversions\n\nbase::StringPiece implicitly converts to/from std::string_view and\nre2::StringPiece is now the same as absl::string_view which, in\nChromium, is the same as std::string_view. All the code which converted\nby hand can mostly not worry about it.\n\nIdeally we\u0027d also remove references to re2::StringPiece in favor of\nstd::string_view, but that\u0027ll bump into the current std::string_view\npresubmit, so I\u0027m leaving this alone for now. I\u0027m also leaving alone for\nnow other issues in the surrounding code, such as pointer arithmetic\nthat would be better done with the bounds-checked substr() method, etc.\nBut all those should also be fixed up.\n\nBug: 1447090\nChange-Id: If9de189f4cd85c1391894d9ab027e37da7144e44\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604580\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nReviewed-by: Brandon Jones \u003cbajones@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Dominic Battre \u003cbattre@chromium.org\u003e\nReviewed-by: Tao Wu \u003cwutao@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1157951}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1727ad241d9f1b0f37602a0a4342c8c767550227\n" }, { "commit": "b8e4c4af11a5365d503965e5c12aa3638b6258cb", "tree": "df9ce5302fb8bd50c3bcc437ac145e4077d19904", "parents": [ "e9cb981f21756a5bc91845f00062d90ca800136e" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed May 31 15:29:50 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:17:45 2023" }, "message": "Use std::string::append(base::StringPiece) instead of decomposing\n\nstd::string_view is special because std::string knows how to integrate\nwith it. Happily, the STL uses a StringViewLike concept, so just by\nadding the implicit conversion, we can now write\nstr.append(piece) instead str.append(piece.data(), piece.size()).\n\nWhile small, this change keeps us using safe constructs. Clear these out\nso we get a little closer to being able to flag accesses of data() as\nunsafe. (That\u0027s a long ways off, but let\u0027s get the easy stuff out of the way.)\n\nA few places (content/web_test/renderer/blink_test_helpers.cc and\nnet/test/embedded_test_server/http2_connection.cc) were even wrong as\nthey used .data() without .size() on a string_view/StringPiece.\n\nBug: 691162\nChange-Id: Ib58e00db5f8c2527908c9e7971d28a0b53e68e65\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574755\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1151252}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2eb24c24d2fb7c302710ad7f00bcc32c9015770e\n" }, { "commit": "e9cb981f21756a5bc91845f00062d90ca800136e", "tree": "27fb6269a4163a2e1b83eaa66c3e0a6fb43287f8", "parents": [ "0d0c7cf1cffd143edde3f88b59356fadbe32af5b" ], "author": { "name": "Paul Wankadia", "email": "junyer@chromium.org", "time": "Tue May 30 22:41:43 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:17:24 2023" }, "message": "Replace more uses of re2::StringPiece::AppendToString().\n\nRE2 has taken a dependency on Abseil. re2::StringPiece is (for now)\nan alias; its old member functions no longer exist. This CL is just\none of many needed to unblock updating Chromium\u0027s copy of RE2 soon.\n\nBug: 1447090\nChange-Id: Ia096ea738e3f87114d61c169cd2471148c7453fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573173\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Paul Wankadia \u003cjunyer@chromium.org\u003e\nCommit-Queue: Paul Wankadia \u003cjunyer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1150920}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dc8105008f725f90ff1af12697b4e6b4c3b69839\n" }, { "commit": "0d0c7cf1cffd143edde3f88b59356fadbe32af5b", "tree": "d4b6fca2faa0c6392ff3ca27da273171b0a2a85a", "parents": [ "cb5abf81809bbb646e6928f40810ff347f6b7739" ], "author": { "name": "Paul Wankadia", "email": "junyer@chromium.org", "time": "Tue May 30 19:53:20 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:17:02 2023" }, "message": "Don\u0027t pass nullptr to construct re2::StringPiece.\n\nThis avoids breakage when re2::StringPiece becomes\nan alias for absl::string_view/std::string_view.\n\nAlso, remove an unused variable that will start\nupsetting the compiler for some reason.\n\nBug: 1447090\nChange-Id: I5d2ffdb261391c0f0f3eaac706eb47a3cf108125\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569968\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Paul Wankadia \u003cjunyer@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1150783}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3f6cd624418e2aacd7f2802df188585db78044da\n" }, { "commit": "cb5abf81809bbb646e6928f40810ff347f6b7739", "tree": "922621bed7e80459436472349740a7e7ead43962", "parents": [ "046b2a8de080a657f2cf010c3ff0c2582de1f229" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Fri May 26 07:21:02 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:16:44 2023" }, "message": "redaction_tool: Don\u0027t match IBANs in continuous blocks\n\nNumber and letter combinatations can appear like an IBAN in long blocks\nof data.\nSince it\u0027s very unlikely that IBANs will be part of a continuous stream\nof data this makes sure the regex doesn\u0027t match without separating\ncharacters.\n\nPreviously this string:\nTd6WFoAAATm1rRGAAAAABzfRGB33BUKB20201555555555AAAAAEWVo\u003d\n\nwould be converted into:\nTd6WFoAAATm1rRGAAAAABzfR(IBAN: 1)AAAAAEWVo\u003d\n\nNow it requires additional indicators before and after the string like:\nTd6WFoAAATm1rRGAAAAABzfR:GB33BUKB20201555555555 AAAAAEWVo\u003d\n\nTo redact the IBAN in the string.\n\nBug: b:284095268\nTest: components_unittests --gtest_filter\u003d\"RedactionToolTest.*\"\nChange-Id: Ibe782e4993e14c87a65c599058fc29c3ba57c963\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4560007\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1149579}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2e361a5d82f9044581cbc05624a37145be1205f7\n" }, { "commit": "046b2a8de080a657f2cf010c3ff0c2582de1f229", "tree": "3dc133d4672575ae6ca3904b078288fd5512506a", "parents": [ "a6fb2d7ddd203e18f8c25679e12e8d68a4fc8c6d" ], "author": { "name": "Paul Wankadia", "email": "junyer@chromium.org", "time": "Tue May 23 18:42:42 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:01:38 2023" }, "message": "Replace uses of re2::StringPiece::contains().\n\nRE2 has taken a dependency on Abseil. re2::StringPiece is (for now)\nan alias; its old member functions no longer exist. This CL is just\none of many needed to unblock updating Chromium\u0027s copy of RE2 soon.\n\nBug: 1447090\nChange-Id: I9d4c0dff881330dd8fcb4805d63845297a203fdf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547053\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Paul Wankadia \u003cjunyer@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1148060}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eee5a88144edad47597163db8f26687a5bd24915\n" }, { "commit": "a6fb2d7ddd203e18f8c25679e12e8d68a4fc8c6d", "tree": "46929055b5454d1655c4972abfd3a04fe68887f5", "parents": [ "8550b0ddd3b7bd664b2522be8a97e997db04c4f2" ], "author": { "name": "Paul Wankadia", "email": "junyer@chromium.org", "time": "Fri May 19 18:43:33 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:01:19 2023" }, "message": "Replace uses of re2::StringPiece::AppendToString().\n\nRE2 has taken a dependency on Abseil. re2::StringPiece is (for now)\nan alias; its old member functions no longer exist. This CL is just\none of many needed to unblock updating Chromium\u0027s copy of RE2 soon.\n\nBug: 1447090\n\nChange-Id: I335e63709193b01d0d4e2e2b7ecfaa205e06877d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547047\nAuto-Submit: Paul Wankadia \u003cjunyer@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Paul Wankadia \u003cjunyer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1146626}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: efc4763ff060a30dbbadc8f31a6fb0899e00a564\n" }, { "commit": "8550b0ddd3b7bd664b2522be8a97e997db04c4f2", "tree": "43de7aab8610779a2c4c0c697790509e1fc03cf4", "parents": [ "590b7dfcda03c0661f1be90adc186ad0de8281a3" ], "author": { "name": "Paul Wankadia", "email": "junyer@chromium.org", "time": "Fri May 19 18:42:56 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:00:56 2023" }, "message": "Replace uses of re2::StringPiece::as_string().\n\nRE2 has taken a dependency on Abseil. re2::StringPiece is (for now)\nan alias; its old member functions no longer exist. This CL is just\none of many needed to unblock updating Chromium\u0027s copy of RE2 soon.\n\nBug: 1447090\n\nChange-Id: I917defc8d2df5c66c25f44a94ee9df5eb6ba1fda\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4549043\nAuto-Submit: Paul Wankadia \u003cjunyer@chromium.org\u003e\nCommit-Queue: Paul Wankadia \u003cjunyer@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1146625}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 68c426f8160021247839f29c88748688c1aa6816\n" }, { "commit": "590b7dfcda03c0661f1be90adc186ad0de8281a3", "tree": "859407e8ac1405bb27b9990f7edf3e05775cfa00", "parents": [ "b70689436428c50d1c2d201827f38a7c4377d2f3" ], "author": { "name": "Irem Uguz", "email": "iremuguz@google.com", "time": "Fri May 19 10:03:25 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:00:31 2023" }, "message": "Rename PIIType::kLocationInfo as kCellularLocationInfo\n\nAfter discussion with privacy team under\ngo/cros-admin-console-support-tool-prd, we decided that Location Info\nname can be misleading since it only represents cellular location info\nlike cell ID and location area code. Rename it to \"Cellular Location\nInfo\" to be more specific.\nUpdate the PII category of \"location\" field in policy status as\nkStableIdentifier. Location is an identifier that\u0027s set during\nenrollment like asset ID so this PII type will be more fitting.\n\n--gtest_filter\u003d*PolicyDataCollector*\n\nBug: b:281040959\nTest: unit_tests --gtest_filter\u003d** and browser_tests\nChange-Id: I8b3c131aaed020a4c82f27df398facc17c436fec\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4512174\nCommit-Queue: Irem Uguz \u003ciremuguz@google.com\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nReviewed-by: Pavol Marko \u003cpmarko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1146438}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4c831d6ee06af7bfd412d8a069ad30c76272518f\n" }, { "commit": "b70689436428c50d1c2d201827f38a7c4377d2f3", "tree": "f4f8f849ea8820d2a209397fc38b7ea5139c70ca", "parents": [ "c0923fecf6901c380124e29aabd693c3d6e66877" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Mon May 15 16:53:21 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 21:00:09 2023" }, "message": "redaction_tool: Redact IBANs\n\nAs part of the DPChromeOS effort we want to redact IBANs on the client\nside.\n\nBug: b:275037400\nTest: components_unittests --gtest_filter\u003d\"RedactionToolTest.*\"\nChange-Id: I1061b612be0680bbe38848141262bb6957244e5d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503032\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCommit-Queue: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1144176}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7501c8181c4993bd6f530a581e9f2731c732d723\n" }, { "commit": "c0923fecf6901c380124e29aabd693c3d6e66877", "tree": "f01c3500c59577d538219356fb2ccd1ed5b9624d", "parents": [ "7fb8fb97e30aa6bbfe4ceb3984c37d0762b07bbc" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Fri May 12 13:17:24 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:59:37 2023" }, "message": "redaction_tool: Redact credit card numbers\n\nAs part of the DPChromeOS effort we want to redact credit card numbers\non the client side.\n\nBug: b:275038297\nChange-Id: I17315eb8c3dbc04fa4a29875fd27fdbe4519555d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4466161\nReviewed-by: Matthias Körber \u003ckoerber@google.com\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCommit-Queue: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nReviewed-by: Denis Kuznetsov \u003cantrim@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1143221}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 123e2fcaa04946a863595e7440458b9e33bbd89d\n" }, { "commit": "7fb8fb97e30aa6bbfe4ceb3984c37d0762b07bbc", "tree": "e3bdd03a539bae2e60e641acb735a526fd2e2398", "parents": [ "1dbde61a055e5b2e7f0063d45bf21428b1c71cba" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Thu May 11 17:49:32 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:59:20 2023" }, "message": "redaction_tool: Only collect UMA metrics when PII matches\n\nCurrently UMA metrics are always collected when the method is called.\nAfter this the metrics will only be collected when PII has been\ndetected.\n\nBug: b:281800173\nChange-Id: Ic953470b64c3b48d5c9e5917106386de1d3476fe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520920\nAuto-Submit: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nCommit-Queue: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1142762}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a08d3932df22bb9dcbde70e310594f4c06917192\n" }, { "commit": "1dbde61a055e5b2e7f0063d45bf21428b1c71cba", "tree": "5c72d152feca7d00442aaf07334b80780112e27e", "parents": [ "45db8522f7c541eea077056fec353d96c9d3329a" ], "author": { "name": "Chinglin Yu", "email": "chinglinyu@chromium.org", "time": "Wed May 03 07:56:41 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:59:00 2023" }, "message": "Avoid truncating base64 data in UID redaction\n\nAs the UIDs are 32 bytes public key, add a non-capturing group of\nnon-base64 character to avoid matching and redacting the suffix of all\nbase64 data decoded to \u003e 32 bytes.\n\nBug: b:277545613\nTest: components_unittests --gtest_filter\u003dRedactionToolTest.RedactUid\nChange-Id: Iba38d5a33abc204de99544fe80a1422e01d39ba8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4493802\nCommit-Queue: Chinglin Yu \u003cchinglinyu@chromium.org\u003e\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1138829}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ffd4df06c0a9477ceb000311cd94e269a1f5cb7a\n" }, { "commit": "45db8522f7c541eea077056fec353d96c9d3329a", "tree": "2bdbe6ff01b5c54bf8f555aeeb7feb9ec80adc8f", "parents": [ "2696fe1dbb66c6fa69a6ed99df4e22c1e53e2909" ], "author": { "name": "Christoph Schlosser", "email": "cschlosser@chromium.org", "time": "Tue Apr 25 07:01:34 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:58:40 2023" }, "message": "redaction_tool: Change the brackets used for redacted information\n\nRedacting information with \u003c\u003e potentially leads some tools to treat it\nas HTML tags and removing them for sanitization.\n\nBug: b:278189152\nChange-Id: I82cd2b352449d073480b1628a450b484dd5369bd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420873\nAuto-Submit: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nCommit-Queue: Christoph Schlosser \u003ccschlosser@chromium.org\u003e\nReviewed-by: Irem Uguz \u003ciremuguz@google.com\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Finnur Thorarinsson \u003cfinnur@chromium.org\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1135073}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9e179811cd6f2272eb822382a65160d7eb6b5790\n" }, { "commit": "2696fe1dbb66c6fa69a6ed99df4e22c1e53e2909", "tree": "415ddae4450613957f2e445002a326d55665def9", "parents": [ "ea130a69a08d4d98feef20f5af8e8066e535cbd3" ], "author": { "name": "Sergiy Belozorov", "email": "sergiyb@google.com", "time": "Wed Apr 12 18:36:52 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:58:19 2023" }, "message": "Avoid matching base64-encoded data as PSM identifiers\n\nWe now require whitespace after \"PSM\" prefix for identifiers to match.\nThe base64 scheme does not include any whitespace characters.\n\nBug: b:277542495\nTest: components_unittests --gtest_filter\u003dRedactionToolTest.RedactCustomPatterns\nChange-Id: I357439d766ba0e26f61b15a07fe8acc662ba3b62\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414858\nReviewed-by: Xiangdong Kong \u003cxiangdongkong@google.com\u003e\nAuto-Submit: Sergiy Belozorov \u003csergiyb@google.com\u003e\nCommit-Queue: Sergiy Belozorov \u003csergiyb@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1129388}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 79778fad75018a0d4ba9e07edd0be1854cf1f041\n" }, { "commit": "ea130a69a08d4d98feef20f5af8e8066e535cbd3", "tree": "297ddd13ab01d4ab2e8d26923db32ae2ce543084", "parents": [ "9a5975247af821552f023fa8f7dda40e2d891752" ], "author": { "name": "Nik", "email": "nikj@google.com", "time": "Tue Feb 14 18:00:03 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:57:59 2023" }, "message": "Add UMA Metrics to the Client side log redaction tool\n\nRecord the number of times each PII type is redacted from the logs to\nmeasure the efficiency of client side log redaction tool.\n\nBug: b/266711224\nChange-Id: I1045af61e15ad11d810353205521eba1979472c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4194047\nCommit-Queue: Nik K \u003cnikj@chromium.org\u003e\nQuick-Run: Nik K \u003cnikj@chromium.org\u003e\nReviewed-by: Miriam Zimmerman \u003cmutexlox@chromium.org\u003e\nAuto-Submit: Nik K \u003cnikj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1105140}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4062615c485d33cadc182484034810657dc3fee0\n" }, { "commit": "9a5975247af821552f023fa8f7dda40e2d891752", "tree": "1862fa217aa4703eaeea26810ab965e9290233ee", "parents": [ "349ca4c41cad798b80777ea5b978bf0153c07655" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Fri Feb 10 09:03:33 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:57:39 2023" }, "message": "[BRP] Apply raw_ptr rewriter for Android\n\nRewrites generated by running the raw_ptr rewriter (Android)\non cdab6b2734f40f8ce775110229528bbabe215bd4\n\nPS1: generated rewrite\nChange-Id: Ia6495d23a5b7889ffe9ed559d3dbe4dedbec1a54\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4236278\nReviewed-by: Keishi Hattori \u003ckeishi@chromium.org\u003e\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1103721}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bb755669310c1271732c5bd815f9576198093139\n" }, { "commit": "349ca4c41cad798b80777ea5b978bf0153c07655", "tree": "3d6c3fbf3507e44d0b24979853ebf228b8ce4360", "parents": [ "29b06ca6f452b5fbbf12f9b3cf4b3544f717222c" ], "author": { "name": "Donna Dionne", "email": "donnadionne@chromium.org", "time": "Mon Jan 30 20:14:48 2023" }, "committer": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 20:57:12 2023" }, "message": "Refactorying redaction_tool.\n\nBranching the files as is, will make modifications based on patchset #3\nto demonstrate the differences in the files.\n\nBug: b:265030885\nChange-Id: I0c535ed78a016b3660b1ebb423ecd139109b0ac5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4131815\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Irem Uguz \u003ciremuguz@google.com\u003e\nCommit-Queue: Donna Dionne \u003cdonnadionne@chromium.org\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1098804}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ca9416da4cccd7e71d733e4786290ce46c314d1b\n" }, { "commit": "29b06ca6f452b5fbbf12f9b3cf4b3544f717222c", "tree": "4b825dc642cb6eb9a060e54bf8d69288fbee4904", "parents": [], "author": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Tue Jun 06 18:12:10 2023" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jun 06 18:12:10 2023" }, "message": "Initial empty repository\n" } ] }