)]}' { "log": [ { "commit": "75158033e1e38dbd864441959615243fd1f06cac", "tree": "8777643b129455751ded6323f99ce7d7df5f5304", "parents": [ "2cae9811cf265092fbfb34a8ceb1e21a4f077986" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Sep 13 19:22:36 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 19:38:55 2022" }, "message": "Update copyright headers in components/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c34.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: If6a3370b0b2849d889ce797596fe1ccbad2f3fe6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891619\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1046502}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ba1bad80dc22235693a0dd41fe55c0fd2dbdabd\n" }, { "commit": "2cae9811cf265092fbfb34a8ceb1e21a4f077986", "tree": "8b77a10581e466d3a4033c4416b8259f7478d06b", "parents": [ "3c82e2c8ca01fd48c730cac730349b1594cbaa85" ], "author": { "name": "Will Harris", "email": "wfh@chromium.org", "time": "Tue May 24 17:24:25 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 24 17:45:57 2022" }, "message": "Allow the swreporter to be manually disabled for chrome branded builds.\n\nSometimes a Chrome branded build is needed for development, but the\nChrome Cleanup Tool running is undesirable.\n\nThis CL adds a new GN flag that defaults to true for Chrome branded\nbuilds but can be manually set to allow disabling of Chrome Cleanup\nTool in these cases.\n\nNo behavior change is expected by this CL unless the new GN flag is\nset by a developer.\n\nBUG\u003d1317724\n\nChange-Id: Ia932646873310d9cadfc86c4e0b35fe5c1814c18\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652911\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1006929}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d3ea872abddde5dc835ab414f221a96386bfec2f\n" }, { "commit": "3c82e2c8ca01fd48c730cac730349b1594cbaa85", "tree": "613a76a2129f8c266103aa71d5221a4b19e7d23d", "parents": [ "7760754a0375625da19075c56f70323b6569e3ad" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Wed Apr 13 23:57:46 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 14 00:13:22 2022" }, "message": "Remove unused kSRTPromptGroupNameParam\n\nThe contents of this param are added to the software_reporter_tool.exe\ncommand line, but the code to read that command-line flag is long gone.\nIt was used when experimenting with different prompt behaviours, to\nrecord the experiment group name in logs collected from the reporter.\n\nBug: 1305047\nChange-Id: Ida043b88834917652d3087f006d92fba3d71fa78\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3585029\nAuto-Submit: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: Daniel Rubery \u003cdrubery@chromium.org\u003e\nCommit-Queue: Daniel Rubery \u003cdrubery@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#992314}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b0e51a3f761cddb2b0ebb4e7085fa1b3a1d43902\n" }, { "commit": "7760754a0375625da19075c56f70323b6569e3ad", "tree": "f931e86d6198eafb52df9c6d9948787ebfe4576f", "parents": [ "347ed67afd15c74cbe707710ec0804ca167cdad1" ], "author": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Tue Sep 28 06:50:47 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 28 07:01:36 2021" }, "message": "[dirmd] Use metadata mixins\n\nUse the new \"mixins\" feature in dirmd.\nDerive mixins from file:// links in OWNERS files.\n\nThis CL is machine-generated, in two parts.\n\nPart 1: use mixins.\n\n1. Save current metadata to JSON files, in ORIGINAL and REDUCED forms.\n dirmd read -form original \u003e ~/tmp/dirmd/original.json\n dirmd read -form reduced \u003e ~/tmp/dirmd/reduced.json\n2. Run mixins.py.\n Source code: https://gist.github.com/nodirg/b59d3df338a72a8944f957c5b3a15e22\n\nThe script finds related directories, connected by file:// links\nin OWNERS files. For those directories that have the same base\nname, e.g.\n components/autofill\n chrome/android/java/src/org/chromium/chrome/browser/autofill\nif importing the \"parent\" to the \"child\" reduces metadata, or adds\nmissing metadata, extract the common metadata to COMMON_METADATA\nand import it in both directories.\n\nPart2: deduplicate metadata.\nApply same instructions as in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/2795985/16\n\nBug: 1179786\nChange-Id: I2e6378004ce433e02f1c9360b09eb72354083bf6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2897943\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Fred Mello \u003cfredmello@chromium.org\u003e\nOwners-Override: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCommit-Queue: Nodir Turakulov \u003cnodir@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#925648}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: de11715e63f49274f3fab352f2367699348ba255\n" }, { "commit": "347ed67afd15c74cbe707710ec0804ca167cdad1", "tree": "ef8c3b2fccbe77417171a2ea4a62356a6b66295a", "parents": [ "564d7b9f411b6b7f490e1422b8d571ca46cd8e0f" ], "author": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Tue May 18 09:06:24 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 18 09:17:31 2021" }, "message": "[dirmd] Deduplicate directory metadata\n\nProgrammatically delete redundant metadata.\nThis CL is entirely machine-generated:\n1. Export the metadata in the \"original\" and \"reduced\" forms:\n dirmd read -form original \u003e ~/tmp/dirmd/original.json\n dirmd read -form reduced \u003e ~/tmp/dirmd/reduced.json\n2. Run reduce.py\n Source code: https://gist.github.com/nodirg/a4803af94ffe258ba0a6e0a4807141d8\n\nThe script diffs the two JSON files and strips redundant\nlines from DIR_METADATA files. If the file became empty, then\nremoves the file.\n\nThe results of the script was verified by diffing canonical\nrepresentation of `dirmd read -form full` before and after\nthe script: there is no diff.\n\nBug: 1179786\nChange-Id: Ie5de3ba0962d266244ffb9b07c874b3dbbb69b9c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2795985\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Fred Mello \u003cfredmello@chromium.org\u003e\nOwners-Override: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCommit-Queue: Nodir Turakulov \u003cnodir@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#883868}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6dfb6d1accb0d5b62ac31eac2ae080f10d64ab57\n" }, { "commit": "564d7b9f411b6b7f490e1422b8d571ca46cd8e0f", "tree": "f16737ad53a4588e83bf337e83c13e991f9c721c", "parents": [ "0a633870a72a184cf09cff5ada598e9cfd6540d4" ], "author": { "name": "Dominic Battre", "email": "battre@chromium.org", "time": "Wed Apr 28 07:28:36 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 28 07:40:30 2021" }, "message": "Replace non-existing UI\u003eBrowser\u003ePreferences\n\nThis CL replaces the non-existing crbug.com component\nUI\u003eBrowser\u003ePreferences with Internals\u003ePreferences and\nServices\u003eSafebrowsing to make sure that bug can be routed.\n\nBug: 1188055\nChange-Id: I94f488e706d6b25d8085d5155283a962b6dfe7db\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2851599\nCommit-Queue: Dominic Battré \u003cbattre@chromium.org\u003e\nCommit-Queue: Dominick Ng \u003cdominickn@chromium.org\u003e\nAuto-Submit: Dominic Battré \u003cbattre@chromium.org\u003e\nReviewed-by: Dominick Ng \u003cdominickn@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Varun Khaneja \u003cvakh@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#876947}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cb833fdfd1cbf8e787040de6ae55ad1acdb73234\n" }, { "commit": "0a633870a72a184cf09cff5ada598e9cfd6540d4", "tree": "afcceb72d1819d52123ab363b8360d7742d59e97", "parents": [ "5eaea9d38dda8576229c562e0f30731d89a1fb70" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Fri Jan 29 22:11:01 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 29 22:16:28 2021" }, "message": "Remove Chrome Cleanup Tool unwanted extension cleaning from Chrome\n\nhttps://crrev.com/c/2638001 removed the code in the Chrome Cleanup Tool\nthat triggers a request to clean unwanted extensions. This removes the\nChrome-side code that handles that request, including the UI that gets\npermission from the user.\n\nBug: 981388\nChange-Id: I153c4b0f4d261830f0257acdc25c5cad43b71eda\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637354\nReviewed-by: dpapad \u003cdpapad@chromium.org\u003e\nReviewed-by: Daniel Rubery \u003cdrubery@chromium.org\u003e\nCommit-Queue: Daniel Rubery \u003cdrubery@chromium.org\u003e\nAuto-Submit: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#848742}\nGitOrigin-RevId: ca4ef799327d696f817f7e887d738d6b76f4d7f6\n" }, { "commit": "5eaea9d38dda8576229c562e0f30731d89a1fb70", "tree": "06a9b8475dba996c47f81d6feb8a268bf5ed215e", "parents": [ "0ceab79c1dcaab375c6f97ae9ee33b60903698a3" ], "author": { "name": "Norman Rosas", "email": "normando@google.com", "time": "Fri Dec 04 21:29:45 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 04 21:43:07 2020" }, "message": "Added DIR_METADATA files and removed duplicated\nmetadata from OWNERS files in the next repos:\n//components/cast...\n//components/certificate..\n//components/chrome_cleaner\n//components/client...\n\nBug: 1113033\nChange-Id: I67561c5b8a8796ca6307fd088855d24ac089e317\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564389\nAuto-Submit: Norman Rosas \u003cnormando@google.com\u003e\nReviewed-by: mark a. foltz \u003cmfoltz@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nCommit-Queue: Norman Rosas \u003cnormando@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#833866}\nGitOrigin-RevId: b4cfc337d13b72313eaf9c4dd3f0b8faa2561440\n" }, { "commit": "0ceab79c1dcaab375c6f97ae9ee33b60903698a3", "tree": "d96c21acb801fc0e3e2b957f2c9712e7fac7fe40", "parents": [ "6c1a4c063d510e1189a4bf441cfa2ee7be3e4a28" ], "author": { "name": "Bettina", "email": "bdea@chromium.org", "time": "Sat Nov 07 13:02:42 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Nov 07 13:13:06 2020" }, "message": "Add experiment Switch for ResetShortcuts in CCT.\n\nThe new reset shortcut feature in the Chrome\nCleanup Tool needs a command line switch to tell it\nwhether or not the feature is on. The switch only\naffects the cleaner and not the reporter.\n\nBug: 1116017\nChange-Id: I8e3de8b1025a1471198991574859fdcf556e9aa8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522679\nCommit-Queue: Bettina Dea \u003cbdea@chromium.org\u003e\nReviewed-by: Daniel Rubery \u003cdrubery@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#825187}\nGitOrigin-RevId: 35e2d490ddfa71ee823074f7b5529b566f8e4eb2\n" }, { "commit": "6c1a4c063d510e1189a4bf441cfa2ee7be3e4a28", "tree": "db96ac229800da5a308c69e24f654a2b1bcec9e7", "parents": [ "9812b44ef9dea98f8cdd2b81ae519df357c07ba8" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Tue Jan 14 16:39:37 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Aug 11 22:07:13 2020" }, "message": "remove copybara initialization artifacts\n\nGitOrigin-RevId: 5480c4c44df688de80a6eb26eba7f2f18b39cb28\n" }, { "commit": "9812b44ef9dea98f8cdd2b81ae519df357c07ba8", "tree": "fe9531bb57fe1862bcc70a9fc0ee4e2f8a5dfe8a", "parents": [ "26ee24bf4e2752d7fd9dec541ce9238f51ed7d0f" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Tue Jan 14 16:39:37 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Aug 11 22:05:10 2020" }, "message": "Copybara Service Migration Initialization.\n\nGitOrigin-RevId: 5480c4c44df688de80a6eb26eba7f2f18b39cb28\n" }, { "commit": "26ee24bf4e2752d7fd9dec541ce9238f51ed7d0f", "tree": "db96ac229800da5a308c69e24f654a2b1bcec9e7", "parents": [ "32f98a7ae67693cdb7bb6a01c86f450cf7cc96eb" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Tue Jan 14 16:39:37 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 14 16:39:37 2020" }, "message": "Reformat all gn files in /components/chrome_cleaner.\n\n`gn format` recently changed its formatting behavior\nfor deps, source, and a few other elements when they\nare assigned (with \u003d) single-element lists to be consistent\nwith the formatting of updates (with +\u003d) with single-element.\n\nNow that we\u0027ve rolled in a GN binary with the change,\nreformat all files so that people don\u0027t get presubmit\nwarnings due to this.\n\nThis CL was uploaded by git cl split.\n\nR\u003djoenotcharles@chromium.org\n\nBug: 1041419\nChange-Id: Ic3538252c9b04bc5ad2b47d74017e36875f30d18\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998861\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#731449}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5480c4c44df688de80a6eb26eba7f2f18b39cb28\n" }, { "commit": "32f98a7ae67693cdb7bb6a01c86f450cf7cc96eb", "tree": "6729000ff2e022c0401ca199d7110a7f8761d29c", "parents": [ "136004338fcda91b0a47ebe7d16f4f7a518e6374" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Tue Nov 12 16:47:55 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 12 16:47:55 2019" }, "message": "Move chrome_prompt.mojom and kChromeMojoPipeTokenSwitch into chrome/chrome_cleaner\n\nThese no longer need to be in the shared components/chrome_cleaner directory\nbecause new versions of Chrome do not use them to communicate with the cleaner.\nThe cleaner itself still needs to build against them so that the cleaner can\ncommunicate with older versions of chrome that set kChromeMojoPipeTokenSwitch\non the command-line.\n\nAlso split out FilePath, RegistryKey and ExtensionId into a new\nfootprints.mojom interface, to eliminate some bogus dependencies on\nchrome_prompt.mojom.\n\nR\u003dproberge\n\nBug: 969139\nChange-Id: Ib6f5b2dbf6f08d389453bcea86d52cdc5b078bec\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903956\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Cait Phillips \u003ccaitkp@chromium.org\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#714502}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d7689e98ddc2a464dae2489b0f6bbf201b6b150b\n" }, { "commit": "136004338fcda91b0a47ebe7d16f4f7a518e6374", "tree": "3e38c4947f4d3654d4d30a87fee9d900dc330858", "parents": [ "3c288abc8b51e7f47f175033b5b04aba4829fdf0" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Wed Aug 21 22:59:23 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 21 22:59:23 2019" }, "message": "Reland \"Implement ProtoChromePromptIPC.\"\n\nThis is a reland of e5f1b06d49463065691dfe49b82f1498dae7bd6f\n\nIt was reverted in https://crrev.com/c/1760644 for causing test failures on CI\nbuilders that couldn\u0027t be reproduced on other machines.\n\nThis patch disables the failing tests. A followup will reenable the tests with\nextra debugging to diagnose the failures on the CI builders.\n\nThen it was relanded and reverted again in https://crrev.com/c/1764124 because\nit raced on the CQ with an API change to CreateSequencedTaskRunner.\n\nTBR\u003dwfh\nTBR_REASON\u003dReland of test-only proto change that was already reviewed.\n\nOriginal change\u0027s description:\n\u003e Implement ProtoChromePromptIPC.\n\u003e\n\u003e Bug: 969139\n\u003e Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747\n\u003e Commit-Queue: Oliver Li \u003colivierli@chromium.org\u003e\n\u003e Reviewed-by: Will Harris \u003cwfh@chromium.org\u003e\n\u003e Reviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#688357}\n\nBug: 969139\nChange-Id: I989a66205db61caefd7777d0046226e3244dc4b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764471\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#689226}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f1b350180337f70c58b80b480bf7a2f42f0d9085\n" }, { "commit": "3c288abc8b51e7f47f175033b5b04aba4829fdf0", "tree": "c6f3c3783614dbacc1d32f45c5a7e6ea2c3127c6", "parents": [ "e5ec8e73a7433914c95d2c677c3b2dfa88c73247" ], "author": { "name": "Evan Stade", "email": "estade@chromium.org", "time": "Wed Aug 21 20:42:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 21 20:42:14 2019" }, "message": "Revert \"Reland \"Implement ProtoChromePromptIPC.\"\"\n\nThis reverts commit 5805ac7f82009dd5cfbabd9e813f9d2d521d6bee.\n\nReason for revert: breaking Windows compile:\n\nIn file included from ../..\\base/task/lazy_task_runner.h:17:\n../..\\base/task/task_traits.h(263,5): error: static_assert failed due to requirement \u0027has_thread_pool ^ has_extension\u0027 \"Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)\"\n static_assert(\n ^\n../..\\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization \u0027base::TaskTraits::TaskTraits\u003cbase::MayBlock, void\u003e\u0027 requested here\n base::CreateSequencedTaskRunner({base::MayBlock()});\n ^\n1 error generated.\n\nOriginal change\u0027s description:\n\u003e Reland \"Implement ProtoChromePromptIPC.\"\n\u003e \n\u003e This is a reland of e5f1b06d49463065691dfe49b82f1498dae7bd6f\n\u003e \n\u003e It was reverted in https://crrev.com/c/1760644 for causing test failures on CI\n\u003e builders that couldn\u0027t be reproduced on other machines.\n\u003e \n\u003e This patch disables the failing tests. A followup will reenable the tests with\n\u003e extra debugging to diagnose the failures on the CI builders.\n\u003e \n\u003e TBR\u003dwfh\n\u003e TBR_REASON\u003dReland of test-only proto change that was already reviewed.\n\u003e \n\u003e Original change\u0027s description:\n\u003e \u003e Implement ProtoChromePromptIPC.\n\u003e \u003e\n\u003e \u003e Bug: 969139\n\u003e \u003e Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747\n\u003e \u003e Commit-Queue: Oliver Li \u003colivierli@chromium.org\u003e\n\u003e \u003e Reviewed-by: Will Harris \u003cwfh@chromium.org\u003e\n\u003e \u003e Reviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#688357}\n\u003e \n\u003e Bug: 969139\n\u003e Change-Id: Iafdc22cc06fbedd5de73bf8bb7881fc46e01f350\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759154\n\u003e Reviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\n\u003e Reviewed-by: Will Harris \u003cwfh@chromium.org\u003e\n\u003e Commit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#689074}\n\nTBR\u003djoenotcharles@google.com,wfh@chromium.org,olivierli@chromium.org\n\nChange-Id: I42f06162b45d41212816410027153f89f95a28f1\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 969139\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764124\nReviewed-by: Evan Stade \u003cestade@chromium.org\u003e\nCommit-Queue: Evan Stade \u003cestade@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#689151}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8eee5e2ee7c31e15e7a808db9b45ed8564ef3542\n" }, { "commit": "e5ec8e73a7433914c95d2c677c3b2dfa88c73247", "tree": "3e38c4947f4d3654d4d30a87fee9d900dc330858", "parents": [ "2ed363d9cb9d4e938841e62b82e6879675ae4078" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Wed Aug 21 18:04:02 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 21 18:04:02 2019" }, "message": "Reland \"Implement ProtoChromePromptIPC.\"\n\nThis is a reland of e5f1b06d49463065691dfe49b82f1498dae7bd6f\n\nIt was reverted in https://crrev.com/c/1760644 for causing test failures on CI\nbuilders that couldn\u0027t be reproduced on other machines.\n\nThis patch disables the failing tests. A followup will reenable the tests with\nextra debugging to diagnose the failures on the CI builders.\n\nTBR\u003dwfh\nTBR_REASON\u003dReland of test-only proto change that was already reviewed.\n\nOriginal change\u0027s description:\n\u003e Implement ProtoChromePromptIPC.\n\u003e\n\u003e Bug: 969139\n\u003e Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747\n\u003e Commit-Queue: Oliver Li \u003colivierli@chromium.org\u003e\n\u003e Reviewed-by: Will Harris \u003cwfh@chromium.org\u003e\n\u003e Reviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#688357}\n\nBug: 969139\nChange-Id: Iafdc22cc06fbedd5de73bf8bb7881fc46e01f350\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759154\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#689074}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5805ac7f82009dd5cfbabd9e813f9d2d521d6bee\n" }, { "commit": "2ed363d9cb9d4e938841e62b82e6879675ae4078", "tree": "c6f3c3783614dbacc1d32f45c5a7e6ea2c3127c6", "parents": [ "851b2f8f2eabc31486faba2b7af1ecf8bf4b6c73" ], "author": { "name": "Mark Brand", "email": "markbrand@google.com", "time": "Tue Aug 20 11:16:25 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 20 11:16:25 2019" }, "message": "mojo: Changing typemaps to use fully-qualified type names for typemapped types.\n\nMany existing typemaps don\u0027t use fully-qualified typenames, and rely on the undocumented namespacing of the generated code. This breaks the generated code for the generic mojo LPM fuzzer that\u0027s currently under development, which has different namespacing. This CL updates all typemaps files to use fully qualified typenames as per the documentation.\n\nChange-Id: I8b8fe9e99369728a2a6e521c92e79f4a52fbce15\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742227\nCommit-Queue: Mark Brand \u003cmarkbrand@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#688473}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9517a4299ec21584164fac903fa941a0a7c2000c\n" }, { "commit": "851b2f8f2eabc31486faba2b7af1ecf8bf4b6c73", "tree": "139e0840b7f3dd862b3066f765ff138277b90aae", "parents": [ "4b1f793fd22f1580e56e8d28505ce2c90faa9b01" ], "author": { "name": "Takashi Sakamoto", "email": "tasak@google.com", "time": "Tue Aug 20 04:04:53 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 20 04:04:53 2019" }, "message": "Revert \"Implement ProtoChromePromptIPC.\"\n\nThis reverts commit e5f1b06d49463065691dfe49b82f1498dae7bd6f.\n\nReason for revert: suspect causing chrome_cleaner_unittests failure on windows-bots because of:\nhttps://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39695\nhttps://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/94372\n...\nUwSPresent/ProtoChromePromptIPCTest.Communication/true_true_PromptAcceptanceACCEPTED_WITHOUT_LOGS_DisconnectedAfterCloseMessageLength\nUwSPresent/ProtoChromePromptIPCTest.Communication/true_true_PromptAcceptanceDENIED_DisconnectedAfterCloseMessageLength\nUwSPresent/ProtoChromePromptIPCTest.Communication/true_true_PromptAcceptanceACCEPTED_WITH_LOGS_NotDisconnected\nUwSPresent/ProtoChromePromptIPCTest.Communication/true_false_PromptAcceptanceACCEPTED_WITH_LOGS_NotDisconnected\n\nE.g. win7 tests\u0027 log\nhttps://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904641206741120976/+/steps/chrome_cleaner_unittests/0/logs/Deterministic_failure:_NoUwSPresent__x2f_ProtoChromePromptIPCTest.Communication__x2f_false_false_PromptAcceptanceDENIED_NotDisconnected__status_FAILURE_/0\n[ RUN ] NoUwSPresent/ProtoChromePromptIPCTest.Communication/false_false_PromptAcceptanceDENIED_NotDisconnected\n[636:3088:0819/200428.002:5454013:ERROR:proto_chrome_prompt_ipc.h(74)] Writing a message to the pipe failed.: The pipe has been ended. (0x6D)\n../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc(648): error: Expected equality of these values:\n error_occurred_\n Which is: true\n should_have_errors\n Which is: false\n\n../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc(670): error: Expected equality of these values:\n expected_exit_code\n Which is: 0\n rv\n Which is: -1\n\n\nOriginal change\u0027s description:\n\u003e Implement ProtoChromePromptIPC.\n\u003e \n\u003e Bug: 969139\n\u003e Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747\n\u003e Commit-Queue: Oliver Li \u003colivierli@chromium.org\u003e\n\u003e Reviewed-by: Will Harris \u003cwfh@chromium.org\u003e\n\u003e Reviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#688357}\n\nTBR\u003djoenotcharles@google.com,wfh@chromium.org,olivierli@chromium.org\n\nChange-Id: If19d65f100db413bd68ca5f9bfa60aa426474e00\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 969139\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760644\nReviewed-by: Takashi Sakamoto \u003ctasak@google.com\u003e\nCommit-Queue: Takashi Sakamoto \u003ctasak@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#688406}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 68edeb13f4e94d16b89c08777d25d90e5e87b0f6\n" }, { "commit": "4b1f793fd22f1580e56e8d28505ce2c90faa9b01", "tree": "f661df8f496bb8b32800bdeb2c2c20c4b625513e", "parents": [ "750f7bb147216e8fb35c63e63ac909bb68ddd297" ], "author": { "name": "Olivier Li", "email": "olivierli@chromium.org", "time": "Tue Aug 20 00:31:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 20 00:31:59 2019" }, "message": "Implement ProtoChromePromptIPC.\n\nBug: 969139\nChange-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747\nCommit-Queue: Oliver Li \u003colivierli@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#688357}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e5f1b06d49463065691dfe49b82f1498dae7bd6f\n" }, { "commit": "750f7bb147216e8fb35c63e63ac909bb68ddd297", "tree": "139e0840b7f3dd862b3066f765ff138277b90aae", "parents": [ "567e08b732e254f5cc6da9b2a88bbbb07478e4ca" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Wed Jul 24 19:25:24 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 24 19:25:24 2019" }, "message": "Rename components/chrome_cleaner/public/mojom back to interfaces\n\nThis puts the directory name back the way it was before\nhttps://crrev.com/c/1699778.\n\nThe change in directory name has side effects in an internal repo that\nare awkward to deal with. This directory is slated for deletion so let\u0027s\njust leave it with the deprecated name until that happens.\n\nR\u003drockot@chromium.org\n\nBug: 806965\nChange-Id: Ic20789d3b331e7f432d707afda7818e9c3e97ccd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712957\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#680550}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1ec4107e685c5a5d375ca80483dc9d7a7dcdc19b\n" }, { "commit": "567e08b732e254f5cc6da9b2a88bbbb07478e4ca", "tree": "73c24e1c9473239f4043802addcffa2d15aa231b", "parents": [ "0c98554ab0fc649f86146f2c902d5ede3f458205" ], "author": { "name": "Miyoung Shin", "email": "myid.shin@igalia.com", "time": "Tue Jul 16 04:00:18 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 16 04:00:18 2019" }, "message": "Rename traits and mojo directory in //components/chrome_cleaner\n\nThis change renames interfaces to mojom and *_struct_traits.*\nto *_mojom_traits.* in //ui/components/chrome_cleaner.\n\n*_struct_traits.* \u003d\u003e *_mojom_traits.*\n//components/chrome_cleaner/public/interfaces \u003d\u003e //components/chrome_cleaner/public/mojom\n\nBug: 806965\nChange-Id: I2577215b92c6cae50ea5c36e0d886cc74045777c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699778\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: Kinuko Yasuda \u003ckinuko@chromium.org\u003e\nCommit-Queue: Miyoung Shin \u003cmyid.shin@igalia.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#677623}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c4c71cc414af0dc8fd33b50c27324461203dc2bb\n" }, { "commit": "0c98554ab0fc649f86146f2c902d5ede3f458205", "tree": "5f089a54cb055d1af1e346400f40e7f5ac8cd9a9", "parents": [ "b95e1393c8839bfb434b143304f4d914847aaf84" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Wed Jul 10 19:39:58 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 10 19:39:58 2019" }, "message": "Implement message serialization in ChromePromptChannelProtobuf\n\nBug: 969139\nChange-Id: I0bf080b7e8e9f461cd3a6da4bc0da9261976ce2b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676545\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: François Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#676084}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: cd046073cdcd3e65f6e56a1bd812562abe7dc7c0\n" }, { "commit": "b95e1393c8839bfb434b143304f4d914847aaf84", "tree": "fdaa9eabd373855a179c9e9be018ffcd7662e948", "parents": [ "5cb9c8a259dde613736d2bc9e563295409da1fc0" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Fri Jul 05 18:40:58 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 05 18:40:58 2019" }, "message": "Add ChromeCleanupProtobufIPCFeature and ChromePromptChannelProtobuf\n\nIf the new feature is enabled, ChromeCleanerRunner will create a\nChromePromptChannel that connects to a pair of pipes instead of using\nMojo. A followup patch will serialize protobufs over the pipes for IPC\ncommunication.\n\nR\u003dproberge\nTBR\u003dwfh\nTBR_REASON\u003dSecurity reviewed by ajgo, who doesn\u0027t have a review bit.\n\nBug: 969139\nChange-Id: I9b9740ea6a8494d53eb9f2b436db844e87bf5bf0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669092\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: François Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#675078}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 72c3df370711992e4be35a44bdd8ca2b32abab30\n" }, { "commit": "5cb9c8a259dde613736d2bc9e563295409da1fc0", "tree": "6175b2e8e1a8a87d30a6ebb905a888d50e4bf5d1", "parents": [ "3be7b1cab3adbb759ba005577290030b785fd502" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Thu May 30 16:00:43 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 30 16:00:43 2019" }, "message": "Clean up kRebootPromptDialogFeature\n\nThe feature is now always on, and set to use a non-modal prompt dialog.\n\nAlso removes a reference to kQuarantineSwitch that was missed when cleaning up\nthe quarantine feature.\n\nR\u003dproberge\n\nBug: 948315\nChange-Id: Ib88c41101fff53fd0e39ff040e75dd6d028a5289\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636232\nReviewed-by: Jesse Doherty \u003cjwd@chromium.org\u003e\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#664759}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 525933f1c29266c9e328223f2fa088577828d52b\n" }, { "commit": "3be7b1cab3adbb759ba005577290030b785fd502", "tree": "d6b4dd3c3ad64002813ac9f7b82308633fde6104", "parents": [ "7043ad46b10c64fa6ef14973e50c54dbe99f95dc" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Tue Mar 19 23:24:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 19 23:24:59 2019" }, "message": "Use shorter enum names in ChromeCleaner tests\n\nThis works around a limitation in the test harness, that uses test names\nto generate file names that are limited to 255 characters on Windows.\n\nThe resulting test names are cryptic (eg.\n\"CleanerFindsUwS/ChromeCleanerControllerTest.WithMockCleanerProcess/Proc2_CrPt0_UwS1_Ext0_Items0_Items0_Resp0\")\nbut the enums can be matched to the right type by position so their\nexact value doesn\u0027t matter.\n\nR\u003dcsharp\n\nBug: 943231\nChange-Id: Icf05ede9652004d6872d76499215aad3e935376b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531382\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#642250}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2c7a5a94271e437f8933265353f7a45799bff8a1" }, { "commit": "7043ad46b10c64fa6ef14973e50c54dbe99f95dc", "tree": "64d44c676478fdef2d5ffad5a367fbfcfe95129d", "parents": [ "3325e7f88735114c75c5da6a2c7e3e7f07f2e8fb" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Mon Mar 04 18:50:44 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 04 18:50:44 2019" }, "message": "Add RESULT_CODE_TEST_ENGINE_SANDBOX_DISCONNECTED_TOO_SOON\n\nR\u003dproberge@chromium.org\n\nBug: 802092\nChange-Id: Ia18dc4278740e0b5e2a51ec8d00626fe1d781150\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499837\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#637368}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7d87915574fba5c4c432bd5a75079195de4d6064" }, { "commit": "3325e7f88735114c75c5da6a2c7e3e7f07f2e8fb", "tree": "c4821fbd716d400ffe83816525bb489bc50c4688", "parents": [ "49cbc71cd85757c8e311b3dc0879aa70cb3a0a14" ], "author": { "name": "Veranika Liaukevich", "email": "veranika@chromium.org", "time": "Thu Jan 31 16:33:10 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 31 16:33:10 2019" }, "message": "New exit codes to signal what the engine was scanning when it timed out.\n\nNew exit codes will be used by the software reporting tool to signal\nwhether the engine was scanning the registry or the file system at the\nmoment when the watchdog terminated the process.\n\nChange-Id: Ied95c7a8451ccbc4fb474bddddc22c2f116b8d97\nReviewed-on: https://chromium-review.googlesource.com/c/1446862\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Chris Sharp \u003ccsharp@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#627975}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2093e10385cf9c10b1383596d18e3298b07271df" }, { "commit": "49cbc71cd85757c8e311b3dc0879aa70cb3a0a14", "tree": "7b1322d6db1cc1c74ec0190a9c5bd83b68d17978", "parents": [ "091b51c7d91ddf7ee0b1ac6f9121677c084420eb" ], "author": { "name": "Chris Sharp", "email": "csharp@google.com", "time": "Thu Nov 29 16:01:30 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 29 16:01:30 2018" }, "message": "Fix ChromeCleanerRunnerTests to work with Extension Removal experiment\n\nAlso cleanup the test names to be more descriptive of what parameter were used.\n\nBug: 907443\nChange-Id: I4a42d1aad2856beda89911e63256ea8d0f67bb54\nReviewed-on: https://chromium-review.googlesource.com/c/1349751\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCommit-Queue: Chris Sharp \u003ccsharp@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#612217}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 57673cf76baaaf4f67eb5ca13e2d5338c965b2cd" }, { "commit": "091b51c7d91ddf7ee0b1ac6f9121677c084420eb", "tree": "cbc6a294cc4fa68ddff7d896b5f2b824d5a9c183", "parents": [ "d020f3097d49d0bae4694959b251fa60e327f97f" ], "author": { "name": "Juan Jose Lopez Jaimez", "email": "jjlopezjaimez@google.com", "time": "Thu Nov 22 20:58:45 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 22 20:58:45 2018" }, "message": "Rename RESULT_CODE_JSON_PARSER_SANDBOX_DISCONNECTED_TOO_SOON\n\nRESULT_CODE_JSON_PARSER_SANDBOX_DISCONNECTED_TOO_SOON should be renamed to\nRESULT_CODE_PARSER_SANDBOX_DISCONNECTED_TOO_SOON\n\nBug: b/117780288\nChange-Id: I99d8ac3f178fdef7453ff29cc0f274bae89dbbc4\nReviewed-on: https://chromium-review.googlesource.com/c/1348790\nCommit-Queue: Juan José Lopez Jaimez \u003cjjlopezjaimez@google.com\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#610486}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a1e93a695f76d88fd0eb2ac5cc070b420349a164" }, { "commit": "d020f3097d49d0bae4694959b251fa60e327f97f", "tree": "fa909bcf5fb22c86da7a2212532e0a3de97966dd", "parents": [ "ef3e6dcbb81ca3f604d96fe4ceb42331e51b391c" ], "author": { "name": "Veranika Liaukevich", "email": "veranika@chromium.org", "time": "Fri Nov 16 09:35:07 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 16 09:35:07 2018" }, "message": "Deprecate NO_PUPS_FOUND_NO_SIGNATURE_MATCH exit code of the cleaner\n\nThe code hasn\u0027t been used by the cleaner or the reporter for a long\ntime.\n\nChange-Id: I46e95300ac11d5c6d601bccafe1853b555de54f7\nReviewed-on: https://chromium-review.googlesource.com/c/1316170\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCommit-Queue: Veranika Liaukevich \u003cveranika@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#608710}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0bdd840823ae18097e3488071b4405b902898e59" }, { "commit": "ef3e6dcbb81ca3f604d96fe4ceb42331e51b391c", "tree": "783a1f705917d6d158b141f2db164c1c7320fd0d", "parents": [ "6449134aa006a834992ef089762f7af1603f3211" ], "author": { "name": "timidger", "email": "timidger@google.com", "time": "Tue Oct 16 18:51:26 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 16 18:51:26 2018" }, "message": "DisableExtensions now uninstalls them\n\nThis is to remain consistent in how the Chrome Cleanup Tool removes other force installed extensions. They interact badly with administrator permissions and so removing them entirely is cleaner than simply disabling like we do with normally installed extensions when the cleanup tool detects UwS.\n\nChange-Id: I1b6b814d521e78edccd7c603f1eae3ef7a9a6c5f\nReviewed-on: https://chromium-review.googlesource.com/c/1278852\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Preston Carpenter \u003ctimidger@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#600059}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 29c8bbfe2e81471ba503af1c03015f0315089b93" }, { "commit": "6449134aa006a834992ef089762f7af1603f3211", "tree": "d4e2d522ff22e2a1f386fed9022a4d6d7cd57519", "parents": [ "b31fc0d3daa71f976c0100fb81daf3c06ce3984d" ], "author": { "name": "timidger", "email": "timidger@google.com", "time": "Wed Oct 03 16:50:13 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 03 16:50:13 2018" }, "message": "Use version 3 for DisableExtensions not 2\n\nWe already shipped a chrome version with version 2 exposed, so the\nChrome Cleanup Tool will try to use this method when it doesn\u0027t exist\nunless we bump the minimum version.\n\nChange-Id: I6c0bf1209da85ea54f4e7d2d365d64ac8a98ba66\nBug: 889568\nReviewed-on: https://chromium-review.googlesource.com/1258296\nCommit-Queue: Preston Carpenter \u003ctimidger@google.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#596254}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0a78043deb1840d45ef6a4ee262ad0fc3b223709" }, { "commit": "b31fc0d3daa71f976c0100fb81daf3c06ce3984d", "tree": "3e5a9a5598d934e568be5e252193fec41f5f0907", "parents": [ "9e16a43cd674f29ff9864f1df1a7d5052748f598" ], "author": { "name": "timidger", "email": "timidger@google.com", "time": "Tue Oct 02 18:15:57 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 02 18:15:57 2018" }, "message": "Added minimum version to DisableExtensions method in chrome_prompt.mojom\n\nWithout the minium version flag the Chrome Cleanup Tool will try to use this method even when it\u0027s not available on older versions of Chrome.\n\nR\u003djoenotcharles@google.com\n\nChange-Id: I67846a30dca37f66f87a0ac04f1c687c739c4723\nReviewed-on: https://chromium-review.googlesource.com/c/1255571\nCommit-Queue: Preston Carpenter \u003ctimidger@google.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#595915}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 08937cd4b77fa549f0a1bf59cedf2c55c25b9a53" }, { "commit": "9e16a43cd674f29ff9864f1df1a7d5052748f598", "tree": "656bc2ef5e966a8c8483135454baa3d636155974", "parents": [ "a91f8bb8ccf15ad11718037a906ba9b1f47983b5" ], "author": { "name": "timidger", "email": "timidger@google.com", "time": "Thu Sep 27 14:18:17 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 27 14:18:17 2018" }, "message": "Added DisableExtension mojo method to the ChromePrompt interface.\n\nThis allows the Chrome Cleanup Tool to request Chrome to delete extensions it finds.\n\nThis was put in the mojom interface because it\u0027s the simplest way to add to the CCT\ninterface to Chrome. This has no real dependency on the chrome prompt\nworkflow.\n\nAlso changes the chrome cleaner to only build on platforms that support extensions as it was breaking on android (which we don\u0027t support).\n\nR\u003djoenotcharles@chromium.org, joenotcharles@google.com, kinuko@chromium.org, reillyg@chromium.org\n\nBug: 889568\nChange-Id: Idbbebda824e3d7764940773964f50045639617bd\nReviewed-on: https://chromium-review.googlesource.com/1207219\nCommit-Queue: Preston Carpenter \u003ctimidger@google.com\u003e\nReviewed-by: Demetrios Papadopoulos \u003cdpapad@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Jialiu Lin \u003cjialiul@chromium.org\u003e\nReviewed-by: Kinuko Yasuda \u003ckinuko@chromium.org\u003e\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#594711}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5afe20d8a0ec4fc02652bfb38d34ee2dbc201721" }, { "commit": "a91f8bb8ccf15ad11718037a906ba9b1f47983b5", "tree": "8d078471326df3e7958537f6586c0f92780aa4a5", "parents": [ "383c93d1bde388b473196c656b16f7149e108bf9" ], "author": { "name": "Chris Sharp", "email": "csharp@google.com", "time": "Mon Sep 24 22:51:07 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 24 22:51:07 2018" }, "message": "Add a chrome cleanup tool exit conditon for wrong architecture\n\nChange-Id: I2d5955ad226d16428cc28cc8e0c908663b9346f8\nReviewed-on: https://chromium-review.googlesource.com/1237866\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCommit-Queue: Chris Sharp \u003ccsharp@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#593727}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484" }, { "commit": "383c93d1bde388b473196c656b16f7149e108bf9", "tree": "b946decac7d02fbf99007e2d4f1e9a9d645c0a83", "parents": [ "ab2ecc251a75f79e0a35c8233f858aa820e1fb2b" ], "author": { "name": "Che-yu Wu", "email": "cheyuw@google.com", "time": "Tue Sep 11 16:21:33 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 11 16:21:33 2018" }, "message": "Add a chrome cleanup tool exit code for zip archiver sandbox.\n\nAdd an exit code for zip archiver sandbox to report unexpected sandbox disconnection.\n\nBug: crbug.com/881988\nChange-Id: Ib38a8cd85876fc8dc186e0c62a377f51d22f5ea2\nReviewed-on: https://chromium-review.googlesource.com/1216025\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Che-yu Wu \u003ccheyuw@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#590339}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b8a8c49e4d632959409fc1cf9347af656703ec16" }, { "commit": "ab2ecc251a75f79e0a35c8233f858aa820e1fb2b", "tree": "cd1210d233736240645c8a33e805e4172a77e0c3", "parents": [ "60cb65aafb6b817cbb08490a02b8816e154a577d" ], "author": { "name": "Che-yu Wu", "email": "cheyuw@google.com", "time": "Thu Aug 30 19:35:21 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Aug 30 19:35:21 2018" }, "message": "Chrome Cleaner: add finch switch for quarantine feature\n\nThe new quarantine feature for chrome cleanup tool needs a finch switch to control it.\nIt adds \"--quarantine\" into the command line when launching the cleaner if the switch is enabled.\nIt will be only enabled on the cleaner. So only adds switch to the cleaner, but not to the reporter.\nDefault is disabled.\n\nBug: crbug.com/878794\nChange-Id: Ibb6f7bf76c36fbaf6106ede1ee9b6049cb2c5d2e\nReviewed-on: https://chromium-review.googlesource.com/1194404\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Che-yu Wu \u003ccheyuw@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#587710}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d99f84674492c1cb5859f46e7f39a0250f8a0295" }, { "commit": "60cb65aafb6b817cbb08490a02b8816e154a577d", "tree": "1201a470a9058bac799dc8bfe4d1d97bc0c8b90f", "parents": [ "89fb84f3bb5796924fca0f01da56c276e954b1bf" ], "author": { "name": "Joe Mason", "email": "joenotcharles@chromium.org", "time": "Fri Aug 10 21:34:05 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 10 21:34:05 2018" }, "message": "Make ExecutionMode pretty-printer available for CHECK outside tests\n\nR\u003dproberge\n\nBug: 872748\nChange-Id: I42ae9acf6bd189ef45543ddfa15521262c56b95f\nReviewed-on: https://chromium-review.googlesource.com/1171549\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#582343}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: da2cbfa6d74f34482c227e4715bc0b03c3298f01" }, { "commit": "89fb84f3bb5796924fca0f01da56c276e954b1bf", "tree": "40eb406749036d3d9aa7021690626462a8810794", "parents": [ "1d8aca79da0a490a7af75d9773895e210da07a41" ], "author": { "name": "Joe Mason", "email": "joenotcharles@chromium.org", "time": "Fri Aug 10 19:24:16 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 10 19:24:16 2018" }, "message": "Re-enable pretty-printed ExecutionMode test names\n\nFix ODR violation with ExecutionMode by declaring the streaming operator in the\nsame header as the type, and add back the GetParamNameForTest calls that use\nthat operator.\n\nAlso add a streaming operator for ChromePromptValue so that all types declared\nin constants.h can be pretty-printed.\n\nR\u003dproberge\n\nBug: 872748\nChange-Id: Idfe3f6044f97b003f17d83c6985d442f9b4103f6\nReviewed-on: https://chromium-review.googlesource.com/1170852\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#582285}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 29182424f4d1c29a0914e09916a198f4d1a4897a" }, { "commit": "1d8aca79da0a490a7af75d9773895e210da07a41", "tree": "da921395af6bb33cae800e4a92ac40406d0be22c", "parents": [ "009acba4e569922abe65ca2b7c208fc9ce8ea35a" ], "author": { "name": "Nick Burris", "email": "nburris@google.com", "time": "Mon Jul 30 20:53:53 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jul 30 20:53:53 2018" }, "message": "Add result code for JSON parser sandbox disconnect\n\nSimilar to the engine sandbox and Chrome prompt IPCs, this result code\nindicates the sandbox connection was closed while it was still needed.\n\nBug: b/111108241\nChange-Id: I8b231c5921e51b57932ce8d5054f9dd0484be46f\nReviewed-on: https://chromium-review.googlesource.com/1154995\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCommit-Queue: Nick Burris \u003cnburris@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#579163}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0ef55feb968ef56840bdc913d2f0d3cb08d025e1" }, { "commit": "009acba4e569922abe65ca2b7c208fc9ce8ea35a", "tree": "7e81bcc9923335249f1b4b18633f1c2c67d952b7", "parents": [ "2baeea79dff35ea971ea5c91b8028e388aa6aa48" ], "author": { "name": "Nick Burris", "email": "nburris@google.com", "time": "Tue Jul 10 13:29:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 10 13:29:12 2018" }, "message": "Chrome Cleaner UI: Add extension IDs to ChromePrompt mojo interface.\n\n- For the interface, this is added in the same way as registry keys.\n- For chrome_cleaner_scanner_results, this is similar to registry keys\nexcept there\u0027s some extra work to fetch names for the extension IDs.\n- A following CL will use the extensions from\nchrome_cleaner_scanner_results on the cleanup settings page.\n\nBug: 853339\nChange-Id: I626fdb1ec08cd2d23711750496127480899bad74\nReviewed-on: https://chromium-review.googlesource.com/1103541\nReviewed-by: Ken Buchanan \u003ckenrb@chromium.org\u003e\nReviewed-by: proberge \u003cproberge@chromium.org\u003e\nCommit-Queue: Nick Burris \u003cnburris@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#573705}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9b7b8017caec75b7cb6f4d6763f9496178f24677" }, { "commit": "2baeea79dff35ea971ea5c91b8028e388aa6aa48", "tree": "68d9f7b215e83bc12d4f8bdf9d2333bbfdc90aa7", "parents": [ "3023378b16e737454098e30d5036e6e3ac0d36fe" ], "author": { "name": "Oksana Zhuravlova", "email": "oksamyt@chromium.org", "time": "Wed Apr 25 17:13:41 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 25 17:13:41 2018" }, "message": "Remove unused dependencies on //mojo/common:common_custom_types\n\nBug: 799482\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs\nChange-Id: I4b1a7da98378bc349986e92bfc1df845b655b0fc\nReviewed-on: https://chromium-review.googlesource.com/1025045\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Oksana Zhuravlova \u003coksamyt@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#553612}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c06c5deb5408ac466e1af35bc96c3b7533edf3c7" }, { "commit": "3023378b16e737454098e30d5036e6e3ac0d36fe", "tree": "8cce452df41efeea941be568e1de5bc0ee70bdcc", "parents": [ "333f77536c58f76b5cd59f0e1972a69613c7d49c" ], "author": { "name": "Joe Mason", "email": "joenotcharles@chromium.org", "time": "Thu Apr 19 14:39:00 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 19 14:39:00 2018" }, "message": "Move src/chrome_cleaner to src/chrome/chrome_cleaner\n\nBug: 834343\nChange-Id: I8da77e5ca6d253a3ba10e284911848d8a0952ce2\nReviewed-on: https://chromium-review.googlesource.com/1018142\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#552011}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 12a0233ebd5ab7d2028c1fd530edabd2b76a9aad" }, { "commit": "333f77536c58f76b5cd59f0e1972a69613c7d49c", "tree": "803badc98479223092dff006b2bb3045d6a28913", "parents": [ "d2dea7915d4826155ab87754660a94a9fa393718" ], "author": { "name": "Veranika Liaukevich", "email": "veranika@chromium.org", "time": "Tue Apr 17 20:05:49 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 17 20:05:49 2018" }, "message": "Chrome Cleaner: introduce an exit code for invalid scan switches\n\nChange-Id: Ie559fbf3eff5e7010b8ff0728a89a49aaa200731\nReviewed-on: https://chromium-review.googlesource.com/1015282\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#551447}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c5b940f4f293cc6ac57d11add66f1730c6d53e39" }, { "commit": "d2dea7915d4826155ab87754660a94a9fa393718", "tree": "efd5a20891a68e493a53391f598e20bd78501ab4", "parents": [ "c384fc2c6780ade96d48b567212fa9bf818f64d7" ], "author": { "name": "Veranika Liaukevich", "email": "veranika@chromium.org", "time": "Mon Apr 09 14:36:07 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 09 14:36:07 2018" }, "message": "Chrome Cleaner: forward reboot prompt method used by Chrome to the cleaner\n\nUsed reboot prompt method is recorded in UMA, but because immediately\nafter that Chrome initiates a machine reboot, the data is not always\nsuccessfully recorded and uploaded. This CL forwards prompt method\ninformation to the cleaner so that this information would be available to\nit too.\n\nBug: 770749\nChange-Id: Iec3e4fd902ab20b0c1cf477b852153e3de5eaeb5\nReviewed-on: https://chromium-review.googlesource.com/986283\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nCommit-Queue: Veranika Liaukevich \u003cveranika@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#549171}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 03c3670cf0f07c5b3fb7feb4535b69bd8ef83c00" }, { "commit": "c384fc2c6780ade96d48b567212fa9bf818f64d7", "tree": "c6a42701cbcbf1b14a09d6f57ec85759eb456a55", "parents": [ "c175285efa7c23f7f88937b7f76a256338a2147f" ], "author": { "name": "Joe Mason", "email": "joenotcharles@chromium.org", "time": "Mon Mar 19 18:49:30 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 19 18:49:30 2018" }, "message": "Make chrome_cleaner::ResultCode enum public.\n\nR\u003dcsharp, ftirelo\n\nChange-Id: I0e747d59f2a04b743283b69d0d5f55b56dc162b1\nReviewed-on: https://chromium-review.googlesource.com/966543\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#544086}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6c97f7fd1c9a29542931952effa8ec2293db8341" }, { "commit": "c175285efa7c23f7f88937b7f76a256338a2147f", "tree": "017a2339284a94479ef959a320254c2879f3302c", "parents": [ "aee05acb9c621f0875c5cdb7728a9a443f1f0156" ], "author": { "name": "Joe Mason", "email": "joenotcharles@chromium.org", "time": "Thu Feb 15 15:50:51 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 15 15:50:51 2018" }, "message": "Add top-level src/chrome_cleaner directory.\n\nRename swreporter watchlist to chrome_cleaner and add all chrome_cleaner\nrelated files and directories to it.\n\nUpdate other chrome_cleaner related OWNERS files to inherit from the new\ntop-level directory. Add a README.md to components/chrome_cleaner to\nexplain its relationship to the new directory.\n\nBug: 802092\nChange-Id: Iadd38f0e7e818c78c356f5ac4d14911cec191a77\nReviewed-on: https://chromium-review.googlesource.com/901724\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#537028}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 60ec2f36fc2187cf86d91b9d8a41b1832ada7344" }, { "commit": "aee05acb9c621f0875c5cdb7728a9a443f1f0156", "tree": "77dbf1b432376a2d0e7959d69ec2555674161d7c", "parents": [ "26a07b090c45c03915f6ee8f452ab78e40af51b5" ], "author": { "name": "Fabio Tirelo", "email": "ftirelo@chromium.org", "time": "Tue Jan 16 14:44:33 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 16 14:44:33 2018" }, "message": "Chrome Cleanup UI: send chrome-prompt switch\n\nThis help us check from cleaner logs if a report is for\na prompted user or if the user started the run from the\nSettings page.\n\nBug: 776538\nChange-Id: Iafa9e7f2452b357dd1670bddadf37abae9078a1b\nReviewed-on: https://chromium-review.googlesource.com/867515\nCommit-Queue: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#529421}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6323cb4cb8f47aa505567914adf9a05548ddadb8" }, { "commit": "26a07b090c45c03915f6ee8f452ab78e40af51b5", "tree": "73a4e90a597298621961a06b5db40a421d6758f8", "parents": [ "595ea878b2aae3ba2aa904ee79605fa8de09a8a2" ], "author": { "name": "Fabio Tirelo", "email": "ftirelo@chromium.org", "time": "Wed Dec 06 16:03:20 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 06 16:03:20 2017" }, "message": "Add proberge@ as OWNER of chrome_cleaner\n\nBug: \nChange-Id: I51c7f5c4b508b2846ba7af0feeee8085ca5e362c\nReviewed-on: https://chromium-review.googlesource.com/810054\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#522099}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bb9c79a7c74e18a7edd844c3ae7a2329844a5c33" }, { "commit": "595ea878b2aae3ba2aa904ee79605fa8de09a8a2", "tree": "bb2b2332d72ccde2ab6915851889ce8815920cd4", "parents": [ "01ee2f6f2c8904695ac7906089cd066a75f40a35" ], "author": { "name": "Fabio Tirelo", "email": "ftirelo@chromium.org", "time": "Fri Dec 01 18:34:29 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 01 18:34:29 2017" }, "message": "Chrome Cleaner UI: Enable cleaner logs from user-initiated runs\n\nBug: 776538\nChange-Id: If7988655050a3415d77fa551cbf9fff617d6a69d\nReviewed-on: https://chromium-review.googlesource.com/794531\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCommit-Queue: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#520992}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3e00925f68e2339dedf024e7f17453d47173460d" }, { "commit": "01ee2f6f2c8904695ac7906089cd066a75f40a35", "tree": "a97e6da655f7ee747e02ecc2f87f354526215aff", "parents": [ "1cc5f1a0aa631dbea0e5967fb948989cbe7869be" ], "author": { "name": "Joe Mason", "email": "joenotcharles@chromium.org", "time": "Thu Nov 30 17:52:28 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 30 17:52:28 2017" }, "message": "Experimental SwReporter is no longer experimental.\n\nMove the behaviour controlled by ExperimentalSwReporterEngine and\nExperimentalSwReporterEngineOnAllArchitectures outside the feature\nchecks so it is always on.\n\nThe exception is the \"tag\" parameter which is used in testing so must\nstill be set through a feature until the test scripts are updated.\n\nBug: 786964\nChange-Id: I06bd7a599b3ab61121daca939d3df60967b3c0e6\nReviewed-on: https://chromium-review.googlesource.com/779302\nCommit-Queue: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Gayane Petrosyan \u003cgayane@chromium.org\u003e\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#520595}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5d34ad9dc7e098dde5d66c919f08bc0f534f7c24" }, { "commit": "1cc5f1a0aa631dbea0e5967fb948989cbe7869be", "tree": "faf399723b12e98ddd04776e17013948639580ea", "parents": [ "cb06027206a20077aaaa645b8235e6c93932a505" ], "author": { "name": "Fabio Tirelo", "email": "ftirelo@chromium.org", "time": "Tue Nov 28 16:03:19 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 28 16:03:19 2017" }, "message": "Chrome Cleaner UI: Add support for user initiated cleanups\n\nThis introduces the concept of invocation type, which decides if\na reporter run should start immediately (if started by the user),\nand if logs are allowed or disallowed by the user.\n\nThis also deprecates behaviour BEHAVIOUR_ALLOW_SEND_REPORTER_LOGS,\nwhich should no longer be enabled by the reporter component\nmanifest.\n\nTo be sent in follow-up CLs:\n - cleaner logs from the scanner process based on user selection;\n - UMA histograms for the new flow;\n - UI changes to enable the new invocation type.\n\nBug: 776538\nChange-Id: I0093826b450dd29625ac22ae5939d932bb04bb86\nReviewed-on: https://chromium-review.googlesource.com/770050\nReviewed-by: Gayane Petrosyan \u003cgayane@chromium.org\u003e\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nReviewed-by: Sorin Jianu \u003csorin@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCommit-Queue: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#519700}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c6786c18e354b926f1a42c1f22b7c5f20bc3f918" }, { "commit": "cb06027206a20077aaaa645b8235e6c93932a505", "tree": "b0b7e23e98369945e08d0dcb96c0cc5112a9f057", "parents": [ "f2ec81a5c6cfd4c2505012a24a72b9ad87befb61" ], "author": { "name": "Fabio Tirelo", "email": "ftirelo@chromium.org", "time": "Tue Nov 28 00:47:33 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 28 00:47:33 2017" }, "message": "Chrome Cleaner UI: Add registry keys to Chrome prompt mojo interface\n\nRegistry keys removed or changed by the cleaner will be shown to the\nuser on the Settings page card and need to be provided by the cleaner\nvia the Mojo IPC. Those keys are only used for visualization (no\nvalidation will be done by Chrome) and we don\u0027t intend to add any\nsophisticated visualization support (such as expandable trees); because\nof that, we decided to go with the simplest approach and only transmit\nlists of strings instead of more structured data.\n\nThis CL only propagates registry keys to the places they may be used,\nso most files in this CL are simply adding a new parameter to\nfunctions. A follow-up CL will actually use the new parameter in UI\ncode.\n\nBug: 776538\nChange-Id: Ifd9faf79eea070d17452356c45ae37482bf77864\nReviewed-on: https://chromium-review.googlesource.com/780287\nCommit-Queue: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Jialiu Lin \u003cjialiul@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#519487}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1da3777815d2f91b045f85693d0fa3ff824b1646" }, { "commit": "f2ec81a5c6cfd4c2505012a24a72b9ad87befb61", "tree": "0c028724b0f1471352b5f9967ddb6e8b76b31cdc", "parents": [ "3db7d8ce14fb37a034ab33c8e3199c751c2b9704" ], "author": { "name": "Fabio Tirelo", "email": "ftirelo@chromium.org", "time": "Wed Oct 04 21:38:57 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 04 21:38:57 2017" }, "message": "Chrome Cleaner: collect srt field trial group name\n\nBug: \nChange-Id: Ib77d051ef0813cd63eafd92b578919f46982d26b\nReviewed-on: https://chromium-review.googlesource.com/700992\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: Fabio Tirelo \u003cftirelo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#506527}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fd6e1fed2d4f14dd51d3980f263fc8d237729e01" }, { "commit": "3db7d8ce14fb37a034ab33c8e3199c751c2b9704", "tree": "769399cf626f8c4fdd9da3209d9a7bd2bed9f110", "parents": [ "01532fbd36e2940c0b597e2a8683ebc72f73f645" ], "author": { "name": "Ken Rockot", "email": "rockot@chromium.org", "time": "Tue Oct 03 04:01:41 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 03 04:01:41 2017" }, "message": "Reland support for Mojom message ID scrambling\n\nFor now we just use the contents of //chrome/VERSION as the salt\nrather than generating a salt from the build datetime. This keeps\nthe build deterministic.\n\nThis CL also limits application of scrambled message IDs to desktop\nbuilds for Windows, Mac, and (non-Chrome OS) Linux.\n\nFinally this adds support for a second supplementary salt file to\nbe appended to the base salt. This can be used in the future to, e.g.,\naugment the public version salt with a private static salt at\nofficial build time.\n\nBUG\u003d673417\n\nChange-Id: Ieb7efcb261d75beb46d463af424a60d37556b009\nReviewed-on: https://chromium-review.googlesource.com/693037\nCommit-Queue: Ken Rockot \u003crockot@chromium.org\u003e\nReviewed-by: Yuzhu Shen \u003cyzshen@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#505941}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ba4171518d951ea2db7e3e6dddcd4ecaa5b1883d" }, { "commit": "01532fbd36e2940c0b597e2a8683ebc72f73f645", "tree": "860c0498054b860a3607f046d00e8656f7b23099", "parents": [ "53dd1fd7d4525138016d786e3d5f8ce346692c39" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Fri Aug 25 20:19:10 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 25 20:19:10 2017" }, "message": "Switch Mojo struct traits over to using base::span\n\nBug: 754077\nCq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel\nChange-Id: I54900486db36558a62a144aefe0dcc5ede099c1c\nReviewed-on: https://chromium-review.googlesource.com/620447\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Jeremy Roman \u003cjbroman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#497517}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ed5f6716a0014b3634ff3c7dbd1d6b94df81bd5f" }, { "commit": "53dd1fd7d4525138016d786e3d5f8ce346692c39", "tree": "63f84f21cb4289530f553d346bdfbffd12143f07", "parents": [ "80ff0f76a89827bde083c1b8ec6e0c107dff7123" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Wed Aug 09 20:04:43 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 09 20:04:43 2017" }, "message": "Evolve mojo::CArray/mojo::ConstCArray towards a future base::Span API\n\nAt some point, //base may implement a span abstraction to represent a\nlightweight view over an array of n elements of type T. This simplifies\nCArray/ConstCArray to make it easier for potential migration in the\nfuture:\n- Add a size deducing helper for constructing from a statically-sized\n array.\n- Reverse size_t and T* arguments to be more consistent with the usual\n argument order in STL.\n- Remove public access to fields and add getters.\n- Remove |max_size|: CArray can\u0027t really be resized upward, so just\n implement |subspan()| to support deserialization.\n\nCq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel\nChange-Id: I0116cd9a1f2e75e26ff515455267725324ee137e\nReviewed-on: https://chromium-review.googlesource.com/605029\nReviewed-by: Vladimir Levin \u003cvmpstr@chromium.org\u003e\nReviewed-by: Kinuko Yasuda \u003ckinuko@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#493114}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 37048f2c9a8e6e95ed4dc1d36a5048d9a031c89e" }, { "commit": "80ff0f76a89827bde083c1b8ec6e0c107dff7123", "tree": "551fc262aed792b278e755fbcd5894d5631a6732", "parents": [ "58466a9bbcae3ebd6a3f307d3d56895db53da85f" ], "author": { "name": "proberge", "email": "proberge@chromium.org", "time": "Fri Jul 14 17:02:21 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 14 17:02:21 2017" }, "message": "Chrome Cleanup: Do not use SBER/Scout for Cleaner logs\n\nNow that Chrome Cleanup has its own opt-in, the SBER/Scout state should\nnot be passed to the Cleaner\u0027s command-line to make sure it isn\u0027t\naccidentally used.\n\nBug: 690020\nChange-Id: I6f1ecb60f2a9d0bdb5c3f4bbab728621082a2879\nReviewed-on: https://chromium-review.googlesource.com/570349\nReviewed-by: Chris Sharp \u003ccsharp@chromium.org\u003e\nCommit-Queue: proberge \u003cproberge@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#486784}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 873c91ddf8e0576ef9482dcb4c6f7a29d2c33e40" }, { "commit": "58466a9bbcae3ebd6a3f307d3d56895db53da85f", "tree": "df6fea189894b62d1c1939a8432892f8335650da", "parents": [ "44a906eddb904c19d4d8a3b180cb4415d629f07a" ], "author": { "name": "proberge", "email": "proberge@chromium.org", "time": "Thu Jul 06 15:12:59 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 06 15:12:59 2017" }, "message": "Cleanup Tool: Update stale comments in component\u0027s constants.h\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2970193002\nCr-Original-Commit-Position: refs/heads/master@{#484597}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3b7b9b4fabebc7f4e6473fb4a3173c847b8337a1\n" }, { "commit": "44a906eddb904c19d4d8a3b180cb4415d629f07a", "tree": "b6a3af01f3edbbf266f7086a9c9c926ef4d6536a", "parents": [ "b8cb0987ba7e8b2799e16ef5e786be709845842b" ], "author": { "name": "alito", "email": "alito@chromium.org", "time": "Fri Jun 30 18:47:45 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jun 30 18:47:45 2017" }, "message": "Chrome Cleaner UI: Add logs upload permission checkbox to the dialog\n\nBUG\u003d736465\n\nReview-Url: https://codereview.chromium.org/2966453002\nCr-Original-Commit-Position: refs/heads/master@{#483777}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c6056e1924f90559fbf4649692a78b12b93e7506\n" }, { "commit": "b8cb0987ba7e8b2799e16ef5e786be709845842b", "tree": "f7b6a6caa70f629808309e78154242cbcff05049", "parents": [ "93bca58e4d0403f178011c7ece76bba0d72eba83" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Mon Jun 19 10:36:57 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jun 19 10:36:57 2017" }, "message": "Post-cleanup settings reset.\n\nTags the profile that accepted a cleanup and resets their settings\nonce the cleanup is confirmed.\n\nThe following cases are handled:\n1. cleanup finishes and doesn\u0027t require a reboot, the same browser\n session is still running: tagged profiles will be reset right away;\n2. cleanup finishes and doesn\u0027t require a reboot, but browser session\n has finished: settings for a tagged profile will be reset next\n time the user launches the browser for that profile;\n3. reboot required: settings for a tagged profile will be reset next\n time the user launches the browser for that profile, once a reboot\n is confirmed.\n\nFor case 1, cleanup is confirmed by means of the exit code of the\ncleaner process. Cases 2 and 3 rely on registry values written by the\ncleaner once a cleanup starts and once it confirms the cleanup. If a\nreboot is required, the registry value is written by a cleaner process\nscheduled to run post-reboot.\n\nBUG\u003d728136\n\nReview-Url: https://codereview.chromium.org/2906103002\nCr-Original-Commit-Position: refs/heads/master@{#480390}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 46b3422639844f33bfd2bf84f590c779a582c276\n" }, { "commit": "93bca58e4d0403f178011c7ece76bba0d72eba83", "tree": "e7c2fd37844a3eb9801411cf220e1784c2664712", "parents": [ "f4a24d2a27d451c701a71571318d6f6228503fdd" ], "author": { "name": "alito", "email": "alito@chromium.org", "time": "Fri Jun 16 21:10:54 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jun 16 21:10:54 2017" }, "message": "Chrome Cleaner: remove unused enum constant.\n\nRemoving the kPostRebootValidation enumerator that is no longer used\nin either Chromium or Chrome Cleaner code.\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2939423002\nCr-Original-Commit-Position: refs/heads/master@{#480168}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 359bd13b6b0c2a23dfd3cdc9704944d6feb9f115\n" }, { "commit": "f4a24d2a27d451c701a71571318d6f6228503fdd", "tree": "c67945ef6f1a059c58deef6d11e6407f2142890f", "parents": [ "8bfe00dea59c3942fada780f03ba94f27097027b" ], "author": { "name": "proberge", "email": "proberge@chromium.org", "time": "Wed Jun 14 19:44:11 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jun 14 19:44:37 2017" }, "message": "Chrome Cleaner: Remove indirect base::FilePath mojo dependency.\n\nThe dependency on mojo.common.mojom.FilePath resolves to base::FilePath\nthrough a [Native] typemap. The Chrome cleaner is an independent binary\nwhose version of base::FilePath will diverge from Chrome\u0027s base::FilePath,\ncausing compatibility issues down the line.\n\nThis will also allow the Chrome Cleaner project to set\nenable_mojom_typemapping to false.\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2932703006\nCr-Original-Commit-Position: refs/heads/master@{#479471}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4d3b5c089c535512ac4c9f4b79f95f7f216454d3\n" }, { "commit": "8bfe00dea59c3942fada780f03ba94f27097027b", "tree": "d3df37f72c6e07704e162aabe568fb41c8f5bd8c", "parents": [ "f28fe6a151cafba30bea40aa90bf04237aa219a9" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Tue Jun 06 03:20:41 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 06 03:20:41 2017" }, "message": "Simplify the Mojo interface with the Chrome Cleaner.\n\nAfter the last UI iteration, we decided to not show UwS names and\nobserved behaviors. The cleaner current must run elevated, so we\npostponed passing that flag until we actually need it.\n\nBUG\u003d728136\n\nReview-Url: https://codereview.chromium.org/2916903002\nCr-Original-Commit-Position: refs/heads/master@{#477170}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a31fd7ecd08449ad6790e5976982f9f31ca01821\n" }, { "commit": "f28fe6a151cafba30bea40aa90bf04237aa219a9", "tree": "13cb9728a58322ce6e8a08395986c994a144973f", "parents": [ "f72d10b3fe25d347c1497f1959da86acc2cfd3ed" ], "author": { "name": "alito", "email": "alito@chromium.org", "time": "Thu May 25 20:21:46 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu May 25 20:21:46 2017" }, "message": "Chrome Cleaner UI: Reporter no longer uses mojo.\n\nThe reporter will no longer use mojo to communicate with Chrome.\nThat will instead be the responsibility of the Chrome Cleaner process.\n\nBUG\u003d690020\n\nReview-Url: https://codereview.chromium.org/2890023005\nCr-Original-Commit-Position: refs/heads/master@{#474778}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bb6caf2e8acec41914ace77fdd974ca7a8b1c261\n" }, { "commit": "f72d10b3fe25d347c1497f1959da86acc2cfd3ed", "tree": "915590b3a74f93f2d0d7916d741504148556e99b", "parents": [ "204aa95c49ff38e11906289142646c4db70d3585" ], "author": { "name": "robertshield", "email": "robertshield@chromium.org", "time": "Tue May 23 17:55:40 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Tue May 23 17:55:40 2017" }, "message": "Add team mailing list to chrome_cleaner OWNERS files.\n\nBUG\u003d679905\n\nReview-Url: https://codereview.chromium.org/2900053002\nCr-Original-Commit-Position: refs/heads/master@{#473970}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d83b5e0dd07bc1175edffe4dffc828f94fce5305\n" }, { "commit": "204aa95c49ff38e11906289142646c4db70d3585", "tree": "5eb50a8f98a6e9d2b6995ce1d4cc3abf92abdd05", "parents": [ "d2d4eea7ad9bf45abf5b6ecd1e8361aed100e726" ], "author": { "name": "tzik", "email": "tzik@chromium.org", "time": "Thu May 11 07:14:28 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu May 11 07:14:28 2017" }, "message": "Enable use_once_callback on mojom GN rule by default\n\nThis CL enables use_once_callback flag on the Mojo code generation by\ndefault, and disables the flag on affected rules, so that the new code starts\nusing OnceCallback by default, and we can track rules to migrate easily.\n\nBUG\u003d714018\nCQ_INCLUDE_TRYBOTS\u003dmaster.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel\n\nReview-Url: https://codereview.chromium.org/2843353004\nCr-Original-Commit-Position: refs/heads/master@{#470858}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0639e21a33c73f3e316ce84a490b1d50ceaa024b\n" }, { "commit": "d2d4eea7ad9bf45abf5b6ecd1e8361aed100e726", "tree": "ccc9fc1f1e30fe74670f0c5a9d196328a8e3de7e", "parents": [ "a843061e349a4242dd1acc12e416e4348a965f5c" ], "author": { "name": "tzik", "email": "tzik@chromium.org", "time": "Tue May 09 14:23:38 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Tue May 09 14:23:38 2017" }, "message": "Use OnceCallback on Mojo interfaces in //components/chrome_cleaner\n\nThis CL flips `use_once_calback` flag on the Mojo code generator, and\nfixes all compile errors after it. After this CL, Mojo interfaces in\n//components/chrome_cleaner starts using base::OnceCallback instead of\nbase::Callback on its return value handling.\n\nThe migration recipe was:\n - Convert pass-by-ref callback objects to pass-by-value.\n - Use std::move() to forward it to other consumer, or to invoke it\n with Callback::Run().\n - Handle wherever copies are required manually.\n - Check if the conversion doesn\u0027t change the semantics. As the transfer\n and invocation clobber the callback object, care about use-after-move.\n It\u0027s considered safe to consume almost scoped-out callback.\n\nBUG\u003d714018\n\nReview-Url: https://codereview.chromium.org/2867723002\nCr-Original-Commit-Position: refs/heads/master@{#470322}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5fa4456aa172ddb1dd6bb47036786bb94375fd62\n" }, { "commit": "a843061e349a4242dd1acc12e416e4348a965f5c", "tree": "5eb50a8f98a6e9d2b6995ce1d4cc3abf92abdd05", "parents": [ "21e442085a5fb0386b18603cc0a5b6b3dba4a01c" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Fri Apr 28 01:46:47 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 28 01:46:47 2017" }, "message": "Use mojo.common.mojom.FilePath to represent file paths\n\nBUG\u003d690020\n\nReview-Url: https://codereview.chromium.org/2842163003\nCr-Original-Commit-Position: refs/heads/master@{#467812}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0b6049cb383da885119055f499d26ff50d78a37c\n" }, { "commit": "21e442085a5fb0386b18603cc0a5b6b3dba4a01c", "tree": "df0a28cf89c6bc4ff8c341d17e6ef903a1ed79d9", "parents": [ "fe1d760501b0adf0e5b5b3ed805902aac27000d5" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Mon Apr 24 18:09:37 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 24 18:09:37 2017" }, "message": "Add min and max to ExecutionMode enum.\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2830273003\nCr-Original-Commit-Position: refs/heads/master@{#466683}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1ddbcd0c22d5f814f9e9853dc06c54ee38159416\n" }, { "commit": "fe1d760501b0adf0e5b5b3ed805902aac27000d5", "tree": "8fcc06d8bc6ab36659794c0813b7997792d7c410", "parents": [ "e7014c56b2a9168d6f881f74037217b382d3c1e2" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Fri Apr 21 18:09:49 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 21 18:09:49 2017" }, "message": "Define post reboot validation mode\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2831393002\nCr-Original-Commit-Position: refs/heads/master@{#466391}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fcceddd71b284285aec3ba2e14299e55e2b4a424\n" }, { "commit": "e7014c56b2a9168d6f881f74037217b382d3c1e2", "tree": "66e25f0a8863d57d74f05ff4fb843999ede3f46b", "parents": [ "18483be81cb56cd62cae10e40d35950d3cefdbda" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Thu Apr 20 20:43:42 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 20 20:43:42 2017" }, "message": "Move shared constants to //components/chrome_cleaner\n\nBUG\u003d709035\n\nReview-Url: https://codereview.chromium.org/2831103002\nCr-Original-Commit-Position: refs/heads/master@{#466117}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 60ed9879a5363d0413f70b40569a14c7b11f42f3\n" }, { "commit": "18483be81cb56cd62cae10e40d35950d3cefdbda", "tree": "38da8c1d9616da63baf132ecab2270ad7815996f", "parents": [ "e3dca59efd37a3709aea65e6d1d8eeaaf3253e7f" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Wed Apr 19 21:44:25 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 19 21:44:25 2017" }, "message": "Sends execution mode to the Software Reporter.\n\nBUG\u003d690020\n\nReview-Url: https://codereview.chromium.org/2831653002\nCr-Original-Commit-Position: refs/heads/master@{#465763}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ab6b83a2f81557c6cd8b0eff1f3306ef1ba87cfc\n" }, { "commit": "e3dca59efd37a3709aea65e6d1d8eeaaf3253e7f", "tree": "f06d01ae161a408722c6858960102dde927ac14a", "parents": [ "96a58b6a5b0c56481677e06c89d913126bd552a2" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Tue Apr 18 21:32:15 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 18 21:32:15 2017" }, "message": "Move shared constants to //components/chrome_cleaner\n\nBUG\u003d709035\n\nReview-Url: https://codereview.chromium.org/2812223003\nCr-Original-Commit-Position: refs/heads/master@{#465380}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6e1d09bf3327be410524f9d594c7c218b5845de3\n" }, { "commit": "96a58b6a5b0c56481677e06c89d913126bd552a2", "tree": "3e7e4dfac7c0388e75fbc96550c857ffc8d54ded", "parents": [ "aaa377e92f4e99aed9ca169f631c376605aa6ff7" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Thu Apr 13 01:12:15 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 13 01:12:15 2017" }, "message": "Replace elevation required bool with an enum.\n\nBUG\u003d690020\n\nReview-Url: https://codereview.chromium.org/2813253002\nCr-Original-Commit-Position: refs/heads/master@{#464226}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: daf91016aa4560f3c0f72d50eee762eed996fc0e\n" }, { "commit": "aaa377e92f4e99aed9ca169f631c376605aa6ff7", "tree": "8f663ac40a137245a4a1257889d0815f0380c6cd", "parents": [ "40408b0e647db722b8b177de6868a691df3f9e99" ], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Thu Apr 06 18:11:21 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 06 18:11:21 2017" }, "message": "Add joenotcharles@chromium.org to //components/chrome_cleaner/OWNERS\n\nBUG\u003d\n\nReview-Url: https://codereview.chromium.org/2799683006\nCr-Original-Commit-Position: refs/heads/master@{#462546}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6ecdc73020ac2ee848d1b0d498f4827008429773\n" }, { "commit": "40408b0e647db722b8b177de6868a691df3f9e99", "tree": "50daed0bca00982df13dcb9a71a100d0fe8086aa", "parents": [], "author": { "name": "ftirelo", "email": "ftirelo@chromium.org", "time": "Fri Mar 31 20:36:34 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 31 20:36:34 2017" }, "message": "Mojo interface shared between Chromium and the Chrome Cleaner.\n\nOriginally this was committed in a separate repo. However, instead of\nchecking this code intro Chromium as third_party, we decided to have it\nchecked here and create a new repo to mirror components/chrome_cleaner.\nIt will be pulled via gitdeps in the cleaner repo as:\n\nhttps://chromium.googlesource.com/chromium/components/chrome_cleaner/src\n\nBUG\u003d690020\n\nReview-Url: https://codereview.chromium.org/2782243002\nCr-Original-Commit-Position: refs/heads/master@{#461211}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f262313c8d7581399b0a5c256e5c75ecf97246bc\n" } ] }