)]}' { "log": [ { "commit": "01b147f07f6b685a0bc3c941a2e65c0b6dc39475", "tree": "dfb6b3335fe678d6686d8bf3898a99fb84cc1340", "parents": [ "654315e63715e3f148c3bede65b21788e9b7d8ee" ], "author": { "name": "Andrew Paseltiner", "email": "apaseltiner@chromium.org", "time": "Thu May 14 22:43:46 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 14 22:55:26 2026" }, "message": "[cbor] Optimize Reader::ReadStringContent and simplify Reader::ReadBytes\n\n- ReadBytes is simplified to use base::span::take_first, which removes\n the need for manual subspan management.\n- ReadStringContent is optimized to perform UTF-8 validation directly on\n a std::string_view created from the input span, delaying the\n creation of an owned std::string until after the check succeeds.\n- ReadByteStringContent is simplified to use the Value constructor that\n directly accepts a span.\n- Redundant and unreachable checks in DecodeToSimpleValueOrFloat are\n removed.\n\nBug: 512819016\nChange-Id: I76f39df7e7cc90ad7978f16d51e321fa1f4555f2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7842160\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Andrew Paseltiner \u003capaseltiner@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1630818}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fc99a318e9ab57650704c7a217b1f958ff9d6eef\n" }, { "commit": "654315e63715e3f148c3bede65b21788e9b7d8ee", "tree": "e52d90ddfdd088f3ec21ebb2ede7de4a0664773e", "parents": [ "ce17bf3b250db913c8b845b793357f9f42ea8fe4" ], "author": { "name": "Andrew Paseltiner", "email": "apaseltiner@chromium.org", "time": "Thu May 14 12:28:54 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 14 12:42:47 2026" }, "message": "[CBOR] Modernize reader_fuzzer\n\nThis CL modernizes reader_fuzzer.cc by using base::span and the\nDEFINE_LLVM_FUZZER_TEST_ONE_INPUT_SPAN macro. It also removes\nunconditionally true if statements and unnecessary // nogncheck comments\nand replaces unsafe memcmp with safe span comparisons.\n\nBug: 512819016\nChange-Id: I7dd5e24b57cd1e3c427bc21920669b1cda00d96d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7843149\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCommit-Queue: Andrew Paseltiner \u003capaseltiner@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1630585}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2414dea6b0da583df77277b2be962645a4ee4902\n" }, { "commit": "ce17bf3b250db913c8b845b793357f9f42ea8fe4", "tree": "472dd80d62db3e3c1f692b1aee7fa9e8ede93b09", "parents": [ "99d2bda213e0907054fff23a0e944666e080a85e" ], "author": { "name": "Andrew Paseltiner", "email": "apaseltiner@chromium.org", "time": "Thu May 14 12:27:26 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 14 12:41:26 2026" }, "message": "[cbor] Remove unused cbor::Value(Type) constructor\n\nChange-Id: Ia48cbbe64d6b1307d43f35d9911711f11ca59c98\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7844185\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Andrew Paseltiner \u003capaseltiner@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1630584}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 84bb1dc9ab9b2d90c23ea6d5f7707921e445cb03\n" }, { "commit": "99d2bda213e0907054fff23a0e944666e080a85e", "tree": "47d2bdd08df2f25322723abcf71254c41f261c93", "parents": [ "b7fbdb0b5015a77eccc6a3b01596fbd3e56f91e7" ], "author": { "name": "Andrew Paseltiner", "email": "apaseltiner@chromium.org", "time": "Thu May 14 03:35:23 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 14 03:36:50 2026" }, "message": "[cbor] Optimize map parsing in Reader::ReadMapContent\n\nThis CL optimizes the map parsing logic in Reader::ReadMapContent by\nconsolidating duplicate key and ordering checks. By using\nstd::map::try_emplace, the implementation reduces the number of full\ntree traversals from two (one for the duplicate check and one for\ninsertion) to just one. The ordering check is then performed in O(1)\ntime by verifying that the newly inserted element is at the end of the\nmap. This simplifies the logic and improves performance by avoiding\nredundant searches and eliminating an additional key comparison that was\npreviously required to verify canonical ordering.\n\nFurthermore, the final MapValue (base::flat_map) construction is\noptimized by collecting elements into a std::vector and using the\nbase::sorted_unique constructor. This avoids the redundant comparisons\nand overhead that were previously performed when using emplace_hint to\nmove elements from the temporary std::map into the final flat_map.\n\nBug: 512819016\nChange-Id: I5f3a98ef0a1ba7aa9a022252d48d477110fbc7bd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7841836\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Andrew Paseltiner \u003capaseltiner@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1630426}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9a19c910aad5a8a5679f50bde8d8c4bc84a7183\n" }, { "commit": "b7fbdb0b5015a77eccc6a3b01596fbd3e56f91e7", "tree": "3ca82eb1874a522c9bc6901e488923d2f8ebf74f", "parents": [ "c5027e5591e3a3af00c64753e88123b16700aa5a" ], "author": { "name": "Andrew Paseltiner", "email": "apaseltiner@chromium.org", "time": "Wed May 13 17:01:31 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 13 17:20:36 2026" }, "message": "[cbor] Fix error code overwriting in Reader::ReadMapContent\n\nThis changes fixes a bug in which the error code for a failed key\ndecoding in a CBOR map could be overwritten by a subsequent decoding\nattempt of the corresponding value. We now return early if the key fails\nto decode, as otherwise the value-decode was likely to be desynchronized\nanyway.\n\nIn a followup CL, we will consider DCHECKing that the error code is\nNO_ERROR in each method that does a read, effectively poisoning the\nreader on error, which would theoretically be caught by the fuzzer.\nAlternatively, the error code field could be removed in favor of\nreturning base::expected\u003cT, DecoderError\u003e.\n\nFixed: 512821715\nChange-Id: I19591615b5f902030137190cb140df36b2ff33cd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7845076\nCommit-Queue: Andrew Paseltiner \u003capaseltiner@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1630046}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 41fdf44d9cb015ab26b2cbba2ef8ca79c4b375d6\n" }, { "commit": "c5027e5591e3a3af00c64753e88123b16700aa5a", "tree": "77cc5de74e4d6ded1b34d3c02f49c3e30d395617", "parents": [ "ffdc2524fe753546c6c05da27e90494b3c0ffd18" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Dec 04 14:48:47 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 04 14:55:33 2025" }, "message": "Convert to UNSAFE_TODO in components [2/4]\n\nThis is an automated #cleanup patch using the [Script] below.\n\nWe are migrating from coarse-grained file-level suppression (#pragma\nallow_unsafe_buffers) to granular, expression-level markers\n(UNSAFE_TODO()). The pragma disables safety checks for an entire file,\nwhereas UNSAFE_TODO() isolates specific potentially unsafe operations,\nallowing the rest of the file to be enforced as safe.\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nR\u003dblundell@chromium.org\n\nScript: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp\u003dsharing\nAX-Relnotes: N/A\nCleanup: This is an automated #cleanup.\nBug: 409340989\nChange-Id: I1a1cb2499719c08a8afe58fc4049df2e9102d041\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228423\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1553973}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 50bb666eb506b73adebc4b1ad579d4c57dec5b03\n" }, { "commit": "ffdc2524fe753546c6c05da27e90494b3c0ffd18", "tree": "c267c7bc8abe521fe6e8afb4fdebca88003e6372", "parents": [ "94d24d6f2453ffd3f51df96a0102be0a9be860c4" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Dec 02 20:59:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 02 21:23:38 2025" }, "message": "Begin converting code to use base\u0027s string_view helpers.\n\nAvoid writing two-arg string view constructors, which may\nsomeday be treated as the UNSAFE_BUFFER_USAGE that they are.\n\nChange-Id: I601ffa3337106a5b521596d3047daf29f4808f36\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7136975\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1553042}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0dace75e34a13ab577cad337c1ead1de2f872c75\n" }, { "commit": "94d24d6f2453ffd3f51df96a0102be0a9be860c4", "tree": "978a99581f8633f702ace2e6293379049f235cf8", "parents": [ "0c2576c17a86cab8382f5f164e8b5beafec27a83" ], "author": { "name": "Ho Cheung", "email": "hocheung@chromium.org", "time": "Fri Aug 08 00:38:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 08 00:55:54 2025" }, "message": "[cbor] Use std::map::extract() in ReadMapContent\n\nReplace key clone with C++17 std::map::extract().\n\nBug: 40205788\nChange-Id: I5c1ed740042e1299bcf9cd819a0a3affc5a07102\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6827825\nCommit-Queue: Ho Cheung \u003chocheung@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1498545}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6a9fdff0cd93cfe2c99badb475d8ee40f4230de2\n" }, { "commit": "0c2576c17a86cab8382f5f164e8b5beafec27a83", "tree": "6d468649ef60d44a211dfb3cd11380155a9dc137", "parents": [ "3c4d94ec658366df3f6d6e7d349763a132831ab6" ], "author": { "name": "Claudio DeSouza", "email": "cdesouza@chromium.org", "time": "Sat Jul 12 02:47:47 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jul 12 02:53:32 2025" }, "message": "[exit-time-destructors] Exclude target with warnings\n\nThis CL is part of number of CLs disabling `-Wexit-time-destructors`in\nplaces where this warning is going off. This will allow having this\nwarning enabled-by-default across the codebase, whilst documenting the\nplaces where corrections for this warning are necessary.\n\nThis change exclude targets under:\n - components/cbor\n\nThis CL was uploaded by git cl split.\n\nR\u003dtsepez@chromium.org\n\nBug: 40031409, 430332953\nChange-Id: I71e5a9ef8e475a3ad9b86cecb1a028b229fa463e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6724844\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nAuto-Submit: Claudio DeSouza \u003ccdesouza@chromium.org\u003e\nCommit-Queue: Claudio DeSouza \u003ccdesouza@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1485920}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f7644d6ea937fbb72b12fa25c02aa22ebe6e4511\n" }, { "commit": "3c4d94ec658366df3f6d6e7d349763a132831ab6", "tree": "2a8ce37354d4e1970ee12d943d2c8e3856de33be", "parents": [ "65be2657661e1e491ab016bfd8a6fd1dcaf8cede" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Tue May 06 21:23:23 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 21:46:31 2025" }, "message": "Exported things should always be visible\n\nThis changes our COMPONENT_EXPORT macros to make the things they export\nvisible all the time on non-windows, rather than making them visible in\nthe named component only. This avoids subtle bugs where things defined\nin multiple components end up with one copy per component, only one of\nwhich is visible, and so the linker doesn\u0027t know it\u0027s supposed to dedup\nthem.\n\nSome, but not all, of these issues are detected by the new clang warning\n-Wunique-object-duplication. This change addresses some instances of that\nwarning firing on chromium code, but not all. Conversely, there are likely\ninstances which the warning does not catch, which are fixed by this CL.\n\nBug: 368047728\nChange-Id: I829a9bd84e57e3c7d80ec33aea0408951019bde7\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6264795\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Devon Loehr \u003cdloehr@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1456614}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: edf57482697bfb2777c28ab56977f5c448fa5c2d\n" }, { "commit": "65be2657661e1e491ab016bfd8a6fd1dcaf8cede", "tree": "ba3c9bd1e0cfb86878ab09d34e9229aabbafdc92", "parents": [ "4760d108d5bf1df2339a7e592847771b511ecdc0" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Wed Nov 13 22:26:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 13 22:47:47 2024" }, "message": "Migrate remaining NOTREACHED()s in components/\n\nNOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.\nThe former is [[noreturn]] so this CL also performs dead-code removal\nafter the NOTREACHED().\n\nThis CL does not attempt to do additional rewrites of any surrounding\ncode, like:\n\nif (!foo) {\n NOTREACHED();\n}\n\nto CHECK(foo);\n\nThose transforms take a non-trivial amount of time (and there are\nthousands of instances). Cleanup can be left as an exercise for the\nreader.\n\nBug: 40580068\nChange-Id: I72205fb77747957c6bf33dbea93656fd20085a42\nLow-Coverage-Reason: OTHER Should-be-unreachable code\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6010008\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nOwners-Override: Rick Byers \u003crbyers@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1382618}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 77d2135a331b8cf68960469a20e58117c82d395b\n" }, { "commit": "4760d108d5bf1df2339a7e592847771b511ecdc0", "tree": "d56f1c46720de234451501aeda8707eba377d4dd", "parents": [ "01e941f132b501530b57a2e1788726294d9115b4" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Thu Oct 24 17:29:45 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 24 17:38:59 2024" }, "message": "Remove unsafe buffer usage from c/cbor/values.cc\n\nBug: 40285824\nChange-Id: I3091673db5d8581dbf77523370d8e35c9d306d1f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961336\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1373406}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ee3e75bc3bdc7d9cb68158bcd59d81488776635a\n" }, { "commit": "01e941f132b501530b57a2e1788726294d9115b4", "tree": "dd1fd54a19a6d18371b1a2d882eb8a3c7753e7c5", "parents": [ "10d0a11b998d2cca774189ba26159ad4e1eacb7f" ], "author": { "name": "Sorin Jianu", "email": "sorin@chromium.org", "time": "Fri Oct 04 03:35:55 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 24 17:38:29 2024" }, "message": "components: default the user-defined empty ctor and dtor where possible\n\nI need an owner\u0027s approval please for changes under:\ncomponents/cbor\n\nThis is a mechanical change. There are a few instances (but not all)\nof empty user-defined constructors and destructors which can be\ndefaulted in the /components code.\n\nThis CL was uploaded by git cl split.\n\nR\u003ddcheng@chromium.org\n\nBug: 371316188\nChange-Id: I28104d14388c6c6f7f956bce950448a5052c30a0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908592\nAuto-Submit: Sorin Jianu \u003csorin@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1364025}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ad029cb7bcb984bad570f0f22eababa464357431\n" }, { "commit": "10d0a11b998d2cca774189ba26159ad4e1eacb7f", "tree": "9d6dcf3b0e3d175f8159b9103db6b02a5693b292", "parents": [ "6eed840e2f5738ee7c39720c6bb2258035328d13" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Wed Jul 31 08:29:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 31 08:36:55 2024" }, "message": "spanification: Add `#pragma allow_unsafe_buffers` to component/*\n\nSee `//docs/unsafe_buffers.md`\n\nThis is a preparation to fix each files.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nAX-Relnotes: n/a.\nBug: 40285824\nChange-Id: I24ff0aee7a6cbe6da11a08830135449ccf8f2ae2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5717711\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Cait Phillips \u003ccaitkp@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1335315}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b948e67a9c2fa2f8adff2206ef00cccde3f8640a\n" }, { "commit": "6eed840e2f5738ee7c39720c6bb2258035328d13", "tree": "9a31426f210b45daf1334f28786f3d329dbc19ad", "parents": [ "11e9440ec6b0beb89e0edd4e8d0e27abab0f577f" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Thu Jun 27 19:26:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 27 19:36:01 2024" }, "message": "Remove comment from cbor::Value that it doesn\u0027t support floating point.\n\nLooks like support was added in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/4658097 and\nhttps://chromium-review.googlesource.com/c/chromium/src/+/4660529,\nbut the comment about not supporting floating point wasn\u0027t removed.\n\nBug: 1442274\nChange-Id: I86a75a894b6830a727701f63a2c3b422ee96434d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5664454\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: mmenke \u003cmmenke@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1320562}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 38aa28bb275fed6479d14a431fa246acc4082b4d\n" }, { "commit": "11e9440ec6b0beb89e0edd4e8d0e27abab0f577f", "tree": "3e2a7ac99647523beee4293d1d6bd80081ad5de9", "parents": [ "7e827f68f485c2e2f6732f416bc7202af4e07243" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Mon Jun 17 16:27:13 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 17 16:33:33 2024" }, "message": "Rewrite base::span fields into base::raw_span\n\nThe following benchmarks were launched to ensure the cl does not\nintroduce any performance regression:\nhttps://pinpoint-dot-chromeperf.appspot.com/job/1557e576fe0000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/14679948410000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/1138a382410000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/151ced98410000\n\nThe first patch was generated using the SpanRewriter tool which\nis part of the raw_ptr rewriter in:\ntools/clang/rewrite_raw_ptr_fields/RewriteRawPtrFields.cpp\nThe later patches are manual fixes.\n\nDanglingUntriaged-notes: Annotating pre-existing dangling pointers.\nBug: 332587642\nChange-Id: Ie6f01a2f4e6ec1f92f66d7cf918705728c39c3dd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515096\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1315913}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ad8f16951d78c92fcb412414db3f72201756044a\n" }, { "commit": "7e827f68f485c2e2f6732f416bc7202af4e07243", "tree": "065c801ab22e624b736f845efa1d28ebbdc3230f", "parents": [ "45874d5ada53dc0f47d67d9b89a2475845eb738b" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Tue May 14 22:08:09 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 14 22:24:59 2024" }, "message": "Use NOTREACHED_IN_MIGRATION() in components/\n\nThis was generated by replacing \" NOTREACHED()\" with\n\" NOTREACHED_IN_MIGRATION()\" and running git cl format.\n\nThis prepares for making NOTREACHED() [[noreturn]] alongside\nNotReachedIsFatal migration of existing inventory.\n\nBug: 40580068\nChange-Id: I92e83d0b564d44267f003147a1ce6ba3674621a4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539175\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1300923}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: aaf19db38dc2303e055df0d45f03155d99dbde46\n" }, { "commit": "45874d5ada53dc0f47d67d9b89a2475845eb738b", "tree": "01a81cb285befcf6a911a6d2bbe022e61f738a0e", "parents": [ "3be48d097db0f3424d137b498c37d8bc621974d4" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Wed May 01 20:04:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 01 20:13:27 2024" }, "message": "Convert base::StringPiece to std::string_view in //components 1/5\n\nThe changes of this CL are made using the following script.\nScript: https://issues.chromium.org/issues/40506050#comment343\n\nBug: 40506050\nChange-Id: I84d00d5e35ae595ecf018c0a7a80cc30d09e01d1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501048\nCommit-Queue: Helmut Januschka \u003chelmut@januschka.com\u003e\nAuto-Submit: Helmut Januschka \u003chelmut@januschka.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1295041}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 26faf71596faafbf3893f795e7554dfe7f0b392d\n" }, { "commit": "3be48d097db0f3424d137b498c37d8bc621974d4", "tree": "d6c427c811b0e33cb37e71810ae2e7d5d06952de", "parents": [ "f5a9e5a34a7dd2fa812bc5ce5d059bc946f1a024" ], "author": { "name": "Alison Gale", "email": "agale@chromium.org", "time": "Tue Apr 16 00:00:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 16 00:06:23 2024" }, "message": "Migrate TODOs referencing old crbug IDs to the new issue tracker IDs\n\nThe canonical bug format is TODO(crbug.com/\u003cid\u003e). TODOs of the\nfollowing forms will all be migrated to the new format:\n\n- TODO(crbug.com/\u003cold id\u003e)\n- TODO(https://crbug.com/\u003cold id\u003e)\n- TODO(crbug/\u003cold id\u003e)\n- TODO(crbug/monorail/\u003cold id\u003e)\n- TODO(\u003cold id\u003e)\n- TODO(issues.chromium.org/\u003cold id\u003e)\n- TODO(https://issues.chromium.org/\u003cold id\u003e)\n- TODO(https://issues.chromium.org/u/1/issues/\u003cold id\u003e)\n- TODO(bugs.chromium.org/\u003cold id\u003e)\n\nBug id mapping is sourced from go/chrome-on-buganizer-prod-issues.\nSee go/crbug-todo-migration for details.\n\n#crbug-todo-migration\n\nBug: b/321899722\nChange-Id: I89f0a4d7ddeb7c9585f3a0e5421aef8ce5a6f0f2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455854\nReviewed-by: Taylor Bergquist \u003ctbergquist@chromium.org\u003e\nCommit-Queue: Alison Gale \u003cagale@chromium.org\u003e\nOwners-Override: Alison Gale \u003cagale@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1287738}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b8be952f6cd08d311fd10d4de475fdac151e33f0\n" }, { "commit": "f5a9e5a34a7dd2fa812bc5ce5d059bc946f1a024", "tree": "cdbb372fd4684b785eec72a15216cdcc9b2d7e16", "parents": [ "8b30d97e5a4bc62329cacf9a47c161603b61c196" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Wed Feb 21 02:13:21 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 21 02:19:20 2024" }, "message": "cbor: make `DiagnosticWriter` a little smarter.\n\nThe DiagnosticWriter converts CBOR structures into debugging strings. It\napproximately caps the size of the returned strings to avoid huge\nmessages causing problems. But when a CBOR structure contains a huge\nbytestring, that can immediately hit the limit and cause all the\nrest of the structure to be ignored.\n\nThis change causes any bytestring that, when hex-encoded, is \u003e 87.5% of\nthe max output length, or which pushes the debugging string over the\nlimit, to be replaced by a placeholder: \"(x bytes)\".\n\nThis isn\u0027t perfect, it\u0027s still a greedy algorithm, but it\u0027s a modest\ndebugging improvement when there are large bytestrings in a message.\n\nChange-Id: I3a812d179a0f353336f86cab612ae517d9b572cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310565\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nAuto-Submit: Adam Langley \u003cagl@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1263095}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ec76a6e2a0b400e2283df7a290b166956cc24ac9\n" }, { "commit": "8b30d97e5a4bc62329cacf9a47c161603b61c196", "tree": "9bcf5180d3f3e339375984193e0887d54907fadc", "parents": [ "194f9332455bfb6ec4f1eaf27859a364436d597b" ], "author": { "name": "Jeff Yoon", "email": "jeffyoon@google.com", "time": "Wed Feb 07 14:38:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 07 14:54:42 2024" }, "message": "[buganizer] Migrate DIR_METADATA components/c*, components/d*\n\nMigrate all metadata files for components/c*, components/d*\nand mixins used by metadata files under components/c* and components/d*\n\nVerify components with http://b/components/{id} or at\ngo/chrome-on-buganizer-prod-components.\n\nBug: chromium:1518875\nChange-Id: Ibc96fe5c67fa946228ff1c5b49df4a09f7262d96\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5274124\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1257323}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 25ef32c94258c22f7070e35f4fa170326954bf14\n" }, { "commit": "194f9332455bfb6ec4f1eaf27859a364436d597b", "tree": "4996c14dd67520fb06ce39b245cefb05975b6c92", "parents": [ "6e9163ece66e4d7325d2a2cef5908598ba78f0e7" ], "author": { "name": "Lukasz Anforowicz", "email": "lukasza@chromium.org", "time": "Mon Jan 29 23:07:58 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 29 23:15:08 2024" }, "message": "`StrictNumeric` in `base::span::first(...)` and `last(...)`: Prep 1/N.\n\nThis CL prepares for using `StrictNumeric\u003csize_t\u003e` (instead of just\n`size_t`) as the type of a parameter taken by `base::span::first` and/or\n`base::span::last` methods. This is done by tweaking callers of these\nmethods to ensure that they either:\n\n* Pass a `size_t` value as an argument, or\n* Pass size as a compile-time argument (e.g. `some_span.first\u003c123\u003e()`)\n\nThis CL also opportunistically performs a similar change for some\ncallers of `base::span::subspan`.\n\nBug: 1490484\nChange-Id: I39e42114590e663a42b25d178e08ac598e8f45d0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5213529\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1253610}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 54cc8a274ba1e6c671aa64f26a11eb3c5754e2a8\n" }, { "commit": "6e9163ece66e4d7325d2a2cef5908598ba78f0e7", "tree": "fce12e94678f061f9bcd683ab514747bb4963c07", "parents": [ "213863fa091ef80676b9915a7af9f02e98d681c9" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Jan 26 20:26:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 26 20:39:23 2024" }, "message": "Rename {absl \u003d\u003e std}::optional in //components/\n\n#cleanup\n\nAutomated patch. This is a no-op. Please avoid, to assign unrelated\nbugs to this, as much as possible.\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias\nfor std::optional. We should migrate toward it.\n\nScript:\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"^components/\" \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n -e \"\\.mm\" \\\n | grep -v \\\n -e \"components/cast_streaming/browser/public/receiver_config.*\" \\\n -e \"components/power_metrics/*\" \\\n -e \"components/zucchini/patch_reader.*\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/g\"\n}\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place\" \"std::in_place\"\nreplace \"absl::in_place_t\" \"std::in_place_t\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\n\necho \"Formatting:\"\n\necho \"IncludeBlocks: Regroup\" \u003e\u003e \".clang-format\"\necho \"IncludeIsMainRegex: \\\"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\\\"\" \u003e\u003e \".clang-format\"\ngit cl format\ngit restore \".clang-format\"\n\ngit cl format\n```\n\nBug: chromium:1500249\nChange-Id: I34b45aba082a627d94fd9d3f9f994a60c64b40b1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5200092\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1252820}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c571efbef3ecfe66613d524ff39c58e25d18548c\n" }, { "commit": "213863fa091ef80676b9915a7af9f02e98d681c9", "tree": "458974bd712fea18110a4ff13721f4ee95953038", "parents": [ "c06a7051a083c84d8d5f211124f67191ba0dbb4e" ], "author": { "name": "Russ Hamilton", "email": "behamilton@google.com", "time": "Thu Jul 06 00:30:38 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 06 00:37:37 2023" }, "message": "Support for CBOR floating point values\n\nThis support is needed so that Chrome can process the response from\na FLEDGE Bidding and Auction server.\n\nBug: 1442274\nChange-Id: I4ab7bda0673b836b3541ba6c639070e18a6af9e9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4658097\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Russ Hamilton \u003cbehamilton@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@chromium.org\u003e\nCommit-Queue: Russ Hamilton \u003cbehamilton@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1166243}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 385541b1ee4f8807805da2b093785888d481dcb3\n" }, { "commit": "c06a7051a083c84d8d5f211124f67191ba0dbb4e", "tree": "c2867a569515e1be6b786f57cf49945affe881c5", "parents": [ "716a26d806963db5be03b8977102cf31b25019d7" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed May 31 15:29:50 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 31 15:41:44 2023" }, "message": "Use std::string::append(base::StringPiece) instead of decomposing\n\nstd::string_view is special because std::string knows how to integrate\nwith it. Happily, the STL uses a StringViewLike concept, so just by\nadding the implicit conversion, we can now write\nstr.append(piece) instead str.append(piece.data(), piece.size()).\n\nWhile small, this change keeps us using safe constructs. Clear these out\nso we get a little closer to being able to flag accesses of data() as\nunsafe. (That\u0027s a long ways off, but let\u0027s get the easy stuff out of the way.)\n\nA few places (content/web_test/renderer/blink_test_helpers.cc and\nnet/test/embedded_test_server/http2_connection.cc) were even wrong as\nthey used .data() without .size() on a string_view/StringPiece.\n\nBug: 691162\nChange-Id: Ib58e00db5f8c2527908c9e7971d28a0b53e68e65\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574755\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1151252}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2eb24c24d2fb7c302710ad7f00bcc32c9015770e\n" }, { "commit": "716a26d806963db5be03b8977102cf31b25019d7", "tree": "c83cae50ab3c64db5b5b4e5f23d4617b2bc5ac2e", "parents": [ "155584feaef6db20c311feabf711ccbb45b082ab" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Sep 13 19:22:36 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 19:37:16 2022" }, "message": "Update copyright headers in components/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c34.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: If6a3370b0b2849d889ce797596fe1ccbad2f3fe6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891619\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1046502}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ba1bad80dc22235693a0dd41fe55c0fd2dbdabd\n" }, { "commit": "155584feaef6db20c311feabf711ccbb45b082ab", "tree": "86771d1e4d4b9ac428fd208bac8b904ecd93518a", "parents": [ "f79dcbd8f28ef2e7000ded3beae86103ff79c354" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Mon Jun 13 17:22:56 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 13 17:32:18 2022" }, "message": "DanglingPtr: Mark all of them as untriaged [1/N]\n\nThis patch must be a no-op with all the common build flags.\n\nAdd the \"DanglingUntriaged\" raw_ptr annotation. It indicates a\nraw_ptr becomes dangling, and it should be triaged/fixed.\n\nThis annotates the one firing during content_browsertests.\nMultiple follow-up will complete the list, up until being able to\nenable dangling pointer detection on a bot.\n\nStats:\n- 175 DanglingUntriaged in code\n- 69 DanglingUntriaged in tests\n\nBug\u003d1291138\n\nChange-Id: I00771bd46403f90297aa5b972fdd1ddc23b18e07\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687960\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1013525}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4c9cdacbe6ebc7a1b5092c5e34fd1b932d4a0bdb\n" }, { "commit": "f79dcbd8f28ef2e7000ded3beae86103ff79c354", "tree": "bcfaf925f77dd972db50eeddda61695cf4be8448", "parents": [ "b45773c5d264e954a9e1c2262ebf5e521226c2d2" ], "author": { "name": "Jochen Eisinger", "email": "jochen@chromium.org", "time": "Fri May 13 14:13:06 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 13 14:29:47 2022" }, "message": "Remove myself from component OWNERS files\n\nChange-Id: I823960c629baa6a2295386fa4ce63277425ba5a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645215\nAuto-Submit: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCommit-Queue: Jochen Eisinger \u003cjochen@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1003109}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7987c351519cc8f3ebad48a68c8277f35d8945a0\n" }, { "commit": "b45773c5d264e954a9e1c2262ebf5e521226c2d2", "tree": "51242ce84a7d805e5a967a9c29ff7307095decca", "parents": [ "6e77f264ae173a65a0b6f425214fec83c84b6525" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Sat Feb 26 17:57:25 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 26 18:09:17 2022" }, "message": "Migrate base::{size,empty,data} to STL equivalents in //components.\n\nBug: 1299695\nChange-Id: Ia2ef2239d649b2a50569cad9b3f293ca23510b68\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3491962\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#975484}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7b7aaecca4adc6d0e8f87779d17774858896d02e\n" }, { "commit": "6e77f264ae173a65a0b6f425214fec83c84b6525", "tree": "e1cbd1dd0ef5d17ef811a88bef2f5ca23e3a0e2e", "parents": [ "70ef0c2594d76015c7521d92456fab36a04eb010" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Dec 09 23:43:38 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 09 23:54:07 2021" }, "message": "Fix \u003costream\u003e IWYU for use with DCHECK(), part 1.\n\nThis is the first batch of files to be updated to allow \u003costream\u003e\nto be removed from base/numerics/safe_conversions.h. Stop short of\nactually removing this until more compilation failures are addressed\nin the next CL.\n\n-- fix one \u003calgorithm\u003e include noticed along the way,\n\nBug: 1270812\nChange-Id: I65842b84fd7015bef8495a9f7755ee445c8eda72\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287683\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#950337}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b03f3f823379a761170457630f9d519b4de961bf\n" }, { "commit": "70ef0c2594d76015c7521d92456fab36a04eb010", "tree": "4ab258182a7f61caab66298420c2dcb0515e5a6f", "parents": [ "701da4c278c33bf7ee2d806862fc4bc0b12b259b" ], "author": { "name": "Keishi Hattori", "email": "keishi@chromium.org", "time": "Sat Nov 27 09:25:52 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Nov 27 09:41:44 2021" }, "message": "Rewrite most `Foo* field_` pointer fields to `raw_ptr\u003cFoo\u003e field_`.\n\nDO NOT REVERT (unless absolutely necessary)! Report build breaks to keishi@(APAC)/glazunov@(EMEA)/sebmarchand@(NA) as soon as you see them. Fixes are expected to be trivial.\n\nThis commit was generated automatically, by running the following script: tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh on commit fe74bc434e5b7e92d13a328362fcb6df15d8847e\n\nFor more information, see MiraclePtr One Pager [1], the PSA at chromium-dev@ [2], and the raw_ptr documentation in //base/memory/raw_ptr.md.\n\nFYI This CL does not enable MiraclePtr protection and we expect no behavior change from this.\n\n[1] https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg/edit?usp\u003dsharing\n[2] https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ\n\nBinary-Size: Increase of around 500kb was approved for MiraclePtr\nInclude-Ci-Only-Tests: true\nNo-Tree-Checks: true\nNo-Presubmit: true\nBug: 1272324, 1073933\nChange-Id: I05c86a83bbb4b3f4b017f361dd7f4e7437697f69\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305132\nCommit-Queue: Keishi Hattori \u003ckeishi@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#945735}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0e45c020c43b1a9f6d2870ff7f92b30a2f03a458\n" }, { "commit": "701da4c278c33bf7ee2d806862fc4bc0b12b259b", "tree": "596bfbde92a65c39fc9a0695f8b767cec735581f", "parents": [ "6ab897e95c1a5c30a4b5578accc4e57a5e3ea318" ], "author": { "name": "Anastasiia N", "email": "anastasiian@chromium.org", "time": "Fri Nov 19 15:11:32 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 19 15:18:21 2021" }, "message": "cbor: Add allow_and_canonicalize_out_of_order_keys flag\n\nAdd `allow_and_canonicalize_out_of_order_keys` flag to the Reader\nconfig. If it\u0027s set to `true`, CBOR reader will not check the key\norder.\n\nAdd a `DUPLICATE_KEY` error which is returned instead of the\n`KEY_OUT_OF_ORDER` error when CBOR map contains duplicate keys.\n\nBug: 1271599, b/204698553\nChange-Id: I678bf276b7bafd3c4d91c847b34c7a73eef6a61a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253307\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Kunihiko Sakamoto \u003cksakamoto@chromium.org\u003e\nReviewed-by: Maksim Ivanov \u003cemaxx@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: Jonathan Metzman \u003cmetzman@chromium.org\u003e\nCommit-Queue: Anastasiia N \u003canastasiian@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#943521}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a63c5fba77533e5a5eda7ad7cca18cf0101f6d83\n" }, { "commit": "6ab897e95c1a5c30a4b5578accc4e57a5e3ea318", "tree": "969fdfec974241bccbc2d496af03131335eeb13b", "parents": [ "fb311d5b7c3afa433d678f2b4508358e1b6c31ae" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Thu Nov 11 05:31:49 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 11 05:46:35 2021" }, "message": "Remove unused \"base/macros.h\" in components/\n\nRemoves `#include \"base/macros.h\"` from files in components/ that do not\ncontain `ignore_result(`.\n\nBug: 1010217\nChange-Id: Ic1ea0c59d63652bc896e80638a7ff919c872f1c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275012\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#940666}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b9e2c27ca6debc7796367f295888ba4701df62bf\n" }, { "commit": "fb311d5b7c3afa433d678f2b4508358e1b6c31ae", "tree": "ed170e84fc33b9e8ae8127944576e739f6952dfb", "parents": [ "a063c26807366b612514044238981a94a5d48aa0" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Mon Sep 20 22:43:27 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 20 22:50:59 2021" }, "message": "Replace DISALLOW_COPY_AND_ASSIGN in components/\n\nThis replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes\nwhere a local script is able to detect its insertion place (~Foo() is\npublic \u003d\u003e insert before this line).\n\nThis is incomplete as not all classes have a public ~Foo() declared, so\nnot all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.\n\nIWYU cleanup is left as a separate pass that is easier when these macros\ngo away.\n\nBug: 1010217\nChange-Id: I917bfbff1357e9e2cfe330d242feff6bb73e1bce\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3167004\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#923103}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 09c0182fae57e72abe62f1f1676458a443b8a3c9\n" }, { "commit": "a063c26807366b612514044238981a94a5d48aa0", "tree": "b259166a3a9d0c6dc334d5c52185300b344da716", "parents": [ "9d6c30f57acddb2e56c631f897df9146befc971a" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue May 25 17:43:06 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 25 17:49:48 2021" }, "message": "Swap from base/stl_util.h to cxx17_backports.h in components/ .cc files.\n\nbase::size() has been moved to base/cxx17_backports.h, so .cc files that\nuse base::size(), but no other function from base/stl_util.h, can\ndirectly include base/cxx17_backports.h and not base/stl_util.h.\n\nBug: 1210983\nChange-Id: I445378492ab1193ea76ca0c0b9958e9cb9c4ca0f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2915464\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Greg Kerr \u003ckerrnel@chromium.org\u003e\nCommit-Queue: Greg Kerr \u003ckerrnel@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#886365}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d073f65fc063f417cfabba9d5f5fbe4632320e05\n" }, { "commit": "9d6c30f57acddb2e56c631f897df9146befc971a", "tree": "37e9d1ccbff293c3c8e77fb0f3fc5d70d7436f33", "parents": [ "0f45c2c30d8091905981fec3b8e35425e0bdff12" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri May 21 20:18:20 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 21 20:24:44 2021" }, "message": "Remove unneeded base/stl_util.h includes in components/ and ui/.\n\nRepeatedly use grep to find all the files in components/ and ui/ that\nincludes base/stl_util.h but do not use any functions provided by\nbase/stl_util.h and base/cxx*_backports.h, and then remove the\nbase/stl_util.h include from them. Files that include base/stl_util.h,\nbut actually needs base/cxx*_backports.h, will be dealt with separately.\n\nBug: 1194078\nChange-Id: I4b598b64de3aab1e3ee61fed81a31e35913e2ed1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2912134\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#885638}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 74745fa888f8b3da749cc99b6f21eecd57ebd7df\n" }, { "commit": "0f45c2c30d8091905981fec3b8e35425e0bdff12", "tree": "be0c7634051468d290100140f857d14a5ec197a1", "parents": [ "9567ac5bb5cb12769c59558773d607ddb5429aea" ], "author": { "name": "Anton Bikineev", "email": "bikineev@chromium.org", "time": "Sat May 15 22:35:36 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat May 15 22:41:46 2021" }, "message": "components: Replace base::Optional and friends with absl counterparts\n\nThis replaces:\n- base::Optional -\u003e absl::optional\n- include \"base/optional.h\"\n -\u003e\n include \"third_party/abseil-cpp/absl/types/optional.h\"\n- base::nullopt -\u003e absl::nullopt\n- base::make_optional -\u003e absl::make_optional\n\nBug: 1202909\nChange-Id: If697b7bf69b199c1796f873eedca3359cdb48c64\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2897151\nCommit-Queue: Anton Bikineev \u003cbikineev@chromium.org\u003e\nOwners-Override: Anton Bikineev \u003cbikineev@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#883296}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1156b5f891de178171e71b9221a96bef1ced3d3b\n" }, { "commit": "9567ac5bb5cb12769c59558773d607ddb5429aea", "tree": "e7aa921f963bae2000f0201d8567b7e8d45e2daa", "parents": [ "8370d50242357be273b5c188f7261e28aa26e3f9" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Apr 30 07:25:43 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 30 07:37:00 2021" }, "message": "Delete unused STL includes from components/ headers.\n\nHeaders that do not contain \"std::\" do not need STL includes.\n\nThis CL is mechanically generated as follows:\n\nINCL\u003d\"algorithm|array|list|map|memory|queue|set|string|utility|vector\"\ngit ls-files components | grep \u0027\\.h$\u0027 | xargs grep -L std:: | \\\n xargs grep -El \"#include \u003c($INCL)\u003e$\" \u003e to_process.txt\n\nINCL_ESCAPED\u003d\"$(echo $INCL|sed \u0027s/|/\\\\|/g\u0027)\"\ncat to_process.txt | xargs sed -i \"/^#include \u003c\\($INCL_ESCAPED\\)\u003e$/d\"\ncat to_process.txt | xargs sed -i \u0027/^$/N;/^\\n$/D\u0027\n\nBug: 1200833\nChange-Id: I3dd65ac6d5b7d2542df285d752af0bd7a9bd965d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2845086\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#877818}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0bf0ff5b03feb5f59c0dddefdb18ac1a9f764aef\n" }, { "commit": "8370d50242357be273b5c188f7261e28aa26e3f9", "tree": "5d316670982ec2387767f8d7a38793d62ae4c8f3", "parents": [ "9ebffe85d039efdfd5afc12787ef42a510c7ac1a" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Apr 28 19:32:08 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 28 19:48:01 2021" }, "message": "[base] Remove base::StringPiece::as_string() usages.\n\nThis API is not compliant with absl::/std::string_view.\n\nBug: 1049498\nChange-Id: Iec01b784db7a7bb02318deca35a3e5f0f122d555\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2856712\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Jochen Eisinger \u003cjochen@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#877183}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 01167526dff908b2149ffdca2997090653244405\n" }, { "commit": "9ebffe85d039efdfd5afc12787ef42a510c7ac1a", "tree": "c6a9c874059b8980f6912163c3c55d4c7629ede3", "parents": [ "da40ce6bd63461a3561c600b0ef933b10f3b0a9c" ], "author": { "name": "Norman Rosas", "email": "normando@google.com", "time": "Tue Dec 01 08:55:04 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 01 09:09:55 2020" }, "message": "Added DIR_METADATA files to a batch of subfolders in //components/c…\nand also removed duplicated metadata from OWNERS files\n\nBug: 1113033\nChange-Id: I0400e86887a6c129a0b289c1179c570608b2846e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565538\nAuto-Submit: Norman Rosas \u003cnormando@google.com\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#832253}\nGitOrigin-RevId: e4357bad80d978e5dcef3d33187bceef929756ef\n" }, { "commit": "da40ce6bd63461a3561c600b0ef933b10f3b0a9c", "tree": "380a0e0680aaeb4af8ae69203ea4408acd80319e", "parents": [ "3287dea58206deb033aede1e8dd93523277ce0a6" ], "author": { "name": "Hans Wennborg", "email": "hans@chromium.org", "time": "Wed Jun 24 13:46:35 2020" }, "committer": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Thu Jun 25 21:24:39 2020" }, "message": "Remove/replace unnecessary includes of logging.h (components/)\n\nIf the file just needs the CHECK/CHECK_OP/NOTREACHED\nmacros, use the appropriate header for that instead.\nOr if logging.h is not needed at all, remove it.\n\nThis is both a nice cleanup (logging.h is a big header,\nand including it unnecessarily has compile-time costs),\nand part of the final step towards making logging.h no\nlonger include check.h and the others.\n\nBug: 1031540\nChange-Id: Ibeb7cc26e331161c5a1490b84ef5a59ecd122413\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254029\nAuto-Submit: Hans Wennborg \u003chans@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#781841}\nGitOrigin-RevId: 29c74d3fa1a05f3de62c3017b70c4e9e0d7fbbca\n" }, { "commit": "3287dea58206deb033aede1e8dd93523277ce0a6", "tree": "eed61e2badca7f2e60d052054fec15a84170ea9f", "parents": [ "1008f96b9c19f6c8bfcdffc59cd02cfb8f148a3c" ], "author": { "name": "Hans Wennborg", "email": "hans@chromium.org", "time": "Tue Apr 28 11:06:24 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 28 11:06:24 2020" }, "message": "Remove/replace unnecessary logging.h includes in .cc files (components)\n\nCHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved\nto the much smaller headers check.h, check_op.h, and notreached.h,\nrespectively.\n\nThis CL updates .cc files to use those headers instead when\npossible, with the purpose of saving compile time.\n\n(Split out from https://crrev.com/c/2164525 which also has\nnotes on how the change was generated.)\n\nBug: 1031540\nChange-Id: I1c0c8450be6320577ebebe39a2cb1abc692fe8b0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164613\nCommit-Queue: Hans Wennborg \u003chans@chromium.org\u003e\nAuto-Submit: Hans Wennborg \u003chans@chromium.org\u003e\nReviewed-by: Ted Choc \u003ctedchoc@chromium.org\u003e\nReviewed-by: Mike West \u003cmkwst@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#763287}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: df87046cb8ae4dbd62cda6e56d317016a6fa02c7\n" }, { "commit": "1008f96b9c19f6c8bfcdffc59cd02cfb8f148a3c", "tree": "9f611b0e6c55179cd50fd31cf3ca2e3bdd6b75a3", "parents": [ "a8bf294ec6bb82c74f5067b1b5fd57a0591de24d" ], "author": { "name": "Hans Wennborg", "email": "hans@chromium.org", "time": "Tue Apr 21 13:14:46 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 21 13:14:46 2020" }, "message": "logging.h related include-what-you-use (components/)\n\nFix code that was implicitly depending on logging.h or its\ndependencies.\n\nFor example, code that uses DISALLOW_COPY_AND_ASSIGN should\ninclude base/macros.h, but it currently happens to work if\nit pulls in logging.h directly or through some dependency.\n\nThis is part of refactoring the codebase to use\ncheck.h/check_op.h for the CHECK and CHECK_op macro\ninstead of logging.h.\n\nBug: 1031540\nChange-Id: Ibdaee90f6af0e9e2cb304274e6a326ea789613c5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156947\nAuto-Submit: Hans Wennborg \u003chans@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#760922}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 628c19e0b15abdbfb3a3c3b4cd9dcd80886c5fb9\n" }, { "commit": "a8bf294ec6bb82c74f5067b1b5fd57a0591de24d", "tree": "19aca46ed6524f6814e8e1242386fff2f8d01bf1", "parents": [ "735f2b605595022018bb9380a518cf8447342c14" ], "author": { "name": "Tiancong Wang", "email": "tcwang@google.com", "time": "Thu Apr 09 21:34:54 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 09 21:34:54 2020" }, "message": "cbor: Fix typedef struct naming for new CrOS Clang updates\n\nNew Clang update reports new warnings when C++ code provides\nanonymous typedef structs. The suggested solution is to either add\na tag to the name or use C++-style struct.\nThis patch fixes the warnings for the next toolchain update.\n\nBug: 1068297\nTest: Tested on Chrome OS\nChange-Id: I6863bc10d9094497b0d634ddee04891df8372906\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144413\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Tiancong Wang \u003ctcwang@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#758025}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: cce8f294b365b90ca15a57b37750411105c5f796\n" }, { "commit": "735f2b605595022018bb9380a518cf8447342c14", "tree": "fd52e26c767067eb35fc78f623a77e27ecf11f4c", "parents": [ "bfa4187baa2373480a4996ed84e36cddc8e734d5" ], "author": { "name": "Jan Wilken Dörrie", "email": "jdoerrie@chromium.org", "time": "Thu Mar 05 12:05:42 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 05 12:05:42 2020" }, "message": "[base] Remove const iterator member functions from span\n\nThis change implements the resolution of LWG issue 3320 by removing the\nmembers cbegin(), cend(), crbegin() and crend() from base::span. This\nwas done because std::cbegin(std::span\u003cT\u003e()) and std::span\u003cT\u003e().cbegin()\nreturned different results if T was non-const.\n\nNote that the nested const_iterator type is not yet removed from\nbase::span, as this breaks using it in gMock matchers like ElementsAre.\nThis will be addressed once gMock no longer requires the presence of\nthis nested type.\n\nReferences:\n* https://wg21.link/LWG3320\n* https://github.com/cplusplus/draft/commit/6faa9c\n\nTBR\u003ddcheng\n\nBug: 828324\nChange-Id: I21f8ffaa0c7183d6e63a087b73f271b677d13f3a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086231\nCommit-Queue: Jan Wilken Dörrie \u003cjdoerrie@chromium.org\u003e\nReviewed-by: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#747216}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bd122a20ab2e8a39ece1937e900bc68c57bc4a7c\n" }, { "commit": "bfa4187baa2373480a4996ed84e36cddc8e734d5", "tree": "3ece51bc18b1208d1770fc581396bdcfd63a468e", "parents": [ "e0ba28794fe55612a32dc52a1a11c23bee7354e9" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Feb 19 23:15:11 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Feb 19 23:15:11 2020" }, "message": "Remove more MSVC compat hacks\n\nIncluding PGO / WPO flags on Windows, which as far as I know aren\u0027t\nused by anyone.\n\nBug: 1053958\nChange-Id: I9479a10f921ca066ec2b702867ba687cdcb862ef\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062880\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: vmpstr \u003cvmpstr@chromium.org\u003e\nReviewed-by: Hans Wennborg \u003chans@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#742850}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 768272463b364dde7f4111e4a37630126c891215\n" }, { "commit": "e0ba28794fe55612a32dc52a1a11c23bee7354e9", "tree": "ce4f1b6d99d95c442aac75870d83271dd3b31cf4", "parents": [ "513ed504c32278d3d9ab751dc34e9ae38d53825e" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Thu Jan 16 18:36:53 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 16 18:36:53 2020" }, "message": "Reformat all gn files in /components/cbor.\n\n`gn format` recently changed its formatting behavior\nfor deps, source, and a few other elements when they\nare assigned (with \u003d) single-element lists to be consistent\nwith the formatting of updates (with +\u003d) with single-element.\n\nNow that we\u0027ve rolled in a GN binary with the change,\nreformat all files so that people don\u0027t get presubmit\nwarnings due to this.\n\nThis CL was uploaded by git cl split.\n\nR\u003dpalmer@chromium.org\n\nBug: 1041419\nChange-Id: I412b3025323df87cc68c59dfd79d5c2f83e5c242\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997997\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#732480}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 242df8b64d2a0ab5f057d1d4c76ea8537fdbb789\n" }, { "commit": "513ed504c32278d3d9ab751dc34e9ae38d53825e", "tree": "b5666403fa91cf6950e6a854ab1afddad6918b43", "parents": [ "07f21b52b562858edb1217c3288d4e32651b15f5" ], "author": { "name": "Tsuyoshi Horo", "email": "horo@chromium.org", "time": "Tue Jan 14 09:18:51 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 14 09:18:51 2020" }, "message": "Use WebBundleBuilder in WebBundleNetworkBrowserTest\n\nTo stop using fixed port of EmbeddedTestServer, this CL changes\nWebBundleNetworkBrowserTest to create a Web Bundle after starting the\nserver using WebBundleBuilder.\n\nBug: 1038346\nChange-Id: I92fb07c4d5e4c5a821c12a3091848a7f52e42f18\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989303\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Kunihiko Sakamoto \u003cksakamoto@chromium.org\u003e\nCommit-Queue: Tsuyoshi Horo \u003choro@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#731175}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2a1fd522086829e26991417d56628a937614dda4\n" }, { "commit": "07f21b52b562858edb1217c3288d4e32651b15f5", "tree": "c4c6c2f1dcaaf68fde6b3bdbd83f2128cfc2376e", "parents": [ "f1db80bd40233dde9f9080f95f77fe987640c0ad" ], "author": { "name": "Eric Foo", "email": "efoo@chromium.org", "time": "Sat Jul 27 00:32:35 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Jul 27 00:32:35 2019" }, "message": "OWNERS files updated with latest COMPONENT and TEAMS.\n\nThis is CL is generated by a script. Data is pulled from\nreview conducted in Q2 2019. See https://tinyurl.com/yxau5sc4\nfor context.\n\nBug: 977050\nChange-Id: I5601c87a350f2a7fb4d5682cc49b7cd5369ffa96\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700871\nReviewed-by: Ehsan Chiniforooshan \u003cchiniforooshan@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Eric Foo \u003cefoo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#681556}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2b97198dc9eb507a86718ddeee03bc724f885c7f\n" }, { "commit": "f1db80bd40233dde9f9080f95f77fe987640c0ad", "tree": "c4e5cc54817b93d6d33f292548a74454125bbad2", "parents": [ "4abc9fe8377ace6f8678a122da7bedce6f47fd17" ], "author": { "name": "Martin Kreichgauer", "email": "martinkr@google.com", "time": "Mon Jul 15 21:32:50 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jul 15 21:32:50 2019" }, "message": "fido: implement UTF-8 string fixup for credentialManagement\n\nAccording to the WebAuthn spec [0], when storing a resident credential\nsecurity keys may truncate certain strings in the\nPublicKeyCredentialRpEntity and PublicKeyCredentialUserEntity which may\npotentially make them invalid UTF-8. As a workaround, Chrome \"fixes up\"\nthese strings during CBOR parsing, i.e. it truncates the trailing\npartial UTF-8 sequence if there is one. This CL implements that for\nmessages from the authenticatorCredentialManagement CTAP sub-protocol.\n\nAlso adds the ability to write such truncated messages to cbor::Writer\nvia a |allow_invalid_utf8_for_testing_only| config option, analogous to\nthe |allow_invalid_utf8| option of the reader.\n\nBug: 955859\nChange-Id: I129718e91c57cdb165691253f2ffc629662c3b80\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700363\nCommit-Queue: Martin Kreichgauer \u003cmartinkr@google.com\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Adam Langley \u003cagl@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#677491}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2344a6462749d9515e03b7a63f02efc495536a83\n" }, { "commit": "4abc9fe8377ace6f8678a122da7bedce6f47fd17", "tree": "d26c1f10ac19811266fc02499a8688b99be4b5f1", "parents": [ "b6226d775a8113655345e0708787e052b7bcca78" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Mon Apr 22 22:21:33 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 22 22:21:33 2019" }, "message": "device/fido: handle user-info truncation.\n\nCTAP2 authenticators are permitted to truncate |name| and |displayName|\nfields at 64 bytes, and CTAP2 Yubikeys actually do so. However, this\ntruncation is done without any reference to the UTF-8 structure thus can\ntruncate in the middle of a multi-byte code-point. This makes future\nresponses from the authenticator potentially invalid CBOR because the\nstrings within are invalid UTF-8.\n\nThis change adds a facility to components/cbor to allow users of the\nparser to indicate that invalid UTF-8 (except in map keys) should be\nreturned as Values of type |INVALID_UTF8|.\n\nThis change also uses this facility when processing CTAP2 GetAssertion\nresponses to allow precisely the |name| and |displayName| fields to be\ntruncated at (or after) 64 bytes. Any partial, multi-byte sequence at\nthe end of the invalid UTF-8 is dropped.\n\nBug: 941120\nChange-Id: I1742128ee1e689fe400083404f17efc8afd55a97\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573091\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nReviewed-by: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nAuto-Submit: Adam Langley \u003cagl@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#652977}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 08718f7357da81ee2d6a31cc1b38569c55f008ff" }, { "commit": "b6226d775a8113655345e0708787e052b7bcca78", "tree": "67e7d4add01786435f1213ff402c3d7c311ad97c", "parents": [ "cbdca6e46abf6163d29a1eec523d02eeeadd0a08" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Apr 11 17:18:47 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 11 17:18:47 2019" }, "message": "device/fido: log outgoing CBOR messages.\n\nNow that we have chrome://device-log for FIDO things, add\n|cbor::ToString| to produce a human-readable version of CBOR structures\nand log outgoing CTAP2 requests.\n\nObviously we want to log the responses too, but leave that for a future\nchange in order to keep the size of this one limited.\n\nChange-Id: I10dde61f2cd038c09bd058e6a5fb0ac2ba06b6e0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555064\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Martin Kreichgauer \u003cmartinkr@google.com\u003e\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nAuto-Submit: Adam Langley \u003cagl@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#649936}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4851c48f8bbabbe0aa1de351e2829ae4b29f12cc" }, { "commit": "cbdca6e46abf6163d29a1eec523d02eeeadd0a08", "tree": "e064f1a44bf521ca2af1b7bf6758d3f1cc4a647b", "parents": [ "227e8c6669ae99c0bec4089db8532d4453255642" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Dec 25 23:08:31 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 25 23:08:31 2018" }, "message": "Use base::size rather than arraysize in components/.\n\nThis is purely a mechanical change; there is no intended behavior change.\n\nBUG\u003d837308\nTBR\u003dcaitkp@chromium.org\n\nChange-Id: I619a6261ee88f38ca591dbee11e1e92fba3d550c\nReviewed-on: https://chromium-review.googlesource.com/c/1390895\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#618889}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8171db7d9f54a54530858524dc4feb64556719b9" }, { "commit": "227e8c6669ae99c0bec4089db8532d4453255642", "tree": "8c5ec4cb93072ffde578a12a27f3eabbc8facdc2", "parents": [ "ea6697949b1399e15618f8b4830fe96f47e2e2df" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Mon Oct 29 19:23:16 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 29 19:23:16 2018" }, "message": "Rename CBOR files to match the newly renamed classes.\n\nCBOR{Reader|Writer|Value} were renamed in b4f12f9a to remove the “CBOR”\nprefix. This change reflects that in the filenames.\n\n(TBR for webpackage code since this is just renaming headers of\nan underlying library.)\n\nTBR\u003dkinuko@chromium.org\n\nChange-Id: I0262c827181fe8ab51cd08ad41fce14aa1aed331\nReviewed-on: https://chromium-review.googlesource.com/c/1303177\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#603583}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e0e46cdf7ba25f893a0ec409bdc01a95193ade36" }, { "commit": "ea6697949b1399e15618f8b4830fe96f47e2e2df", "tree": "a4d07aeffa50048f820d42b70d6a6cda9ee7310e", "parents": [ "d13905132a93c915cac9fa7982b8c90d00b50ac1" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Fri Oct 26 21:00:02 2018" }, "committer": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Fri Oct 26 21:00:02 2018" }, "message": "Remove CBOR prefix on CBOR{Reader|Writer|Value}.\n\nThese names are already in the “cbor” namespace, thus we end up using a\ncbor::CBORReader to get a cbor::CBORWriter and it\u0027s stuttery.\n\nI defer entirely to the owner\u0027s personal preferences here because the\nabove is obviously just my personal preference. But, thanks to\nclang-format, this only took five minutes to do.\n\n(TBR for web_package due to non-semantic change of underlying API.)\n\nTBR\u003dkinuko@chromium.org\n\nChange-Id: I8b34506ebe2aad2779548da0fb451ced61381ccf\nReviewed-on: https://chromium-review.googlesource.com/c/1289509\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nReviewed-by: Kinuko Yasuda \u003ckinuko@chromium.org\u003e\nReviewed-by: Jan Wilken Dörrie \u003cjdoerrie@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#603191}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b4f12f9a9f44e44d96abdf33dde83f1f84588efc" }, { "commit": "d13905132a93c915cac9fa7982b8c90d00b50ac1", "tree": "9405ef6f336ad807ba15c855e2920fb7b63392a7", "parents": [ "22f9f40a8764f0471cf250f6c800d203df2a0994" ], "author": { "name": "Chris Palmer", "email": "palmer@chromium.org", "time": "Fri Oct 19 18:58:46 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 19 18:58:46 2018" }, "message": "Worry over some nits in the CBOR reader.\n\nMake function names the same kinds of phrases (predicates: \"IsFoo\" and\n\"HasFoo\"); consistent use of curly braces to avoid visual confusion; use\npositive conditions (`DCHECK(success, ...)`).\n\nBug: 879237\nChange-Id: I0157f5676bddd7f8a806b5ece9e95792fbbe3ed0\nReviewed-on: https://chromium-review.googlesource.com/c/1289957\nCommit-Queue: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#601246}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 867100ad676118c091dbf583b3d2859bd1a186b7" }, { "commit": "22f9f40a8764f0471cf250f6c800d203df2a0994", "tree": "0b7a8c4cc82c8ff3fe5c232753ecb7a76556ff2c", "parents": [ "6f17813257182ceece9d088d4d31e0510e892a66" ], "author": { "name": "Chris Palmer", "email": "palmer@chromium.org", "time": "Mon Sep 17 22:44:05 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 17 22:44:05 2018" }, "message": "Don\u0027t `NOTREACHED` when handling malformed CBOR inputs.\n\nJust return `nullopt` and (crucially) set the error code without crashing.\n\nBug: 879237,884382\nChange-Id: I899ceb45648e130d5352a0a487c2d244f41a118d\nReviewed-on: https://chromium-review.googlesource.com/1228938\nCommit-Queue: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#591854}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 62403b01f1a3edbe0676d4b1f44fa5cb33013006" }, { "commit": "6f17813257182ceece9d088d4d31e0510e892a66", "tree": "be1f15f2e9cedee8579275df2f1f1dd7cc1e4e60", "parents": [ "5ab73b2cbdd406bb81d290d49ccdc4586c01f1e3" ], "author": { "name": "Chris Palmer", "email": "palmer@chromium.org", "time": "Fri Sep 14 22:39:46 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 14 22:39:46 2018" }, "message": "Fix a typo in a comment.\n\nBug: None\nTBR: rsesek,kinuko,kouhei\nChange-Id: I2dda1e9ed0bcdf822a3d310a1654fded31eb8038\nReviewed-on: https://chromium-review.googlesource.com/1227355\nReviewed-by: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nCommit-Queue: Chris Palmer \u003cpalmer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#591504}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8114479df891f7396885f2c95a4d10ffac568026" }, { "commit": "5ab73b2cbdd406bb81d290d49ccdc4586c01f1e3", "tree": "074b3e4a5f34b21782df815ff130e01327103456", "parents": [ "b94a000144b15fd63c2ba276ea191fc62c9007b7" ], "author": { "name": "Chris Palmer", "email": "palmer@chromium.org", "time": "Fri Sep 14 00:31:42 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 14 00:31:42 2018" }, "message": "Document `CBORReader`\u0027s limitations and their reasons.\n\nAlso resolve an API inconsistency: use Optional in 1 last place.\n\nBug: 879237\nChange-Id: I383cce38e47f06cedff99c05c3b2c1e1c67601f7\nReviewed-on: https://chromium-review.googlesource.com/1222916\nCommit-Queue: Chris Palmer \u003cpalmer@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#591228}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: be2d8dcbe045805779a972a32bc1433dd782b01a" }, { "commit": "b94a000144b15fd63c2ba276ea191fc62c9007b7", "tree": "e4e616e1c3e610c2084c09154815c2d2c7598bc4", "parents": [ "a7a55130746d049c6bf4d8fa23d59f5607af6f1e" ], "author": { "name": "Chris Palmer", "email": "palmer@chromium.org", "time": "Fri Aug 31 19:40:47 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 31 19:40:47 2018" }, "message": "Establish a new kind of SECURITY_OWNERS.\n\nLike IPC, but for code that has heightened memory-safety requirements.\n\nBug: None\nChange-Id: I9a7e2ba77b140e560f05cb850136697f3c5fb95a\nReviewed-on: https://chromium-review.googlesource.com/1196006\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Chris Palmer \u003cpalmer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#588126}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8cb52e2cbef3304647a4f5fafded1977f14d0dab" }, { "commit": "a7a55130746d049c6bf4d8fa23d59f5607af6f1e", "tree": "dd77fa04a44e8b57584bea0a370af8f9a9231e93", "parents": [ "c849f99e009170dcb86d2c54fe4f86de0e78291e" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Wed Aug 29 22:30:06 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 29 22:30:06 2018" }, "message": "Replace the CanConsume pattern in components/cbor.\n\nInstead, combine the length check with the reading. This means we don\u0027t need\nthe iterator access to match CanConsume calls above it.\n\nBug: none\nChange-Id: I541048c0f399d90650e87c3b995ac3a0ad9fccb6\nReviewed-on: https://chromium-review.googlesource.com/1195708\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#587337}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f0023516100fa817609337ff8a9ef08fc830e1b1" }, { "commit": "c849f99e009170dcb86d2c54fe4f86de0e78291e", "tree": "2d3a8048d4b4c7538dee37cf85f1f52687d7d7d3", "parents": [ "a5e0e8959df63f95314e11ef78cc830cb8ae9537" ], "author": { "name": "jdoerrie", "email": "jdoerrie@chromium.org", "time": "Thu Jun 14 21:22:19 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jun 14 21:22:19 2018" }, "message": "[fido] Use std::array for static sized containers\n\nThis change replaces a few contant sized vectors with their std::array\nequivalent. Furthermore, function parameters are updated to take static\nbase::spans, as this allows for greater flexibility and more efficiency,\neven for temporary values.\n\nBug: 838923\nChange-Id: I41ea47ad757aec0740adb2b71f72fd80b558e1e9\nReviewed-on: https://chromium-review.googlesource.com/1039748\nCommit-Queue: Jan Wilken Dörrie \u003cjdoerrie@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#567423}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b5384426df4a1d47c2438e7671b3469319ca93fc" }, { "commit": "a5e0e8959df63f95314e11ef78cc830cb8ae9537", "tree": "45cda6f61e1279db1b7030aa01c8dd5afd6576ae", "parents": [ "7644cabab3c411ce097fda3e9c1993b47e81fdcd" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Fri Apr 20 16:12:00 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 20 16:12:00 2018" }, "message": "Revert CBORReader::ReadDataItemHeader\n\nThis CL removes an unused method.\nWe originally planned to use the method to parse SignedExchanges, but they no longer require this.\n\nBug: 803774, 811717\nChange-Id: I5bd3f89891f046e4b6b1f128a63584cd78918266\nReviewed-on: https://chromium-review.googlesource.com/1017420\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#552350}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4fb1aebca0d4909e3fc560f0d6295823d98ba50f" }, { "commit": "7644cabab3c411ce097fda3e9c1993b47e81fdcd", "tree": "1593e8bc80464551cb91fd24a24dfb254ad61fd9", "parents": [ "efbe7eba8fa4fd2de0a9207c14a4d97f7b260537" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Apr 05 21:56:34 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 05 21:56:34 2018" }, "message": "cbor: use static checks to ensure that all cases are handled.\n\nBy removing the default case the compiler will throw an error if any CBOR type is unhandled.\n\nChange-Id: I6efd5c2fde89cf15ea4363cdc4d60b511979d6e8\nBug: 827564\nReviewed-on: https://chromium-review.googlesource.com/982736\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548574}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e8bea50f748c433acecb72c28493899c9f0722e7" }, { "commit": "efbe7eba8fa4fd2de0a9207c14a4d97f7b260537", "tree": "9cabb51a32d59a171b45aaa0e8ebe5f12d9c8a50", "parents": [ "0f17d681326c19976d0a4bfb242d4382b7bca4a4" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Apr 05 17:44:46 2018" }, "committer": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Apr 05 17:44:46 2018" }, "message": "cbor: comment that |SimpleValue| can be casted via |int|.\n\nThe code casts an |int| to a |SimpleValue|. Since |SimpleValue| is an\n|enum class|, this is safe. But it might not be for a traditional\n|enum|, so add a comment in case it flags for anyone else.\n\nChange-Id: Ifc50115d0ae9b047167f48b3d031b89d4494eda9\nReviewed-on: https://chromium-review.googlesource.com/982609\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548474}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ccb6298dd418397e170906ddb58b748960e35de7" }, { "commit": "0f17d681326c19976d0a4bfb242d4382b7bca4a4", "tree": "e872b159efe29e04bdfa50bb8359423dc2af829f", "parents": [ "8f74b25fb307d6352c9fb62f7d4ad5f43f0b650e" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Apr 05 15:24:04 2018" }, "committer": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Apr 05 15:24:04 2018" }, "message": "cbor: document some range bounds.\n\nIt took me a little while to figure out why the bounds in this function\nwere valid so I added some comments.\n\nChange-Id: I1244b966dbb6b7984dfc4fbceaa7ed6a2f369aa3\nReviewed-on: https://chromium-review.googlesource.com/984958\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548427}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bdc2b6900dc5a33bc44b60fc68dbe87bd04305de" }, { "commit": "8f74b25fb307d6352c9fb62f7d4ad5f43f0b650e", "tree": "aea503186417c73207c2ec068e988435c01da278", "parents": [ "9c3fb897a78bf677c6a41f5abac176d2126e07ee" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Wed Apr 04 17:23:41 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 04 17:23:41 2018" }, "message": "cbor: ensure that error codes are set iff parsing fails.\n\nBug: 827551\nChange-Id: I134199ca4538f469fc29d0b315a9e36f72e8df80\nReviewed-on: https://chromium-review.googlesource.com/982611\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548108}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: dc341a3c395d3b6424081b97da4470350ea6db14" }, { "commit": "9c3fb897a78bf677c6a41f5abac176d2126e07ee", "tree": "2dfd32f7d223c9ae520ee75d4ce4f7fd2376bbc6", "parents": [ "9326f123b554e7cfb5480f153cd5eb630c821df0" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Mon Apr 02 23:51:30 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 02 23:51:30 2018" }, "message": "cbor: have one Read function wrap the other.\n\nThis is a trivial matter but makes a bit more sense when I make the\ninner Read call a little more complex in the next change.\n\nChange-Id: Ie1c19e8760a598cf36914e634037c519e7f78d72\nReviewed-on: https://chromium-review.googlesource.com/990194\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#547569}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ea85530c8f5ea0ef423ccc352821c4efa11e44d7" }, { "commit": "9326f123b554e7cfb5480f153cd5eb630c821df0", "tree": "6c00476f7c2170759b5c757ef14db1a57098d0d8", "parents": [ "c1d4d0e3259b3c7c726427fb46b75a7f8347d1b0" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Mon Apr 02 22:53:46 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 02 22:53:46 2018" }, "message": "cbor: only need to check map value order.\n\nIf we enforce that each new map value is greater than the previous one\nthen that ensures that no duplicates are allowed without doing a lookup\nfor every insert.\n\nBug: 827551\nChange-Id: Idcc24b1070cc1707362f37a7f76198053882148a\nReviewed-on: https://chromium-review.googlesource.com/982610\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#547546}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 565f5a3f82c45eb2a0da9d56696dbd5e00d8938b" }, { "commit": "c1d4d0e3259b3c7c726427fb46b75a7f8347d1b0", "tree": "7bd8599015ba76ce850a39d1d7a89eeb2240a3a8", "parents": [ "a941ee50d597f4245b33119c18c2583f10a425a8" ], "author": { "name": "Adam Langley", "email": "agl@chromium.org", "time": "Thu Mar 29 18:35:31 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 29 18:35:31 2018" }, "message": "cbor: CanConsume already sets the error code.\n\n(So no need to set it again when it fails.)\n\nChange-Id: Icab4d89c5bacc84fd7e242d554d196d73cd0c520\nReviewed-on: https://chromium-review.googlesource.com/982608\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCommit-Queue: Adam Langley \u003cagl@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#546871}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 20b4b01a61945b162b7f9b95369ac3ff6523f94d" }, { "commit": "a941ee50d597f4245b33119c18c2583f10a425a8", "tree": "58aa1e4bd7aecfd1a16b0aacaba89eb7aa858a2b", "parents": [ "938c3901242c03bb37d7a9a86694f9ea0e34cb94" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Thu Feb 22 07:37:27 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 22 07:37:27 2018" }, "message": "CBORReader: CBOR array/map length should be treated as uint64_t\n\nBug: 813738, 813735\nChange-Id: I126e260f6ffb938264a40f92a286cf8488852f56\nReviewed-on: https://chromium-review.googlesource.com/927926\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#538378}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1e3136289954860e760caa4214124249c9549c59" }, { "commit": "938c3901242c03bb37d7a9a86694f9ea0e34cb94", "tree": "8e87dc9bd0afcb430aa144c77b1ca9c02834f43f", "parents": [ "b9523a751ad294ae59ca57cd6c3c943ef5ecd15b" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Tue Feb 20 05:36:19 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 20 05:36:19 2018" }, "message": "CBORReader: Add CBORReader::DecodeDataItemHeader()\n\nThis CL introduces *experimental* CBORReader::ReadDataItemHeader()\nmethod which allows streaming consuming of a large CBOR-encoded array.\n\nSince this API exposes CBORReader::DataItemHeader, which should conceptually be\nencapsulated inside CBORReader, the method should not be used widely, and\nshould be replaced by event-based CBORReader API.\n\nThe method is really only for short-term use from SignedExchangeParser, which\ndefinitely requires streaming parsing, but is currently unclear if it will\ncontinue to use CBOR encoding in long term.\n\nBug: 803774, 811717\nChange-Id: If37c70b034afcdecbe6e7793c95b4e1f60eee9d0\nReviewed-on: https://chromium-review.googlesource.com/920723\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#537721}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8abc3038960de43eb28bfe10cd6c058709dc9aad" }, { "commit": "b9523a751ad294ae59ca57cd6c3c943ef5ecd15b", "tree": "8505c788a4eafbef6e1a695743ce34fbd3e363fc", "parents": [ "7d9db348f448dd8075b5df4d31d1eb6fe15a7485" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Tue Feb 20 03:03:09 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 20 03:03:09 2018" }, "message": "CBORReader: Add alternate ::Read() which allows extraneous data\n\nBefore this CL, CBORReader::Read() rejected CBOR-encoded data with extra bytes\nat the end, and reported CBORReader::DecoderError::EXTRANEOUS_DATA.\n\nThis CL introduces alternative CBORReader::Read() which allows extraneous data\nfollowing CBOR-encoded data. Callers can tell the size of the CBOR-encoded data\nvia |num_consumed_bytes|.\n\nBug: 803774\nChange-Id: I154534f5049e94f3d20e67c4889e711332b1726f\nReviewed-on: https://chromium-review.googlesource.com/920802\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#537699}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7367cae631920f389d435f2058185c04345b89ec" }, { "commit": "7d9db348f448dd8075b5df4d31d1eb6fe15a7485", "tree": "56fbb8ee40398e3a7a9bb261cfc4cfb728a928e4", "parents": [ "e1cae4b6efd95c9b0587458e7cfa7b9cda911848" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Fri Feb 02 00:41:06 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Feb 02 00:41:06 2018" }, "message": "CBORReader: Add support for byte string keys.\n\nThis CL adds support for \"byte string\" keys in map.\n\nWe plan to use this to encode signed exchange \"Canonical CBOR\".\n\nBug: 803774\nChange-Id: Ia10a64781d66c66665a7b3c9749e93b46b30b108\nReviewed-on: https://chromium-review.googlesource.com/892939\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#533873}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2c9411e901bc4fb43693fcaf419e9ec9d49793d7" }, { "commit": "e1cae4b6efd95c9b0587458e7cfa7b9cda911848", "tree": "369513b9298320a26e620cfbb0d0bb42979fcbec", "parents": [ "87f9f0e6d5ad9210a09d8eb15f266dbaeb356157" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Thu Feb 01 17:28:03 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 01 17:28:03 2018" }, "message": "CBORWriter: Add support for byte string keys.\n\nThis CL:\n- clarifies that the map keys are sorted according to\n https://tools.ietf.org/html/rfc7049 section 3.9 (with errata 4409), and\n- add support for \"byte string\" keys in map.\n\nWe plan to use this to encode signed exchange \"Canonical CBOR\".\n\nBug: 803774, 808022\nChange-Id: I336a703efe6a3910f069034086b2c84e6a81a075\nReviewed-on: https://chromium-review.googlesource.com/895227\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#533714}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6d1629e73736f131582452f6d310dbd969972a79" }, { "commit": "87f9f0e6d5ad9210a09d8eb15f266dbaeb356157", "tree": "4f05531cb743523fcfda29dbb6ab35b02d376ad1", "parents": [ "5259aa3a490523bc10e6d568cba6e321e275e3b4" ], "author": { "name": "Kouhei Ueno", "email": "kouhei@chromium.org", "time": "Thu Feb 01 14:02:10 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 01 14:02:10 2018" }, "message": "Add CBORValue::{,Get}BytestringFromString\n\nThis CL introduce utility methods to convert/extract base::StringPiece\nto/from \"byte string\" CBOR Value.\n\nThe methods will be used to {en,de}code Signed Exchange CBOR, which uses\nmany ascii strings encoded as \"byte string\".\n\nBug: 803774\nChange-Id: I025dcc3ec86983c6cbd4e44c60b9abdfe135c26f\nReviewed-on: https://chromium-review.googlesource.com/892659\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCommit-Queue: Kouhei Ueno \u003ckouhei@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#533652}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c12b0b9ead385ad9cea3d92a3d3cca8cf95da2c8" }, { "commit": "5259aa3a490523bc10e6d568cba6e321e275e3b4", "tree": "7121b345be898bbf1e9e63da440e12c809b4ed5a", "parents": [ "6f724eba8d6e7a087f16db8de148a7d67bbcc9d7" ], "author": { "name": "Mostyn Bramley-Moore", "email": "mostynb@vewd.com", "time": "Wed Jan 24 12:27:41 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 24 12:27:41 2018" }, "message": "[jumbo] add missing include guards in //components\n\nAlso, move some existing include guards closer to the top of the file.\n\nChange-Id: I5a29c448a5fe300b9000ef54cd6b1a0bae7e5395\nReviewed-on: https://chromium-review.googlesource.com/882323\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#531507}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f64aa8ef5e65e2aae37de5ca3587e1d46dbb33c6" }, { "commit": "6f724eba8d6e7a087f16db8de148a7d67bbcc9d7", "tree": "6827ef4eb80963cfd71741b29c2baf5e11cf4db3", "parents": [ "06debadc1c3649fad943495ce8b63159dba93322" ], "author": { "name": "Jun Choi", "email": "hongjunchoi@chromium.org", "time": "Mon Jan 22 22:54:18 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 22 22:54:18 2018" }, "message": "Change CBORReader::Read parameter to base::span.\n\nChange |input_data| parameter of CBORReader::Read() from const\nstd::vector\u003cuint8_t\u003e\u0026 to base::span\u003cuint8_t const\u003e to prevent\nunnecessary intermediate copies.\n\nBug: 803605\nChange-Id: Id96df6a9c806bb39549f5696f73853faf71c3a94\nReviewed-on: https://chromium-review.googlesource.com/875006\nReviewed-by: Kim Paulhamus \u003ckpaulhamus@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nCommit-Queue: Jun Choi \u003chongjunchoi@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#531038}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 087c6d2d29c373ea015fbccde6a6dbb971f99fe4" }, { "commit": "06debadc1c3649fad943495ce8b63159dba93322", "tree": "212c9476c612bc48637c8055a82dda47ac816c57", "parents": [ "1dacf75748a88de8f79c6c88ef15ecfa155d991c" ], "author": { "name": "Jun Choi", "email": "hongjunchoi@chromium.org", "time": "Mon Jan 22 19:54:01 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 22 19:54:01 2018" }, "message": "Add methods for creating boolean simple values\n\nAdd helper methods and static factory methods for creating/accessing\nboolean CBOR simple values.\n\nBug: 803648\nChange-Id: If0297d149ee1b58022fcf6b92e521b28e5f9faff\nReviewed-on: https://chromium-review.googlesource.com/875196\nCommit-Queue: Jun Choi \u003chongjunchoi@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Jan Wilken Dörrie \u003cjdoerrie@chromium.org\u003e\nReviewed-by: Kim Paulhamus \u003ckpaulhamus@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#530958}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c" }, { "commit": "1dacf75748a88de8f79c6c88ef15ecfa155d991c", "tree": "be85ffe207bdcead51d9de004e851d9b5dd5689c", "parents": [], "author": { "name": "Jun Choi", "email": "hongjunchoi@chromium.org", "time": "Thu Dec 21 23:33:27 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 22 01:04:15 2017" }, "message": "Migrate CBOR to components\n\nMoved source code for CBORValue, CBORWriter, and CBORReader to //components\nfor that it can be reused for //device and //content/browser.\n\nBug: 794649\nChange-Id: Ic7ffc0158d5b28048bed810d742f0f385ed57b62\nReviewed-on: https://chromium-review.googlesource.com/825403\nCommit-Queue: Jun Choi \u003chongjunchoi@chromium.org\u003e\nReviewed-by: Balazs Engedy \u003cengedy@chromium.org\u003e\nReviewed-by: Max Moroz \u003cmmoroz@chromium.org\u003e\nReviewed-by: Jochen Eisinger \u003cjochen@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#525882}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9f1446c07055c28cb33555c9cd5b53c5eab0b45d" } ] }