Revert "Reland "Sets persistent shell on by default and adds flag to turn off"" This reverts commit 79f1c404812ce861f267f5cf9ae19ad284584b29. Reason for revert: telemetry_chromium_minidump_unittests fails on android-10-x86-rel Original change's description: > Reland "Sets persistent shell on by default and adds flag to turn off" > > This is a reland of commit db862914a87e0c1353fd29bee50dd1e0bffd7dda > > Revert was caused by a telemetry test case not recognizing the new arg. > This has been rectified in https://chromium-review.googlesource.com/c/catapult/+/7518411 > > > Original change's description: > > Sets persistent shell on by default and adds flag to turn off > > > > Persistent shell has been running for 2+ years, so turn it on by default and add a flag to be able to turn it off. > > If the current flag was turned on be default, there wouldn't be a way to turn off persistent shell. > > > > This CL, removing arg from builders, needs to land first: > > https://chromium-review.googlesource.com/c/chromium/src/+/7509733 > > > > Cleanup CL to remove arg where it is ignored. > > https://chromium-review.googlesource.com/c/chromium/src/+/7512327 > > > > Bug: 454390941 > > Change-Id: I26a16c5f4c732fd1aa3e585286c68de62f9ce64d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7512251 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Benjamin Joyce (Ben) <bjoyce@google.com> > > Cr-Commit-Position: refs/heads/main@{#1573905} > > Bug: 454390941 > Change-Id: I7df37827aa5cc199d6757b7da09108cebaf93c18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7517956 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Benjamin Joyce (Ben) <bjoyce@google.com> > Cr-Commit-Position: refs/heads/main@{#1575452} Bug: 454390941 Change-Id: Idf144928952aa2917e090eda1a98f77be4ad9f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7531678 Owners-Override: Luchen Peng <luchenpeng@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Luchen Peng <luchenpeng@google.com> Cr-Commit-Position: refs/heads/main@{#1576495} NOKEYCHECK=True GitOrigin-RevId: 66a9c9e71335f4533c123f4856398ff8db4c874a
//build contains:
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing, select //third_party subdirectories), but new dependencies tend to break these other projects, and so should be avoided.
Changes to //build should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.
//build/config - Common templates via .gni files.//build/toolchain - GN toolchain definitions.Other .py files - Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.Files referenced by //.gn:
//build/BUILDCONFIG.gn - Included by all BUILD.gn files.//build/secondary - An overlay for BUILD.gn files. Enables adding BUILD.gn to directories that live in sub-repositories.//build_overrides - Refer to //build_overrides/README.md.