[Settings Search] Fix disappearing title breadcrumb/search bar In the reported UI scenario, tapping on the search bar should trigger title breadcrumb update with the |mFirstVisibleTitleIndex| set to non-zero so that the breadcrumb would start showing from "Search Result". But this was not working as expected since the EmptyFragment is ignored in MultiColumnSettings#FragmentTracker. This CL fixes it by having EmptyFragment implement EmbeddableSettingsPage. Another issue that causes the search bar to disappear can be resolved by updating AllSiteSettings: - closes the local search when AllSiteSettings is stopped - Fixes a bug in #onStart that was not closing the local search With these changes, the local/settings search visibility state is now working as expected. Bug: 505299271, 505300628 Change-Id: If49692d258413455b04295001368f5cdf2e107fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789305 Reviewed-by: Moe Adel <[email protected]> Commit-Queue: Jinsuk Kim <[email protected]> Cr-Commit-Position: refs/heads/main@{#1620078}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.